diff options
| author | Sameeh Jubran <sameeh@daynix.com> | 2016-03-17 09:37:57 +0200 |
|---|---|---|
| committer | Jason Wang <jasowang@redhat.com> | 2016-03-30 08:57:36 +0800 |
| commit | 74004e8ce4306f51f593a99d175a1e1f0453deba (patch) | |
| tree | e86c84ba9f1223189e617ad1046ca44106d90eeb /hw/net/e1000.c | |
| parent | 9fd3c5d556b21e0020d98d4695c84a655aa056f0 (diff) | |
| download | qemu-74004e8ce4306f51f593a99d175a1e1f0453deba.tar.gz | |
e1000: Fixing interrupts pace.
This patch introduces an upper bound for number of interrupts
per second. Without this bound an interrupt storm can occur as
it has been observed on Windows 10 when disabling the device.
According to the SPEC - Intel PCI/PCI-X Family of Gigabit
Ethernet Controllers Software Developer's Manual, section
13.4.18 - the Ethernet controller guarantees a maximum
observable interrupt rate of 7813 interrupts/sec. If there is
no upper bound this could lead to an interrupt storm by e1000
(when mit_delay < 500) causing interrupts to fire at a very high
pace.
Thus if mit_delay < 500 then the delay should be set to the
minimum delay possible which is 500. This can be calculated
easily as follows:
Interval = 10^9 / (7813 * 256) = 500.
Signed-off-by: Sameeh Jubran <sameeh@daynix.com>
Signed-off-by: Jason Wang <jasowang@redhat.com>
Diffstat (limited to 'hw/net/e1000.c')
| -rw-r--r-- | hw/net/e1000.c | 8 |
1 files changed, 8 insertions, 0 deletions
diff --git a/hw/net/e1000.c b/hw/net/e1000.c index 0387fa0646..09b9ab5377 100644 --- a/hw/net/e1000.c +++ b/hw/net/e1000.c @@ -357,6 +357,14 @@ set_interrupt_cause(E1000State *s, int index, uint32_t val) } mit_update_delay(&mit_delay, s->mac_reg[ITR]); + /* + * According to e1000 SPEC, the Ethernet controller guarantees + * a maximum observable interrupt rate of 7813 interrupts/sec. + * Thus if mit_delay < 500 then the delay should be set to the + * minimum delay possible which is 500. + */ + mit_delay = (mit_delay < 500) ? 500 : mit_delay; + if (mit_delay) { s->mit_timer_on = 1; timer_mod(s->mit_timer, qemu_clock_get_ns(QEMU_CLOCK_VIRTUAL) + |