summaryrefslogtreecommitdiff
path: root/hw/net/rocker
diff options
context:
space:
mode:
authorScott Feldman <sfeldma@gmail.com>2015-07-01 03:33:08 -0700
committerStefan Hajnoczi <stefanha@redhat.com>2015-07-07 13:13:22 +0100
commitd1a88c96b7f94c8e12c07518f55fce8873e814d0 (patch)
tree0f1d7c62edf952bc2825beaf425594fcd56ba3b0 /hw/net/rocker
parent66851f640b73a5a84160ee6ab19ab429f68bbb9f (diff)
downloadqemu-d1a88c96b7f94c8e12c07518f55fce8873e814d0.tar.gz
rocker: fix misplaced break statement
Premature break in switch case block. This particular case (group L2 rewrite) will be used for L2 LAG and L3 ECMP support, neither of which are enabled in the guest driver at this time, but are under development. Signed-off-by: Scott Feldman <sfeldma@gmail.com> Reported-by: Paolo Bonzini <pbonzini@redhat.com> Message-id: 1435746792-41278-2-git-send-email-sfeldma@gmail.com Signed-off-by: Stefan Hajnoczi <stefanha@redhat.com>
Diffstat (limited to 'hw/net/rocker')
-rw-r--r--hw/net/rocker/rocker_of_dpa.c2
1 files changed, 1 insertions, 1 deletions
diff --git a/hw/net/rocker/rocker_of_dpa.c b/hw/net/rocker/rocker_of_dpa.c
index b25a17d6d7..02b3896a76 100644
--- a/hw/net/rocker/rocker_of_dpa.c
+++ b/hw/net/rocker/rocker_of_dpa.c
@@ -2525,7 +2525,6 @@ static void of_dpa_group_fill(void *key, void *value, void *user_data)
ngroup->has_set_vlan_id = true;
ngroup->set_vlan_id = ntohs(group->l2_rewrite.vlan_id);
}
- break;
if (memcmp(group->l2_rewrite.src_mac.a, zero_mac.a, ETH_ALEN)) {
ngroup->has_set_eth_src = true;
ngroup->set_eth_src =
@@ -2536,6 +2535,7 @@ static void of_dpa_group_fill(void *key, void *value, void *user_data)
ngroup->set_eth_dst =
qemu_mac_strdup_printf(group->l2_rewrite.dst_mac.a);
}
+ break;
case ROCKER_OF_DPA_GROUP_TYPE_L2_FLOOD:
case ROCKER_OF_DPA_GROUP_TYPE_L2_MCAST:
ngroup->has_vlan_id = true;