diff options
| author | Peter Wu <peter@lekensteyn.nl> | 2014-03-15 17:34:06 +0100 |
|---|---|---|
| committer | Peter Wu <peter@lekensteyn.nl> | 2014-03-16 00:10:06 +0100 |
| commit | 43d6464d410136f1c083a6df263bb71319eb2244 (patch) | |
| tree | d71312c0b19da4394f8cb974d7229000616ea52f /hw/usb/dev-unifying.c | |
| parent | 8002d8a662d4db7cc8c833ac960179e05f1280ed (diff) | |
| download | qemu-43d6464d410136f1c083a6df263bb71319eb2244.tar.gz | |
usbdump: fail early if dump file is not available
This allows for less less checking by the consumer and avoids
unnecessary work if the capture cannot be written anyway.
Signed-off-by: Peter Wu <peter@lekensteyn.nl>
Diffstat (limited to 'hw/usb/dev-unifying.c')
| -rw-r--r-- | hw/usb/dev-unifying.c | 8 |
1 files changed, 2 insertions, 6 deletions
diff --git a/hw/usb/dev-unifying.c b/hw/usb/dev-unifying.c index 48479a07f4..68e2928b60 100644 --- a/hw/usb/dev-unifying.c +++ b/hw/usb/dev-unifying.c @@ -363,9 +363,7 @@ static void usb_ltunify_handle_control(USBDevice *dev, USBPacket *p, int desc_len = 0; const uint8_t *desc = NULL; - if (s->usb_dump_state) { - usb_dump_submit(s->usb_dump_state, p); - } + usb_dump_submit(s->usb_dump_state, p); /* handle basic requests such as DeviceRequest | USB_REQ_GET_DESCRIPTOR */ ret = usb_desc_handle_control(dev, p, request, value, index, length, data); @@ -409,9 +407,7 @@ static void usb_ltunify_handle_control(USBDevice *dev, USBPacket *p, } data_ready: - if (s->usb_dump_state) { - usb_dump_complete(s->usb_dump_state, p); - } + usb_dump_complete(s->usb_dump_state, p); } /* handle interrupt transfers (this device does not have a bulk/iso endpoint */ |