diff options
| author | Michael S. Tsirkin <mst@redhat.com> | 2018-01-24 19:19:41 +0200 |
|---|---|---|
| committer | Michael S. Tsirkin <mst@redhat.com> | 2018-01-24 19:20:19 +0200 |
| commit | ce3a9eaff4e5f29514dba35a001894cb7a238e07 (patch) | |
| tree | 2d4e52c7005a744d528f2f923ce7a72f08c50b68 /hw/virtio | |
| parent | 52483b067cce4a88ffbf8fbeea26de7549d2ad23 (diff) | |
| download | qemu-ce3a9eaff4e5f29514dba35a001894cb7a238e07.tar.gz | |
Revert "virtio: improve virtio devices initialization time"
This reverts commit 6f0bb230722931d17fb284eee8efd40b9d653822.
This reverts commit f87d72f5c5bff0837d409a56bd34f439a90119ca as that is
reported to break cleanup and migration.
Cc: Gal Hammer <ghammer@redhat.com>
Cc: Sitong Liu <siliu@redhat.com>
Cc: Xiaoling Gao <xiagao@redhat.com>
Suggested-by: Greg Kurz <groug@kaod.org>
Suggested-by: Paolo Bonzini <pbonzini@redhat.com>
Reported-by: Jose Ricardo Ziviani <joserz@linux.vnet.ibm.com>
Reported-by: Daniel Henrique Barboza <danielhb@linux.vnet.ibm.com>
Diffstat (limited to 'hw/virtio')
| -rw-r--r-- | hw/virtio/virtio.c | 5 |
1 files changed, 0 insertions, 5 deletions
diff --git a/hw/virtio/virtio.c b/hw/virtio/virtio.c index 3ac3491bee..d6002ee550 100644 --- a/hw/virtio/virtio.c +++ b/hw/virtio/virtio.c @@ -2574,7 +2574,6 @@ static int virtio_device_start_ioeventfd_impl(VirtIODevice *vdev) VirtioBusState *qbus = VIRTIO_BUS(qdev_get_parent_bus(DEVICE(vdev))); int n, r, err; - memory_region_transaction_begin(); for (n = 0; n < VIRTIO_QUEUE_MAX; n++) { VirtQueue *vq = &vdev->vq[n]; if (!virtio_queue_get_num(vdev, n)) { @@ -2597,7 +2596,6 @@ static int virtio_device_start_ioeventfd_impl(VirtIODevice *vdev) } event_notifier_set(&vq->host_notifier); } - memory_region_transaction_commit(); return 0; assign_error: @@ -2611,7 +2609,6 @@ assign_error: r = virtio_bus_set_host_notifier(qbus, n, false); assert(r >= 0); } - memory_region_transaction_commit(); return err; } @@ -2628,7 +2625,6 @@ static void virtio_device_stop_ioeventfd_impl(VirtIODevice *vdev) VirtioBusState *qbus = VIRTIO_BUS(qdev_get_parent_bus(DEVICE(vdev))); int n, r; - memory_region_transaction_begin(); for (n = 0; n < VIRTIO_QUEUE_MAX; n++) { VirtQueue *vq = &vdev->vq[n]; @@ -2639,7 +2635,6 @@ static void virtio_device_stop_ioeventfd_impl(VirtIODevice *vdev) r = virtio_bus_set_host_notifier(qbus, n, false); assert(r >= 0); } - memory_region_transaction_commit(); } void virtio_device_stop_ioeventfd(VirtIODevice *vdev) |