diff options
| author | Luke Shumaker <lukeshu@parabola.nu> | 2017-12-28 13:08:12 -0500 |
|---|---|---|
| committer | Laurent Vivier <laurent@vivier.eu> | 2018-03-13 15:04:01 +0100 |
| commit | 8c17d862b3cefed23a62c4e09d4b3f1f04a38631 (patch) | |
| tree | 64e581e032a98931606dc2e0f3d11970eb2cd9bc /linux-user | |
| parent | aac362e46f13305fd9b4abfe7d0068595d4555f2 (diff) | |
| download | qemu-8c17d862b3cefed23a62c4e09d4b3f1f04a38631.tar.gz | |
linux-user: init_guest_space: Add a comment about search strategy
Signed-off-by: Luke Shumaker <lukeshu@parabola.nu>
Message-Id: <20171228180814.9749-10-lukeshu@lukeshu.com>
Reviewed-by: Peter Maydell <peter.maydell@linaro.org>
Signed-off-by: Laurent Vivier <laurent@vivier.eu>
Diffstat (limited to 'linux-user')
| -rw-r--r-- | linux-user/elfload.c | 4 |
1 files changed, 4 insertions, 0 deletions
diff --git a/linux-user/elfload.c b/linux-user/elfload.c index 5c64299961..9d10a5f592 100644 --- a/linux-user/elfload.c +++ b/linux-user/elfload.c @@ -1910,6 +1910,10 @@ unsigned long init_guest_space(unsigned long host_start, * happen often. Probably means we got unlucky and host * address space randomization put a shared library somewhere * inconvenient. + * + * This is probably a good strategy if host_start, but is + * probably a bad strategy if not, which means we got here + * because of trouble with ARM commpage setup. */ munmap((void *)real_start, real_size); current_start += qemu_host_page_size; |