summaryrefslogtreecommitdiff
path: root/main-loop.h
diff options
context:
space:
mode:
authorDavid Gibson <david@gibson.dropbear.id.au>2012-11-26 12:33:52 +1100
committerMichael Roth <mdroth@linux.vnet.ibm.com>2012-12-03 15:02:28 -0600
commitbf47da47dbcbf2c90119ba0bd45560d5b2f1dd13 (patch)
treec7e9663acdf3282b805e8a79da91a47944e28b7b /main-loop.h
parentea08f3a4e25fe76d42a186152949516c2a63a46b (diff)
downloadqemu-bf47da47dbcbf2c90119ba0bd45560d5b2f1dd13.tar.gz
virtio-scsi: Fix subtle (guest) endian bug
The virtio-scsi config space is, by specification, in guest endian (which is ill-defined, but there you go). In virtio_scsi_get_config() we set up all the fields in there, using stl_raw(). Which is a problem for the max_channel and max_target fields, which are 16-bit, not 32-bit. For little-endian targets we get away with it by accident, since the first two bytes will still be correct, and the extra two bytes written (with zeroes) will be overwritten correctly by the next store. But for big-endian guests, this means the max_target field ends up as zero, which means the guest will only recognize a single disk on the virtio-scsi bus. This patch fixes the problem. Cc: Paolo Bonzini <pbonzini@redhat.com> Cc: Paul 'Rusty' Russell <rusty@rustcorp.com.au> Signed-off-by: David Gibson <david@gibson.dropbear.id.au> Signed-off-by: Paolo Bonzini <pbonzini@redhat.com> (cherry picked from commit 863d1050c96cff91dd478767c0da9cc288575919) Signed-off-by: Michael Roth <mdroth@linux.vnet.ibm.com>
Diffstat (limited to 'main-loop.h')
0 files changed, 0 insertions, 0 deletions