summaryrefslogtreecommitdiff
path: root/qga
diff options
context:
space:
mode:
authorGreg Kurz <groug@kaod.org>2017-11-17 13:56:48 +0100
committerDavid Gibson <david@gibson.dropbear.id.au>2017-11-20 10:10:56 +1100
commit82512483940c756e2db1bd67ea91b02bc29c5e01 (patch)
treeaa322c3b16b320b549894dda1e19223a04bca282 /qga
parent7abd43baec0649002d32bbb1380e936bec6f5867 (diff)
downloadqemu-82512483940c756e2db1bd67ea91b02bc29c5e01.tar.gz
spapr: reset DRCs after devices
A DRC with a pending unplug request releases its associated device at machine reset time. In the case of LMB, when all DRCs for a DIMM device have been reset, the DIMM gets unplugged, causing guest memory to disappear. This may be very confusing for anything still using this memory. This is exactly what happens with vhost backends, and QEMU aborts with: qemu-system-ppc64: used ring relocated for ring 2 qemu-system-ppc64: qemu/hw/virtio/vhost.c:649: vhost_commit: Assertion `r >= 0' failed. The issue is that each DRC registers a QEMU reset handler, and we don't control the order in which these handlers are called (ie, a LMB DRC will unplug a DIMM before the virtio device using the memory on this DIMM could stop its vhost backend). To avoid such situations, let's reset DRCs after all devices have been reset. Reported-by: Mallesh N. Koti <mallesh@linux.vnet.ibm.com> Signed-off-by: Greg Kurz <groug@kaod.org> Reviewed-by: Daniel Henrique Barboza <danielhb@linux.vnet.ibm.com> Reviewed-by: Michael Roth <mdroth@linux.vnet.ibm.com> Signed-off-by: David Gibson <david@gibson.dropbear.id.au>
Diffstat (limited to 'qga')
0 files changed, 0 insertions, 0 deletions