diff options
| author | Markus Armbruster <armbru@redhat.com> | 2018-02-01 12:18:31 +0100 |
|---|---|---|
| committer | Markus Armbruster <armbru@redhat.com> | 2018-02-09 13:50:17 +0100 |
| commit | e688df6bc4549f28534cdb001f168b8caae55b0c (patch) | |
| tree | d77cfea92ccc7318f7ac82b75a72821d06b5dc75 /qga | |
| parent | 522ece32d214bd4b086821c4350c2aebe5587878 (diff) | |
| download | qemu-e688df6bc4549f28534cdb001f168b8caae55b0c.tar.gz | |
Include qapi/error.h exactly where needed
This cleanup makes the number of objects depending on qapi/error.h
drop from 1910 (out of 4743) to 1612 in my "build everything" tree.
While there, separate #include from file comment with a blank line,
and drop a useless comment on why qemu/osdep.h is included first.
Reviewed-by: Eric Blake <eblake@redhat.com>
Reviewed-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
Signed-off-by: Markus Armbruster <armbru@redhat.com>
Message-Id: <20180201111846.21846-5-armbru@redhat.com>
[Semantic conflict with commit 34e304e975 resolved, OSX breakage fixed]
Diffstat (limited to 'qga')
| -rw-r--r-- | qga/commands-posix.c | 1 | ||||
| -rw-r--r-- | qga/commands-win32.c | 2 | ||||
| -rw-r--r-- | qga/commands.c | 1 | ||||
| -rw-r--r-- | qga/main.c | 2 | ||||
| -rw-r--r-- | qga/vss-win32.c | 1 |
5 files changed, 7 insertions, 0 deletions
diff --git a/qga/commands-posix.c b/qga/commands-posix.c index e809e382eb..88807f3c78 100644 --- a/qga/commands-posix.c +++ b/qga/commands-posix.c @@ -18,6 +18,7 @@ #include <dirent.h> #include "qga/guest-agent-core.h" #include "qga-qmp-commands.h" +#include "qapi/error.h" #include "qapi/qmp/qerror.h" #include "qemu/queue.h" #include "qemu/host-utils.h" diff --git a/qga/commands-win32.c b/qga/commands-win32.c index d79974f212..bedae32957 100644 --- a/qga/commands-win32.c +++ b/qga/commands-win32.c @@ -14,6 +14,7 @@ #ifndef _WIN32_WINNT # define _WIN32_WINNT 0x0600 #endif + #include "qemu/osdep.h" #include <wtypes.h> #include <powrprof.h> @@ -34,6 +35,7 @@ #include "qga/guest-agent-core.h" #include "qga/vss-win32.h" #include "qga-qmp-commands.h" +#include "qapi/error.h" #include "qapi/qmp/qerror.h" #include "qemu/queue.h" #include "qemu/host-utils.h" diff --git a/qga/commands.c b/qga/commands.c index ff89e805cf..6d710dbb20 100644 --- a/qga/commands.c +++ b/qga/commands.c @@ -13,6 +13,7 @@ #include "qemu/osdep.h" #include "qga/guest-agent-core.h" #include "qga-qmp-commands.h" +#include "qapi/error.h" #include "qapi/qmp/qerror.h" #include "qemu/base64.h" #include "qemu/cutils.h" diff --git a/qga/main.c b/qga/main.c index 62a62755bd..57083ca10c 100644 --- a/qga/main.c +++ b/qga/main.c @@ -10,6 +10,7 @@ * This work is licensed under the terms of the GNU GPL, version 2 or later. * See the COPYING file in the top-level directory. */ + #include "qemu/osdep.h" #include <getopt.h> #include <glib/gstdio.h> @@ -23,6 +24,7 @@ #include "qga/guest-agent-core.h" #include "qemu/module.h" #include "qapi/qmp/qerror.h" +#include "qapi/error.h" #include "qapi/qmp/dispatch.h" #include "qga/channel.h" #include "qemu/bswap.h" diff --git a/qga/vss-win32.c b/qga/vss-win32.c index dcb27567bb..0199c2a792 100644 --- a/qga/vss-win32.c +++ b/qga/vss-win32.c @@ -12,6 +12,7 @@ #include "qemu/osdep.h" #include <windows.h> +#include "qapi/error.h" #include "qemu/error-report.h" #include "qga/guest-agent-core.h" #include "qga/vss-win32.h" |