summaryrefslogtreecommitdiff
path: root/qmp.c
diff options
context:
space:
mode:
authorLaurent Vivier <lvivier@redhat.com>2017-04-14 10:37:16 +0200
committerMarkus Armbruster <armbru@redhat.com>2017-04-21 07:18:34 +0200
commitd28fca153bb27ff965b9eb26d73327fa4d2402c8 (patch)
tree0f259ed171b28bf389747699e0d3a4dd12c347d7 /qmp.c
parent40fda982f2e887f7d5cc36b8a7e3b5a07a1e6704 (diff)
downloadqemu-d28fca153bb27ff965b9eb26d73327fa4d2402c8.tar.gz
versatile: remove cannot_destroy_with_object_finalize_yet
cannot_destroy_with_object_finalize_yet was added by 4c315c2 ("qdev: Protect device-list-properties against broken devices") because "realview_pci" and "versatile_pci" were hanging during "device-list-properties" cleanup (an infinite loop in bus_unparent()). We have this problem because the child is not removed from the list of the PCI bus children because it has no defined parent: qdev_set_parent_bus() set the device parent_bus pointer to bus, and adds the device in the bus children list, but doesn't update the device parent pointer. To fix the problem, move all the involved parts to the realize function. Signed-off-by: Laurent Vivier <lvivier@redhat.com> Message-Id: <20170414083717.13641-4-lvivier@redhat.com> Reviewed-by: Markus Armbruster <armbru@redhat.com> Acked-by: Peter Maydell <peter.maydell@linaro.org> [Commit message tweaked] Signed-off-by: Markus Armbruster <armbru@redhat.com>
Diffstat (limited to 'qmp.c')
0 files changed, 0 insertions, 0 deletions