diff options
| author | Kevin Wolf <kwolf@redhat.com> | 2017-08-04 12:44:22 +0200 |
|---|---|---|
| committer | Kevin Wolf <kwolf@redhat.com> | 2017-08-08 15:19:16 +0200 |
| commit | 809eb70ed6cfbfb6c198a25aed036849cc11944d (patch) | |
| tree | 0bbb77953f6c7665588c637e55f51e2b3f2d5bcf /tests | |
| parent | 82346685b8cc0537819a3cf7fe2303b55b5f825f (diff) | |
| download | qemu-809eb70ed6cfbfb6c198a25aed036849cc11944d.tar.gz | |
block/null: Remove 'filename' option
This option was only added to allow 'null-co://' and 'null-aio://' as
filenames, its value never served any actual purpose and was ignored.
Nevertheless it was accepted as '-drive driver=null,filename=foo'.
The correct way to enable the protocol prefixes (and that without adding
a useless -drive option) is implementing .bdrv_parse_filename. This is
what this patch does.
Technically, this is an incompatible change, but the null block driver
is only used for benchmarking, testing and debugging, and an option
without effect isn't likely to be used by anyone anyway, so no bad
effects are to be expected.
Reported-by: Markus Armbruster <armbru@redhat.com>
Signed-off-by: Kevin Wolf <kwolf@redhat.com>
Reviewed-by: Eric Blake <eblake@redhat.com>
Reviewed-by: Jeff Cody <jcody@redhat.com>
Reviewed-by: Stefan Hajnoczi <stefanha@redhat.com>
Diffstat (limited to 'tests')
| -rw-r--r-- | tests/qemu-iotests/136 | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/tests/qemu-iotests/136 b/tests/qemu-iotests/136 index 635b977552..4b994897af 100644 --- a/tests/qemu-iotests/136 +++ b/tests/qemu-iotests/136 @@ -75,7 +75,7 @@ sector = "%d" drive_args.append("stats-account-failed=%s" % (self.account_failed and "on" or "off")) self.create_blkdebug_file() - self.vm = iotests.VM().add_drive('blkdebug:%s:%s ' % + self.vm = iotests.VM().add_drive('blkdebug:%s:%s' % (blkdebug_file, self.test_img), ','.join(drive_args)) self.vm.launch() |