diff options
| author | Guy Harris <guy@alum.mit.edu> | 2015-11-24 21:38:05 -0800 |
|---|---|---|
| committer | Guy Harris <guy@alum.mit.edu> | 2015-11-25 05:38:49 +0000 |
| commit | e10bd6b22394a2a3cd65689a3f404df0f7661cbe (patch) | |
| tree | f5c41efca423ddbb41030abb86182432ec4ea416 | |
| parent | 38af1ad45ba38a64086b288c6750bcfc0869aeb1 (diff) | |
| download | wireshark-e10bd6b22394a2a3cd65689a3f404df0f7661cbe.tar.gz | |
Check whether create_tempfile() fails.
Thanks and a tip of the Hatlo hat to Coverity for finding this.
Change-Id: Ie9d4089443e52ef427e0cc8ae6e90a9d9787134e
Reviewed-on: https://code.wireshark.org/review/12123
Reviewed-by: Guy Harris <guy@alum.mit.edu>
(cherry picked from commit e9c26d015bde3ca5e5bf858ddb266a70d6751b7d)
Reviewed-on: https://code.wireshark.org/review/12124
| -rw-r--r-- | wiretap/file_access.c | 5 |
1 files changed, 5 insertions, 0 deletions
diff --git a/wiretap/file_access.c b/wiretap/file_access.c index f502c18dec..71e25805fd 100644 --- a/wiretap/file_access.c +++ b/wiretap/file_access.c @@ -2280,6 +2280,11 @@ wtap_dump_open_tempfile_ng(char **filenamep, const char *pfx, /* Choose a random name for the file */ fd = create_tempfile(&tmpname, pfx); + if (fd == -1) { + *err = errno; + g_free(wdh); + return NULL; /* can't create file */ + } *filenamep = tmpname; /* In case "fopen()" fails but doesn't set "errno", set "errno" |