diff options
author | Guy Harris <guy@alum.mit.edu> | 2005-08-05 23:18:05 +0000 |
---|---|---|
committer | Guy Harris <guy@alum.mit.edu> | 2005-08-05 23:18:05 +0000 |
commit | 1106ac410594177a2acb3987d24c80e742bd29fa (patch) | |
tree | 1307922b53f6cc84d374cfb0bcc8484a56cd3149 | |
parent | b945c5bd2a3f642ac51d517ec127aa2180fb9974 (diff) | |
download | wireshark-1106ac410594177a2acb3987d24c80e742bd29fa.tar.gz |
Put in a comment asking about the music going over the connection - we
shouldn't try to parse it as DAAP.
svn path=/trunk/; revision=15231
-rw-r--r-- | epan/dissectors/packet-daap.c | 11 |
1 files changed, 5 insertions, 6 deletions
diff --git a/epan/dissectors/packet-daap.c b/epan/dissectors/packet-daap.c index 9cc5db1542..4e40566187 100644 --- a/epan/dissectors/packet-daap.c +++ b/epan/dissectors/packet-daap.c @@ -146,12 +146,13 @@ dissect_daap(tvbuff_t *tvb, packet_info *pinfo, proto_tree *tree) proto_tree *daap_tree; int offset = 0; gboolean is_request = (pinfo->destport == TCP_PORT_DAAP); - - + if (check_col(pinfo->cinfo, COL_PROTOCOL)) col_set_str(pinfo->cinfo, COL_PROTOCOL, "DAAP"); - - + + /* + * XXX - what about the music itself? Check for bogus tag values? + */ if (check_col(pinfo->cinfo, COL_INFO)) { if (is_request) { col_add_str(pinfo->cinfo, COL_INFO, "DAAP Request"); @@ -165,8 +166,6 @@ dissect_daap(tvbuff_t *tvb, packet_info *pinfo, proto_tree *tree) } } - - if (tree) { ti = proto_tree_add_item(tree, proto_daap, tvb, 0, -1, FALSE); daap_tree = proto_item_add_subtree(ti, ett_daap); |