diff options
| author | Peter Wu <peter@lekensteyn.nl> | 2017-06-21 11:38:56 -0400 |
|---|---|---|
| committer | Michael Mann <mmann78@netscape.net> | 2017-06-22 10:34:35 +0000 |
| commit | 44aa08d02511ee0056a6456c66136ae753de989c (patch) | |
| tree | 59f5f93b58f650f1d803de7def17f32712ead46c | |
| parent | d25c33cc0b091d54f391d5aeceb5bb3453215b73 (diff) | |
| download | wireshark-44aa08d02511ee0056a6456c66136ae753de989c.tar.gz | |
tcp: always display next seq number
While you can add both the sequence number and next sequence number as
columns, the latter would remain empty if it was the same. This disrupts
the user reading flow who would have to look left and right, so just
display the field unconditionally.
Change-Id: I80efb972eaa9a16813a87ac0fdf6a045a3eb9d2f
Suggested-by: Laura Chappell
Reviewed-on: https://code.wireshark.org/review/22307
Reviewed-by: Anders Broman <a.broman58@gmail.com>
Petri-Dish: Anders Broman <a.broman58@gmail.com>
Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org>
Reviewed-by: Michael Mann <mmann78@netscape.net>
| -rw-r--r-- | epan/dissectors/packet-tcp.c | 12 |
1 files changed, 5 insertions, 7 deletions
diff --git a/epan/dissectors/packet-tcp.c b/epan/dissectors/packet-tcp.c index 8c1b29edd6..bf6818f145 100644 --- a/epan/dissectors/packet-tcp.c +++ b/epan/dissectors/packet-tcp.c @@ -5985,14 +5985,12 @@ dissect_tcp(tvbuff_t *tvb, packet_info *pinfo, proto_tree *tree, void* data _U_) } proto_item_set_len(ti, tcph->th_hlen); if (tcph->th_have_seglen) { - if (nxtseq != tcph->th_seq) { - if(tcp_relative_seq) { - tf=proto_tree_add_uint_format_value(tcp_tree, hf_tcp_nxtseq, tvb, offset, 0, nxtseq, "%u (relative sequence number)", nxtseq); - } else { - tf=proto_tree_add_uint(tcp_tree, hf_tcp_nxtseq, tvb, offset, 0, nxtseq); - } - PROTO_ITEM_SET_GENERATED(tf); + if(tcp_relative_seq) { + tf=proto_tree_add_uint_format_value(tcp_tree, hf_tcp_nxtseq, tvb, offset, 0, nxtseq, "%u (relative sequence number)", nxtseq); + } else { + tf=proto_tree_add_uint(tcp_tree, hf_tcp_nxtseq, tvb, offset, 0, nxtseq); } + PROTO_ITEM_SET_GENERATED(tf); } tf = proto_tree_add_uint(tcp_tree, hf_tcp_ack, tvb, offset + 8, 4, tcph->th_ack); |