diff options
| author | Martin Mathieson <martin.r.mathieson@googlemail.com> | 2012-07-28 23:51:06 +0000 |
|---|---|---|
| committer | Martin Mathieson <martin.r.mathieson@googlemail.com> | 2012-07-28 23:51:06 +0000 |
| commit | 4f65e11ad94ae3d5a1f4face2b7f302dfa104216 (patch) | |
| tree | 51f9d5df70af5467d44507673d8f0383a4dc7b97 | |
| parent | e1389f1196b3d063f184201a37714f0961830ea3 (diff) | |
| download | wireshark-4f65e11ad94ae3d5a1f4face2b7f302dfa104216.tar.gz | |
Add a comment that VS Code Analyzer makes a very good point here -
masking the m.s.b. of the command code does mean that several of them
won't ever get detected. I couldn't readily see from the spec what the
right think to do is.
svn path=/trunk/; revision=44098
| -rw-r--r-- | epan/dissectors/packet-t30.c | 6 |
1 files changed, 5 insertions, 1 deletions
diff --git a/epan/dissectors/packet-t30.c b/epan/dissectors/packet-t30.c index 33a756832f..b640848867 100644 --- a/epan/dissectors/packet-t30.c +++ b/epan/dissectors/packet-t30.c @@ -992,7 +992,11 @@ dissect_t30_hdlc(tvbuff_t *tvb, packet_info *pinfo, proto_tree *tree) " %s - %s", val_to_str_const(octet & 0x7F, t30_facsimile_control_field_vals_short, "<unknown>"), val_to_str(octet & 0x7F, t30_facsimile_control_field_vals, "<unknown>") ); - + /* + TODO: VS Code Analysis makes a good point - several of these commands can't get detected while + the m.s.b. is masked off! (e.g. T30_FC_DTC is 0x81). I couldn't readily work out from the T.30 + spec why this masking is being done... + */ switch (octet & 0x7F) { case T30_FC_DIS: case T30_FC_DTC: |