diff options
| author | Guy Harris <guy@alum.mit.edu> | 2016-06-23 18:51:25 -0700 |
|---|---|---|
| committer | Guy Harris <guy@alum.mit.edu> | 2016-06-24 01:51:55 +0000 |
| commit | 71a57dc85b235df5b598a195fefa243773c4f18f (patch) | |
| tree | e30b181384b9461bdc33c718ccd57c76902a733d | |
| parent | a5e9e7e7aed75cfec58ff33fc488baf6236c92c6 (diff) | |
| download | wireshark-71a57dc85b235df5b598a195fefa243773c4f18f.tar.gz | |
Indicate how this should be done.
Assuming that it could, if registered as an "eth.trailer" heuristic
dissector, get the length of the entire frame, that is.
Change-Id: I1ac26feeb10bb8ba357089a80f4b768f580bb51d
Reviewed-on: https://code.wireshark.org/review/16121
Reviewed-by: Guy Harris <guy@alum.mit.edu>
| -rw-r--r-- | epan/dissectors/packet-prp.c | 7 |
1 files changed, 7 insertions, 0 deletions
diff --git a/epan/dissectors/packet-prp.c b/epan/dissectors/packet-prp.c index c0781269a8..5cf0f9c3d5 100644 --- a/epan/dissectors/packet-prp.c +++ b/epan/dissectors/packet-prp.c @@ -97,6 +97,13 @@ dissect_prp_redundancy_control_trailer(tvbuff_t *tvb, packet_info *pinfo _U_, pr * This is horribly broken. It assumes the frame is an Ethernet * frame, with a type field at an offset of 12 bytes from the header. * That is not guaranteed to be true. + * + * Ideally, this should be a heuristic dissector registered in + * the "eth.trailer" heuristic dissector table (and it can + * be registered as "disabled by default" there); unfortunately, + * it needs to know the length of the entire frame for the + * PRP-0 heuristic, so it'd have to be passed that length + * out of band. */ if (!tvb_bytes_exist(tvb, 12, 2)) return 0; |