diff options
author | Guy Harris <guy@alum.mit.edu> | 2014-08-18 12:08:53 -0700 |
---|---|---|
committer | Guy Harris <guy@alum.mit.edu> | 2014-08-18 19:09:23 +0000 |
commit | a3cecb290938f56787c0e08b30fc34749bb4baec (patch) | |
tree | 2ff0ddd876572c06befb5c91f22e04cbd9056b07 | |
parent | 4a16ffc324b5fe6aaea7a9fd6a2e5327f66b0450 (diff) | |
download | wireshark-a3cecb290938f56787c0e08b30fc34749bb4baec.tar.gz |
Don't use proto_tree_add_expert() with an item rather than a tree.
proto_tree_add_expert() is to be used only on an item that's been
created as a tree (i.e., an interior node, complete with an ett_ value);
to hang expert info off of an *item*, which might *not* have been set up
to take subtree items, use expert_add_info().
Change-Id: Icdcdf39c31c0a03ff80dbb629186e8f6fa82e8ab
Reviewed-on: https://code.wireshark.org/review/3705
Reviewed-by: Guy Harris <guy@alum.mit.edu>
-rw-r--r-- | epan/dissectors/packet-acr122.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/epan/dissectors/packet-acr122.c b/epan/dissectors/packet-acr122.c index 47bdb72eb7..dc579ad655 100644 --- a/epan/dissectors/packet-acr122.c +++ b/epan/dissectors/packet-acr122.c @@ -320,7 +320,7 @@ dissect_acr122(tvbuff_t *tvb, packet_info *pinfo, proto_tree *tree, void *data) sub_item = proto_tree_add_uint(main_tree, hf_command, tvb, offset, 4 + length, command); PROTO_ITEM_SET_GENERATED(sub_item); if (command == CMD_UNKNOWN) - proto_tree_add_expert(sub_item, pinfo, &ei_unknown_command_or_invalid_parameters, tvb, offset, 4 + length); + expert_add_info(pinfo, sub_item, &ei_unknown_command_or_invalid_parameters); col_add_fstr(pinfo->cinfo, COL_INFO, "Command: %s", val_to_str_ext_const(command, &command_vals_ext, "Unknown")); |