diff options
| author | Guy Harris <guy@alum.mit.edu> | 2011-11-15 05:37:56 +0000 |
|---|---|---|
| committer | Guy Harris <guy@alum.mit.edu> | 2011-11-15 05:37:56 +0000 |
| commit | e600a12538b26bceae600fddc071548621584cd9 (patch) | |
| tree | a1ed7e0cbdb78e8d4c8328a99b8fa85f493b065e | |
| parent | c8283d1291af7d5b5793274d3947d7866d9a9f5c (diff) | |
| download | wireshark-e600a12538b26bceae600fddc071548621584cd9.tar.gz | |
OK, *that's* what Clang Cat was going on about:
packet-dcerpc-pn-io.c:8438:17: warning: Although the value
stored to 'prm_flag2' is used in the enclosing expression, the
value is never actually read from 'prm_flag2'
OK, thanks for telling me that, technically,
prm_flag1 = prm_flag2 = 0;
can be implemented by storing the 0 into prm_flag1 directly rather than
storing 0 into prm_flag2 and copying it to prm_flag1. Yes, you can haz
cheeseburger.
I guess it would matter if we were actually depending on some
side-effect of fetching prm_flag2, but we're not. Rewrite this one to
squelch the complaint.
svn path=/trunk/; revision=39841
| -rw-r--r-- | plugins/profinet/packet-dcerpc-pn-io.c | 3 |
1 files changed, 2 insertions, 1 deletions
diff --git a/plugins/profinet/packet-dcerpc-pn-io.c b/plugins/profinet/packet-dcerpc-pn-io.c index d0352d686f..1d733ede0f 100644 --- a/plugins/profinet/packet-dcerpc-pn-io.c +++ b/plugins/profinet/packet-dcerpc-pn-io.c @@ -8435,7 +8435,8 @@ dissect_ProfiSafeParameterRequest(tvbuff_t *tvb, int offset, guint8 prm_flag2_f_block_id; guint8 prm_flag2_f_par_version; - prm_flag1 = prm_flag2 = 0; + prm_flag1 = 0; + prm_flag2 = 0; f_item = proto_tree_add_item(tree, hf_pn_io_block, tvb, offset, 0, ENC_NA); f_tree = proto_item_add_subtree(f_item, ett_pn_io_profisafe_f_parameter); |