diff options
| author | Guy Harris <guy@alum.mit.edu> | 2016-12-23 01:00:44 -0800 |
|---|---|---|
| committer | Guy Harris <guy@alum.mit.edu> | 2016-12-23 09:02:37 +0000 |
| commit | f15b3a0f73568ca928827ee746792478c907845a (patch) | |
| tree | 48ef2bbb59dad3187855b4148cc0bfa8e6727232 | |
| parent | 933a73177736171214c2ae853fa3819fc09016bc (diff) | |
| download | wireshark-f15b3a0f73568ca928827ee746792478c907845a.tar.gz | |
Make sure we know that a RNG_RSP_DL_FREQ_OVERRIDE item is present.
Set a variable that we were supposed to be setting.
Also, note some items that should probably be expert info items instead
of, or in addition to, additional text at the end of protocol tree items.
Addresses CID 1397702.
Change-Id: I2ff0c2549f229546035964efa6af19b77646f7d2
Reviewed-on: https://code.wireshark.org/review/19397
Reviewed-by: Guy Harris <guy@alum.mit.edu>
| -rw-r--r-- | plugins/wimax/msg_rng_rsp.c | 5 |
1 files changed, 4 insertions, 1 deletions
diff --git a/plugins/wimax/msg_rng_rsp.c b/plugins/wimax/msg_rng_rsp.c index 35ed143e2b..ea85a2b9cd 100644 --- a/plugins/wimax/msg_rng_rsp.c +++ b/plugins/wimax/msg_rng_rsp.c @@ -342,7 +342,7 @@ static int dissect_mac_mgmt_msg_rng_rsp_decoder(tvbuff_t *tvb, packet_info *pinf ranging_status_item = add_tlv_subtree(&tlv_info, rng_rsp_tree, hf_rng_rsp_ranging_status, tvb, offset, ENC_BIG_ENDIAN); break; case RNG_RSP_DL_FREQ_OVERRIDE: { - add_tlv_subtree(&tlv_info, rng_rsp_tree, hf_rng_rsp_dl_freq_override, tvb, offset, ENC_BIG_ENDIAN); + dl_freq_override_item = add_tlv_subtree(&tlv_info, rng_rsp_tree, hf_rng_rsp_dl_freq_override, tvb, offset, ENC_BIG_ENDIAN); break; } case RNG_RSP_UL_CHANNEL_ID_OVERRIDE: @@ -512,6 +512,9 @@ static int dissect_mac_mgmt_msg_rng_rsp_decoder(tvbuff_t *tvb, packet_info *pinf } offset = tlv_len + tlv_offset; } /* end of TLV process while loop */ + /* + * XXX - these should probably be expert info items. + */ if (ranging_status_item && dl_freq_override_item) proto_item_append_text(ranging_status_item, " (shall be set to 2 because Downlink Frequency Override is present)"); if (ss_mac_address_item && frame_number_item) { |