summaryrefslogtreecommitdiff
path: root/CMakeLists.txt
diff options
context:
space:
mode:
authorMartin Kaiser <wireshark@kaiser.cx>2016-11-08 15:30:45 +0100
committerMartin Kaiser <wireshark@kaiser.cx>2016-11-08 16:22:30 +0000
commit4e95d5fa8e2f7fec72f0d7350a0b07ca8cdfa12b (patch)
tree446a7b297631905193a0e72a0095c449d61fa748 /CMakeLists.txt
parent7531318e054153fbd5e33624ef30314acd52b6bc (diff)
downloadwireshark-4e95d5fa8e2f7fec72f0d7350a0b07ca8cdfa12b.tar.gz
cmake: fix the linker flags test for Visual Studio
ddd1c87d43781533c3ec10279857e3870d12437e modified the order of linker command line options. This broke the tests and made invalid linker flags seem valid. (Link target) -> LINK : warning LNK4044: unrecognized option '/Wl,--as-needed'; ignored [C:\wireshark\build3\wsutil\wsutil.vcxproj] LINK : warning LNK4044: unrecognized option '/pie'; ignored [C:\wireshark\build3\wsutil\wsutil.vcxproj] The simple fix is to add specific options for Visual Studio and clang at the beginning of the linker's command line options rather than at the end. Change-Id: I6492ea1271e18be0d190e7579f47baecf6ac4d61 Reviewed-on: https://code.wireshark.org/review/18709 Petri-Dish: Martin Kaiser <wireshark@kaiser.cx> Reviewed-by: Peter Wu <peter@lekensteyn.nl> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Graham Bloice <graham.bloice@trihedral.com> Reviewed-by: Martin Kaiser <wireshark@kaiser.cx>
Diffstat (limited to 'CMakeLists.txt')
0 files changed, 0 insertions, 0 deletions