diff options
| author | Gerald Combs <gerald@wireshark.org> | 2009-09-14 23:31:02 +0000 |
|---|---|---|
| committer | Gerald Combs <gerald@wireshark.org> | 2009-09-14 23:31:02 +0000 |
| commit | c7b0b40c9bcdbd5339ddc8434d58318fb6438335 (patch) | |
| tree | 01f889b41d3ec7d7c4fbaa2b26705cb94ae4b4d2 /ChangeLog | |
| parent | 01e559bb2f47101e7cc11d8245e5a248a47d5fa2 (diff) | |
| download | wireshark-c7b0b40c9bcdbd5339ddc8434d58318fb6438335.tar.gz | |
Build 1.3.0.
svn path=/trunk/; revision=29912
Diffstat (limited to 'ChangeLog')
| -rw-r--r-- | ChangeLog | 17996 |
1 files changed, 7215 insertions, 10781 deletions
@@ -1,14708 +1,11142 @@ ------------------------------------------------------------------------ -r22111 | gerald | 2007-06-15 11:44:43 -0700 (Fri, 15 Jun 2007) | 2 lines +r28815 | gerald | 2009-06-22 15:38:29 -0700 (Mon, 22 Jun 2009) | 5 lines Changed paths: - M /trunk/config.nmake - M /trunk/configure.in - -0.99.6 has been split off. Bump the trunk to 0.99.7. + M /trunk/epan/dissectors/packet-afs.c ------------------------------------------------------------------------- -r22112 | guy | 2007-06-15 16:07:10 -0700 (Fri, 15 Jun 2007) | 2 lines -Changed paths: - M /trunk/epan/dissectors/packet-rpc.c - -Fix indentation. - ------------------------------------------------------------------------- -r22113 | jake | 2007-06-16 03:52:25 -0700 (Sat, 16 Jun 2007) | 1 line -Changed paths: - M /trunk/docbook/user-guide.xml - M /trunk/docbook/wsdg_src/WSDG_chapter_libraries.xml - M /trunk/docbook/wsug_src/WSUG_app_tools.xml - M /trunk/docbook/wsug_src/WSUG_chapter_advanced.xml - M /trunk/docbook/wsug_src/WSUG_chapter_build_install.xml - M /trunk/docbook/wsug_src/WSUG_chapter_introduction.xml +Instead of tvb_get_ptr + ep_alloc + proto_tree_add_string to fetch a string and +add it to the tree, just call proto_tree_add_item. Fixes bug 3564. -Bring the information up to date regarding versions and sample output. ------------------------------------------------------------------------- -r22114 | ulfl | 2007-06-16 04:09:34 -0700 (Sat, 16 Jun 2007) | 1 line -Changed paths: - M /trunk/docbook/wsdg_src/WSDG_chapter_libraries.xml - M /trunk/docbook/wsug_src/WSUG_chapter_build_install.xml - M /trunk/packaging/nsis/wireshark.nsi +Replace another tvb_get_ptr call with tvb_format_text. -Since the integration into the official GTK sources, the name of GTK-Wimp is now "GTK MS Windows Engine". Change the name in the NSIS installer and the docbook docs accordingly. ------------------------------------------------------------------------ -r22115 | sfisher | 2007-06-16 17:54:58 -0700 (Sat, 16 Jun 2007) | 6 lines +r28816 | morriss | 2009-06-22 15:48:35 -0700 (Mon, 22 Jun 2009) | 1 line Changed paths: - M /trunk/gtk/dfilter_expr_dlg.c - M /trunk/gtk/dfilter_expr_dlg.h - M /trunk/gtk/filter_dlg.c - - -Fix bug #1334 and a problem where a user couldn't interact with the -filter dialog's add expression dialog when going to it through file->open -or file->merge (because dialogs in between are set to modal). - + M /trunk + M /trunk/doc/Makefile.am +Copy AUTHORS-SHORT to the top-level directory so Help->About can find it when run from the build directory. ------------------------------------------------------------------------ -r22116 | lego | 2007-06-16 21:58:16 -0700 (Sat, 16 Jun 2007) | 5 lines +r28817 | stig | 2009-06-22 23:02:12 -0700 (Mon, 22 Jun 2009) | 6 lines Changed paths: - M /trunk/Makefile.am - M /trunk/Makefile.common - M /trunk/capinfos.c - M /trunk/editcap.c - -Have editcap and capinfos compile --without-plugins + M /trunk/asn1/h248/packet-h248-template.c + M /trunk/asn1/pkix1explicit/packet-pkix1explicit-template.c + M /trunk/asn1/pkixcmp/packet-cmp-template.c + M /trunk/asn1/q932/packet-q932-template.c + M /trunk/asn1/qsig/packet-qsig-template.c + M /trunk/asn1/ranap/packet-ranap-template.c + M /trunk/asn1/rtse/packet-rtse-template.c + M /trunk/asn1/s1ap/packet-s1ap-template.c + M /trunk/asn1/sabp/packet-sabp-template.c + M /trunk/asn1/smrse/packet-smrse-template.c + M /trunk/asn1/spnego/packet-spnego-template.c + M /trunk/asn1/t38/packet-t38-template.c + M /trunk/asn1/tcap/packet-tcap-template.c + M /trunk/asn1/x509af/packet-x509af-template.c + M /trunk/asn1/x509ce/packet-x509ce-template.c + M /trunk/asn1/x509if/packet-x509if-template.c -Should go in 0.99.6 +From Kovarththanan Rajaratnam: +Clean up header field info in asn1/*-template.c files. +From me: +Fixed a few typos in the patch. ------------------------------------------------------------------------ -r22117 | jake | 2007-06-17 04:18:29 -0700 (Sun, 17 Jun 2007) | 1 line +r28818 | jake | 2009-06-22 23:45:59 -0700 (Mon, 22 Jun 2009) | 2 lines Changed paths: - M /trunk/docbook/developer-guide.xml - M /trunk/docbook/wsdg_src/WSDG_chapter_dissection.xml - M /trunk/docbook/wsdg_src/WSDG_chapter_quick_setup.xml - M /trunk/docbook/wsdg_src/WSDG_chapter_tools.xml + M /trunk/epan/dissectors/packet-icmpv6.c -Bring developer guide up to date regarding tools and current plugin build infrastructure. +From Shinsuke SUZUKI: +Due to an incorrect offset setting in packet-icmpv6.c Wireshark cannot parse RA router-lifetime and RA flags properly. ------------------------------------------------------------------------ -r22118 | sahlberg | 2007-06-17 10:39:30 -0700 (Sun, 17 Jun 2007) | 3 lines +r28819 | jake | 2009-06-22 23:49:38 -0700 (Mon, 22 Jun 2009) | 12 lines Changed paths: - M /trunk/epan/dissectors/packet-nfs.c - -add some missing error codes + M /trunk/epan/dissectors/Makefile.common + A /trunk/epan/dissectors/packet-btamp.c + M /trunk/epan/dissectors/packet-btl2cap.c + M /trunk/epan/dissectors/packet-btl2cap.h +From Kovarththanan Rajaratnam: +The Bluetooth AMP Manager protocol was recently adopted by the Bluetooth SIG. +This protocol sits on top of L2CAP and requires a few changes in order to +accommodate the new move/create channel request. +This patch includes: +* a new Bluetooth AMP Manager Protocol dissector +* changes to L2CAP to handle the new move/create channel signals +* introduce a dissector table for fixed channel, allowing btamp dissector to +handle the BT AMP Manager Protocol channel +* Preliminary changes in L2CAP to support the new enhanced L2CAP modes +(enhanced retransmission/streaming mode) ------------------------------------------------------------------------ -r22119 | sahlberg | 2007-06-17 12:51:20 -0700 (Sun, 17 Jun 2007) | 4 lines +r28820 | etxrab | 2009-06-23 06:49:46 -0700 (Tue, 23 Jun 2009) | 1 line Changed paths: - M /trunk/gtk/column_prefs.c - -column_entry_changed_cb is not used by the GTK1 code. ifdef it out for -gtk1 - + M /trunk/epan/dissectors/packet-gtp.c +Try to fix indentation a bit. ------------------------------------------------------------------------ -r22120 | sahlberg | 2007-06-17 12:57:47 -0700 (Sun, 17 Jun 2007) | 3 lines +r28821 | etxrab | 2009-06-23 07:16:28 -0700 (Tue, 23 Jun 2009) | 1 line Changed paths: - M /trunk/gtk/filter_dlg.c - -gtk1 does not have gtk_window_get_modal - + M /trunk/epan/dissectors/packet-gtp.c +Revert(Try to fix indentation a bit.) ------------------------------------------------------------------------ -r22121 | sahlberg | 2007-06-17 13:57:34 -0700 (Sun, 17 Jun 2007) | 4 lines +r28822 | etxrab | 2009-06-23 09:01:55 -0700 (Tue, 23 Jun 2009) | 1 line Changed paths: - M /trunk/epan/dissectors/packet-smb.c - M /trunk/epan/dissectors/packet-smb.h - -remember locking info between requests and repsonses so it is easier to -diagnose why an operation returned an error - + M /trunk/diameter/dictionary.xml +Update 3GPP AVP:s ------------------------------------------------------------------------ -r22122 | sahlberg | 2007-06-17 16:58:01 -0700 (Sun, 17 Jun 2007) | 4 lines +r28823 | jake | 2009-06-23 14:05:47 -0700 (Tue, 23 Jun 2009) | 4 lines Changed paths: - M /trunk/epan/dissectors/packet-smb.c - M /trunk/epan/dissectors/packet-smb.h - -track filenames between rename requests and responses to make it easier to -diagnose why a rename failed + M /trunk/AUTHORS + A /trunk/epan/dissectors/packet-hpteam.c + M /trunk/epan/dissectors/packet-llc.c + M /trunk/epan/oui.h +From Nathan Hartwell: +This patch attempt should more closely align with the Wireshark "layout" of using +a dissector rather than a "hack" to the packet-llc dissector. ------------------------------------------------------------------------ -r22123 | sahlberg | 2007-06-17 17:01:24 -0700 (Sun, 17 Jun 2007) | 4 lines +r28824 | wmeier | 2009-06-23 17:29:54 -0700 (Tue, 23 Jun 2009) | 3 lines Changed paths: - M /trunk/epan/dissectors/packet-nfs.c - M /trunk/epan/dissectors/packet-nfs.h - -make hf_nfs_nfsstat externaly visible so other dissectors can use nfs -status codes + M /trunk/epan/dissectors/Makefile.common + M /trunk/epan/dissectors/packet-hpteam.c +if (!initialized) ... not req'd + other addt'l minor revisions; +Also: add packet-hpteam.c to Makefile.common so it gets built as part oif Wireshark. ------------------------------------------------------------------------ -r22124 | sahlberg | 2007-06-17 17:04:30 -0700 (Sun, 17 Jun 2007) | 2 lines +r28825 | wmeier | 2009-06-23 17:49:54 -0700 (Tue, 23 Jun 2009) | 2 lines Changed paths: - M /trunk/epan/dissectors/packet-nfsacl.c + M /trunk/epan/dissectors/packet-btamp.c -nfs acl uses the same status codes as nfs so use the hf field for nfs +Remove two unused includes ------------------------------------------------------------------------ -r22125 | sfisher | 2007-06-17 18:42:17 -0700 (Sun, 17 Jun 2007) | 5 lines +r28826 | stig | 2009-06-23 18:40:54 -0700 (Tue, 23 Jun 2009) | 3 lines Changed paths: - M /trunk/epan/dissectors/packet-dcom.c - - -Fix compilation on OS X with GLib 1.2 by including ctype.h since our -isprint.h override only kicks in for GLib 2+. + M /trunk/asn1/ansi_map/ansi_map.cnf + M /trunk/asn1/ansi_map/packet-ansi_map-template.c + M /trunk/asn1/camel/packet-camel-template.c + M /trunk/asn1/ftam/packet-ftam-template.c + M /trunk/asn1/gsmmap/packet-gsmmap-template.c + M /trunk/asn1/h225/packet-h225-template.c + M /trunk/asn1/h450/packet-h450-template.c + M /trunk/asn1/ocsp/packet-ocsp-template.c + M /trunk/asn1/qsig/packet-qsig-template.c +From Kovarththanan Rajaratnam: +More asn1/* header field info cleanup ------------------------------------------------------------------------ -r22126 | standel | 2007-06-17 19:23:44 -0700 (Sun, 17 Jun 2007) | 3 lines +r28827 | stig | 2009-06-23 19:05:51 -0700 (Tue, 23 Jun 2009) | 2 lines Changed paths: - M /trunk/configure.in - -get rid of the "case" statement to test the value of withval. + M /trunk/epan/dissectors/ncp2222.py +More hf_register_info related cleanup. ------------------------------------------------------------------------ -r22127 | standel | 2007-06-17 20:03:54 -0700 (Sun, 17 Jun 2007) | 13 lines +r28828 | stig | 2009-06-23 19:07:16 -0700 (Tue, 23 Jun 2009) | 4 lines Changed paths: - M /trunk/configure.in + M /trunk/epan/dissectors/process-x11-fields.pl + M /trunk/epan/dissectors/x11-fields -Fix bug #1395 -Configure options '--with-libgnutls-prefix' and '--with-libgcrypt-prefix' could -be used to indicate the path where the respective libraries had been installed. -However, these options could not be used to compile wireshark without the use -of them if installed on the system. -These two macros are not part of the wireshark project. configure.in has -therefore been modified so that wireshark can be compiled without gnutls or -gcrypt. Two configure options have been introduced : '--with-gnutls' and -'--with-gcrypt'. They take precedence on their 'prefix-specification' -counterpart or in other words, if '-with-gnutls=no' and -'--with-libgnutls-prefix' are used, wireshark will be compiled *without* -gnutls. +From Kovarththanan Rajaratnam: +More hf_register_info related cleanup +* Fix process-x11-fields.pl (packet-x11.c) ------------------------------------------------------------------------ -r22128 | jake | 2007-06-18 11:11:58 -0700 (Mon, 18 Jun 2007) | 4 lines +r28829 | stig | 2009-06-23 19:08:14 -0700 (Tue, 23 Jun 2009) | 3 lines Changed paths: - M /trunk/epan/dissectors/packet-edonkey.c - M /trunk/epan/dissectors/packet-edonkey.h - -From Lukasz "M.": -I added 5 new packets to packet-edonkey.c and improve 2. Diffs in -attachment. This part of wireshark (decoding emule packets) it's not -finish as I see :) I try to do it, meybe... :) ------------------------------------------------------------------------- -r22129 | sfisher | 2007-06-18 11:57:58 -0700 (Mon, 18 Jun 2007) | 13 lines -Changed paths: - M /trunk/epan/dissectors/packet-mysql.c - - -From Martin Warnes: - -Currently the MySQL dissector assumes that an OK-Packet Response -contains the Server_Status field. Having checked the MySQL protocol page -I can't say conclusively whether it should or it shouldn't, however I've -come across a couple of MySQL Java clients that receive the OK-Packet -without the Server_Status field set in response to a "SET AUTOCOMMIT" call. - -The attached patched simply adds a check to ensure the Server_Status -field is present before calling function mysql_dissect_server_status. + M /trunk/epan/dissectors/packet-nisplus.c +Change hf_nisplus_dummy to use "dummy" as name instead of " " +(this is the only place where " " was used) ------------------------------------------------------------------------ -r22130 | sfisher | 2007-06-18 12:08:59 -0700 (Mon, 18 Jun 2007) | 9 lines +r28830 | stig | 2009-06-23 19:11:11 -0700 (Tue, 23 Jun 2009) | 5 lines Changed paths: - M /trunk/epan/dissectors/packet-mysql.c - -From Martin Warnes: + M /trunk/epan/dissectors/packet-cimetrics.c + M /trunk/epan/dissectors/packet-cisco-oui.c + M /trunk/epan/dissectors/packet-extreme.c + M /trunk/epan/dissectors/packet-force10-oui.c + M /trunk/epan/dissectors/packet-iana-oui.c + M /trunk/epan/dissectors/packet-nt-oui.c -Attached is a small patch that adds a preference option to allow the SQL -Query string to be appended to the INFO column display. This makes life -a little bit easier when scanning a trace to find the packet associated -with a specific query. I thought it was better to implement it as a -preference option with default set FALSE as it can clutter up the -display for applications that generate large amounts of queries. +From Kovarththanan Rajaratnam: +Cleanup hf_register_info declaration passed to llc_add_oui(). While there, +change the declaration to an array in order to be consistent with the rest +of packet-*.c files. ------------------------------------------------------------------------ -r22131 | sfisher | 2007-06-18 12:15:48 -0700 (Mon, 18 Jun 2007) | 12 lines +r28831 | stig | 2009-06-23 19:12:13 -0700 (Tue, 23 Jun 2009) | 3 lines Changed paths: - M /trunk/epan/dissectors/packet-armagetronad.c - -From Guillaume Chazarain: + M /trunk/plugins/m2m/packet-m2m.c -Please find attached a patch to fix some bugs in the armagetronad -dissector. More specifically: - -* Update the descriptors to armagetronad-0.2.8.2.1, the file -src/network/Makefile.in does not exist anymore in the armagetronad -source code. -* Ensure the printed data is null terminated. -* Avoid guint16 overflow because of the '* 2'. -* Remove a statement with no effect (data = NULL). +From Kovarththanan Rajaratnam: +Move hf_register_info declarations in packet-m2m.c to function scope ------------------------------------------------------------------------ -r22132 | etxrab | 2007-06-18 12:20:52 -0700 (Mon, 18 Jun 2007) | 5 lines +r28832 | stig | 2009-06-23 19:17:12 -0700 (Tue, 23 Jun 2009) | 3 lines Changed paths: - M /trunk/asn1/ansi_map/ansi_map.asn - M /trunk/asn1/ansi_map/packet-ansi_map-template.c - M /trunk/epan/dissectors/packet-ansi_map.c - -Add code for signals: -- LCSParameterRequest -- CheckMEID -- PositionEventNotification -- StatusRequest ------------------------------------------------------------------------- -r22133 | sfisher | 2007-06-18 12:31:34 -0700 (Mon, 18 Jun 2007) | 11 lines -Changed paths: - M /trunk/AUTHORS - M /trunk/epan/dissectors/packet-fcoe.c - - -From Joe Eykholt: - -- Remove ethertype preference from recently added FCoE dissector - -Me: - -- Add Joe to the AUTHORS list -- Change previous line in AUTHORS list from @ to [AT] in e-mail address + M /trunk/epan/dissectors/packet-diameter.c + M /trunk/epan/dissectors/packet-infiniband.h + M /trunk/epan/dissectors/packet-jxta.c + M /trunk/epan/dissectors/packet-tpncp.c + M /trunk/epan/oids.c + M /trunk/plugins/unistim/header_field.h +From Kovarththanan Rajaratnam: +More hf_register_info related cleanup. ------------------------------------------------------------------------ -r22134 | sfisher | 2007-06-18 13:14:07 -0700 (Mon, 18 Jun 2007) | 8 lines +r28833 | wmeier | 2009-06-23 19:42:43 -0700 (Tue, 23 Jun 2009) | 2 lines Changed paths: - M /trunk/epan/dissectors/packet-smb.h + M /trunk/epan/dissectors/packet-hpteam.c - -Fix Windows build-bot warnings: - -packet-smb.c(5479) : error C2220: warning treated as error - no object file generated -packet-smb.c(5479) : warning C4244: '=' : conversion from 'unsigned short ' to 'unsigned char ', possible loss of data -packet-smb.c(5480) : warning C4244: '=' : conversion from 'unsigned short ' to 'unsigned char ', possible loss of data - +Remove superflous code; #include <stdio.h> not needed. ------------------------------------------------------------------------ -r22135 | etxrab | 2007-06-18 13:54:15 -0700 (Mon, 18 Jun 2007) | 11 lines +r28834 | stig | 2009-06-23 20:03:25 -0700 (Tue, 23 Jun 2009) | 2 lines Changed paths: - M /trunk/asn1/gsmmap/GSMMAP.asn - M /trunk/asn1/gsmmap/gsmmap.cnf - M /trunk/asn1/gsmmap/packet-gsm_map-template.c - M /trunk/epan/dissectors/packet-gsm_map.c - -Fix to: -For the Cancel Location message, you can replace the -old_CancelLocationArgV2 by the Identity message. -So the old syntax for Cancel Location is not used anymore. - -For the message Send Authentication Info Res, there is a typo error. The "item" should not be used. - -- one with the decoding of "processUnstructuredSS-Data", the IA5 string -is not decoded/displayed. + M /trunk/epan/dissectors/packet-cip.c + M /trunk/epan/dissectors/packet-enip.c -This should go into 0.99.6. ------------------------------------------------------------------------- -r22136 | etxrab | 2007-06-18 14:03:59 -0700 (Mon, 18 Jun 2007) | 1 line -Changed paths: - M /trunk/asn1/gsmmap/Makefile.nmake - M /trunk/asn1/gsmmap/gsm_map-exp.cnf - M /trunk/asn1/gsmmap/gsmmap.cnf - M /trunk/epan/dissectors/packet-gsm_map.c - M /trunk/epan/dissectors/packet-gsm_map.h +More hf_register_info related cleanup. -Update .cnf file ------------------------------------------------------------------------ -r22137 | wmeier | 2007-06-18 14:12:13 -0700 (Mon, 18 Jun 2007) | 2 lines +r28835 | stig | 2009-06-23 22:54:19 -0700 (Tue, 23 Jun 2009) | 2 lines Changed paths: - M /trunk/epan/dissectors/packet-armagetronad.c + M /trunk/epan/dissectors/packet-homeplug.c -Fix windows build error .... +Fixed field types for some reserved fields. ------------------------------------------------------------------------ -r22138 | gerald | 2007-06-18 14:58:34 -0700 (Mon, 18 Jun 2007) | 3 lines +r28836 | jake | 2009-06-23 23:21:45 -0700 (Tue, 23 Jun 2009) | 4 lines Changed paths: - M /trunk/epan/crypt/airpdcap.c - -Be a little less picky about EAPOL packet lengths. Someone sent in a -capture that has extra data in the 4th handshake message. + M /trunk/epan/dissectors/packet-slowprotocols.c +From Artem Tamazov: +Added: ESMC support as per G.8264 (Slow Protocol Subtype 0x0a). +* QL codes are dissected according to G.781 5.5.1.1 "Option I SDH". +Added: support for Timestamp entities in ESMC PDU as per WD56 proposal. ------------------------------------------------------------------------ -r22139 | sfisher | 2007-06-19 11:09:50 -0700 (Tue, 19 Jun 2007) | 4 lines +r28837 | stig | 2009-06-24 12:10:50 -0700 (Wed, 24 Jun 2009) | 3 lines Changed paths: - M /trunk/doc/wireshark.pod - - -Add a simple entry for -z voip,calls to wireshark man page/html file + M /trunk/epan/addr_resolv.c +From Kovarththanan Rajaratnam via bug 3555: +Cancel hostname lookup timers if c-ares is not initialized. ------------------------------------------------------------------------ -r22140 | gerald | 2007-06-19 14:19:11 -0700 (Tue, 19 Jun 2007) | 2 lines +r28838 | jake | 2009-06-24 13:27:58 -0700 (Wed, 24 Jun 2009) | 2 lines Changed paths: - M /trunk/epan - M /trunk/epan/wslua - -Add more items to svn:ignore. + M /trunk/wiretap/dct3trace.c +From Duncan Salerno: +Ensure dct3trac packets never longer than 23 bytes. ------------------------------------------------------------------------ -r22141 | etxrab | 2007-06-19 15:11:30 -0700 (Tue, 19 Jun 2007) | 3 lines +r28839 | stig | 2009-06-24 18:50:56 -0700 (Wed, 24 Jun 2009) | 2 lines Changed paths: - M /trunk/asn1/gsmmap/Makefile - M /trunk/epan/dissectors/packet-gsm_a.c + M /trunk/epan/dissectors/packet-infiniband.c + +Remove a tvb_free() call. -- update the Unix Makefile to use gsmmap.cnf and not gsm_map.cnf. -- the Facility is not bellow the facility itself, but at the end of the tree. -It's not a problem, but it looks strange.. - Fixed ------------------------------------------------------------------------ -r22142 | martinm | 2007-06-20 07:40:40 -0700 (Wed, 20 Jun 2007) | 3 lines +r28840 | stig | 2009-06-24 19:07:17 -0700 (Wed, 24 Jun 2009) | 3 lines Changed paths: - M /trunk/diameter/dictionary.xml - M /trunk/epan/dissectors/packet-diameter.c + M /trunk/epan/to_str.c + M /trunk/epan/to_str.h -- include gqpolicy.xml properly! -- print more specific console disgnostics when AVPs don't match because of vendorID being different +From Nathan Hartwell via bug 2733: +Added time_secs_to_str_unsigned(). ------------------------------------------------------------------------ -r22143 | jake | 2007-06-20 10:17:25 -0700 (Wed, 20 Jun 2007) | 3 lines +r28841 | stig | 2009-06-24 19:08:06 -0700 (Wed, 24 Jun 2009) | 3 lines Changed paths: - M /trunk/epan/dissectors/packet-edonkey.c + M /trunk/epan/dissectors/packet-bootp.c -From Lukasz M.: -Sometimes edonkey packets comes joined, and wireshark display only last -one on column Info. Now everyone is displayed. ------------------------------------------------------------------------- -r22145 | morriss | 2007-06-20 13:02:52 -0700 (Wed, 20 Jun 2007) | 1 line -Changed paths: - M /trunk/editcap.c +From Nathan Hartwell via bug 2733: +Use time_secs_to_str_unsigned(). -Increase the maximum number of packet selections to 512 (from 100). More importantly, give the user feedback if we run out of room for packet selections. As mentioned on the list, this could be made completely dynamic if someone actually goes over the (new) limit. OK for 0.99.6 but not necessary. ------------------------------------------------------------------------ -r22146 | etxrab | 2007-06-20 14:54:40 -0700 (Wed, 20 Jun 2007) | 2 lines +r28842 | stig | 2009-06-24 19:13:35 -0700 (Wed, 24 Jun 2009) | 2 lines Changed paths: - M /trunk/asn1/gsmmap/gsmmap.cnf - M /trunk/asn1/gsmmap/packet-gsm_map-template.c - M /trunk/epan/dissectors/packet-gsm_map.c - M /trunk/epan/dissectors/packet-gsm_sms.c + M /trunk/epan/to_str.c -Add call to the sms dissector for MO-ForwardSM-Arg and MT-ForwardSM-Arg. -Use a separate valuestring for forwardSM and sendRoutingInfoForSM. ------------------------------------------------------------------------- -r22147 | etxrab | 2007-06-20 14:56:03 -0700 (Wed, 20 Jun 2007) | 1 line -Changed paths: - M /trunk/asn1/ulp/ulp.cnf - M /trunk/epan/dissectors/packet-ulp.c +Unsigned does not have msign. -Show IPv4/IPv6 addresses as such. ------------------------------------------------------------------------ -r22148 | martinm | 2007-06-21 04:37:42 -0700 (Thu, 21 Jun 2007) | 2 lines +r28843 | etxrab | 2009-06-24 22:59:04 -0700 (Wed, 24 Jun 2009) | 1 line Changed paths: - M /trunk/Makefile.am - A /trunk/dtds/xcap-error.dtd - M /trunk/packaging/nsis/wireshark.nsi - -Add DTD file for xcap-error (RFC 4825) + M /trunk/asn1/spnego/packet-spnego-template.c +tvb_new_real_data()->tvb_child_new_real_data() ------------------------------------------------------------------------ -r22149 | gal | 2007-06-21 09:50:16 -0700 (Thu, 21 Jun 2007) | 3 lines +r28844 | stig | 2009-06-25 19:38:23 -0700 (Thu, 25 Jun 2009) | 6 lines Changed paths: - M /trunk/asn1/x411/packet-x411-template.c - M /trunk/asn1/x411/x411.cnf - M /trunk/epan/dissectors/packet-x411.c + M /trunk/epan/dissectors/Makefile.common + M /trunk/epan/dissectors/packet-cip.c + M /trunk/epan/dissectors/packet-cip.h + M /trunk/epan/dissectors/packet-enip.c + A /trunk/epan/dissectors/packet-enip.h -New preference to specify the tcp port to use for P1 and fix to include /OU= in dissected X.400 addresses. +From Joakim Wiberg via bug 3103: +Various improvements to the CIP and ENIP dissectors. +From me: +Updated to latest trunk changes. ------------------------------------------------------------------------ -r22150 | martinm | 2007-06-21 10:30:13 -0700 (Thu, 21 Jun 2007) | 2 lines +r28845 | stig | 2009-06-25 20:20:12 -0700 (Thu, 25 Jun 2009) | 2 lines Changed paths: - M /trunk/wiretap/catapult_dct2000.c + M /trunk/asn1/spnego/packet-spnego-template.c -Don't create & leak a hash table during unsuccessful open() +tvb_child_new_real_data() -> tvb_new_child_real_data() ------------------------------------------------------------------------ -r22151 | gerald | 2007-06-21 10:49:03 -0700 (Thu, 21 Jun 2007) | 7 lines +r28846 | stig | 2009-06-25 20:24:08 -0700 (Thu, 25 Jun 2009) | 2 lines Changed paths: - M /trunk/docbook/release-notes.xml - M /trunk/epan/crypt/airpdcap.c - M /trunk/epan/crypt/airpdcap_user.h - M /trunk/epan/dissectors/packet-ieee80211.c - M /trunk/epan/strutil.c - -Be less restrictive about WEP key preferences. Use hex_str_to_bytes to -process WEP keys. Allow the "wep:" prefix for WEP keys even when -HAVE_AIRPDCAP isn't defined. Add a NULL pointer check to -hex_str_to_bytes(). Fixes bug 1584. + M /trunk/doc/README.developer -Fixup indentation. +Use NULL for empty blurb. ------------------------------------------------------------------------ -r22152 | gerald | 2007-06-21 13:22:56 -0700 (Thu, 21 Jun 2007) | 4 lines +r28847 | stig | 2009-06-25 20:37:30 -0700 (Thu, 25 Jun 2009) | 2 lines Changed paths: - M /trunk/epan/crypt/airpdcap.c - M /trunk/epan/dissectors/packet-ieee80211.c + M /trunk/gtk/main.c -In packet-ieee802.11.c, fix a serious preference bug introduced in the -last checkin. In airpcap.c, appease the toolbar code by returning a -lower-case, non-separated WEP key. +Small whitespace cleanup. ------------------------------------------------------------------------ -r22154 | etxrab | 2007-06-21 14:38:34 -0700 (Thu, 21 Jun 2007) | 1 line +r28848 | stig | 2009-06-25 20:59:01 -0700 (Thu, 25 Jun 2009) | 2 lines Changed paths: - M /trunk/asn1/gsmmap/GSMMAP.asn - M /trunk/asn1/gsmmap/gsmmap.cnf - M /trunk/asn1/gsmmap/packet-gsm_map-template.c + M /trunk/epan/dissectors/packet-acp133.c + M /trunk/epan/dissectors/packet-ansi_map.c + M /trunk/epan/dissectors/packet-camel.c + M /trunk/epan/dissectors/packet-cmip.c + M /trunk/epan/dissectors/packet-crmf.c + M /trunk/epan/dissectors/packet-dap.c + M /trunk/epan/dissectors/packet-disp.c + M /trunk/epan/dissectors/packet-dop.c + M /trunk/epan/dissectors/packet-dsp.c + M /trunk/epan/dissectors/packet-ftam.c + M /trunk/epan/dissectors/packet-gnm.c + M /trunk/epan/dissectors/packet-goose.c M /trunk/epan/dissectors/packet-gsm_map.c + M /trunk/epan/dissectors/packet-h225.c + M /trunk/epan/dissectors/packet-h235.c + M /trunk/epan/dissectors/packet-h245.c + M /trunk/epan/dissectors/packet-h245.h + M /trunk/epan/dissectors/packet-h248.c + M /trunk/epan/dissectors/packet-h282.c + M /trunk/epan/dissectors/packet-h283.c + M /trunk/epan/dissectors/packet-h450.c + M /trunk/epan/dissectors/packet-h460.c + M /trunk/epan/dissectors/packet-h501.c + M /trunk/epan/dissectors/packet-inap.c + M /trunk/epan/dissectors/packet-ldap.c + M /trunk/epan/dissectors/packet-lte-rrc.c + M /trunk/epan/dissectors/packet-mms.c + M /trunk/epan/dissectors/packet-mpeg-audio.c + M /trunk/epan/dissectors/packet-mpeg-pes.c + M /trunk/epan/dissectors/packet-nbap.c + M /trunk/epan/dissectors/packet-p7.c + M /trunk/epan/dissectors/packet-p7.h + M /trunk/epan/dissectors/packet-pcap.c + M /trunk/epan/dissectors/packet-pkix1explicit.c + M /trunk/epan/dissectors/packet-pkixtsp.c + M /trunk/epan/dissectors/packet-q932.c + M /trunk/epan/dissectors/packet-qsig.c + M /trunk/epan/dissectors/packet-rnsap.c + M /trunk/epan/dissectors/packet-rrc.c + M /trunk/epan/dissectors/packet-smrse.c + M /trunk/epan/dissectors/packet-spnego.c + M /trunk/epan/dissectors/packet-t125.c + M /trunk/epan/dissectors/packet-ulp.c + M /trunk/epan/dissectors/packet-x2ap.c + M /trunk/epan/dissectors/packet-x411.c + M /trunk/epan/dissectors/packet-x411.h + M /trunk/epan/dissectors/packet-x420.c + M /trunk/epan/dissectors/packet-x509af.c + M /trunk/epan/dissectors/packet-x509ce.c + M /trunk/epan/dissectors/packet-x509if.c + M /trunk/epan/dissectors/packet-x509sat.c -Fix some GSM MAP Warnings. ------------------------------------------------------------------------- -r22155 | etxrab | 2007-06-21 14:41:31 -0700 (Thu, 21 Jun 2007) | 1 line -Changed paths: - D /trunk/asn1/gsm_ss/Makefile - D /trunk/asn1/gsm_ss/Makefile.nmake - D /trunk/asn1/gsm_ss/SS-Operations.asn - D /trunk/asn1/gsm_ss/gsm_ss.cnf - D /trunk/asn1/gsm_ss/packet-gsm_ss-template.c - D /trunk/asn1/gsm_ss/packet-gsm_ss-template.h +Re-generate asn1 dissectors after hf_register_info cleanup. -Delete now obsolete GSM SS. ------------------------------------------------------------------------ -r22156 | etxrab | 2007-06-21 14:44:50 -0700 (Thu, 21 Jun 2007) | 1 line +r28849 | etxrab | 2009-06-25 22:48:03 -0700 (Thu, 25 Jun 2009) | 3 lines Changed paths: - D /trunk/asn1/MAP_Dialogue + M /trunk/Makefile.am + M /trunk/diameter/dictionary.xml + A /trunk/diameter/eap.xml + M /trunk/diameter/nasreq.xml + M /trunk/epan/dissectors/packet-diameter.c + M /trunk/packaging/nsis/wireshark.nsi -Delete now obsolete MAP dialouge. +From Sebastien Decugis: +Add Missing Diameter EAP support. +https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=3600 ------------------------------------------------------------------------ -r22157 | standel | 2007-06-21 15:36:33 -0700 (Thu, 21 Jun 2007) | 3 lines +r28850 | tuexen | 2009-06-26 08:08:04 -0700 (Fri, 26 Jun 2009) | 12 lines Changed paths: - M /trunk/configure.in + M /trunk/wiretap/pcapng.c -default value of --with-gcrypt must be set to yes. +* Allocate enough memory for reading a packet. +* Initialize pseudoheader. +* Add some input validation / protection code. +* Fix some return values. +* Clean up some whitespaces. +This fixes Bug 3565. Thanks to Tyson Key how reported +the issue and provided capture files for debugging. ------------------------------------------------------------------------- -r22158 | gerald | 2007-06-21 15:54:06 -0700 (Thu, 21 Jun 2007) | 2 lines -Changed paths: - M /trunk/docbook/release-notes.xml - -Expand the new/added features section. +This fix is scheduled for inclusion in Wireshark 1.2.1 +and higher. ------------------------------------------------------------------------ -r22159 | gerald | 2007-06-21 16:19:16 -0700 (Thu, 21 Jun 2007) | 2 lines +r28851 | tuexen | 2009-06-26 08:25:22 -0700 (Fri, 26 Jun 2009) | 2 lines Changed paths: - M /trunk/docbook/release-notes.xml + M /trunk/wiretap/pcapng.c -Fix invalid markup. +Disable debug output. ------------------------------------------------------------------------ -r22160 | sfisher | 2007-06-21 16:30:09 -0700 (Thu, 21 Jun 2007) | 4 lines +r28852 | gerald | 2009-06-26 14:25:09 -0700 (Fri, 26 Jun 2009) | 3 lines Changed paths: - M /trunk/docbook/release-notes.xml - - -Fix typo in HTTP Export Object menu path. It ends with HTTP, not HTML. + M /trunk/AUTHORS + M /trunk/dumpcap.c +Unfortunately, r28452 seems to cause more problems than it fixes. Back +out the change for now. ------------------------------------------------------------------------ -r22162 | martinm | 2007-06-22 05:42:47 -0700 (Fri, 22 Jun 2007) | 3 lines +r28853 | gerald | 2009-06-26 16:05:04 -0700 (Fri, 26 Jun 2009) | 2 lines Changed paths: - M /trunk/diameter/dictionary.xml - M /trunk/epan/dissectors/packet-diameter-defs.h + M /trunk/gtk/prefs_column.c -NASREQ AVP 4 (NAS-IP-Address) is of type OctetString, not IPAddress -(according to RFC 4005). +Add a tooltip in case it's not obvious how to rearrange the columns. ------------------------------------------------------------------------ -r22163 | sahlberg | 2007-06-22 06:23:50 -0700 (Fri, 22 Jun 2007) | 7 lines +r28854 | rbalint | 2009-06-26 23:32:52 -0700 (Fri, 26 Jun 2009) | 2 lines Changed paths: - M /trunk/epan/dissectors/packet-dns.c - -dns request/response tracking did not work if tree==NULL we didnt set up -the tracking structures - -this makes dns request/response trackign work when you dont have any -color filters + M /trunk/configure.in +Strictly require flex instead of allowing lex, too. ------------------------------------------------------------------------ -r22165 | sahlberg | 2007-06-22 12:32:02 -0700 (Fri, 22 Jun 2007) | 5 lines +r28855 | rbalint | 2009-06-27 01:13:39 -0700 (Sat, 27 Jun 2009) | 2 lines Changed paths: - M /trunk/asn1/ldap/ldap.cnf - M /trunk/epan/dissectors/packet-ldap.c - M /trunk/epan/dissectors/packet-ldap.h - -add code to handle new insanity in how spnego and gss wrap -eachother - + M /trunk/configure.in +Revert commit 28854. ------------------------------------------------------------------------ -r22166 | sfisher | 2007-06-22 15:22:10 -0700 (Fri, 22 Jun 2007) | 8 lines +r28856 | etxrab | 2009-06-27 03:31:42 -0700 (Sat, 27 Jun 2009) | 5 lines Changed paths: - M /trunk/docbook/wsug_graphics/ws-stats-iographs.png - M /trunk/docbook/wsug_src/WSUG_chapter_statistics.xml - M /trunk/gtk/Makefile.am - M /trunk/gtk/Makefile.common - M /trunk/gtk/io_stat.c - A /trunk/gtk/pixmap_save.c - A /trunk/gtk/pixmap_save.h - - -Fix enhancement bug #1337: Export IO Graphs - -This new code adds a save button to the Statistics IO Graphs window and -is also reusable by any other code that uses GDK Pixmaps to draw graphs. -The Gdk-pixbuf library included in GTK is used for this save function. + M /trunk/epan/dissectors/dcerpc/drsuapi/template.c + M /trunk/epan/dissectors/dcerpc/idl2wrs.c + M /trunk/epan/dissectors/ncp2222.py + M /trunk/epan/dissectors/pidl/atsvc.cnf + M /trunk/epan/dissectors/pidl/mapi/mapi.cnf + M /trunk/epan/dissectors/pidl/mapi/request.cnf.c + M /trunk/epan/dissectors/pidl/mapi/response.cnf.c +From Kovarththanan Rajaratnam: +- Fix ncp2222.py and all the epan/dissectors/dcerpc dissectors. The +latter required changes to idl2wrs which used variadic macros (not supported in MSVC 6.0). +- Cleanup PIDL conformance files ------------------------------------------------------------------------ -r22167 | sfisher | 2007-06-22 15:42:33 -0700 (Fri, 22 Jun 2007) | 5 lines +r28857 | tuexen | 2009-06-27 04:39:47 -0700 (Sat, 27 Jun 2009) | 8 lines Changed paths: - M /trunk/asn1/Makefile.am - D /trunk/asn1/gsm_ss - - -Fix distcheck for recently removed asn1/gsm_ss and asn1/MAP_Dialogue and -remove the asn1/gsm_ss directory. + M /trunk/wiretap/libpcap.c + M /trunk/wiretap/pcap-common.c + M /trunk/wiretap/pcap-common.h + M /trunk/wiretap/pcapng.c +This commit +* adds an encap argument to pcap_process_pseudo_header. +* adds support for reading pseudo headers. +It fixes Bug 3560. +Thanks to Tyson Key for reporting the bug and providing +trace files. This fix will be scheduled for inclusion in +Wireshark 1.2.1 and higher. ------------------------------------------------------------------------ -r22168 | sfisher | 2007-06-22 15:44:51 -0700 (Fri, 22 Jun 2007) | 4 lines +r28858 | tuexen | 2009-06-27 05:14:18 -0700 (Sat, 27 Jun 2009) | 10 lines Changed paths: - M /trunk/asn1/Makefile.nmake - - -Remove gsm_ss and MAP_Dialogue from Windows makefile + M /trunk/wiretap/pcapng.c +If all interfaces use the same encapsulation, use +this a the file encapsulation. ------------------------------------------------------------------------- -r22169 | gerald | 2007-06-22 17:00:57 -0700 (Fri, 22 Jun 2007) | 2 lines -Changed paths: - M /trunk/epan/crypt/airpdcap.c +This fixes a bug where you can not save a file +in libpcap format when you captured it as a +pcapng one. -A recent checkin broke wpa-psk keys; fix it. +This fix will be scheduled for Wireshark 1.2.1 +and higher. ------------------------------------------------------------------------ -r22170 | sfisher | 2007-06-22 22:58:01 -0700 (Fri, 22 Jun 2007) | 7 lines +r28859 | tuexen | 2009-06-27 05:41:06 -0700 (Sat, 27 Jun 2009) | 7 lines Changed paths: - M /trunk/docbook/wsug_src/WSUG_chapter_statistics.xml - M /trunk/gtk/io_stat.c - M /trunk/gtk/pixmap_save.c + M /trunk/wiretap/libpcap.c + M /trunk/wiretap/pcap-common.c + M /trunk/wiretap/pcap-common.h + M /trunk/wiretap/pcapng.c +This patch +* adds an encapsulation argument to pcap_write_phdr. +* writes the pseudo header when writing pcapng files. -Updates to initial check-in of pixmap saving feature: - - - Bump minimum GTK version from 2.4 to 2.6 in code and users manual - - Free some strings after we're done with them - +This fixes a bug where you could not write pcapng files +when using encapsulations requiring pseudo headers. ------------------------------------------------------------------------ -r22171 | etxrab | 2007-06-23 08:31:37 -0700 (Sat, 23 Jun 2007) | 1 line +r28860 | etxrab | 2009-06-27 05:41:39 -0700 (Sat, 27 Jun 2009) | 3 lines Changed paths: - M /trunk/epan/dissectors/packet-ber.c + M /trunk/epan/dissectors/packet-ieee80211.c -Fix a typo. +From Greg Schwendimann: +802.11 decryption is broken +https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=3590 ------------------------------------------------------------------------ -r22172 | etxrab | 2007-06-23 08:32:36 -0700 (Sat, 23 Jun 2007) | 1 line +r28861 | etxrab | 2009-06-27 06:37:03 -0700 (Sat, 27 Jun 2009) | 2 lines Changed paths: - M /trunk/asn1/ansi_map/ansi_map.asn - M /trunk/asn1/ansi_map/packet-ansi_map-template.c - M /trunk/epan/dissectors/packet-ansi_map.c + M /trunk/asn1/h248/h248.cnf + M /trunk/asn1/h248/packet-h248-template.c + M /trunk/epan/dissectors/packet-h248.c + M /trunk/epan/dissectors/packet-h248.h -Try to fix some GCC warnings. +From yin sun: +h248 term wildcard enhancement ------------------------------------------------------------------------ -r22173 | gal | 2007-06-23 22:09:42 -0700 (Sat, 23 Jun 2007) | 6 lines +r28862 | tuexen | 2009-06-27 08:20:44 -0700 (Sat, 27 Jun 2009) | 9 lines Changed paths: - M /trunk/epan/dissectors/packet-clnp.c - -This patch fixes reassembly when receiving a SES MINOR SYNC POINT and a -COTP DT Data (class 1) fragment in the same frame. Also added the -generated dst_ref and a reference to the "COTP segment data" to the -tree. + M /trunk/wiretap/pcapng.c + M /trunk/wiretap/wtap-int.h +Add support for writing pcapng files with multiple +encapsulations. +This fixes a bug reported by Sake during the +Sharkfest 09. Thanks for providing a +Netscreen tracefile with multiple link layer +types. +This patch will be included in Wireshark 1.2.1 +and higher. ------------------------------------------------------------------------ -r22174 | gal | 2007-06-23 22:14:39 -0700 (Sat, 23 Jun 2007) | 6 lines +r28863 | tuexen | 2009-06-27 09:08:18 -0700 (Sat, 27 Jun 2009) | 3 lines Changed paths: - M /trunk/epan/reassemble.c - -Added a new function, fragment_end_seq_next(), to end the -fragmented data without adding an empty data fragment. -This is used by the RTSE dissector which can't identify the -last fragment until after it has been added. + M /trunk/wiretap/libpcap.c + M /trunk/wiretap/pcap-common.c + M /trunk/wiretap/pcap-common.h + M /trunk/wiretap/pcapng.c +Cleanup. Should be included in Wireshark 1.2.1 and higher to keep +merging future bug fixes simple. ------------------------------------------------------------------------ -r22175 | gal | 2007-06-23 22:22:09 -0700 (Sat, 23 Jun 2007) | 3 lines +r28864 | tuexen | 2009-06-27 10:33:23 -0700 (Sat, 27 Jun 2009) | 3 lines Changed paths: - M /trunk/asn1/x420/x420.cnf - M /trunk/epan/dissectors/packet-x420.c - -This patch adds s4406 type to COL_INFO, as for X420. + M /trunk/wiretap/pcapng.c +Another cleanup. We are now back to Ulf's original +model of data handling. ------------------------------------------------------------------------ -r22176 | gal | 2007-06-23 22:28:27 -0700 (Sat, 23 Jun 2007) | 8 lines +r28865 | tuexen | 2009-06-27 11:10:10 -0700 (Sat, 27 Jun 2009) | 3 lines Changed paths: - M /trunk/AUTHORS - M /trunk/asn1/pres/packet-pres-template.c - M /trunk/asn1/rtse/packet-rtse-template.c - M /trunk/epan/dissectors/packet-pres.c - M /trunk/epan/dissectors/packet-rtse.c - M /trunk/epan/dissectors/packet-ses.c - M /trunk/epan/dissectors/packet-ses.h - -This patch adds RTSE reassembly. The reassembly is done when -receiving a SES MAJOR SYNC POINT, as this indicates the end of the -COTP DT Data stream. Previous the RTSE dissector was called when -receiving a COTP DT Data fragment with the "last data unit" bit set, -but this does not work with messages fragmented in RTSE. Reassembly -can be turned off in the preferences. + M /trunk/wiretap/libpcap.c +Fix copy/paste error introduced in rev. 28863. +Thanks to Guy for finding and reporting it. ------------------------------------------------------------------------ -r22177 | etxrab | 2007-06-24 01:13:11 -0700 (Sun, 24 Jun 2007) | 1 line +r28866 | tuexen | 2009-06-27 11:50:13 -0700 (Sat, 27 Jun 2009) | 6 lines Changed paths: - M /trunk/epan/libwireshark.def - M /trunk/epan/reassemble.h - -Export fragment_end_seq_next to get the Windows buildbot going again. ------------------------------------------------------------------------- -r22178 | gal | 2007-06-24 01:23:26 -0700 (Sun, 24 Jun 2007) | 3 lines -Changed paths: - M /trunk/asn1/x420/Makefile.nmake - A /trunk/asn1/x420/ftbp.asn - M /trunk/asn1/x420/packet-x420-template.c - M /trunk/asn1/x420/x420-exp.cnf - M /trunk/asn1/x420/x420.cnf - M /trunk/epan/dissectors/Makefile.common - D /trunk/epan/dissectors/packet-ftbp.c - D /trunk/epan/dissectors/packet-ftbp.h - M /trunk/epan/dissectors/packet-x420.c - M /trunk/epan/dissectors/packet-x420.h - -Consolidation of FTBP dissector into the X420 dissector. + M /trunk/wiretap/pcapng.c +Accept file snaplen larger than WTAP_MAX_PACKET_SIZE, +text2pcap uses 102400. +This fixes bug 3620. Thanks to Tyson Key for reporting the bug +and providing capture files. +This fix should be included in Wireshark 1.2.1 and higher. ------------------------------------------------------------------------ -r22179 | gal | 2007-06-24 01:24:49 -0700 (Sun, 24 Jun 2007) | 3 lines +r28867 | rbalint | 2009-06-27 21:20:10 -0700 (Sat, 27 Jun 2009) | 4 lines Changed paths: - D /trunk/asn1/ftbp - -Delete the associated asn2wrs files for the FTBP dissector + M /trunk/configure.in +Strictly require flex instead of allowing lex, too. +It compiles now. +This fixes bug 1641. ------------------------------------------------------------------------ -r22180 | etxrab | 2007-06-24 02:18:36 -0700 (Sun, 24 Jun 2007) | 1 line +r28868 | tuexen | 2009-06-28 04:09:24 -0700 (Sun, 28 Jun 2009) | 7 lines Changed paths: - M /trunk/asn1/ansi_map/ansi_map.asn - M /trunk/asn1/ansi_map/packet-ansi_map-template.c - M /trunk/epan/dissectors/packet-ansi_map.c - -Try to fix some more GCC warnings. ------------------------------------------------------------------------- -r22181 | sahlberg | 2007-06-24 10:23:55 -0700 (Sun, 24 Jun 2007) | 9 lines -Changed paths: - M /trunk/asn1/ldap/packet-ldap-template.c - M /trunk/epan/dissectors/packet-ldap.c - -remove some compiler warning due to unused pinfo parameter - -a SASL encapsulated ldap blob can contain more than one LDAP message so -the rest_is_pad parameter is bogus and thus removed. + M /trunk/wiretap/pcapng.c -make dissect_ldap_pdu handle when we have more than one LDAP message -inside one sasl blob +Stop loading a pcapng file with multiple section header blocks. +This fixes a bug reported by Tyson Key as a follow up of Bug 3560. +Also some cleanups and debug output improvements. +Thanks to Tyson Key for reporting the bug and providing a tracefile. +This fix will be included in Wireshark 1.2.1 and higher. ------------------------------------------------------------------------ -r22182 | sfisher | 2007-06-24 17:26:31 -0700 (Sun, 24 Jun 2007) | 4 lines +r28869 | gerald | 2009-06-28 08:03:26 -0700 (Sun, 28 Jun 2009) | 1 line Changed paths: - M /trunk/asn1/Makefile.am - M /trunk/asn1/Makefile.nmake - - -Fix Windows builds and dist after revision 22179 removed the FTBP dissector - + M /trunk/epan/enterprise-numbers + M /trunk/manuf +[Automatic manuf and enterprise-numbers update for 2009-06-28] ------------------------------------------------------------------------ -r22183 | etxrab | 2007-06-24 23:10:36 -0700 (Sun, 24 Jun 2007) | 9 lines +r28872 | etxrab | 2009-06-28 08:18:27 -0700 (Sun, 28 Jun 2009) | 4 lines Changed paths: - M /trunk/epan/dissectors/packet-tipc.c + M /trunk/epan/dissectors/packet-homeplug.c -From Martin Peylo: -Changes are only for protocol version 2. +From Jon Smirl: +More packet decoding for Intellon powerline devices. -The changes are: -- dissect "TIPC Bundler Protocol" messages correctly -- search for other dissectors which want to dissect encapsulated data according to the TIPC user or TIPC type of a message. The data dissection is difficult since a TIPC data message does not necessarily a "type" set. So for the moment - while TIPC is not widely used - just triggering for the user of a message will be sufficient for people looking into the TIPC protocol. -- "Dissect TIPC data" in the preferences is now switched on by default -- to show undissected data, the "data" dissector is now used. -- corrected some typos +From me put proto_register_homeplug() last in the file and whitespace changes. ------------------------------------------------------------------------ -r22184 | kukosa | 2007-06-25 01:58:27 -0700 (Mon, 25 Jun 2007) | 3 lines +r28873 | etxrab | 2009-06-28 08:22:43 -0700 (Sun, 28 Jun 2009) | 3 lines Changed paths: - M /trunk/epan/dissectors/packet-q932-ros.c - M /trunk/tools/asn2wrs.py - -- fix field type FT_... for SelectionType -- fix OPTIONAL handling in CLASS definition -- Q.932 ROS regenerated ------------------------------------------------------------------------- -r22185 | kukosa | 2007-06-25 03:26:21 -0700 (Mon, 25 Jun 2007) | 1 line -Changed paths: - M /trunk/tools/asn2wrs.py + M /trunk/gtk/tcp_graph.c -comment out some forgotten debug printouts +From Sean Walberg: +The title in the TCP sequence graphs is too short. +https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=3556 ------------------------------------------------------------------------ -r22186 | gerald | 2007-06-25 11:22:36 -0700 (Mon, 25 Jun 2007) | 2 lines +r28874 | rbalint | 2009-06-28 09:31:27 -0700 (Sun, 28 Jun 2009) | 4 lines Changed paths: - M /trunk/epan/dissectors/packet-eapol.c + D /trunk/aclocal-fallback/libgnutls.m4 + M /trunk/configure.in -Fix logic to properly ignore (for now) encrypted keys and group keys. +Detect gnutls via pkg-config instead of the deprecated libgnutls-config. +Based on patch from Andreas Metzler. +This fixes bug 3627. ------------------------------------------------------------------------ -r22187 | etxrab | 2007-06-25 11:40:17 -0700 (Mon, 25 Jun 2007) | 1 line +r28875 | jake | 2009-06-28 09:39:31 -0700 (Sun, 28 Jun 2009) | 1 line Changed paths: - M /trunk/asn1/cmip/Makefile - M /trunk/asn1/cmip/Makefile.nmake - M /trunk/asn1/cmip/cmip-exp.cnf - M /trunk/asn1/cmip/cmip.cnf - M /trunk/asn1/cmip/packet-cmip-template.c - M /trunk/epan/dissectors/packet-cmip.c - M /trunk/epan/dissectors/packet-cmip.h + M /trunk/epan/dissectors/packet-hip.c -Generate CMIP from original asn1 files with -X and -T option. +Make dissector handle unexpected data better. ------------------------------------------------------------------------ -r22188 | sfisher | 2007-06-25 11:59:43 -0700 (Mon, 25 Jun 2007) | 6 lines +r28876 | guy | 2009-06-28 10:23:07 -0700 (Sun, 28 Jun 2009) | 3 lines Changed paths: - M /trunk/capture_opts.c - - -Fix bug #1665 / From Nikns Siankin: - -Fix compilation on OpenBSD. This needs to go into 0.99.6 release. - - ------------------------------------------------------------------------- -r22189 | sfisher | 2007-06-25 12:29:02 -0700 (Mon, 25 Jun 2007) | 7 lines -Changed paths: - M /trunk/epan/libwireshark.def - - -From Frank Stratemeier: - -I added rval_to_str, match_strrval and match_strrval_idx to -libwireshark.def for being available in plugins. + M /trunk/aclocal-flags +We only support GLib 2.x/GTK+ 2.x, which uses pkg-config, not +gtk-config; use it instead. ------------------------------------------------------------------------ -r22190 | sfisher | 2007-06-25 12:40:37 -0700 (Mon, 25 Jun 2007) | 7 lines +r28877 | tuexen | 2009-06-28 11:22:15 -0700 (Sun, 28 Jun 2009) | 3 lines Changed paths: - M /trunk/asn1/Makefile.am - M /trunk/asn1/x420/Makefile - M /trunk/asn1/x420/Makefile.nmake - - -From Stig Bjorlykke: - -This patch fixes building x420 with ftbp on Unix platform and adds -ftbp.asn to the tarball. + M /trunk/wiretap/pcap-common.c + M /trunk/wiretap/wtap.h +Add support for DLT_PPP_WITH_DIR. This fixes bug 3619. +Thanks for Tyson Key for reporting the issue. ------------------------------------------------------------------------ -r22191 | etxrab | 2007-06-25 12:51:23 -0700 (Mon, 25 Jun 2007) | 2 lines +r28878 | wmeier | 2009-06-28 13:01:37 -0700 (Sun, 28 Jun 2009) | 3 lines Changed paths: - M /trunk/epan/dissectors/packet-ipmi.c + M /trunk/gtk/proto_dlg.c -From Flavio Leitner: -Fix IPMI Completion Codes. ------------------------------------------------------------------------- -r22192 | jake | 2007-06-25 13:47:45 -0700 (Mon, 25 Jun 2007) | 2 lines -Changed paths: - M /trunk/epan/dissectors/packet-edonkey.c +Analyze!Enabled Protocols: Fix so type-ahead find OK w/o needing to first select a row. + Ditto when clicking on a column header to change the sort order. -From Lukazs M.: -Small patch for packet-edonkey.c (stupid mistakes are the easiest to made :-)) ------------------------------------------------------------------------ -r22193 | jake | 2007-06-26 00:02:48 -0700 (Tue, 26 Jun 2007) | 2 lines +r28879 | ulfl | 2009-06-28 14:13:51 -0700 (Sun, 28 Jun 2009) | 3 lines Changed paths: - M /trunk/epan/dissectors/packet-ospf.c + M /trunk/gtk/capture_if_details_dlg_win32.c -Fix for bug 1658: -Add Do Not Age bit interpretation. ------------------------------------------------------------------------- -r22194 | etxrab | 2007-06-26 10:10:05 -0700 (Tue, 26 Jun 2007) | 1 line -Changed paths: - M /trunk/asn1/cmip/cmip.cnf - M /trunk/asn1/gnm/Makefile.nmake - M /trunk/asn1/gnm/gnm.cnf - M /trunk/epan/dissectors/packet-cmip.c - M /trunk/epan/dissectors/packet-gnm.c +fix bug #3439 (thanks to Kovarththanan Rajaratnam), make WS compilable under MSVC2005(EE) again. -Try to fix some GCC warnings +Some definitions are not available on MSVC2005. This fix "detects" the MSVC version used, it might still not work with MSVC2008EE though (I guess the required definitions are depending on the Windows SDK installed). ------------------------------------------------------------------------ -r22195 | gerald | 2007-06-26 12:38:44 -0700 (Tue, 26 Jun 2007) | 2 lines +r28880 | gal | 2009-06-29 06:01:54 -0700 (Mon, 29 Jun 2009) | 9 lines Changed paths: - M /trunk/capture_info.c - M /trunk/epan/dissectors/packet-ppi.c - A /trunk/epan/dissectors/packet-ppi.h - M /trunk/epan/libwireshark.def + D /trunk/packaging/portableapps/win32/WiresharkPortable.ini + M /trunk/packaging/portableapps/win32/WiresharkPortable.nsi + A /trunk/packaging/portableapps/win32/WiresharkPortable.tmpl + M /trunk/packaging/portableapps/win32/makefile.nmake -Add capture counts for PPI. +Changes to address bug 3547: ------------------------------------------------------------------------- -r22196 | etxrab | 2007-06-26 13:49:21 -0700 (Tue, 26 Jun 2007) | 1 line -Changed paths: - M /trunk/asn1/cmip/cmip.cnf - M /trunk/epan/dissectors/packet-cmip.c +1) Make sure WiresharkPortable.nsi uses correct WinPcap version (from config.nmake), and also vcredist. +2) Automatically generate WiresharkPortable.ini with correct default values +3) Include readme.txt in the distribution so that users know how to use WiresharkPortable.ini -Try to fix the last defined but not used warnings. ------------------------------------------------------------------------- -r22198 | gerald | 2007-06-26 22:39:13 -0700 (Tue, 26 Jun 2007) | 3 lines -Changed paths: - M /trunk/gtk/export_object.c +Thanks to Kovarththanan Rajaratnam for basic patch. -If we have problems with "Save All" in the HTTP object list, show a single -error dialog instead of one dialog per unsaved file. ------------------------------------------------------------------------ -r22199 | etxrab | 2007-06-26 23:03:13 -0700 (Tue, 26 Jun 2007) | 1 line +r28881 | etxrab | 2009-06-29 12:24:14 -0700 (Mon, 29 Jun 2009) | 2 lines Changed paths: - D /trunk/asn1/ldap/README + M /trunk/epan/dissectors/Makefile.common + M /trunk/epan/dissectors/packet-atm.c + M /trunk/epan/dissectors/packet-atm.h + M /trunk/epan/dissectors/packet-bfd.c + M /trunk/epan/dissectors/packet-mpls.c + M /trunk/epan/dissectors/packet-pw-atm.c + A /trunk/epan/dissectors/packet-pw-atm.h + M /trunk/epan/dissectors/packet-pw-cesopsn.c + M /trunk/epan/dissectors/packet-pw-common.c + M /trunk/epan/dissectors/packet-pw-common.h + M /trunk/epan/dissectors/packet-pw-satop.c + M /trunk/epan/packet_info.h -Remove obsolete README file. +From Artem Tamazov: +Added: PW ATM 1:1, AAL5 SDU, AAL5 PDU support + BFD fix + PW ATM OAM fix ------------------------------------------------------------------------ -r22200 | sfisher | 2007-06-26 23:28:02 -0700 (Tue, 26 Jun 2007) | 4 lines +r28882 | stig | 2009-06-29 13:16:20 -0700 (Mon, 29 Jun 2009) | 2 lines Changed paths: - M /trunk/asn1/Makefile.am - - -Fix distcheck + M /trunk/packaging/Makefile.am + M /trunk/packaging/portableapps/win32 +WiresharkPortable.ini -> WiresharkPortable.tmpl ------------------------------------------------------------------------ -r22201 | kukosa | 2007-06-26 23:54:48 -0700 (Tue, 26 Jun 2007) | 1 line +r28883 | jmayer | 2009-06-29 13:35:47 -0700 (Mon, 29 Jun 2009) | 2 lines Changed paths: - M /trunk/epan/libwireshark.def + M /trunk/epan/dissectors/packet-glbp.c -export prefs_register_static_text_preference() ------------------------------------------------------------------------- -r22202 | kukosa | 2007-06-27 01:13:53 -0700 (Wed, 27 Jun 2007) | 4 lines -Changed paths: - M /trunk/tools/asn2wrs.py +Add value for vfstate: active -- INSTANCE OF type support -- fix bug in empty SET handling -- partial support for OpenTypeFieldVal -- allow useful object classes in ObjectFieldSpec and ObjectSetFieldSpec ------------------------------------------------------------------------ -r22203 | kukosa | 2007-06-27 07:26:17 -0700 (Wed, 27 Jun 2007) | 1 line +r28884 | wmeier | 2009-06-29 13:59:26 -0700 (Mon, 29 Jun 2009) | 3 lines Changed paths: - M /trunk/tools/asn2wrs.py + M /trunk/epan/dissectors/packet-btl2cap.c -check conflict in CLASS fields redefinition ------------------------------------------------------------------------- -r22204 | etxrab | 2007-06-27 10:02:47 -0700 (Wed, 27 Jun 2007) | 1 line -Changed paths: - M /trunk/asn1/cmip/cmip-exp.cnf - M /trunk/asn1/cmip/cmip.cnf - M /trunk/asn1/cmip/packet-cmip-template.c - M /trunk/epan/dissectors/packet-cmip.c - M /trunk/epan/dissectors/packet-cmip.h +From Kovarththanan Rajaratnam: Fix for Bug #3572 +[http://bugs.wireshark.org/bugzilla/show_bug.cgi?id=3572] -Try to fix the last defined but not used warnings(again). ------------------------------------------------------------------------ -r22205 | etxrab | 2007-06-27 10:03:25 -0700 (Wed, 27 Jun 2007) | 1 line +r28885 | rbalint | 2009-06-29 15:22:30 -0700 (Mon, 29 Jun 2009) | 3 lines Changed paths: - M /trunk/epan/dissectors/Makefile.common + M /trunk/epan/dissectors/packet-data.c + +Added option to show not dissected packet data on a separate packet bytes pane. +It makes offsets in the not dissected data easier to follow. -Fix distcheck ------------------------------------------------------------------------ -r22206 | gal | 2007-06-27 10:42:41 -0700 (Wed, 27 Jun 2007) | 3 lines +r28886 | gerald | 2009-06-29 16:08:05 -0700 (Mon, 29 Jun 2009) | 3 lines Changed paths: - M /trunk/asn1/s4406/s4406.asn - M /trunk/epan/dissectors/packet-s4406.c - -This patch changes ExemptedAddressSeq to a SEQUENCE OF. + M /trunk/gtk/airpcap_dlg.c + M /trunk/gtk/airpcap_dlg.h + M /trunk/gtk/airpcap_gui_utils.c + M /trunk/gtk/airpcap_gui_utils.h + M /trunk/gtk/keys.h + M /trunk/gtk/main_airpcap_toolbar.c +Fix a couple of AirPcap channel/offset bugs. Remove an unused +routine. Fixup whitespace in a couple of places. ------------------------------------------------------------------------ -r22207 | gal | 2007-06-27 10:51:19 -0700 (Wed, 27 Jun 2007) | 3 lines +r28887 | guy | 2009-06-29 17:32:20 -0700 (Mon, 29 Jun 2009) | 2 lines Changed paths: - M /trunk/asn1/pres/packet-pres-template.c - M /trunk/epan/dissectors/packet-pres.c - -This patch make PRES context identifiers conversation aware. + M /trunk/gtk/airpcap_gui_utils.c +Put in missing newline at the end. ------------------------------------------------------------------------ -r22208 | gal | 2007-06-27 10:57:44 -0700 (Wed, 27 Jun 2007) | 4 lines +r28888 | stig | 2009-06-30 01:28:21 -0700 (Tue, 30 Jun 2009) | 2 lines Changed paths: - M /trunk/asn1/rtse/packet-rtse-template.c - M /trunk/epan/dissectors/packet-rtse.c - -This patch adds a check for octet string in RTSE reassembly. -If not an octet string the data is handled as ordinary RTSE APDU. + M /trunk/asn1/ldap/packet-ldap-template.c + M /trunk/epan/dissectors/packet-ldap.c +Cleanup protocol name for ldap. ------------------------------------------------------------------------ -r22209 | gal | 2007-06-27 11:03:23 -0700 (Wed, 27 Jun 2007) | 5 lines +r28889 | stig | 2009-06-30 03:38:00 -0700 (Tue, 30 Jun 2009) | 6 lines Changed paths: - M /trunk/asn1/x411/x411.cnf - M /trunk/epan/dissectors/packet-x411.c + M /trunk/asn1/ldap/packet-ldap-template.c + M /trunk/epan/dissectors/packet-ldap.c -This patch will set correct extension_id for ExtensionAttributeType -(error introduced in r22043), and fix printing of CAP values in -oraddress (error introduced in r22054). +Changed check for having multiple ldap PDU's in one frame. +The previous check is incorrect when the first ldap frame in the capture is +selected and the filter is changed, or selecting "Follow TCP Stream". +Also removed check_col(). ------------------------------------------------------------------------ -r22210 | gerald | 2007-06-27 12:02:58 -0700 (Wed, 27 Jun 2007) | 3 lines +r28890 | stig | 2009-06-30 05:26:11 -0700 (Tue, 30 Jun 2009) | 2 lines Changed paths: - M /trunk/epan/crypt/airpdcap.c + M /trunk/epan/dissectors/packet-simulcrypt.c -Make the WPA passphrase a percent-escaped string. Constify and GLib-ize -some variables. +Always register to tcp.port to be able to decode as. ------------------------------------------------------------------------ -r22211 | gerald | 2007-06-27 14:03:25 -0700 (Wed, 27 Jun 2007) | 4 lines +r28891 | wmeier | 2009-06-30 06:57:26 -0700 (Tue, 30 Jun 2009) | 6 lines Changed paths: - M /trunk/gtk/airpcap_dlg.c + M /trunk/epan/dissectors/packet-radius.c -In the wireless key management dialog, apply the 802.11 preferences when -the "OK," "Apply," or "Cancel" buttons are pressed. Remove some duplicate -code. Add a comment about "Cancel" not working as expected. +packet-radius: Fix exception CLEANUP handling when malformed attribute list/pair seen; +Fixes crash reported in Bug #3578. [https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=3578] +Essentially: CLEANUP_CALL_AND_POP wasn't being executed for certain error exits from + dissect_attribute_pairs() thus leaving a CLEANUP entry on the exception stack. +Also: vsa_buffer_table wasn't being destroyed if an exception occurred in dissect_attribute_pairs. ------------------------------------------------------------------------ -r22214 | sfisher | 2007-06-27 16:26:24 -0700 (Wed, 27 Jun 2007) | 8 lines +r28892 | sfisher | 2009-06-30 11:05:04 -0700 (Tue, 30 Jun 2009) | 14 lines Changed paths: + M /trunk/color_filters.c + M /trunk/file.c + M /trunk/gtk/Makefile.common M /trunk/gtk/capture_file_dlg.c + M /trunk/gtk/color_dlg.c + M /trunk/gtk/drag_and_drop.c + M /trunk/gtk/font_utils.c + M /trunk/gtk/gtkglobals.h + M /trunk/gtk/main.c + M /trunk/gtk/main.h + M /trunk/gtk/main_packet_list.c + M /trunk/gtk/main_packet_list.h + M /trunk/gtk/main_proto_draw.c + M /trunk/gtk/main_toolbar.c + M /trunk/gtk/menus.c + A /trunk/gtk/new_packet_list.c + A /trunk/gtk/new_packet_list.h + A /trunk/gtk/packet_list_store.c + A /trunk/gtk/packet_list_store.h + M /trunk/gtk/prefs_column.c + M /trunk/gtk/prefs_gui.c + M /trunk/gtk/prefs_stream.c + M /trunk/gtk/recent.c + M /trunk/ui_util.h -Fix a bug where you couldn't save individual packets from a file type that -Wireshark doesn't support writing to. The default in the drop-down menu -was libpcap, but since gtk_option_menu_set_history() doesn't send the -activate signal we set up earlier, you would have to manually click on the -drop-down and reselect libpcap for it to work. Now it works as expected. - - ------------------------------------------------------------------------- -r22215 | gerald | 2007-06-27 16:42:06 -0700 (Wed, 27 Jun 2007) | 2 lines -Changed paths: - M /trunk/Makefile.common - -Put airpcap.h back in the distribution. +Introduce experimental new feature: GTK2 tree view based packet list ------------------------------------------------------------------------- -r22217 | guy | 2007-06-27 16:53:24 -0700 (Wed, 27 Jun 2007) | 5 lines -Changed paths: - M /trunk/epan/dissectors/packet-radiotap.c +To use the GTK2 based packet list, define NEW_PACKET_LIST when compiling. +To do this with gcc, set the environment variable CPPFLAGS to +"-DNEW_PACKET_LIST" and re-run configure. -I think David Young needs to be granted the power of life and death -over anybody who edits the sys/net80211/ieee80211_radiotap.h header on -any operating system. I also think he needs to be willing to use that -power when necessary. +Many features do not yet work. This work began with prototypes by Ulf +quite a while back. I've put quite a bit of work into this so far and +as discussed with a few of the core team members at Sharkfest09 and it was +decided that it would be best to commit what I have so far to allow others to +help work on this. ------------------------------------------------------------------------- -r22220 | jake | 2007-06-28 12:03:47 -0700 (Thu, 28 Jun 2007) | 2 lines -Changed paths: - M /trunk/epan/dissectors/packet-bacapp.c -Fix for bug 1669: -Don't ditch the returned offset. ------------------------------------------------------------------------ -r22222 | martinm | 2007-06-29 03:47:46 -0700 (Fri, 29 Jun 2007) | 2 lines +r28893 | guy | 2009-06-30 12:09:18 -0700 (Tue, 30 Jun 2009) | 2 lines Changed paths: - M /trunk/gtk/sip_stat.c - M /trunk/tap-sipstat.c + M /trunk/gtk/menus.c -Add 422 "Session Timer Too Small" response code from RFC 4028 - ------------------------------------------------------------------------- -r22223 | kukosa | 2007-06-29 04:28:35 -0700 (Fri, 29 Jun 2007) | 2 lines -Changed paths: - M /trunk/tools/asn2wrs.py +Fix typo. -- implementation of OPERATION and ERROR objects support started -- new #.TABLE... directives to printout objects into output files ------------------------------------------------------------------------ -r22224 | martinm | 2007-06-29 09:16:57 -0700 (Fri, 29 Jun 2007) | 3 lines +r28894 | guy | 2009-06-30 12:10:11 -0700 (Tue, 30 Jun 2009) | 2 lines Changed paths: - M /trunk/epan/dissectors/packet-catapult-dct2000.c - M /trunk/wiretap/catapult_dct2000.c + M /trunk/gtk/main_packet_list.c -- Map gre -> IP -- Change a value string value to help an easily-frightened colleague +Fix typo. ------------------------------------------------------------------------ -r22226 | jake | 2007-06-29 12:00:46 -0700 (Fri, 29 Jun 2007) | 2 lines +r28895 | wmeier | 2009-06-30 12:52:43 -0700 (Tue, 30 Jun 2009) | 3 lines Changed paths: - M /trunk/epan/dissectors/packet-iax2.c - M /trunk/epan/dissectors/packet-iax2.h + M /trunk/epan/dissectors/packet-tte.c -Fix for bug 1585: -Add new frame types for IAX protocol and modem subclass dissection. ------------------------------------------------------------------------- -r22227 | etxrab | 2007-07-01 11:48:15 -0700 (Sun, 01 Jul 2007) | 2 lines -Changed paths: - M /trunk/asn1/cmip/Makefile.nmake - M /trunk/asn1/cmip/cmip-exp.cnf - M /trunk/asn1/cmip/cmip.cnf - M /trunk/asn1/cmip/packet-cmip-template.c - M /trunk/asn1/gnm/GNM.asn - M /trunk/asn1/gnm/Makefile - M /trunk/asn1/gnm/Makefile.nmake - M /trunk/asn1/gnm/gnm.cnf - M /trunk/asn1/gnm/packet-gnm-template.c - M /trunk/epan/dissectors/packet-cmip.c - M /trunk/epan/dissectors/packet-cmip.h - M /trunk/epan/dissectors/packet-gnm.c - M /trunk/epan/dissectors/packet-gnm.h +From: Benjamin Roch: Enhancements and small fixes for packet-tte.c dissector; +Also: a few minor mostly formatting changes by me. -Try to fix defined but not used warnings and use the nice new table function to get the -list of Opcodes. ------------------------------------------------------------------------ -r22228 | etxrab | 2007-07-02 02:20:19 -0700 (Mon, 02 Jul 2007) | 1 line +r28896 | gerald | 2009-06-30 13:28:26 -0700 (Tue, 30 Jun 2009) | 2 lines Changed paths: - M /trunk/asn1/cmip/cmip.cnf - M /trunk/epan/dissectors/packet-cmip.c + M /trunk/tools/checkAPIs.pl -Correct a copy paste error and rename fields. ------------------------------------------------------------------------- -r22229 | etxrab | 2007-07-02 05:12:49 -0700 (Mon, 02 Jul 2007) | 1 line -Changed paths: - M /trunk/asn1/ansi_map/ansi_map.asn - M /trunk/asn1/ansi_map/ansi_map.cnf - M /trunk/epan/dissectors/packet-ansi_map.c +Add assert and assert_perror to the 'abort' list. -Fix some of the 'defined but not used' warnings. ------------------------------------------------------------------------ -r22230 | kukosa | 2007-07-02 05:22:05 -0700 (Mon, 02 Jul 2007) | 2 lines +r28897 | gerald | 2009-06-30 13:59:51 -0700 (Tue, 30 Jun 2009) | 2 lines Changed paths: - M /trunk/tools/asn2wrs.py + M /trunk/epan/dissectors/packet-sflow.c -register type of OPERATION fields &ArgumentType and &ResultType and ERROR field &ParemeterType if other type than Typereference is used +Add some length checks. Fixes bug 3567. ------------------------------------------------------------------------ -r22231 | kukosa | 2007-07-02 05:25:13 -0700 (Mon, 02 Jul 2007) | 1 line +r28898 | guy | 2009-06-30 16:49:34 -0700 (Tue, 30 Jun 2009) | 4 lines Changed paths: - M /trunk/asn1/qsig/packet-qsig-template.c - M /trunk/asn1/qsig/qsig-cf.asn - M /trunk/asn1/qsig/qsig.cnf - M /trunk/epan/dissectors/packet-qsig.c + M /trunk/epan/dissectors/packet-mtp3.c -ARGUMENT and RESULT types of OPERATION can be used with new asn2wrs and need not to be redefined as assignment ------------------------------------------------------------------------- -r22232 | kukosa | 2007-07-02 06:03:39 -0700 (Mon, 02 Jul 2007) | 2 lines -Changed paths: - M /trunk/tools/asn2wrs.py +Get rid of assert() call; either the pointer will never be null, in +which case it won't crash, or it will be null, in which case that just +trades one crash for another, and we should fix the crash. -- HSTRING value support -- accept any type in CONSTRAINED BY ------------------------------------------------------------------------ -r22233 | etxrab | 2007-07-03 02:08:31 -0700 (Tue, 03 Jul 2007) | 2 lines +r28899 | guy | 2009-06-30 16:52:20 -0700 (Tue, 30 Jun 2009) | 3 lines Changed paths: - M /trunk/asn1/ulp/packet-ulp-template.c - M /trunk/asn1/ulp/ulp.cnf - M /trunk/epan/dissectors/packet-per.c - M /trunk/epan/dissectors/packet-ulp.c + M /trunk/epan/dissectors/packet-pw-common.c -Fix dissection of IP addresses in unaligned PER. -Add dissection of MSISDN and IMSI to the ULP dissector. ------------------------------------------------------------------------- -r22234 | kukosa | 2007-07-03 04:01:21 -0700 (Tue, 03 Jul 2007) | 1 line -Changed paths: - M /trunk/tools/asn2wrs.py +Don't crash if a null pointer is passed, just skip the appending of the +items. -small changes in value reference handling and parameterized object assignment handling ------------------------------------------------------------------------ -r22235 | sahlberg | 2007-07-03 05:02:16 -0700 (Tue, 03 Jul 2007) | 16 lines +r28900 | guy | 2009-06-30 16:56:26 -0700 (Tue, 30 Jun 2009) | 5 lines Changed paths: - M /trunk/epan/dissectors/packet-kerberos.c - -dissect a new AD-IF-RELEVANT type seen in some vista traces - -it is essentially - -Checksum ::= SEQUENCE { - type [0] INTEGER # -138 == HMAC-MD5 - checksum [1] OCTET STRING -} - -SignTicket ::= SEQUENCE { - enctype [0] INTEGER - signature [1] Checksum -} - + M /trunk/epan/dissectors/packet-pw-atm.c +Replace one assert() with DISSECTOR_ASSET(), so we don't crash, and get +rid of another, as the pointer in question is non-null in all calls (if +somebody adds another call with a null pointer, it'll crash when +dereferencing the pointer in any case). ------------------------------------------------------------------------ -r22236 | sahlberg | 2007-07-03 06:05:33 -0700 (Tue, 03 Jul 2007) | 11 lines +r28901 | jmayer | 2009-06-30 22:27:34 -0700 (Tue, 30 Jun 2009) | 5 lines Changed paths: - M /trunk/epan/dissectors/packet-isns.c - -relax the checking of [PG] PORTAL IP ADDRESS, some implementations are -apparently broken and send 64 bytes for these fields. - -mark these packets in the decode pane that the isns host is broken - - -change the calculation of offset to just increment it by tag size len -size and length one at the very end of the attribute dissector - + M /trunk/epan/dissectors/packet-ismp.c +- Put ISMP.EDP into the protocol column to make it clearer + that filtering on edp is not going to help +- Make it possible to filter on ismp.edp +- In case of edp fill info column ------------------------------------------------------------------------ -r22237 | gerald | 2007-07-03 17:53:03 -0700 (Tue, 03 Jul 2007) | 2 lines +r28902 | stig | 2009-07-01 00:21:13 -0700 (Wed, 01 Jul 2009) | 3 lines Changed paths: - M /trunk/packaging/nsis/Makefile.am - M /trunk/packaging/nsis/Makefile.nmake - D /trunk/packaging/nsis/WinPcap_4_0.exe - A /trunk/packaging/nsis/WinPcap_4_0_1.exe - M /trunk/packaging/nsis/wireshark.nsi - M /trunk/packaging/u3/win32/makefile.nmake - M /trunk/packaging/u3/win32/u3util.c + M /trunk/epan/dissectors/packet-simulcrypt.c -Switch to WinPcap 4.0.1. +Added support for Simulcrypt EMMG <-> MUX, +and generic support for other interfaces. ------------------------------------------------------------------------ -r22238 | jake | 2007-07-04 00:22:57 -0700 (Wed, 04 Jul 2007) | 2 lines +r28903 | etxrab | 2009-07-01 01:23:32 -0700 (Wed, 01 Jul 2009) | 2 lines Changed paths: - M /trunk/debian/changelog - M /trunk/debian/control - M /trunk/debian/copyright - M /trunk/debian/patches/00list - M /trunk/debian/patches/01_idl2deb.dpatch - M /trunk/debian/patches/02_asn2deb.dpatch - M /trunk/debian/patches/03_preferences.dpatch - M /trunk/debian/patches/04_drop-capabilities.dpatch - M /trunk/debian/patches/05_plugin-libdir.dpatch - M /trunk/debian/patches/06_giop-buffer.dpatch - M /trunk/debian/patches/07_gcc4.dpatch - D /trunk/debian/patches/08_ethereal-desktop-menu.dpatch - M /trunk/debian/patches/08_wireshark-desktop-menu.dpatch - D /trunk/debian/patches/09_idl2eth.dpatch - M /trunk/debian/patches/09_idl2wrs.dpatch - D /trunk/debian/patches/10_ethereal_gen.dpatch - D /trunk/debian/patches/11_diameter_vendors.dpatch - A /trunk/debian/pycompat - A /trunk/debian/pyversions - M /trunk/debian/rules - M /trunk/debian/tshark.files - M /trunk/debian/tshark.manpages - M /trunk/debian/wireshark-common.files - M /trunk/debian/wireshark-common.manpages - M /trunk/debian/wireshark-dev.docs - M /trunk/debian/wireshark-dev.files - M /trunk/debian/wireshark-dev.header-files - M /trunk/debian/wireshark-dev.manpages - M /trunk/debian/wireshark-dev.postinst - M /trunk/debian/wireshark-dev.prerm - M /trunk/debian/wireshark-root.desktop - M /trunk/debian/wireshark.files - M /trunk/debian/wireshark.manpages - M /trunk/debian/wireshark.menu - -From Frederic Peters: -Update of de Debian Packaging files from 0.99.2 to 0.99.6pre1. ------------------------------------------------------------------------- -r22239 | etxrab | 2007-07-04 06:27:44 -0700 (Wed, 04 Jul 2007) | 1 line -Changed paths: - A /trunk/asn1/camel/CAP-GPRS-ReferenceNumber.asn - A /trunk/asn1/camel/CAP-SMS-ops-args.asn - A /trunk/asn1/camel/CAP-U-ABORT-Data.asn - A /trunk/asn1/camel/CAP-classes.asn - A /trunk/asn1/camel/CAP-datatypes.asn - A /trunk/asn1/camel/CAP-errorcodes.asn - A /trunk/asn1/camel/CAP-errortypes.asn - A /trunk/asn1/camel/CAP-gprsSSF-gsmSCF-ops-args.asn - A /trunk/asn1/camel/CAP-gsmSCF-gsmSRF-ops-args.asn - A /trunk/asn1/camel/CAP-gsmSSF-gsmSCF-ops-args.asn - A /trunk/asn1/camel/CAP-object-identifiers.asn - A /trunk/asn1/camel/CAP-operationcodes.asn - M /trunk/asn1/gsmmap/gsm_map-exp.cnf - M /trunk/asn1/gsmmap/gsmmap.cnf - M /trunk/asn1/gsmmap/packet-gsm_map-template.c - M /trunk/asn1/inap/inap.cnf - M /trunk/asn1/inap/packet-inap-template.h - M /trunk/epan/dissectors/packet-gsm_map.c - M /trunk/epan/dissectors/packet-gsm_map.h - M /trunk/epan/dissectors/packet-inap.c - M /trunk/epan/dissectors/packet-inap.h + M /trunk/config.h.win32 + M /trunk/config.nmake + M /trunk/gtk/capture_file_dlg.c -Preparations for updated CAMEL dissector. +Make it possible to configure use of NEW_PACKET_LIST and fix +one compile error. It still fails in file.c trying to include gtk/gtk.h in new_packet_list.h ------------------------------------------------------------------------ -r22240 | gal | 2007-07-04 09:16:32 -0700 (Wed, 04 Jul 2007) | 4 lines +r28904 | stig | 2009-07-01 02:05:13 -0700 (Wed, 01 Jul 2009) | 2 lines Changed paths: - M /trunk/epan/dissectors/packet-smtp.c - -New preference to allow for the reassembly of SMTP DATA and subsequent dissection as Internet Message Format (imf). -(imf dissector in separate patch). + M /trunk/gtk/capture_file_dlg.c +Added NEW_PACKET_LIST guard for new_packet_list.h ------------------------------------------------------------------------ -r22241 | gal | 2007-07-04 09:24:20 -0700 (Wed, 04 Jul 2007) | 7 lines +r28905 | stig | 2009-07-01 04:12:58 -0700 (Wed, 01 Jul 2009) | 2 lines Changed paths: - M /trunk/epan/dissectors/Makefile.common - A /trunk/epan/dissectors/packet-imf.c - -New dissector for Internet Message Format (IMF) - RFC 2822. -It provides basic dissection of the text-based protocol, providing fields for filtering. -It also calls the multipart dissector for any MIME body that is found. -It includes very basic support for MIXER (RFC 2156) fields. -It also registers itself as "message/rfc822" in the media type table. + M /trunk/Makefile.nmake + M /trunk/config.nmake +Try to fix HAVE_NEW_PACKET_LIST handling. ------------------------------------------------------------------------ -r22242 | martinm | 2007-07-04 10:27:46 -0700 (Wed, 04 Jul 2007) | 2 lines +r28906 | etxrab | 2009-07-01 04:40:24 -0700 (Wed, 01 Jul 2009) | 1 line Changed paths: - M /trunk/epan/dissectors/packet-sip.c - -Make lines of raw SIP filterable. Fix a little whitespace. + M /trunk/config.nmake +Sligtly modify Stig's fix, I forgot the makefile change :-( ------------------------------------------------------------------------ -r22243 | martinm | 2007-07-05 02:58:09 -0700 (Thu, 05 Jul 2007) | 2 lines +r28907 | etxrab | 2009-07-01 07:37:02 -0700 (Wed, 01 Jul 2009) | 1 line Changed paths: - M /trunk/epan/dissectors/packet-catapult-dct2000.c - -Make timestamp a double to make filtering more useful. + M /trunk/file.c + M /trunk/gtk/new_packet_list.c + M /trunk/gtk/new_packet_list.h + M /trunk/gtk/packet_list_store.c + M /trunk/ui_util.h +Make the new packet list compile on Windows. ------------------------------------------------------------------------ -r22244 | etxrab | 2007-07-05 06:14:25 -0700 (Thu, 05 Jul 2007) | 2 lines +r28908 | gerald | 2009-07-01 08:56:12 -0700 (Wed, 01 Jul 2009) | 3 lines Changed paths: - M /trunk/epan/dissectors/packet-ber.c + M /trunk/gtk/airpcap_dlg.c + M /trunk/gtk/airpcap_gui_utils.c + M /trunk/gtk/airpcap_gui_utils.h + M /trunk/gtk/main_airpcap_toolbar.c -From Stig Bj?\195?\184rlykke: -This patch adds an option to packet-ber to show unexpected tags/data as unknown BER. It also fixes some offset/length combinations when adding the error message to the tree. ------------------------------------------------------------------------- -r22245 | etxrab | 2007-07-05 06:18:28 -0700 (Thu, 05 Jul 2007) | 1 line -Changed paths: - M /trunk/asn1/camel/Makefile - M /trunk/asn1/camel/Makefile.nmake - A /trunk/asn1/camel/TCAPMessages.asn - M /trunk/asn1/camel/camel.cnf - M /trunk/asn1/camel/packet-camel-template.c - M /trunk/asn1/camel/packet-camel-template.h - M /trunk/asn1/cmip/cmip.cnf - M /trunk/epan/dissectors/packet-camel.c - M /trunk/epan/dissectors/packet-camel.h +Fix a key entry bug in the decryption key dialog. Remove some unused / +unnecessary functions. Clean up code in a couple of places. -New Camel dissector built with -X and -T option and origninal ASN1 files. ------------------------------------------------------------------------ -r22246 | gal | 2007-07-05 09:19:36 -0700 (Thu, 05 Jul 2007) | 2 lines +r28909 | etxrab | 2009-07-01 10:39:19 -0700 (Wed, 01 Jul 2009) | 1 line Changed paths: - M /trunk/epan/dissectors/packet-multipart.c - -Allow for leading whitespace in parameters when looking for the boundary. + M /trunk/file.c + M /trunk/gtk/new_packet_list.c + M /trunk/gtk/new_packet_list.h + M /trunk/ui_util.h +Realy make the new packet list compile under Windows... ------------------------------------------------------------------------ -r22248 | gal | 2007-07-05 09:31:12 -0700 (Thu, 05 Jul 2007) | 3 lines +r28910 | guy | 2009-07-01 10:40:08 -0700 (Wed, 01 Jul 2009) | 2 lines Changed paths: - M /trunk/epan/dissectors/packet-multipart.c - -Consistent eol-style restored. + M /trunk/epan/dissectors/packet-pw-atm.c +Thou shalt not call assert() in dissectors. ------------------------------------------------------------------------ -r22250 | etxrab | 2007-07-05 14:29:53 -0700 (Thu, 05 Jul 2007) | 1 line +r28911 | gerald | 2009-07-01 12:36:24 -0700 (Wed, 01 Jul 2009) | 4 lines Changed paths: - M /trunk/asn1/camel/camel.cnf - M /trunk/asn1/camel/packet-camel-template.c - M /trunk/asn1/camel/packet-camel-template.h - M /trunk/epan/dissectors/packet-camel.c - M /trunk/epan/dissectors/packet-camel.h + M /trunk/epan/dissectors/packet-netflow.c -Try to get rid of the warnings. ------------------------------------------------------------------------- -r22251 | etxrab | 2007-07-05 14:51:12 -0700 (Thu, 05 Jul 2007) | 1 line -Changed paths: - M /trunk/diameter/chargecontrol.xml - M /trunk/diameter/dictionary.xml +Try to fix fuzzing errors in bug 3636. When dissecting an options +template, differentiate between Netflow v9 and IPFIX, which require +different interpretations. Add other minor fixes and comments. -Move 3GPP AVP:s to dictionary.xml chnge some AVP types to 'Time' as per 3GPP spec. ------------------------------------------------------------------------ -r22252 | sahlberg | 2007-07-05 15:01:58 -0700 (Thu, 05 Jul 2007) | 3 lines +r28912 | gerald | 2009-07-01 13:56:03 -0700 (Wed, 01 Jul 2009) | 2 lines Changed paths: - A /trunk/epan/dissectors/pidl/samr.cnf - A /trunk/epan/dissectors/pidl/samr.idl - -add initial samr idl and conformance file + M /trunk/epan/dissectors/packet-netflow.c +Add a couple of IPFIX labels where they differ from Netflow. ------------------------------------------------------------------------ -r22253 | sahlberg | 2007-07-05 15:03:35 -0700 (Thu, 05 Jul 2007) | 2 lines +r28913 | stig | 2009-07-01 14:20:18 -0700 (Wed, 01 Jul 2009) | 2 lines Changed paths: - M /trunk/epan/dissectors/pidl/samr.cnf - M /trunk/epan/dissectors/pidl/samr.idl + M /trunk/epan/dissectors/packet-simulcrypt.c -set propset eol-style to native +Added error value tables. ------------------------------------------------------------------------ -r22254 | sahlberg | 2007-07-05 15:19:28 -0700 (Thu, 05 Jul 2007) | 3 lines +r28914 | gerald | 2009-07-01 16:36:35 -0700 (Wed, 01 Jul 2009) | 2 lines Changed paths: - M /trunk/epan/dissectors/pidl/samr.cnf - -add policy handle tracking to samr.cnf + M /trunk/epan/dissectors/packet-netflow.c +Fix a couple of labels. ------------------------------------------------------------------------ -r22255 | sahlberg | 2007-07-05 21:05:06 -0700 (Thu, 05 Jul 2007) | 6 lines +r28915 | gerald | 2009-07-01 16:36:51 -0700 (Wed, 01 Jul 2009) | 5 lines Changed paths: - M /trunk/epan/dissectors/pidl/samr.cnf - M /trunk/epan/dissectors/pidl/samr.idl - -redo the lsa_String dissector we temporarily host in samr until lsa has -been pidlified + M /trunk/dumpcap.c + M /trunk/file.c + M /trunk/gtk/follow_stream.c + M /trunk/gtk/follow_stream.h + M /trunk/gtk/follow_tcp.c + M /trunk/gtk/hostlist_table.c + M /trunk/gtk/iax2_analysis.c + M /trunk/gtk/print_dlg.c + M /trunk/gtk/rtp_analysis.c + M /trunk/tempfile.c + M /trunk/tempfile.h -prettify some strings and show them in the summary line +Updates to create_tempfile: + - Use g_get_tmp_dir, just like get_tempfile_path. + - Don't make the caller worry about the path buffer length. ------------------------------------------------------------------------ -r22256 | sahlberg | 2007-07-05 22:45:55 -0700 (Thu, 05 Jul 2007) | 4 lines +r28916 | gerald | 2009-07-01 19:50:24 -0700 (Wed, 01 Jul 2009) | 2 lines Changed paths: - M /trunk/epan/dissectors/pidl/samr.cnf - -some more prettification, show name of created users on the summary -line and also in the associated policy handle - + M /trunk/gtk/follow_stream.c ------------------------------------------------------------------------- -r22257 | etxrab | 2007-07-06 03:03:19 -0700 (Fri, 06 Jul 2007) | 2 lines -Changed paths: - M /trunk/epan/dissectors/packet-ethertype.c - M /trunk/epan/etypes.h +Fix the build. -From Seehofer, Markus: -ETHERTYPE for IEEE1588/PTP ------------------------------------------------------------------------ -r22258 | etxrab | 2007-07-06 03:07:25 -0700 (Fri, 06 Jul 2007) | 3 lines +r28917 | stig | 2009-07-01 23:51:27 -0700 (Wed, 01 Jul 2009) | 3 lines Changed paths: M /trunk/epan/dissectors/packet-mip6.c M /trunk/epan/dissectors/packet-mip6.h -From Nicolas Dichtel: -First patch is only to reindent the packet-mip6 files. -Second patch adds PMIPv6 options (draft-ietf-netlmm-proxymip6-01.txt) and Mobile Node Identifier Option (RFC4283). ------------------------------------------------------------------------- -r22259 | jake | 2007-07-06 13:34:20 -0700 (Fri, 06 Jul 2007) | 1 line -Changed paths: - M /trunk/packaging/nsis/wireshark.nsi +From Albert Chin: +Small patch to make it compile on AIX. -Have the installer propose to install 4.0.1 over 4.0.0. ------------------------------------------------------------------------ -r22260 | sahlberg | 2007-07-06 15:14:04 -0700 (Fri, 06 Jul 2007) | 3 lines +r28918 | stig | 2009-07-02 02:08:11 -0700 (Thu, 02 Jul 2009) | 5 lines Changed paths: - M /trunk/epan/dissectors/pidl/samr.cnf - M /trunk/epan/dissectors/pidl/samr.idl + M /trunk/gtk/main.c -add dissection of the bits for the Connect[0-5] access_masks +Move updating menus with new recent values to a point after we have created +the new packet list, because we relay on the columns for time values. +This fixes bug 3640. ------------------------------------------------------------------------ -r22261 | jake | 2007-07-06 15:27:03 -0700 (Fri, 06 Jul 2007) | 1 line +r28919 | etxrab | 2009-07-02 09:54:20 -0700 (Thu, 02 Jul 2009) | 3 lines Changed paths: - M /trunk/wiretap/mpeg.c + M /trunk/epan/dissectors/packet-nfs.c + M /trunk/epan/dissectors/packet-nfs.h -Now it really can read MP3 files, without SIGABRT. +From Radek Vok?\195?\161l: +Support for new NFSv4 features. +https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=3258 ------------------------------------------------------------------------ -r22262 | jake | 2007-07-06 15:36:58 -0700 (Fri, 06 Jul 2007) | 9 lines +r28920 | gerald | 2009-07-02 10:20:27 -0700 (Thu, 02 Jul 2009) | 8 lines Changed paths: - M /trunk/epan/dissectors/packet-bacapp.c - M /trunk/epan/dissectors/packet-bacapp.h - -From Steve Karg: -Attached is a patch that fixes bug 1670 and related issues. -For the BACnet GetEventInformation-ACK request dissector: -1. Corrected BitString decoding for acknowledgedTransitions and eventEnable. -2. Corrected the ability to decode more than one event. -3. Grouped each item of the sequence using subtrees. Added more informative -text to Priority and Timestamp. -4. Corrected eventState to use BACnetEventState enumeration instead of -BACnetEventStateFilter. ------------------------------------------------------------------------- -r22263 | sahlberg | 2007-07-06 18:25:26 -0700 (Fri, 06 Jul 2007) | 3 lines -Changed paths: - M /trunk/epan/dissectors/pidl/samr.cnf - M /trunk/epan/dissectors/pidl/samr.idl + M /trunk/Makefile.am + M /trunk/Makefile.common + M /trunk/Makefile.nmake + M /trunk/config.h.win32 + M /trunk/configure.in + M /trunk/gtk/hostlist_table.c + D /trunk/mkstemp.c + D /trunk/mkstemp.h + M /trunk/tempfile.c + M /trunk/tempfile.h -add some more access masks +Pull mkstemp() into tempfile.c. That's the only place we use it now, and +it's arguably the only place we _should_ use it. Add create_tempdir() to +tempfile.c and use it to create a temp directory for IP maps. This +should fix bug 3530. +(This still doesn't work on IE 8 / Vista here. IE gives an access denied +error in OpenLayers.js, but this is a separate issue). ------------------------------------------------------------------------ -r22264 | sahlberg | 2007-07-06 20:34:30 -0700 (Fri, 06 Jul 2007) | 3 lines +r28921 | etxrab | 2009-07-02 11:22:41 -0700 (Thu, 02 Jul 2009) | 1 line Changed paths: - M /trunk/epan/dissectors/pidl/samr.cnf - -fix a typo - + M /trunk/gtk/packet_list_store.c +Don't resort the list for every row, the list will be in packet order any way. And "clicking" on the column titles will resort the list. ------------------------------------------------------------------------ -r22265 | sahlberg | 2007-07-07 14:47:27 -0700 (Sat, 07 Jul 2007) | 3 lines +r28922 | etxrab | 2009-07-02 11:24:26 -0700 (Thu, 02 Jul 2009) | 1 line Changed paths: - M /trunk/epan/dissectors/packet-dcerpc-samr.c - M /trunk/epan/dissectors/packet-dcerpc-samr.h - -add the new pidl created SAMR dissector - + M /trunk/gtk/packet_list_store.c +This time with the comment... ------------------------------------------------------------------------ -r22266 | etxrab | 2007-07-07 15:24:37 -0700 (Sat, 07 Jul 2007) | 1 line +r28923 | gerald | 2009-07-02 12:50:35 -0700 (Thu, 02 Jul 2009) | 2 lines Changed paths: - M /trunk/asn1/camel/camel.cnf - M /trunk/asn1/camel/packet-camel-template.c - M /trunk/asn1/camel/packet-camel-template.h - M /trunk/epan/dissectors/packet-camel.c - M /trunk/epan/dissectors/packet-camel.h - -Make hf fileds for ARGGUMENT RESULT and ERROR parameters. ------------------------------------------------------------------------- -r22267 | sahlberg | 2007-07-07 15:27:22 -0700 (Sat, 07 Jul 2007) | 9 lines -Changed paths: - M /trunk/epan/dissectors/packet-tcp.c - -bug 1550 -add a fix for ack/seq tracking when the tcp is broken and sends a -non-zero ack field for SYN packets. - -add a warning to the dissect pane that illustrates that these are broken -packets - - + M /trunk/epan/Makefile.nmake + M /trunk/epan/libwireshark.def ------------------------------------------------------------------------- -r22268 | jmayer | 2007-07-08 03:20:30 -0700 (Sun, 08 Jul 2007) | 30 lines -Changed paths: - M /trunk/tools/pidl/lib/Parse/Pidl/Wireshark/NDR.pm - M /trunk/tools/pidl/tests/ndr_align.pl - M /trunk/tools/pidl/tests/ndr_tagtype.pl +mkstemp cleanups. -Update from samba tree revision 23135 to 23750 -============================ Samba log start ============ ------------------------------------------------------------------------ -r23677 | abartlet | 2007-07-03 09:28:46 +0200 (Tue, 03 Jul 2007) | 6 lines +r28924 | tuexen | 2009-07-02 12:52:47 -0700 (Thu, 02 Jul 2009) | 4 lines Changed paths: - M /branches/SAMBA_4_0/source/pidl/tests/ndr_align.pl - M /branches/SAMBA_4_0/source/pidl/tests/ndr_tagtype.pl + M /trunk/wiretap/btsnoop.c -When I removed data_blob_equal, I clearly didn't test the PIDL code. +Patch from Alex Badea for Bug 3645. -Fix these to use the new data_blob_cmp() - -Andrew Bartlett +This fix will be included in Wireshark 1.2.1. ------------------------------------------------------------------------ -r23721 | sahlberg | 2007-07-05 09:19:14 +0200 (Thu, 05 Jul 2007) | 7 lines +r28925 | guy | 2009-07-02 13:10:05 -0700 (Thu, 02 Jul 2009) | 7 lines Changed paths: - M /branches/SAMBA_4_0/source/pidl/lib/Parse/Pidl/Wireshark/NDR.pm - -For unions, The TAG and the ARM are aligned independently. - -Move emitting ALIGN_TO_x_BYTES to after the tag has been dissected so the -alignment only affects the ARM. + M /trunk/wiretap/btsnoop.c +Don't dump out the raw link-layer type when noting that +KHciLoggerDatalinkTypeBCSP and KHciLoggerDatalinkTypeH5 aren't supported +- just explicitly say "BSCP" or "H5". +For unknown link-layer types, say "unknown or unsupported", as other +Wiretap modules do. ------------------------------------------------------------------------ ------------------------------------------------------------------------- -============================ Samba log end ============== - ------------------------------------------------------------------------- -r22269 | etxrab | 2007-07-08 07:38:07 -0700 (Sun, 08 Jul 2007) | 1 line -Changed paths: - M /trunk/asn1/acp133/Makefile - M /trunk/asn1/acp133/Makefile.nmake - M /trunk/epan/dissectors/packet-acp133.c - M /trunk/epan/dissectors/packet-acp133.h - -ACP123 with -X and -T option ------------------------------------------------------------------------- -r22270 | sahlberg | 2007-07-09 03:49:34 -0700 (Mon, 09 Jul 2007) | 5 lines +r28926 | gerald | 2009-07-02 13:35:46 -0700 (Thu, 02 Jul 2009) | 2 lines Changed paths: - M /trunk/epan/dissectors/packet-dcerpc-samr.c - M /trunk/epan/dissectors/pidl/samr.cnf - -rename all policy handles in samr to have a name that describes the type -of handle. - + M /trunk/epan/dissectors/packet-radiotap.c +Update documentation links. ------------------------------------------------------------------------ -r22271 | sahlberg | 2007-07-09 04:04:38 -0700 (Mon, 09 Jul 2007) | 12 lines +r28927 | gerald | 2009-07-02 13:35:58 -0700 (Thu, 02 Jul 2009) | 7 lines Changed paths: - M /trunk/epan/dissectors/packet-smb-sidsnooping.c - -disabling sid snooping in the code - -this module was never really finished and was therefore semi-useless. -disabled now since the change to samr broke it and the real fix to -unbreak it would be a substantial rewrite of it -(and adding a nice gui so one can see which sids are mapped...) - -disabled it but did not remove it since i do think the module is -useful IF it is completed with a lot more operations. + M /trunk/epan/dissectors/packet-netflow.c +From Kovarththanan Rajaratnam via bug 3567: +The template cache contains pointers that are session-scope (only freed in +netflow_reinit()) but still we use g_malloc(). This patch changes that so we +now use se_alloc(). With this patch I'm able to reproduce the crash +("Per-session memory corrupted"). ------------------------------------------------------------------------ -r22272 | sahlberg | 2007-07-09 05:37:20 -0700 (Mon, 09 Jul 2007) | 5 lines +r28928 | sfisher | 2009-07-02 14:06:24 -0700 (Thu, 02 Jul 2009) | 4 lines Changed paths: - M /trunk/epan/dissectors/packet-dcerpc-samr.c - M /trunk/epan/dissectors/packet-dcerpc-samr.h - M /trunk/epan/dissectors/pidl/samr.cnf - M /trunk/epan/dissectors/pidl/samr.idl - -make all rids use a single hf filter field - -dissect the Type of rid using lsa_Types - + M /trunk/gtk/new_packet_list.c +Allow the new packet list's columns to be moved back +and forth while the packet list is open without having +to go into the preferences. The new column ordering is +not saved for next time though. Perhaps it should be. ------------------------------------------------------------------------ -r22273 | sahlberg | 2007-07-09 05:50:57 -0700 (Mon, 09 Jul 2007) | 3 lines +r28929 | tuexen | 2009-07-02 15:04:22 -0700 (Thu, 02 Jul 2009) | 2 lines Changed paths: - M /trunk/epan/dissectors/packet-dcerpc-samr.c - M /trunk/epan/dissectors/pidl/samr.idl - -the sidtype is a 32bit enum not a standard enum + M /trunk/gtk/capture_file_dlg.c + M /trunk/ui_util.h +Get it compiling with -DNEW_PACKET_LIST on Mac OS X. ------------------------------------------------------------------------ -r22274 | sahlberg | 2007-07-09 06:05:52 -0700 (Mon, 09 Jul 2007) | 3 lines +r28930 | gerald | 2009-07-02 17:17:06 -0700 (Thu, 02 Jul 2009) | 2 lines Changed paths: - M /trunk/epan/dissectors/packet-dcerpc-samr.c - M /trunk/epan/dissectors/packet-dcerpc-samr.h - M /trunk/epan/dissectors/pidl/samr.cnf - M /trunk/epan/dissectors/pidl/samr.idl - -dissect lsa_Strings correctly in the samr dissector + M /trunk/epan/dissectors/packet-netflow.c +Try to allocate enough memory on all platforms. ------------------------------------------------------------------------ -r22275 | martinm | 2007-07-09 06:27:15 -0700 (Mon, 09 Jul 2007) | 4 lines +r28931 | wmeier | 2009-07-02 18:11:23 -0700 (Thu, 02 Jul 2009) | 12 lines Changed paths: - M /trunk/diameter/dictionary.xml - M /trunk/epan/dissectors/packet-diameter.c + M /trunk/epan/dfilter/semcheck.c + M /trunk/gtk/dfilter_expr_dlg.c -- Fix a broken comment in xml file -- Add/fix some AVPs -- Print unmatched command codes in decimal +From Kovarththanan Rajaratnam: Fixes for bug #3536 +(plus some additional changes by me). ------------------------------------------------------------------------- -r22277 | gerald | 2007-07-09 09:31:39 -0700 (Mon, 09 Jul 2007) | 6 lines -Changed paths: - M /trunk/file.c - M /trunk/gtk/packet_list.c - M /trunk/gtk/packet_list.h - M /trunk/ui_util.h +Handle BASE_RANGE_STRING display types properly + +We always treat header field info strings as value_string's undiscriminated. +However, if the header field info display is marked as BASE_RANGE_STRING, we +need to treat them as range_string's. This wasn't properly handled in the +filter expression dialog and in the filter toolbar which would cause a crash +upon referencing any fields marked as BASE_RANGE_STRING. -From Dustin Johnson: If "Update list of packets in real time" and -"Automatic scrolling in live capture" are both enabled, make the scroll -bar behavior more natural. If the packet list is scrolled to the -bottom, scroll automatically. If the user scrolls back, keep the packet -list scrolled at that point instead of jumping back to the end. ------------------------------------------------------------------------ -r22278 | gerald | 2007-07-09 09:36:29 -0700 (Mon, 09 Jul 2007) | 2 lines +r28932 | ulfl | 2009-07-03 02:12:43 -0700 (Fri, 03 Jul 2009) | 3 lines Changed paths: - M /trunk/gtk/airpcap_gui_utils.c + M /trunk/plugins/profinet/packet-dcerpc-pn-io.c + M /trunk/plugins/profinet/packet-pn-rt.c -From Dustin Johnson: AirPcap display update. +update to the latest PROFINET drafts +(defragmentation of RT fragments "FRAG-PDU" is still not implemented) ------------------------------------------------------------------------ -r22279 | jake | 2007-07-09 09:44:30 -0700 (Mon, 09 Jul 2007) | 1 line +r28933 | ulfl | 2009-07-03 02:35:40 -0700 (Fri, 03 Jul 2009) | 1 line Changed paths: - M /trunk/doc/README.developer + M /trunk/doc -Add a note on how to handle obsolete preferences +ignore copied ws.css for commits ------------------------------------------------------------------------ -r22280 | gerald | 2007-07-09 10:01:00 -0700 (Mon, 09 Jul 2007) | 2 lines +r28934 | tuexen | 2009-07-03 03:29:45 -0700 (Fri, 03 Jul 2009) | 2 lines Changed paths: - M /trunk/epan/dissectors/packet-ieee80211.c + M /trunk/plugins/profinet/packet-dcerpc-pn-io.c + M /trunk/plugins/profinet/packet-pn-rt.c -From Dustin Johnson: Fix a typo. +Make the compiler on Mac OS X happy... ------------------------------------------------------------------------ -r22281 | guy | 2007-07-09 13:27:38 -0700 (Mon, 09 Jul 2007) | 4 lines +r28935 | etxrab | 2009-07-03 04:45:42 -0700 (Fri, 03 Jul 2009) | 3 lines Changed paths: - M /trunk/configure.in - M /trunk/wiretap/configure.in - -Check %l[doux] first, when looking for the format to use with 64-bit -integral data types, so we handle LP64 platforms if "gint64" is just a -"long int". + M /trunk/epan/dissectors/packet-ndmp.c +From Chris Costa: +NDMP fragmentation fix. +https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=3395 ------------------------------------------------------------------------ -r22282 | jake | 2007-07-09 22:15:45 -0700 (Mon, 09 Jul 2007) | 1 line +r28936 | etxrab | 2009-07-03 06:05:45 -0700 (Fri, 03 Jul 2009) | 2 lines Changed paths: - M /trunk/epan/dissectors/packet-pana.c + M /trunk/asn1/s1ap/s1ap.cnf + M /trunk/config.nmake + M /trunk/epan/dissectors/packet-ndmp.c -Fix reserved bits bitmask. +Fix: +packet-ndmp.c:562: warning: unused parameter 'pinfo' ------------------------------------------------------------------------ -r22283 | martinm | 2007-07-10 06:20:37 -0700 (Tue, 10 Jul 2007) | 2 lines +r28937 | wmeier | 2009-07-03 09:03:02 -0700 (Fri, 03 Jul 2009) | 29 lines Changed paths: - M /trunk/diameter/dictionary.xml - A /trunk/diameter/etsie2e4.xml - M /trunk/packaging/nsis/wireshark.nsi - -Add ETSI e2/e4 Diameter applications + M /trunk/epan/dissectors/packet-radius.c + M /trunk/epan/radius_dict.l ------------------------------------------------------------------------- -r22284 | martinm | 2007-07-10 10:45:11 -0700 (Tue, 10 Jul 2007) | 2 lines -Changed paths: - M /trunk/epan/dissectors/packet-diameter.c +From: Tobias Witek: Fix processing of radius 'vendor specific attributes' -Allow filtering of whole AVP +In the RADIUS dissector, the function radius_register_avp_dissector() registers +vendors that are not already present in the dictionary hash-table. As far as I +can see, there are two problems with this: ------------------------------------------------------------------------- -r22285 | gerald | 2007-07-10 16:23:09 -0700 (Tue, 10 Jul 2007) | 2 lines -Changed paths: - M /trunk/epan/dissectors/packet-ieee80211.c +1. The function does not set the number of type/length octets and the has_flags + variable for that AVP, which is required to correctly decode AVP/VSA values +2. In some situations, the function is called _before_ radius_load_dictionary() +is called (for example for the vendor 3GPP (ID: 10415)) -Add a missing display filter. +Therefore, all vendor entries that are created by calling +radius_register_avp_dissector() leave their type_octets and length_octets un-initialized, +which causes incorrect decoding. ------------------------------------------------------------------------- -r22286 | gerald | 2007-07-11 11:08:14 -0700 (Wed, 11 Jul 2007) | 2 lines -Changed paths: - M /trunk/docbook/release-notes.xml +[Result: Radius dissector displays messages such as: + "Malformed Packet: RADIUS" and "Error/Malformed: Malformed Packet(Exception occurred)"] -Clean out the 0.99.6 material and seed for 0.99.7. +The attached patch fixes this problem by assuming that the dictionary knows the +'ground truth' about the type/length octet and the has_flags information and allows it to +overwrite these values even for vendors that have already been loaded. ------------------------------------------------------------------------- -r22287 | gerald | 2007-07-11 11:23:54 -0700 (Wed, 11 Jul 2007) | 2 lines -Changed paths: - M /trunk/epan/dissectors/Makefile.common - M /trunk/epan/dissectors/packet-ipsec.c +Also: (from Bill Meier): set the type/length octet and the has_flags variables to default +"standard" values (1,1,FALSE) in radius_register_avp_dissector(). -Move packet-ipsec.c to CLEAN_DISSECTOR_SRC. +Fixes Bug #3651 (and Bug #3635). +https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=3651 +https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=3635 ------------------------------------------------------------------------ -r22288 | sfisher | 2007-07-11 20:27:11 -0700 (Wed, 11 Jul 2007) | 4 lines +r28938 | guy | 2009-07-03 10:12:36 -0700 (Fri, 03 Jul 2009) | 3 lines Changed paths: - M /trunk/docbook/release-notes.xml - - -Fix doc build by removing empty itemized lists + M /trunk/epan/dissectors/packet-ndmp.c +Set save_fragmented regardless of whether we're reassembling or not, as +we restore it regardless of whether we're reassembling or not. ------------------------------------------------------------------------ -r22289 | morriss | 2007-07-12 08:34:21 -0700 (Thu, 12 Jul 2007) | 1 line +r28939 | etxrab | 2009-07-04 08:15:51 -0700 (Sat, 04 Jul 2009) | 3 lines Changed paths: - M /trunk/epan/dissectors/packet-ssl.c + M /trunk/epan/dissectors/packet-isup.c -Undo part of rev 21460: go back to passing proto_ssl to the tap (since apparently follow ssl stream uses it) but now cast it using GINT_TO_POINTER so as to avoid a warning (seen on 64-bit Redhat AS4) about casting to a pointer from an integer of different size. It does not appear that there is a DTLS tap (which is the other thing changed in 21460). +A fix for: +"ANSI ISUP Cause indicators with coding standard=ANSI fail to dissect." +https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=3654 ------------------------------------------------------------------------ -r22290 | martinm | 2007-07-12 10:31:26 -0700 (Thu, 12 Jul 2007) | 2 lines +r28940 | etxrab | 2009-07-05 04:49:36 -0700 (Sun, 05 Jul 2009) | 3 lines Changed paths: - M /trunk/epan/dissectors/packet-catapult-dct2000.c - -Fix parsing of sctpprim header (v1) + M /trunk/asn1/ldap/packet-ldap-template.c + M /trunk/epan/dissectors/packet-homeplug.c + M /trunk/epan/dissectors/packet-ldap.c + M /trunk/epan/dissectors/packet-ldap.h + M /trunk/epan/dissectors/packet-slowprotocols.c +From Kovarththanan Rajaratnam: +Cleanup header_field_info definitions +https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=3548 ------------------------------------------------------------------------ -r22291 | martinm | 2007-07-12 10:33:50 -0700 (Thu, 12 Jul 2007) | 2 lines +r28941 | gerald | 2009-07-05 08:03:31 -0700 (Sun, 05 Jul 2009) | 1 line Changed paths: - M /trunk/diameter/gqpolicy.xml - -Add some AVPs used with Rq interface (same appid as Gq) + M /trunk/epan/enterprise-numbers + M /trunk/manuf ------------------------------------------------------------------------- -r22292 | jake | 2007-07-12 12:55:12 -0700 (Thu, 12 Jul 2007) | 6 lines +[Automatic manuf and enterprise-numbers update for 2009-07-05] +------------------------------------------------------------------------ +r28944 | etxrab | 2009-07-05 09:22:20 -0700 (Sun, 05 Jul 2009) | 1 line +Changed paths: + M /trunk/gtk/new_packet_list.c + +gtk_tree_view_set_fixed_height_mode() is GTK 2.6 +------------------------------------------------------------------------ +r28945 | ulfl | 2009-07-06 02:46:28 -0700 (Mon, 06 Jul 2009) | 1 line +Changed paths: + M /trunk/plugins/Custom.nmake.example + +fix install step +------------------------------------------------------------------------ +r28946 | wmeier | 2009-07-06 05:39:58 -0700 (Mon, 06 Jul 2009) | 2 lines +Changed paths: + A /trunk/radius/dictionary.airespace + A /trunk/radius/dictionary.alvarion + A /trunk/radius/dictionary.apc + A /trunk/radius/dictionary.asn + A /trunk/radius/dictionary.avaya + A /trunk/radius/dictionary.azaire + A /trunk/radius/dictionary.chillispot + A /trunk/radius/dictionary.clavister + A /trunk/radius/dictionary.dhcp + A /trunk/radius/dictionary.digium + A /trunk/radius/dictionary.epygi + A /trunk/radius/dictionary.fortinet + A /trunk/radius/dictionary.freeswitch + A /trunk/radius/dictionary.h3c + A /trunk/radius/dictionary.hp + A /trunk/radius/dictionary.huawei + A /trunk/radius/dictionary.infonet + A /trunk/radius/dictionary.ipunplugged + A /trunk/radius/dictionary.issanni + A /trunk/radius/dictionary.jradius + A /trunk/radius/dictionary.lancom + A /trunk/radius/dictionary.lucent + A /trunk/radius/dictionary.manzara + A /trunk/radius/dictionary.motorola + A /trunk/radius/dictionary.networkphysics + A /trunk/radius/dictionary.nexans + A /trunk/radius/dictionary.nokia.conflict + A /trunk/radius/dictionary.nortel + A /trunk/radius/dictionary.ntua + A /trunk/radius/dictionary.openser + A /trunk/radius/dictionary.packeteer + A /trunk/radius/dictionary.patton + A /trunk/radius/dictionary.prosoft + A /trunk/radius/dictionary.quiconnect + A /trunk/radius/dictionary.rfc2865 + A /trunk/radius/dictionary.rfc2866 + A /trunk/radius/dictionary.rfc2867 + A /trunk/radius/dictionary.rfc2868 + A /trunk/radius/dictionary.rfc2869 + A /trunk/radius/dictionary.rfc3162 + A /trunk/radius/dictionary.rfc3576 + A /trunk/radius/dictionary.rfc3580 + A /trunk/radius/dictionary.rfc4072 + A /trunk/radius/dictionary.rfc4372 + A /trunk/radius/dictionary.rfc4675 + A /trunk/radius/dictionary.rfc4679 + A /trunk/radius/dictionary.rfc4818 + A /trunk/radius/dictionary.rfc4849 + A /trunk/radius/dictionary.rfc5090 + A /trunk/radius/dictionary.rfc5176 + A /trunk/radius/dictionary.riverstone + A /trunk/radius/dictionary.roaringpenguin + A /trunk/radius/dictionary.slipstream + A /trunk/radius/dictionary.sofaware + A /trunk/radius/dictionary.telkom + A /trunk/radius/dictionary.tropos + A /trunk/radius/dictionary.utstarcom + A /trunk/radius/dictionary.vqp + A /trunk/radius/dictionary.walabi + A /trunk/radius/dictionary.waverider + A /trunk/radius/dictionary.xylan + A /trunk/radius/dictionary.zyxel + +Update dictionary files from FreeRadius 2.1.6 [5/18/09]: part 1: New files + +------------------------------------------------------------------------ +r28947 | etxrab | 2009-07-06 05:50:12 -0700 (Mon, 06 Jul 2009) | 3 lines Changed paths: - M /trunk/wiretap/wtap.c + M /trunk/epan/dissectors/packet-isup.c -From Jim Paris: -The encap_table_base in wcap.c is missing an entry. -This causes e.g. "dumpcap -i usb3 -L" to output: - Data link types (use option -y to set): - USB_LINUX - (MPEG) ------------------------------------------------------------------------- -r22293 | morriss | 2007-07-12 15:36:35 -0700 (Thu, 12 Jul 2007) | 1 line -Changed paths: - M /trunk/doc/README.developer - M /trunk/epan/dissectors/packet-ieee80211.c +Decode error for network-id in BICC BCU-ID -From Guillem Hernandez: fix decoding of EOSP bit. From Jaap Keuter: fix description of 'value' in proto_tree_add_boolean() that caused the former bug. +https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=3648 ------------------------------------------------------------------------ -r22294 | jake | 2007-07-12 23:28:44 -0700 (Thu, 12 Jul 2007) | 1 line +r28948 | jmayer | 2009-07-06 06:00:04 -0700 (Mon, 06 Jul 2009) | 3 lines Changed paths: - M /trunk/doc/README.developer + M /trunk/epan/dissectors/packet-glbp.c -Added remark on anonymous unions. ------------------------------------------------------------------------- -r22295 | kukosa | 2007-07-13 04:25:53 -0700 (Fri, 13 Jul 2007) | 2 lines -Changed paths: - M /trunk/asn1/q932/packet-q932-ros-template.c - M /trunk/asn1/q932/packet-q932-ros-template.h - M /trunk/asn1/q932/packet-q932-template.c - M /trunk/epan/asn1.h - M /trunk/epan/dissectors/packet-ber.c - M /trunk/epan/dissectors/packet-per.c - M /trunk/epan/dissectors/packet-q932-ros.c - M /trunk/epan/dissectors/packet-q932-ros.h - M /trunk/epan/dissectors/packet-q932.c +Fix for bug 3660: Length (guint32) could become 0 or very large +(overflow). -- get rid of anonymous unions -- move some structures from packet-per and packet-q932-ros to asn1.h ------------------------------------------------------------------------ -r22296 | kukosa | 2007-07-13 06:17:16 -0700 (Fri, 13 Jul 2007) | 1 line +r28949 | etxrab | 2009-07-06 06:34:30 -0700 (Mon, 06 Jul 2009) | 1 line Changed paths: - M /trunk/tap-camelcounter.c + M /trunk/config.nmake -add necessary include +Revert checkin made by misstake(don't use new packet list). ------------------------------------------------------------------------ -r22297 | kukosa | 2007-07-13 06:20:34 -0700 (Fri, 13 Jul 2007) | 1 line +r28950 | stig | 2009-07-06 06:53:01 -0700 (Mon, 06 Jul 2009) | 2 lines Changed paths: - M /trunk/tap-camelcounter.c - M /trunk/tap-camelsrt.c + M /trunk/file.c -next try to fix includes ------------------------------------------------------------------------- -r22298 | morriss | 2007-07-13 06:45:11 -0700 (Fri, 13 Jul 2007) | 1 line -Changed paths: - M /trunk/asn1/tcap/tcap.cnf - M /trunk/epan/dissectors/packet-tcap.c +Removed an incorrect optimalization for invalidating packet in row 0. -From Florent Drouin: fix for bug http://bugs.wireshark.org/bugzilla/show_bug.cgi?id=1681 : initialize the variable containing the OID so the dialog portion gets decoded properly ------------------------------------------------------------------------ -r22299 | etxrab | 2007-07-13 07:46:21 -0700 (Fri, 13 Jul 2007) | 4 lines +r28951 | stig | 2009-07-06 06:59:09 -0700 (Mon, 06 Jul 2009) | 9 lines Changed paths: - M /trunk/asn1/camel/camel.cnf - M /trunk/epan/dissectors/packet-camel.c + M /trunk/epan/dissectors/packet-cip.c + M /trunk/epan/dissectors/packet-cip.h -From Florent DROUIN: -http://bugs.wireshark.org/bugzilla/show_bug.cgi?id=1652 -patch to correct the decoding of Calling Party Number, and -Called Party Number, when an implicit tag is used. ------------------------------------------------------------------------- -r22300 | martinm | 2007-07-13 08:51:34 -0700 (Fri, 13 Jul 2007) | 2 lines -Changed paths: - M /trunk/wiretap/catapult_dct2000.c +From Joakim Wiberg via bug 3670: +This patch correctes serveral minor things. -Worked out properly the silly way aal header is encoded! +1. Adds decoding of generic services to classes that have a separate dissect + function. +2. Adds new error codes. +3. Adds new CIP objects. +4. Extends the VendorID list. ------------------------------------------------------------------------ -r22301 | etxrab | 2007-07-13 13:00:38 -0700 (Fri, 13 Jul 2007) | 2 lines +r28952 | wmeier | 2009-07-06 07:05:37 -0700 (Mon, 06 Jul 2009) | 5 lines Changed paths: M /trunk/epan/dissectors/packet-radius.c + M /trunk/epan/dissectors/packet-radius.h + M /trunk/epan/radius_dict.l + +Radius: Additional attribute handling: + - implement "ether" attribute; + - parse "abinary" attribute [uses existing radius_abinary()] +Also: add a comment in packet-radius.h about the meaning of the encrypt flag. -Fix bug -http://bugs.wireshark.org/bugzilla/show_bug.cgi?id=1640 change "Change-Filter-Request (43)" to "CoA-Request (43)" ------------------------------------------------------------------------ -r22302 | guy | 2007-07-13 15:09:58 -0700 (Fri, 13 Jul 2007) | 3 lines +r28953 | etxrab | 2009-07-06 07:09:52 -0700 (Mon, 06 Jul 2009) | 1 line Changed paths: - M /trunk/Makefile.am - -Add some missing files from the doc directory, and sort them in the -order that "ls" produces them. + M /trunk/epan/dissectors/packet-iec104.c +Small editorial changes. ------------------------------------------------------------------------ -r22303 | guy | 2007-07-13 16:18:04 -0700 (Fri, 13 Jul 2007) | 5 lines +r28954 | stig | 2009-07-06 07:14:13 -0700 (Mon, 06 Jul 2009) | 2 lines Changed paths: - M /trunk/wiretap/catapult_dct2000.c - -"isdigit()" doesn't need to be cast to "int". + M /trunk/epan/dissectors/packet-cip.h -Its argument, however, needs to be cast to "guchar", so that if the -high-order bit is set, it doesn't get sign-extended. +Rewrite non-ASCII characters. ------------------------------------------------------------------------ -r22304 | guy | 2007-07-13 16:20:02 -0700 (Fri, 13 Jul 2007) | 4 lines +r28955 | etxrab | 2009-07-06 08:37:29 -0700 (Mon, 06 Jul 2009) | 2 lines Changed paths: - M /trunk/wiretap/catapult_dct2000.c - -Fix more ctype.h calls - casting to "int" suppresses the warning, but -doesn't fix the problem, as the sign extension is still done; you have -to cast to "guchar". + M /trunk/epan/dfilter/dfilter.c +Initialize memory to zero. + (is NULL = zero on all platforms?) ------------------------------------------------------------------------ -r22305 | guy | 2007-07-13 17:29:03 -0700 (Fri, 13 Jul 2007) | 2 lines +r28956 | gerald | 2009-07-06 10:13:41 -0700 (Mon, 06 Jul 2009) | 2 lines Changed paths: - M /trunk/wiretap/catapult_dct2000.c + M /trunk/tap-rtp-common.c -Fix another cast of the argument to a ctype.h macro. +Fix a couple of typos. ------------------------------------------------------------------------ -r22306 | guy | 2007-07-13 17:37:01 -0700 (Fri, 13 Jul 2007) | 3 lines +r28957 | etxrab | 2009-07-06 10:37:03 -0700 (Mon, 06 Jul 2009) | 2 lines Changed paths: - M /trunk/epan/dfilter/dfilter-macro.c - M /trunk/epan/strutil.c - M /trunk/epan/uat.c - M /trunk/fileset.c - -Fix yet more casts of ctype.h macro arguments - and fix some cases where -we were passing an uncasted "char" to those macros. + M /trunk/epan/dissectors/packet-netflow.c +CFLOW decoding is wrong for IPv6 fields. +https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=3328 ------------------------------------------------------------------------ -r22307 | gal | 2007-07-14 01:16:43 -0700 (Sat, 14 Jul 2007) | 4 lines +r28958 | jmayer | 2009-07-06 10:44:02 -0700 (Mon, 06 Jul 2009) | 3 lines Changed paths: - M /trunk/asn1/x420/x420.asn - M /trunk/epan/dissectors/packet-x420.c - -From Stig Bjorlykke. -ExtendedBodyPart parameters are OPTIONAL. + M /trunk/epan/dissectors/packet-mip.c +OK, nobody cared about the waring, so just remove the +test for now. ------------------------------------------------------------------------ -r22308 | gal | 2007-07-14 01:21:58 -0700 (Sat, 14 Jul 2007) | 3 lines +r28959 | jmayer | 2009-07-06 10:45:40 -0700 (Mon, 06 Jul 2009) | 3 lines Changed paths: - M /trunk/asn1/acse/acse.cnf - M /trunk/epan/dissectors/packet-acse.c - -Dissection of octet-aligned EXTERNALs. + M /trunk/epan/dissectors/packet-ismp.c +Move edp to the top level tree instead of inside the ismp +tree. ------------------------------------------------------------------------ -r22309 | gal | 2007-07-14 02:12:38 -0700 (Sat, 14 Jul 2007) | 3 lines +r28960 | jmayer | 2009-07-06 10:49:33 -0700 (Mon, 06 Jul 2009) | 4 lines Changed paths: - M /trunk/epan/base64.c - -Allow the base64 decoding to cope with lines broken with \r\n. + M /trunk/epan/dissectors/packet-glbp.c +Shorten a few variables for values read from the packet. +Inspired by Kovarththanan Rajaratnam's patch for bug 3665 +which in turn was a duplicate for the (fixed) bug 3660. ------------------------------------------------------------------------ -r22310 | gal | 2007-07-14 02:15:02 -0700 (Sat, 14 Jul 2007) | 3 lines +r28961 | etxrab | 2009-07-06 11:35:05 -0700 (Mon, 06 Jul 2009) | 2 lines Changed paths: - M /trunk/epan/dissectors/packet-imf.c - A /trunk/epan/dissectors/packet-imf.h - -Expose a function (imf_find_field_end()) and -make the field format dissection case-insensitive. + M /trunk/asn1/snmp/packet-snmp-template.c + M /trunk/doc/README.developer + M /trunk/tools/pidl/lib/Parse/Pidl/Wireshark/NDR.pm +From Kovarththanan Rajaratnam: +More "Cleanup header_field_info definitions" ------------------------------------------------------------------------ -r22311 | gal | 2007-07-14 02:19:35 -0700 (Sat, 14 Jul 2007) | 5 lines +r28962 | etxrab | 2009-07-06 11:36:00 -0700 (Mon, 06 Jul 2009) | 2 lines Changed paths: - M /trunk/epan/dissectors/packet-multipart.c - -Optional removal of any base64 content-transfer-encoding from a MIME -body before passing it to a sub-dissector. The decoded content is added -as a new source, named with the filename or the content-type. - + M /trunk/epan/dissectors/packet-snmp.c + M /trunk/epan/dissectors/packet-snmp.h +From Kovarththanan Rajaratnam: +More "Cleanup header_field_info definitions" ------------------------------------------------------------------------ -r22312 | gal | 2007-07-14 02:53:30 -0700 (Sat, 14 Jul 2007) | 17 lines +r28963 | gerald | 2009-07-06 13:23:32 -0700 (Mon, 06 Jul 2009) | 17 lines Changed paths: M /trunk/epan/dissectors/Makefile.common - A /trunk/epan/dissectors/packet-tnef.c + M /trunk/epan/dissectors/packet-miop.c + D /trunk/epan/dissectors/packet-miop.h -New dissector for Transport-Neutral Encapsulation Format - TNEF. +From Kovarththanan Rajaratnam via bug 3652: -TNEF is a Microsoft defined format for carrying additional information about a message (e.g. rich text formatting) -and generally appears as a "winmail.dat" attachment. Details are here: +This patch protects against malformed Unique ID lengths (>= 252 bytes) and +defer all tvb_xxx related calls to when we actually need them. This allows us +to dissects as much as possible before bailing out (in case of a malformed +length). -http://msdn2.microsoft.com/en-us/library/ms530652.aspx - -This is a basic dissector which handles the TNEF attributes and the MAPI properties (found in MAPIPROPS -TNEF attribute). It is not complete and requires further work to complete the dissection. However it will -dissect TNEF generated from Outlook (including messages with attachments). - -It is registered under the appropriate BER OID (1.2.840.113556.3.10.1) for X.400 attachments and media -type ("application/ms-tnef") for MIME messages. For MIME messages, any content-transfer-encoding -(usually base64) needs to be removed before calling this dissector. There is a preference in the -MIME multipart dissector to do this. +From me: +Add a link to the protocol specification. Remove packet-miop.h along +with some struct definitions. (Don't tvb_memcpy over structs!) Remove +some more tvbuffs. Don't call proto_item_add_subtree if we're not going +to use the trees. Call proto_tree_add_item instead of +proto_tree_add_text Remove a bunch of unused ett_ variables. Add an +expert item for the protocol version. Register the field array with the +correct length. ------------------------------------------------------------------------ -r22313 | gal | 2007-07-14 02:58:08 -0700 (Sat, 14 Jul 2007) | 3 lines +r28964 | etxrab | 2009-07-06 21:41:53 -0700 (Mon, 06 Jul 2009) | 2 lines Changed paths: - M /trunk/epan/dissectors/packet-multipart.c - -Fix for warnings on OSX. - + M /trunk/epan/dissectors/ncp2222.py + M /trunk/epan/dissectors/packet-iwarp-ddp-rdmap.c +From Kovarththanan Rajaratnam: +More "Cleanup header_field_info definitions" ------------------------------------------------------------------------ -r22314 | gal | 2007-07-14 03:15:52 -0700 (Sat, 14 Jul 2007) | 3 lines +r28965 | etxrab | 2009-07-06 22:10:20 -0700 (Mon, 06 Jul 2009) | 2 lines Changed paths: - M /trunk/epan/dissectors/packet-multipart.c - -Further problem highlighted by OSX. - + M /trunk/make-manuf +Add holding|spa to the strings removed from manuf names. +manuf will be automatically rebuilt on Sunday. ------------------------------------------------------------------------ -r22315 | gal | 2007-07-14 05:52:51 -0700 (Sat, 14 Jul 2007) | 3 lines +r28966 | etxrab | 2009-07-06 22:43:43 -0700 (Mon, 06 Jul 2009) | 1 line Changed paths: M /trunk/epan/dissectors/Makefile.common + D /trunk/epan/dissectors/packet-etheric.c + D /trunk/epan/dissectors/packet-isup_thin.c -Add packet-imf.h - - +Delete obsolete protocol dissectors. ------------------------------------------------------------------------ -r22316 | gal | 2007-07-15 03:26:55 -0700 (Sun, 15 Jul 2007) | 4 lines +r28967 | stig | 2009-07-07 00:45:32 -0700 (Tue, 07 Jul 2009) | 4 lines Changed paths: - M /trunk/packaging/u3/win32/makefile.nmake - -Include latest configuration files and remove ones no longer shipped. -(Without these configuration files defragmentation was failing - unsure why!) - - ------------------------------------------------------------------------- -r22317 | gal | 2007-07-15 03:59:07 -0700 (Sun, 15 Jul 2007) | 3 lines -Changed paths: - M /trunk/packaging/u3/win32/makefile.nmake - -Further synchronisation with wireshark.nsi + D /trunk/plugins/unistim/header_field.h + M /trunk/plugins/unistim/packet-unistim.c +From Kovarththanan Rajaratnam via bug 3548: +Move header_field.h into packet-unistim.c to align it with all other +dissectors. ------------------------------------------------------------------------ -r22318 | lego | 2007-07-15 22:41:58 -0700 (Sun, 15 Jul 2007) | 15 lines +r28968 | stig | 2009-07-07 00:46:57 -0700 (Tue, 07 Jul 2009) | 3 lines Changed paths: - A /trunk/epan/diam_dict.h - A /trunk/epan/diam_dict.l - M /trunk/epan/dissectors/packet-diameter.c - -Rewrite of the diameter dissector to use the dictionary for creating hfids, drop libxml dependency. - -The work is still incomplete (anything but strings and numbers appears as bytes) but I want others to start testing it. - -TODO: -builders and decoders for: -- (ntp) timestamps -- addresses -- diameteruris -- diameteridentities -- ipfilterrules -- qosfilterrules -- mipregistrationrequests + M /trunk/epan/dissectors/packet-radius.c + M /trunk/plugins/wimaxasncp/packet-wimaxasncp.c +From Kovarththanan Rajaratnam via bug 3548: +Minor hf cleanup. ------------------------------------------------------------------------ -r22319 | lego | 2007-07-15 22:43:46 -0700 (Sun, 15 Jul 2007) | 3 lines +r28969 | stig | 2009-07-07 01:27:15 -0700 (Tue, 07 Jul 2009) | 7 lines Changed paths: - M /trunk/epan/Makefile.am - M /trunk/epan/Makefile.common - -update Makefiles to build diam_dict.[co] + M /trunk/epan/dissectors/packet-cops.c +From Juli?\195?\131?\194?\161n Lastiri via bug 3656: +ClassifierID should be before Priority field in the Extended Classifier of +PacketCable Multimedia Protocol. Also the reference to PacketCable Multimedia +document PKT-SP-MM-I02-040930 is wrong because there is no definition about +Extended Classifier. My fix is based on PacketCable Multimedia +PKT-SP-MM-I04-080522 document. ------------------------------------------------------------------------ -r22320 | lego | 2007-07-15 23:06:21 -0700 (Sun, 15 Jul 2007) | 3 lines +r28970 | stig | 2009-07-07 02:00:33 -0700 (Tue, 07 Jul 2009) | 3 lines Changed paths: - M /trunk/epan/Makefile.nmake - -Windows too needs diam_dict.c + M /trunk/plugins/docsis/packet-bpkmattr.c + M /trunk/plugins/docsis/packet-dccreq.c + M /trunk/plugins/docsis/packet-dcd.c + M /trunk/plugins/docsis/packet-macmgmt.c + M /trunk/plugins/docsis/packet-tlv.c + M /trunk/plugins/profinet/packet-dcerpc-pn-io.c + M /trunk/plugins/profinet/packet-pn-mrp.c + M /trunk/plugins/profinet/packet-pn-mrrt.c + M /trunk/plugins/profinet/packet-pn-ptcp.c + M /trunk/plugins/unistim/packet-unistim.c + M /trunk/plugins/wimax/msg_dcd.c + M /trunk/plugins/wimax/msg_dreg.c + M /trunk/plugins/wimax/msg_fpc.c + M /trunk/plugins/wimax/msg_pmc.c + M /trunk/plugins/wimax/msg_reg_req.c + M /trunk/plugins/wimax/msg_rng_req.c + M /trunk/plugins/wimax/msg_rng_rsp.c + M /trunk/plugins/wimax/wimax_utils.c +From Kovarththanan Rajaratnam: +More FT_XXX cleanup. ------------------------------------------------------------------------ -r22321 | lego | 2007-07-15 23:28:56 -0700 (Sun, 15 Jul 2007) | 4 lines +r28971 | stig | 2009-07-07 02:02:59 -0700 (Tue, 07 Jul 2009) | 3 lines Changed paths: + M /trunk/asn1/ldap/packet-ldap-template.c + M /trunk/asn1/ros/packet-ros-template.c + M /trunk/epan/dissectors/packet-alcap.c + M /trunk/epan/dissectors/packet-ans.c + M /trunk/epan/dissectors/packet-aoe.c + M /trunk/epan/dissectors/packet-artnet.c + M /trunk/epan/dissectors/packet-asap.c + M /trunk/epan/dissectors/packet-bacnet.c + M /trunk/epan/dissectors/packet-banana.c + M /trunk/epan/dissectors/packet-bpdu.c + M /trunk/epan/dissectors/packet-bthci_evt.c + M /trunk/epan/dissectors/packet-catapult-dct2000.c + M /trunk/epan/dissectors/packet-cigi.c + M /trunk/epan/dissectors/packet-cpha.c M /trunk/epan/dissectors/packet-diameter.c + M /trunk/epan/dissectors/packet-dnp.c + M /trunk/epan/dissectors/packet-dns.c + M /trunk/epan/dissectors/packet-dtls.c + M /trunk/epan/dissectors/packet-enip.c + M /trunk/epan/dissectors/packet-enrp.c + M /trunk/epan/dissectors/packet-enttec.c + M /trunk/epan/dissectors/packet-fip.c + M /trunk/epan/dissectors/packet-fractalgeneratorprotocol.c + M /trunk/epan/dissectors/packet-gdsdb.c + M /trunk/epan/dissectors/packet-giop.c + M /trunk/epan/dissectors/packet-gmrp.c + M /trunk/epan/dissectors/packet-gssapi.c + M /trunk/epan/dissectors/packet-gtp.c + M /trunk/epan/dissectors/packet-homeplug.c + M /trunk/epan/dissectors/packet-ieee80211.c + M /trunk/epan/dissectors/packet-ipmi-app.c + M /trunk/epan/dissectors/packet-ipmi-se.c + M /trunk/epan/dissectors/packet-ipmi.c + M /trunk/epan/dissectors/packet-iuup.c + M /trunk/epan/dissectors/packet-ldap.c + M /trunk/epan/dissectors/packet-ldss.c + M /trunk/epan/dissectors/packet-linx.c + M /trunk/epan/dissectors/packet-nbd.c + M /trunk/epan/dissectors/packet-netflow.c + M /trunk/epan/dissectors/packet-nhrp.c + M /trunk/epan/dissectors/packet-ntp.c + M /trunk/epan/dissectors/packet-pana.c + M /trunk/epan/dissectors/packet-prp.c + M /trunk/epan/dissectors/packet-ptp.c + M /trunk/epan/dissectors/packet-rmp.c + M /trunk/epan/dissectors/packet-rmt-norm.c + M /trunk/epan/dissectors/packet-ros.c + M /trunk/epan/dissectors/packet-rpc.c + M /trunk/epan/dissectors/packet-rtcp.c + M /trunk/epan/dissectors/packet-rtmpt.c + M /trunk/epan/dissectors/packet-smb.c + M /trunk/epan/dissectors/packet-stun.c + M /trunk/epan/dissectors/packet-stun2.c + M /trunk/epan/dissectors/packet-trmac.c + M /trunk/epan/dissectors/packet-tzsp.c + M /trunk/epan/dissectors/packet-uma.c + M /trunk/epan/dissectors/packet-umts_fp.c + M /trunk/epan/dissectors/packet-wol.c + M /trunk/epan/dissectors/packet-wps.c -for MSVC (vendor_flag ? 12 : 8) is signed ... -well for gcc is either signed or unsigned (they are two literals!) - - ------------------------------------------------------------------------- -r22322 | kukosa | 2007-07-16 05:51:42 -0700 (Mon, 16 Jul 2007) | 1 line -Changed paths: - M /trunk/epan/dissectors/packet-http.c - M /trunk/epan/dissectors/packet-ssl.c +From Kovarththanan Rajaratnam: +More FT_XXX cleanup. -make TCP and SSL/TLS ports configurable for HTTP ------------------------------------------------------------------------ -r22323 | lego | 2007-07-16 10:27:51 -0700 (Mon, 16 Jul 2007) | 3 lines +r28972 | etxrab | 2009-07-07 02:27:52 -0700 (Tue, 07 Jul 2009) | 2 lines Changed paths: - M /trunk/epan/diam_dict.l - -Glibize diam_dict.l (should fix windows config) - + M /trunk/epan/dissectors/packet-x420.c +Cleanup header_field_info definitions +- Regenerating x420 seems to have fixed the "last" problem :-) ------------------------------------------------------------------------ -r22324 | lego | 2007-07-16 10:39:40 -0700 (Mon, 16 Jul 2007) | 3 lines +r28973 | etxrab | 2009-07-07 02:42:09 -0700 (Tue, 07 Jul 2009) | 1 line Changed paths: - M /trunk/epan/Makefile.am - -Fix distcheck - + M /trunk/epan/to_str.c + M /trunk/epan/to_str.h +Introduce se_address_to_str() ------------------------------------------------------------------------ -r22325 | gerald | 2007-07-16 11:04:53 -0700 (Mon, 16 Jul 2007) | 2 lines +r28974 | stig | 2009-07-07 03:07:42 -0700 (Tue, 07 Jul 2009) | 2 lines Changed paths: - M /trunk/doc/README.packaging + M /trunk/asn1/cdt/cdt.cnf + M /trunk/asn1/cdt/packet-cdt-template.c + M /trunk/epan/dissectors/packet-bjnp.c + M /trunk/epan/dissectors/packet-cdt.c + M /trunk/epan/dissectors/packet-dmp.c + M /trunk/epan/dissectors/packet-nat-pmp.c + M /trunk/epan/dissectors/packet-p_mul.c -Add a note about svnversion.h. +Remove some check_col() calls. ------------------------------------------------------------------------ -r22328 | morriss | 2007-07-16 14:37:07 -0700 (Mon, 16 Jul 2007) | 1 line +r28975 | stig | 2009-07-07 03:12:15 -0700 (Tue, 07 Jul 2009) | 3 lines Changed paths: - M /trunk/epan/dissectors/packet-per.c + M /trunk/epan/dissectors/ncp2222.py + M /trunk/epan/gcp.h -Fix bug http://bugs.wireshark.org/bugzilla/show_bug.cgi?id=1675 (warning: cast from pointer to integer of different size) and, presumably, display of PER encoded IPv4 addresses by copying the IP address into a guint32 and passing that to proto_tree_add_ipv4(). ------------------------------------------------------------------------- -r22329 | morriss | 2007-07-16 15:19:59 -0700 (Mon, 16 Jul 2007) | 1 line -Changed paths: - M /trunk/gtk/column_prefs.c - M /trunk/gtk/dfilter_expr_dlg.c - M /trunk/gtk/expert_comp_table.c +From Kovarththanan Rajaratnam: +More header field info cleanup -Fix a couple "cast to pointer from integer of different size" warnings when building with GTK1.2 on Redhat AS4 64-bit ------------------------------------------------------------------------ -r22330 | sfisher | 2007-07-16 23:21:15 -0700 (Mon, 16 Jul 2007) | 10 lines +r28976 | stig | 2009-07-07 04:13:22 -0700 (Tue, 07 Jul 2009) | 12 lines Changed paths: - M /trunk/epan/dissectors/packet-wlccp.c - - -From Kevin A. Noll via private bug #1683: + M /trunk/plugins/ethercat/Makefile.common + A /trunk/plugins/ethercat/packet-esl.c + A /trunk/plugins/ethercat/packet-esl.h + M /trunk/plugins/ethercat/packet-ethercat-datagram.c -This is a major re-write of the WLCCP version 0xc1 dissector. It now is -able to dissect many more WLCCP message types and the TLVs that may be -included in a message. Placeholders are left for message types and -TLV types that we do not currently have enough data to engineer a -dissector. +From Richard Kummel: +- New dissector for EtherCAT Switch Link Header added to EtherCAT plugin +- Changed filtering of EtherCAT commands to the abbreviated form: + e.g. ecat.cmd = APWR +From me: +- Mark unused variables +- Fixed a string warning +- Do not initialize a static struct +- Use tfs_yes_no +- Reorder files in Makefile ------------------------------------------------------------------------ -r22331 | jake | 2007-07-17 00:01:36 -0700 (Tue, 17 Jul 2007) | 2 lines +r28977 | stig | 2009-07-07 04:33:55 -0700 (Tue, 07 Jul 2009) | 2 lines Changed paths: - M /trunk/epan/dissectors/packet-ipv6.c + M /trunk/AUTHORS -Fix for bug 1616: -ICMPv6 & UDP w/IPv6 checksum with a routing header fixed using the routing header address now. ------------------------------------------------------------------------- -r22332 | kukosa | 2007-07-17 02:59:35 -0700 (Tue, 17 Jul 2007) | 1 line -Changed paths: - M /trunk/tools/asn2wrs.py +Added Richard Kummel. -support for syntax of TYPE-IDENTIFIER and ABSTRACT-SYNTAX classes ------------------------------------------------------------------------ -r22333 | martinm | 2007-07-17 04:54:22 -0700 (Tue, 17 Jul 2007) | 2 lines +r28978 | stig | 2009-07-07 04:37:15 -0700 (Tue, 07 Jul 2009) | 3 lines Changed paths: - M /trunk/epan/dissectors/packet-multipart.c + M /trunk/asn1/s1ap/packet-s1ap-template.c + M /trunk/diameter/TGPPGmb.xml + M /trunk/diameter/chargecontrol.xml + M /trunk/diameter/dictionary.xml + M /trunk/epan/dissectors/ncp2222.py + M /trunk/epan/dissectors/packet-cpfi.c + M /trunk/epan/dissectors/packet-dcerpc-rdaclif.c + M /trunk/epan/dissectors/packet-dcerpc-rs_prop_acct.c + M /trunk/epan/dissectors/packet-dcerpc-rs_prop_acl.c + M /trunk/epan/dissectors/packet-dcerpc-rs_pwd_mgmt.c + M /trunk/epan/dissectors/packet-ipars.c + M /trunk/epan/dissectors/packet-isup.c + M /trunk/epan/dissectors/packet-s1ap.c + M /trunk/epan/dissectors/packet-x224.c + M /trunk/plugins/docsis/packet-dccack.c + M /trunk/plugins/docsis/packet-dccreq.c + M /trunk/plugins/docsis/packet-dccrsp.c + M /trunk/plugins/docsis/packet-dcd.c -Avoid an infinite loop (on malformed packet) +From Kovarththanan Rajaratnam: +Remove trailing spaces in protocol/field names ------------------------------------------------------------------------ -r22334 | martinm | 2007-07-17 06:09:44 -0700 (Tue, 17 Jul 2007) | 2 lines +r28979 | stig | 2009-07-07 04:40:40 -0700 (Tue, 07 Jul 2009) | 4 lines Changed paths: - M /trunk/epan/dissectors/packet-sdp.c + M /trunk/epan/dissectors/packet-infiniband.c + M /trunk/epan/dissectors/packet-infiniband.h -Show malformed SDP line as an expert item +From Kovarththanan Rajaratnam: +Move hf/ett definitions from packet-infiniband.h -> packet-infiniband.c to +align it with the rest of the bunch ------------------------------------------------------------------------ -r22335 | morriss | 2007-07-17 11:09:01 -0700 (Tue, 17 Jul 2007) | 1 line +r28980 | stig | 2009-07-07 04:52:53 -0700 (Tue, 07 Jul 2009) | 2 lines Changed paths: - M /trunk/gtk/packet_list.c + M /trunk/AUTHORS -Don't use gtk_clist_row_is_visible() but rather eth_clist_row_is_visible() so that GTK1.2 builds work (without a warning). ------------------------------------------------------------------------- -r22336 | morriss | 2007-07-17 11:56:09 -0700 (Tue, 17 Jul 2007) | 1 line -Changed paths: - M /trunk/epan/dissectors/packet-imf.c +Added credits for Lua BitOp. -Don't use g_ascii_isupper() nor g_ascii_tolower(): they don't exist in GTK1. Replaced with generic isupper() and tolower(). ------------------------------------------------------------------------ -r22337 | guy | 2007-07-17 12:09:50 -0700 (Tue, 17 Jul 2007) | 4 lines +r28981 | stig | 2009-07-07 04:58:23 -0700 (Tue, 07 Jul 2009) | 4 lines Changed paths: - M /trunk/epan/dissectors/packet-imf.c + M /trunk/epan/dissectors/packet-amqp.c -"key" is a guint8 *; make the pointer into the string to which it refers -a guint8 * as well - that keeps us from sign-extending the characters -before passing them to the ctype.h macros. +From Kovarththanan Rajaratnam: +Move hf/ett into proto_register_amqp() and do some field cleanup +(duplicate name/blurb removal) ------------------------------------------------------------------------ -r22338 | gerald | 2007-07-17 14:29:18 -0700 (Tue, 17 Jul 2007) | 3 lines +r28982 | stig | 2009-07-07 05:14:47 -0700 (Tue, 07 Jul 2009) | 3 lines Changed paths: - M /trunk/epan/diam_dict.l - M /trunk/epan/dissectors/packet-diameter.c + M /trunk/epan/dissectors/packet-fix.h + M /trunk/fix/hfField.xsl -If we can't find dictionary.xml, fail instead of trying to read from -stdin (which makes distcheck unhappy). Fixup whitespace. +From Kovarththanan Rajaratnam: +Duplicate name/blurb removal from packet-fix.h (and template) ------------------------------------------------------------------------ -r22339 | sfisher | 2007-07-17 14:50:29 -0700 (Tue, 17 Jul 2007) | 6 lines +r28983 | stig | 2009-07-07 05:21:25 -0700 (Tue, 07 Jul 2009) | 2 lines Changed paths: - M /trunk/epan/dissectors/packet-mysql.c - - -From Jess Balint: - -a patch to fix the state management for the MySQL protocol dissector. + M /trunk/AUTHORS +Added Kovarththanan Rajaratnam. ------------------------------------------------------------------------ -r22340 | lego | 2007-07-17 15:00:40 -0700 (Tue, 17 Jul 2007) | 3 lines +r28984 | stig | 2009-07-07 07:13:45 -0700 (Tue, 07 Jul 2009) | 3 lines Changed paths: - M /trunk/epan/dissectors/packet-k12.c - -Have the encapsulation selection match on the port name as well as stk filename. + M /trunk/epan/dissectors/packet-jxta.c +From Kovarththanan Rajaratnam: +Move hf/ett into proto_register_jxta() and do some field cleanup ------------------------------------------------------------------------ -r22341 | lego | 2007-07-17 15:04:00 -0700 (Tue, 17 Jul 2007) | 4 lines +r28985 | stig | 2009-07-07 07:23:49 -0700 (Tue, 07 Jul 2009) | 2 lines Changed paths: - A /trunk/epan/crc10.c - A /trunk/epan/crc10.h - A /trunk/epan/crc6.c - A /trunk/epan/crc6.h - M /trunk/epan/dissectors/packet-iuup.c - -get crc10 and crc6 out of packet-iuup.c -- experimental code for a way-too-heurstic look for iuup dissector + M /trunk/epan/tfs.h +Fix prototypes for default tfs sets. ------------------------------------------------------------------------ -r22342 | lego | 2007-07-17 15:05:18 -0700 (Tue, 17 Jul 2007) | 2 lines +r28986 | wmeier | 2009-07-07 07:26:38 -0700 (Tue, 07 Jul 2009) | 8 lines Changed paths: - M /trunk/epan/uat_load.l + M /trunk/plugins/ethercat/packet-esl.c + M /trunk/plugins/ethercat/packet-esl.h -increase line numbers on comments too +Various fixes: +1. For some reason: using an using the external tfs_yes_no doesn't work in a plugin; +2. proto_reg_handoff: remove unneeded code; +3. Change the prefs callback to call a function which just enables/disables + the protocol; (using proto_reg_handoff means that the dissector + was re-registered each time the pref was changed); +4. packet-esl.h: use #if 0 instead of /* ... */ to comment out code; ------------------------------------------------------------------------ -r22343 | lego | 2007-07-17 15:09:10 -0700 (Tue, 17 Jul 2007) | 3 lines +r28987 | stig | 2009-07-07 07:34:33 -0700 (Tue, 07 Jul 2009) | 2 lines Changed paths: - M /trunk/epan/dissectors/packet-dec-dnart.c - -fix a leak + M /trunk/epan/dissectors/packet-mikey.c +No need to include tfs.h ------------------------------------------------------------------------ -r22344 | lego | 2007-07-17 15:11:07 -0700 (Tue, 17 Jul 2007) | 3 lines +r28988 | martinm | 2009-07-07 07:38:14 -0700 (Tue, 07 Jul 2009) | 2 lines Changed paths: - M /trunk/epan/Makefile.common - -(Following my "tradition") I forgot to ci the changes to the Makefiles for crc6 and crc10 + M /trunk/epan/dissectors/packet-catapult-dct2000.c +Add preference for turning off LTE RRC. ------------------------------------------------------------------------ -r22345 | lego | 2007-07-17 15:19:54 -0700 (Tue, 17 Jul 2007) | 3 lines +r28989 | stig | 2009-07-07 07:54:15 -0700 (Tue, 07 Jul 2009) | 2 lines Changed paths: - M /trunk/epan/diam_dict.h - M /trunk/epan/diam_dict.l + M /trunk/asn1/snmp/packet-snmp-template.c + M /trunk/asn1/spnego/packet-spnego-template.c + M /trunk/epan/dissectors/packet-9p.c + M /trunk/epan/dissectors/packet-aim-generic.c + M /trunk/epan/dissectors/packet-aim-messaging.c + M /trunk/epan/dissectors/packet-aim.c + M /trunk/epan/dissectors/packet-aodv.c + M /trunk/epan/dissectors/packet-bat.c + M /trunk/epan/dissectors/packet-bfd.c + M /trunk/epan/dissectors/packet-dcerpc-spoolss.c + M /trunk/epan/dissectors/packet-dcerpc-svcctl.c + M /trunk/epan/dissectors/packet-dcerpc.c + M /trunk/epan/dissectors/packet-dcom-dispatch.c + M /trunk/epan/dissectors/packet-dcom.c M /trunk/epan/dissectors/packet-diameter.c + M /trunk/epan/dissectors/packet-drda.c + M /trunk/epan/dissectors/packet-dtpt.c + M /trunk/epan/dissectors/packet-eapol.c + M /trunk/epan/dissectors/packet-extreme.c + M /trunk/epan/dissectors/packet-fr.c + M /trunk/epan/dissectors/packet-ip.c + M /trunk/epan/dissectors/packet-jxta.c + M /trunk/epan/dissectors/packet-lapb.c + M /trunk/epan/dissectors/packet-lapd.c + M /trunk/epan/dissectors/packet-llc.c + M /trunk/epan/dissectors/packet-mq.c + M /trunk/epan/dissectors/packet-mysql.c + M /trunk/epan/dissectors/packet-nfs.c + M /trunk/epan/dissectors/packet-nt-tpcp.c + M /trunk/epan/dissectors/packet-ntlmssp.c + M /trunk/epan/dissectors/packet-rtp.c + M /trunk/epan/dissectors/packet-sap.c + M /trunk/epan/dissectors/packet-sdlc.c + M /trunk/epan/dissectors/packet-smb.c + M /trunk/epan/dissectors/packet-snmp.c + M /trunk/epan/dissectors/packet-spnego.c + M /trunk/epan/dissectors/packet-sqloracle.c + M /trunk/epan/dissectors/packet-t30.c + M /trunk/epan/dissectors/packet-tacacs.c + M /trunk/epan/dissectors/packet-tcp.c + M /trunk/epan/dissectors/packet-v120.c + M /trunk/epan/dissectors/packet-windows-common.c -Add Address decoding, two debug environment variables (WIRESHARK_DEBUG_DIAM_DICT_PARSER and WIRESHARK_DUMP_DIAM_DICT) and fix some issues pointed out by Martin - - ------------------------------------------------------------------------- -r22346 | lego | 2007-07-17 17:19:37 -0700 (Tue, 17 Jul 2007) | 3 lines -Changed paths: - M /trunk/epan/Makefile.common - -fxi a ytpo - +Changed flags_set_truth -> tfs_set_notset ------------------------------------------------------------------------ -r22347 | tuexen | 2007-07-18 00:06:46 -0700 (Wed, 18 Jul 2007) | 2 lines +r28990 | stig | 2009-07-07 07:58:25 -0700 (Tue, 07 Jul 2009) | 3 lines Changed paths: - M /trunk/epan/diam_dict.l - M /trunk/gtk/tcp_graph.c + M /trunk/epan/tfs.c + M /trunk/epan/tfs.h -Make debugging static. +Removed unused flags_set_truth. +Fixed some capitalizations. ------------------------------------------------------------------------ -r22348 | lego | 2007-07-18 01:25:09 -0700 (Wed, 18 Jul 2007) | 3 lines +r28991 | stig | 2009-07-07 08:21:36 -0700 (Tue, 07 Jul 2009) | 2 lines Changed paths: - M /trunk/epan/crc6.c - - add license + M /trunk/epan/dissectors/packet-dmp.c +Do not use tfs true_string and false_string directly. ------------------------------------------------------------------------ -r22349 | kukosa | 2007-07-18 06:15:36 -0700 (Wed, 18 Jul 2007) | 1 line +r28992 | stig | 2009-07-07 09:04:26 -0700 (Tue, 07 Jul 2009) | 2 lines Changed paths: - M /trunk/asn1/Makefile.am - M /trunk/asn1/q932/Makefile - M /trunk/asn1/q932/Makefile.nmake - M /trunk/asn1/q932/packet-q932-ros-template.c - D /trunk/asn1/q932/packet-q932-ros-template.h - M /trunk/asn1/q932/packet-q932-template.c - M /trunk/asn1/q932/q932-ros.cnf - M /trunk/epan/asn1.c - M /trunk/epan/asn1.h - M /trunk/epan/dissectors/packet-per.c - M /trunk/epan/dissectors/packet-per.h - M /trunk/epan/dissectors/packet-q932-ros.c - D /trunk/epan/dissectors/packet-q932-ros.h - M /trunk/epan/dissectors/packet-q932.c + M /trunk/epan/proto.c -rose_ctx_t structure usage in Q.932 dissector ------------------------------------------------------------------------- -r22350 | martinm | 2007-07-18 06:18:41 -0700 (Wed, 18 Jul 2007) | 2 lines +Added some casts for true_false_string's. + +------------------------------------------------------------------------ +r28993 | stig | 2009-07-07 09:13:25 -0700 (Tue, 07 Jul 2009) | 2 lines +Changed paths: + M /trunk/epan/tfs.h + +Revert r28985 to fix tfs prototypes, as it doesn't work... + +------------------------------------------------------------------------ +r28994 | wmeier | 2009-07-07 10:03:11 -0700 (Tue, 07 Jul 2009) | 4 lines +Changed paths: + M /trunk/plugins/ethercat/packet-esl.c + +Fix the esl protocol enable/disable handling issue introduced in SVN #28986: + Use the standard "if (!initialized)..." logic in proto_reg_handoff(). +Also: use "true_false_string flags_yes_no" as in the original patch. + +------------------------------------------------------------------------ +r28995 | martinm | 2009-07-07 10:07:24 -0700 (Tue, 07 Jul 2009) | 2 lines +Changed paths: + M /trunk/epan/dissectors/packet-rlc-lte.c + +Add expert item to warn of AM data PDUs that don't have any data. + +------------------------------------------------------------------------ +r28996 | wmeier | 2009-07-07 10:52:03 -0700 (Tue, 07 Jul 2009) | 3 lines +Changed paths: + M /trunk/radius/dictionary.3com + M /trunk/radius/dictionary.acc + M /trunk/radius/dictionary.alteon + M /trunk/radius/dictionary.altiga + M /trunk/radius/dictionary.aptis + M /trunk/radius/dictionary.bay + M /trunk/radius/dictionary.bintec + M /trunk/radius/dictionary.bristol + M /trunk/radius/dictionary.cabletron + M /trunk/radius/dictionary.cisco + M /trunk/radius/dictionary.cisco.bbsm + M /trunk/radius/dictionary.cisco.vpn5000 + M /trunk/radius/dictionary.colubris + M /trunk/radius/dictionary.columbia_university + M /trunk/radius/dictionary.compat + M /trunk/radius/dictionary.cosine + M /trunk/radius/dictionary.ericsson + M /trunk/radius/dictionary.erx + M /trunk/radius/dictionary.extreme + M /trunk/radius/dictionary.foundry + M /trunk/radius/dictionary.gandalf + M /trunk/radius/dictionary.garderos + M /trunk/radius/dictionary.gemtek + M /trunk/radius/dictionary.itk + M /trunk/radius/dictionary.juniper + M /trunk/radius/dictionary.karlnet + M /trunk/radius/dictionary.livingston + M /trunk/radius/dictionary.localweb + M /trunk/radius/dictionary.merit + M /trunk/radius/dictionary.mikrotik + M /trunk/radius/dictionary.navini + M /trunk/radius/dictionary.netscreen + M /trunk/radius/dictionary.nokia + M /trunk/radius/dictionary.nomadix + M /trunk/radius/dictionary.propel + M /trunk/radius/dictionary.quintum + M /trunk/radius/dictionary.redback + M /trunk/radius/dictionary.redcreek + M /trunk/radius/dictionary.shasta + M /trunk/radius/dictionary.shiva + M /trunk/radius/dictionary.sonicwall + M /trunk/radius/dictionary.springtide + M /trunk/radius/dictionary.t_systems_nova + M /trunk/radius/dictionary.telebit + M /trunk/radius/dictionary.trapeze + M /trunk/radius/dictionary.unix + M /trunk/radius/dictionary.valemount + M /trunk/radius/dictionary.versanet + M /trunk/radius/dictionary.wispr + M /trunk/radius/dictionary.xedia + +Update dictionary files from FreeRadius 2.1.6 [5/18/09]: part 2: +Modified files w/o conflicts with current Wireshark radius dictionary files. + +------------------------------------------------------------------------ +r28997 | stig | 2009-07-07 11:22:23 -0700 (Tue, 07 Jul 2009) | 2 lines Changed paths: - M /trunk/epan/dissectors/packet-diameter.c + M /trunk/epan/libwireshark.def -Minor changes to expert items +Removed flags_set_truth ------------------------------------------------------------------------ -r22351 | martinm | 2007-07-18 06:22:11 -0700 (Wed, 18 Jul 2007) | 2 lines +r28998 | wmeier | 2009-07-07 12:40:17 -0700 (Tue, 07 Jul 2009) | 7 lines Changed paths: - M /trunk/epan/diam_dict.l - -Initialise description field to avoid crash when dumping dictionary. + M /trunk/radius/dictionary.cablelabs ------------------------------------------------------------------------- -r22352 | kukosa | 2007-07-18 07:12:56 -0700 (Wed, 18 Jul 2007) | 1 line -Changed paths: - M /trunk/epan/dissectors/Makefile.common +Update dictionary files from FreeRadius 2.1.6 [5/18/09]: part 3a: cablelabs + dictionary.cablelabs from FreeRadius v 2.1.6 updated based upon: + PacketCable(TM) 1.5 Specification: Event Messages [PKT-SP-EM1.5-I03-070412] + PacketCable(TM) Specification: Multimedia Specification [PKT-SP-MM-I04-080522] + Also: Added additional comments and changes related to Wireshark use of this file. + -remove packet-q932-ros.h ------------------------------------------------------------------------ -r22353 | wmeier | 2007-07-18 08:07:45 -0700 (Wed, 18 Jul 2007) | 2 lines +r28999 | stig | 2009-07-07 13:40:28 -0700 (Tue, 07 Jul 2009) | 2 lines Changed paths: - M /trunk/epan/dissectors/packet-diameter.c - M /trunk/epan/dissectors/packet-iuup.c + M /trunk/plugins/unistim/Makefile.common -Fix two Windows compile warnings +Removed header_field.h ------------------------------------------------------------------------ -r22354 | kukosa | 2007-07-19 04:41:10 -0700 (Thu, 19 Jul 2007) | 1 line +r29000 | wmeier | 2009-07-07 13:55:01 -0700 (Tue, 07 Jul 2009) | 7 lines Changed paths: - M /trunk/asn1/q932/q932-ros.cnf - M /trunk/asn1/qsig/packet-qsig-template.c - M /trunk/asn1/qsig/qsig.cnf - M /trunk/epan/dissectors/packet-q932-ros.c - M /trunk/epan/dissectors/packet-qsig.c - M /trunk/tools/asn2wrs.py + M /trunk/radius/dictionary.microsoft -change QSIG tables structure so as they can be generated automatically from ASN.1 in the next step ------------------------------------------------------------------------- -r22355 | kukosa | 2007-07-19 05:31:01 -0700 (Thu, 19 Jul 2007) | 1 line -Changed paths: - M /trunk/asn1/q932/packet-q932-ros-template.c - M /trunk/asn1/q932/q932-ros.cnf - M /trunk/asn1/qsig/packet-qsig-template.c - M /trunk/epan/dissectors/packet-q932-ros.c - M /trunk/epan/dissectors/packet-qsig.c +Update dictionary files from FreeRadius 2.1.6 [5/18/09]: part 3b: microsoft + FreeRadius v 2.1.6 dictionary.microsoft modified based upon + Wireshark commit SVN #17706. + Essentailly: Add "VALUES" for + ATTRIBUTE MS-MPPE-Encryption-Policy and + ATTRIBUTE MS-MPPE-Encryption-Types. -get rid of few warnings ------------------------------------------------------------------------ -r22356 | morriss | 2007-07-19 06:05:39 -0700 (Thu, 19 Jul 2007) | 1 line +r29001 | wmeier | 2009-07-07 15:14:25 -0700 (Tue, 07 Jul 2009) | 7 lines Changed paths: - M /trunk/epan/dissectors/packet-bssgp.c - M /trunk/epan/dissectors/packet-gdsdb.c - M /trunk/epan/dissectors/packet-ipmi.c - M /trunk/epan/dissectors/packet-netsync.c - M /trunk/epan/dissectors/packet-sebek.c - M /trunk/epan/dissectors/packet-snmp.c - M /trunk/epan/dissectors/packet-ssl-utils.c - M /trunk/epan/dissectors/packet-t30.c + M /trunk/radius/dictionary.wimax -Change "lenght" to "length" and "decypt" to "decrypt" ------------------------------------------------------------------------- -r22357 | morriss | 2007-07-19 06:43:36 -0700 (Thu, 19 Jul 2007) | 1 line -Changed paths: - M /trunk/asn1/snmp/packet-snmp-template.c - M /trunk/asn1/snmp/snmp-exp.cnf - M /trunk/epan/dissectors/packet-snmp.c +Update dictionary files from FreeRadius 2.1.6 [5/18/09]: part 3c: wimax + - As is from the FreeRadius release except added missing VENDOR-END + - Note: Attribute WiMAX-MN-hHA-MIP4-SPI [11] had a type of "octets" + in the previous Wireshark repository version of this file. + whereas this attribute in the FreeRadius version of tis file + has an attribute type of "integer". -Change "lenght" to "length", this time in the *source* of the SNMP dissector (sigh) ------------------------------------------------------------------------ -r22358 | morriss | 2007-07-19 07:04:56 -0700 (Thu, 19 Jul 2007) | 1 line +r29002 | wmeier | 2009-07-07 15:20:56 -0700 (Tue, 07 Jul 2009) | 2 lines Changed paths: - M /trunk/asn1/snmp/snmp.cnf - M /trunk/epan/dissectors/packet-snmp.c + M /trunk/radius/dictionary.wimax -For LEGO: Use crypt_tvb when we don't have cleartext_tvb ------------------------------------------------------------------------- -r22359 | morriss | 2007-07-19 08:11:34 -0700 (Thu, 19 Jul 2007) | 1 line -Changed paths: - M /trunk/epan/dissectors/packet-mysql.c +radius: dictionary.wimax; Actually add the missing END-VENDOR statement -Put register_dissector() call back in ------------------------------------------------------------------------ -r22360 | lego | 2007-07-19 17:15:17 -0700 (Thu, 19 Jul 2007) | 5 lines +r29003 | etxrab | 2009-07-07 15:22:05 -0700 (Tue, 07 Jul 2009) | 1 line Changed paths: - M /trunk/diameter/dictionary.xml - M /trunk/epan/diam_dict.h - M /trunk/epan/diam_dict.l - M /trunk/epan/dissectors/packet-diameter.c - -- <?avp-proto and <?type-proto to instruct about which dissector to use for a given type or avp -- dissect timestamps -- add all the avps that were commented out in the dictionary - + M /trunk/epan/dfilter/dfilter.c +NULL is zero on all platforms we run on. ------------------------------------------------------------------------ -r22361 | kukosa | 2007-07-20 02:54:47 -0700 (Fri, 20 Jul 2007) | 1 line +r29004 | wmeier | 2009-07-07 15:53:44 -0700 (Tue, 07 Jul 2009) | 2 lines Changed paths: - M /trunk/asn1/Makefile.am - M /trunk/asn1/q932/packet-q932-template.c - M /trunk/asn1/q932/q932-ros.cnf - M /trunk/asn1/qsig/Makefile - M /trunk/asn1/qsig/Makefile.nmake - A /trunk/asn1/qsig/QSIG-AOC.asn - A /trunk/asn1/qsig/QSIG-CC.asn - A /trunk/asn1/qsig/QSIG-CF.asn - A /trunk/asn1/qsig/QSIG-CI.asn - A /trunk/asn1/qsig/QSIG-CIDL.asn - A /trunk/asn1/qsig/QSIG-CINT.asn - A /trunk/asn1/qsig/QSIG-CMN.asn - A /trunk/asn1/qsig/QSIG-CO.asn - A /trunk/asn1/qsig/QSIG-CPI.asn - A /trunk/asn1/qsig/QSIG-CT.asn - A /trunk/asn1/qsig/QSIG-DND.asn - A /trunk/asn1/qsig/QSIG-MCM.asn - A /trunk/asn1/qsig/QSIG-MCR.asn - A /trunk/asn1/qsig/QSIG-MID.asn - A /trunk/asn1/qsig/QSIG-NA.asn - A /trunk/asn1/qsig/QSIG-PR.asn - A /trunk/asn1/qsig/QSIG-PUMCH.asn - A /trunk/asn1/qsig/QSIG-PUMR.asn - A /trunk/asn1/qsig/QSIG-RE.asn - A /trunk/asn1/qsig/QSIG-SD.asn - A /trunk/asn1/qsig/QSIG-SMS.asn - A /trunk/asn1/qsig/QSIG-SSCT.asn - A /trunk/asn1/qsig/QSIG-WTMAU.asn - A /trunk/asn1/qsig/QSIG-WTMCH.asn - A /trunk/asn1/qsig/QSIG-WTMLR.asn - M /trunk/asn1/qsig/packet-qsig-template.c - M /trunk/asn1/qsig/qsig-exp.cnf - M /trunk/asn1/qsig/qsig-gf-ade.asn - M /trunk/asn1/qsig/qsig-gf-ext.asn - M /trunk/asn1/qsig/qsig-gf-gp.asn - M /trunk/asn1/qsig/qsig.cnf - M /trunk/epan/asn1.h - M /trunk/epan/dissectors/packet-q932-ros.c - M /trunk/epan/dissectors/packet-q932.c - M /trunk/epan/dissectors/packet-qsig.c - M /trunk/epan/dissectors/packet-qsig.h - M /trunk/epan/libwireshark.def - M /trunk/tools/asn2wrs.py + M /trunk/radius/dictionary.nortel + +radius: dictionary.nortel: Update as per the 2009-07-01 FreeRadius reposistory commit -QSIG fully implemented ------------------------------------------------------------------------ -r22362 | richardv | 2007-07-20 03:45:41 -0700 (Fri, 20 Jul 2007) | 3 lines +r29005 | gerald | 2009-07-07 17:28:54 -0700 (Tue, 07 Jul 2009) | 2 lines Changed paths: - D /trunk/asn1/qsig/qsig-cf.asn - D /trunk/asn1/qsig/qsig-na.asn - -kukosa has replaced these with uppercase variants (he should have svn mv'ed them...) + M /trunk/epan/dissectors/packet-glbp.c +Fix several dissector assertions. ------------------------------------------------------------------------ -r22363 | martinm | 2007-07-20 04:39:09 -0700 (Fri, 20 Jul 2007) | 3 lines +r29006 | guy | 2009-07-07 17:57:01 -0700 (Tue, 07 Jul 2009) | 5 lines Changed paths: - M /trunk/epan/dissectors/packet-diameter.c + M /trunk/doc/README.developer -- add an all_cmds array for looking up 'RFC' packets -- improve error/expert info when see unmatched AVPs, commands, appids +Recommend the expert mechanism, rather than DISSECTOR_ASSERT(), for +checks that really check whether the packet is valid; DISSECTOR_ASSERT() +should only be used for cases where the dissector is making an +assumption about its internal state. ------------------------------------------------------------------------ -r22364 | morriss | 2007-07-20 11:57:02 -0700 (Fri, 20 Jul 2007) | 3 lines +r29007 | jake | 2009-07-07 22:20:30 -0700 (Tue, 07 Jul 2009) | 2 lines Changed paths: - M /trunk/AUTHORS - M /trunk/epan/dissectors/packet-kerberos.c + M /trunk/Makefile.am + A /trunk/debian/README.source -From Ted Percival: Support for PA-S4U2Self Kerberos packet type based on ASN.1 -description in Heimdal. +Add missing packaging file (according to Debian Policy Manual). ------------------------------------------------------------------------ -r22365 | morriss | 2007-07-20 12:11:57 -0700 (Fri, 20 Jul 2007) | 1 line +r29008 | jake | 2009-07-07 22:22:47 -0700 (Tue, 07 Jul 2009) | 1 line Changed paths: - M /trunk/aclocal-fallback/gtk-2.0.m4 + M /trunk/debian/control -From Jess Balint: modern versions of pkg-config want --cflags or --libs *before* the library we're asking about +Drop non-existing omniidl from wireshark-dev dependancy list. ------------------------------------------------------------------------ -r22366 | gerald | 2007-07-20 14:31:19 -0700 (Fri, 20 Jul 2007) | 2 lines +r29009 | jake | 2009-07-07 22:24:55 -0700 (Tue, 07 Jul 2009) | 2 lines Changed paths: - M /trunk/image/wslogo.svg - -Make the lawyer happy - add a registered trademark symbol. + M /trunk/debian/rules +Drop obsolete --enable-gtk2 CFLAG +Make fakeroot actually work by setting proper LD_LIBRARY_PATH ------------------------------------------------------------------------ -r22367 | gerald | 2007-07-20 14:43:07 -0700 (Fri, 20 Jul 2007) | 4 lines +r29010 | jake | 2009-07-07 23:07:21 -0700 (Tue, 07 Jul 2009) | 7 lines Changed paths: - M /trunk/capture.c - M /trunk/capture.h - M /trunk/capture_opts.c - M /trunk/capture_opts.h - M /trunk/capture_sync.c - M /trunk/capture_sync.h - M /trunk/doc/dumpcap.pod - M /trunk/dumpcap.c - M /trunk/gtk/capture_dlg.c - M /trunk/gtk/main.c - M /trunk/tshark.c + M /trunk/AUTHORS + M /trunk/epan/dissectors/Makefile.common + A /trunk/epan/dissectors/packet-dtn.c + A /trunk/epan/dissectors/packet-dtn.h -Remove the "-I" flag from dumpcap, and add a "-M" flag used to specify -that "-D" and "-L" should produce machine-readable output. Use this to -move an indirect get_pcap_linktype() call from the GUI to dumpcap. +From Don Chirieleison: +Within the attached diff file are two source files, packet-dtn.h and +packet-dtn.c. Their function is to decode Bundle Protocol PDUs sent using the +UDP or TCP Convergence Layers. These protocols have been released by the +Internet Research Task Force and are described in RFC 4838 and RFC 5050. +Detailed information on DTN can be obtained at www.dtnrg.org. ------------------------------------------------------------------------ -r22368 | gerald | 2007-07-20 17:31:55 -0700 (Fri, 20 Jul 2007) | 3 lines +r29011 | guy | 2009-07-07 23:40:17 -0700 (Tue, 07 Jul 2009) | 3 lines Changed paths: - M /trunk/capture_sync.c + M /trunk/epan/dissectors/packet-dtn.c -Fix Windows Buildbot breakage. Remove an unneeded function and fix a -couple of memory leaks. +"uint" isn't a standard type, and isn't a type defined by GLib; use +guint, as defined by GLib, instead. ------------------------------------------------------------------------ -r22369 | lego | 2007-07-21 08:24:25 -0700 (Sat, 21 Jul 2007) | 3 lines +r29012 | stig | 2009-07-08 00:48:13 -0700 (Wed, 08 Jul 2009) | 3 lines Changed paths: - M /trunk/docbook/Makefile - M /trunk/docbook/Makefile.common - M /trunk/docbook/make-wsluarm.pl - D /trunk/docbook/template-wsluarm.xml - M /trunk/docbook/user-guide.xml - M /trunk/docbook/wsdg_src/WSDG_chapter_tools.xml - -Migrate the wslua ref man into wsug + M /trunk/epan/dissectors/packet-diffserv-mpls-common.c + M /trunk/epan/dissectors/packet-ldp.c + M /trunk/epan/dissectors/packet-rsvp.c + M /trunk/epan/dissectors/x11-fields +From Kovarththanan Rajaratnam: +Duplicate name/blurb removal. ------------------------------------------------------------------------ -r22370 | lego | 2007-07-21 09:25:17 -0700 (Sat, 21 Jul 2007) | 3 lines +r29013 | etxrab | 2009-07-08 00:53:28 -0700 (Wed, 08 Jul 2009) | 1 line Changed paths: - M /trunk/docbook/Makefile - -Fix dependencies - + M /trunk/AUTHORS +Add Darryl G. Champagne. ------------------------------------------------------------------------ -r22371 | lego | 2007-07-21 09:30:17 -0700 (Sat, 21 Jul 2007) | 3 lines +r29014 | stig | 2009-07-08 01:00:55 -0700 (Wed, 08 Jul 2009) | 3 lines Changed paths: - M /trunk/diameter/dictionary.xml - -according to RFC3588 6.7.2 Proxy-Info is a grouped avp + M /trunk/epan/oids.c +From Kovarththanan Rajaratnam: +Avoid duplicate blurb/name. ------------------------------------------------------------------------ -r22372 | lego | 2007-07-21 09:36:20 -0700 (Sat, 21 Jul 2007) | 3 lines +r29015 | stig | 2009-07-08 01:04:30 -0700 (Wed, 08 Jul 2009) | 3 lines Changed paths: - M /trunk/diameter/dictionary.xml - -fix xml + M /trunk/doc/README.developer +From Kovarththanan Rajaratnam: +Update to include the new constraints. ------------------------------------------------------------------------ -r22373 | lego | 2007-07-21 11:23:08 -0700 (Sat, 21 Jul 2007) | 3 lines +r29016 | stig | 2009-07-08 03:41:17 -0700 (Wed, 08 Jul 2009) | 3 lines Changed paths: - M /trunk/epan/wslua/wslua_field.c - -Fix documentation comments + M /trunk/epan/wslua/wslua_proto.c +Default to NULL for description. +Avoid duplicate name/blurb. ------------------------------------------------------------------------ -r22374 | lego | 2007-07-21 11:24:05 -0700 (Sat, 21 Jul 2007) | 3 lines +r29017 | stig | 2009-07-08 05:08:35 -0700 (Wed, 08 Jul 2009) | 2 lines Changed paths: - M /trunk/docbook/Makefile - M /trunk/docbook/Makefile.common - M /trunk/docbook/Makefile.nmake - -work out dependencies in a .common way and make sure we nmake wsluarm + M /trunk/packaging + M /trunk/packaging/macosx + M /trunk/packaging/macosx/ScriptExec +Added some svn:ignore targets for OSX package build. ------------------------------------------------------------------------ -r22375 | lego | 2007-07-21 13:46:41 -0700 (Sat, 21 Jul 2007) | 5 lines +r29018 | wmeier | 2009-07-08 05:50:09 -0700 (Wed, 08 Jul 2009) | 5 lines Changed paths: - M /trunk/docbook - M /trunk/docbook/Makefile.common - M /trunk/docbook/user-guide.xml - A /trunk/docbook/wsluarm.xml - -Cleanup how WsLuaRm is inserted -Add a section introducing wslua and how scripts are loaded (to be completed). -svn:ignore wsluarm (a dummy file to mark the generation of the various components of the reference manual) + M /trunk/epan/dissectors/packet-dtn.c +Do defragment inits via registered init routine + instead of once-only in proto_reg_handoff; +Also: localize handles to proto_reg_handoff; + Fix a typo; ------------------------------------------------------------------------ -r22376 | lego | 2007-07-21 13:48:21 -0700 (Sat, 21 Jul 2007) | 3 lines +r29019 | wmeier | 2009-07-08 06:10:00 -0700 (Wed, 08 Jul 2009) | 2 lines Changed paths: - M /trunk/docbook/wsluarm.xml - -Pset wsluarm.xml + M /trunk/epan/dissectors/packet-radius_packetcable.c +Add references to two specifications ------------------------------------------------------------------------ -r22377 | lego | 2007-07-21 13:49:54 -0700 (Sat, 21 Jul 2007) | 3 lines +r29020 | wmeier | 2009-07-08 06:38:59 -0700 (Wed, 08 Jul 2009) | 3 lines Changed paths: - M /trunk/docbook/wsluarm.xml - -$Id: $ and a fix + M /trunk/radius/dictionary.alcatel +Update dictionary files from FreeRadius 2.1.6 [5/18/09]: part 3d: alcatel +Use dictionary.alcatel as is from the FreeRadius release. ------------------------------------------------------------------------ -r22378 | lego | 2007-07-21 15:34:46 -0700 (Sat, 21 Jul 2007) | 2 lines +r29021 | rbalint | 2009-07-08 07:20:59 -0700 (Wed, 08 Jul 2009) | 2 lines Changed paths: - M /trunk/docbook/wsluarm.xml + M /trunk/epan/wslua/wslua_tvb.c -Add examples of dissector and tap +Minor documentation fix ------------------------------------------------------------------------ -r22379 | jake | 2007-07-22 01:08:41 -0700 (Sun, 22 Jul 2007) | 1 line +r29022 | etxrab | 2009-07-08 07:27:21 -0700 (Wed, 08 Jul 2009) | 2 lines Changed paths: - M /trunk/docbook/custom_layer_pdf.xsl + M /trunk/diameter/dictionary.xml + M /trunk/diameter/etsie2e4.xml + M /trunk/diameter/gqpolicy.xml -Add remark on FOP 0.93 +From Magnus S?\195?\182rman: +Correct AVP properties. ------------------------------------------------------------------------ -r22380 | lego | 2007-07-22 09:43:35 -0700 (Sun, 22 Jul 2007) | 3 lines +r29023 | jmayer | 2009-07-08 08:26:04 -0700 (Wed, 08 Jul 2009) | 3 lines Changed paths: - M /trunk/docbook/wsug_src/WSUG_chapter_customize.xml - -Add some useful hints as examples of payload_protocols to the User DLT table description + M /trunk/epan/dissectors/packet-glbp.c +Readd the feature to skip the unknown/faulty remainder +of an IE and still display the next one(s). ------------------------------------------------------------------------ -r22381 | lego | 2007-07-22 09:44:25 -0700 (Sun, 22 Jul 2007) | 2 lines +r29024 | jmayer | 2009-07-08 08:29:37 -0700 (Wed, 08 Jul 2009) | 5 lines Changed paths: - M /trunk/epan/dissectors/packet-eth.c + M /trunk/epan/dissectors/packet-ip.c -register dissect_eth_maybefcs as "eth" users might find it useful. +Currently, the expert code notifies if a packet is addressed +to 224.0.0.x with a TTL>1. Some protocols (notably VRRP and GLBP) +send out a TTL of 255 and thus cause a notice. That should be fixed, +so for now: Add a FIXME about that. ------------------------------------------------------------------------ -r22382 | martinm | 2007-07-23 07:39:17 -0700 (Mon, 23 Jul 2007) | 2 lines +r29025 | etxrab | 2009-07-08 09:16:13 -0700 (Wed, 08 Jul 2009) | 3 lines Changed paths: - M /trunk/epan/dissectors/packet-rtp.c + M /trunk/gtk/new_packet_list.c -Make contributing items and hdr extensions proper fields. +We are only handling one row at a time(right?). +Shouldn't the row_data_t structures col_text and col_filter just hold the number of columns (cfile.cinfo.num_cols) rather than [NUM_COL_FMTS] with an adittional col_fmt[] all beeing dynamically allocated? ------------------------------------------------------------------------ -r22383 | morriss | 2007-07-23 12:32:40 -0700 (Mon, 23 Jul 2007) | 19 lines +r29026 | wmeier | 2009-07-08 10:23:58 -0700 (Wed, 08 Jul 2009) | 7 lines Changed paths: - M /trunk/AUTHORS - M /trunk/epan/dissectors/packet-stun2.c + M /trunk/radius/dictionary.cisco.vpn3000 -From Marc Petit-Huguenin: this is an update to the STUN2 dissector using the -last draft, draft-ietf-behave-rfc3489bis-07. Changelog: - -* My employer is now sponsoring this work, so added a copyright line. -* Added a comment for each method/attribute with the RFC/I-D where is - it defined, so it will be easier to add new STUN usages. -* Removed the SHARED-SECRET method. -* Removed the PASSWORD and REFRESH-INTERVAL attributes. -* Changed "Response" to "Success Response". -* Changed "Error Reason Phase" to "Error Reason Phrase". -* Added reassembly for TCP segments on STUN2. -* Updated STUN acronym expansion. -* Renamed STUN2_ERROR to ERROR_RESPONSE. -* Changed the value of attribute FINGERPRINT from 0x8025 to 0x8028. -* Display if an unknown attribute is comprehension-optional or - comprehension-required. -* Reorganized order of attributes in the dissector code. -* The message length is now displayed in decimal. +Update dictionary files from FreeRadius 2.1.6 [5/18/09]: part 3e: cisco.vpn3000 +dictionary.cisco.vpn3000 from FreeRadius v 2.1.6 plus additions: + a. Values as defined in the previous Wireshark version of dictionary.cisco.vpn3000; + b. Attributes as defined in: +http://www.cisco.com/en/US/docs/security/vpn3000/vpn3000_47/configuration/guide/ldapapp.html#wp1564468 + Additions from the FreeRadius version marked with "## [wireshark]". ------------------------------------------------------------------------ -r22384 | ulfl | 2007-07-23 13:06:03 -0700 (Mon, 23 Jul 2007) | 1 line +r29027 | jake | 2009-07-08 10:46:37 -0700 (Wed, 08 Jul 2009) | 2 lines Changed paths: - M /trunk/epan/dissectors/packet-clnp.c + M /trunk/epan/dissectors/packet-dtn.c -show the number of fragment bytes in the info column ------------------------------------------------------------------------- -r22385 | ulfl | 2007-07-23 13:07:51 -0700 (Mon, 23 Jul 2007) | 3 lines -Changed paths: - M /trunk/plugins/profinet/packet-dcerpc-pn-io.c +Address the size_t vs. gint issue. -add dissection of blocks: - { 0x021E, "CheckSyncDifference"}, - { 0x021F, "CheckMAUTypeDifference"}, ------------------------------------------------------------------------ -r22386 | ulfl | 2007-07-23 13:08:53 -0700 (Mon, 23 Jul 2007) | 1 line +r29028 | etxrab | 2009-07-08 11:36:31 -0700 (Wed, 08 Jul 2009) | 3 lines Changed paths: - M /trunk/plugins/profinet/packet-dcom-cba-acco.c - -remove ProvCRID from expert info output, so the composite view is more compact ------------------------------------------------------------------------- -r22387 | ulfl | 2007-07-23 13:11:05 -0700 (Mon, 23 Jul 2007) | 2 lines -Changed paths: - M /trunk/epan/column-utils.c - M /trunk/epan/column.c - M /trunk/epan/column_info.h - M /trunk/epan/expert.c - -- add a column for the expert info severity level -- fix a column related bug introduced in SVN 20118 ------------------------------------------------------------------------- -r22388 | ulfl | 2007-07-23 13:12:18 -0700 (Mon, 23 Jul 2007) | 1 line -Changed paths: - M /trunk/update.c + M /trunk/epan/dissectors/packet-isup.c + M /trunk/epan/dissectors/packet-smpp.c + M /trunk/epan/dissectors/packet-ucp.c + M /trunk/gtk/ansi_a_stat.c + M /trunk/gtk/ansi_map_stat.c + M /trunk/gtk/camel_counter.c + M /trunk/gtk/gsm_a_stat.c + M /trunk/gtk/gsm_map_stat.c + M /trunk/gtk/gsm_map_summary.c + M /trunk/gtk/h225_counter.c + M /trunk/gtk/iax2_analysis.c + M /trunk/gtk/mac_lte_stat_dlg.c + M /trunk/gtk/mtp3_stat.c + M /trunk/gtk/mtp3_summary.c + M /trunk/gtk/rtp_analysis.c + M /trunk/gtk/rtp_stream_dlg.c + M /trunk/gtk/sctp_assoc_analyse.c + M /trunk/gtk/sctp_chunk_stat.c + M /trunk/gtk/sctp_stat_dlg.c + M /trunk/gtk/sip_stat.c + M /trunk/gtk/t38_analysis.c + M /trunk/gtk/voip_calls_dlg.c + M /trunk/gtk/wsp_stat.c -use the right return type of update_pref(), to prevent a warning +From Kovarththanan Rajaratnam: +No letter-shortcuts in Telephony menu. +https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=3678 ------------------------------------------------------------------------ -r22389 | ulfl | 2007-07-23 13:18:01 -0700 (Mon, 23 Jul 2007) | 1 line +r29029 | guy | 2009-07-08 12:19:06 -0700 (Wed, 08 Jul 2009) | 2 lines Changed paths: - M /trunk/gtk/menu.c + M /trunk/tshark.c -for the Ethernet conversation filter, don't use ethertype but the data link address type being Ethernet. If the ethertype field is a length (0-1500), it will contain 0 - and the filter wouldn't work that way ------------------------------------------------------------------------- -r22390 | morriss | 2007-07-23 15:38:57 -0700 (Mon, 23 Jul 2007) | 1 line -Changed paths: - M /trunk/epan/dissectors/Makefile.common +Clarify that "-w" specifies a *pcap-format* file to be written to. -Move packet-isup to CLEAN_DISSECTOR_SRC--it compiles cleanly for me. ------------------------------------------------------------------------ -r22391 | etxrab | 2007-07-23 16:02:54 -0700 (Mon, 23 Jul 2007) | 6 lines +r29030 | wmeier | 2009-07-08 12:35:49 -0700 (Wed, 08 Jul 2009) | 5 lines Changed paths: - M /trunk/asn1/camel/Makefile.nmake - M /trunk/asn1/camel/camel.cnf - M /trunk/asn1/camel/packet-camel-template.c - M /trunk/asn1/inap/packet-inap-template.c - M /trunk/epan/dissectors/packet-camel.c - M /trunk/epan/dissectors/packet-inap.c + M /trunk/radius/dictionary.aruba -Fix bug -http://bugs.wireshark.org/bugzilla/show_bug.cgi?id=1699 Bad decoding of Camel PromptAndCollectUserInfo +Update dictionary files from FreeRadius 2.1.6 [5/18/09]: part 3f: aruba + - FreeRadius 2.1.6 dictionary.aruba plus additions: + See Wireshark Bug #3104 and SVN #26945. + See also: https://airheads.arubanetworks.com/vBulletin/showthread.php?t=910 -By fixing up the generation of HF vars for Arg etc - -Add an OID name to INAP. ------------------------------------------------------------------------ -r22392 | morriss | 2007-07-23 16:29:36 -0700 (Mon, 23 Jul 2007) | 1 line +r29031 | wmeier | 2009-07-08 13:29:06 -0700 (Wed, 08 Jul 2009) | 3 lines Changed paths: - M /trunk/epan/dissectors/Makefile.common + M /trunk/radius/dictionary.ascend -Getting brave (or foolish?): move packet-bacapp, packet-cops, packet-diameter, and packet-sctp to CLEAN_DISSECTOR_SRC ------------------------------------------------------------------------- -r22393 | morriss | 2007-07-23 17:44:07 -0700 (Mon, 23 Jul 2007) | 1 line -Changed paths: - M /trunk/epan/dissectors/Makefile.common - -(sigh): move packet-bacapp, packet-diameter, and packet-sctp back out of CLEAN_DISSECTOR_SRC. Next time: check the compile logs on the buildbots _before_ experimenting ------------------------------------------------------------------------- -r22394 | kukosa | 2007-07-24 00:37:10 -0700 (Tue, 24 Jul 2007) | 1 line -Changed paths: - M /trunk/asn1/qsig/Makefile - M /trunk/asn1/qsig/Makefile.nmake - M /trunk/asn1/qsig/QSIG-CF.asn - M /trunk/asn1/qsig/QSIG-NA.asn - A /trunk/asn1/qsig/SYNC-SIG.asn - M /trunk/asn1/qsig/qsig-exp.cnf - M /trunk/asn1/qsig/qsig.cnf - M /trunk/epan/dissectors/packet-qsig.c - M /trunk/epan/dissectors/packet-qsig.h +Update dictionary files from FreeRadius 2.1.6 [5/18/09]: part 3g: ascend + FreeRadius 2.1.6 dictionary.ascend as is; -QSIG extended with SYNC-SIG operations (ECMA-245) ------------------------------------------------------------------------ -r22395 | martinm | 2007-07-24 08:15:02 -0700 (Tue, 24 Jul 2007) | 2 lines +r29032 | wmeier | 2009-07-08 13:50:56 -0700 (Wed, 08 Jul 2009) | 3 lines Changed paths: - M /trunk/wiretap/catapult_dct2000.c + M /trunk/radius/dictionary.freeradius -More space needed for wimax frames. +Update dictionary files from FreeRadius 2.1.6 [5/18/09]: part 3h: freeradius + FreeRadius 2.1.6 dictionary.freeradius as is; ------------------------------------------------------------------------ -r22396 | etxrab | 2007-07-24 10:20:44 -0700 (Tue, 24 Jul 2007) | 4 lines +r29033 | jake | 2009-07-08 14:04:53 -0700 (Wed, 08 Jul 2009) | 1 line Changed paths: - M /trunk/asn1/camel/Makefile - M /trunk/asn1/camel/camel.cnf - M /trunk/asn1/camel/packet-camel-template.c - M /trunk/epan/dissectors/packet-camel.c + M /trunk/asn1/snmp/packet-snmp-template.c -From Florent Drouin: -- add a subtree to the ApplyChargingXX Report -- add a subtree to ReleaseCall and ReleaseSMS -- synchronize Unix and Windows makefile. +Remove hint of name resolution when it's not there. ------------------------------------------------------------------------ -r22397 | guy | 2007-07-24 14:13:34 -0700 (Tue, 24 Jul 2007) | 3 lines +r29034 | stig | 2009-07-09 02:28:05 -0700 (Thu, 09 Jul 2009) | 3 lines Changed paths: - M /trunk/epan + M /trunk/gtk/main_statusbar.c -Add diam_dict.c to the list of files to ignore in SVN (it's a generated -file). +Pop the welcome header when we are finished capture without updating packet +list in real time, so we get back to the welcome screen when closing the file. ------------------------------------------------------------------------ -r22398 | ulfl | 2007-07-24 14:15:34 -0700 (Tue, 24 Jul 2007) | 10 lines +r29035 | stig | 2009-07-09 04:32:50 -0700 (Thu, 09 Jul 2009) | 3 lines Changed paths: - M /trunk/plugins/profinet/packet-dcerpc-pn-io.c - -from HPfrommer@hilscher.com: -I?\226?\128?\153ve fixed a bug in the Profinet-Dissector -(plugins/profinet/packet-dcerpc-pn-io.c). - -In PROFINET IO DCE RPC write-requests, only the first IR frame dataset -in PDIRFrameData was dissected. + M /trunk/epan/dissectors/Makefile.common + A /trunk/epan/dissectors/packet-icmp.c (from /trunk/epan/dissectors/packet-ip.c:29033) + M /trunk/epan/dissectors/packet-ip.c + M /trunk/epan/dissectors/packet-ip.h -I?\226?\128?\153ve fixed the problem, now all IR frame datasets are dissected into -individual sub-trees. +Split packet-ip into packet-ip and packet-icmp. +Some cleanup in handles and ett entries. ------------------------------------------------------------------------ -r22399 | jake | 2007-07-24 14:23:55 -0700 (Tue, 24 Jul 2007) | 2 lines +r29036 | wmeier | 2009-07-09 05:44:16 -0700 (Thu, 09 Jul 2009) | 9 lines Changed paths: - M /trunk/epan/dissectors/packet-bootp.c - -From Francois-Xavier Le Bail: -The following patch decodes DHCP option 121. (RFC 3442) ------------------------------------------------------------------------- -r22400 | ulfl | 2007-07-25 01:38:31 -0700 (Wed, 25 Jul 2007) | 1 line -Changed paths: - M /trunk/plugins/profinet/packet-dcerpc-pn-io.c + M /trunk/radius/dictionary.3gpp2 -fix unused parameter warning by adding _U_ ------------------------------------------------------------------------- -r22401 | morriss | 2007-07-25 10:16:02 -0700 (Wed, 25 Jul 2007) | 1 line -Changed paths: - M /trunk/plugins/wimax/mac_hd_generic_decoder.c + Update dictionary files from FreeRadius 2.1.6 [5/18/09]: part 3i: 3gpp2 + - FreeRadius 2.1.6 dictionary.3gpp2 plus additions based upon + the latest 3GPP2 specification: + "cdma2000 Wireless IP Network Standard: Accounting Services and 3GPP2 Radius VSAs + 3GPP2 X.S0011-005-D + Version: 2.0 + Version Date: November 2008" + http://www.3gpp2.org/public_html/Specs/X.S0011-005-D_v2.0_081103.pdf -Initialize a couple of variables to prevent a couple (false, I think) "could be used uninitialized" warnings from GCC ------------------------------------------------------------------------ -r22402 | gal | 2007-07-25 12:11:02 -0700 (Wed, 25 Jul 2007) | 3 lines +r29037 | etxrab | 2009-07-09 08:26:41 -0700 (Thu, 09 Jul 2009) | 1 line Changed paths: - M /trunk/epan/dissectors/packet-tnef.c - -Small cosmetic change to show Named Property name. - + M /trunk/diameter/dictionary.xml +Update 3GPP AVP:s ------------------------------------------------------------------------ -r22403 | lego | 2007-07-25 14:30:51 -0700 (Wed, 25 Jul 2007) | 8 lines +r29038 | wmeier | 2009-07-09 08:59:02 -0700 (Thu, 09 Jul 2009) | 7 lines Changed paths: - M /trunk/gtk/capture_file_dlg.c - - -from Florent DROUIN: -I did load an k12 file (.rf5), and want to save the selected frames in a new file. -I got the error "Wireshark can't save this capture in that format" -I think this is due to this correction: http://anonsvn.wireshark.org/viewvc/viewvc.cgi?view=rev&revision=22214 -I have got a patch to force the type of file to libpcap, only if no other format is available. It should solve both problems. + M /trunk/radius/dictionary.3gpp +Update dictionary files from FreeRadius 2.1.6 [5/18/09]: part 3j: 3gpp + FreeRadius 2.1.6 dictionary.3gpp plus additions based upon: + http://pda.etsi.org/exchangefolder/ts_129061v080300p.pdf + (ETSI TS 129 061 V8.3.0 (2009-06)) + Also: Add values for RAT-Type; (packet-gtp custom AVP 3GPP VSA dissector + no longer required for 3GPP-RAT-Type). ------------------------------------------------------------------------ -r22404 | gerald | 2007-07-25 14:56:37 -0700 (Wed, 25 Jul 2007) | 2 lines +r29039 | wmeier | 2009-07-09 09:02:34 -0700 (Thu, 09 Jul 2009) | 3 lines Changed paths: - M /trunk/docbook/wsdg_src/WSDG_chapter_sources.xml + M /trunk/epan/dissectors/packet-gtp.c -Update the sections on submitting patches. +packet-gtp: 3GPP AVP custom VSA dissection no longer required for 3GPP-RAT-Type attribute. + 3GPP-RAT-Type values are now defined in the Radius dictionary.3gpp file. ------------------------------------------------------------------------ -r22405 | jake | 2007-07-25 23:45:19 -0700 (Wed, 25 Jul 2007) | 1 line +r29040 | wmeier | 2009-07-09 13:10:39 -0700 (Thu, 09 Jul 2009) | 7 lines Changed paths: - M /trunk/docbook/wsdg_src/WSDG_chapter_sources.xml + A /trunk/radius/dictionary.freeradius.internal -Filling in ChSrcDeb section ------------------------------------------------------------------------- -r22406 | kukosa | 2007-07-26 07:00:48 -0700 (Thu, 26 Jul 2007) | 2 lines -Changed paths: - M /trunk/epan/dissectors/packet-ber.c - M /trunk/epan/libwireshark.def +Add FreeRadius v2.1.6 dictionary.freeradius.internal (for completeness). +This file contains "Non Protocol Attributes used by FreeRADIUS". +The "$inlude dictionary.freeradius.internal" line in +the Radius "dictionary" file is commented out and thus the +dictionary.freeradius.internal file is not +read by Wireshark as part of the Radius dictionary files load. -- export some ASN.1 functions from libwireshark -- fill-in actx->created_item in dissect_ber_object_identifier() ------------------------------------------------------------------------ -r22407 | kukosa | 2007-07-26 07:31:38 -0700 (Thu, 26 Jul 2007) | 1 line +r29041 | wmeier | 2009-07-09 13:21:39 -0700 (Thu, 09 Jul 2009) | 9 lines Changed paths: - M /trunk/epan/dissectors/packet-ber.c + M /trunk/radius/dictionary -remove unused variable ------------------------------------------------------------------------- -r22408 | morriss | 2007-07-26 12:27:22 -0700 (Thu, 26 Jul 2007) | 1 line -Changed paths: - M /trunk/epan/dissectors/packet-sctp.c - -Check COL_INFO before calling col_set_fence(..., COL_INFO) rather than COL_PROTOCOL ------------------------------------------------------------------------- -r22409 | morriss | 2007-07-26 13:05:54 -0700 (Thu, 26 Jul 2007) | 7 lines -Changed paths: - M /trunk/asn1/tcap/tcap.cnf - M /trunk/epan/dissectors/packet-sccp.c - M /trunk/epan/dissectors/packet-tcap.c +FreeRadius v2.1.6 "dictionary" file with the following changes: + - enabled include: dictionary.cisco.vpn3000 + - disabled include: dictionary.vqp + - disabled include: dictionary.freeradius.internal + - added include: dictionary.chillispot: as per 2009-06-11 commit + in the FreeRadius repository. + - added: Comment re Wireshark usage of the integer data type. -Change a bunch of calls to col_append_*() to col_add_*() in places where we -_want_ what's currently in the INFO column (usually a more generic message -type from a lower level dissector) replaced (usually with a more -specific--higher level--message type from the currect dissector). Add a -comment there not to change it back and to explain the use of col_set_fence() -in case someone finds data there that they _don't_ want replaced. ------------------------------------------------------------------------ -r22410 | guy | 2007-07-26 19:51:42 -0700 (Thu, 26 Jul 2007) | 3 lines +r29042 | wmeier | 2009-07-09 13:28:46 -0700 (Thu, 09 Jul 2009) | 3 lines Changed paths: - M /trunk/configure.in - M /trunk/wiretap/configure.in + A /trunk/radius/README.radius_dictionary -Step 1 in adding support for reentrant Flex scanners if Flex supports -them - check whether Flex supports them. +README describing the Wireshark changes to the FreeRadius +v2.1.6 dictionary files as of 2009-07-09. ------------------------------------------------------------------------ -r22411 | kukosa | 2007-07-26 23:23:45 -0700 (Thu, 26 Jul 2007) | 2 lines +r29043 | wmeier | 2009-07-09 13:31:22 -0700 (Thu, 09 Jul 2009) | 3 lines Changed paths: - M /trunk/asn1/tcap/tcap.cnf - M /trunk/epan/dissectors/packet-tcap.c + M /trunk/Makefile.am + M /trunk/packaging/nsis/wireshark.nsi -- use #.FN_HDR where #.FN_BODY is not necessary -- modify subtypes for individual TCMessage/ansi... fields instead of switching based on hf_index inside common TransactionPDU type ------------------------------------------------------------------------- -r22412 | morriss | 2007-07-27 07:22:47 -0700 (Fri, 27 Jul 2007) | 1 line -Changed paths: - M /trunk/epan/libwireshark.def +Revised packaging for the Radius directory: +include new Radius dictionary files & etc. -Add fetch_tapped_data ------------------------------------------------------------------------ -r22413 | martinm | 2007-07-27 11:32:09 -0700 (Fri, 27 Jul 2007) | 2 lines +r29044 | etxrab | 2009-07-09 13:44:28 -0700 (Thu, 09 Jul 2009) | 5 lines Changed paths: - M /trunk/epan/dissectors/packet-diameter.c + M /trunk/epan/dissectors/packet-enip.c + M /trunk/epan/dissectors/packet-enip.h + M /trunk/epan/dissectors/packet-ethertype.c + M /trunk/epan/etypes.h -Check the length in unsigned32 AVP data fields. +From Joakim Wiberg: +Device Level Ring protocol addition. +https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=3685 +With some minor changes (blurb NULL whem text equal). ------------------------------------------------------------------------ -r22414 | guy | 2007-07-27 11:52:05 -0700 (Fri, 27 Jul 2007) | 8 lines +r29045 | wmeier | 2009-07-09 14:05:37 -0700 (Thu, 09 Jul 2009) | 2 lines Changed paths: - M /trunk/configure.in - M /trunk/wiretap/configure.in + M /trunk/epan/dissectors/packet-hpteam.c -I think the intent, at least, is to allow people to build Wireshark from -a source release tarball without having Flex (think of a source release -tarball being as much a platform-independent distribution format for -people *not* interested in development, and who are on platforms for -which there aren't binary packages, as a way of getting the source to do -development). Don't check Flex's capabilities in the configure script -(handling reentrant scanners would have to be done differently). +From: : Nathan Hartwell: Patch to fix output of HP Team dissector in Info column ------------------------------------------------------------------------ -r22415 | morriss | 2007-07-27 12:24:40 -0700 (Fri, 27 Jul 2007) | 14 lines +r29046 | etxrab | 2009-07-09 14:18:59 -0700 (Thu, 09 Jul 2009) | 1 line Changed paths: - M /trunk/AUTHORS - M /trunk/asn1/tcap/packet-tcap-template.c - M /trunk/asn1/tcap/packet-tcap-template.h - M /trunk/asn1/tcap/tcap.cnf - M /trunk/epan/dissectors/packet-tcap.c - M /trunk/epan/dissectors/packet-tcap.h - M /trunk/epan/tcap-persistentdata.c - M /trunk/epan/tcap-persistentdata.h - -From Florent Drouin: - -- add support of session management for tcap ANSI. - (In fact, this support already exist for ANSI MAP subdissector, but as our - simulators can reuse the tcap transaction Id, the decoding of the response - may be wrong) -- move the code related to asn1 in tcap.cnf, and update tcap.cnf -- move the code related to the session management in tcap-persistentdata -- add a compilation option to free the entry in the hashtable for a closed - transaction. This is used only for tshark statistics generation, with huge file. -- cleanup and add some comments - -Add Id tags to epan/tcap-persistentdata.{c,h} - ------------------------------------------------------------------------- -r22416 | lego | 2007-07-28 04:37:27 -0700 (Sat, 28 Jul 2007) | 5 lines -Changed paths: - A /trunk/trigcap.c - -A toy I wrote as PoC for a more complex similar tool I'm working on. - -Not in the makefiles yet: It works on my mac but I do not know if it works anywhere else (Guy?) - - ------------------------------------------------------------------------- -r22417 | kukosa | 2007-07-30 01:01:59 -0700 (Mon, 30 Jul 2007) | 1 line -Changed paths: - M /trunk/asn1/Makefile.am - A /trunk/asn1/h450/Addressing-Data-Elements.asn - A /trunk/asn1/h450/Call-Completion-Operations.asn - A /trunk/asn1/h450/Call-Diversion-Operations.asn - A /trunk/asn1/h450/Call-Hold-Operations.asn - A /trunk/asn1/h450/Call-Intrusion-Operations.asn - A /trunk/asn1/h450/Call-Offer-Operations.asn - A /trunk/asn1/h450/Call-Park-Pickup-Operations.asn - A /trunk/asn1/h450/Call-Transfer-Operations.asn - A /trunk/asn1/h450/Call-Waiting-Operations.asn - A /trunk/asn1/h450/Common-Information-Operations.asn - A /trunk/asn1/h450/H225-generic-parameters-definition.asn - A /trunk/asn1/h450/H4501-General-Error-List.asn - A /trunk/asn1/h450/H4501-Supplementary-ServiceAPDU-Structure.asn - M /trunk/asn1/h450/Makefile - M /trunk/asn1/h450/Makefile.nmake - A /trunk/asn1/h450/Manufacturer-specific-service-extension-definition.asn - A /trunk/asn1/h450/Message-Waiting-Indication-Operations.asn - A /trunk/asn1/h450/Name-Operations.asn - A /trunk/asn1/h450/Remote-Operations-Apdus.asn - A /trunk/asn1/h450/h450-ros-exp.cnf - A /trunk/asn1/h450/h450-ros.cnf - M /trunk/asn1/h450/h450.cnf - D /trunk/asn1/h450/h4501.asn - A /trunk/asn1/h450/packet-h450-ros-template.c - A /trunk/asn1/h450/packet-h450-ros-template.h - M /trunk/asn1/h450/packet-h450-template.c - D /trunk/asn1/h450/packet-h450-template.h - M /trunk/epan/dissectors/Makefile.common - M /trunk/epan/dissectors/packet-h450.c - D /trunk/epan/dissectors/packet-h450.h - M /trunk/epan/dissectors/packet-per.c - M /trunk/tools/asn2wrs.py + M /trunk/diameter/dictionary.xml -H.450 regenerated from original ASN.1 sources +Fix cut-n-paste errors. ------------------------------------------------------------------------ -r22418 | kukosa | 2007-07-30 01:22:22 -0700 (Mon, 30 Jul 2007) | 1 line +r29047 | etxrab | 2009-07-09 14:43:57 -0700 (Thu, 09 Jul 2009) | 3 lines Changed paths: - A /trunk/epan/dissectors/packet-h450-ros.c - A /trunk/epan/dissectors/packet-h450-ros.h + M /trunk/asn1/snmp/packet-snmp-template.c + M /trunk/epan/dissectors/packet-snmp.c -add forgotten files +Reworked patch from massimo: +SNMP cannot be decoded in case of appended data to message +https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=3684 ------------------------------------------------------------------------ -r22419 | kukosa | 2007-07-30 05:08:38 -0700 (Mon, 30 Jul 2007) | 1 line +r29048 | etxrab | 2009-07-09 22:40:02 -0700 (Thu, 09 Jul 2009) | 4 lines Changed paths: - M /trunk/asn1/rnsap/RNSAP-CommonDataTypes.asn - M /trunk/asn1/rnsap/RNSAP-Constants.asn - M /trunk/asn1/rnsap/RNSAP-Containers.asn - M /trunk/asn1/rnsap/RNSAP-IEs.asn - M /trunk/asn1/rnsap/RNSAP-PDU-Contents.asn - M /trunk/asn1/rnsap/RNSAP-PDU-Descriptions.asn - M /trunk/asn1/rnsap/packet-rnsap-template.c - M /trunk/asn1/rnsap/rnsap.cnf - M /trunk/epan/dissectors/packet-rnsap.c + M /trunk/epan/dissectors/packet-iec104.c -RNSAP updated to V7.5.0 (2007-06) +From Joan Ramio: +IEC 60870-5-104 dissector decodes nothing +(new_tvb reported length bug) +https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=3650 ------------------------------------------------------------------------ -r22420 | jake | 2007-07-30 06:06:01 -0700 (Mon, 30 Jul 2007) | 4 lines +r29049 | stig | 2009-07-10 01:03:19 -0700 (Fri, 10 Jul 2009) | 2 lines Changed paths: - M /trunk/epan/dissectors/packet-text-media.c + M /trunk/epan/dissectors/packet-enip.c -Fix for bug 1712: -RFC 4627 defines "The application/json Media Type for JavaScript Object Notation (JSON)" -application/json is a text based type used by JavaScript applications and web pages. +Header field cleanup. ------------------------------------------------------------------------ -r22421 | morriss | 2007-07-30 10:10:20 -0700 (Mon, 30 Jul 2007) | 6 lines +r29050 | stig | 2009-07-10 02:09:11 -0700 (Fri, 10 Jul 2009) | 8 lines Changed paths: - M /trunk/asn1/tcap/packet-tcap-template.c - M /trunk/asn1/tcap/tcap.cnf - M /trunk/epan/dissectors/packet-tcap.c - M /trunk/epan/tcap-persistentdata.c + M /trunk/epan/dissectors/packet-icmp.c -From Florent Drouin: +Cleanup handling of ICMP type and code: +- Use value_string to convert strings +- Added more types and codes from IANA -Correct bug in TCAP statistics when read filter is used. -Rename the TCAP decoding functions to show which are ITU vs. ANSI. -Don't unregister an ITU SSN if it's used by an ANSI subdissector. +Removed use of check_col() +Check checksum also if no tree +Some white space cleanup ------------------------------------------------------------------------ -r22422 | morriss | 2007-07-30 10:21:40 -0700 (Mon, 30 Jul 2007) | 1 line +r29051 | stig | 2009-07-10 02:12:13 -0700 (Fri, 10 Jul 2009) | 3 lines Changed paths: - M /trunk/epan/dissectors/packet-icmpv6.c - M /trunk/epan/dissectors/packet-ip.c - -As requested by Mike Rogovin: register the ICMP dissector by name. For completeness, also register ICMPv6 by name. ------------------------------------------------------------------------- -r22423 | martinm | 2007-07-30 11:45:48 -0700 (Mon, 30 Jul 2007) | 2 lines -Changed paths: - M /trunk/epan/dissectors/packet-ftp.c + M /trunk/epan/dissectors/packet-ff.c -Parse EPSV responses (229) & set up FTP-DATA conversation. +Use correct length for "Version OD Calling". +This fixes bug 3694. ------------------------------------------------------------------------ -r22424 | guy | 2007-07-30 13:22:37 -0700 (Mon, 30 Jul 2007) | 18 lines +r29052 | etxrab | 2009-07-10 02:40:11 -0700 (Fri, 10 Jul 2009) | 1 line Changed paths: - M /trunk/epan/Makefile.am - M /trunk/epan/dfilter/Makefile.am - M /trunk/epan/dfilter/scanner.l - M /trunk/epan/diam_dict.l - M /trunk/epan/dtd_parse.l - M /trunk/epan/dtd_preparse.l - M /trunk/epan/radius_dict.l - M /trunk/epan/uat_load.l - M /trunk/plugins/mate/Makefile.am - M /trunk/plugins/mate/mate_parser.l - M /trunk/text2pcap-scanner.l - M /trunk/wiretap/Makefile.am - M /trunk/wiretap/ascend-scanner.l - M /trunk/wiretap/k12text.l - -Add comments to various %option items to explain what they're doing. -Move the %options to the beginning if they weren't already there, and -put them in the same order in all files. - -Add "prefix=" options to .l files that don't already have them, so we -don't have to pass a "-P" option. - -Add "never-interactive" and "noyywrap" options to our lexical analyzers, -to remove extra isatty() checks and to eliminate the need for yywrap() -from the Flex library. - -Get rid of %option nostdinit - that's the default. - -Add .l.c: rules to Makefile.am files, replacing the rules for specific -.l files. Have those rules all check that $(LEX) is set. - -Update the address for the FSF. + M /trunk/diameter/dictionary.xml +More 3GPP updates. ------------------------------------------------------------------------ -r22425 | lego | 2007-07-30 14:10:12 -0700 (Mon, 30 Jul 2007) | 3 lines +r29053 | etxrab | 2009-07-10 05:26:39 -0700 (Fri, 10 Jul 2009) | 2 lines Changed paths: - M /trunk/editcap.c - -for bug 1158 have editcap print the value of the timestamps while running so I can get feedback from the user. - + M /trunk/epan/dissectors/packet-gtp.c +Restore hf_gtp_ext_rat_type as it's used in decode_gtp_rat_type(). +Fix IMEI(SV) While we're at it. ------------------------------------------------------------------------ -r22426 | lego | 2007-07-30 14:17:03 -0700 (Mon, 30 Jul 2007) | 3 lines +r29054 | stig | 2009-07-10 05:48:48 -0700 (Fri, 10 Jul 2009) | 7 lines Changed paths: - M /trunk/editcap.c + M /trunk/epan/dissectors/packet-icmpv6.c + M /trunk/epan/dissectors/packet-ipv6.h -nononono.... print one on 250 not every line +Cleanup handling of ICMPv6 type and code (not complete): +- Use value_string to convert strings +- Added more types and codes from IANA +Removed use of check_col() +Some white space cleanup ------------------------------------------------------------------------ -r22427 | lego | 2007-07-30 16:32:47 -0700 (Mon, 30 Jul 2007) | 3 lines +r29055 | etxrab | 2009-07-10 08:15:14 -0700 (Fri, 10 Jul 2009) | 1 line Changed paths: - M /trunk/epan/dfilter/dfilter-macro.c - M /trunk/epan/dfilter/dfilter-macro.h - M /trunk/epan/proto.c - M /trunk/epan/proto.h - M /trunk/file.c - -As per Ulf's request add ${proto.field} macros that will use the value of the given field has in the last selected packet. - + M /trunk/epan/column_info.h +Fix a typo. ------------------------------------------------------------------------ -r22428 | guy | 2007-07-30 18:24:26 -0700 (Mon, 30 Jul 2007) | 5 lines +r29056 | tuexen | 2009-07-10 13:00:54 -0700 (Fri, 10 Jul 2009) | 3 lines Changed paths: - M /trunk/tools/lemon/lemonflex-tail.inc + M /trunk/AUTHORS + M /trunk/epan/dissectors/Makefile.common + A /trunk/epan/dissectors/packet-gsm_abis_ip.c + M /trunk/epan/dissectors/packet-rsl.c -If YY_SKIP_YYWRAP is defined, don't bother defining WRAP_FUNC - with -flex 2.5.31, WRAP_FUNC will end up being defined as a value that, when -used as a function-style macro, expands to 1, so the definition of -WRAP_FUNC will get a syntax error. +Add ip.access A-bis over IP dissector received from Harald Welte. +Removed check_col() calls. ------------------------------------------------------------------------ -r22429 | guy | 2007-07-30 18:32:47 -0700 (Mon, 30 Jul 2007) | 2 lines +r29057 | tuexen | 2009-07-10 13:03:25 -0700 (Fri, 10 Jul 2009) | 2 lines Changed paths: - M /trunk/epan/libwireshark.def + M /trunk/epan/dissectors/packet-gsm_abis_ip.c -Export dfilter_macro_build_ftv_cache() for use by Wireshark. +Fix the two other nits reported by Jaap. ------------------------------------------------------------------------ -r22430 | martinm | 2007-07-31 06:53:45 -0700 (Tue, 31 Jul 2007) | 2 lines +r29058 | tuexen | 2009-07-10 13:07:57 -0700 (Fri, 10 Jul 2009) | 2 lines Changed paths: - M /trunk/wiretap/catapult_dct2000.c - -Add "igmp" -> "ip" mapping. + M /trunk/epan/dissectors/packet-gsm_abis_ip.c ------------------------------------------------------------------------- -r22431 | ulfl | 2007-07-31 11:57:51 -0700 (Tue, 31 Jul 2007) | 1 line -Changed paths: - M /trunk/plugins/profinet/packet-pn.c - M /trunk/plugins/profinet/packet-pn.h +Fix last issue reported by Jaap. -add helper function dissect_pn_int32() ------------------------------------------------------------------------ -r22432 | ulfl | 2007-07-31 12:01:15 -0700 (Tue, 31 Jul 2007) | 1 line +r29059 | wmeier | 2009-07-10 13:35:34 -0700 (Fri, 10 Jul 2009) | 2 lines Changed paths: - M /trunk/plugins/profinet/moduleinfo.h - M /trunk/plugins/profinet/packet-pn-ptcp.c - M /trunk/plugins/profinet/packet-pn-rt.c + M /trunk/epan/dissectors/packet-gsm_abis_ip.c -update PTCP dissection to latest specification draft ------------------------------------------------------------------------- -r22433 | ulfl | 2007-07-31 12:03:43 -0700 (Tue, 31 Jul 2007) | 1 line -Changed paths: - M /trunk/manuf - M /trunk/manuf.tmpl +Two minor changes: include emem.h not req'd; SUB_IPACCESS not used. -add PROFINET Multicast OUI 01:0E:CF (in addition to the unicast 00:0E:CF) ------------------------------------------------------------------------ -r22434 | guy | 2007-07-31 17:22:25 -0700 (Tue, 31 Jul 2007) | 3 lines +r29060 | jake | 2009-07-10 14:54:29 -0700 (Fri, 10 Jul 2009) | 6 lines Changed paths: - M /trunk/epan/Makefile.nmake - M /trunk/epan/dfilter/Makefile.nmake - M /trunk/plugins/mate/Makefile.nmake - M /trunk/wiretap/Makefile.nmake - -Use a common .l.c rule for running Flex on .l files, just as is done on -UN*X. + M /trunk/epan/dissectors/packet-dcm.c + M /trunk/epan/dissectors/packet-dcm.h + M /trunk/gtk/export_object_dicom.c +From David Aggeler: + * - Fixed corrupt files on DICOM Export + * - Fixed memory limitation on DICOM Export + * - Removed minimum packet length for static port mode + * - Simplified checks for heuristic mode + * - Removed unused functions ------------------------------------------------------------------------ -r22435 | jake | 2007-08-01 10:42:43 -0700 (Wed, 01 Aug 2007) | 2 lines +r29061 | gerald | 2009-07-10 16:39:23 -0700 (Fri, 10 Jul 2009) | 7 lines Changed paths: - M /trunk/epan/dissectors/packet-ethertype.c - M /trunk/epan/etypes.h - M /trunk/plugins/m2m/Makefile.common - M /trunk/plugins/m2m/packet-m2m.c - D /trunk/plugins/m2m/wmxtypes.h + M /trunk/epan/dissectors/packet-netflow.c -Clean up the WiMax Mac-to-Mac dissector code. +Don't use tvb_memcpy to fill in a struct. (Cue Jamie Hyneman saying +"EVER!") Expand the entry/scope struct to include private enterprise +numbers instead of casting guint32s to arbritrary chunks of memory. +Limit the number of entries and scopes we allocate. Don't allocate +memory every time we see a new template. Don't use a C++ keyword for +variable names. ------------------------------------------------------------------------ -r22436 | guy | 2007-08-01 13:35:05 -0700 (Wed, 01 Aug 2007) | 5 lines +r29062 | etxrab | 2009-07-11 01:38:41 -0700 (Sat, 11 Jul 2009) | 2 lines Changed paths: - M /trunk/Makefile.am - A /trunk/Makefile.am.inc - M /trunk/epan/Makefile.am - M /trunk/epan/dfilter/Makefile.am - M /trunk/plugins/mate/Makefile.am - M /trunk/wiretap/Makefile.am - -Add a Makefile.am.inc file, to hold rules etc. used by multiple -Makefile.am files; currently, it has the (F)lex-to-C rule. Have -Makefile.am files with .l.c rules include Makefile.am.inc to get that -rule. + M /trunk/epan/dissectors/packet-gsm_abis_ip.c +From Harald Welte: +Add some more GSM A-bis IP message types. ------------------------------------------------------------------------ -r22437 | guy | 2007-08-01 15:20:38 -0700 (Wed, 01 Aug 2007) | 11 lines +r29063 | etxrab | 2009-07-11 02:50:09 -0700 (Sat, 11 Jul 2009) | 3 lines Changed paths: - M /trunk/Makefile.am - A /trunk/Makefile.nmake.inc - M /trunk/epan/Makefile.nmake - M /trunk/epan/dfilter/Makefile.nmake - M /trunk/plugins/mate/Makefile.nmake - M /trunk/wiretap/Makefile.nmake - -Add a Makefile.nmake.inc file, to hold rules etc. used by multiple -Makefile.nmake files; currently, it has the (F)lex-to-C rule and a -.SUFFIXES pseudo-rule to add .l to the list of suffixes. Have -Makefile.nmake files with .l.c rules include Makefile.nmake.inc to get -that rule. - -The names Makefile.am.inc and Makefile.nmake.inc aren't necessarily the -right names for the files in question. - -Use $(PACKAGE) in the Mate plugin's Makefile, rather than "mate". + M /trunk/epan/dissectors/packet-pw-eth.c + M /trunk/gtk/decode_as_dlg.c +From Artem Tamazov: +Analyze->Decode as... menu item becomes unavailable in some situations.(Ethernet-PW) +https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=3642 ------------------------------------------------------------------------ -r22438 | standel | 2007-08-01 19:28:48 -0700 (Wed, 01 Aug 2007) | 7 lines +r29064 | wmeier | 2009-07-11 08:36:18 -0700 (Sat, 11 Jul 2009) | 5 lines Changed paths: - M /trunk/epan/dissectors/packet-ipv6.h - -From Amine Dhraief: - - there is a mistake in the assigned number of the update request and update - ack shim6 control message. Accordingly to draft-ietf-shim6-proto-08 the - update request has a value of 64 and the update ack 65. + M /trunk/epan/dissectors/packet-paltalk.c +Fix use of "unaligned" memory references; +Fixes Bug #3689. +Also: fix IPV4 address comparisons which would be incorrect + on a big-endian machine. ------------------------------------------------------------------------ -r22439 | guy | 2007-08-02 00:54:03 -0700 (Thu, 02 Aug 2007) | 6 lines +r29065 | etxrab | 2009-07-12 02:05:03 -0700 (Sun, 12 Jul 2009) | 2 lines Changed paths: - M /trunk/epan/wslua/Makefile.am - A /trunk/epan/wslua/Makefile.common - M /trunk/epan/wslua/Makefile.nmake - -Move the list of source files to a Makefile.common file. - -Don't put $(srcdir)/ at the beginning of those file names - other -Makefile.am files don't have it, and it appears to break "make -distcheck", at least on my Mac OS X 10.4 machine. + M /trunk/gtk/new_packet_list.c + M /trunk/gtk/packet_list_store.c + M /trunk/gtk/packet_list_store.h +Some small fixes from Jakub Zawadzki joined with my efforts +to only store the used columns. ------------------------------------------------------------------------ -r22440 | guy | 2007-08-02 01:24:00 -0700 (Thu, 02 Aug 2007) | 3 lines +r29066 | stig | 2009-07-12 03:19:13 -0700 (Sun, 12 Jul 2009) | 6 lines Changed paths: - M /trunk/epan/wslua/Makefile.am - M /trunk/epan/wslua/Makefile.nmake + M /trunk/epan/dissectors/packet-dcerpc-eventlog.c + M /trunk/epan/frame_data.h + M /trunk/epan/libwireshark.def + M /trunk/epan/packet.c + M /trunk/epan/packet.h + M /trunk/gtk/main_proto_draw.c + M /trunk/print.c -We have to include Makefile.common if we move definitions we need -there.... +From Kovarththanan Rajaratnam via bug 3702: +This patch optimizes the data source name processing in add_new_data_source() +by delaying it. We now simply store the constant string and lazily compute the +name when needed. This gives a performance boost because we only need the name +if we have multiple data sources. ------------------------------------------------------------------------ -r22441 | guy | 2007-08-02 09:06:13 -0700 (Thu, 02 Aug 2007) | 4 lines +r29067 | wmeier | 2009-07-12 06:41:36 -0700 (Sun, 12 Jul 2009) | 3 lines Changed paths: - M /trunk/epan/wslua/Makefile.am - D /trunk/epan/wslua/Makefile.common - M /trunk/epan/wslua/Makefile.nmake + M /trunk/epan/dissectors/packet-tipc.c -Gak. <> makes it too easy to make these make- scripts do what the rest -do, and take $(srcdir) as the first argument. Back the previous changes -out, for now. +Don't coerce a pointer to guint32 when pointing to a guint8. +Using that pointer will fetch the guint8 plus who knows what.... ------------------------------------------------------------------------ -r22442 | guy | 2007-08-02 12:07:08 -0700 (Thu, 02 Aug 2007) | 2 lines +r29068 | wmeier | 2009-07-12 07:13:01 -0700 (Sun, 12 Jul 2009) | 2 lines Changed paths: - M /trunk/epan/wslua/wslua_pinfo.c + M /trunk/epan/dissectors/packet-sctp.c -Squelch a warning. +Fix a typo ------------------------------------------------------------------------ -r22443 | gerald | 2007-08-02 14:45:27 -0700 (Thu, 02 Aug 2007) | 5 lines +r29069 | jake | 2009-07-12 08:03:05 -0700 (Sun, 12 Jul 2009) | 5 lines Changed paths: - M /trunk/capture-pcap-util.h - M /trunk/capture.c - M /trunk/capture.h - M /trunk/capture_opts.c - M /trunk/capture_opts.h - M /trunk/capture_sync.c - M /trunk/capture_sync.h - M /trunk/doc/README.packaging - M /trunk/dumpcap.c - M /trunk/gtk/capture_if_dlg.c - -Add a "-S" flag to dumpcap, which prints out interface statistics. Use -this in the GUI rather than calling pcap_stats() directly. This gets rid -of the last pcap_open_live() call in the GUI code. Update -README.packaging. + M /trunk/epan/dissectors/packet-rtmpt.c +From Nick Ford: +Chunks handled individually rather than as complete messages which have +the risk of being fragmented and unrecognizable. +Added FLV data type. +Allow simultaneous RTMP streams to be handled independently. ------------------------------------------------------------------------ -r22444 | ulfl | 2007-08-03 12:29:34 -0700 (Fri, 03 Aug 2007) | 3 lines +r29070 | gerald | 2009-07-12 08:03:33 -0700 (Sun, 12 Jul 2009) | 1 line Changed paths: - M /trunk/epan/packet.c - M /trunk/epan/packet_info.h - M /trunk/plugins/profinet/packet-dcerpc-pn-io.c - -- add PDInterfaceFSUDataAdjust block -- start to implement an AR conversation handler + M /trunk/epan/enterprise-numbers + M /trunk/manuf +[Automatic manuf and enterprise-numbers update for 2009-07-12] ------------------------------------------------------------------------ -r22445 | ulfl | 2007-08-03 13:07:06 -0700 (Fri, 03 Aug 2007) | 1 line +r29073 | etxrab | 2009-07-12 09:34:20 -0700 (Sun, 12 Jul 2009) | 1 line Changed paths: - M /trunk/plugins/profinet/packet-dcerpc-pn-io.c + M /trunk/gtk/packet_list_store.c -mark some parameters as unused +Add a forgotten piece of code... ------------------------------------------------------------------------ -r22446 | guy | 2007-08-03 19:13:52 -0700 (Fri, 03 Aug 2007) | 7 lines +r29074 | etxrab | 2009-07-12 12:08:55 -0700 (Sun, 12 Jul 2009) | 1 line Changed paths: - M /trunk/Makefile.am.inc - M /trunk/Makefile.nmake.inc - M /trunk/epan/Makefile.am - M /trunk/epan/Makefile.common - M /trunk/epan/Makefile.nmake - M /trunk/epan/dfilter/Makefile.am - M /trunk/epan/dfilter/Makefile.nmake - M /trunk/epan/dfilter/scanner.l - M /trunk/epan/diam_dict.l - M /trunk/epan/dtd_parse.l - M /trunk/epan/dtd_preparse.l - M /trunk/epan/radius_dict.l - M /trunk/epan/uat_load.l - M /trunk/plugins/mate/Makefile.am - M /trunk/plugins/mate/Makefile.common - M /trunk/plugins/mate/Makefile.nmake - M /trunk/plugins/mate/mate_parser.l - M /trunk/tools/Makefile.am - M /trunk/wiretap/Makefile.am - M /trunk/wiretap/Makefile.common - M /trunk/wiretap/Makefile.nmake - M /trunk/wiretap/ascend-scanner.l - M /trunk/wiretap/k12text.l - -Add a script as a front-end for Flex, to work around various problems, -such as the fact that Flex strips all but the last component of the "-o" -argument, and that it doesn't generate a header file to declare routines -the generated lexical analyzer defines. Use that script when building -lexical analyzers, and, for each lexical analyzer, include the generated -header file in the generated analyzer. + M /trunk/epan/dissectors/packet-rtmpt.c +Make iCommand a guint8. ------------------------------------------------------------------------ -r22447 | guy | 2007-08-03 19:36:21 -0700 (Fri, 03 Aug 2007) | 2 lines +r29075 | etxrab | 2009-07-12 12:38:55 -0700 (Sun, 12 Jul 2009) | 1 line Changed paths: - A /trunk/tools/runlex.sh - A /trunk/wiretap/runlex.sh - -Oops, forgot to check in the script for running Flex/Lex. + M /trunk/gtk/new_packet_list.c + M /trunk/gtk/packet_list_store.c +Column index now corresponds to the column in the tree view. ------------------------------------------------------------------------ -r22448 | guy | 2007-08-03 20:11:06 -0700 (Fri, 03 Aug 2007) | 10 lines +r29076 | sfisher | 2009-07-12 22:27:25 -0700 (Sun, 12 Jul 2009) | 6 lines Changed paths: - M /trunk/tools/runlex.sh - M /trunk/wiretap/runlex.sh + M /trunk/gtk/new_packet_list.c -Sigh, crufty old shells. The Solaris test(1) manual says that - 1) "-e" isn't supported by good old /bin/sh, so we use "-r" - instead; +Change the new packet list to use a cell data function for displaying +values in each column's rows. This is the first step in adding coloring +rule support and other features. - 2) "The algorithm for determining the precedence of the - operators and the return value that will be generated is - based on the number of arguments presented to test", so we - explicitly parenthesize. ------------------------------------------------------------------------ -r22449 | guy | 2007-08-03 20:14:00 -0700 (Fri, 03 Aug 2007) | 2 lines +r29077 | etxrab | 2009-07-13 01:35:30 -0700 (Mon, 13 Jul 2009) | 2 lines Changed paths: - M /trunk/wiretap/Makefile.nmake - -runlex.sh is in tools, not the top-level directory. + M /trunk/epan/dissectors/packet-gsm_a_bssmap.c +APDU incorrectly dissected(BSSLAP Protocol Not Decoded In BSSMAP-LE Messages). +https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=3711 ------------------------------------------------------------------------ -r22450 | guy | 2007-08-03 20:27:18 -0700 (Fri, 03 Aug 2007) | 4 lines +r29078 | martinm | 2009-07-13 03:55:53 -0700 (Mon, 13 Jul 2009) | 2 lines Changed paths: - M /trunk/tools/runlex.sh - M /trunk/wiretap/runlex.sh + M /trunk/epan/dissectors/packet-catapult-dct2000.c -1989 was quite a while ago. We use function prototypes extensively; -don't worry about YY_PROTO, which isn't defined with the newer shinier -versions of Flex. +Remove calls to check_col(), and stop giving '{' a line of its own. ------------------------------------------------------------------------ -r22451 | guy | 2007-08-03 20:47:20 -0700 (Fri, 03 Aug 2007) | 2 lines +r29079 | martinm | 2009-07-13 04:23:40 -0700 (Mon, 13 Jul 2009) | 2 lines Changed paths: - M /trunk/wiretap/ascend-scanner.l + M /trunk/epan/dissectors/packet-mac-lte.c + M /trunk/epan/dissectors/packet-pdcp-lte.c + M /trunk/epan/dissectors/packet-rlc-lte.c -One quote mark sufficeth. +Remove calls to check_col(). ------------------------------------------------------------------------ -r22452 | guy | 2007-08-04 01:04:17 -0700 (Sat, 04 Aug 2007) | 3 lines +r29080 | wmeier | 2009-07-13 07:29:13 -0700 (Mon, 13 Jul 2009) | 3 lines Changed paths: - M /trunk/epan/Makefile.am - M /trunk/epan/Makefile.common - M /trunk/epan/Makefile.nmake + M /trunk/doc/tshark.pod -Treat runlex.sh-generated headers differently from Flex-generated .c -files - for one thing, the former aren't compiled into .o or .obj files. +Add additional indentation to -z <statistics> swction to improve readability. +Various other minor reformatting and rewording. ------------------------------------------------------------------------ -r22453 | guy | 2007-08-04 01:13:22 -0700 (Sat, 04 Aug 2007) | 2 lines +r29081 | wmeier | 2009-07-13 07:54:47 -0700 (Mon, 13 Jul 2009) | 5 lines Changed paths: - M /trunk/epan/Makefile.common + M /trunk/doc/wireshark.pod -Fix cut-and-pasteo. +Add additional indentation to -z <statistics> section to improve readability. +Do some work on "Interface" section to have it match current Wireshark: + additionas/changes to "Menu Items" sub-section. +Various other minor reformatting and rewording. ------------------------------------------------------------------------ -r22454 | lego | 2007-08-04 07:20:37 -0700 (Sat, 04 Aug 2007) | 3 lines +r29082 | etxrab | 2009-07-13 10:33:14 -0700 (Mon, 13 Jul 2009) | 3 lines Changed paths: - M /trunk/epan/dissectors/packet-xml.c - -Add preferences to register XML for a TCP port or as a TCP heuristic dissector. - + M /trunk/epan/dissectors/packet-hci_h4.c +From Kovarththanan Rajaratnam: +hci_h4: Optimize column/field handling +https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=3703 ------------------------------------------------------------------------ -r22455 | sfisher | 2007-08-04 10:52:38 -0700 (Sat, 04 Aug 2007) | 5 lines +r29083 | etxrab | 2009-07-13 10:40:31 -0700 (Mon, 13 Jul 2009) | 3 lines Changed paths: - M /trunk/gtk/export_object.c - M /trunk/gtk/export_object_http.c - M /trunk/gtk/menu.c - - -Change the export object/export object http code to only be included -in the code for GTK versions 2.4 and up instead of 2 and up. - + M /trunk/epan/dissectors/packet-smb2.c +From Chris Costa: +SMB2 Error Response doesn't decode properly. +https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=3609 ------------------------------------------------------------------------ -r22456 | sfisher | 2007-08-04 11:00:27 -0700 (Sat, 04 Aug 2007) | 4 lines +r29084 | guy | 2009-07-13 10:43:44 -0700 (Mon, 13 Jul 2009) | 2 lines Changed paths: - M /trunk/docbook/wsug_src/WSUG_chapter_io.xml - - -Update documentation for change in revision 22455. + M /trunk/epan/dissectors/packet-hci_h4.c +Note what the "Unknown" value is. ------------------------------------------------------------------------ -r22457 | ulfl | 2007-08-06 01:44:26 -0700 (Mon, 06 Aug 2007) | 1 line +r29085 | gerald | 2009-07-13 11:54:24 -0700 (Mon, 13 Jul 2009) | 2 lines Changed paths: - M /trunk/epan/addr_resolv.c - -add a way to read a personal /etc/services file for TCP/UDP/... port service name resolution. ------------------------------------------------------------------------- -r22458 | ulfl | 2007-08-06 02:12:18 -0700 (Mon, 06 Aug 2007) | 1 line -Changed paths: - M /trunk/epan/addr_resolv.c + M /trunk/epan/dissectors/packet-ieee80211.c -remove an unused variable ------------------------------------------------------------------------- -r22459 | etxrab | 2007-08-06 05:16:20 -0700 (Mon, 06 Aug 2007) | 2 lines -Changed paths: - M /trunk/asn1/inap/IN-SCF-SRF-Classes.asn - M /trunk/asn1/inap/IN-SCF-SRF-datatypes.asn - M /trunk/asn1/inap/IN-SCF-SRF-ops-args.asn - M /trunk/asn1/inap/IN-SSF-SCF-Classes.asn - M /trunk/asn1/inap/IN-SSF-SCF-datatypes.asn - M /trunk/asn1/inap/IN-SSF-SCF-ops-args.asn - M /trunk/asn1/inap/IN-common-classes.asn - M /trunk/asn1/inap/IN-common-datatypes.asn - A /trunk/asn1/inap/IN-errorcodes.asn - A /trunk/asn1/inap/IN-errortypes.asn - M /trunk/asn1/inap/IN-object-identifiers.asn - A /trunk/asn1/inap/IN-operationcodes.asn - M /trunk/asn1/inap/Makefile.nmake - M /trunk/asn1/inap/inap.cnf +Squelch a couple of Valgrind warnings. This should fix bug 3700. -Use correct SVN keywords. -Add missing ASN1 files. ------------------------------------------------------------------------ -r22460 | lego | 2007-08-06 15:34:26 -0700 (Mon, 06 Aug 2007) | 6 lines +r29086 | gerald | 2009-07-13 13:12:53 -0700 (Mon, 13 Jul 2009) | 2 lines Changed paths: - M /trunk/wiretap/mpeg.c - -From: Shaun Jackman - -This patch adds MPEG PES (packetized elementary stream) to the list of -magic types in wiretap/mpeg.c. + M /trunk/epan/dissectors/packet-giop.c +Check to see if tvb_child_uncompress returns NULL. Fixes bug 3705. ------------------------------------------------------------------------ -r22461 | lego | 2007-08-07 13:07:43 -0700 (Tue, 07 Aug 2007) | 3 lines +r29087 | jake | 2009-07-13 15:29:59 -0700 (Mon, 13 Jul 2009) | 2 lines Changed paths: - M /trunk/capinfos.c - M /trunk/editcap.c - M /trunk/epan/plugins.c - M /trunk/gtk/main.c - M /trunk/tshark.c - -Make sure that wiretap plugins are loaded before dissectors are (if a new encap type is registered the plugin probably needs it before reg_handoff) - + M /trunk/epan/dissectors/packet-llc.c +Fix for bug 3710: +Use the derived length of the control field i.s.o. assuming its size. ------------------------------------------------------------------------ -r22462 | lego | 2007-08-07 13:09:18 -0700 (Tue, 07 Aug 2007) | 3 lines +r29088 | jake | 2009-07-13 15:46:32 -0700 (Mon, 13 Jul 2009) | 3 lines Changed paths: - M /trunk/epan/libwireshark.def - -Export the entire uat api + M /trunk/doc/tshark.pod +From Reinhard Speyerer: +The description of tshark -t dd is missing from tshark.pod. ------------------------------------------------------------------------ -r22463 | lego | 2007-08-07 14:26:07 -0700 (Tue, 07 Aug 2007) | 8 lines +r29089 | guy | 2009-07-13 16:35:26 -0700 (Mon, 13 Jul 2009) | 6 lines Changed paths: - M /trunk/epan/packet.c - M /trunk/epan/packet.h - -from: Mike Duigou - -Adds a heur_dissector_delete() function to allow heuristic dissectors to be -dynamically disabled based upon, for example, preference settings. + M /trunk/doc/tshark.pod + M /trunk/doc/wireshark.pod -http://bugs.wireshark.org/bugzilla/show_bug.cgi?id=1697 +Fix one place where we didn't mention "-t dd". +Put the description of the default time format after the description of +all the time formats, i.e. say "the default is relative" after we say +what "relative" is. ------------------------------------------------------------------------ -r22464 | richardv | 2007-08-07 15:49:31 -0700 (Tue, 07 Aug 2007) | 3 lines +r29090 | stig | 2009-07-14 02:33:54 -0700 (Tue, 14 Jul 2009) | 2 lines Changed paths: - M /trunk/epan/dissectors/packet-iax2.c + M /trunk/epan/dissectors/packet-smb2.c -remember to dissect IEs which we rely on elsewhere, even when there is no -packet tree. +Header field cleanup. ------------------------------------------------------------------------ -r22465 | lego | 2007-08-07 16:07:27 -0700 (Tue, 07 Aug 2007) | 3 lines +r29091 | etxrab | 2009-07-14 05:41:11 -0700 (Tue, 14 Jul 2009) | 1 line Changed paths: - M /trunk/epan/dissectors/packet-xml.c - -Remove XML heuristic dissector when disabling it. - + M /trunk/gtk/packet_list_store.c +Fix the sort routine. ------------------------------------------------------------------------ -r22466 | jake | 2007-08-08 00:04:28 -0700 (Wed, 08 Aug 2007) | 1 line +r29092 | martinm | 2009-07-14 06:08:23 -0700 (Tue, 14 Jul 2009) | 2 lines Changed paths: - M /trunk/epan/dissectors/packet-iax2.c + M /trunk/epan/dissectors/packet-mac-lte.c -Fix the build ------------------------------------------------------------------------- -r22467 | etxrab | 2007-08-08 05:44:28 -0700 (Wed, 08 Aug 2007) | 2 lines -Changed paths: - M /trunk/epan/dissectors/packet-sigcomp.c +Add preference to control whether decode of CRC-error'd frames should be attempted. -From Daniel Rao: -Implement desegment for SIGCOMP over TCP, similar with HTTP desegment. ------------------------------------------------------------------------ -r22468 | martinm | 2007-08-08 06:12:15 -0700 (Wed, 08 Aug 2007) | 2 lines +r29093 | etxrab | 2009-07-14 10:15:03 -0700 (Tue, 14 Jul 2009) | 3 lines Changed paths: - M /trunk/epan/dissectors/packet-catapult-dct2000.c - -Send free-standing generic XML messages -> xml dissector + M /trunk/wimaxasncp/dictionary.xml +From Rajasekhar Reddy Gali: +"dictionary.xml file is very old..." - Update the Wimax .xml file +https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=3731 ------------------------------------------------------------------------ -r22469 | kukosa | 2007-08-08 07:01:28 -0700 (Wed, 08 Aug 2007) | 1 line +r29094 | martinm | 2009-07-14 10:43:20 -0700 (Tue, 14 Jul 2009) | 2 lines Changed paths: - M /trunk/epan/dissectors/packet-http.c + M /trunk/epan/dissectors/packet-mac-lte.c -add missing initial registration to TCP and SSL ports ------------------------------------------------------------------------- -r22470 | etxrab | 2007-08-08 07:25:17 -0700 (Wed, 08 Aug 2007) | 4 lines -Changed paths: - M /trunk/epan/dissectors/packet-sip.c +Trivial formatting changes to RAR output. -Wireshark fails to decode the MIME encapsulation part correctly if there is a -"white space" in the Content-Type field before the semi-colon. -http://bugs.wireshark.org/bugzilla/show_bug.cgi?id=1716 -Still does not work correctly as packet-multipart.c seems to have got broken. ------------------------------------------------------------------------ -r22471 | etxrab | 2007-08-08 12:50:39 -0700 (Wed, 08 Aug 2007) | 1 line +r29095 | gerald | 2009-07-14 12:13:14 -0700 (Tue, 14 Jul 2009) | 14 lines Changed paths: - M /trunk/epan/dissectors/packet-xml.c + M /trunk/epan/dissectors/packet-ziop.c -Add more XCAP application types. ------------------------------------------------------------------------- -r22472 | ulfl | 2007-08-08 13:06:51 -0700 (Wed, 08 Aug 2007) | 12 lines -Changed paths: - M /trunk/epan/dissectors/packet-ptp.c +From Alvaro Vega Garcia via bug 3652: -From Markus Seehofer: -A new version of the IEEE1588/PTP dissector. This dissector now includes the -coming version 2 of the standard. It supports both IP/UDP and pure ethernet -frames. - -I've done some minor changes: - -LL suffix doesn't work on Win32, used G_GINT64_CONSTANT instead - as described in doc/readme.developer -removed ETHERTYPE_PTP definition, already defined in etypes.h -removed some duplicated "if (tree)" - +Patch with some improvements for packet ziop dissector following patch +about MIOP dissector submitted by Kovarththanan Rajaratnam. ------------------------------------------------------------------------- -r22473 | ulfl | 2007-08-08 15:53:14 -0700 (Wed, 08 Aug 2007) | 3 lines -Changed paths: - M /trunk/epan/dissectors/packet-clnp.c - M /trunk/epan/packet.c - M /trunk/epan/packet_info.h +From me: -add pinfo fields clnp_srcref and clnp_dstref to the clnp dissector, similar to the srcport / destport already existing. As simply using srcport / destport for this will confuse mixed protocol usage (like RFC1006 ISOonTCP), I've added explicit clnp fields. +Add a link to the protocol specification. Don't tvb_memcpy over +structs! Remove some more tvbuffs. Don't call proto_item_add_subtree if +we're not going to use the trees. Call proto_tree_add_item instead of +proto_tree_add_text Remove a bunch of unused ett_ variables and a few +other now-unused variables. Register the field array with the correct +length. -This way, protocols on top of COTP / CLNP have at least a chance to do reassembling correct. ------------------------------------------------------------------------ -r22474 | ulfl | 2007-08-08 16:36:48 -0700 (Wed, 08 Aug 2007) | 1 line +r29096 | etxrab | 2009-07-14 13:49:34 -0700 (Tue, 14 Jul 2009) | 7 lines Changed paths: - M /trunk/epan/packet.c + M /trunk/epan/dissectors/Makefile.common + A /trunk/epan/dissectors/packet-v52.c + M /trunk/epan/dissectors/packet-v5ua.c -don't use NULL to initialise an integer ------------------------------------------------------------------------- -r22475 | jake | 2007-08-08 23:52:13 -0700 (Wed, 08 Aug 2007) | 2 lines -Changed paths: - M /trunk/wiretap/Makefile.am - M /trunk/wiretap/configure.in +From Vladimir Smrekar : +v5.2-User Adaptation Layer and V5.2 Interface. +https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=3732 -Fix for bug 1704: -libm required if C library is not libc (like uclibc) +Me: +Removed check_col(), hf blurbs, removed global vars and regestering +SCTP port in packet-v52.c. ------------------------------------------------------------------------ -r22476 | etxrab | 2007-08-09 05:17:56 -0700 (Thu, 09 Aug 2007) | 2 lines +r29097 | wmeier | 2009-07-14 14:34:03 -0700 (Tue, 14 Jul 2009) | 2 lines Changed paths: - M /trunk/epan/dissectors/packet-imf.c - M /trunk/epan/dissectors/packet-multipart.c + M /trunk/epan/dissectors/packet-v52.c -Packet-imf.c - Offset must be advanced to AFTER CRLF(CRLF). -packet-multipart.c - imf_find_field_end()'s maxlength is last offset in tvb. ------------------------------------------------------------------------- -r22477 | etxrab | 2007-08-09 07:47:25 -0700 (Thu, 09 Aug 2007) | 1 line -Changed paths: - M /trunk/epan/dissectors/packet-ulp.c +#include prefs.h not req'd; Also: remove unused #define -Register by name. ------------------------------------------------------------------------ -r22478 | jake | 2007-08-09 13:40:32 -0700 (Thu, 09 Aug 2007) | 2 lines +r29098 | gerald | 2009-07-14 16:09:59 -0700 (Tue, 14 Jul 2009) | 2 lines Changed paths: - M /trunk/wiretap/file_util.h + M /trunk/epan/dissectors/packet-afs.c -Fix for bug 1659: -Changed eth_dir_get_name(dirent) macro ------------------------------------------------------------------------- -r22479 | jake | 2007-08-09 13:41:09 -0700 (Thu, 09 Aug 2007) | 1 line -Changed paths: - M /trunk/gtk/rtp_player.c +Remove an unused define. -Fix GTK1 compilation. ------------------------------------------------------------------------ -r22480 | guy | 2007-08-09 15:50:16 -0700 (Thu, 09 Aug 2007) | 2 lines +r29100 | stig | 2009-07-15 01:56:12 -0700 (Wed, 15 Jul 2009) | 3 lines Changed paths: - M /trunk/wiretap/file_util.h + M /trunk/epan/proto.c -Parenthesize macro arguments. +From Kovarththanan Rajaratnam: +Add "text" abbrev + tighten FT_FRAMENUM checks. ------------------------------------------------------------------------ -r22481 | etxrab | 2007-08-10 04:41:28 -0700 (Fri, 10 Aug 2007) | 1 line +r29103 | stig | 2009-07-15 12:33:48 -0700 (Wed, 15 Jul 2009) | 2 lines Changed paths: - M /trunk/epan/dissectors/packet-sip.c + M /trunk/epan/dissectors/packet-enip.c + +Indent some comments. -Add header fields. ------------------------------------------------------------------------ -r22482 | etxrab | 2007-08-10 04:42:31 -0700 (Fri, 10 Aug 2007) | 1 line +r29104 | etxrab | 2009-07-15 13:55:31 -0700 (Wed, 15 Jul 2009) | 1 line Changed paths: M /trunk/Makefile.nmake - M /trunk/tools/win32-setup.sh + M /trunk/epan/crc/Makefile.nmake + M /trunk/epan/crypt/Makefile.nmake + M /trunk/epan/dfilter/Makefile.nmake + M /trunk/epan/ftypes/Makefile.nmake + M /trunk/epan/wslua/Makefile.nmake + M /trunk/gtk/Makefile.nmake + M /trunk/plugins/ethercat/Makefile.nmake + M /trunk/wiretap/Makefile.nmake + M /trunk/wsutil/Makefile.nmake -Use the latest GTK2 packages +Add /MP flag to make use of multi cores. ------------------------------------------------------------------------ -r22483 | lego | 2007-08-10 14:03:26 -0700 (Fri, 10 Aug 2007) | 3 lines +r29105 | guy | 2009-07-15 14:30:37 -0700 (Wed, 15 Jul 2009) | 2 lines Changed paths: - M /trunk/dtds/presence.dtd - M /trunk/epan/dissectors/packet-xml.c - -An old proposal from Martin, append to COL_PROTO the name taken from a matching DTD (in case the media-type actually matches it). Having the name of the root element found would be nicer. + M /trunk/epan/dissectors/packet-ziop.c +Get rid of C++-style comment (and anglicize it). ------------------------------------------------------------------------ -r22484 | lego | 2007-08-10 14:07:18 -0700 (Fri, 10 Aug 2007) | 4 lines +r29109 | gerald | 2009-07-15 15:51:01 -0700 (Wed, 15 Jul 2009) | 3 lines Changed paths: - M /trunk/epan/libwireshark.def - - -+prefs_add_uat_preference + M /trunk/epan/dissectors/packet-v52.c +Make sure we advance our offset during a while loop. This should fix recent +fuzz errors. ------------------------------------------------------------------------ -r22485 | jake | 2007-08-11 01:03:46 -0700 (Sat, 11 Aug 2007) | 1 line +r29111 | gerald | 2009-07-15 16:16:10 -0700 (Wed, 15 Jul 2009) | 2 lines Changed paths: - M /trunk/gtk/rtp_player.c - -Fixing the GTK1 build shouldn't break the GTK2 build. ------------------------------------------------------------------------- -r22486 | lego | 2007-08-11 15:05:44 -0700 (Sat, 11 Aug 2007) | 3 lines -Changed paths: - M /trunk/epan/dfilter/scanner.l - + M /trunk/epan/dissectors/packet-v52.c -Use '~' as a synonim for "matches" replace rogue "s with \042 to avoid some text editors going wild +Add a modeline blurb. Minor indentation fix. ------------------------------------------------------------------------ -r22487 | ulfl | 2007-08-12 13:54:30 -0700 (Sun, 12 Aug 2007) | 3 lines +r29114 | etxrab | 2009-07-16 01:27:18 -0700 (Thu, 16 Jul 2009) | 2 lines Changed paths: - M /trunk/AUTHORS - M /trunk/Makefile.am M /trunk/Makefile.nmake - M /trunk/packaging/nsis/wireshark.nsi - M /trunk/packaging/u3/win32/makefile.nmake - A /trunk/services - -add IANA port-numbers file as a file named "services", with some minor explanations from me at the top of that file + M /trunk/config.nmake + M /trunk/epan/crc/Makefile.nmake + M /trunk/epan/crypt/Makefile.nmake + M /trunk/epan/dfilter/Makefile.nmake + M /trunk/epan/ftypes/Makefile.nmake + M /trunk/epan/wslua/Makefile.nmake + M /trunk/gtk/Makefile.nmake + M /trunk/wiretap/Makefile.nmake + M /trunk/wsutil/Makefile.nmake -add it to the distributed files, to the Win32 NSIS and U3 packages. UNIX packages will still miss this (optional) file. +Move th /MP flag setting to LOCAL_CFLAGS set in configure.nmake +for MSVC variant 2008 only. As suggested by Bill Meier. ------------------------------------------------------------------------ -r22488 | ulfl | 2007-08-12 14:46:50 -0700 (Sun, 12 Aug 2007) | 1 line +r29115 | stig | 2009-07-16 03:45:14 -0700 (Thu, 16 Jul 2009) | 3 lines Changed paths: - M /trunk/Makefile.am + M /trunk/epan/dissectors/packet-fc.c + M /trunk/wiretap/pcap-common.c + M /trunk/wiretap/wtap.c + M /trunk/wiretap/wtap.h -as noted by Stig Bj?\195?\184rlykke: Also adding "services" to pkgdata_DATA will install the services file correctly. ------------------------------------------------------------------------- -r22489 | ulfl | 2007-08-12 16:38:09 -0700 (Sun, 12 Aug 2007) | 1 line -Changed paths: - M /trunk/packaging/u3/win32/makefile.nmake +From Kahou via bug 3739: +New DLT value is added for Fibre Channel FC2. -fix a typo ------------------------------------------------------------------------ -r22490 | kukosa | 2007-08-13 04:15:39 -0700 (Mon, 13 Aug 2007) | 1 line +r29116 | morriss | 2009-07-16 05:39:50 -0700 (Thu, 16 Jul 2009) | 1 line Changed paths: - M /trunk/asn1/Makefile.am - M /trunk/asn1/nbap/Makefile - M /trunk/asn1/nbap/Makefile.nmake - A /trunk/asn1/nbap/NBAP-CommonDataTypes.asn - A /trunk/asn1/nbap/NBAP-Constants.asn - A /trunk/asn1/nbap/NBAP-Containers.asn - A /trunk/asn1/nbap/NBAP-IEs.asn - A /trunk/asn1/nbap/NBAP-PDU-Contents.asn - A /trunk/asn1/nbap/NBAP-PDU-Descriptions.asn - D /trunk/asn1/nbap/nbap.asn - M /trunk/asn1/nbap/nbap.cnf - M /trunk/asn1/nbap/packet-nbap-template.c - D /trunk/asn1/nbap/packet-nbap-template.h - M /trunk/asn1/rnsap/Makefile - M /trunk/epan/dissectors/packet-nbap.c - M /trunk/tools/asn2wrs.py + M /trunk/config.nmake -NBAP rewritten to use original ASN.1 source and updated to TS 25.433 V7.5.0 (2007-06) +/MP also works with 2008EE ------------------------------------------------------------------------ -r22491 | etxrab | 2007-08-13 09:28:13 -0700 (Mon, 13 Aug 2007) | 1 line +r29118 | gerald | 2009-07-16 10:00:58 -0700 (Thu, 16 Jul 2009) | 2 lines Changed paths: - M /trunk/epan/dissectors/packet-sip.c + M /trunk/asn1/snmp/packet-snmp-template.c + M /trunk/epan/dissectors/packet-snmp.c + M /trunk/epan/dissectors/packet-snmp.h -Add forgotten header field. ------------------------------------------------------------------------- -r22492 | etxrab | 2007-08-13 09:41:16 -0700 (Mon, 13 Aug 2007) | 6 lines -Changed paths: - M /trunk/asn1/dop/packet-dop-template.c - M /trunk/asn1/rtse/packet-rtse-template.c - M /trunk/epan/dissectors/packet-ber.c - M /trunk/epan/dissectors/packet-dop.c - M /trunk/epan/dissectors/packet-imf.c - M /trunk/epan/dissectors/packet-rtse.c +Don't crash if we happen to load a bad MIB file. -http://bugs.wireshark.org/bugzilla/show_bug.cgi?id=1739 -Fro Stig Bj?\195?\184rlykke: -1. BER: Added support for empty indef SET -2. RTSE: Added fragment length in COL_INFO -3. IMF: Use correct hf_id for extension value -4. DOP: Fix typo in COL_INFO oid name ------------------------------------------------------------------------ -r22493 | etxrab | 2007-08-13 09:44:35 -0700 (Mon, 13 Aug 2007) | 1 line +r29121 | jake | 2009-07-16 12:57:15 -0700 (Thu, 16 Jul 2009) | 11 lines Changed paths: - M /trunk/asn1/ulp/packet-ulp-template.c + M /trunk/epan/dissectors/packet-ipsec.c + +From David Dahlberg: +As for now, Wireshark supports only 96-bit (or 0-bit for NULL authentication) +integrity control values (ICVs) for IPsec ESP. While the autentication field is +of variable length, this may lead to situations where the whole packet is not +parsable. -Register by name.(Add the template file as well). +To solve this, I added generic classes (not checked) for 128, 192 and 256 bit +ICVs to the ESP dissector. I also split the HMAC-SHA-256 autentication +algorithm to HMAC-SHA-256-128 (128 bit as defined in RFC 4868) and +HMAC-SHA-256-96 (from the very first draft, nevertheless unpatched Linux and +BSDs do it this way). ------------------------------------------------------------------------ -r22494 | sfisher | 2007-08-13 13:14:42 -0700 (Mon, 13 Aug 2007) | 14 lines +r29122 | gerald | 2009-07-16 13:52:36 -0700 (Thu, 16 Jul 2009) | 3 lines Changed paths: - M /trunk/epan - M /trunk/epan/dfilter - M /trunk/plugins/mate - M /trunk/wiretap - - -Add the following files to svn:ignore - - plugins/mate/mate_parser_lex.h - epan/dtd_parse_lex.h - epan/uat_load_lex.h - epan/radius_dict_lex.h - epan/diam_dict_lex.h - epan/dtd_preparse_lex.h - epan/dfilter/scanner_lex.h - wiretap/ascend-scanner_lex.h - wiretap/k12text_lex.h + M /trunk/epan/packet.c +Zero out the packet_info struct for each packet instead of trying to +initialize everything by hand. Fixes a Valgrind warning. ------------------------------------------------------------------------ -r22495 | martinm | 2007-08-13 14:17:02 -0700 (Mon, 13 Aug 2007) | 2 lines +r29123 | gerald | 2009-07-16 14:03:39 -0700 (Thu, 16 Jul 2009) | 3 lines Changed paths: - M /trunk/Makefile.am + M /trunk/epan/dissectors/packet-rsvp.c -Add etsie2e4.xml to Makefile.am +Make sure some variables are initialized so that Valgrind quits +complaining. Use se_memdup to copy memory. ------------------------------------------------------------------------ -r22496 | etxrab | 2007-08-13 23:03:52 -0700 (Mon, 13 Aug 2007) | 1 line +r29124 | etxrab | 2009-07-16 14:09:18 -0700 (Thu, 16 Jul 2009) | 3 lines Changed paths: - A /trunk/asn1/tcap/DialoguePDUs.asn - A /trunk/asn1/tcap/TC-Notation-Extensions.asn - A /trunk/asn1/tcap/TCAP-Remote-Operations-Information-Objects.asn - A /trunk/asn1/tcap/TCAPMessages.asn - A /trunk/asn1/tcap/TCAPPackage.asn - A /trunk/asn1/tcap/UnidialoguePDUs.asn + M /trunk/epan/dissectors/packet-per.c -Add the original TCAP ASN1 files. +From Sean Yunjnz: +Problem in packet-per.c for ASN.1 PER Encoding. +https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=3733 ------------------------------------------------------------------------ -r22497 | etxrab | 2007-08-13 23:14:31 -0700 (Mon, 13 Aug 2007) | 1 line +r29125 | etxrab | 2009-07-16 14:27:56 -0700 (Thu, 16 Jul 2009) | 3 lines Changed paths: - A /trunk/asn1/tcap/ansi_tcap.cnf - A /trunk/asn1/tcap/packet-ansi_tcap-template.c - A /trunk/asn1/tcap/packet-ansi_tcap-template.h + M /trunk/plugins/wimaxasncp/packet-wimaxasncp.c -Add files for ANSI TCAP. +From Rajasekhar Reddy Gali: +packet-wimaxasncp.c file need to update with latest wimax spec. +https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=3730 ------------------------------------------------------------------------ -r22498 | etxrab | 2007-08-13 23:20:54 -0700 (Mon, 13 Aug 2007) | 1 line +r29126 | gerald | 2009-07-16 14:35:54 -0700 (Thu, 16 Jul 2009) | 3 lines Changed paths: - M /trunk/asn1/tcap/Makefile.nmake + M /trunk/epan/dissectors/packet-rsvp.c + +Use SE_COPY_ADDRESS instead of trying to attach ep_alloced data to an +se_alloced struct. -Update the makefile ------------------------------------------------------------------------ -r22499 | jake | 2007-08-14 09:37:35 -0700 (Tue, 14 Aug 2007) | 4 lines +r29127 | gerald | 2009-07-16 15:24:31 -0700 (Thu, 16 Jul 2009) | 2 lines Changed paths: - M /trunk/epan/dissectors/packet-mip6.h + M /trunk/epan/dissectors/packet-nfs.c -From Nicolas Dichtel: -Please find enclosed a patch to update BA status code for PMIPv6 -according to draft-ietf-netlmm-proxymip6-01 Section 8.5 +Initialize a variable and remove a check_col. ------------------------------------------------------------------------ -r22500 | etxrab | 2007-08-14 14:50:12 -0700 (Tue, 14 Aug 2007) | 6 lines +r29128 | gerald | 2009-07-16 15:25:06 -0700 (Thu, 16 Jul 2009) | 2 lines Changed paths: - M /trunk/epan/dissectors/packet-gtp.c + M /trunk/epan/reassemble.c -From From: Sommars, Steven E: -Minor problem in packet-gtp.c when decoding the PDP context Information -Element (7.7.29 in 29.060) The two uplink TEIDs are reversed in -packet-gtp.c, it should be control plane, followed by data. +Check for an overflow. This should hopefully fix bug 3672. -Reworked the patch. ------------------------------------------------------------------------ -r22501 | etxrab | 2007-08-14 15:05:36 -0700 (Tue, 14 Aug 2007) | 1 line +r29129 | jake | 2009-07-16 23:49:58 -0700 (Thu, 16 Jul 2009) | 3 lines Changed paths: - M /trunk/asn1/tcap/packet-tcap-template.c M /trunk/epan/dissectors/Makefile.common - M /trunk/epan/dissectors/packet-tcap.c - M /trunk/epan/dissectors/packet-tcap.h - -Preparations to split the TCAP dissector into ANSI and ITU parts. ------------------------------------------------------------------------- -r22502 | etxrab | 2007-08-14 15:10:55 -0700 (Tue, 14 Aug 2007) | 1 line -Changed paths: - A /trunk/epan/dissectors/packet-ansi_tcap.c - A /trunk/epan/dissectors/packet-ansi_tcap.h + M /trunk/epan/dissectors/packet-telnet.c + A /trunk/epan/dissectors/packet-tn3270.c + A /trunk/epan/dissectors/packet-tn3270.h -Actually adding the dissector may help :) +From Robert Hogan: +I'm working on a tn3270 dissector. +See: http://roberthogan.net/stuff/tn3270-dissector/ ------------------------------------------------------------------------ -r22503 | ulfl | 2007-08-14 16:52:51 -0700 (Tue, 14 Aug 2007) | 1 line +r29130 | etxrab | 2009-07-17 01:24:06 -0700 (Fri, 17 Jul 2009) | 3 lines Changed paths: M /trunk/epan/addr_resolv.c + M /trunk/epan/addr_resolv.h + M /trunk/epan/to_str.c -if the manuf address could not be resolved, strip off special bits (multicast, locally administered) and try again to find it +From Kovarththanan Rajaratnam: +Optimize column fill path. +https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=3701 ------------------------------------------------------------------------ -r22504 | ulfl | 2007-08-14 18:35:05 -0700 (Tue, 14 Aug 2007) | 1 line +r29131 | etxrab | 2009-07-17 06:42:46 -0700 (Fri, 17 Jul 2009) | 1 line Changed paths: - M /trunk/docbook/user-guide.xml - A /trunk/docbook/wsug_graphics/ws-expert-infos.png - M /trunk/docbook/wsug_src/WSUG_chapter_advanced.xml + M /trunk/gtk/packet_list_store.c -add a section about expert infos +make it possible to retreive the record with packet_list_get_value(). ------------------------------------------------------------------------ -r22505 | etxrab | 2007-08-14 22:47:17 -0700 (Tue, 14 Aug 2007) | 1 line +r29132 | wmeier | 2009-07-17 07:25:56 -0700 (Fri, 17 Jul 2009) | 3 lines Changed paths: - M /trunk/asn1/tcap/packet-ansi_tcap-template.c - M /trunk/epan/dissectors/packet-ansi_tcap.c + M /trunk/epan/dissectors/packet-tn3270.c -Change tcap_private to ansi_tcap_private. ------------------------------------------------------------------------- -r22506 | ulfl | 2007-08-15 00:37:23 -0700 (Wed, 15 Aug 2007) | 1 line -Changed paths: - M /trunk/docbook/wsug_src/WSUG_chapter_advanced.xml +Minor changes: Move protocol_register & etc to end; +Use find_dissector instead of create_dissector_handle. -don't use table names twice ------------------------------------------------------------------------ -r22507 | jmayer | 2007-08-15 06:21:23 -0700 (Wed, 15 Aug 2007) | 3 lines +r29133 | gerald | 2009-07-17 08:59:24 -0700 (Fri, 17 Jul 2009) | 2 lines Changed paths: - M /trunk/epan/addr_resolv.c + M /trunk/epan/to_str.c -Mask out only the bc/mc bit, not the locally assigned bit. -Update comment accordingly. +Fix an ep buffer overrun introduced in r29130. ------------------------------------------------------------------------ -r22508 | lego | 2007-08-15 12:52:44 -0700 (Wed, 15 Aug 2007) | 2 lines +r29134 | wmeier | 2009-07-17 12:41:34 -0700 (Fri, 17 Jul 2009) | 2 lines Changed paths: - A /trunk/epan/oids.c - A /trunk/epan/oids.h - -I'm at the end of the second iteration, so far this compiles OK still haven't tested it but it does not go in the Makefiles, I need this as a reference point. + M /trunk/epan/dissectors/packet-tn3270.c ------------------------------------------------------------------------- -r22509 | morriss | 2007-08-15 13:35:14 -0700 (Wed, 15 Aug 2007) | 1 line -Changed paths: - A /trunk/tools/checkAPIs.pl +From Robert Hogan: "no need to register tn3270 for 'decode-as'". -As discussed on the -dev list quite a while ago: a small tool to check Wireshark code (or at least parts of it) for "bad" things (C++ style comments and API/function calls that should not be used). I'm checking in because I almost missed some C++ style comments in a file I was contemplating checking in; this tool can help us (at least me) avoid such problems in the future. ------------------------------------------------------------------------ -r22510 | morriss | 2007-08-15 14:07:01 -0700 (Wed, 15 Aug 2007) | 1 line +r29135 | gerald | 2009-07-17 15:59:59 -0700 (Fri, 17 Jul 2009) | 2 lines Changed paths: - M /trunk/epan/dissectors/packet-sccp.c + M /trunk/gtk/airpcap_gui_utils.c + M /trunk/gtk/main_airpcap_toolbar.c -checkhf.pl found a couple bugs: hf_sccp_calling_itu_global_title_indicator and hf_sccp_ansi_isni_counter were never used (the former due to a typo, the latter due to oversight). ------------------------------------------------------------------------- -r22511 | morriss | 2007-08-15 14:37:09 -0700 (Wed, 15 Aug 2007) | 1 line -Changed paths: - M /trunk/asn1/ansi_map/packet-ansi_map-template.c - M /trunk/epan/dissectors/packet-ansi_map.c - M /trunk/epan/dissectors/packet-ansi_map.h +Set the extension channel correctly. Fixup whitespace. -Change tvb_get_string() to tvb_get_ephemeral_string(). Since we weren't freeing the returned buffer, this cleans up a memory leak. NOTE: I had to manually regenerate this dissector without the "-T" option to avoid checking in a lot of changes that I don't understand/didn't make. Why is the Makefile newer than what's in epan/dissectors/ ? ------------------------------------------------------------------------ -r22512 | stig | 2007-08-15 15:20:28 -0700 (Wed, 15 Aug 2007) | 6 lines +r29137 | stig | 2009-07-18 13:10:14 -0700 (Sat, 18 Jul 2009) | 8 lines Changed paths: - M /trunk/AUTHORS - M /trunk/epan/dissectors/packet-dmp.c - -Fixed a free -> g_free -Removed a unused hf_ entry + M /trunk/epan/dissectors/packet-xml.c + M /trunk/epan/libwireshark.def + M /trunk/epan/proto.c + M /trunk/epan/proto.h + M /trunk/epan/wspython/wspy_proto.c + M /trunk/plugins/mate/mate_runtime.c -From Ian Brumby: -- Fixed decoding of 4 character and longer SICs +From Kovarththanan Rajaratnam via bug 3719: +This patch optimizes proto_tree_prime_hfid() + friends and +plugs a memleak in the process. ------------------------------------------------------------------------- -r22513 | stig | 2007-08-15 15:24:05 -0700 (Wed, 15 Aug 2007) | 2 lines -Changed paths: - M /trunk/epan/reassemble.c - M /trunk/epan/reassemble.h - -Added fragment_start_seq_check to start a reassembly without adding any data. +From me: +Removed unused hfindex in proto_tree_new_item() +Fixed ref_count entry in struct header_field_info. ------------------------------------------------------------------------ -r22514 | stig | 2007-08-15 15:26:00 -0700 (Wed, 15 Aug 2007) | 3 lines +r29138 | gerald | 2009-07-19 08:03:36 -0700 (Sun, 19 Jul 2009) | 1 line Changed paths: - M /trunk/epan/dissectors/packet-p_mul.c - -Use fragment_start_seq_check to start defragmentation when receiving an -Address PDU without adding a empty message fragment. + M /trunk/epan/enterprise-numbers + M /trunk/manuf +[Automatic manuf and enterprise-numbers update for 2009-07-19] ------------------------------------------------------------------------ -r22515 | morriss | 2007-08-15 15:27:52 -0700 (Wed, 15 Aug 2007) | 8 lines +r29142 | sfisher | 2009-07-19 23:21:35 -0700 (Sun, 19 Jul 2009) | 8 lines Changed paths: - M /trunk/epan/dissectors/packet-bittorrent.c - M /trunk/epan/dissectors/packet-dcerpc.c - M /trunk/epan/dissectors/packet-dmp.c - M /trunk/epan/dissectors/packet-dtpt.c - M /trunk/epan/dissectors/packet-fcct.c - M /trunk/epan/dissectors/packet-fcdns.c - M /trunk/epan/dissectors/packet-fcfzs.c - M /trunk/epan/dissectors/packet-fcswils.c - M /trunk/epan/dissectors/packet-fw1.c - M /trunk/epan/dissectors/packet-http.c - M /trunk/epan/dissectors/packet-imf.c - M /trunk/epan/dissectors/packet-isup.c - M /trunk/epan/dissectors/packet-msrp.c - M /trunk/epan/dissectors/packet-mysql.c - M /trunk/epan/dissectors/packet-ndps.c - M /trunk/epan/dissectors/packet-p_mul.c - M /trunk/epan/dissectors/packet-pppoe.c - M /trunk/epan/dissectors/packet-sdp.c - -- s/ntohs/g_ntohs -- s/ntohl/g_ntohl -- s/free/g_free -- Change some tvb_get_string()+g_free()'s into tvb_get_ephemeral_string() -- Change some tvb_fake_unicode()+g_free()'s into tvb_get_ephemeral_faked_unicode() -- Change some tvb_get_string() calls that were clearly memory leaks (like - atoi(tvb_get_string(...))) into tvb_get_ephemeral_string() + M /trunk/color_filters.c + M /trunk/file.c + M /trunk/gtk/menus.c + M /trunk/gtk/new_packet_list.c + M /trunk/ui_util.h ------------------------------------------------------------------------- -r22516 | stig | 2007-08-15 15:29:58 -0700 (Wed, 15 Aug 2007) | 6 lines -Changed paths: - M /trunk/epan/dissectors/packet-smtp.c -Added support for RFC3030 (BDAT) in SMTP. -Added data fragment length to COL_INFO. -Changed some 0/1 values to boolean. +Introduce packet list coloring for the NEW_PACKET_LIST. One caveat: when +enabling/disabling the coloring of the packet list from the menus, the user +has to drag the mouse cursor over each displayed row to take away/add the +coloring. Dragging the scroll bar up or down will also take care of this as +only the displayed rows are colored. -http://bugs.wireshark.org/bugzilla/show_bug.cgi?id=1736 ------------------------------------------------------------------------ -r22517 | stig | 2007-08-15 15:34:56 -0700 (Wed, 15 Aug 2007) | 2 lines +r29143 | etxrab | 2009-07-20 02:06:47 -0700 (Mon, 20 Jul 2009) | 1 line Changed paths: - M /trunk/epan/dissectors/packet-ber.c - -Improved dumping of unexpected data when dissector for OID not implemented. + M /trunk/gtk/new_packet_list.c +Avoid a crash if no color filter exists (SCTP trace). ------------------------------------------------------------------------ -r22518 | morriss | 2007-08-15 15:41:49 -0700 (Wed, 15 Aug 2007) | 1 line +r29144 | etxrab | 2009-07-20 04:33:02 -0700 (Mon, 20 Jul 2009) | 1 line Changed paths: - M /trunk/asn1/ldap/ldap.cnf - M /trunk/epan/dissectors/packet-ldap.c + M /trunk/gtk/new_packet_list.c -Convert a couple tvb_get_string()'s into tvb_get_ephemeral_string(). In the one remaining use of tvb_get_string(), g_free the old entry if the pointer is *not* NULL. +Redraw the list when color filters are enabled/disabled. ------------------------------------------------------------------------ -r22519 | stig | 2007-08-15 16:42:29 -0700 (Wed, 15 Aug 2007) | 2 lines +r29145 | stig | 2009-07-20 04:42:28 -0700 (Mon, 20 Jul 2009) | 8 lines Changed paths: - M /trunk/asn1/cdt/Makefile - M /trunk/asn1/cdt/Makefile.nmake - M /trunk/asn1/cdt/cdt-exp.cnf - M /trunk/epan/dissectors/packet-cdt.c - M /trunk/epan/dissectors/packet-cdt.h + M /trunk/gtk/prefs_column.c -Regenerate the CDT dissector with -X and -T options. +Changed to use "Field type" instead of "Format", to be more descriptive. +Moved "Filed name" fields below "Field type", to improve the layout. +Always show the "Field name" fields, disable when field type is not custom. +Remember field name even when changing field type, so the user can change his +mind without losing the data entered. +Some small adjustments to "Add" and "Remove" buttons. +Added some tooltips. ------------------------------------------------------------------------ -r22520 | sfisher | 2007-08-15 20:36:38 -0700 (Wed, 15 Aug 2007) | 4 lines +r29146 | stig | 2009-07-20 05:40:55 -0700 (Mon, 20 Jul 2009) | 5 lines Changed paths: - M /trunk/gtk/Makefile.am - M /trunk/gtk/Makefile.common - M /trunk/gtk/follow_dlg.c - A /trunk/gtk/follow_stream.c - A /trunk/gtk/follow_stream.h - M /trunk/gtk/ssl-dlg.c - - -Initial work on merging common code between follow TCP & SSL stream features + M /trunk/epan/to_str.c +From Jakub Zawadzki via bug 3701: +Fix regressions in r29130 and r29133 +In r29130 formating for DSECS was changed. (old: %01d now: %02d) +In r29133 adding sign was removed (old: buf[0] = '-' now: buf[0] = '\0') ------------------------------------------------------------------------ -r22521 | ulfl | 2007-08-15 21:25:54 -0700 (Wed, 15 Aug 2007) | 1 line +r29147 | etxrab | 2009-07-20 09:09:50 -0700 (Mon, 20 Jul 2009) | 2 lines Changed paths: - M /trunk/epan/dissectors/packet-ip.c + M /trunk/file.c + M /trunk/gtk/new_packet_list.c + M /trunk/ui_util.h -add an expert info, if ip.ttl < 5 +Implement new_packet_list_find_row_from_data() +Goto frame should work now. ------------------------------------------------------------------------ -r22522 | ulfl | 2007-08-15 21:32:48 -0700 (Wed, 15 Aug 2007) | 1 line +r29149 | etxrab | 2009-07-20 23:02:12 -0700 (Mon, 20 Jul 2009) | 3 lines Changed paths: - M /trunk/docbook/wsug_src/WSUG_chapter_advanced.xml + M /trunk/epan/dissectors/packet-e212.c -some more editing of the expert infos - still incomplete +From Gerasimos Dimitriadis: +Enhancement to E.212 MCC/MNC decoding. +https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=3759 ------------------------------------------------------------------------ -r22523 | ulfl | 2007-08-15 21:54:30 -0700 (Wed, 15 Aug 2007) | 1 line +r29150 | etxrab | 2009-07-20 23:08:45 -0700 (Mon, 20 Jul 2009) | 3 lines Changed paths: - M /trunk/gtk/follow_stream.c + M /trunk/plugins/profinet/packet-dcerpc-pn-io.c -fix build problems under Win32 +From Benjamin Meyer: +Profinet dissector does not decode all defined error codes. +https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=3753 ------------------------------------------------------------------------ -r22524 | lego | 2007-08-15 23:48:51 -0700 (Wed, 15 Aug 2007) | 5 lines +r29151 | etxrab | 2009-07-20 23:20:47 -0700 (Mon, 20 Jul 2009) | 14 lines Changed paths: - M /trunk/epan/oids.c - M /trunk/epan/oids.h + M /trunk/epan/dissectors/packet-bacapp.c + M /trunk/epan/dissectors/packet-bacapp.h -- It's just-a-bad-idea(tm) to redefine anything from a foreign library, Don't. -- Allow to look for value-types by name. +From Herbert Lischka: +Added some new features to BACnet dissection: +- ListOfObjectPropertyReferences in scheduler +- RestartReason +- Properties for loop-object +- LogDeviceObjectProperty in trend-log object +- log-buffer entries in trend-log object -[still largelly untested] +- reassemby of fragmented messages +- fallback changed if iconv-library is not here ------------------------------------------------------------------------- -r22525 | etxrab | 2007-08-16 00:00:50 -0700 (Thu, 16 Aug 2007) | 1 line -Changed paths: - M /trunk/asn1/ansi_map/Makefile - M /trunk/asn1/ansi_map/ansi_map.cnf - M /trunk/asn1/camel/Makefile +Me: Moved includes from .h to .c as thats how we normaly do it. -Fix makefiles and a comment. +https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=3736 ------------------------------------------------------------------------ -r22526 | ulfl | 2007-08-16 08:53:35 -0700 (Thu, 16 Aug 2007) | 1 line +r29152 | guy | 2009-07-21 00:28:47 -0700 (Tue, 21 Jul 2009) | 7 lines Changed paths: - M /trunk/docbook/user-guide.xml - A /trunk/docbook/wsug_graphics/ws-expert-colored-tree.png - A /trunk/docbook/wsug_graphics/ws-expert-column.png - M /trunk/docbook/wsug_src/WSUG_chapter_advanced.xml + M /trunk/epan/dissectors/packet-bacapp.c -finish the expert info section ------------------------------------------------------------------------- -r22527 | stig | 2007-08-16 10:59:27 -0700 (Thu, 16 Aug 2007) | 4 lines -Changed paths: - M /trunk/asn1/ftam/packet-ftam-template.c - M /trunk/epan/dissectors/packet-ftam.c +Don't use tvb_length_remaining() - that just reports how much captured +data is available, not how big the packet really is. -Added handling of ISO FTAM unstructured binary, as this OID is used in -X.420 FileTransferBodyPart for generic binary bodyparts. -Also added handling of ISO FTAM unstructured text. +Clean up white space. ------------------------------------------------------------------------- -r22528 | etxrab | 2007-08-16 12:59:55 -0700 (Thu, 16 Aug 2007) | 1 line -Changed paths: - M /trunk/asn1/tcap/ansi_tcap.cnf - M /trunk/asn1/tcap/packet-ansi_tcap-template.c - M /trunk/asn1/tcap/packet-ansi_tcap-template.h - M /trunk/epan/dissectors/packet-ansi_tcap.c - M /trunk/epan/dissectors/packet-ansi_tcap.h +Get rid of an unused parameter and two unused variables. -Collect context data. ------------------------------------------------------------------------ -r22529 | stig | 2007-08-16 13:54:43 -0700 (Thu, 16 Aug 2007) | 4 lines +r29153 | guy | 2009-07-21 00:44:04 -0700 (Tue, 21 Jul 2009) | 2 lines Changed paths: - M /trunk/epan/dissectors/packet-p_mul.c + M /trunk/epan/dissectors/packet-bacapp.c -When calculating checksum for p_mul the checksum field itself is set to zero. -Ensure this field is inside the buffer before altering it, so we don't -write outside the allocated buffer. +Fix typo. ------------------------------------------------------------------------ -r22530 | ulfl | 2007-08-16 15:03:10 -0700 (Thu, 16 Aug 2007) | 5 lines +r29154 | martinm | 2009-07-21 00:59:16 -0700 (Tue, 21 Jul 2009) | 10 lines Changed paths: - M /trunk/epan/Makefile.common - A /trunk/epan/dissector_filters.c - A /trunk/epan/dissector_filters.h - M /trunk/epan/libwireshark.def - M /trunk/gtk/gui_stat_menu.h - M /trunk/gtk/menu.c - M /trunk/gtk/tcp_graph.c - M /trunk/plugins/profinet/packet-dcerpc-pn-io.c - M /trunk/stat_menu.h + M /trunk/epan/dissectors/packet-bacapp.c -experimental feature: dissector filters +Stop using the C++ 'true' and 'false'. -add the possibility, that a dissector writer can provide (usually non-trivial) display filters specific for the protocol in question (with an example in packet-dcerpc-pn-io.c), that will appear in the GUI +I still get a compilation error... +packet-bacapp.c: In function `dissect_bacapp': +packet-bacapp.c:6350: warning: 'bacapp_invoke_id' might be used uninitialized in this function ------------------------------------------------------------------------- -r22531 | ulfl | 2007-08-16 15:45:36 -0700 (Thu, 16 Aug 2007) | 1 line -Changed paths: - M /trunk/plugins/profinet/packet-dcerpc-pn-io.c +... although I've followed the paths (including the setting of 'segment'), and it looks bogus to me. -fix return types, hopefully this will make the osx buildbot happy ------------------------------------------------------------------------- -r22532 | ulfl | 2007-08-16 16:35:28 -0700 (Thu, 16 Aug 2007) | 1 line -Changed paths: - M /trunk/gtk/menu.c -mark some parameters as unused ------------------------------------------------------------------------ -r22533 | sake | 2007-08-17 01:03:32 -0700 (Fri, 17 Aug 2007) | 26 lines +r29155 | stig | 2009-07-21 01:07:40 -0700 (Tue, 21 Jul 2009) | 2 lines Changed paths: - M /trunk/wiretap/Makefile.common - M /trunk/wiretap/file_access.c - A /trunk/wiretap/netscreen.c - A /trunk/wiretap/netscreen.h - M /trunk/wiretap/wtap.h - -(http://bugs.wireshark.org/bugzilla/show_bug.cgi?id=1717) - -This patch adds support for the Juniper NetScreen snoop output format. -It takes a text-dump op the captured packets and parses the headers -and hex-data. Since the snoop files on a Junpiper NetScreen can be saved -to a tftp-server, this patch makes it quite easy to use the snoop -function of the Juniper NetScreen firewalls. - -/* XXX TODO: - * - * o Create a wiki-page with instruction on how to make tracefiles - * on Juniper NetScreen devices. Also put a few examples up - * on the wiki (Done: wiki-page added 2007-08-03) - * - * o Use the interface names to properly detect the encapsulation - * type (ie adsl packets are now not properly dissected) - * (Done: adsl packets are now correctly seen as PPP, 2007-08-03) - * - * o Pass the interface names and the traffic direction to either - * the frame-structure, a pseudo-header or use PPI. This needs - * to be discussed on the dev-list first - * (Posted a message to wireshark-dev abou this 2007-08-03) - * - */ - - ------------------------------------------------------------------------- -r22534 | gal | 2007-08-17 11:52:40 -0700 (Fri, 17 Aug 2007) | 5 lines -Changed paths: - M /trunk/asn1/pkcs12/Makefile - M /trunk/asn1/pkcs12/Makefile.nmake - M /trunk/asn1/pkcs12/packet-pkcs12-template.c - M /trunk/asn1/pkcs12/packet-pkcs12-template.h - M /trunk/asn1/pkcs12/pkcs12.cnf - M /trunk/epan/dissectors/packet-pkcs12.c - M /trunk/epan/dissectors/packet-pkcs12.h - -Support for decrypting of PKCS#12 bag contents. -Supports RC2, RC4 and 3DES with SHA1 Password-based Encryption using libgcrypt functions. -Password is provided as a preference, as is trying to decode with a empty/NULL password. + M /trunk/epan/dissectors/packet-bacapp.c +Initialize bacapp_invoke_id to avoid a compiler warning. ------------------------------------------------------------------------ -r22535 | gal | 2007-08-17 12:14:39 -0700 (Fri, 17 Aug 2007) | 4 lines +r29156 | etxrab | 2009-07-21 01:35:24 -0700 (Tue, 21 Jul 2009) | 1 line Changed paths: - M /trunk/asn1/cms/cms-exp.cnf - M /trunk/asn1/cms/cms.cnf - M /trunk/asn1/cms/packet-cms-template.c - M /trunk/epan/dissectors/packet-cms.c - M /trunk/epan/dissectors/packet-cms.h - -Support for the decryption of EncryptedData which is used by PKCS12 -Uses the PBE routines from PKCS12. - + M /trunk/epan/dissectors/packet-bacapp.c + M /trunk/epan/dissectors/packet-bacapp.h +size_t -> int to make the Win64 build bot happy. ------------------------------------------------------------------------ -r22536 | gal | 2007-08-17 12:16:51 -0700 (Fri, 17 Aug 2007) | 3 lines +r29157 | guy | 2009-07-21 01:53:39 -0700 (Tue, 21 Jul 2009) | 3 lines Changed paths: - M /trunk/asn1/x509sat/x509sat-exp.cnf - M /trunk/asn1/x509sat/x509sat.cnf - M /trunk/epan/dissectors/packet-x509sat.c - M /trunk/epan/dissectors/packet-x509sat.h - -Faked BMP string display. + M /trunk/epan/dissectors/packet-bacapp.c + M /trunk/epan/dissectors/packet-bacapp.h +GLib documentation says the 3rd and 5th arguments to g_iconv are "gsize +*"s. ------------------------------------------------------------------------ -r22537 | gal | 2007-08-17 12:23:15 -0700 (Fri, 17 Aug 2007) | 3 lines +r29158 | guy | 2009-07-21 02:05:16 -0700 (Tue, 21 Jul 2009) | 2 lines Changed paths: - M /trunk/asn1/pkcs12/packet-pkcs12-template.c - M /trunk/epan/dissectors/packet-pkcs12.c - -Fix for OSX gremlin in PKCS12 template. + M /trunk/epan/dissectors/packet-bacapp.c +More gsizery. ------------------------------------------------------------------------ -r22538 | gerald | 2007-08-17 12:34:14 -0700 (Fri, 17 Aug 2007) | 7 lines +r29159 | stig | 2009-07-21 09:48:16 -0700 (Tue, 21 Jul 2009) | 4 lines Changed paths: - M /trunk/airpcap_loader.c - M /trunk/airpcap_loader.h - M /trunk/epan/Makefile.common M /trunk/epan/column-utils.c - M /trunk/epan/column.c - M /trunk/epan/column_info.h - M /trunk/epan/dissectors/packet-ppi.c - M /trunk/epan/dissectors/packet-prism.c - M /trunk/epan/dissectors/packet-radiotap.c - M /trunk/epan/dissectors/packet-wlancap.c - A /trunk/epan/frequency-utils.c - A /trunk/epan/frequency-utils.h - M /trunk/epan/libwireshark.def - M /trunk/gtk/airpcap_dlg.c - M /trunk/gtk/airpcap_gui_utils.c + M /trunk/epan/frame_data.h + M /trunk/file.c M /trunk/gtk/main.c -Instead of converting between 802.11 frequencies and channels umpteen -different ways, add a set of common conversion routines. Add a -"Frequency/Channel" column and fill it in where we can. Fix RSSI column -printing in PPI. - -Fix up whitespace along the way. +From didier gautheron via bug 3762: +This patch removes col_expr in frame_data structure, +it can be recomputed when needed. ------------------------------------------------------------------------ -r22539 | gal | 2007-08-17 12:40:40 -0700 (Fri, 17 Aug 2007) | 3 lines +r29160 | stig | 2009-07-21 15:09:31 -0700 (Tue, 21 Jul 2009) | 5 lines Changed paths: - M /trunk/asn1/pkcs12/packet-pkcs12-template.c - M /trunk/epan/dissectors/packet-pkcs12.c + M /trunk/epan/dissectors/packet-rtcp.c -Further tidy up for preference. +Cummulative number of packets lost is a signed 24 bits value. +This fixes bug 3763. +Cleanup some proto_tree_add_uint() -> proto_tree_add_item(). ------------------------------------------------------------------------ -r22540 | guy | 2007-08-17 13:04:31 -0700 (Fri, 17 Aug 2007) | 3 lines +r29161 | stig | 2009-07-21 15:23:34 -0700 (Tue, 21 Jul 2009) | 2 lines Changed paths: - M /trunk/wiretap/netxray.c + M /trunk/epan/dissectors/packet-bacapp.c + M /trunk/epan/dissectors/packet-bacapp.h -At least some LAPB Windows Sniffer captures have 4 bytes of extra stuff -at the ends of packets. +Another try to fix the compiler warnings on win64. ------------------------------------------------------------------------ -r22541 | ashokn | 2007-08-17 14:21:18 -0700 (Fri, 17 Aug 2007) | 4 lines +r29162 | sfisher | 2009-07-21 22:02:24 -0700 (Tue, 21 Jul 2009) | 4 lines Changed paths: - M /trunk/AUTHORS - M /trunk/epan/dissectors/Makefile.common - M /trunk/epan/dissectors/packet-ethertype.c - A /trunk/epan/dissectors/packet-ieee8021ah.c - A /trunk/epan/dissectors/packet-ieee8021ah.h - M /trunk/epan/etypes.h + M /trunk/epan/column-utils.c -Added support for 802.1ad and 802.1ah ethernet frames +Change some g_malloc() calls to g_new() to make the code easier to read. ------------------------------------------------------------------------ -r22542 | morriss | 2007-08-17 14:21:50 -0700 (Fri, 17 Aug 2007) | 1 line +r29163 | etxrab | 2009-07-21 23:00:53 -0700 (Tue, 21 Jul 2009) | 1 line Changed paths: - M /trunk/epan/dissectors/packet-dcp-etsi.c - M /trunk/epan/dissectors/packet-sdp.c + M /trunk/file.c -Replace a couple more calls to tvb_get_string() with tvb_get_ephemeral_string(). 2 of the 3 replacements fix memory leaks. +Minor indentation fixes. ------------------------------------------------------------------------ -r22543 | etxrab | 2007-08-17 14:31:22 -0700 (Fri, 17 Aug 2007) | 1 line +r29164 | etxrab | 2009-07-22 01:09:22 -0700 (Wed, 22 Jul 2009) | 5 lines Changed paths: - M /trunk/epan/dissectors/Makefile.common - A /trunk/epan/dissectors/packet-dpnss.c - M /trunk/epan/dissectors/packet-dua.c + M /trunk/epan/frame_data.c + M /trunk/epan/frame_data.h + M /trunk/gtk/main_packet_list.c + M /trunk/gtk/packet_list_store.c -Add a rudimentarry DPNSS dissector - work in progress. +From Jakub Zawadzki: +This patch is cut&paste code from gtk/main_packet_list.c:packet_list_compare() +to new function frame_data_compare() ++ it make use of new function inside packet_list_compare() and +packet_list_compare_records() ------------------------------------------------------------------------ -r22544 | etxrab | 2007-08-17 16:23:36 -0700 (Fri, 17 Aug 2007) | 1 line +r29165 | etxrab | 2009-07-22 01:11:50 -0700 (Wed, 22 Jul 2009) | 6 lines Changed paths: - M /trunk/asn1/tcap/ansi_tcap.cnf - M /trunk/asn1/tcap/packet-ansi_tcap-template.c - M /trunk/asn1/tcap/packet-ansi_tcap-template.h - M /trunk/epan/dissectors/packet-ansi_tcap.c - M /trunk/epan/dissectors/packet-ansi_tcap.h + M /trunk/epan/libwireshark.def -Add code for finding sub dissectors. +Take 2: +From Jakub Zawadzki: +This patch is cut&paste code from gtk/main_packet_list.c:packet_list_compare() +to new function frame_data_compare() ++ it make use of new function inside packet_list_compare() and +packet_list_compare_records() ------------------------------------------------------------------------ -r22545 | gerald | 2007-08-17 16:53:41 -0700 (Fri, 17 Aug 2007) | 2 lines +r29166 | etxrab | 2009-07-22 01:54:38 -0700 (Wed, 22 Jul 2009) | 3 lines Changed paths: - M /trunk/epan/frequency-utils.c - -Fix a couple of signedness mismatches. + M /trunk/gtk/new_packet_list.c +From Jakub Zawadzki: +This patch makes row coloring alike GtkCList version + (remove white space between cells/columns) ------------------------------------------------------------------------ -r22546 | lego | 2007-08-17 17:14:52 -0700 (Fri, 17 Aug 2007) | 3 lines +r29167 | martinm | 2009-07-22 06:21:15 -0700 (Wed, 22 Jul 2009) | 2 lines Changed paths: - M /trunk/epan/proto.c - -accept 64bit integers where 8 <= len <= 1 + M /trunk/epan/dissectors/packet-mac-lte.c +Improve/expand checks on reserved bit values. ------------------------------------------------------------------------ -r22547 | guy | 2007-08-17 18:46:14 -0700 (Fri, 17 Aug 2007) | 5 lines +r29168 | etxrab | 2009-07-22 08:23:08 -0700 (Wed, 22 Jul 2009) | 4 lines Changed paths: - M /trunk/gtk/rtp_player.c - -Use #defines, rather than raw numbers, for RTP payload types. + M /trunk/gtk/new_packet_list.c + M /trunk/gtk/packet_list_store.c -Note that we should return an error for payload types we don't support, -so the user knows we can't handle the audio. +From Jakub Zawadzki: +This patch fix return value in new_packet_list_find_row_from_data when !select +From Me: Change back the cell coloring and remove the horizontal-separator making the colorinjg look the same as in the old packet list. ------------------------------------------------------------------------ -r22548 | wmeier | 2007-08-17 20:19:44 -0700 (Fri, 17 Aug 2007) | 2 lines +r29169 | etxrab | 2009-07-22 10:35:28 -0700 (Wed, 22 Jul 2009) | 2 lines Changed paths: - M /trunk/epan/dissectors/packet-dpnss.c - -Fix some gcc warnings so buildbots can proceed. + M /trunk/file.c + M /trunk/gtk/new_packet_list.c + M /trunk/ui_util.h +From kovarththanan Rajaratnam: +Pass column_info as a pointer (new packet list). ------------------------------------------------------------------------ -r22549 | wmeier | 2007-08-17 21:28:40 -0700 (Fri, 17 Aug 2007) | 2 lines +r29170 | etxrab | 2009-07-22 14:33:47 -0700 (Wed, 22 Jul 2009) | 1 line Changed paths: - M /trunk/gtk/rtp_player.c - -Add #include needed to get defs for PT_PCMU & etc + M /trunk/epan/dissectors/packet-eth.c + M /trunk/epan/dissectors/packet-frame.c + M /trunk/epan/dissectors/packet-ip.c + M /trunk/epan/dissectors/packet-udp.c +Get rid of check_col() in some of the more frequently used dissectors. ------------------------------------------------------------------------ -r22550 | wmeier | 2007-08-18 08:48:10 -0700 (Sat, 18 Aug 2007) | 2 lines +r29171 | gerald | 2009-07-22 16:59:15 -0700 (Wed, 22 Jul 2009) | 3 lines Changed paths: - M /trunk/docbook/Makefile + M /trunk/capinfos.c + M /trunk/editcap.c + M /trunk/make-version.pl + M /trunk/mergecap.c + M /trunk/text2pcap.c + M /trunk/version_info.c -Bug #1446 work-around from Toralf F?\195?\182rster +Use "svn info" to fetch the version by default. Fetch the repository path as +well. Add the repository path to the version strings. ------------------------------------------------------------------------ -r22551 | gal | 2007-08-18 10:39:44 -0700 (Sat, 18 Aug 2007) | 3 lines +r29172 | etxrab | 2009-07-22 22:32:31 -0700 (Wed, 22 Jul 2009) | 3 lines Changed paths: - M /trunk/epan/dissectors/packet-ber.c - -Handle unknown Universal and BMP strings. - + M /trunk/asn1/rrc/rrc.cnf + M /trunk/epan/dissectors/packet-rrc.c + M /trunk/epan/dissectors/packet-rrc.h +From Neil Piercy: +Another missing RRC dissector chaining link. +https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=3769 ------------------------------------------------------------------------ -r22552 | stig | 2007-08-18 15:56:44 -0700 (Sat, 18 Aug 2007) | 6 lines +r29173 | etxrab | 2009-07-22 22:38:34 -0700 (Wed, 22 Jul 2009) | 3 lines Changed paths: - M /trunk/epan/dissectors/packet-x25.c - -Check for COTP if Call Request has not been captured. -Fixed an offset for diagnostic in COL_INFO. - -This file should really be rewritten to use more proto_tree_add_item's -instead of proto_tree_add_text's. + M /trunk/epan/dissectors/packet-bacapp.c + M /trunk/epan/dissectors/packet-bacapp.h +From Steve Karg: +BACnet Action property not decoded correctly. +https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=3766 ------------------------------------------------------------------------ -r22553 | etxrab | 2007-08-19 13:26:08 -0700 (Sun, 19 Aug 2007) | 1 line +r29174 | etxrab | 2009-07-22 22:48:39 -0700 (Wed, 22 Jul 2009) | 3 lines Changed paths: - M /trunk/epan/dissectors/packet-dpnss.c + M /trunk/epan/column-utils.c + M /trunk/epan/column.c + M /trunk/epan/column_info.h + M /trunk/epan/proto.c + M /trunk/tshark.c -Disscet CC messages. +From Kovarththanan Rajaratnam: +Precompile custom columns filters. +https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=3767 ------------------------------------------------------------------------ -r22554 | etxrab | 2007-08-19 13:41:16 -0700 (Sun, 19 Aug 2007) | 1 line +r29175 | etxrab | 2009-07-23 00:57:32 -0700 (Thu, 23 Jul 2009) | 1 line Changed paths: - M /trunk/epan/dissectors/packet-dpnss.c + M /trunk/epan/column-utils.c + M /trunk/epan/column_info.h -Fix copy-paste errors. +Try to get the #includes right. ------------------------------------------------------------------------ -r22555 | stig | 2007-08-19 14:56:11 -0700 (Sun, 19 Aug 2007) | 2 lines +r29176 | etxrab | 2009-07-23 01:53:13 -0700 (Thu, 23 Jul 2009) | 1 line Changed paths: - M /trunk/epan/dissectors/packet-dpnss.c - -Mark pinfo as unused to make buildbot happy again. + M /trunk/epan/column-utils.c + M /trunk/epan/column_info.h + M /trunk/epan/dfilter/dfilter.h +Try to get the #includes right - take 2. ------------------------------------------------------------------------ -r22556 | lego | 2007-08-19 16:00:47 -0700 (Sun, 19 Aug 2007) | 20 lines +r29177 | etxrab | 2009-07-23 01:56:09 -0700 (Thu, 23 Jul 2009) | 5 lines Changed paths: - M /trunk/asn1/snmp/packet-snmp-template.c - M /trunk/asn1/snmp/snmp.asn - M /trunk/asn1/snmp/snmp.cnf - M /trunk/epan/oids.c - M /trunk/epan/oids.h - -Filtering on snmp variables starts to work so I put it there in case anyone wants to start playing with it. I'll leave the generated dissector in place and the rest off the Makefiles so that others are not bothered by this. - -TODO: -- Global - - add libsmi to autoconf (I modified CFLAGS and LDADDs in the makefile.ams appending my own values, that's good only for me) - - have other users of oid_resolv.h get to use the new functions in oids.h - - add a menu item or preference setting for the smi_modules UAT ( the smi_modules file has one dquoted string per line with the name of each module to be loaded) -- SNMP - - put complete information in the labels of the VarBind Items - - add oids to COL_INFO - - negative testing (Well, testing in general) -- OIDS - - implement "ALL" modules - - some functions are not yet tested or implemented - -I'll put a TO-DO list on the wiki for people (incl. me) to add more items - - - + M /trunk/epan/dissectors/packet-radiotap.c +- Ambiguous value for radiotap datarate. +The value given to proto_tree_add_uint_format() was not divided by 2. +https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=3747 +- remove check_col() +- Indentation changes. ------------------------------------------------------------------------ -r22557 | sahlberg | 2007-08-20 01:09:52 -0700 (Mon, 20 Aug 2007) | 5 lines +r29178 | guy | 2009-07-23 02:32:58 -0700 (Thu, 23 Jul 2009) | 5 lines Changed paths: - M /trunk/epan/dissectors/packet-smb.c + M /trunk/epan/dissectors/packet-radiotap.c -we need to track the fid in the rwdata structure so that reassembly of -connectionoriented dcerpc over smb pipes will be able to find the fid -used for reassembly +Don't divide the data rate by 2 - that loses information (yes, I have a +trace with at least one packet transmitted at 5.5 Mb/s). +Clean up indentation. ------------------------------------------------------------------------ -r22558 | jake | 2007-08-20 13:50:29 -0700 (Mon, 20 Aug 2007) | 2 lines +r29179 | martinm | 2009-07-23 04:19:05 -0700 (Thu, 23 Jul 2009) | 2 lines Changed paths: - M /trunk/Makefile.am - M /trunk/Makefile.nmake - M /trunk/configure.in - M /trunk/plugins/Makefile.am - M /trunk/plugins/Makefile.nmake - A /trunk/plugins/unistim - A /trunk/plugins/unistim/AUTHORS - A /trunk/plugins/unistim/COPYING - A /trunk/plugins/unistim/ChangeLog - A /trunk/plugins/unistim/Makefile.am - A /trunk/plugins/unistim/Makefile.common - A /trunk/plugins/unistim/Makefile.nmake - A /trunk/plugins/unistim/TODO - A /trunk/plugins/unistim/audio.h - A /trunk/plugins/unistim/basic.h - A /trunk/plugins/unistim/broadcast.h - A /trunk/plugins/unistim/defines.h - A /trunk/plugins/unistim/display.h - A /trunk/plugins/unistim/header_field.h - A /trunk/plugins/unistim/key.h - A /trunk/plugins/unistim/moduleinfo.h - A /trunk/plugins/unistim/moduleinfo.nmake - A /trunk/plugins/unistim/network.h - A /trunk/plugins/unistim/packet-unistim.c - A /trunk/plugins/unistim/packet-unistim.h - A /trunk/plugins/unistim/plugin.rc.in - -Add the UNISTIM plugin to Wireshark. - ------------------------------------------------------------------------- -r22559 | etxrab | 2007-08-20 13:55:06 -0700 (Mon, 20 Aug 2007) | 9 lines -Changed paths: - M /trunk/epan/dissectors/packet-gprs-llc.c - M /trunk/epan/dissectors/packet-gsm_a.c - -From Cyrille Colin: -gsm_a : -http://bugs.wireshark.org/bugzilla/show_bug.cgi?id=1754 -SMS CP (gsm_a_dtap), RP (gsm_a_rp) and T-PDU (gsm_sms) protocol stacks are -decoded in Wireshark when called by BSSAP or RANAP. -Same protocol stack can be called by GPRS-LLC (sapi 7). Simple modification -needed in packet-gsm_a.c to add dtap dissector to llcgprs.sapi 7. + M /trunk/epan/column_info.h + M /trunk/epan/dfilter/dfilter.h -Me a comment in gprs-llc. ------------------------------------------------------------------------- -r22560 | etxrab | 2007-08-20 13:58:02 -0700 (Mon, 20 Aug 2007) | 1 line -Changed paths: - M /trunk/epan/dissectors/packet-dpnss.c +From Kovarththanan Rajaratnam: avoid circular dependency. -Dissect End-to-End and Link-by-Link messages. ------------------------------------------------------------------------ -r22561 | jake | 2007-08-20 14:48:25 -0700 (Mon, 20 Aug 2007) | 2 lines +r29180 | wmeier | 2009-07-23 10:46:09 -0700 (Thu, 23 Jul 2009) | 3 lines Changed paths: - M /trunk/epan/dissectors/packet-dpnss.c - -Fix the build. + M /trunk/epan/dissectors/packet-2dparityfec.c + M /trunk/epan/dissectors/packet-bjnp.c + M /trunk/epan/dissectors/packet-dnp.c + M /trunk/epan/dissectors/packet-ieee80211.c + M /trunk/epan/dissectors/packet-memcache.c + M /trunk/epan/dissectors/packet-nat-pmp.c + M /trunk/epan/dissectors/packet-p_mul.c + M /trunk/epan/dissectors/packet-packetlogger.c + M /trunk/epan/dissectors/packet-ppi.c ------------------------------------------------------------------------- -r22562 | jake | 2007-08-21 00:23:34 -0700 (Tue, 21 Aug 2007) | 5 lines -Changed paths: - M /trunk/epan/dissectors/packet-rtcp.c - M /trunk/epan/dissectors/packet-rtcp.h - M /trunk/epan/dissectors/packet-rtp.c - M /trunk/epan/dissectors/packet-rtp.h +Set editor modelines to be consistent between emacs and vi/ex; +Indentation and whitespace cleanup; -From Neil Piercy: -This patch set provides a an API for out of band signalling protocols to -register flows as SRTP/SRTCP using extended versions of the existing -rt(c)p_add_address functions. At present the encrypted portions of the payloads -are simply skipped, and the auth tags etc added as fields. ------------------------------------------------------------------------ -r22563 | guy | 2007-08-21 10:49:54 -0700 (Tue, 21 Aug 2007) | 2 lines +r29181 | guy | 2009-07-23 11:36:25 -0700 (Thu, 23 Jul 2009) | 2 lines Changed paths: - M /trunk/packaging/nsis/Makefile.nmake - M /trunk/packaging/nsis/wireshark.nsi + M /trunk/epan/dissectors/packet-dnp.c -Update the NSIS files to add the UNISTIM plugin. +Saved by removing the bell. ------------------------------------------------------------------------ -r22564 | guy | 2007-08-21 10:59:08 -0700 (Tue, 21 Aug 2007) | 2 lines +r29182 | etxrab | 2009-07-23 13:36:16 -0700 (Thu, 23 Jul 2009) | 3 lines Changed paths: - M /trunk/doc/README.plugins - -Add more information on adding a plugin to the NSIS installer. + M /trunk/epan/dissectors/packet-gsm_a_common.c +From Gerasimos Dimitriadis: +Minor enhancement to LAI decoding. +https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=3770 ------------------------------------------------------------------------ -r22565 | guy | 2007-08-21 11:04:09 -0700 (Tue, 21 Aug 2007) | 3 lines +r29183 | wmeier | 2009-07-23 13:52:54 -0700 (Thu, 23 Jul 2009) | 2 lines Changed paths: - M /trunk/packaging/u3/win32/makefile.nmake + M /trunk/capture_wpcap_packet.c -Add the UNISTIM plugin, and put the plugins in alphabetical order (to -simplify checking whether we have the full list). +Fix emacs editor modeline to be a 'safe" value. ------------------------------------------------------------------------ -r22566 | guy | 2007-08-21 11:09:33 -0700 (Tue, 21 Aug 2007) | 3 lines +r29184 | wmeier | 2009-07-23 13:53:44 -0700 (Thu, 23 Jul 2009) | 2 lines Changed paths: - M /trunk/doc/README.plugins + M /trunk/epan/crypt/airpdcap.c -Give the full pathname of the wireshark.nsi file, and add information on -what to do for the U3 win32/makefile.nmake file. +Fix some whitespace .... ------------------------------------------------------------------------ -r22567 | stig | 2007-08-21 11:50:37 -0700 (Tue, 21 Aug 2007) | 2 lines +r29185 | wmeier | 2009-07-23 14:25:02 -0700 (Thu, 23 Jul 2009) | 2 lines Changed paths: - M /trunk/plugins/unistim - -Add default svn:ignore files to unistim plugin. + M /trunk/epan/dissectors/packet-atalk.c ------------------------------------------------------------------------- -r22568 | morriss | 2007-08-21 13:24:17 -0700 (Tue, 21 Aug 2007) | 1 line -Changed paths: - M /trunk/epan/dissectors/packet-smpp.c +Use consistent indentation ... -When saving off a temporary copy of an address, use SET_ADDRESS instead of COPY_ADDRESS so as to avoid a memory leak (or adding g_free() calls to fix said memory leak). ------------------------------------------------------------------------ -r22569 | richardv | 2007-08-21 13:32:22 -0700 (Tue, 21 Aug 2007) | 2 lines +r29186 | etxrab | 2009-07-24 01:10:33 -0700 (Fri, 24 Jul 2009) | 1 line Changed paths: - M /trunk/epan/dissectors/packet-rtcp.c - -fix a signedness-in-comparison warning + M /trunk/file.c + M /trunk/gtk/new_packet_list.c + M /trunk/ui_util.h +When using the new packet list select the first packet when the file read is complete. This should take care of the crash when closing WS. ------------------------------------------------------------------------ -r22570 | richardv | 2007-08-21 13:57:52 -0700 (Tue, 21 Aug 2007) | 13 lines +r29187 | etxrab | 2009-07-24 06:50:57 -0700 (Fri, 24 Jul 2009) | 1 line Changed paths: - M /trunk/epan/req_resp_hdrs.c - -From Mike Duigou <wireshark@duigou.org> (bug 1698): - -Enclosed is a patch with fixes problems with the desegmentation of chunked HTTP -message bodies. - -... - -Changing the value of pinfo->desegment_len to DESEGMENT_ONE_MORE_SEGMENT rather -than the current 1 or 2 seems to make everything work. (I'm kind of confused as -to why the headers resassembly code already used DESEGMENT_ONE_MORE_SEGMENT and -the body reassembly code did not). - + M /trunk/cfile.h + M /trunk/file.c +Use g_slice if glib >=2.10 ------------------------------------------------------------------------ -r22571 | morriss | 2007-08-21 14:03:59 -0700 (Tue, 21 Aug 2007) | 1 line +r29188 | etxrab | 2009-07-24 14:25:21 -0700 (Fri, 24 Jul 2009) | 3 lines Changed paths: - M /trunk/epan/dissectors/packet-netflow.c + M /trunk/gtk/new_packet_list.c + M /trunk/gtk/packet_list_store.c -Use SET_ADDRESS (instead of COPY_ADDRESS) for an address that has "ephemeral" scope. Use SE_COPY_ADDRESS when the address is copied to the template cache (with "seasonal" scope.) +From Kovarththanan Rajaratnam: +New packet list: enable packet history +Me: Add a comment. ------------------------------------------------------------------------ -r22572 | richardv | 2007-08-21 14:15:57 -0700 (Tue, 21 Aug 2007) | 6 lines +r29189 | sfisher | 2009-07-24 20:23:37 -0700 (Fri, 24 Jul 2009) | 4 lines Changed paths: - M /trunk/color_filters.c + M /trunk/gtk/new_packet_list.c + M /trunk/gtk/packet_list_store.c -From Florent DROUIN <florent.drouin@alcatel.fr>, bug 1518: -Fix for g_assert when clicking 'OK' on colour filters dialogue whilst -individual filter edit window is open. +Update my e-mail address with a reference to the AUTHORS file ------------------------------------------------------------------------ -r22573 | morriss | 2007-08-21 14:23:37 -0700 (Tue, 21 Aug 2007) | 1 line +r29190 | etxrab | 2009-07-25 00:50:53 -0700 (Sat, 25 Jul 2009) | 2 lines Changed paths: - M /trunk/epan/dissectors/packet-isakmp.c - M /trunk/epan/dissectors/packet-jxta.c - M /trunk/epan/dissectors/packet-sip.c - -Change COPY_ADDRESS to SE_COPY_ADDRESS: all of these appear to have "seasonal" scope (e.g., they are used in conversations or similar). ------------------------------------------------------------------------- -r22574 | richardv | 2007-08-21 14:25:53 -0700 (Tue, 21 Aug 2007) | 1 line -Changed paths: - M /trunk/text2pcap.c + M /trunk/file.c + M /trunk/gtk/menus.c + M /trunk/gtk/new_packet_list.c + M /trunk/ui_util.h -fix usage message for -o option +From Kovarththanan Rajaratnam: +New packet list: enable goto first/last packet (Optimized) ------------------------------------------------------------------------ -r22575 | lego | 2007-08-21 14:32:00 -0700 (Tue, 21 Aug 2007) | 3 lines +r29191 | etxrab | 2009-07-25 02:45:35 -0700 (Sat, 25 Jul 2009) | 2 lines Changed paths: - M /trunk/asn1/snmp/packet-snmp-template.c - M /trunk/epan/oids.c - M /trunk/epan/oids.h - -A further iteration in the code, things start to look good! - + M /trunk/gtk/goto_dlg.c + M /trunk/gtk/goto_dlg.h + M /trunk/gtk/main_packet_list.h + M /trunk/gtk/menus.c + M /trunk/gtk/new_packet_list.c + M /trunk/ui_util.h +From Kovarththanan Rajaratnam: +packet_goto_next_previous_frame ------------------------------------------------------------------------ -r22576 | richardv | 2007-08-21 14:40:18 -0700 (Tue, 21 Aug 2007) | 6 lines +r29192 | etxrab | 2009-07-25 03:40:10 -0700 (Sat, 25 Jul 2009) | 2 lines Changed paths: - M /trunk/epan/dissectors/packet-bootp.c - -From Francois-Xavier Le Bail <fx.lebail@yahoo.com> / bug 1724: - -The following patch decode DHCP option 249 (Classless Static Route) used by -some Microsoft systems. Same decoding as option 121 (RFC 3442). - + M /trunk/ui_util.h +From Kovarththanan Rajaratnam: +Include needed header (unbreak OSX buildbot) ------------------------------------------------------------------------ -r22577 | richardv | 2007-08-21 15:00:06 -0700 (Tue, 21 Aug 2007) | 12 lines +r29193 | sfisher | 2009-07-25 13:13:46 -0700 (Sat, 25 Jul 2009) | 4 lines Changed paths: - M /trunk/asn1/mpeg/mpeg-pes.asn - M /trunk/asn1/mpeg/packet-mpeg-pes-template.c - M /trunk/epan/dissectors/packet-mpeg-pes.c - M /trunk/wiretap/mpeg.c - M /trunk/wiretap/wtap-int.h + M /trunk/file.c + M /trunk/gtk/new_packet_list.c -From Shaun Jackman <sjackman@gmail.com> / bug 1753: - * asn1/mpeg/packet-mpeg-pes-template.c: Improved decoding of PES - extension header and Pack header. Decode SCR, PTS, and DTS. - * asn1/mpeg/mpeg-pes.asn (Pack): Remove. - * epan/dissectors/packet-mpeg-pes.c: Regenerate. - * wiretap/mpeg.c (mpeg_read): Decode the SCR using integer - arithmetic instead of double float arithmetic to prevent rounding - error. - * wiretap/wtap-int.h (mpeg_t) <t0>: Use time_t instead of double. +Remove two unused variables and mark a function paramter as unused ------------------------------------------------------------------------ -r22578 | richardv | 2007-08-21 15:15:17 -0700 (Tue, 21 Aug 2007) | 7 lines +r29194 | guy | 2009-07-25 17:32:22 -0700 (Sat, 25 Jul 2009) | 3 lines Changed paths: - M /trunk/epan/dissectors/packet-tcp.c - -From yin sun <sunyin51@gmail.com> / bug 1722: - -When a subdissector on top of TCP set ... DESEGMENT_UNTIL_FIN ... then -the subdissector should receive the whole reassembled TCP stream in tvb. -But the bug is it is missing the last payload from the FIN packet. + M /trunk/wiretap/wtap.h +Note that libpcap fails if it tries to read a file with a snapshot +length > 65535, so we shouldn't use a larger value. ------------------------------------------------------------------------ -r22579 | morriss | 2007-08-21 15:18:27 -0700 (Tue, 21 Aug 2007) | 1 line +r29195 | etxrab | 2009-07-26 03:34:07 -0700 (Sun, 26 Jul 2009) | 2 lines Changed paths: - M /trunk/epan/dissectors/packet-jxta.c + M /trunk/file.c + M /trunk/gtk/new_packet_list.c + M /trunk/gtk/packet_list_store.c + M /trunk/gtk/packet_list_store.h + M /trunk/ui_util.h -Fix a known- and marked-by-a-comment memory leak: replace g_strdup() with se_strdup(). (The address in question is stored in a conversation structure so it's "seasonal".) +From Kovarththanan Rajaratnam: +Only clear packet list store if we need to redissect. ------------------------------------------------------------------------ -r22580 | guy | 2007-08-21 19:45:42 -0700 (Tue, 21 Aug 2007) | 5 lines +r29196 | gerald | 2009-07-26 08:03:27 -0700 (Sun, 26 Jul 2009) | 1 line Changed paths: - M /trunk/wiretap/mpeg.c - -Cast away shortening conversions that are presumed not to lose any data. - -Use G_GINT64_CONSTANT() to make a 64-bit integral constant; not all -compilers we use support LL as a suffix for that (MSVC++ 6, for one). + M /trunk/epan/enterprise-numbers + M /trunk/manuf +[Automatic manuf and enterprise-numbers update for 2009-07-26] ------------------------------------------------------------------------ -r22581 | guy | 2007-08-21 21:25:00 -0700 (Tue, 21 Aug 2007) | 5 lines +r29199 | etxrab | 2009-07-26 15:11:46 -0700 (Sun, 26 Jul 2009) | 11 lines Changed paths: - M /trunk/asn1/mpeg/packet-mpeg-pes-template.c - -Cast away shortening conversions that are presumed not to lose any data. + M /trunk/config.nmake + M /trunk/gtk/new_packet_list.c + M /trunk/gtk/packet_list_store.c + M /trunk/gtk/packet_list_store.h -Use G_GINT64_CONSTANT() to make a 64-bit integral constant; not all -compilers we use support LL as a suffix for that (MSVC++ 6, for one). +From Kovarththanan Rajaratnam: +- Don't issue a row_inserted signal. Rely on our caller to have +disconnected the model from the view. +- Removing col_fmt from row_data. It wasn't being used. If we need to store +the column format in the future that should probably be placed in the +PacketList instead of the PacketListRecord +2) Remove double allocation of col_text. Now we allocate it in +new_packet_list_append() and pass it on to packet_list_append_record() +3) Use se_alloc instead of se_alloc0 because we explictly set all the +parameters we use. ------------------------------------------------------------------------ -r22582 | guy | 2007-08-21 21:31:32 -0700 (Tue, 21 Aug 2007) | 2 lines +r29200 | etxrab | 2009-07-26 15:16:36 -0700 (Sun, 26 Jul 2009) | 1 line Changed paths: - M /trunk/epan/dissectors/packet-mpeg-pes.c - -Oops, have to regenerate this after changing its template. + M /trunk/gtk/new_packet_list.c +"Create" the time cols when we render them making change of time format fast. ------------------------------------------------------------------------ -r22583 | jake | 2007-08-21 23:59:28 -0700 (Tue, 21 Aug 2007) | 3 lines +r29201 | etxrab | 2009-07-26 15:18:11 -0700 (Sun, 26 Jul 2009) | 1 line Changed paths: - M /trunk/epan/dissectors/packet-pana.c - -From Victor Fajardo: -Updated patches to support draft-ietf-pana-pana-18.txt. + M /trunk/config.nmake +Revert change by mistake. ------------------------------------------------------------------------ -r22584 | guy | 2007-08-22 00:14:08 -0700 (Wed, 22 Aug 2007) | 2 lines +r29202 | etxrab | 2009-07-26 20:34:57 -0700 (Sun, 26 Jul 2009) | 2 lines Changed paths: - M /trunk/asn1/mpeg/packet-mpeg-pes-template.c - M /trunk/epan/dissectors/packet-mpeg-pes.c - -More timestamp calculation fixes similar to the previous ones. + M /trunk/epan/column-utils.c + M /trunk/epan/column-utils.h + M /trunk/epan/libwireshark.def + M /trunk/gtk/new_packet_list.c + M /trunk/gtk/packet_list_store.c +From Kovarththanan Rajaratnam: +Use frame_data values . ------------------------------------------------------------------------ -r22585 | jake | 2007-08-22 06:58:39 -0700 (Wed, 22 Aug 2007) | 1 line +r29203 | etxrab | 2009-07-27 01:33:26 -0700 (Mon, 27 Jul 2009) | 2 lines Changed paths: - M /trunk/epan/dissectors/packet-pana.c + M /trunk/epan/column-utils.c + M /trunk/epan/column-utils.h + M /trunk/epan/epan.c + M /trunk/epan/epan.h + M /trunk/epan/frame_data.h + M /trunk/file.c + M /trunk/gtk/main.c + M /trunk/gtk/packet_win.c + M /trunk/tshark.c -The reserved field is now 16 bits. Treat it as such. +From Kovarththanan Rajaratnam: +Only fill in frame_data vals when needed. ------------------------------------------------------------------------ -r22586 | martinm | 2007-08-22 07:43:26 -0700 (Wed, 22 Aug 2007) | 2 lines +r29204 | etxrab | 2009-07-27 06:08:17 -0700 (Mon, 27 Jul 2009) | 3 lines Changed paths: - M /trunk/epan/dissectors/packet-ip.c - -Show which bits 'fragment offset' comes from (I had to look it up :( ) + M /trunk/epan/dissectors/packet-gsm_a_dtap.c +From Gerasimos Dimitriadis: +Decoding support for 4 DTAP IEs. +https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=3777 ------------------------------------------------------------------------ -r22587 | morriss | 2007-08-22 09:30:16 -0700 (Wed, 22 Aug 2007) | 11 lines +r29205 | wmeier | 2009-07-27 06:59:53 -0700 (Mon, 27 Jul 2009) | 2 lines Changed paths: - M /trunk/capture_opts.c - M /trunk/capture_opts.h - M /trunk/capture_ui_utils.c - M /trunk/gtk/capture_dlg.c - M /trunk/gtk/capture_if_dlg.c - M /trunk/gtk/main.c - M /trunk/summary.c - M /trunk/tshark.c - -Fix bug http://bugs.wireshark.org/bugzilla/show_bug.cgi?id=1757 : - -Try to call get_interface_descriptive_name() as little as possible (storing -the result in capture_opts) to avoid a performance hit during live capture -(especially if you have lots of interfaces) and to avoid leaking memory. + M /trunk/epan/reassemble.c + M /trunk/epan/reassemble.h -One issue with this is that capture_opts.c cannot (without adding significant -dependencies) set the iface_descr so readers of that field (only gtk/main.c -and tshark.c) use a macro to (set if not already set and) get the value of -that field. +reassemble.h: update two comments; reassemble.c: correct a typo. ------------------------------------------------------------------------ -r22588 | morriss | 2007-08-22 11:56:20 -0700 (Wed, 22 Aug 2007) | 1 line +r29206 | wmeier | 2009-07-27 07:45:25 -0700 (Mon, 27 Jul 2009) | 2 lines Changed paths: - M /trunk/capture_opts.h - M /trunk/capture_ui_utils.c - M /trunk/capture_ui_utils.h - M /trunk/gtk/main.c - M /trunk/summary.c + M /trunk/epan/dissectors/packet-ipsec-tcp.c -gcc 4 doesn't like my macro for getting the interface description: it says there's an invalid lvalue in it. I don't see what's wrong with it, but replace the macro with a function. Also: don't include the .xpm files in gtk/main.c if we're building without PCAP (as they're not used in that configuration). ------------------------------------------------------------------------- -r22589 | morriss | 2007-08-22 11:58:26 -0700 (Wed, 22 Aug 2007) | 1 line -Changed paths: - M /trunk/gtk/toolbar.c +Move proto_reg_handoff to the end ... -autoscroll_button is not used if we don't HAVE_LIBPCAP so put it inside the #ifdef ------------------------------------------------------------------------ -r22590 | wmeier | 2007-08-22 12:36:49 -0700 (Wed, 22 Aug 2007) | 2 lines +r29207 | etxrab | 2009-07-27 07:47:12 -0700 (Mon, 27 Jul 2009) | 12 lines Changed paths: - M /trunk/make-version.pl + M /trunk/epan/dissectors/packet-v52.c -Handle case of source-dir != build-dir; 2 other minor bug fixes +From Vladimir Smrekar: ------------------------------------------------------------------------- -r22591 | morriss | 2007-08-22 12:38:49 -0700 (Wed, 22 Aug 2007) | 1 line -Changed paths: - M /trunk/epan/dissectors/packet-ppi.c - M /trunk/wiretap/libpcap.h - M /trunk/wiretap/wtap-capture.h +Change, that fix infinite loop for dissections of elements: +- Pulse notification +- Line Information +- PSTN FSM state +- Autonomous signalling sequence +- Sequence response +- Performance grading +- Rejection cp cause -Move wtap_pcap_encap_to_wtap_encap()'s definition to libpcap.h so packet-ppi.c can get access to it even when we don't HAVE_LIBPCAP (besides, it doesn't seem to be specific to capturing...) +Me prefix hf vars with hf_v52_ ------------------------------------------------------------------------ -r22592 | morriss | 2007-08-22 14:05:25 -0700 (Wed, 22 Aug 2007) | 1 line +r29208 | wmeier | 2009-07-27 14:59:01 -0700 (Mon, 27 Jul 2009) | 14 lines Changed paths: - M /trunk/configure.in + M /trunk/epan/dissectors/packet-ndmp.c -Postpone checking if dumpcap is enabled until after we have checked if we have libpcap or not: if not, don't bother trying to build dumpcap. ------------------------------------------------------------------------- -r22593 | etxrab | 2007-08-22 14:47:31 -0700 (Wed, 22 Aug 2007) | 1 line -Changed paths: - M /trunk/epan/dissectors/packet-dpnss.c +Improve defragmentation: +1. Prevent tcpencap (ipsec-tcp) from incorrectly dissecting NDMP PDU fragments; + (Essentially: register NDMP as the dissector for the conversation); + Allows correct NDMP fragment reassembly whether or not the + TCP "Try heuristic sub-dissectors first" preference is enabled. + Fixes Bug #3755 (https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=3755) +2. Use a registered init routine to init the fragment and reassembled tables + each time a complete capture dissection is (re)started. + Fixes a crash. +3. Don't register on TCP port 10000 since the tcpencap dissector needs to own this + port. (The NDMP dissector is a heuristic dissector). +4. Strengthen the heuristic checking slightly. +5. Other minor changes. -Put suplementarry service strings and parameters into the tree. ------------------------------------------------------------------------ -r22594 | stig | 2007-08-22 14:58:21 -0700 (Wed, 22 Aug 2007) | 9 lines +r29209 | wmeier | 2009-07-27 16:16:29 -0700 (Mon, 27 Jul 2009) | 2 lines Changed paths: M /trunk/AUTHORS - M /trunk/epan/dissectors/packet-slowprotocols.c -From Todd J Martin: -When LACP packets have the actor state or partner state fields set to 0x00, -wireshark prints the state like this (note the closing parenthesis): - - Actor State: 0x00) - -Since there are no flags set, this fields should be printed like this: - Actor State: 0x00 +Add Chris Costa to AUTHORS ------------------------------------------------------------------------ -r22595 | stig | 2007-08-22 15:32:13 -0700 (Wed, 22 Aug 2007) | 3 lines +r29210 | sahlberg | 2009-07-28 00:18:05 -0700 (Tue, 28 Jul 2009) | 9 lines Changed paths: - M /trunk/epan/dissectors/packet-dpnss.c + M /trunk/asn1/ldap/packet-ldap-template.c + M /trunk/asn1/ldap/packet-ldap-template.h + M /trunk/epan/dissectors/packet-ldap.c + M /trunk/epan/dissectors/packet-ldap.h -Added DPNSS_NONE as par3_num and par4_num to "PCON-P" -Fixed a signed/unsigned compiler warning +From: Matthieu Patou <mat+Informatique.Samba@matws.net> +Date: Mon, 27 Jul 2009 08:55:55 +0000 (+0200) +Subject: patch_ldap_260709 ------------------------------------------------------------------------- -r22596 | lego | 2007-08-22 15:56:36 -0700 (Wed, 22 Aug 2007) | 3 lines -Changed paths: - M /trunk/epan/oids.c - M /trunk/epan/oids.h +Add a few additional LDAP OIDs +and increase the maximum SASL blob size to be 1M instead of 256kb -Prepare the oids dataset for managing conceptual table indexing ------------------------------------------------------------------------ -r22597 | jake | 2007-08-22 23:56:04 -0700 (Wed, 22 Aug 2007) | 6 lines +r29211 | etxrab | 2009-07-28 02:26:18 -0700 (Tue, 28 Jul 2009) | 1 line Changed paths: - M /trunk/epan/dissectors/packet-bacnet.c + M /trunk/epan/proto.h -From Steve Karg -1. Moved all the network layer message type decodings under the network layer control bit check to prevent malformed packets. -2. Added the decoding of the optional network number for the Who-Is-Router-To-Network message type. -3. Added the decoding for the Establish-Connection-To-Network and Disconnect-Connection-To-Network network layer messages. -4. Corrected Initialize-Routing-Table and Initialize-Routing-Table-Ack decoding. -5. Added Network layer info under Column Info. +Whitespace change. ------------------------------------------------------------------------ -r22598 | jake | 2007-08-23 02:16:31 -0700 (Thu, 23 Aug 2007) | 5 lines +r29212 | etxrab | 2009-07-28 03:53:57 -0700 (Tue, 28 Jul 2009) | 1 line Changed paths: - M /trunk/epan/dissectors/packet-bgp.c - -From David Helder: -The MP_REACH_NLRI (and MP_UNREACH_NLRI) parser incorrectly increments a buffer -offset. Any attributes following will be skipped and/or parsed incorrectly. -No security problem I see - the bounds are checked before parsing each attribute. + M /trunk/file.h + M /trunk/gtk/menus.c + M /trunk/gtk/new_packet_list.c + M /trunk/ui_util.h +Fix setting of new time format. ------------------------------------------------------------------------ -r22599 | grahamb | 2007-08-23 02:26:01 -0700 (Thu, 23 Aug 2007) | 1 line +r29213 | sahlberg | 2009-07-28 06:01:41 -0700 (Tue, 28 Jul 2009) | 15 lines Changed paths: - M /trunk/epan/dissectors/packet-cip.c + M /trunk/asn1/spnego/packet-spnego-template.c + M /trunk/epan/dissectors/packet-kerberos.c + M /trunk/epan/dissectors/packet-kerberos.h + M /trunk/epan/dissectors/packet-kink.c + M /trunk/epan/dissectors/packet-spnego.c -Permit decoding of individual service errors + removal of a few lines consisting of just whitespace ------------------------------------------------------------------------- -r22600 | grahamb | 2007-08-23 02:28:03 -0700 (Thu, 23 Aug 2007) | 1 line -Changed paths: - M /trunk/epan/dissectors/packet-dnp.c +When we passed the crytobuffer to krb5_c_decrypt() we never actually +verified that we did have enough data in the buffer/tvb, which could +lead to a SEGV. +(for example if we enable KRB5 decryption but we do NOT use TCP +reassembly, and the encrypted data goes beyong the end of the current +segment) -Large update with improvements in objects dissected, fragment reassembly, info column details and filter field names ------------------------------------------------------------------------- -r22601 | wmeier | 2007-08-23 07:56:18 -0700 (Thu, 23 Aug 2007) | 2 lines -Changed paths: - M /trunk/tools/fuzz-test.sh -Don't rename to self when fuzz err; enable ^C file cleanup trap +Change the signature to decrypt_krb5_data() to take a TVB instead of a +buffer+length. +Actually check that we do have the entire encrypted PDU before calling +out to the kerberos libraries. + ------------------------------------------------------------------------- -r22602 | etxrab | 2007-08-23 10:00:44 -0700 (Thu, 23 Aug 2007) | 1 line -Changed paths: - M /trunk/epan/dissectors/packet-sip.c -Translate Q.850 Cause values. ------------------------------------------------------------------------ -r22603 | richardv | 2007-08-23 10:25:22 -0700 (Thu, 23 Aug 2007) | 2 lines +r29214 | sahlberg | 2009-07-28 06:38:46 -0700 (Tue, 28 Jul 2009) | 3 lines Changed paths: - M /trunk/epan/Makefile.common - A /trunk/epan/golay.c (from /trunk/plugins/h223/golay.c:22567) - A /trunk/epan/golay.h (from /trunk/plugins/h223/golay.h:22567) - M /trunk/plugins/h223/Makefile.common - D /trunk/plugins/h223/golay.c - D /trunk/plugins/h223/golay.h - M /trunk/plugins/h223/packet-h223.c + M /trunk/tools/pidl/MANIFEST + M /trunk/tools/pidl/README + M /trunk/tools/pidl/TODO + M /trunk/tools/pidl/idl.yp + M /trunk/tools/pidl/lib/Parse/Pidl/Compat.pm + M /trunk/tools/pidl/lib/Parse/Pidl/Expr.pm + M /trunk/tools/pidl/lib/Parse/Pidl/IDL.pm + M /trunk/tools/pidl/lib/Parse/Pidl/NDR.pm + M /trunk/tools/pidl/lib/Parse/Pidl/Samba3/ClientNDR.pm + M /trunk/tools/pidl/lib/Parse/Pidl/Samba3/ServerNDR.pm + M /trunk/tools/pidl/lib/Parse/Pidl/Samba4/Header.pm + M /trunk/tools/pidl/lib/Parse/Pidl/Samba4/NDR/Client.pm + M /trunk/tools/pidl/lib/Parse/Pidl/Samba4/NDR/Parser.pm + M /trunk/tools/pidl/lib/Parse/Pidl/Samba4/NDR/Server.pm + M /trunk/tools/pidl/lib/Parse/Pidl/Samba4/TDR.pm + M /trunk/tools/pidl/lib/Parse/Pidl/Samba4.pm + M /trunk/tools/pidl/lib/Parse/Pidl/Typelist.pm + M /trunk/tools/pidl/lib/Parse/Pidl/Wireshark/Conformance.pm + M /trunk/tools/pidl/lib/Parse/Pidl/Wireshark/NDR.pm + M /trunk/tools/pidl/lib/Parse/Pidl.pm + M /trunk/tools/pidl/pidl + M /trunk/tools/pidl/tests/Util.pm + M /trunk/tools/pidl/tests/header.pl + M /trunk/tools/pidl/tests/ndr.pl + M /trunk/tools/pidl/tests/ndr_align.pl + M /trunk/tools/pidl/tests/ndr_alloc.pl + M /trunk/tools/pidl/tests/ndr_array.pl + M /trunk/tools/pidl/tests/ndr_compat.pl + M /trunk/tools/pidl/tests/ndr_fullptr.pl + M /trunk/tools/pidl/tests/ndr_refptr.pl + M /trunk/tools/pidl/tests/ndr_represent.pl + M /trunk/tools/pidl/tests/ndr_simple.pl + M /trunk/tools/pidl/tests/ndr_string.pl + M /trunk/tools/pidl/tests/ndr_tagtype.pl + M /trunk/tools/pidl/tests/parse_idl.pl + M /trunk/tools/pidl/tests/samba-ndr.pl + M /trunk/tools/pidl/tests/samba3-cli.pl + M /trunk/tools/pidl/tests/typelist.pl + M /trunk/tools/pidl/tests/wireshark-conf.pl + +update pidl to the newest version from samba -in preparation for de-pluginising h223, move golay code support into libwireshark ------------------------------------------------------------------------ -r22604 | gerald | 2007-08-23 10:49:47 -0700 (Thu, 23 Aug 2007) | 3 lines +r29215 | sahlberg | 2009-07-28 06:39:42 -0700 (Tue, 28 Jul 2009) | 3 lines Changed paths: - M /trunk/capture-pcap-util.c + M /trunk/epan/dissectors/packet-dcerpc-samr.c -Include libpcap.h so that we can use wtap_pcap_encap_to_wtap_encap() -in its new location. +regenerate SAMR using the new version of pidl ------------------------------------------------------------------------- -r22605 | jake | 2007-08-23 12:12:52 -0700 (Thu, 23 Aug 2007) | 1 line -Changed paths: - M /trunk/plugins/unistim/TODO -List additional request for command presentation ------------------------------------------------------------------------ -r22606 | lego | 2007-08-23 12:45:31 -0700 (Thu, 23 Aug 2007) | 4 lines +r29216 | sahlberg | 2009-07-28 06:50:22 -0700 (Tue, 28 Jul 2009) | 4 lines Changed paths: - M /trunk/asn1/snmp/packet-snmp-template.c - M /trunk/epan/oids.c + A /trunk/epan/dissectors/pidl/frstrans.cnf + A /trunk/epan/dissectors/pidl/frstrans.idl -Implement Resolution of conceptual table indexing -So far this has being tested only for integer indexes. +From Stefan Metzmacher : +Add IDL file for FRSTRANS ------------------------------------------------------------------------ -r22607 | jake | 2007-08-23 13:42:27 -0700 (Thu, 23 Aug 2007) | 5 lines +r29217 | sahlberg | 2009-07-28 06:53:10 -0700 (Tue, 28 Jul 2009) | 4 lines Changed paths: - M /trunk/epan/dissectors/packet-bgp.c + M /trunk/epan/dissectors/Makefile.common + A /trunk/epan/dissectors/packet-dcerpc-frstrans.c + A /trunk/epan/dissectors/packet-dcerpc-frstrans.h -Clean up the code. -- Move add. info from header -- Remove excess comma's -- Use plurality macro -- NULL pointer for field descriptions ------------------------------------------------------------------------- -r22608 | morriss | 2007-08-23 14:11:47 -0700 (Thu, 23 Aug 2007) | 1 line -Changed paths: - M /trunk/epan/libwireshark.def +From Stefan Metzmacher +add generated FRSTRANS dissectors and add them to the build -Export golay_errors() to get the Windows builds going again ------------------------------------------------------------------------- -r22609 | morriss | 2007-08-23 14:38:15 -0700 (Thu, 23 Aug 2007) | 1 line -Changed paths: - M /trunk/epan/dissectors/packet-tcp.c -When detecting fast retransmissions or out of order packets, use a 64-bit variable to store the time delta (instead of a 32-bit one). We're counting nanoseconds here, so this allows us to accurately detect differences greater than 4.294 seconds. ------------------------------------------------------------------------ -r22610 | stig | 2007-08-23 14:51:36 -0700 (Thu, 23 Aug 2007) | 2 lines +r29218 | etxrab | 2009-07-28 07:07:15 -0700 (Tue, 28 Jul 2009) | 1 line Changed paths: - M /trunk/gtk/io_stat.c - -Fixed drawing of X Axis decimal values: "0. 50" -> "0.050" + M /trunk/gtk/menus.c +Fix setting of timestamp_precision. ------------------------------------------------------------------------ -r22611 | sfisher | 2007-08-23 14:51:44 -0700 (Thu, 23 Aug 2007) | 4 lines +r29219 | sahlberg | 2009-07-28 07:11:08 -0700 (Tue, 28 Jul 2009) | 5 lines Changed paths: - M /trunk/gtk/follow_stream.h + M /trunk/epan/dissectors/packet-dcerpc-frstrans.c + M /trunk/epan/dissectors/packet-dcerpc-samr.c + M /trunk/epan/dissectors/pidl/samr.idl +update samr.idl and remove a keyword we no longer support in pidl -Fix comment on top of file +regenerate samr and frstrans with the new version of pidl ------------------------------------------------------------------------ -r22612 | sfisher | 2007-08-23 15:11:39 -0700 (Thu, 23 Aug 2007) | 10 lines +r29220 | etxrab | 2009-07-28 09:20:05 -0700 (Tue, 28 Jul 2009) | 1 line Changed paths: - M /trunk/AUTHORS - M /trunk/wiretap/visual.c - - -From Scott Robinson: - -Enhancement patch: - http://bugs.wireshark.org/bugzilla/show_bug.cgi?id=1758 - -This change gives Wireshark the ability to read ATM captures saved by UpTime -Select traffic capture. - + M /trunk/file.c + M /trunk/gtk/main.c + M /trunk/gtk/new_packet_list.c +Set reftime without recreating the packet list. ------------------------------------------------------------------------ -r22613 | gerald | 2007-08-23 16:01:20 -0700 (Thu, 23 Aug 2007) | 2 lines +r29221 | gerald | 2009-07-28 10:27:59 -0700 (Tue, 28 Jul 2009) | 2 lines Changed paths: - M /trunk/gtk/follow_stream.c - M /trunk/gtk/follow_stream.h + M /trunk/test/config.sh -Move follow_infos into folow_stream.c and initialize it. +Update the adapter name check to match the buildbot. ------------------------------------------------------------------------ -r22614 | richardv | 2007-08-23 16:33:23 -0700 (Thu, 23 Aug 2007) | 1 line +r29222 | etxrab | 2009-07-28 11:29:15 -0700 (Tue, 28 Jul 2009) | 1 line Changed paths: - M /trunk/epan/libwireshark.def + M /trunk/file.c -add remaining golay_* functions +Pacify the build bot. ------------------------------------------------------------------------ -r22615 | richardv | 2007-08-23 16:58:59 -0700 (Thu, 23 Aug 2007) | 5 lines +r29223 | etxrab | 2009-07-28 13:46:23 -0700 (Tue, 28 Jul 2009) | 2 lines Changed paths: - M /trunk/epan/dissectors/packet-calcappprotocol.c - M /trunk/epan/dissectors/packet-cast.c - M /trunk/epan/dissectors/packet-cpha.c - -From Chris Maynard <christopher.maynard@gtech.com> / bug 1789: - -Incorrect display filter field naming conventions for packet-c*.c dissector -files. + M /trunk/gtk/main.c + M /trunk/gtk/main_proto_draw.c + M /trunk/gtk/menus.c + M /trunk/gtk/new_packet_list.c + M /trunk/gtk/new_packet_list.h + M /trunk/ui_util.h +From Kovarththanan Rajaratnam: +Enable popup menu in packet list view. ------------------------------------------------------------------------ -r22616 | richardv | 2007-08-23 17:03:02 -0700 (Thu, 23 Aug 2007) | 3 lines +r29224 | wmeier | 2009-07-28 13:56:36 -0700 (Tue, 28 Jul 2009) | 3 lines Changed paths: - M /trunk/epan/filesystem.c + M /trunk/gtk/recent.c -Don't build in init_plugin_dir if HAVE_PLUGINS is not defined, which -means that we aren't reliant on PLUGIN_DIR having a sensible value. +Clarify (slightly) some comments; +Add a comment as to what looks like incorrect code. ------------------------------------------------------------------------ -r22617 | richardv | 2007-08-23 17:06:30 -0700 (Thu, 23 Aug 2007) | 7 lines +r29225 | etxrab | 2009-07-28 15:18:19 -0700 (Tue, 28 Jul 2009) | 1 line Changed paths: - M /trunk/config.h.win32 - M /trunk/configure.in - -In keeping with all the other path variables (eg, libdir), don't resolve -plugindir at configure time. Instead leave it to be defined at make -time, which means it can then be changed by, eg, changing $prefix. This -also means moving the definition of PLUGIN_DIR from config.h to a -D in -CPPFLAGS. - + M /trunk/gtk/menus.c + M /trunk/gtk/new_packet_list.c + M /trunk/gtk/new_packet_list.h +Make mark frame work. ------------------------------------------------------------------------ -r22618 | lego | 2007-08-23 17:26:30 -0700 (Thu, 23 Aug 2007) | 3 lines +r29226 | jake | 2009-07-29 00:10:02 -0700 (Wed, 29 Jul 2009) | 3 lines Changed paths: - M /trunk/asn1/snmp/packet-snmp-template.c - M /trunk/epan/oids.c + M /trunk/epan/dissectors/packet-dns.c -Another iteration, the new code is almost there, We're missing just the implied octetstrings indexes. +From Ivan Sy: +Support for DLV RR (RFC 4431) and SHA-256 Digest for DS RR (RFC 4509). +------------------------------------------------------------------------ +r29227 | kukosa | 2009-07-29 02:13:03 -0700 (Wed, 29 Jul 2009) | 1 line +Changed paths: + M /trunk/epan/dissectors/packet-sip.c +Support for IPv6 addresses in URI ------------------------------------------------------------------------ -r22619 | lego | 2007-08-23 17:33:35 -0700 (Thu, 23 Aug 2007) | 3 lines +r29228 | sahlberg | 2009-07-29 03:01:14 -0700 (Wed, 29 Jul 2009) | 18 lines Changed paths: - M /trunk/asn1/snmp/packet-snmp-template.c + M /trunk/epan/crypt/Makefile.common + M /trunk/epan/crypt/airpdcap_ccmp.c + M /trunk/epan/crypt/airpdcap_rijndael.c + M /trunk/epan/crypt/airpdcap_rijndael.h + A /trunk/epan/crypt/crypt-aes.c + A /trunk/epan/crypt/crypt-aes.h -Never, never, never modify a generated file... or out of idiocy you might loose changes (or not check them in). +Break the aes set ket/decrypt/encrypt out from airpdcap_raindoll into +its own crypt-aes. +change the integer types to glib style integers ------------------------------------------------------------------------- -r22620 | lego | 2007-08-23 17:41:43 -0700 (Thu, 23 Aug 2007) | 3 lines -Changed paths: - M /trunk/asn1/snmp/packet-snmp-template.c -this one was missing +this may/will be helpful if/when we implement our own version of +kerberos +aes decryption of dcerpc since the existing libraries can not (yet) +handle when header signing is used. + +we should implement our own decryption of this for cfx+aes just as we +did for classic+arcfour + ------------------------------------------------------------------------- -r22621 | etxrab | 2007-08-23 22:58:08 -0700 (Thu, 23 Aug 2007) | 3 lines -Changed paths: - M /trunk/asn1/ansi_map/packet-ansi_map-template.c - M /trunk/asn1/tcap/packet-ansi_tcap-template.c - M /trunk/epan/dissectors/packet-ansi_map.c - M /trunk/epan/dissectors/packet-ansi_map.h - M /trunk/epan/dissectors/packet-ansi_tcap.c - M /trunk/epan/dissectors/packet-gsm_a.c -From Chris Maynard: -Fix display filter field problems -Correct the template files in the case of generated dissectors. ------------------------------------------------------------------------- -r22622 | etxrab | 2007-08-23 22:59:08 -0700 (Thu, 23 Aug 2007) | 3 lines -Changed paths: - M /trunk/epan/dissectors/packet-amr.c -From Chris Maynard: -Fix display filter field problems -Correct the template files in the case of generated dissectors. ------------------------------------------------------------------------ -r22623 | jmayer | 2007-08-23 23:49:47 -0700 (Thu, 23 Aug 2007) | 3 lines +r29229 | sahlberg | 2009-07-29 03:28:10 -0700 (Wed, 29 Jul 2009) | 8 lines Changed paths: - M /trunk/epan/dissectors/packet-radius.h + M /trunk/epan/dissectors/packet-dcerpc-eventlog.c + M /trunk/epan/dissectors/pidl/eventlog.idl -Add a value for message_authenticator +update the idl to correctly dissect the read eventlog w flags as a +bitmap and not as a uint32 +this addresses bug 3691 (that was already manually addressed by hand +in the generated dissector) ------------------------------------------------------------------------- -r22624 | jmayer | 2007-08-23 23:51:10 -0700 (Thu, 23 Aug 2007) | 4 lines -Changed paths: - M /trunk/tools/asn2wrs.py -Make Windows path separator look like Unix path separator. -That way, we will not have irrelevant diffs depending on -the platform the last submitter built the dissector on. ------------------------------------------------------------------------ -r22625 | jmayer | 2007-08-23 23:52:19 -0700 (Thu, 23 Aug 2007) | 3 lines +r29230 | sahlberg | 2009-07-29 03:41:24 -0700 (Wed, 29 Jul 2009) | 3 lines Changed paths: - M /trunk/epan/dissectors/packet-ssl.c + M /trunk/epan/dissectors/packet-dcerpc-eventlog.c + M /trunk/epan/dissectors/pidl/eventlog.idl + +Fixup the correct names of the parameters for OpenEventLogW -Don't acidentally print the hexdump of a certificate -in the summary-tree ------------------------------------------------------------------------ -r22626 | jmayer | 2007-08-24 00:10:33 -0700 (Fri, 24 Aug 2007) | 2 lines +r29231 | sahlberg | 2009-07-29 03:59:31 -0700 (Wed, 29 Jul 2009) | 14 lines Changed paths: - M /trunk/epan/dissectors/packet-isakmp.c + M /trunk/epan/dissectors/packet-dcerpc-eventlog.c + M /trunk/epan/dissectors/pidl/eventlog.idl -Decode certificates +start describing ReportEventW in the IDL and make use of the "bitmap" +for EventTypes. ------------------------------------------------------------------------- -r22627 | jmayer | 2007-08-24 00:12:04 -0700 (Fri, 24 Aug 2007) | 3 lines -Changed paths: - M /trunk/asn1/acse/acse-exp.cnf - M /trunk/asn1/cmip/cmip-exp.cnf - M /trunk/asn1/cms/cms.cnf - M /trunk/asn1/dap/dap-exp.cnf - M /trunk/asn1/disp/disp-exp.cnf - M /trunk/asn1/dop/dop-exp.cnf - M /trunk/asn1/dsp/dsp-exp.cnf - M /trunk/asn1/ftam/ftam-exp.cnf - M /trunk/asn1/gsmmap/gsm_map-exp.cnf - M /trunk/asn1/gsmmap/packet-gsm_map-template.c - M /trunk/asn1/h225/h225-exp.cnf - M /trunk/asn1/h245/h245-exp.cnf - M /trunk/asn1/ldap/packet-ldap-template.c - M /trunk/asn1/mms/mms-exp.cnf - M /trunk/asn1/mms/packet-mms-template.c - M /trunk/asn1/mpeg/mpeg-audio-exp.cnf - M /trunk/asn1/mpeg/mpeg-pes-exp.cnf - M /trunk/asn1/pkcs12/packet-pkcs12-template.c - M /trunk/asn1/pkix1explicit/pkix1explicit-exp.cnf - M /trunk/asn1/pkix1implicit/pkix1implicit-exp.cnf - M /trunk/asn1/pkixcmp/cmp-exp.cnf - M /trunk/asn1/pkixcrmf/crmf-exp.cnf - M /trunk/asn1/q932/packet-q932-template.c - M /trunk/asn1/q932/q932-exp.cnf - M /trunk/asn1/qsig/qsig-exp.cnf - M /trunk/asn1/ranap/ranap-exp.cnf - M /trunk/asn1/ros/ros-exp.cnf - M /trunk/asn1/rtse/rtse-exp.cnf - M /trunk/asn1/rtse/rtse.cnf - M /trunk/asn1/snmp/packet-snmp-template.c - M /trunk/asn1/snmp/snmp.cnf - M /trunk/asn1/tcap/packet-tcap-template.c - M /trunk/asn1/x411/x411-exp.cnf - M /trunk/asn1/x411/x411.cnf - M /trunk/asn1/x509af/x509af-exp.cnf - M /trunk/asn1/x509ce/x509ce-exp.cnf - M /trunk/asn1/x509if/x509if-exp.cnf - M /trunk/epan/dissectors/packet-acse.h - M /trunk/epan/dissectors/packet-ber.c - M /trunk/epan/dissectors/packet-ber.h - M /trunk/epan/dissectors/packet-cmip.c - M /trunk/epan/dissectors/packet-cmip.h - M /trunk/epan/dissectors/packet-cmp.c - M /trunk/epan/dissectors/packet-cmp.h - M /trunk/epan/dissectors/packet-cms.c - M /trunk/epan/dissectors/packet-cops.c - M /trunk/epan/dissectors/packet-crmf.c - M /trunk/epan/dissectors/packet-crmf.h - M /trunk/epan/dissectors/packet-dap.c - M /trunk/epan/dissectors/packet-dap.h - M /trunk/epan/dissectors/packet-disp.c - M /trunk/epan/dissectors/packet-disp.h - M /trunk/epan/dissectors/packet-dop.c - M /trunk/epan/dissectors/packet-dop.h - M /trunk/epan/dissectors/packet-dsp.c - M /trunk/epan/dissectors/packet-dsp.h - M /trunk/epan/dissectors/packet-ftam.h - M /trunk/epan/dissectors/packet-gsm_a.c - M /trunk/epan/dissectors/packet-gsm_map.c - M /trunk/epan/dissectors/packet-gsm_map.h - M /trunk/epan/dissectors/packet-gssapi.c - M /trunk/epan/dissectors/packet-h225.c - M /trunk/epan/dissectors/packet-h225.h - M /trunk/epan/dissectors/packet-h245.c - M /trunk/epan/dissectors/packet-h245.h - M /trunk/epan/dissectors/packet-kerberos.c - M /trunk/epan/dissectors/packet-ldap.c - M /trunk/epan/dissectors/packet-mms.c - M /trunk/epan/dissectors/packet-mms.h - M /trunk/epan/dissectors/packet-mpeg-audio.c - M /trunk/epan/dissectors/packet-pkcs12.c - M /trunk/epan/dissectors/packet-pkix1explicit.c - M /trunk/epan/dissectors/packet-pkix1explicit.h - M /trunk/epan/dissectors/packet-pkix1implicit.c - M /trunk/epan/dissectors/packet-pkix1implicit.h - M /trunk/epan/dissectors/packet-q932-ros.c - M /trunk/epan/dissectors/packet-q932.c - M /trunk/epan/dissectors/packet-q932.h - M /trunk/epan/dissectors/packet-qsig.c - M /trunk/epan/dissectors/packet-qsig.h - M /trunk/epan/dissectors/packet-ranap.c - M /trunk/epan/dissectors/packet-ranap.h - M /trunk/epan/dissectors/packet-ros.c - M /trunk/epan/dissectors/packet-ros.h - M /trunk/epan/dissectors/packet-rtse.c - M /trunk/epan/dissectors/packet-rtse.h - M /trunk/epan/dissectors/packet-snmp.c - M /trunk/epan/dissectors/packet-snmp.h - M /trunk/epan/dissectors/packet-tcap.c - M /trunk/epan/dissectors/packet-tcap.h - M /trunk/epan/dissectors/packet-x411.c - M /trunk/epan/dissectors/packet-x411.h - M /trunk/epan/dissectors/packet-x509af.c - M /trunk/epan/dissectors/packet-x509af.h - M /trunk/epan/dissectors/packet-x509ce.c - M /trunk/epan/dissectors/packet-x509ce.h - M /trunk/epan/dissectors/packet-x509if.c - M /trunk/epan/dissectors/packet-x509if.h +This addresses also bug 3552 with the until now unusued code. -get_ber_length doesn't need the tree argument, get rid of it. -Rebuild asn1 dissectors. ------------------------------------------------------------------------- -r22628 | jmayer | 2007-08-24 01:12:39 -0700 (Fri, 24 Aug 2007) | 3 lines -Changed paths: - M /trunk/epan/dissectors/packet-ber.c +The eventlog dissector is very incomplete. +While the protocol specification is available now, what is lacking is +example capture files to test with when implementing more of the IDL +definitions. -The ber header was missing from the object, resulting in -invalid saved certificates. ------------------------------------------------------------------------- -r22629 | jmayer | 2007-08-24 03:20:22 -0700 (Fri, 24 Aug 2007) | 1 line -Changed paths: - M /trunk/epan/dissectors/packet-ber.c -Warning fixes ------------------------------------------------------------------------- -r22630 | richardv | 2007-08-24 05:15:49 -0700 (Fri, 24 Aug 2007) | 1 line -Changed paths: - M /trunk/epan/oids.h -add newline to end of file ------------------------------------------------------------------------ -r22631 | richardv | 2007-08-24 05:43:38 -0700 (Fri, 24 Aug 2007) | 1 line +r29232 | sahlberg | 2009-07-29 04:29:53 -0700 (Wed, 29 Jul 2009) | 4 lines Changed paths: - M /trunk/epan/oids.c + M /trunk/epan/dissectors/Makefile.common + M /trunk/epan/dissectors/packet-zbee-aps.c + M /trunk/epan/dissectors/packet-zbee-aps.h + M /trunk/epan/dissectors/packet-zbee-nwk.c + A /trunk/epan/dissectors/packet-zbee-zcl.c + A /trunk/epan/dissectors/packet-zbee-zcl.h + M /trunk/epan/dissectors/packet-zbee-zdp.c + M /trunk/epan/dissectors/packet-zbee.h -fix 'unused variable' warning ------------------------------------------------------------------------- -r22632 | richardv | 2007-08-24 05:44:29 -0700 (Fri, 24 Aug 2007) | 2 lines -Changed paths: - M /trunk/epan/oid_resolv.c +zigbee cluster dissector, +modified from entry in bug 3765 so it compiles cleanly -Cut and paste old oid_to_subid_buf (it used to be in packet-snmp.c) to get things building again. ------------------------------------------------------------------------ -r22633 | richardv | 2007-08-24 05:45:08 -0700 (Fri, 24 Aug 2007) | 2 lines +r29233 | stig | 2009-07-29 08:31:25 -0700 (Wed, 29 Jul 2009) | 2 lines Changed paths: - M /trunk/epan/Makefile.common + M /trunk/gtk/new_packet_list.c -add oids.{c,h} for LEGO +Mark an unused argument. ------------------------------------------------------------------------ -r22634 | richardv | 2007-08-24 06:08:21 -0700 (Fri, 24 Aug 2007) | 1 line +r29234 | jake | 2009-07-29 11:26:55 -0700 (Wed, 29 Jul 2009) | 4 lines Changed paths: - M /trunk/epan/dissectors/Makefile.common - A /trunk/epan/dissectors/packet-srp.c (from /trunk/plugins/h223/packet-srp.c:22567) - M /trunk/plugins/h223/Makefile.common - D /trunk/plugins/h223/packet-srp.c - D /trunk/plugins/h223/packet-srp.h + M /trunk/epan/dissectors/packet-isakmp.c -move packet-srp into the core (from the h223 plugin) +From Neil Piercy: +The Cert Authority hashes in the IKEv2 Cert Request are not dissected properly: +the display offset is not correctly moved on, so the same info is displayed for +all Cert Authority fields. ------------------------------------------------------------------------ -r22635 | richardv | 2007-08-24 06:44:59 -0700 (Fri, 24 Aug 2007) | 2 lines +r29235 | guy | 2009-07-29 12:39:17 -0700 (Wed, 29 Jul 2009) | 2 lines Changed paths: - M /trunk/Makefile.am - M /trunk/Makefile.nmake - M /trunk/configure.in M /trunk/epan/dissectors/Makefile.common - A /trunk/epan/dissectors/packet-h223.c (from /trunk/plugins/h223/packet-h223.c:22629) - A /trunk/epan/dissectors/packet-h223.h (from /trunk/plugins/h223/packet-h223.h:22629) - M /trunk/plugins/Makefile.am - D /trunk/plugins/h223 -complete the death of the h223 plugin +Add packet-zbee-zcl.h to the source tarball. ------------------------------------------------------------------------ -r22636 | jmayer | 2007-08-24 06:52:37 -0700 (Fri, 24 Aug 2007) | 1 line +r29236 | wmeier | 2009-07-29 13:24:10 -0700 (Wed, 29 Jul 2009) | 3 lines Changed paths: - M /trunk/epan/dissectors/packet-snmp.c - M /trunk/epan/dissectors/packet-snmp.h + M /trunk/epan/dissectors/packet-ndmp.c -Revert back to old version with manually fixed get_ber_length parameters ------------------------------------------------------------------------- -r22637 | richardv | 2007-08-24 08:29:13 -0700 (Fri, 24 Aug 2007) | 1 line -Changed paths: - M /trunk/gtk/main.c +From Chris Costa: Fix Bug 3786: "NDMP fragmentation fails when final fragment is very small". +(See https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=3786) -fix log msg typo ------------------------------------------------------------------------ -r22638 | richardv | 2007-08-24 08:33:37 -0700 (Fri, 24 Aug 2007) | 5 lines +r29237 | etxrab | 2009-07-29 13:58:47 -0700 (Wed, 29 Jul 2009) | 7 lines Changed paths: - M /trunk/capture_loop.c + M /trunk/file.c + M /trunk/gtk/new_packet_list.c + M /trunk/ui_util.h -Add some comments to the effect that capture_loop_dispatch must timeout to make -the packet batching stuff work properly. +Add pinfo to new_packet_list_append() this should give us the abillity +to store (most) of the underlying data rather than the strings in the store and render it when we need it, thuss saving storage space and loading time. -Hence, do not block forever when doing a select() on a capture fd. +Idealy we should not store the complete fdata or pinfo structures +but rather just the data relevant to the currently selected/used columns. I'm not entierly sure how to accomplish that however. +Dynamically allocated array to hold pointers to the actual data? ------------------------------------------------------------------------ -r22639 | richardv | 2007-08-24 08:34:08 -0700 (Fri, 24 Aug 2007) | 2 lines +r29238 | etxrab | 2009-07-29 14:32:49 -0700 (Wed, 29 Jul 2009) | 4 lines Changed paths: - M /trunk/capture_loop.h - -Fix bug 1181 by always using select() on a capture fd on linux + M /trunk/file.c + M /trunk/gtk/packet_list_store.c +From Kovarththanan Rajaratnam: +This patch fixes the "Decode as" crash. We now freeze the packetlist before +attempting to clear it. This way we don't have to issue a row deleted signal +either. ------------------------------------------------------------------------ -r22640 | richardv | 2007-08-24 08:45:16 -0700 (Fri, 24 Aug 2007) | 1 line +r29239 | wmeier | 2009-07-29 15:33:08 -0700 (Wed, 29 Jul 2009) | 9 lines Changed paths: - M /trunk/test/config.sh + M /trunk/epan/dissectors/packet-zbee-zcl.c + +Fix a potential crash and do various other minor changes: +- Fix an hf[] entry which had an invalid "strings" field which could cause a crash; +- Remove unneeded #includes; +- Make most functions & etc static; +- Remove declarations for functions never defined; +- Fix certain comments to refer to the correct function names; +- Change global variable to be local to proto_reg_handoff... +- ... -do the fifo test on platforms where mkfifo is available ------------------------------------------------------------------------ -r22641 | gerald | 2007-08-24 09:08:31 -0700 (Fri, 24 Aug 2007) | 4 lines +r29240 | wmeier | 2009-07-29 15:54:28 -0700 (Wed, 29 Jul 2009) | 2 lines Changed paths: - M /trunk/doc/README.plugins - M /trunk/packaging/nsis/Makefile.nmake - M /trunk/packaging/nsis/wireshark.nsi - M /trunk/packaging/u3/win32/makefile.nmake - M /trunk/plugins/Makefile.nmake + M /trunk/epan/dissectors/packet-zbee-zcl.c -Clear out any remaining references to the h223 plugin. Replace the -references to h223 in README.plugins with agentx since it's small and -no one seems to be in a hurry to move it to epan/dissectors. +Function dissect_zcl_attr_data_type() unused: comment it out ------------------------------------------------------------------------ -r22642 | richardv | 2007-08-24 09:43:42 -0700 (Fri, 24 Aug 2007) | 4 lines +r29241 | wmeier | 2009-07-29 16:18:34 -0700 (Wed, 29 Jul 2009) | 2 lines Changed paths: - M /trunk/epan/oid_resolv.c - -take out oid_to_subid_buf again, because joerg has put it back into packet-snmp.c. + M /trunk/doc/README.developer -This is not a productive use of my time. I'm annoyed. +Fix a typo ------------------------------------------------------------------------ -r22643 | guy | 2007-08-24 12:14:38 -0700 (Fri, 24 Aug 2007) | 3 lines +r29242 | gerald | 2009-07-29 17:40:32 -0700 (Wed, 29 Jul 2009) | 2 lines Changed paths: - M /trunk/capture_ui_utils.c + M /trunk/epan/dissectors/packet-ansi_683.c -Add a comment explaining why get_interface_descriptive_name() shouldn't -be, for example, called once a second while a capture is in progress. +Remove some unused variables. ------------------------------------------------------------------------ -r22644 | stig | 2007-08-24 14:23:34 -0700 (Fri, 24 Aug 2007) | 4 lines +r29243 | gerald | 2009-07-30 09:17:46 -0700 (Thu, 30 Jul 2009) | 2 lines Changed paths: - M /trunk/gtk/io_stat.c + M /trunk/epan/dissectors/packet-netflow.c + M /trunk/epan/dissectors/packet-olsr.c + M /trunk/epan/dissectors/packet-ositp.c + M /trunk/epan/dissectors/packet-ospf.c -Print the first interval in the graph. -Print zero label string in the X Axis (not centered). -Always start the graph with the first interval, not at zero x value. +Remove some unused variable assignments. ------------------------------------------------------------------------ -r22645 | stig | 2007-08-24 14:38:10 -0700 (Fri, 24 Aug 2007) | 6 lines +r29244 | martinm | 2009-07-30 09:53:33 -0700 (Thu, 30 Jul 2009) | 2 lines Changed paths: - M /trunk/gtk/io_stat.c - -The code for resizing the scrollbar page_size was a bit strange and did -some strange justifications when having high "tick values" in the graph. + M /trunk/epan/dissectors/packet-mac-lte.c -Simplified this to fix a problem with scrolling to X Axis zero and a -problem with interval values printed in the wrong time position. +Show backoff indicator value in subheader tree root. ------------------------------------------------------------------------ -r22646 | stig | 2007-08-24 15:22:34 -0700 (Fri, 24 Aug 2007) | 11 lines +r29245 | gerald | 2009-07-30 10:22:00 -0700 (Thu, 30 Jul 2009) | 2 lines Changed paths: - M /trunk/epan/dissectors/packet-isis-hello.c - M /trunk/epan/dissectors/packet-isis-hello.h - -From Todd J Martin: -- Decodes all valid Restart Signaling CLVs -- The restart flags are now shown in a tree and have display filters for them -- The Remaining hold time field now has a display filter -- The Restarting Neighbor Id field is now decoded -- Corrected another CLV decoder that assumed the length of a system ID was 6 - and hard coded that value instead of using the id_length variable - -Rearranged the Restart Signaling Flags to show the most significant bit first + M /trunk/epan/dissectors/packet-radius.c + M /trunk/epan/dissectors/packet-radius_packetcable.c +Remove a couple of unused variables. ------------------------------------------------------------------------ -r22647 | stig | 2007-08-24 15:42:08 -0700 (Fri, 24 Aug 2007) | 7 lines +r29246 | gerald | 2009-07-30 10:54:58 -0700 (Thu, 30 Jul 2009) | 8 lines Changed paths: - M /trunk/epan/dissectors/packet-dmp.c + M /trunk/epan/except.c + M /trunk/epan/except.h + +From Kovarththanan Rajaratnam via bug 3506: -- Added first version of DMP sequence analysis. -- Added some generated search fields. -- Added notice about negative ack in msg_type strings. -- Added some more expert infos. -- Rewrote alot of display filter names. -- Rewrote some hf_ values. +The exception throwing code in except.c/h should be annotated with +"noreturn" to indicate that they never return. Running static analysis +on Wireshark without this annotation causes a lot of false positives +since these analyzers assume that the exception handling code are +ordinary functions that will eventually return. ------------------------------------------------------------------------ -r22648 | stig | 2007-08-24 16:27:33 -0700 (Fri, 24 Aug 2007) | 2 lines +r29247 | etxrab | 2009-07-30 14:11:26 -0700 (Thu, 30 Jul 2009) | 2 lines Changed paths: - M /trunk/epan/dissectors/packet-p_mul.c - -Added expert info for length issues. + M /trunk/epan/dissectors/packet-gtpv2.c +From swapnil: +Packet-gtpv2.c dissector extended to support more IE's. ------------------------------------------------------------------------ -r22649 | stig | 2007-08-24 17:29:40 -0700 (Fri, 24 Aug 2007) | 19 lines +r29248 | guy | 2009-07-30 14:40:22 -0700 (Thu, 30 Jul 2009) | 7 lines Changed paths: - M /trunk/epan/dissectors/packet-cisco-erspan.c - -From Munenori Ohuchi: -1. Priority field decode. - The 802.1q tag field of a frame is separated from its frame body in - a ERSPAN packet. - Current packet-cisco-erspan.c decodes only the vlan id field of the - 802.1q tag. - This patch can also decode the priority field of the 802.1q tag. + M /trunk/epan/dissectors/packet-gtpv2.c -2. Direction of a captured frame decode. - A ERSPAN packet includes the additional information of the direction - a captured frame as below. +Fix warnings: - If a caputred frame comes from outside to a switch port, this means an - 'Incoming' frame. If a caputred frame goes out of a switch port, - this is an 'Outgoing' frame. - - -Added an extra unknown value for the bit between direction and spanid. - ------------------------------------------------------------------------- -r22650 | stig | 2007-08-24 17:50:20 -0700 (Fri, 24 Aug 2007) | 7 lines -Changed paths: - M /trunk/asn1/mpeg/packet-mpeg-pes-template.c - M /trunk/epan/dissectors/packet-mp2t.c - M /trunk/epan/dissectors/packet-mpeg-pes.c + the behavior of x = x++ is undefined by the ANSI C standard - + they obviously just meant x++; -From Shaun Jackman: - * asn1/mpeg/packet-mpeg-pes-template.c (proto_register_mpeg_pes): - Register the dissectors mpeg and mpeg-pes. - * epan/dissectors/packet-mp2t.c (dissect_tsp): Call the mpeg-pes - dissector. - (ett_mp2t_header, ett_mp2t_af): New subtree identifiers. + get rid of unused variables. ------------------------------------------------------------------------ -r22651 | lego | 2007-08-24 18:14:24 -0700 (Fri, 24 Aug 2007) | 3 lines +r29249 | gerald | 2009-07-30 16:47:36 -0700 (Thu, 30 Jul 2009) | 2 lines Changed paths: - M /trunk/asn1/acp133/packet-acp133-template.c M /trunk/asn1/acse/packet-acse-template.c - M /trunk/asn1/camel/packet-camel-template.c - M /trunk/asn1/cdt/packet-cdt-template.c - M /trunk/asn1/cmip/packet-cmip-template.c - M /trunk/asn1/cms/packet-cms-template.c - M /trunk/asn1/dap/packet-dap-template.c - M /trunk/asn1/disp/packet-disp-template.c M /trunk/asn1/dop/packet-dop-template.c M /trunk/asn1/dsp/packet-dsp-template.c M /trunk/asn1/ftam/packet-ftam-template.c - M /trunk/asn1/gsmmap/packet-gsm_map-template.c - M /trunk/asn1/h225/packet-h225-template.c - M /trunk/asn1/h235/packet-h235-template.c - M /trunk/asn1/h245/packet-h245-template.c - M /trunk/asn1/inap/packet-inap-template.c - M /trunk/asn1/ldap/packet-ldap-template.c - M /trunk/asn1/pkcs12/packet-pkcs12-template.c - M /trunk/asn1/pkixproxy/packet-pkixproxy-template.c - M /trunk/asn1/snmp/packet-snmp-template.c - M /trunk/asn1/tcap/packet-ansi_tcap-template.c - M /trunk/asn1/tcap/packet-tcap-template.c - M /trunk/asn1/wlancertextn/packet-wlancertextn-template.c - M /trunk/asn1/x411/packet-x411-template.c - M /trunk/asn1/x420/packet-x420-template.c - M /trunk/asn1/x509af/packet-x509af-template.c - M /trunk/asn1/x509if/packet-x509if-template.c - M /trunk/asn1/x509sat/packet-x509sat-template.c - M /trunk/epan/Makefile.common - M /trunk/epan/dissectors/Makefile.common - D /trunk/epan/dissectors/format-oid.h - M /trunk/epan/dissectors/packet-acp133.c - M /trunk/epan/dissectors/packet-acp133.h + M /trunk/asn1/goose/packet-goose-template.c M /trunk/epan/dissectors/packet-acse.c - M /trunk/epan/dissectors/packet-ansi_map.c - M /trunk/epan/dissectors/packet-ansi_map.h - M /trunk/epan/dissectors/packet-ansi_tcap.c - M /trunk/epan/dissectors/packet-ber.c - M /trunk/epan/dissectors/packet-camel.c - M /trunk/epan/dissectors/packet-camel.h - M /trunk/epan/dissectors/packet-cdt.c - M /trunk/epan/dissectors/packet-cmip.c - M /trunk/epan/dissectors/packet-cms.c - M /trunk/epan/dissectors/packet-cops.c - M /trunk/epan/dissectors/packet-dap.c - M /trunk/epan/dissectors/packet-disp.c M /trunk/epan/dissectors/packet-dop.c M /trunk/epan/dissectors/packet-dsp.c - M /trunk/epan/dissectors/packet-ess.c - M /trunk/epan/dissectors/packet-ess.h M /trunk/epan/dissectors/packet-ftam.c - M /trunk/epan/dissectors/packet-gnm.c - M /trunk/epan/dissectors/packet-gnm.h - M /trunk/epan/dissectors/packet-gsm_map.c - M /trunk/epan/dissectors/packet-h225.c - M /trunk/epan/dissectors/packet-h235.c - M /trunk/epan/dissectors/packet-h235.h - M /trunk/epan/dissectors/packet-h245.c - M /trunk/epan/dissectors/packet-h248.c - M /trunk/epan/dissectors/packet-h248.h - M /trunk/epan/dissectors/packet-inap.c - M /trunk/epan/dissectors/packet-inap.h - M /trunk/epan/dissectors/packet-ldap.c - M /trunk/epan/dissectors/packet-logotypecertextn.c - M /trunk/epan/dissectors/packet-logotypecertextn.h - M /trunk/epan/dissectors/packet-ns_cert_exts.c - M /trunk/epan/dissectors/packet-ocsp.c - M /trunk/epan/dissectors/packet-ocsp.h - M /trunk/epan/dissectors/packet-pkcs1.c - M /trunk/epan/dissectors/packet-pkcs1.h - M /trunk/epan/dissectors/packet-pkcs12.c - M /trunk/epan/dissectors/packet-pkinit.c - M /trunk/epan/dissectors/packet-pkinit.h - M /trunk/epan/dissectors/packet-pkixproxy.c - M /trunk/epan/dissectors/packet-pkixproxy.h - M /trunk/epan/dissectors/packet-pkixqualified.c - M /trunk/epan/dissectors/packet-pkixqualified.h - M /trunk/epan/dissectors/packet-pkixtsp.c - M /trunk/epan/dissectors/packet-pkixtsp.h - M /trunk/epan/dissectors/packet-pres.h - M /trunk/epan/dissectors/packet-rrc.c - M /trunk/epan/dissectors/packet-rrlp.c - M /trunk/epan/dissectors/packet-s4406.h - M /trunk/epan/dissectors/packet-smrse.c - M /trunk/epan/dissectors/packet-smrse.h - M /trunk/epan/dissectors/packet-snmp.c - M /trunk/epan/dissectors/packet-snmp.h - M /trunk/epan/dissectors/packet-spnego.c - M /trunk/epan/dissectors/packet-spnego.h - M /trunk/epan/dissectors/packet-tcap.c - M /trunk/epan/dissectors/packet-ulp.c - M /trunk/epan/dissectors/packet-wlancertextn.c - M /trunk/epan/dissectors/packet-wlancertextn.h - M /trunk/epan/dissectors/packet-x411.c - M /trunk/epan/dissectors/packet-x420.c - M /trunk/epan/dissectors/packet-x509af.c - M /trunk/epan/dissectors/packet-x509if.c - M /trunk/epan/dissectors/packet-x509sat.c - M /trunk/epan/epan.c - D /trunk/epan/oid_resolv.c - D /trunk/epan/oid_resolv.h - M /trunk/epan/oids.c - M /trunk/epan/oids.h - M /trunk/epan/proto.c - M /trunk/plugins/asn1/asn1.c - M /trunk/plugins/asn1/asn1.h - M /trunk/plugins/asn1/packet-asn1.c - -get users of oid_resolv to use the new oids, rollout packet-snmp.c + M /trunk/epan/dissectors/packet-goose.c + M /trunk/epan/dissectors/packet-wccp.c + M /trunk/epan/dissectors/packet-wcp.c + M /trunk/epan/dissectors/packet-windows-common.c + M /trunk/epan/dissectors/packet-winsrepl.c + M /trunk/epan/dissectors/packet-wlccp.c +Remove more unused variables. ------------------------------------------------------------------------ -r22652 | etxrab | 2007-08-25 00:44:01 -0700 (Sat, 25 Aug 2007) | 6 lines +r29250 | jake | 2009-07-30 23:51:27 -0700 (Thu, 30 Jul 2009) | 3 lines Changed paths: - M /trunk/epan/libwireshark.def - -Get rid of now unused: + M /trunk/epan/dissectors/packet-dns.c - add_oid_name - add_oid_str_name -l get_oid_name - get_oid_str_name ------------------------------------------------------------------------- -r22653 | etxrab | 2007-08-25 01:20:59 -0700 (Sat, 25 Aug 2007) | 2 lines -Changed paths: - M /trunk/gtk/io_stat.c +From Ivan Sy: +NAPTR RR (RFC 3403) replacement MUST be a fully qualified domain-name. -Cast as (gfloat) -io->scrollbar_adjustment->value=(gfloat)first_interval; ------------------------------------------------------------------------ -r22654 | jake | 2007-08-25 02:08:49 -0700 (Sat, 25 Aug 2007) | 4 lines +r29251 | sfisher | 2009-07-31 00:02:02 -0700 (Fri, 31 Jul 2009) | 5 lines Changed paths: - M /trunk/epan/dissectors/packet-ssl-utils.c + M /trunk/gtk/gui_utils.c -Partial fix for bug 1317: -Add Elliptic Curve cypher suites -Add extension types ------------------------------------------------------------------------- -r22655 | stig | 2007-08-25 02:57:12 -0700 (Sat, 25 Aug 2007) | 2 lines -Changed paths: - M /trunk/asn1/ftam/packet-ftam-template.c - M /trunk/epan/dissectors/packet-ftam.c +Include packet_info.h before ui_utils.h since we just started passing a +packet_info structure to one of the functions. -Removed duplicate entry of OID 1.0.8571.2.4 in FTAM ------------------------------------------------------------------------ -r22656 | lego | 2007-08-25 07:15:56 -0700 (Sat, 25 Aug 2007) | 4 lines +r29252 | jake | 2009-07-31 00:05:43 -0700 (Fri, 31 Jul 2009) | 3 lines Changed paths: - M /trunk/epan/oids.c - -Initialize to zero all subids in oid_string2subid() to avoid creating bogus oids. This is aspirin for a buffer overflow somewhere in the code that reads cretificates, that dimensions a buffer probably assumung oid subids are few digits while they can actually be bigger. -Place two DISSECTOR_ASSERT() guards to avoid an (I believe impossible) buffer overflow of the ep_allocated subid array in oid_string2subid() and oid_encoded2subid(). + M /trunk/epan/dissectors/packet-dns.c +From Ivan Sy: +Add support for SSHFP RR (RFC 4255). ------------------------------------------------------------------------ -r22657 | lego | 2007-08-25 07:48:48 -0700 (Sat, 25 Aug 2007) | 3 lines +r29253 | gerald | 2009-07-31 09:37:53 -0700 (Fri, 31 Jul 2009) | 7 lines Changed paths: - M /trunk/asn1/x411/packet-x411-template.c - M /trunk/epan/dissectors/packet-x411.c - -there's nothing like a MAX_OID_STR_LEN... get rid of a potential stack BO - + M /trunk/epan/dissectors/packet-dns.c ------------------------------------------------------------------------- -r22658 | lego | 2007-08-25 08:15:55 -0700 (Sat, 25 Aug 2007) | 4 lines -Changed paths: - M /trunk/trigcap.c +From Ivan Sy via bug 3797: -From Gisle Vanem <gvanem@broadpark.no> -Some signals needs to be ifdef'ed (missing on VC/MingW): +Support for SPF RR (RFC 4408) +- this has the same format as TXT RR (see section 3.1.1) below. +Currently wireshark 1.2.1 shows this as Unknown type 99 ------------------------------------------------------------------------ -r22659 | lego | 2007-08-25 10:29:55 -0700 (Sat, 25 Aug 2007) | 5 lines +r29254 | gerald | 2009-07-31 12:19:25 -0700 (Fri, 31 Jul 2009) | 14 lines Changed paths: - M /trunk/asn1/dop/packet-dop-template.c - M /trunk/asn1/rtse/packet-rtse-template.c - M /trunk/asn1/rtse/rtse.cnf - M /trunk/epan/dissectors/packet-ber.c - M /trunk/epan/dissectors/packet-dop.c - M /trunk/epan/dissectors/packet-per.c - M /trunk/epan/dissectors/packet-rtse.c - M /trunk/epan/ftypes/ftype-bytes.c - M /trunk/epan/oids.c - M /trunk/epan/oids.h - M /trunk/epan/to_str.c - M /trunk/epan/to_str.h - -replace oid_to_str_buf() and oid_to_str() - -fix a potential buffer overflow due to a very liberal estimate by oid_repr_len() - + M /trunk/epan/dissectors/Makefile.common + D /trunk/epan/dissectors/packet-gsm_abis_ip.c + A /trunk/epan/dissectors/packet-gsm_ipa.c (from /trunk/epan/dissectors/packet-gsm_abis_ip.c:29252) ------------------------------------------------------------------------- -r22660 | wmeier | 2007-08-25 12:13:00 -0700 (Sat, 25 Aug 2007) | 4 lines -Changed paths: - M /trunk/test/suite-capture.sh - M /trunk/test/suite-unittests.sh +From Holger Freyther via bug 3776: -Disable capture tests and unit tests until possible issues corrected. -Hopefully the windows buildbot will be OK with these tests disabled -temporarily. +Part 1: +Rename packet-gsm_abis_ip.c to packet-gsm_ipa.c. ------------------------------------------------------------------------- -r22661 | lego | 2007-08-25 13:27:58 -0700 (Sat, 25 Aug 2007) | 3 lines -Changed paths: - A /trunk/aclocal-fallback/libsmi.m4 - M /trunk/configure.in - M /trunk/epan/oids.c +Part 2: +Rename to the content to match the filename. -get libsmi into the picture +Part 3: +Add GSM A/SCCP support to the packet-gsm_ipa.c dissector +Adjusted patch to take laforge's comment into account. Use guint16 for the +length and use the ntohs routine to convert the length. ------------------------------------------------------------------------ -r22662 | lego | 2007-08-25 16:49:09 -0700 (Sat, 25 Aug 2007) | 4 lines +r29255 | guy | 2009-07-31 13:13:53 -0700 (Fri, 31 Jul 2009) | 4 lines Changed paths: - M /trunk/epan/oids.c - -Turns out that smiGetMinSize() and smiGetMaxSize() exists only in libsmi's HEAD... ;-) -Official releases do not have them yet, avoid using them. + M /trunk/epan/dissectors/packet-gtpv2.c +Completely remove an unused variable, don't just comment it out +(especially with a C++/C99-style comment that not all compilers used to +compile Wireshark accept). ------------------------------------------------------------------------ -r22663 | lego | 2007-08-25 20:11:27 -0700 (Sat, 25 Aug 2007) | 3 lines +r29256 | gerald | 2009-07-31 15:16:29 -0700 (Fri, 31 Jul 2009) | 10 lines Changed paths: - M /trunk/epan/libwireshark.def + M /trunk/epan/dissectors/Makefile.common + A /trunk/epan/dissectors/packet-usb-hid.c + A /trunk/epan/dissectors/packet-usb-hid.h + M /trunk/epan/dissectors/packet-usb.c -add the new oid_* functions +From Adam Nielsen via bug 3659: +Here is a patch against SVN that implements preliminary support for USB HID +devices. At the moment it only dissects the initial set up packets (which you +will see if you hotplug a keyboard or mouse.) ------------------------------------------------------------------------- -r22664 | etxrab | 2007-08-26 02:17:16 -0700 (Sun, 26 Aug 2007) | 1 line -Changed paths: - M /trunk/diameter/dictionary.xml +The patch also fixes a minor bug in the USB dissector code which reported +certain packets as malformed due to miscounting bytes, and it reports control +packet data and padding data in a more user-friendly manner. -Fix indentation ------------------------------------------------------------------------ -r22665 | stig | 2007-08-26 06:43:47 -0700 (Sun, 26 Aug 2007) | 4 lines +r29257 | guy | 2009-07-31 16:38:02 -0700 (Fri, 31 Jul 2009) | 3 lines Changed paths: - M /trunk/epan/dissectors/packet-ospf.c + M /trunk/epan/dissectors/packet-usb.c -From Todd J Martin: -- Added support for grace-LSA TLVs -- Fix a checksum that was printed in hex, but did not prepend "0x" +Fix indentation, get rid of a comment that might no longer apply (dump +*what* as hex? The stuff we now display as generic fields?). ------------------------------------------------------------------------ -r22666 | stig | 2007-08-26 07:02:59 -0700 (Sun, 26 Aug 2007) | 2 lines +r29258 | martinm | 2009-08-01 02:52:12 -0700 (Sat, 01 Aug 2009) | 2 lines Changed paths: - M /trunk/gtk/io_stat.c + M /trunk/epan/dissectors/packet-mac-lte.c -Added "Dot" as new style in IO Graph. +Remember Msg3 bytes and compare with Msg4 Contention Resolution bodies. ------------------------------------------------------------------------ -r22667 | stig | 2007-08-26 10:03:44 -0700 (Sun, 26 Aug 2007) | 2 lines +r29259 | jake | 2009-08-02 05:11:38 -0700 (Sun, 02 Aug 2009) | 3 lines Changed paths: - M /trunk/docbook/wsug_src/WSUG_chapter_statistics.xml + M /trunk/epan/dissectors/packet-rtcp.c -Added "Dot" as a new IO Graph style in the user guide. +Fix for bug 3800: +Correctly track the size of Feedback Control Information in Payload specific RTCP feedback packet. ------------------------------------------------------------------------ -r22668 | jmayer | 2007-08-26 10:58:26 -0700 (Sun, 26 Aug 2007) | 1 line +r29260 | jake | 2009-08-02 05:53:14 -0700 (Sun, 02 Aug 2009) | 2 lines Changed paths: - M /trunk/configure.in + M /trunk/epan/dissectors/packet-zrtp.c -libsmi: Small fix and add a comment ------------------------------------------------------------------------- -r22669 | jmayer | 2007-08-26 11:21:52 -0700 (Sun, 26 Aug 2007) | 1 line -Changed paths: - M /trunk/epan/dissectors/packet-isakmp.c +Add additional cypher types. -Isakmp runs over port 4500 (natt) as well ------------------------------------------------------------------------ -r22670 | jmayer | 2007-08-26 11:39:34 -0700 (Sun, 26 Aug 2007) | 4 lines +r29261 | wmeier | 2009-08-02 05:58:57 -0700 (Sun, 02 Aug 2009) | 2 lines Changed paths: - M /trunk/epan/dissectors/packet-isakmp.c + M /trunk/epan/dissectors/packet-usb-hid.c -Undo last commit. It's not yet clear to my why isakmp traffic -after nat-t isn't matched by a isakmp display filter, but this -approach wrong. +Remove unneeded #include <epan/emem.h>; fix some indentation. ------------------------------------------------------------------------ -r22671 | etxrab | 2007-08-26 12:17:03 -0700 (Sun, 26 Aug 2007) | 1 line +r29262 | gerald | 2009-08-02 08:03:29 -0700 (Sun, 02 Aug 2009) | 1 line Changed paths: - M /trunk/Makefile.nmake - M /trunk/config.nmake - -Download libsmi ------------------------------------------------------------------------- -r22672 | etxrab | 2007-08-26 13:03:23 -0700 (Sun, 26 Aug 2007) | 1 line -Changed paths: - M /trunk/Makefile.nmake - M /trunk/config.h.win32 - M /trunk/config.nmake + M /trunk/epan/enterprise-numbers + M /trunk/manuf -Use config and makefile from Chris Maynard and Luis instead. +[Automatic manuf and enterprise-numbers update for 2009-08-02] ------------------------------------------------------------------------ -r22673 | lego | 2007-08-26 13:16:35 -0700 (Sun, 26 Aug 2007) | 3 lines +r29265 | wmeier | 2009-08-02 12:09:36 -0700 (Sun, 02 Aug 2009) | 5 lines Changed paths: - M /trunk/epan/dissectors/packet-cops.c - -De-NET-SNMPize COPS + M /trunk/epan/dissectors/packet-http.c +Don't do dissector_add twice on TCP port 3689; +packet-daap requests registration on that port via http_dissector_add + and thus packet-http does not need to do a default registration on that port. +Also: fix a typo in a comment. ------------------------------------------------------------------------ -r22674 | etxrab | 2007-08-26 14:01:13 -0700 (Sun, 26 Aug 2007) | 1 line +r29266 | wmeier | 2009-08-02 12:17:09 -0700 (Sun, 02 Aug 2009) | 2 lines Changed paths: - M /trunk/config.nmake - M /trunk/version_info.c + M /trunk/epan/dissectors/packet-uma.c -Minor tweeks. ------------------------------------------------------------------------- -r22675 | etxrab | 2007-08-26 14:19:18 -0700 (Sun, 26 Aug 2007) | 1 line -Changed paths: - M /trunk/version_info.c +Change default range from 1401,1401 to 1401 so that the port isn't double-registered. -Fix a typo ------------------------------------------------------------------------ -r22676 | lego | 2007-08-26 14:35:17 -0700 (Sun, 26 Aug 2007) | 3 lines +r29267 | wmeier | 2009-08-02 12:20:20 -0700 (Sun, 02 Aug 2009) | 2 lines Changed paths: - M /trunk/Makefile.nmake - M /trunk/version_info.c - -libsmi was missing from the CFLAGS + M /trunk/epan/dissectors/packet-stun.c +packet-stun2 registers for TCP & UDP port 3478 so packet-stun need not register for same. ------------------------------------------------------------------------ -r22677 | lego | 2007-08-26 14:37:11 -0700 (Sun, 26 Aug 2007) | 4 lines +r29268 | wmeier | 2009-08-02 12:54:33 -0700 (Sun, 02 Aug 2009) | 2 lines Changed paths: - M /trunk/epan/oids.c - M /trunk/epan/oids.h - -Give the files its propper title -Keep libsmi's default path and append the user given one + M /trunk/epan/dissectors/packet-simulcrypt.c +Do dissector_add() only if port non-zero; register dissector for "decode-as". ------------------------------------------------------------------------ -r22678 | lego | 2007-08-26 14:38:09 -0700 (Sun, 26 Aug 2007) | 3 lines +r29269 | stig | 2009-08-03 01:05:44 -0700 (Mon, 03 Aug 2009) | 2 lines Changed paths: - M /trunk/epan/dissectors/packet-cops.c - -Remove every remembrance of NET_SNMP from COPS + M /trunk/epan/dissectors/packet-usb-hid.c +Handle usb_hid_item_usage_vals as range_string. ------------------------------------------------------------------------ -r22679 | lego | 2007-08-26 16:24:49 -0700 (Sun, 26 Aug 2007) | 4 lines +r29270 | stig | 2009-08-03 02:58:14 -0700 (Mon, 03 Aug 2009) | 2 lines Changed paths: - M /trunk/epan/Makefile.nmake - -This was missing - + M /trunk/epan/dissectors/Makefile.common +Added missing packet-usb-hid.h ------------------------------------------------------------------------ -r22680 | etxrab | 2007-08-26 23:28:20 -0700 (Sun, 26 Aug 2007) | 1 line +r29271 | wmeier | 2009-08-03 07:17:31 -0700 (Mon, 03 Aug 2009) | 2 lines Changed paths: - M /trunk/packaging/nsis/Makefile.nmake - M /trunk/packaging/nsis/wireshark.nsi + M /trunk/epan/dissectors/packet-frame.c + M /trunk/epan/dissectors/packet-ositp.c -Add SMI to the installation, the MIB:s are still missing. ------------------------------------------------------------------------- -r22681 | etxrab | 2007-08-26 23:40:36 -0700 (Sun, 26 Aug 2007) | 1 line -Changed paths: - M /trunk/packaging/nsis/wireshark.nsi +(Trivial) Fix two typos. -And now the MIB's ------------------------------------------------------------------------ -r22682 | stig | 2007-08-27 04:27:41 -0700 (Mon, 27 Aug 2007) | 2 lines +r29272 | wmeier | 2009-08-03 08:18:44 -0700 (Mon, 03 Aug 2009) | 2 lines Changed paths: - M /trunk/COPYING + M /trunk/epan/dissectors/packet-mip6.c -Removed ^L as they turn up as a strange square in About->License +Do find_dissector_table() in proto_reg_handoff(). ------------------------------------------------------------------------ -r22683 | stig | 2007-08-27 04:33:47 -0700 (Mon, 27 Aug 2007) | 2 lines +r29273 | wmeier | 2009-08-03 09:18:06 -0700 (Mon, 03 Aug 2009) | 3 lines Changed paths: - M /trunk/AUTHORS + M /trunk/plugins/mate/packet-mate.c -Adjusted indentation to align email addresses. +Use find_dissector() instead of create_dissector_handle(); +Fix some indentation. ------------------------------------------------------------------------ -r22684 | lego | 2007-08-27 10:05:11 -0700 (Mon, 27 Aug 2007) | 8 lines +r29274 | wmeier | 2009-08-03 09:21:55 -0700 (Mon, 03 Aug 2009) | 2 lines Changed paths: - M /trunk/asn1/snmp/packet-snmp-template.c - M /trunk/epan/dissectors/packet-snmp.c - M /trunk/epan/oids.c - M /trunk/epan/oids.h - -- packet-snmp(-template).c - - reimplement the "snmp.variable_oid" dissector table -- oids.[ch] - - get rid of keytype_implicit in oid_value_type_t we won't use it. - - have the windows base path for mibs be consistent to where we've put the mibs - - oid_get_from_encoded() and oid_get_from_string(): have the subids array being computed in a prior statement of where the side-effected argument is going to be used... worked on gcc, not on windows... I deserve "have daemons flying out of my nose" for that :-). + M /trunk/epan/dissectors/packet-rpcap.c +Reword some help text slightly. ------------------------------------------------------------------------ -r22685 | wmeier | 2007-08-27 10:49:53 -0700 (Mon, 27 Aug 2007) | 5 lines +r29275 | wmeier | 2009-08-03 10:25:17 -0700 (Mon, 03 Aug 2009) | 2 lines Changed paths: - M /trunk/test/config.sh + M /trunk/epan/packet.c -Prevent execution of the fifo tests on Windows. -(Windows cygwin has a mkfifo but Windows dumpcap & etc -use Windows named pipes which are different than -the cygwin named pipes). +Add some debug code (commented out) to check for duplicate dissector port registrations, ------------------------------------------------------------------------ -r22686 | wmeier | 2007-08-27 11:09:38 -0700 (Mon, 27 Aug 2007) | 3 lines +r29276 | wmeier | 2009-08-03 11:06:36 -0700 (Mon, 03 Aug 2009) | 2 lines Changed paths: - M /trunk/test/suite-unittests.sh + M /trunk/epan/packet.c -Re-enable unittests after determining that they work correctly -on Windows (and shouldn't cause the Windows buildbot any problems). +Remove 1 commented-out #include inadvertantly committed. ------------------------------------------------------------------------ -r22687 | guy | 2007-08-27 11:44:55 -0700 (Mon, 27 Aug 2007) | 3 lines +r29277 | jake | 2009-08-03 11:23:04 -0700 (Mon, 03 Aug 2009) | 2 lines Changed paths: - M /trunk/epan/oids.c - M /trunk/epan/oids.h - -Get rid of extra newlines at the end of epan/oids.h, and give one of -them to epan/oids.c. :-) + M /trunk/epan/dissectors/packet-dns.c +From Ivan Sy: +Support for Host Identity Protocol (HIP) Domain Name System (DNS) Extension. ------------------------------------------------------------------------ -r22688 | lego | 2007-08-27 12:14:30 -0700 (Mon, 27 Aug 2007) | 7 lines +r29278 | gerald | 2009-08-03 12:50:35 -0700 (Mon, 03 Aug 2009) | 2 lines Changed paths: - M /trunk/epan/oids.c - -Fixed an ep_ buffer overflow (off by one) in oid_subid2string() -Abort on integer overflow in oid_string2subid() and oid_encoded2subid() - - - + M /trunk/epan/dissectors/packet-sccp.c +Add a null pointer check. Remove some unused variables. ------------------------------------------------------------------------ -r22689 | lego | 2007-08-27 12:37:48 -0700 (Mon, 27 Aug 2007) | 3 lines +r29279 | guy | 2009-08-03 14:07:08 -0700 (Mon, 03 Aug 2009) | 2 lines Changed paths: - M /trunk/epan/oids.c - -cast a guint64 down to guint32 before assignment to get windows build running + M /trunk/epan/dissectors/packet-dns.c +Thou shalt terminate thy value_string arrays with {0, NULL}. ------------------------------------------------------------------------ -r22690 | etxrab | 2007-08-27 13:44:28 -0700 (Mon, 27 Aug 2007) | 1 line +r29280 | jake | 2009-08-03 14:12:41 -0700 (Mon, 03 Aug 2009) | 3 lines Changed paths: - M /trunk/diameter/dictionary.xml + M /trunk/epan/dissectors/packet-gsm_a_dtap.c + M /trunk/epan/dissectors/packet-q931.c -Update comments. +From Gerasimos Dimitriadis: +Added decoding support for the High Layer Compatibility IE in DTAP and updated +the relevant part in Q.931. Also some minor enhancements in Q.931. ------------------------------------------------------------------------ -r22691 | stig | 2007-08-27 14:23:18 -0700 (Mon, 27 Aug 2007) | 3 lines +r29281 | guy | 2009-08-03 14:17:30 -0700 (Mon, 03 Aug 2009) | 2 lines Changed paths: - M /trunk/epan/dissectors/packet-ieee80211.c - -From Tuomas Maattanen: -Committed changes in r21450 again. - ------------------------------------------------------------------------- -r22692 | lego | 2007-08-27 14:29:20 -0700 (Mon, 27 Aug 2007) | 3 lines -Changed paths: - M /trunk/epan/oids.c - -Do not throw, some of this functions get called outside TRY blocks. + M /trunk/epan/dissectors/packet-sccp.c +Clean up indentation somewhat. ------------------------------------------------------------------------ -r22693 | lego | 2007-08-27 15:00:39 -0700 (Mon, 27 Aug 2007) | 3 lines +r29282 | wmeier | 2009-08-03 15:09:08 -0700 (Mon, 03 Aug 2009) | 9 lines Changed paths: - A /trunk/smi_modules - -Add a default smi_modules file. + M /trunk/plugins/m2m/packet-m2m.c +Various minor cleanups: +- Do all find_dissector() calls only once during proto_reg_handoff + (not each time a sub-dissector is called when dissecting frames). +- Move proto_register & proto_reg_handoff to the end of the file as per convention; +- Move a global variables to be local; +- Change a global variable to be static; +- Remove unneeded multiple #include <string.h> +- Remove an unneeded variable and a few unneeded lines of code. ------------------------------------------------------------------------ -r22694 | lego | 2007-08-27 15:06:47 -0700 (Mon, 27 Aug 2007) | 3 lines +r29283 | wmeier | 2009-08-03 15:38:43 -0700 (Mon, 03 Aug 2009) | 9 lines Changed paths: - M /trunk/Makefile.am - M /trunk/Makefile.nmake - M /trunk/packaging/nsis/wireshark.nsi - -Get smi_modules in the distrib + M /trunk/plugins/wimax/packet-wmx.c +Minor cleanups: +- Comment out code which creates two dissector tables and then + stores a preference value in each of them; + AFAICT the tables are not accessed elsewhere; +- Comment out the no longer required prefs callback specification + in proto_register; +- "if (... == -1)" not req'd in proto_register; +- Remove unused proto_reg_wimax function. ------------------------------------------------------------------------ -r22695 | lego | 2007-08-27 15:24:39 -0700 (Mon, 27 Aug 2007) | 3 lines +r29284 | wmeier | 2009-08-03 16:18:59 -0700 (Mon, 03 Aug 2009) | 5 lines Changed paths: - M /trunk/smi_modules - -Wes Hardaker refered to net-snmp defaults, It does not apply to this at all. + M /trunk/plugins/wimax/packet-wmx.c +More minor cleanups: +- Move proto_register to near the end of the file as per convention; +- Remove unneeded #include <epan/reassemble.h>; +- Comment out unused ett[] array and associated; ------------------------------------------------------------------------ -r22696 | wmeier | 2007-08-27 15:56:27 -0700 (Mon, 27 Aug 2007) | 2 lines +r29285 | gerald | 2009-08-03 16:49:05 -0700 (Mon, 03 Aug 2009) | 2 lines Changed paths: - M /trunk/plugins/agentx/Makefile.nmake - M /trunk/plugins/artnet/Makefile.nmake - M /trunk/plugins/asn1/Makefile.nmake - M /trunk/plugins/ciscosm/Makefile.nmake - M /trunk/plugins/docsis/Makefile.nmake - M /trunk/plugins/enttec/Makefile.nmake - M /trunk/plugins/gryphon/Makefile.nmake - M /trunk/plugins/irda/Makefile.nmake - M /trunk/plugins/lwres/Makefile.nmake - M /trunk/plugins/m2m/Makefile.nmake - M /trunk/plugins/mate/Makefile.nmake - M /trunk/plugins/mgcp/Makefile.nmake - M /trunk/plugins/opcua/Makefile.nmake - M /trunk/plugins/opsi/Makefile.nmake - M /trunk/plugins/pcli/Makefile.nmake - M /trunk/plugins/profinet/Makefile.nmake - M /trunk/plugins/rlm/Makefile.nmake - M /trunk/plugins/rtnet/Makefile.nmake - M /trunk/plugins/rudp/Makefile.nmake - M /trunk/plugins/sbus/Makefile.nmake - M /trunk/plugins/unistim/Makefile.nmake - M /trunk/plugins/v5ua/Makefile.nmake - M /trunk/plugins/wimax/Makefile.nmake + M /trunk/gtk/compare_stat.c + M /trunk/plugins/asn1/packet-asn1.c -Add .c.obj:: inference rule (to cause "batch compile") +Add some null checks. ------------------------------------------------------------------------ -r22697 | sfisher | 2007-08-27 19:13:51 -0700 (Mon, 27 Aug 2007) | 6 lines +r29286 | gerald | 2009-08-03 16:50:55 -0700 (Mon, 03 Aug 2009) | 2 lines Changed paths: - M /trunk/capture_ui_utils.c - - -Fix for bug #1801 (http://bugs.wireshark.org/bugzilla/show_bug.cgi?id=1801) - -Don't get to the point where we may do a strcmp() with a null value. + M /trunk/plugins/profinet/packet-dcerpc-pn-io.c +Remove a couple of unused variables. ------------------------------------------------------------------------ -r22698 | etxrab | 2007-08-27 22:53:13 -0700 (Mon, 27 Aug 2007) | 1 line +r29287 | gerald | 2009-08-03 16:51:13 -0700 (Mon, 03 Aug 2009) | 2 lines Changed paths: - M /trunk/smi_modules + M /trunk/asn1/cmip/packet-cmip-template.c + M /trunk/epan/dissectors/packet-cmip.c -Temporray remove "SNMP-REPEATER-MIB" it causes a crash. ------------------------------------------------------------------------- -r22699 | jake | 2007-08-27 22:59:09 -0700 (Mon, 27 Aug 2007) | 1 line -Changed paths: - M /trunk/epan/oids.c +Rework an assignment to keep static analyzers from complaining. -Fix warnings "dereferencing type-punned pointer will break strict-aliasing rules" ------------------------------------------------------------------------ -r22700 | sahlberg | 2007-08-28 00:34:05 -0700 (Tue, 28 Aug 2007) | 4 lines +r29288 | gerald | 2009-08-03 17:35:30 -0700 (Mon, 03 Aug 2009) | 2 lines Changed paths: - M /trunk/epan/dissectors/packet-ctdb.c - -improve the ctdb dissector to track request/responses for controls and -start decoding some control payload + M /trunk/make-version.pl +Don't exit with an error if we can't find the svn executable. ------------------------------------------------------------------------ -r22701 | kukosa | 2007-08-28 00:59:35 -0700 (Tue, 28 Aug 2007) | 1 line +r29289 | jmayer | 2009-08-04 00:50:49 -0700 (Tue, 04 Aug 2009) | 1 line Changed paths: - M /trunk/asn1/snmp/packet-snmp-template.c - M /trunk/epan/dissectors/packet-snmp.c + M /trunk/epan/proto.h -fix bug in snmp.variable_oid subdissector calling and call them at the end of snmp dissector (so as snmp does not overwrite COL_INFO of subdissector) +Warning fix: comma at end of enum ------------------------------------------------------------------------ -r22702 | jmayer | 2007-08-28 03:37:21 -0700 (Tue, 28 Aug 2007) | 3 lines +r29290 | martinm | 2009-08-04 03:41:08 -0700 (Tue, 04 Aug 2009) | 2 lines Changed paths: - M /trunk/plugins/unistim/packet-unistim.c + M /trunk/epan/dissectors/packet-rlc-lte.c -Disable unistim for now: it used port 5000 unconditionally -and that collied with tapa. Please add a check. +Show number of predefined bytes in info column. ------------------------------------------------------------------------ -r22703 | sahlberg | 2007-08-28 04:45:08 -0700 (Tue, 28 Aug 2007) | 22 lines +r29291 | gerald | 2009-08-04 10:59:48 -0700 (Tue, 04 Aug 2009) | 2 lines Changed paths: - M /trunk/epan/dissectors/packet-dcerpc-lsa.c - M /trunk/epan/dissectors/packet-dcerpc-nt.c - M /trunk/epan/dissectors/packet-dcerpc-nt.h - M /trunk/epan/dissectors/packet-dcerpc-samr.c - M /trunk/epan/dissectors/packet-dcerpc-spoolss.c - M /trunk/epan/dissectors/packet-dcerpc-svcctl.c - M /trunk/epan/dissectors/packet-dcerpc.c - M /trunk/epan/dissectors/packet-dcerpc.h - M /trunk/epan/dissectors/packet-smb-sidsnooping.c - M /trunk/epan/dissectors/packet-smb2.c - M /trunk/epan/dissectors/pidl/samr.cnf - -rename dcerpc_smb_store_pol_name to dcerpc_store_polhnd_name - -rename dcerpc_smb_fetch_pol to dcerpc_fetch_polhnd_data and also make -it take an additional parameter to return the "type" of the policy -handle, if such a type was stored. - -extend the pol_value structure used to track policy handles to also -store a type to represent what created the policy handle -types could be USER/ALIAS/CONNECT/... etc handles returned from the -SAMR interface - -add a new helper function dcerpc_store_polhnd_type() - -track policy handles between request/responses for dcerpc - -update the samr.cnf file to make the samr dissectors for -SetSecurity/QuerySecurity dissect the specific bits for the security -descriptor correctly based on whether the policy handle refers to a -CONNECT/DOMAIN/USER/ALIAS or GROUP - + M /trunk/epan/dissectors/packet-pop.c +Miscellaneous cleanups. ------------------------------------------------------------------------ -r22704 | lego | 2007-08-28 08:18:32 -0700 (Tue, 28 Aug 2007) | 10 lines +r29292 | guy | 2009-08-04 11:39:43 -0700 (Tue, 04 Aug 2009) | 5 lines Changed paths: - M /trunk/asn1/snmp/packet-snmp-template.c - M /trunk/epan/dissectors/packet-snmp.c - M /trunk/epan/emem.c - M /trunk/epan/oids.c - M /trunk/epan/uat-int.h - M /trunk/epan/uat.c - M /trunk/epan/uat.h - -SNMP: - - As noted by Thomas Anders values are not added to the tree anymore. Move the calling of subdissectors to the end of the function, so that the value is added to the tree. - - add port 8161 to be decoded as SNMP (hey, it's on IANA's services file!) -UAT: - - do not have the uat reloaded. -OIDS: - - do not complain if renaming an OID to an identical name + M /trunk/epan/dissectors/packet-pop.c +Clean up white space a bit - use 2-space indenting. +Put a bunch of code that does nothing unless data_val is non-null inside +"if (data_val)", and get rid of the individual tests. ------------------------------------------------------------------------ -r22705 | lego | 2007-08-28 08:38:05 -0700 (Tue, 28 Aug 2007) | 3 lines +r29293 | wmeier | 2009-08-04 11:46:51 -0700 (Tue, 04 Aug 2009) | 2 lines Changed paths: - M /trunk/epan/uat.c - M /trunk/epan/uat_load.l - -Commit canges to uat_load.l, and initialize uat_t->loaded (not every system zeroes-out on malloc). + M /trunk/epan/dissectors/packet-fcels.c + M /trunk/epan/dissectors/packet-rsl.c +Remove duplicate entry from ett[] ------------------------------------------------------------------------ -r22706 | ulfl | 2007-08-28 10:38:50 -0700 (Tue, 28 Aug 2007) | 1 line +r29294 | wmeier | 2009-08-04 11:48:45 -0700 (Tue, 04 Aug 2009) | 2 lines Changed paths: - M /trunk/docbook/wsdg_src/WSDG_chapter_quick_setup.xml + M /trunk/epan/dissectors/ncp2222.py + M /trunk/epan/dissectors/packet-ansi_801.c + M /trunk/epan/dissectors/packet-cimd.c + M /trunk/epan/dissectors/packet-dcerpc-spoolss.c + M /trunk/epan/dissectors/packet-dis-pdus.c + M /trunk/epan/dissectors/packet-rsvp.c + +Init ett_... variables to -1 -move "create guides" section above installer section as the installer might need the user's guide ------------------------------------------------------------------------ -r22707 | wmeier | 2007-08-28 10:47:39 -0700 (Tue, 28 Aug 2007) | 3 lines +r29295 | wmeier | 2009-08-04 11:52:01 -0700 (Tue, 04 Aug 2009) | 2 lines Changed paths: - M /trunk/capture_opts.c + M /trunk/asn1/spnego/packet-spnego-template.c + M /trunk/epan/dissectors/packet-spnego.c + M /trunk/epan/dissectors/packet-spnego.h -capture_opts_log: use dummy string if iface_desc is NULL; -This fixes dumpcap crash on Windows +Initialize several ett_... variables to -1 ------------------------------------------------------------------------ -r22708 | wmeier | 2007-08-28 10:49:16 -0700 (Tue, 28 Aug 2007) | 2 lines +r29296 | wmeier | 2009-08-04 12:01:34 -0700 (Tue, 04 Aug 2009) | 7 lines Changed paths: - M /trunk/test/suite-capture.sh + M /trunk/plugins/wimax/mac_hd_generic_decoder.c + M /trunk/plugins/wimax/mac_hd_type1_decoder.c + M /trunk/plugins/wimax/mac_hd_type2_decoder.c + M /trunk/plugins/wimax/mac_mgmt_msg_decoder.c + M /trunk/plugins/wimax/msg_aas_beam.c + M /trunk/plugins/wimax/msg_aas_fbck.c + M /trunk/plugins/wimax/msg_clk_cmp.c + M /trunk/plugins/wimax/msg_dcd.c + M /trunk/plugins/wimax/msg_dlmap.c + M /trunk/plugins/wimax/msg_dsa.c + M /trunk/plugins/wimax/msg_dsc.c + M /trunk/plugins/wimax/msg_dsd.c + M /trunk/plugins/wimax/msg_dsx_rvd.c + M /trunk/plugins/wimax/msg_fpc.c + M /trunk/plugins/wimax/msg_pkm.c + M /trunk/plugins/wimax/msg_prc_lt_ctrl.c + M /trunk/plugins/wimax/msg_reg_req.c + M /trunk/plugins/wimax/msg_reg_rsp.c + M /trunk/plugins/wimax/msg_rep.c + M /trunk/plugins/wimax/msg_res_cmd.c + M /trunk/plugins/wimax/msg_rng_req.c + M /trunk/plugins/wimax/msg_rng_rsp.c + M /trunk/plugins/wimax/msg_sbc.c + M /trunk/plugins/wimax/msg_ucd.c + M /trunk/plugins/wimax/msg_ulmap.c + M /trunk/plugins/wimax/packet-wmx.c + M /trunk/plugins/wimax/wimax_cdma_code_decoder.c + M /trunk/plugins/wimax/wimax_compact_dlmap_ie_decoder.c + M /trunk/plugins/wimax/wimax_compact_ulmap_ie_decoder.c + M /trunk/plugins/wimax/wimax_fch_decoder.c + M /trunk/plugins/wimax/wimax_ffb_decoder.c + M /trunk/plugins/wimax/wimax_hack_decoder.c + M /trunk/plugins/wimax/wimax_harq_map_decoder.c + M /trunk/plugins/wimax/wimax_pdu_decoder.c + M /trunk/plugins/wimax/wimax_phy_attributes_decoder.c + +Minor changes: +- Move proto_register...() to the end of the file as per convention; +- Move ett[] to be local to proto_register...(); +- "if (...==-1)" not req'd in proto_register...(); +- #include <moduleinfo.h> not req'd; +- Remove unneeded forward declarations. + +------------------------------------------------------------------------ +r29297 | wmeier | 2009-08-04 12:29:42 -0700 (Tue, 04 Aug 2009) | 2 lines +Changed paths: + M /trunk/epan/dissectors/packet-chdlc.c + +Fix benign double subtree registration of an ett_... variable. + +------------------------------------------------------------------------ +r29298 | jake | 2009-08-04 14:05:38 -0700 (Tue, 04 Aug 2009) | 1 line +Changed paths: + M /trunk/epan/dissectors/packet-gsm_a_bssmap.c + M /trunk/epan/dissectors/packet-gsm_a_common.h + M /trunk/epan/dissectors/packet-gsm_a_dtap.c + M /trunk/epan/dissectors/packet-gsm_a_gm.c + M /trunk/epan/dissectors/packet-gsm_a_rp.c + M /trunk/epan/dissectors/packet-gsm_a_rr.c + M /trunk/epan/dissectors/packet-gsm_bsslap.c + M /trunk/epan/dissectors/packet-gsm_bssmap_le.c + +Optimize empty strings to NULL pointers. +------------------------------------------------------------------------ +r29299 | guy | 2009-08-04 16:14:40 -0700 (Tue, 04 Aug 2009) | 4 lines +Changed paths: + M /trunk/plugins/wimax/msg_dsa.c + M /trunk/plugins/wimax/msg_dsc.c + M /trunk/plugins/wimax/msg_dsd.c + +Put the initializers for the elements of value_string arrays into curly +brackets, so the API checks for non-terminated value_string arrays will +not falsely think the arrays are non-terminated. + +------------------------------------------------------------------------ +r29300 | guy | 2009-08-04 17:13:38 -0700 (Tue, 04 Aug 2009) | 2 lines +Changed paths: + M /trunk/plugins/wimax/msg_dsc.c -Re-enable capture tests now that a a dumpcap problem has been corrected. +Fix typo. ------------------------------------------------------------------------ -r22709 | etxrab | 2007-08-28 10:50:02 -0700 (Tue, 28 Aug 2007) | 1 line +r29301 | gerald | 2009-08-04 17:36:27 -0700 (Tue, 04 Aug 2009) | 2 lines Changed paths: - M /trunk/epan/dissectors/packet-dpnss.c + M /trunk/asn1/h225/packet-h225-template.c + M /trunk/epan/dissectors/packet-h225.c -Add filters. ------------------------------------------------------------------------- -r22710 | ulfl | 2007-08-28 10:50:25 -0700 (Tue, 28 Aug 2007) | 1 line -Changed paths: - M /trunk/docbook/wsdg_src/WSDG_chapter_quick_setup.xml +Add a couple of pointer checks. -some more editing ------------------------------------------------------------------------ -r22711 | etxrab | 2007-08-28 10:50:44 -0700 (Tue, 28 Aug 2007) | 1 line +r29302 | jake | 2009-08-05 00:33:44 -0700 (Wed, 05 Aug 2009) | 3 lines Changed paths: - M /trunk/diameter/dictionary.xml + M /trunk/epan/dissectors/packet-ieee80211.c + +Fix for bug 3806: +Add presentation of Block Ack Bitmap. -Add AVP's ------------------------------------------------------------------------ -r22712 | lego | 2007-08-28 12:07:39 -0700 (Tue, 28 Aug 2007) | 3 lines +r29303 | martinm | 2009-08-05 01:02:12 -0700 (Wed, 05 Aug 2009) | 2 lines Changed paths: - M /trunk/epan/oids.c - -Report loading failures to the user + M /trunk/epan/dissectors/packet-mac-lte.c +Show power headroom report inside its own subtree. ------------------------------------------------------------------------ -r22713 | lego | 2007-08-28 12:11:36 -0700 (Tue, 28 Aug 2007) | 3 lines +r29304 | gerald | 2009-08-05 08:39:29 -0700 (Wed, 05 Aug 2009) | 2 lines Changed paths: - M /trunk/smi_modules - -remove (for now) the COPS PIBs from the list, as I have added a reprot_failure to give feedback about libsmi errors while loading the modules. + M /trunk/gtk/wlan_stat_dlg.c + M /trunk/tap-iostat.c +Squelch a couple of Clang Static Analyzer warnings. ------------------------------------------------------------------------ -r22714 | ulfl | 2007-08-28 13:31:48 -0700 (Tue, 28 Aug 2007) | 1 line +r29305 | jake | 2009-08-05 11:17:18 -0700 (Wed, 05 Aug 2009) | 3 lines Changed paths: - M /trunk/Makefile.nmake - M /trunk/config.nmake + M /trunk/epan/dissectors/packet-dns.c + +From Ivan Sy: +Add support for Support for DHCID RR (RFC 4701). -always compile zlib.dll from source (even on MSVC6 now), this simplifies the makefiles a bit and (more important) removes an annoying behaviour if you switch between compiler versions - you'll need to run the setup target each time you switch ------------------------------------------------------------------------ -r22715 | wmeier | 2007-08-28 13:58:50 -0700 (Tue, 28 Aug 2007) | 3 lines +r29306 | jake | 2009-08-05 11:21:52 -0700 (Wed, 05 Aug 2009) | 3 lines Changed paths: - M /trunk/colorfilters - M /trunk/epan/dissectors/packet-ip.c + M /trunk/epan/dissectors/packet-wbxml.c -From Todd Martin: "Flag IP TTL more intelligently". -Also: Change default "Low TTL" color filter to match. +Fix for bug 3811: +Add missing shorthand application/vnd.ms-sync besides application/vnd.ms-sync.wbxml. ------------------------------------------------------------------------ -r22716 | ulfl | 2007-08-28 14:21:25 -0700 (Tue, 28 Aug 2007) | 1 line +r29307 | jake | 2009-08-05 11:42:45 -0700 (Wed, 05 Aug 2009) | 3 lines Changed paths: - M /trunk/docbook/wsug_src/WSUG_chapter_work.xml + M /trunk/epan/dissectors/packet-gsm_a_common.c -add "Classless InterDomain Routing (CIDR) notation" explanation to the display filter section +From Gerasimos Dimitriadis: +Fixes/enhances the decoding of the Mobile Identity IE for type of identity +"TMGI and optional MBMS Session Identity". ------------------------------------------------------------------------ -r22717 | wmeier | 2007-08-28 14:24:34 -0700 (Tue, 28 Aug 2007) | 2 lines +r29308 | gerald | 2009-08-05 12:03:48 -0700 (Wed, 05 Aug 2009) | 3 lines Changed paths: - M /trunk/colorfilters + M /trunk/epan/dissectors/packet-p_mul.c -On 2nd thought: change color filter name from "Low TTL" to "TTL low or unexpected" +Convert a GString to an ep_strbuf_t (and squelch a static analysis +warning in the process). Remove an unused variable. ------------------------------------------------------------------------ -r22718 | lego | 2007-08-28 14:27:54 -0700 (Tue, 28 Aug 2007) | 3 lines +r29309 | wmeier | 2009-08-06 09:06:11 -0700 (Thu, 06 Aug 2009) | 2 lines Changed paths: - M /trunk/asn1/snmp/packet-snmp-template.c - M /trunk/epan/dissectors/packet-snmp.c - -Fix non implicit oid key indexes. This starts to look good! + M /trunk/epan/dissectors/packet-gsm_a_rr.c +Register ett[] subtree array only once. ------------------------------------------------------------------------ -r22719 | lego | 2007-08-28 16:19:30 -0700 (Tue, 28 Aug 2007) | 4 lines +r29310 | wmeier | 2009-08-06 09:10:29 -0700 (Thu, 06 Aug 2009) | 2 lines Changed paths: - M /trunk/asn1/snmp/packet-snmp-template.c - M /trunk/asn1/snmp/snmp.cnf - -Add some more expert info. -Restore engine-id dissection (a "victim" of decryption support) + M /trunk/epan/dissectors/packet-ieee8021ah.c +Register ett[] subtree array only once. ------------------------------------------------------------------------ -r22720 | lego | 2007-08-28 16:55:49 -0700 (Tue, 28 Aug 2007) | 5 lines +r29311 | wmeier | 2009-08-06 09:13:31 -0700 (Thu, 06 Aug 2009) | 2 lines Changed paths: - M /trunk/asn1/snmp/snmp.asn - M /trunk/asn1/snmp/snmp.cnf - M /trunk/epan/dissectors/packet-snmp.c - M /trunk/epan/oids.c - -- turn some other TC from FT_BYTES to FT_STRING so that human-readable strings become readable by humans -- Add the EngineId decoding for the contextEngineId -- Add some expert info about malformed indexed oids + M /trunk/epan/dissectors/packet-gsm_a_rr.c +Remove inadvertantly committed comments re issue yet to be fixed ... ------------------------------------------------------------------------ -r22721 | ulfl | 2007-08-28 17:15:15 -0700 (Tue, 28 Aug 2007) | 1 line +r29312 | wmeier | 2009-08-06 11:44:38 -0700 (Thu, 06 Aug 2009) | 2 lines Changed paths: - M /trunk/docbook/wsdg_src/WSDG_chapter_quick_setup.xml - M /trunk/docbook/wsdg_src/WSDG_chapter_tools.xml + M /trunk/epan/dissectors/packet-gsm_a_rr.c -various updates to match current MSVC compiler problems, fix some typos, ... ------------------------------------------------------------------------- -r22722 | ulfl | 2007-08-28 20:45:56 -0700 (Tue, 28 Aug 2007) | 1 line -Changed paths: - M /trunk/docbook/wsug_src/WSUG_chapter_work.xml +Prevent possible (benign ?) array references with an array index of -1. -fix broken tags ------------------------------------------------------------------------ -r22723 | etxrab | 2007-08-28 23:13:40 -0700 (Tue, 28 Aug 2007) | 1 line +r29313 | gerald | 2009-08-06 13:55:04 -0700 (Thu, 06 Aug 2009) | 3 lines Changed paths: - M /trunk/asn1/gsmmap/gsm_map-exp.cnf - M /trunk/asn1/gsmmap/packet-gsm_map-template.c - M /trunk/epan/dissectors/packet-gsm_map.c - M /trunk/epan/dissectors/packet-gsm_map.h + M /trunk/epan/dissectors/Makefile.common + M /trunk/epan/dissectors/packet-isakmp.c + M /trunk/epan/dissectors/packet-k12.c + M /trunk/epan/dissectors/packet-sccp.c + M /trunk/epan/dissectors/packet-user_encap.c -Fix up most of the OID names in GSM MAP. ------------------------------------------------------------------------- -r22724 | kukosa | 2007-08-29 04:44:49 -0700 (Wed, 29 Aug 2007) | 2 lines -Changed paths: - M /trunk/epan/asn1.c - M /trunk/epan/asn1.h +Fix compilation warnings in a few dissectors and try moving them to the +"clean" list. -ASN.1 parameterization handling (1st raw implementation) -it is not supported in asn2wrs now, code has to be written manually ------------------------------------------------------------------------ -r22725 | kukosa | 2007-08-29 04:47:35 -0700 (Wed, 29 Aug 2007) | 1 line +r29314 | wmeier | 2009-08-06 14:42:40 -0700 (Thu, 06 Aug 2009) | 2 lines Changed paths: - M /trunk/tools/asn2wrs.py + M /trunk/epan/dissectors/packet-gsm_a_common.c -new directive #.ASSIGN_VALUE_TO_TYPE ------------------------------------------------------------------------- -r22726 | kukosa | 2007-08-29 04:57:27 -0700 (Wed, 29 Aug 2007) | 1 line -Changed paths: - M /trunk/asn1/Makefile.am - M /trunk/asn1/ranap/Makefile - M /trunk/asn1/ranap/Makefile.nmake - M /trunk/asn1/ranap/RANAP-CommonDataTypes.asn - M /trunk/asn1/ranap/RANAP-Constants.asn - M /trunk/asn1/ranap/RANAP-Containers.asn - M /trunk/asn1/ranap/RANAP-IEs.asn - M /trunk/asn1/ranap/RANAP-PDU-Contents.asn - M /trunk/asn1/ranap/RANAP-PDU-Descriptions.asn - M /trunk/asn1/ranap/packet-ranap-template.c - D /trunk/asn1/ranap/ranap.asn - M /trunk/asn1/ranap/ranap.cnf - M /trunk/epan/dissectors/packet-ranap.c - M /trunk/epan/dissectors/packet-ranap.h +Fix some indentation and spacing -RANAP rewritten to use original ASN.1 source and updated to TS 25.413 V7.6.0 (2007-06) ------------------------------------------------------------------------ -r22727 | martinm | 2007-08-29 08:35:27 -0700 (Wed, 29 Aug 2007) | 2 lines +r29315 | tuexen | 2009-08-06 14:55:10 -0700 (Thu, 06 Aug 2009) | 2 lines Changed paths: - M /trunk/epan/dissectors/packet-ip.c + M /trunk/epan/dissectors/packet-isakmp.c -Don't show fragment offset as a bit field, but note number of bits used in long text. +Get it compiling when HAVE_LIBGCRYPT is not defined. ------------------------------------------------------------------------ -r22728 | etxrab | 2007-08-29 09:10:04 -0700 (Wed, 29 Aug 2007) | 1 line +r29316 | stig | 2009-08-06 15:06:37 -0700 (Thu, 06 Aug 2009) | 3 lines Changed paths: - M /trunk/diameter/TGPPSh.xml - M /trunk/diameter/dictionary.xml + M /trunk/gtk/font_utils.c + M /trunk/gtk/main.c + M /trunk/gtk/new_packet_list.c + M /trunk/gtk/new_packet_list.h -Adjust to the latest IANA status 2007-08-22. ------------------------------------------------------------------------- -r22729 | etxrab | 2007-08-29 09:10:47 -0700 (Wed, 29 Aug 2007) | 1 line -Changed paths: - M /trunk/asn1/camel/camel.cnf - M /trunk/asn1/camel/packet-camel-template.c - M /trunk/asn1/gsmmap/gsmmap.cnf - M /trunk/asn1/gsmmap/packet-gsm_map-template.c - M /trunk/epan/dissectors/packet-camel.c - M /trunk/epan/dissectors/packet-gsm_map.c +Added new_packet_list_set_font() and initialize fonts when using +new packet list. -OID name fixes. ------------------------------------------------------------------------ -r22730 | stig | 2007-08-29 11:39:30 -0700 (Wed, 29 Aug 2007) | 7 lines +r29317 | tuexen | 2009-08-06 15:26:05 -0700 (Thu, 06 Aug 2009) | 2 lines Changed paths: - M /trunk/asn1/x411/packet-x411-template.c - M /trunk/asn1/x411/x411.asn - M /trunk/asn1/x411/x411.cnf - M /trunk/epan/dissectors/packet-x411.c + M /trunk/epan/dissectors/Makefile.common -- Rewrote handling of extensions to get rid of "funky" oid strings. -- Added ASN.1 integer values for StandardExtension, ExtensionAttributeType - and TokenDataType. -- Added expert info for unknown standard-extension, extension-attribute-type - and tokendata-type. -- Added expert info for unknown built-in content-type. +packet-sctp.c seems to be clean (at least it is on Mac OS X). ------------------------------------------------------------------------ -r22731 | etxrab | 2007-08-29 12:31:15 -0700 (Wed, 29 Aug 2007) | 2 lines +r29318 | guy | 2009-08-06 16:26:24 -0700 (Thu, 06 Aug 2009) | 4 lines Changed paths: - M /trunk/asn1/Makefile.am - D /trunk/asn1/inap/IN-CS-1-Datatypes-appendix.asn - D /trunk/asn1/inap/IN-CS-1-Datatypes.asn + M /trunk/epan/dissectors/packet-sctp.c -Makefile.am Try to get the latest state of asn1 files into the dist. -Delete "old" unused asn1 files. ------------------------------------------------------------------------- -r22732 | etxrab | 2007-08-29 15:21:25 -0700 (Wed, 29 Aug 2007) | 2 lines -Changed paths: - M /trunk/asn1/Makefile.am +Those items are 32 bits or longer, so the cast should be safe; add an +additional cast in the hopes that they squelch "dereferencing +type-punned pointer" warnings. -Makefile.am Try to get the latest state of asn1 files into the dist. -Try again ;) ------------------------------------------------------------------------ -r22733 | gerald | 2007-08-29 17:24:40 -0700 (Wed, 29 Aug 2007) | 7 lines +r29319 | wmeier | 2009-08-06 16:47:21 -0700 (Thu, 06 Aug 2009) | 5 lines Changed paths: - M /trunk/Makefile.am - M /trunk/capture_loop.c - M /trunk/capture_opts.c - M /trunk/capture_opts.h - M /trunk/configure.in - M /trunk/doc/README.packaging - M /trunk/docbook/release-notes.xml - M /trunk/epan/libwireshark.def - M /trunk/epan/privileges.c - M /trunk/epan/privileges.h - M /trunk/gtk/capture_dlg.c - M /trunk/gtk/drag_and_drop.c - M /trunk/gtk/gsm_map_summary.c - M /trunk/gtk/main.c - M /trunk/gtk/mtp3_summary.c - M /trunk/gtk/packet_win.c - M /trunk/gtk/recent.c - M /trunk/gtk/recent.h - M /trunk/gtk/summary_dlg.c - M /trunk/summary.c - M /trunk/tools/Makefile.am - M /trunk/tshark.c + M /trunk/epan/dissectors/packet-gsm_a_common.h -Change the "--enable-setuid-install" option to install dumpcap and TShark -setuid instead of Wireshark. Remove the "DANGEROUS" notices, but leave it -disabled by default. Whine if the user runs Wireshark or TShark as root. -Add a preference to disable the whining. Add a "setuid-root" script that -can be used to switch dumpcap and TShark's setuid-ness on and off for -development and testing. Update the release notes and README.packaging. - ------------------------------------------------------------------------- -r22734 | ulfl | 2007-08-29 19:14:36 -0700 (Wed, 29 Aug 2007) | 3 lines -Changed paths: - M /trunk/plugins/profinet/packet-dcerpc-pn-io.c +'if (curr_len <= 0)' won't work as desired when curr_len is declared as unsigned. +The fix: change to 'if ((signed)curr_len <= 0)'. +This is a bit of a hack but I think it works. +See the comment in this file (packet-gsm_a_common.h). -update to latest draft: -- add PDSyncData block with Version 1.2 -- add IOXBlockReq/s ids 0x116, 0x117, 0x8116 and 0x8117 ------------------------------------------------------------------------ -r22735 | guy | 2007-08-29 19:32:55 -0700 (Wed, 29 Aug 2007) | 2 lines +r29320 | wmeier | 2009-08-06 16:51:45 -0700 (Thu, 06 Aug 2009) | 2 lines Changed paths: - M /trunk/asn1/Makefile.am + M /trunk/epan/dissectors/packet-gsm_a_dtap.c + M /trunk/epan/dissectors/packet-gsm_a_rp.c + M /trunk/epan/dissectors/packet-gsm_a_rr.c + M /trunk/epan/dissectors/packet-gsm_bssmap_le.c -Get rid of tab after backslash, to eliminate warning. +Fix some individual cases of 'if (unsigned) < 0' ------------------------------------------------------------------------ -r22736 | gerald | 2007-08-29 21:16:11 -0700 (Wed, 29 Aug 2007) | 2 lines +r29321 | gerald | 2009-08-06 17:15:35 -0700 (Thu, 06 Aug 2009) | 2 lines Changed paths: - A /trunk/tools/setuid-root.pl.in + M /trunk/epan/dissectors/Makefile.am + M /trunk/epan/dissectors/Makefile.common + M /trunk/epan/dissectors/packet-nbd.c + M /trunk/epan/dissectors/packet-scsi-osd.c -Add the setuid script missing from my last checkin. +Clean up the last two DIRTY_DISSECTOR_SRC entries. ------------------------------------------------------------------------ -r22737 | etxrab | 2007-08-29 21:35:58 -0700 (Wed, 29 Aug 2007) | 1 line +r29322 | krj | 2009-08-07 05:15:46 -0700 (Fri, 07 Aug 2009) | 4 lines Changed paths: - M /trunk/asn1/Makefile.am + M /trunk/file.c -Remeove file not to be included. ------------------------------------------------------------------------- -r22738 | etxrab | 2007-08-29 21:49:04 -0700 (Wed, 29 Aug 2007) | 2 lines -Changed paths: - M /trunk/epan/dissectors/packet-ansi_637.c +Free frame data slice on file reset -From Chris Maynard: -Incorrect display filter field naming convention. ------------------------------------------------------------------------- -r22739 | etxrab | 2007-08-29 21:58:11 -0700 (Wed, 29 Aug 2007) | 2 lines -Changed paths: - M /trunk/epan/dissectors/packet-3com-xns.c +https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=3813 -From Chris Maynard: -Incorrect display filter field naming convention. ------------------------------------------------------------------------ -r22740 | etxrab | 2007-08-29 22:02:33 -0700 (Wed, 29 Aug 2007) | 2 lines +r29323 | krj | 2009-08-07 06:18:02 -0700 (Fri, 07 Aug 2009) | 1 line Changed paths: - M /trunk/epan/dissectors/packet-slowprotocols.c + M /trunk/config.nmake -From Chris Maynard: -Incorrect display filter field naming convention. +Use fully qualified path to bash ------------------------------------------------------------------------ -r22741 | etxrab | 2007-08-29 22:05:45 -0700 (Wed, 29 Aug 2007) | 2 lines +r29324 | krj | 2009-08-07 07:01:44 -0700 (Fri, 07 Aug 2009) | 1 line Changed paths: - M /trunk/epan/dissectors/packet-aim-admin.c + M /trunk/config.nmake -From Chris Maynard: -Incorrect display filter field naming convention. +Back out r29323. The non fully qualified path seems to work for everyone else so don't mess with it. ------------------------------------------------------------------------ -r22742 | etxrab | 2007-08-29 22:22:25 -0700 (Wed, 29 Aug 2007) | 2 lines +r29325 | jmayer | 2009-08-07 11:45:06 -0700 (Fri, 07 Aug 2009) | 3 lines Changed paths: - M /trunk/epan/dissectors/packet-aim-buddylist.c - M /trunk/epan/dissectors/packet-aim-generic.c - M /trunk/epan/dissectors/packet-aim-location.c - M /trunk/epan/dissectors/packet-aim-messaging.c - M /trunk/epan/dissectors/packet-aim-signon.c - M /trunk/epan/dissectors/packet-aim-ssi.c - M /trunk/epan/dissectors/packet-aim-sst.c - M /trunk/epan/dissectors/packet-aim-userlookup.c - M /trunk/epan/dissectors/packet-dcerpc-atsvc.c + M /trunk/epan/dissectors/packet-bootp.c -From Chris Maynard: -Incorrect display filter field naming convention. ------------------------------------------------------------------------- -r22743 | etxrab | 2007-08-29 22:30:28 -0700 (Wed, 29 Aug 2007) | 2 lines -Changed paths: - M /trunk/epan/dissectors/packet-aim-bos.c +- Add rfc number comments on not-yet-decoded options +- Decode autoconfigure option -From Chris Maynard: -Incorrect display filter field naming convention. ------------------------------------------------------------------------ -r22744 | stig | 2007-08-30 01:50:05 -0700 (Thu, 30 Aug 2007) | 3 lines +r29326 | jmayer | 2009-08-07 11:47:56 -0700 (Fri, 07 Aug 2009) | 8 lines Changed paths: - M /trunk/Makefile.am - M /trunk/tools - -Fixed a typo: setuid-root.in -> setuid-root.pl.in -Added setuid-root.pl to svn:ignore + M /trunk/epan/Makefile.am + M /trunk/wiretap/Makefile.am ------------------------------------------------------------------------- -r22745 | stig | 2007-08-30 02:28:41 -0700 (Thu, 30 Aug 2007) | 2 lines -Changed paths: - M /trunk/gtk/capture_info_dlg.c +* Tue May 26 2009 cmorve69@yahoo.es +- made it compile with --as-needed -Added #include <sys/types.h> +This patch was taken from the opensuse wireshark.spec file. +No thanks go to the author and the package maintainers of +this package for not sending this upstream - it would have +made it into 1.2.0. ------------------------------------------------------------------------ -r22746 | gmorris | 2007-08-30 03:18:29 -0700 (Thu, 30 Aug 2007) | 2 lines +r29327 | jmayer | 2009-08-07 11:49:24 -0700 (Fri, 07 Aug 2009) | 4 lines Changed paths: - M /trunk/epan/dissectors/ncp2222.py - M /trunk/epan/dissectors/packet-ncp-int.h - M /trunk/epan/dissectors/packet-ncp2222.inc + M /trunk/acinclude.m4 + M /trunk/configure.in -Add eDirectory iteration verb 0x6e. -Fix eDirectory timestamps to display correctly. ------------------------------------------------------------------------- -r22747 | gmorris | 2007-08-30 03:23:58 -0700 (Thu, 30 Aug 2007) | 2 lines -Changed paths: - M /trunk/epan/dissectors/packet-ndps.c +- Add an AC macro to test linker flags. +- Test whether the linker supports --as-needed and if so, + adds it to LDFLAGS -Fix attribute *Print Checkpoint" -Fix Printer State Reasons in extended error codes. ------------------------------------------------------------------------ -r22748 | gmorris | 2007-08-30 03:26:20 -0700 (Thu, 30 Aug 2007) | 1 line +r29328 | wmeier | 2009-08-07 14:22:54 -0700 (Fri, 07 Aug 2009) | 9 lines Changed paths: - M /trunk/gtk/ncp_stat.c + M /trunk/tshark.c -Update to reflect new iteration verb 0x6e. ------------------------------------------------------------------------- -r22749 | gmorris | 2007-08-30 03:33:24 -0700 (Thu, 30 Aug 2007) | 1 line -Changed paths: - M /trunk/epan/dissectors/packet-lpd.c +tshark: console_log_level preference now controls which log msgs are sent to stderr; +Note: This is a behavior change: + Given the default value for the console_log_level preference + tshark will now show ERROR, CRITICAL and WARNING level log messages. + Prior to this change tshark was hardwired to show only + ERROR and CRITICAL level messages. + Time will tell whether this change results in too much noise + in tshark output. -Test to see if packet is actually a request by verifying the one byte function code is a non-zero value. ------------------------------------------------------------------------ -r22750 | stig | 2007-08-30 04:28:27 -0700 (Thu, 30 Aug 2007) | 2 lines +r29329 | gerald | 2009-08-07 14:53:40 -0700 (Fri, 07 Aug 2009) | 6 lines Changed paths: - M /trunk/capture_info.c + M /trunk/epan/dissectors/packet-eth.c -Count IEEE 802.11 WLAN AVS packets. +From Matt P via bug 3774: ------------------------------------------------------------------------- -r22751 | stig | 2007-08-30 04:37:49 -0700 (Thu, 30 Aug 2007) | 2 lines -Changed paths: - M /trunk/epan/dissectors/packet-ieee80211.c - -Fixed a brace placement to enable the default case +Patch utilizes techniques incorporated in the packet-ieee8023.c dissect_802_3() +routine to dynamically calculate the remaining payload length. This is then +compared to the length included in the CCSDS header. ------------------------------------------------------------------------ -r22752 | stig | 2007-08-30 04:52:30 -0700 (Thu, 30 Aug 2007) | 2 lines +r29330 | wmeier | 2009-08-07 15:36:14 -0700 (Fri, 07 Aug 2009) | 8 lines Changed paths: - M /trunk/capture_info.c + M /trunk/tools/fuzz-test.sh -And include packet-wlancap.h +fuzz-test: Fix/change WIRESHARK_ABORT_ON_DISSECTOR_BUG handling: +1. If enabled: the variable must be exported to the env to take effect; +2. Upon reflection: disable this feature: + tshark has been changed to output WARNING messages to stderr as a + default; This means that DISSECTOR_BUGs and failed DISSECTOR_ASSERTs + which cause WARNING log level messages will thus be output to stderr and + thus will be detected by the fuzz-test. ------------------------------------------------------------------------ -r22753 | stig | 2007-08-30 05:06:18 -0700 (Thu, 30 Aug 2007) | 2 lines +r29331 | gerald | 2009-08-07 17:27:31 -0700 (Fri, 07 Aug 2009) | 3 lines Changed paths: - M /trunk/tools/Makefile.am + M /trunk/asn1/snmp/packet-snmp-template.c + M /trunk/epan/dissectors/packet-snmp.c -Added setuid-root.pl.in to EXSTRA_DIST +If we have a format error, don't try adding something to the +tree. Fixes bug 3822. ------------------------------------------------------------------------ -r22754 | stig | 2007-08-30 08:44:59 -0700 (Thu, 30 Aug 2007) | 2 lines +r29332 | guy | 2009-08-07 18:21:55 -0700 (Fri, 07 Aug 2009) | 9 lines Changed paths: - M /trunk/tools/Makefile.am + M /trunk/gtk/main.c -Huh. Fetch setuid-root.pl.in from srcdir instead. +Move one comment before all of the code to which it refers. ------------------------------------------------------------------------- -r22755 | stig | 2007-08-30 10:36:38 -0700 (Thu, 30 Aug 2007) | 3 lines -Changed paths: - M /trunk/gtk/capture_if_dlg.c +Update another comment with information from the corresponding comment +in tshark.c -It seems like capture_stats is working as a correctly implemented pcap_stats. -Update the Packets count in Capture Interfaces according to this. +Move some code so that it's run only if its result is used. + +Add an additional comment about logging on UN*X. ------------------------------------------------------------------------ -r22756 | stig | 2007-08-30 12:11:36 -0700 (Thu, 30 Aug 2007) | 2 lines +r29333 | guy | 2009-08-07 18:23:15 -0700 (Fri, 07 Aug 2009) | 2 lines Changed paths: - M /trunk/epan/libwireshark.def + M /trunk/tshark.c -Added capture_wlancap to libwireshark.def +Note that the new behavior matches what Wireshark does. ------------------------------------------------------------------------ -r22757 | guy | 2007-08-30 12:34:20 -0700 (Thu, 30 Aug 2007) | 2 lines +r29334 | jake | 2009-08-07 21:51:42 -0700 (Fri, 07 Aug 2009) | 3 lines Changed paths: - M /trunk/tools/Makefile.am + M /trunk/epan/dissectors/packet-ipv6.c -Clean up "setuid-root.pl" when we do "make distclean". +From Ivan Sy: +Fixed IPv6 malformed packet when ip6_nxt (Next Header) is equal to "59". as per section 4.7 RFC 2460. ------------------------------------------------------------------------ -r22758 | etxrab | 2007-08-30 12:44:22 -0700 (Thu, 30 Aug 2007) | 1 line +r29335 | krj | 2009-08-08 02:22:58 -0700 (Sat, 08 Aug 2009) | 4 lines Changed paths: - M /trunk/epan/dissectors/packet-per.c + M /trunk/packaging/portableapps/win32/makefile.nmake -fix dissect_per_bit_string() for unaligned PER, values ar still not correctly displayed. ------------------------------------------------------------------------- -r22759 | ulfl | 2007-08-30 12:50:56 -0700 (Thu, 30 Aug 2007) | 1 line -Changed paths: - M /trunk/plugins/profinet/packet-pn-rt.c +Pass on WinPcap/MSVC redistributable executables to the WiresharkPortable launcher and not the extractor. -fix length calculation for 802.11 packets - the 802.11 dissector will strip off the 4 byte FCS at the end of a packet (while the Ethernet dissector does not). ------------------------------------------------------------------------- -r22760 | jake | 2007-08-30 22:37:43 -0700 (Thu, 30 Aug 2007) | 2 lines -Changed paths: - M /trunk/epan/dissectors/packet-isup.c +Fixes https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=3547. -Fix for bug 1244: -hf_isup_event_ind contains incorrect fieldbase. ------------------------------------------------------------------------ -r22761 | sake | 2007-08-31 07:14:17 -0700 (Fri, 31 Aug 2007) | 15 lines +r29336 | krj | 2009-08-08 02:57:07 -0700 (Sat, 08 Aug 2009) | 4 lines Changed paths: - M /trunk/editcap.c - M /trunk/gtk/about_dlg.c - -This patch fixes the following two errors that appear when -configure is run with "--without-plugins" - -cc1: warnings being treated as errors -about_dlg.c: In function ?\226?\128?\152about_wireshark_cb?\226?\128?\153: -about_dlg.c:426: warning: unused variable ?\226?\128?\152plugins_page?\226?\128?\153 -make[2]: *** [about_dlg.o] Error 1 + M /trunk/asn1/Makefile.inc.nmake + M /trunk/epan/dissectors/packet-x420.c -editcap.c: In function ?\226?\128?\152main?\226?\128?\153: -editcap.c:663: error: ?\226?\128?\152check_ts?\226?\128?\153 undeclared (first use in this function) -editcap.c:663: error: (Each undeclared identifier is reported only once -editcap.c:663: error: for each function it appears in.) -make[2]: *** [editcap.o] Error 1 +Make sure that we pass on the same set of parameters to asn2wrs.py on Unix/Windows. This fix ensures that the generated copyright headers are identical on both platforms. +Fixes https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=3658 ------------------------------------------------------------------------ -r22762 | sake | 2007-08-31 08:06:27 -0700 (Fri, 31 Aug 2007) | 8 lines +r29337 | krj | 2009-08-08 05:40:59 -0700 (Sat, 08 Aug 2009) | 4 lines Changed paths: - M /trunk/epan/dissectors/packet-tcp.c + M /trunk/gtk/filter_autocomplete.c -When doing TCP_SEQ analysis, if the packet is a SYN, then it's -not a lost packet but the tcp ports are being reused. This is often -seen in load-balanced environments where client ports are preserved -on the server-side. +From Bahaa Naamneh via Bug 3538: -We only want to report port reusage once, so the SYN/ACK is excluded -from TCP_SEQ analysis. +This patch ensures that the filter autocompletion code handles protocols (radius and wimaxasncp) which uses delayed initialisation of protocols fields. ------------------------------------------------------------------------ -r22763 | wmeier | 2007-08-31 16:22:45 -0700 (Fri, 31 Aug 2007) | 2 lines +r29338 | gerald | 2009-08-08 15:20:08 -0700 (Sat, 08 Aug 2009) | 2 lines Changed paths: - M /trunk/gtk/uat_gui.c + M /trunk/plugins/m2m/packet-m2m.c -Enable <esc> to cancel window; remove some redundant code +Check TLV lengths before we try to add them to the tree. Fixes bug 3824. ------------------------------------------------------------------------ -r22764 | guy | 2007-08-31 16:56:07 -0700 (Fri, 31 Aug 2007) | 2 lines +r29339 | guy | 2009-08-08 18:23:09 -0700 (Sat, 08 Aug 2009) | 3 lines Changed paths: - M /trunk/epan/dissectors/packet-dnp.c + M /trunk/epan/dissectors/packet-ppp.c -Show unsigned quantities with %u, not %d. +Don't use DISSECTOR_ASSERT() to check a packet's content. Fixes bug +3827. ------------------------------------------------------------------------ -r22765 | sake | 2007-09-01 04:14:01 -0700 (Sat, 01 Sep 2007) | 4 lines +r29340 | krj | 2009-08-08 23:26:46 -0700 (Sat, 08 Aug 2009) | 1 line Changed paths: - M /trunk/wiretap/netscreen.c - -This patch solves two issue with the NetScreen wiretap routine: -- It accepts the "/" character in interface names -- It accepts EOF as delimiter for the last packet (when there is no more emptyline) + M /trunk/asn1/acse/packet-acse-template.c + M /trunk/asn1/cmip/packet-cmip-template.c + M /trunk/asn1/disp/packet-disp-template.c + M /trunk/asn1/dop/packet-dop-template.c + M /trunk/asn1/dsp/packet-dsp-template.c + M /trunk/asn1/ftam/packet-ftam-template.c + M /trunk/asn1/h248/packet-h248-template.c + M /trunk/asn1/kerberos/packet-kerberos-template.c + M /trunk/asn1/mms/packet-mms-template.c + M /trunk/asn1/mpeg-audio/packet-mpeg-audio-template.c + M /trunk/asn1/mpeg-pes/packet-mpeg-pes-template.c + M /trunk/asn1/nbap/packet-nbap-template.c + M /trunk/asn1/ocsp/packet-ocsp-template.c + M /trunk/asn1/pcap/packet-pcap-template.c + M /trunk/asn1/pkixcmp/packet-cmp-template.c + M /trunk/asn1/pkixtsp/packet-pkixtsp-template.c + M /trunk/asn1/pres/packet-pres-template.c + M /trunk/asn1/ranap/packet-ranap-template.c + M /trunk/asn1/rnsap/packet-rnsap-template.c + M /trunk/asn1/ros/packet-ros-template.c + M /trunk/asn1/rrc/packet-rrc-template.c + M /trunk/asn1/rtse/packet-rtse-template.c + M /trunk/asn1/s1ap/packet-s1ap-template.c + M /trunk/asn1/s4406/packet-s4406-template.c + M /trunk/asn1/smrse/packet-smrse-template.c + M /trunk/asn1/snmp/packet-snmp-template.c + M /trunk/asn1/x2ap/packet-x2ap-template.c + M /trunk/asn1/x411/packet-x411-template.c + M /trunk/asn1/x420/packet-x420-template.c + M /trunk/asn1/x509af/packet-x509af-template.c + M /trunk/epan/dissectors/packet-3com-xns.c + M /trunk/epan/dissectors/packet-3g-a11.c + M /trunk/epan/dissectors/packet-9p.c + M /trunk/epan/dissectors/packet-aarp.c + M /trunk/epan/dissectors/packet-acap.c + M /trunk/epan/dissectors/packet-acse.c + M /trunk/epan/dissectors/packet-actrace.c + M /trunk/epan/dissectors/packet-afp.c + M /trunk/epan/dissectors/packet-agentx.c + M /trunk/epan/dissectors/packet-aim.c + M /trunk/epan/dissectors/packet-airopeek.c + M /trunk/epan/dissectors/packet-ajp13.c + M /trunk/epan/dissectors/packet-amqp.c + M /trunk/epan/dissectors/packet-amr.c + M /trunk/epan/dissectors/packet-ans.c + M /trunk/epan/dissectors/packet-aodv.c + M /trunk/epan/dissectors/packet-aoe.c + M /trunk/epan/dissectors/packet-ap1394.c + M /trunk/epan/dissectors/packet-arcnet.c + M /trunk/epan/dissectors/packet-armagetronad.c + M /trunk/epan/dissectors/packet-arp.c + M /trunk/epan/dissectors/packet-aruba-adp.c + M /trunk/epan/dissectors/packet-asf.c + M /trunk/epan/dissectors/packet-atalk.c + M /trunk/epan/dissectors/packet-atm.c + M /trunk/epan/dissectors/packet-auto_rp.c + M /trunk/epan/dissectors/packet-ax4000.c + M /trunk/epan/dissectors/packet-ayiya.c + M /trunk/epan/dissectors/packet-bacnet.c + M /trunk/epan/dissectors/packet-beep.c + M /trunk/epan/dissectors/packet-ber.c + M /trunk/epan/dissectors/packet-bfd.c + M /trunk/epan/dissectors/packet-bgp.c + M /trunk/epan/dissectors/packet-bofl.c + M /trunk/epan/dissectors/packet-bootp.c + M /trunk/epan/dissectors/packet-brdwlk.c + M /trunk/epan/dissectors/packet-bssgp.c + M /trunk/epan/dissectors/packet-btrfcomm.c + M /trunk/epan/dissectors/packet-btsdp.c + M /trunk/epan/dissectors/packet-bvlc.c + M /trunk/epan/dissectors/packet-ccsds.c + M /trunk/epan/dissectors/packet-cdp.c + M /trunk/epan/dissectors/packet-cgmp.c + M /trunk/epan/dissectors/packet-chdlc.c + M /trunk/epan/dissectors/packet-cimd.c + M /trunk/epan/dissectors/packet-cisco-sm.c + M /trunk/epan/dissectors/packet-cisco-wids.c + M /trunk/epan/dissectors/packet-clnp.c + M /trunk/epan/dissectors/packet-cmip.c + M /trunk/epan/dissectors/packet-cmp.c + M /trunk/epan/dissectors/packet-cmpp.c + M /trunk/epan/dissectors/packet-cops.c + M /trunk/epan/dissectors/packet-cpha.c + M /trunk/epan/dissectors/packet-csm-encaps.c + M /trunk/epan/dissectors/packet-daap.c + M /trunk/epan/dissectors/packet-daytime.c + M /trunk/epan/dissectors/packet-dcc.c + M /trunk/epan/dissectors/packet-dccp.c + M /trunk/epan/dissectors/packet-dcerpc.c + M /trunk/epan/dissectors/packet-dect.c + M /trunk/epan/dissectors/packet-dhcp-failover.c + M /trunk/epan/dissectors/packet-dhcpv6.c + M /trunk/epan/dissectors/packet-diameter.c + M /trunk/epan/dissectors/packet-disp.c + M /trunk/epan/dissectors/packet-distcc.c + M /trunk/epan/dissectors/packet-dlm3.c + M /trunk/epan/dissectors/packet-dlsw.c + M /trunk/epan/dissectors/packet-dnp.c + M /trunk/epan/dissectors/packet-dns.c + M /trunk/epan/dissectors/packet-dop.c + M /trunk/epan/dissectors/packet-dplay.c + M /trunk/epan/dissectors/packet-dpnss.c + M /trunk/epan/dissectors/packet-drda.c + M /trunk/epan/dissectors/packet-dsi.c + M /trunk/epan/dissectors/packet-dsp.c + M /trunk/epan/dissectors/packet-dtp.c + M /trunk/epan/dissectors/packet-dtpt.c + M /trunk/epan/dissectors/packet-dua.c + M /trunk/epan/dissectors/packet-eap.c + M /trunk/epan/dissectors/packet-eapol.c + M /trunk/epan/dissectors/packet-edonkey.c + M /trunk/epan/dissectors/packet-eigrp.c + M /trunk/epan/dissectors/packet-enc.c + M /trunk/epan/dissectors/packet-enip.c + M /trunk/epan/dissectors/packet-epmd.c + M /trunk/epan/dissectors/packet-erf.c + M /trunk/epan/dissectors/packet-esis.c + M /trunk/epan/dissectors/packet-etherip.c + M /trunk/epan/dissectors/packet-exec.c + M /trunk/epan/dissectors/packet-extreme.c + M /trunk/epan/dissectors/packet-fc.c + M /trunk/epan/dissectors/packet-fcct.c + M /trunk/epan/dissectors/packet-fcels.c + M /trunk/epan/dissectors/packet-fcfcs.c + M /trunk/epan/dissectors/packet-fcfzs.c + M /trunk/epan/dissectors/packet-fcip.c + M /trunk/epan/dissectors/packet-fcoe.c + M /trunk/epan/dissectors/packet-fcp.c + M /trunk/epan/dissectors/packet-fcsb3.c + M /trunk/epan/dissectors/packet-fcswils.c + M /trunk/epan/dissectors/packet-fddi.c + M /trunk/epan/dissectors/packet-fefd.c + M /trunk/epan/dissectors/packet-fip.c + M /trunk/epan/dissectors/packet-fr.c + M /trunk/epan/dissectors/packet-ftam.c + M /trunk/epan/dissectors/packet-ftp.c + M /trunk/epan/dissectors/packet-fw1.c + M /trunk/epan/dissectors/packet-g723.c + M /trunk/epan/dissectors/packet-gdsdb.c + M /trunk/epan/dissectors/packet-gift.c + M /trunk/epan/dissectors/packet-giop.c + M /trunk/epan/dissectors/packet-gmrp.c + M /trunk/epan/dissectors/packet-gnutella.c + M /trunk/epan/dissectors/packet-gprs-ns.c + M /trunk/epan/dissectors/packet-gre.c + M /trunk/epan/dissectors/packet-gsm_um.c + M /trunk/epan/dissectors/packet-gtp.c + M /trunk/epan/dissectors/packet-gtpv2.c + M /trunk/epan/dissectors/packet-gvrp.c + M /trunk/epan/dissectors/packet-h1.c + M /trunk/epan/dissectors/packet-h248.c + M /trunk/epan/dissectors/packet-h264.c + M /trunk/epan/dissectors/packet-hci_h1.c + M /trunk/epan/dissectors/packet-hilscher.c + M /trunk/epan/dissectors/packet-homeplug.c + M /trunk/epan/dissectors/packet-hsrp.c + M /trunk/epan/dissectors/packet-hyperscsi.c + M /trunk/epan/dissectors/packet-iapp.c + M /trunk/epan/dissectors/packet-icap.c + M /trunk/epan/dissectors/packet-icep.c + M /trunk/epan/dissectors/packet-icp.c + M /trunk/epan/dissectors/packet-icq.c + M /trunk/epan/dissectors/packet-idp.c + M /trunk/epan/dissectors/packet-ieee80211.c + M /trunk/epan/dissectors/packet-ieee8021ah.c + M /trunk/epan/dissectors/packet-igrp.c + M /trunk/epan/dissectors/packet-imap.c + M /trunk/epan/dissectors/packet-infiniband.c + M /trunk/epan/dissectors/packet-ipdc.c + M /trunk/epan/dissectors/packet-ipfc.c + M /trunk/epan/dissectors/packet-ipp.c + M /trunk/epan/dissectors/packet-ipsec-tcp.c + M /trunk/epan/dissectors/packet-ipsec-udp.c + M /trunk/epan/dissectors/packet-ipsec.c + M /trunk/epan/dissectors/packet-ipv6.c + M /trunk/epan/dissectors/packet-ipx.c + M /trunk/epan/dissectors/packet-ipxwan.c + M /trunk/epan/dissectors/packet-irc.c + M /trunk/epan/dissectors/packet-isakmp.c + M /trunk/epan/dissectors/packet-iscsi.c + M /trunk/epan/dissectors/packet-isdn.c + M /trunk/epan/dissectors/packet-isis.c + M /trunk/epan/dissectors/packet-isl.c + M /trunk/epan/dissectors/packet-isns.c + M /trunk/epan/dissectors/packet-isup.c + M /trunk/epan/dissectors/packet-itdm.c + M /trunk/epan/dissectors/packet-jabber.c + M /trunk/epan/dissectors/packet-juniper.c + M /trunk/epan/dissectors/packet-kerberos.c + M /trunk/epan/dissectors/packet-kerberos4.c + M /trunk/epan/dissectors/packet-kingfisher.c + M /trunk/epan/dissectors/packet-kismet.c + M /trunk/epan/dissectors/packet-kpasswd.c + M /trunk/epan/dissectors/packet-l1-events.c + M /trunk/epan/dissectors/packet-l2tp.c + M /trunk/epan/dissectors/packet-lanforge.c + M /trunk/epan/dissectors/packet-lapb.c + M /trunk/epan/dissectors/packet-lapbether.c + M /trunk/epan/dissectors/packet-lapd.c + M /trunk/epan/dissectors/packet-lapdm.c + M /trunk/epan/dissectors/packet-laplink.c + M /trunk/epan/dissectors/packet-ldp.c + M /trunk/epan/dissectors/packet-lge_monitor.c + M /trunk/epan/dissectors/packet-linx.c + M /trunk/epan/dissectors/packet-lldp.c + M /trunk/epan/dissectors/packet-llt.c + M /trunk/epan/dissectors/packet-lmi.c + M /trunk/epan/dissectors/packet-lmp.c + M /trunk/epan/dissectors/packet-loop.c + M /trunk/epan/dissectors/packet-lpd.c + M /trunk/epan/dissectors/packet-lsc.c + M /trunk/epan/dissectors/packet-lwapp.c + M /trunk/epan/dissectors/packet-lwres.c + M /trunk/epan/dissectors/packet-m2tp.c + M /trunk/epan/dissectors/packet-m2ua.c + M /trunk/epan/dissectors/packet-maccontrol.c + M /trunk/epan/dissectors/packet-manolito.c + M /trunk/epan/dissectors/packet-mbtcp.c + M /trunk/epan/dissectors/packet-mdshdr.c + M /trunk/epan/dissectors/packet-megaco.c + M /trunk/epan/dissectors/packet-mesh.c + M /trunk/epan/dissectors/packet-mip.c + M /trunk/epan/dissectors/packet-mip6.c + M /trunk/epan/dissectors/packet-mms.c + M /trunk/epan/dissectors/packet-mmse.c + M /trunk/epan/dissectors/packet-mp4ves.c + M /trunk/epan/dissectors/packet-mpeg-audio.c + M /trunk/epan/dissectors/packet-mpeg-pes.c + M /trunk/epan/dissectors/packet-mpls-echo.c + M /trunk/epan/dissectors/packet-mq-pcf.c + M /trunk/epan/dissectors/packet-mq.c + M /trunk/epan/dissectors/packet-msdp.c + M /trunk/epan/dissectors/packet-msn-messenger.c + M /trunk/epan/dissectors/packet-msnlb.c + M /trunk/epan/dissectors/packet-msproxy.c + M /trunk/epan/dissectors/packet-msrp.c + M /trunk/epan/dissectors/packet-mstp.c + M /trunk/epan/dissectors/packet-mtp2.c + M /trunk/epan/dissectors/packet-nasdaq-itch.c + M /trunk/epan/dissectors/packet-nasdaq-soup.c + M /trunk/epan/dissectors/packet-nbap.c + M /trunk/epan/dissectors/packet-nbipx.c + M /trunk/epan/dissectors/packet-nbns.c + M /trunk/epan/dissectors/packet-ncp.c + M /trunk/epan/dissectors/packet-ncs.c + M /trunk/epan/dissectors/packet-ndmp.c + M /trunk/epan/dissectors/packet-ndps.c + M /trunk/epan/dissectors/packet-netbios.c + M /trunk/epan/dissectors/packet-netflow.c + M /trunk/epan/dissectors/packet-nettl.c + M /trunk/epan/dissectors/packet-newmail.c + M /trunk/epan/dissectors/packet-nlsp.c + M /trunk/epan/dissectors/packet-nntp.c + M /trunk/epan/dissectors/packet-nsip.c + M /trunk/epan/dissectors/packet-nsrp.c + M /trunk/epan/dissectors/packet-nt-sonmp.c + M /trunk/epan/dissectors/packet-nt-tpcp.c + M /trunk/epan/dissectors/packet-ntp.c + M /trunk/epan/dissectors/packet-ocsp.c + M /trunk/epan/dissectors/packet-oicq.c + M /trunk/epan/dissectors/packet-olsr.c + M /trunk/epan/dissectors/packet-opsi.c + M /trunk/epan/dissectors/packet-ospf.c + M /trunk/epan/dissectors/packet-paltalk.c + M /trunk/epan/dissectors/packet-pana.c + M /trunk/epan/dissectors/packet-pcap.c + M /trunk/epan/dissectors/packet-pcep.c + M /trunk/epan/dissectors/packet-pflog.c + M /trunk/epan/dissectors/packet-pgm.c + M /trunk/epan/dissectors/packet-pgsql.c + M /trunk/epan/dissectors/packet-pim.c + M /trunk/epan/dissectors/packet-pkixtsp.c + M /trunk/epan/dissectors/packet-pktc.c + M /trunk/epan/dissectors/packet-pktgen.c + M /trunk/epan/dissectors/packet-ppi.c + M /trunk/epan/dissectors/packet-ppp.c + M /trunk/epan/dissectors/packet-pptp.c + M /trunk/epan/dissectors/packet-pres.c + M /trunk/epan/dissectors/packet-prp.c + M /trunk/epan/dissectors/packet-ptp.c + M /trunk/epan/dissectors/packet-pvfs2.c + M /trunk/epan/dissectors/packet-q2931.c + M /trunk/epan/dissectors/packet-q931.c + M /trunk/epan/dissectors/packet-q933.c + M /trunk/epan/dissectors/packet-qllc.c + M /trunk/epan/dissectors/packet-quake.c + M /trunk/epan/dissectors/packet-quake2.c + M /trunk/epan/dissectors/packet-quake3.c + M /trunk/epan/dissectors/packet-quakeworld.c + M /trunk/epan/dissectors/packet-radius.c + M /trunk/epan/dissectors/packet-ranap.c + M /trunk/epan/dissectors/packet-rdm.c + M /trunk/epan/dissectors/packet-rip.c + M /trunk/epan/dissectors/packet-ripng.c + M /trunk/epan/dissectors/packet-rlm.c + M /trunk/epan/dissectors/packet-rmcp.c + M /trunk/epan/dissectors/packet-rmi.c + M /trunk/epan/dissectors/packet-rmt-alc.c + M /trunk/epan/dissectors/packet-rmt-norm.c + M /trunk/epan/dissectors/packet-rnsap.c + M /trunk/epan/dissectors/packet-roofnet.c + M /trunk/epan/dissectors/packet-ros.c + M /trunk/epan/dissectors/packet-rpc.c + M /trunk/epan/dissectors/packet-rpl.c + M /trunk/epan/dissectors/packet-rrc.c + M /trunk/epan/dissectors/packet-rsh.c + M /trunk/epan/dissectors/packet-rsl.c + M /trunk/epan/dissectors/packet-rsync.c + M /trunk/epan/dissectors/packet-rtmpt.c + M /trunk/epan/dissectors/packet-rtse.c + M /trunk/epan/dissectors/packet-rtsp.c + M /trunk/epan/dissectors/packet-rudp.c + M /trunk/epan/dissectors/packet-rx.c + M /trunk/epan/dissectors/packet-s1ap.c + M /trunk/epan/dissectors/packet-s4406.c + M /trunk/epan/dissectors/packet-sap.c + M /trunk/epan/dissectors/packet-sbus.c + M /trunk/epan/dissectors/packet-sctp.c + M /trunk/epan/dissectors/packet-sdlc.c + M /trunk/epan/dissectors/packet-sebek.c + M /trunk/epan/dissectors/packet-ses.c + M /trunk/epan/dissectors/packet-sflow.c + M /trunk/epan/dissectors/packet-sigcomp.c + M /trunk/epan/dissectors/packet-sip.c + M /trunk/epan/dissectors/packet-slimp3.c + M /trunk/epan/dissectors/packet-sll.c + M /trunk/epan/dissectors/packet-slowprotocols.c + M /trunk/epan/dissectors/packet-slsk.c + M /trunk/epan/dissectors/packet-smb-logon.c + M /trunk/epan/dissectors/packet-smpp.c + M /trunk/epan/dissectors/packet-smrse.c + M /trunk/epan/dissectors/packet-smtp.c + M /trunk/epan/dissectors/packet-sna.c + M /trunk/epan/dissectors/packet-snaeth.c + M /trunk/epan/dissectors/packet-sndcp.c + M /trunk/epan/dissectors/packet-snmp.c + M /trunk/epan/dissectors/packet-socks.c + M /trunk/epan/dissectors/packet-spp.c + M /trunk/epan/dissectors/packet-srvloc.c + M /trunk/epan/dissectors/packet-sscf-nni.c + M /trunk/epan/dissectors/packet-sscop.c + M /trunk/epan/dissectors/packet-stun.c + M /trunk/epan/dissectors/packet-stun2.c + M /trunk/epan/dissectors/packet-symantec.c + M /trunk/epan/dissectors/packet-synergy.c + M /trunk/epan/dissectors/packet-syslog.c + M /trunk/epan/dissectors/packet-tacacs.c + M /trunk/epan/dissectors/packet-tali.c + M /trunk/epan/dissectors/packet-tcp.c + M /trunk/epan/dissectors/packet-tds.c + M /trunk/epan/dissectors/packet-teimanagement.c + M /trunk/epan/dissectors/packet-telkonet.c + M /trunk/epan/dissectors/packet-telnet.c + M /trunk/epan/dissectors/packet-teredo.c + M /trunk/epan/dissectors/packet-tftp.c + M /trunk/epan/dissectors/packet-time.c + M /trunk/epan/dissectors/packet-tipc.c + M /trunk/epan/dissectors/packet-tivoconnect.c + M /trunk/epan/dissectors/packet-tns.c + M /trunk/epan/dissectors/packet-tpkt.c + M /trunk/epan/dissectors/packet-tpncp.c + M /trunk/epan/dissectors/packet-tr.c + M /trunk/epan/dissectors/packet-trmac.c + M /trunk/epan/dissectors/packet-tsp.c + M /trunk/epan/dissectors/packet-tte-pcf.c + M /trunk/epan/dissectors/packet-tte.c + M /trunk/epan/dissectors/packet-turbocell.c + M /trunk/epan/dissectors/packet-turnchannel.c + M /trunk/epan/dissectors/packet-tuxedo.c + M /trunk/epan/dissectors/packet-tzsp.c + M /trunk/epan/dissectors/packet-ucp.c + M /trunk/epan/dissectors/packet-udld.c + M /trunk/epan/dissectors/packet-uma.c + M /trunk/epan/dissectors/packet-umts_fp.c + M /trunk/epan/dissectors/packet-usb-masstorage.c + M /trunk/epan/dissectors/packet-usb.c + M /trunk/epan/dissectors/packet-v120.c + M /trunk/epan/dissectors/packet-vcdu.c + M /trunk/epan/dissectors/packet-vicp.c + M /trunk/epan/dissectors/packet-vines.c + M /trunk/epan/dissectors/packet-vj.c + M /trunk/epan/dissectors/packet-vlan.c + M /trunk/epan/dissectors/packet-vnc.c + M /trunk/epan/dissectors/packet-vrrp.c + M /trunk/epan/dissectors/packet-vtp.c + M /trunk/epan/dissectors/packet-wcp.c + M /trunk/epan/dissectors/packet-wfleet-hdlc.c + M /trunk/epan/dissectors/packet-who.c + M /trunk/epan/dissectors/packet-wlccp.c + M /trunk/epan/dissectors/packet-wol.c + M /trunk/epan/dissectors/packet-wow.c + M /trunk/epan/dissectors/packet-wsmp.c + M /trunk/epan/dissectors/packet-x11.c + M /trunk/epan/dissectors/packet-x25.c + M /trunk/epan/dissectors/packet-x29.c + M /trunk/epan/dissectors/packet-x2ap.c + M /trunk/epan/dissectors/packet-x411.c + M /trunk/epan/dissectors/packet-x420.c + M /trunk/epan/dissectors/packet-x509af.c + M /trunk/epan/dissectors/packet-xcsl.c + M /trunk/epan/dissectors/packet-xdmcp.c + M /trunk/epan/dissectors/packet-xot.c + M /trunk/epan/dissectors/packet-xtp.c + M /trunk/epan/dissectors/packet-xyplex.c + M /trunk/epan/dissectors/packet-yhoo.c + M /trunk/epan/dissectors/packet-ymsg.c + M /trunk/epan/dissectors/packet-zebra.c + M /trunk/epan/dissectors/packet-zrtp.c + M /trunk/plugins/docsis/packet-docsis.c + M /trunk/plugins/docsis/packet-macmgmt.c + M /trunk/plugins/ethercat/packet-ams.c + M /trunk/plugins/ethercat/packet-ethercat-datagram.c + M /trunk/plugins/ethercat/packet-ioraw.c + M /trunk/plugins/ethercat/packet-nv.c + M /trunk/plugins/giop/packet-coseventcomm.c + M /trunk/plugins/giop/packet-cosnaming.c + M /trunk/plugins/giop/packet-parlay.c + M /trunk/plugins/giop/packet-tango.c + M /trunk/plugins/gryphon/packet-gryphon.c + M /trunk/plugins/irda/packet-ircomm.c + M /trunk/plugins/irda/packet-irda.c + M /trunk/plugins/profinet/packet-pn-mrp.c + M /trunk/plugins/sercosiii/packet-sercosiii_1v1.c + M /trunk/plugins/sercosiii/packet-sercosiii_1v1_at.c + M /trunk/plugins/sercosiii/packet-sercosiii_1v1_mdt.c + +Don't guard col_set_str (COL_PROTOCOL) with col_check +------------------------------------------------------------------------ +r29341 | krj | 2009-08-08 23:47:24 -0700 (Sat, 08 Aug 2009) | 1 line +Changed paths: + M /trunk/epan/dissectors/packet-ascend.c + M /trunk/epan/dissectors/packet-cip.c + M /trunk/epan/dissectors/packet-clip.c + M /trunk/epan/dissectors/packet-cosine.c + M /trunk/epan/dissectors/packet-ehs.c + M /trunk/epan/dissectors/packet-enip.c + M /trunk/epan/dissectors/packet-null.c + M /trunk/epan/dissectors/packet-ppp.c + M /trunk/epan/dissectors/packet-raw.c + M /trunk/epan/dissectors/packet-sqloracle.c + M /trunk/epan/dissectors/packet-wsp.c + M /trunk/epan/dissectors/packet-wtp.c + M /trunk/plugins/unistim/packet-unistim.c +Don't guard col_set_str (COL_PROTOCOL) with col_check ------------------------------------------------------------------------ -r22766 | jake | 2007-09-01 04:47:59 -0700 (Sat, 01 Sep 2007) | 3 lines +r29342 | krj | 2009-08-09 00:01:26 -0700 (Sun, 09 Aug 2009) | 1 line Changed paths: - M /trunk/epan/dissectors/packet-bacapp.c + M /trunk/asn1/s4406/packet-s4406-template.c + M /trunk/asn1/x411/packet-x411-template.c + M /trunk/asn1/x420/packet-x420-template.c + M /trunk/epan/dissectors/packet-aim.c + M /trunk/epan/dissectors/packet-arcnet.c + M /trunk/epan/dissectors/packet-ascend.c + M /trunk/epan/dissectors/packet-atm.c + M /trunk/epan/dissectors/packet-bacnet.c + M /trunk/epan/dissectors/packet-bvlc.c + M /trunk/epan/dissectors/packet-ccsds.c + M /trunk/epan/dissectors/packet-cgmp.c + M /trunk/epan/dissectors/packet-clip.c + M /trunk/epan/dissectors/packet-clnp.c + M /trunk/epan/dissectors/packet-cosine.c + M /trunk/epan/dissectors/packet-dccp.c + M /trunk/epan/dissectors/packet-ddtp.c + M /trunk/epan/dissectors/packet-dect.c + M /trunk/epan/dissectors/packet-dlm3.c + M /trunk/epan/dissectors/packet-dtp.c + M /trunk/epan/dissectors/packet-dtpt.c + M /trunk/epan/dissectors/packet-edonkey.c + M /trunk/epan/dissectors/packet-ehs.c + M /trunk/epan/dissectors/packet-exec.c + M /trunk/epan/dissectors/packet-fc.c + M /trunk/epan/dissectors/packet-fcip.c + M /trunk/epan/dissectors/packet-fip.c + M /trunk/epan/dissectors/packet-gmrp.c + M /trunk/epan/dissectors/packet-gvrp.c + M /trunk/epan/dissectors/packet-h1.c + M /trunk/epan/dissectors/packet-h223.c + M /trunk/epan/dissectors/packet-icq.c + M /trunk/epan/dissectors/packet-ieee80211.c + M /trunk/epan/dissectors/packet-ipsec-udp.c + M /trunk/epan/dissectors/packet-ipx.c + M /trunk/epan/dissectors/packet-lapb.c + M /trunk/epan/dissectors/packet-lldp.c + M /trunk/epan/dissectors/packet-lsc.c + M /trunk/epan/dissectors/packet-megaco.c + M /trunk/epan/dissectors/packet-mip6.c + M /trunk/epan/dissectors/packet-mpls-echo.c + M /trunk/epan/dissectors/packet-mtp2.c + M /trunk/epan/dissectors/packet-mtp3.c + M /trunk/epan/dissectors/packet-mtp3mg.c + M /trunk/epan/dissectors/packet-nbns.c + M /trunk/epan/dissectors/packet-ndps.c + M /trunk/epan/dissectors/packet-newmail.c + M /trunk/epan/dissectors/packet-null.c + M /trunk/epan/dissectors/packet-ppi.c + M /trunk/epan/dissectors/packet-ppp.c + M /trunk/epan/dissectors/packet-prp.c + M /trunk/epan/dissectors/packet-ptp.c + M /trunk/epan/dissectors/packet-pvfs2.c + M /trunk/epan/dissectors/packet-raw.c + M /trunk/epan/dissectors/packet-rpc.c + M /trunk/epan/dissectors/packet-s4406.c + M /trunk/epan/dissectors/packet-sigcomp.c + M /trunk/epan/dissectors/packet-sip.c + M /trunk/epan/dissectors/packet-slowprotocols.c + M /trunk/epan/dissectors/packet-slsk.c + M /trunk/epan/dissectors/packet-sna.c + M /trunk/epan/dissectors/packet-snaeth.c + M /trunk/epan/dissectors/packet-spp.c + M /trunk/epan/dissectors/packet-symantec.c + M /trunk/epan/dissectors/packet-telnet.c + M /trunk/epan/dissectors/packet-tn3270.c + M /trunk/epan/dissectors/packet-tpkt.c + M /trunk/epan/dissectors/packet-tte.c + M /trunk/epan/dissectors/packet-turbocell.c + M /trunk/epan/dissectors/packet-tuxedo.c + M /trunk/epan/dissectors/packet-v120.c + M /trunk/epan/dissectors/packet-vcdu.c + M /trunk/epan/dissectors/packet-vj.c + M /trunk/epan/dissectors/packet-vnc.c + M /trunk/epan/dissectors/packet-vtp.c + M /trunk/epan/dissectors/packet-wsmp.c + M /trunk/epan/dissectors/packet-x11.c + M /trunk/epan/dissectors/packet-x25.c + M /trunk/epan/dissectors/packet-x29.c + M /trunk/epan/dissectors/packet-x411.c + M /trunk/epan/dissectors/packet-x420.c + M /trunk/plugins/docsis/packet-docsis.c + M /trunk/plugins/irda/packet-irda.c -From Steve Karg: -Fix for bug 1807. This patch corrects the decoding of the NotificationParameters. -I fuzz tested with these and other captures (Pass > 100). +Don't guard col_set_str (COL_INFO) with col_check ------------------------------------------------------------------------ -r22767 | wmeier | 2007-09-02 05:37:24 -0700 (Sun, 02 Sep 2007) | 3 lines +r29343 | krj | 2009-08-09 00:14:16 -0700 (Sun, 09 Aug 2009) | 1 line Changed paths: - M /trunk/epan/dfilter/dfilter-macro.c - -macro_name_chk: return valid error string for fail return when empty macro name field; -fixes bug #1813 + M /trunk/epan/dissectors/packet-ascend.c + M /trunk/epan/dissectors/packet-atm.c + M /trunk/epan/dissectors/packet-ber.c + M /trunk/epan/dissectors/packet-chdlc.c + M /trunk/epan/dissectors/packet-clip.c + M /trunk/epan/dissectors/packet-cosine.c + M /trunk/epan/dissectors/packet-fr.c + M /trunk/epan/dissectors/packet-gsm_um.c + M /trunk/epan/dissectors/packet-isdn.c + M /trunk/epan/dissectors/packet-lapb.c + M /trunk/epan/dissectors/packet-null.c + M /trunk/epan/dissectors/packet-ppp.c + M /trunk/epan/dissectors/packet-raw.c + M /trunk/epan/dissectors/packet-sdlc.c + M /trunk/epan/dissectors/packet-v120.c + M /trunk/epan/dissectors/packet-wfleet-hdlc.c +Don't guard col_set_str (COL_RES_DL_SRC/COL_RES_DL_DST) with col_check ------------------------------------------------------------------------ -r22768 | guy | 2007-09-02 13:37:39 -0700 (Sun, 02 Sep 2007) | 2 lines +r29344 | krj | 2009-08-09 00:36:13 -0700 (Sun, 09 Aug 2009) | 1 line Changed paths: - M /trunk/epan/dissectors/packet-ip.c - -Fix indentation. + M /trunk/asn1/acse/packet-acse-template.c + M /trunk/asn1/cmip/packet-cmip-template.c + M /trunk/asn1/disp/packet-disp-template.c + M /trunk/asn1/dop/packet-dop-template.c + M /trunk/asn1/dsp/packet-dsp-template.c + M /trunk/asn1/ftam/packet-ftam-template.c + M /trunk/asn1/goose/packet-goose-template.c + M /trunk/asn1/kerberos/packet-kerberos-template.c + M /trunk/asn1/mms/packet-mms-template.c + M /trunk/asn1/mpeg-audio/packet-mpeg-audio-template.c + M /trunk/asn1/mpeg-pes/packet-mpeg-pes-template.c + M /trunk/asn1/pres/packet-pres-template.c + M /trunk/asn1/ros/packet-ros-template.c + M /trunk/asn1/rtse/packet-rtse-template.c + M /trunk/asn1/x411/packet-x411-template.c + M /trunk/epan/dissectors/packet-3com-xns.c + M /trunk/epan/dissectors/packet-3g-a11.c + M /trunk/epan/dissectors/packet-9p.c + M /trunk/epan/dissectors/packet-aarp.c + M /trunk/epan/dissectors/packet-acse.c + M /trunk/epan/dissectors/packet-actrace.c + M /trunk/epan/dissectors/packet-airopeek.c + M /trunk/epan/dissectors/packet-ajp13.c + M /trunk/epan/dissectors/packet-aodv.c + M /trunk/epan/dissectors/packet-aoe.c + M /trunk/epan/dissectors/packet-ap1394.c + M /trunk/epan/dissectors/packet-arp.c + M /trunk/epan/dissectors/packet-aruba-adp.c + M /trunk/epan/dissectors/packet-asf.c + M /trunk/epan/dissectors/packet-atalk.c + M /trunk/epan/dissectors/packet-atm.c + M /trunk/epan/dissectors/packet-auto_rp.c + M /trunk/epan/dissectors/packet-bfd.c + M /trunk/epan/dissectors/packet-bgp.c + M /trunk/epan/dissectors/packet-bofl.c + M /trunk/epan/dissectors/packet-brdwlk.c + M /trunk/epan/dissectors/packet-bssgp.c + M /trunk/epan/dissectors/packet-cdp.c + M /trunk/epan/dissectors/packet-chdlc.c + M /trunk/epan/dissectors/packet-cip.c + M /trunk/epan/dissectors/packet-cisco-wids.c + M /trunk/epan/dissectors/packet-clnp.c + M /trunk/epan/dissectors/packet-cmip.c + M /trunk/epan/dissectors/packet-cmpp.c + M /trunk/epan/dissectors/packet-cops.c + M /trunk/epan/dissectors/packet-cpha.c + M /trunk/epan/dissectors/packet-cups.c + M /trunk/epan/dissectors/packet-dccp.c + M /trunk/epan/dissectors/packet-dhcp-failover.c + M /trunk/epan/dissectors/packet-dhcpv6.c + M /trunk/epan/dissectors/packet-disp.c + M /trunk/epan/dissectors/packet-distcc.c + M /trunk/epan/dissectors/packet-dlm3.c + M /trunk/epan/dissectors/packet-dnp.c + M /trunk/epan/dissectors/packet-dns.c + M /trunk/epan/dissectors/packet-dop.c + M /trunk/epan/dissectors/packet-dplay.c + M /trunk/epan/dissectors/packet-dsp.c + M /trunk/epan/dissectors/packet-dtls.c + M /trunk/epan/dissectors/packet-eap.c + M /trunk/epan/dissectors/packet-eapol.c + M /trunk/epan/dissectors/packet-edonkey.c + M /trunk/epan/dissectors/packet-eigrp.c + M /trunk/epan/dissectors/packet-enip.c + M /trunk/epan/dissectors/packet-esis.c + M /trunk/epan/dissectors/packet-fefd.c + M /trunk/epan/dissectors/packet-fr.c + M /trunk/epan/dissectors/packet-ftam.c + M /trunk/epan/dissectors/packet-fw1.c + M /trunk/epan/dissectors/packet-gift.c + M /trunk/epan/dissectors/packet-gnutella.c + M /trunk/epan/dissectors/packet-goose.c + M /trunk/epan/dissectors/packet-gprs-ns.c + M /trunk/epan/dissectors/packet-gtp.c + M /trunk/epan/dissectors/packet-gtpv2.c + M /trunk/epan/dissectors/packet-h223.c + M /trunk/epan/dissectors/packet-hci_h1.c + M /trunk/epan/dissectors/packet-hyperscsi.c + M /trunk/epan/dissectors/packet-iapp.c + M /trunk/epan/dissectors/packet-icp.c + M /trunk/epan/dissectors/packet-idp.c + M /trunk/epan/dissectors/packet-ieee80211.c + M /trunk/epan/dissectors/packet-ieee8021ah.c + M /trunk/epan/dissectors/packet-igrp.c + M /trunk/epan/dissectors/packet-imf.c + M /trunk/epan/dissectors/packet-infiniband.c + M /trunk/epan/dissectors/packet-ipars.c + M /trunk/epan/dissectors/packet-ipsec-tcp.c + M /trunk/epan/dissectors/packet-ipsec-udp.c + M /trunk/epan/dissectors/packet-ipsec.c + M /trunk/epan/dissectors/packet-ipv6.c + M /trunk/epan/dissectors/packet-ipx.c + M /trunk/epan/dissectors/packet-ipxwan.c + M /trunk/epan/dissectors/packet-isakmp.c + M /trunk/epan/dissectors/packet-isis.c + M /trunk/epan/dissectors/packet-isl.c + M /trunk/epan/dissectors/packet-isns.c + M /trunk/epan/dissectors/packet-juniper.c + M /trunk/epan/dissectors/packet-kerberos.c + M /trunk/epan/dissectors/packet-kerberos4.c + M /trunk/epan/dissectors/packet-kpasswd.c + M /trunk/epan/dissectors/packet-l2tp.c + M /trunk/epan/dissectors/packet-lapb.c + M /trunk/epan/dissectors/packet-lapbether.c + M /trunk/epan/dissectors/packet-lapd.c + M /trunk/epan/dissectors/packet-ldp.c + M /trunk/epan/dissectors/packet-linx.c + M /trunk/epan/dissectors/packet-lmi.c + M /trunk/epan/dissectors/packet-lmp.c + M /trunk/epan/dissectors/packet-loop.c + M /trunk/epan/dissectors/packet-lpd.c + M /trunk/epan/dissectors/packet-lsc.c + M /trunk/epan/dissectors/packet-maccontrol.c + M /trunk/epan/dissectors/packet-mbtcp.c + M /trunk/epan/dissectors/packet-mdshdr.c + M /trunk/epan/dissectors/packet-mgcp.c + M /trunk/epan/dissectors/packet-mip.c + M /trunk/epan/dissectors/packet-mip6.c + M /trunk/epan/dissectors/packet-mms.c + M /trunk/epan/dissectors/packet-mpeg-audio.c + M /trunk/epan/dissectors/packet-mpeg-pes.c + M /trunk/epan/dissectors/packet-mq-pcf.c + M /trunk/epan/dissectors/packet-msproxy.c + M /trunk/epan/dissectors/packet-nbipx.c + M /trunk/epan/dissectors/packet-nbns.c + M /trunk/epan/dissectors/packet-ncp.c + M /trunk/epan/dissectors/packet-ndps.c + M /trunk/epan/dissectors/packet-netflow.c + M /trunk/epan/dissectors/packet-nlsp.c + M /trunk/epan/dissectors/packet-nsip.c + M /trunk/epan/dissectors/packet-nt-tpcp.c + M /trunk/epan/dissectors/packet-ntp.c + M /trunk/epan/dissectors/packet-olsr.c + M /trunk/epan/dissectors/packet-ospf.c + M /trunk/epan/dissectors/packet-paltalk.c + M /trunk/epan/dissectors/packet-pcep.c + M /trunk/epan/dissectors/packet-pim.c + M /trunk/epan/dissectors/packet-ppi.c + M /trunk/epan/dissectors/packet-ppp.c + M /trunk/epan/dissectors/packet-pptp.c + M /trunk/epan/dissectors/packet-pres.c + M /trunk/epan/dissectors/packet-pvfs2.c + M /trunk/epan/dissectors/packet-qllc.c + M /trunk/epan/dissectors/packet-quake.c + M /trunk/epan/dissectors/packet-radius.c + M /trunk/epan/dissectors/packet-rdm.c + M /trunk/epan/dissectors/packet-rip.c + M /trunk/epan/dissectors/packet-ripng.c + M /trunk/epan/dissectors/packet-rmt-alc.c + M /trunk/epan/dissectors/packet-rmt-norm.c + M /trunk/epan/dissectors/packet-ros.c + M /trunk/epan/dissectors/packet-rpcap.c + M /trunk/epan/dissectors/packet-rsl.c + M /trunk/epan/dissectors/packet-rsvp.c + M /trunk/epan/dissectors/packet-rsync.c + M /trunk/epan/dissectors/packet-rtmpt.c + M /trunk/epan/dissectors/packet-rtp-events.c + M /trunk/epan/dissectors/packet-rtse.c + M /trunk/epan/dissectors/packet-rudp.c + M /trunk/epan/dissectors/packet-rx.c + M /trunk/epan/dissectors/packet-sap.c + M /trunk/epan/dissectors/packet-sbus.c + M /trunk/epan/dissectors/packet-sdlc.c + M /trunk/epan/dissectors/packet-ses.c + M /trunk/epan/dissectors/packet-sigcomp.c + M /trunk/epan/dissectors/packet-sita.c + M /trunk/epan/dissectors/packet-sll.c + M /trunk/epan/dissectors/packet-smb-logon.c + M /trunk/epan/dissectors/packet-sna.c + M /trunk/epan/dissectors/packet-sndcp.c + M /trunk/epan/dissectors/packet-sqloracle.c + M /trunk/epan/dissectors/packet-srvloc.c + M /trunk/epan/dissectors/packet-ssl.c + M /trunk/epan/dissectors/packet-sua.c + M /trunk/epan/dissectors/packet-syslog.c + M /trunk/epan/dissectors/packet-tacacs.c + M /trunk/epan/dissectors/packet-tcp.c + M /trunk/epan/dissectors/packet-teimanagement.c + M /trunk/epan/dissectors/packet-telkonet.c + M /trunk/epan/dissectors/packet-teredo.c + M /trunk/epan/dissectors/packet-tipc.c + M /trunk/epan/dissectors/packet-tn3270.c + M /trunk/epan/dissectors/packet-trmac.c + M /trunk/epan/dissectors/packet-tsp.c + M /trunk/epan/dissectors/packet-tzsp.c + M /trunk/epan/dissectors/packet-udld.c + M /trunk/epan/dissectors/packet-uma.c + M /trunk/epan/dissectors/packet-usb-masstorage.c + M /trunk/epan/dissectors/packet-v120.c + M /trunk/epan/dissectors/packet-vicp.c + M /trunk/epan/dissectors/packet-vines.c + M /trunk/epan/dissectors/packet-vlan.c + M /trunk/epan/dissectors/packet-vnc.c + M /trunk/epan/dissectors/packet-vrrp.c + M /trunk/epan/dissectors/packet-wcp.c + M /trunk/epan/dissectors/packet-wfleet-hdlc.c + M /trunk/epan/dissectors/packet-who.c + M /trunk/epan/dissectors/packet-wol.c + M /trunk/epan/dissectors/packet-wow.c + M /trunk/epan/dissectors/packet-wsp.c + M /trunk/epan/dissectors/packet-wtp.c + M /trunk/epan/dissectors/packet-x29.c + M /trunk/epan/dissectors/packet-x411.c + M /trunk/epan/dissectors/packet-xcsl.c + M /trunk/epan/dissectors/packet-xdmcp.c + M /trunk/epan/dissectors/packet-xtp.c + M /trunk/plugins/asn1/packet-asn1.c + M /trunk/plugins/docsis/packet-macmgmt.c + M /trunk/plugins/ethercat/packet-ams.c + M /trunk/plugins/ethercat/packet-ethercat-datagram.c + M /trunk/plugins/ethercat/packet-ioraw.c + M /trunk/plugins/ethercat/packet-nv.c + M /trunk/plugins/gryphon/packet-gryphon.c + M /trunk/plugins/irda/packet-irda.c + M /trunk/plugins/sercosiii/packet-sercosiii_1v1.c +Don't guard col_clear with col_check ------------------------------------------------------------------------ -r22769 | wmeier | 2007-09-02 13:53:15 -0700 (Sun, 02 Sep 2007) | 2 lines +r29345 | krj | 2009-08-09 00:59:51 -0700 (Sun, 09 Aug 2009) | 1 line Changed paths: - M /trunk/Makefile.nmake - M /trunk/tools/win32-setup.sh - -Verify existence of required downloaded library packages during make after Makefile.nmake updated + M /trunk/asn1/ansi-tcap/packet-ansi_tcap-template.c + M /trunk/asn1/ansi_map/packet-ansi_map-template.c + M /trunk/asn1/camel/packet-camel-template.c + M /trunk/asn1/gsmmap/packet-gsmmap-template.c + M /trunk/asn1/inap/packet-inap-template.c + M /trunk/asn1/t125/packet-t125-template.c + M /trunk/asn1/t38/packet-t38-template.c + M /trunk/asn1/tcap/packet-tcap-template.c + M /trunk/epan/dissectors/packet-2dparityfec.c + M /trunk/epan/dissectors/packet-acn.c + M /trunk/epan/dissectors/packet-afs.c + M /trunk/epan/dissectors/packet-aim.c + M /trunk/epan/dissectors/packet-ansi_map.c + M /trunk/epan/dissectors/packet-ansi_tcap.c + M /trunk/epan/dissectors/packet-artnet.c + M /trunk/epan/dissectors/packet-bat.c + M /trunk/epan/dissectors/packet-bittorrent.c + M /trunk/epan/dissectors/packet-bssap.c + M /trunk/epan/dissectors/packet-bthci_acl.c + M /trunk/epan/dissectors/packet-bthci_cmd.c + M /trunk/epan/dissectors/packet-bthci_evt.c + M /trunk/epan/dissectors/packet-btl2cap.c + M /trunk/epan/dissectors/packet-camel.c + M /trunk/epan/dissectors/packet-cast.c + M /trunk/epan/dissectors/packet-cfm.c + M /trunk/epan/dissectors/packet-cigi.c + M /trunk/epan/dissectors/packet-cisco-wids.c + M /trunk/epan/dissectors/packet-ctdb.c + M /trunk/epan/dissectors/packet-dcm.c + M /trunk/epan/dissectors/packet-dcp-etsi.c + M /trunk/epan/dissectors/packet-dec-bpdu.c + M /trunk/epan/dissectors/packet-dec-dnart.c + M /trunk/epan/dissectors/packet-dect.c + M /trunk/epan/dissectors/packet-dtls.c + M /trunk/epan/dissectors/packet-dvmrp.c + M /trunk/epan/dissectors/packet-e100.c + M /trunk/epan/dissectors/packet-echo.c + M /trunk/epan/dissectors/packet-egd.c + M /trunk/epan/dissectors/packet-enttec.c + M /trunk/epan/dissectors/packet-epl.c + M /trunk/epan/dissectors/packet-epl_v1.c + M /trunk/epan/dissectors/packet-evrc.c + M /trunk/epan/dissectors/packet-fc.c + M /trunk/epan/dissectors/packet-fcels.c + M /trunk/epan/dissectors/packet-ff.c + M /trunk/epan/dissectors/packet-fix.c + M /trunk/epan/dissectors/packet-giop.c + M /trunk/epan/dissectors/packet-gprs-llc.c + M /trunk/epan/dissectors/packet-gsm_map.c + M /trunk/epan/dissectors/packet-h261.c + M /trunk/epan/dissectors/packet-h263p.c + M /trunk/epan/dissectors/packet-hpext.c + M /trunk/epan/dissectors/packet-hpsw.c + M /trunk/epan/dissectors/packet-iax2.c + M /trunk/epan/dissectors/packet-icq.c + M /trunk/epan/dissectors/packet-iec104.c + M /trunk/epan/dissectors/packet-ieee802154.c + M /trunk/epan/dissectors/packet-ieee802a.c + M /trunk/epan/dissectors/packet-ifcp.c + M /trunk/epan/dissectors/packet-igap.c + M /trunk/epan/dissectors/packet-igmp.c + M /trunk/epan/dissectors/packet-inap.c + M /trunk/epan/dissectors/packet-ipmi.c + M /trunk/epan/dissectors/packet-ipsi-ctl.c + M /trunk/epan/dissectors/packet-ipvs-syncd.c + M /trunk/epan/dissectors/packet-isakmp.c + M /trunk/epan/dissectors/packet-iuup.c + M /trunk/epan/dissectors/packet-iwarp-ddp-rdmap.c + M /trunk/epan/dissectors/packet-jpeg.c + M /trunk/epan/dissectors/packet-jxta.c + M /trunk/epan/dissectors/packet-kdp.c + M /trunk/epan/dissectors/packet-kerberos.c + M /trunk/epan/dissectors/packet-kink.c + M /trunk/epan/dissectors/packet-kpasswd.c + M /trunk/epan/dissectors/packet-llc.c + M /trunk/epan/dissectors/packet-manolito.c + M /trunk/epan/dissectors/packet-mpeg1.c + M /trunk/epan/dissectors/packet-mpls.c + M /trunk/epan/dissectors/packet-mrdisc.c + M /trunk/epan/dissectors/packet-ms-mms.c + M /trunk/epan/dissectors/packet-msnip.c + M /trunk/epan/dissectors/packet-mstp.c + M /trunk/epan/dissectors/packet-mysql.c + M /trunk/epan/dissectors/packet-nbd.c + M /trunk/epan/dissectors/packet-ncp-nmas.c + M /trunk/epan/dissectors/packet-ncp-sss.c + M /trunk/epan/dissectors/packet-ncp.c + M /trunk/epan/dissectors/packet-netdump.c + M /trunk/epan/dissectors/packet-netsync.c + M /trunk/epan/dissectors/packet-nhrp.c + M /trunk/epan/dissectors/packet-omapi.c + M /trunk/epan/dissectors/packet-osi.c + M /trunk/epan/dissectors/packet-ppp.c + M /trunk/epan/dissectors/packet-pppoe.c + M /trunk/epan/dissectors/packet-pw-atm.c + M /trunk/epan/dissectors/packet-pw-cesopsn.c + M /trunk/epan/dissectors/packet-pw-fr.c + M /trunk/epan/dissectors/packet-pw-satop.c + M /trunk/epan/dissectors/packet-quake3.c + M /trunk/epan/dissectors/packet-rdt.c + M /trunk/epan/dissectors/packet-retix-bpdu.c + M /trunk/epan/dissectors/packet-rfc2190.c + M /trunk/epan/dissectors/packet-rgmp.c + M /trunk/epan/dissectors/packet-rlogin.c + M /trunk/epan/dissectors/packet-rmp.c + M /trunk/epan/dissectors/packet-rpc.c + M /trunk/epan/dissectors/packet-rtcp.c + M /trunk/epan/dissectors/packet-rtnet.c + M /trunk/epan/dissectors/packet-rtp-events.c + M /trunk/epan/dissectors/packet-rtp.c + M /trunk/epan/dissectors/packet-rtps.c + M /trunk/epan/dissectors/packet-rtps2.c + M /trunk/epan/dissectors/packet-s5066.c + M /trunk/epan/dissectors/packet-skinny.c + M /trunk/epan/dissectors/packet-smb-browse.c + M /trunk/epan/dissectors/packet-smb-mailslot.c + M /trunk/epan/dissectors/packet-smb-pipe.c + M /trunk/epan/dissectors/packet-smb.c + M /trunk/epan/dissectors/packet-smb2.c + M /trunk/epan/dissectors/packet-ssl.c + M /trunk/epan/dissectors/packet-starteam.c + M /trunk/epan/dissectors/packet-t125.c + M /trunk/epan/dissectors/packet-t38.c + M /trunk/epan/dissectors/packet-tcap.c + M /trunk/epan/dissectors/packet-tcp.c + M /trunk/epan/dissectors/packet-teamspeak2.c + M /trunk/epan/dissectors/packet-vnc.c + M /trunk/epan/dissectors/packet-wccp.c + M /trunk/epan/dissectors/packet-winsrepl.c + M /trunk/epan/dissectors/packet-wtls.c + M /trunk/epan/dissectors/packet-x224.c + M /trunk/epan/dissectors/packet-zbee-aps.c + M /trunk/epan/dissectors/packet-zbee-nwk.c + M /trunk/epan/dissectors/packet-zbee-zdp.c + M /trunk/plugins/ethercat/packet-ethercat-frame.c + M /trunk/plugins/m2m/packet-m2m.c + M /trunk/plugins/opcua/opcua.c + M /trunk/plugins/wimax/packet-wmx.c + M /trunk/plugins/wimaxasncp/packet-wimaxasncp.c +Don't guard col_set_str (COL_INFO/COL_PROTOCOL) with col_check ------------------------------------------------------------------------ -r22770 | guy | 2007-09-02 15:49:56 -0700 (Sun, 02 Sep 2007) | 16 lines +r29346 | krj | 2009-08-09 01:14:59 -0700 (Sun, 09 Aug 2009) | 1 line Changed paths: + M /trunk/asn1/h225/packet-h225-template.c + M /trunk/asn1/t125/packet-t125-template.c + M /trunk/asn1/t38/packet-t38-template.c + M /trunk/epan/dissectors/packet-afs.c + M /trunk/epan/dissectors/packet-amqp.c + M /trunk/epan/dissectors/packet-artnet.c + M /trunk/epan/dissectors/packet-bpdu.c + M /trunk/epan/dissectors/packet-cfm.c + M /trunk/epan/dissectors/packet-ctdb.c + M /trunk/epan/dissectors/packet-dcp-etsi.c + M /trunk/epan/dissectors/packet-dec-bpdu.c + M /trunk/epan/dissectors/packet-dec-dnart.c + M /trunk/epan/dissectors/packet-dect.c + M /trunk/epan/dissectors/packet-dplay.c + M /trunk/epan/dissectors/packet-dvmrp.c + M /trunk/epan/dissectors/packet-epl_v1.c + M /trunk/epan/dissectors/packet-fix.c + M /trunk/epan/dissectors/packet-h225.c + M /trunk/epan/dissectors/packet-iax2.c + M /trunk/epan/dissectors/packet-icq.c + M /trunk/epan/dissectors/packet-iec104.c + M /trunk/epan/dissectors/packet-ieee802a.c + M /trunk/epan/dissectors/packet-igap.c + M /trunk/epan/dissectors/packet-igmp.c + M /trunk/epan/dissectors/packet-ipvs-syncd.c + M /trunk/epan/dissectors/packet-kdp.c + M /trunk/epan/dissectors/packet-llc.c + M /trunk/epan/dissectors/packet-lldp.c + M /trunk/epan/dissectors/packet-mrdisc.c + M /trunk/epan/dissectors/packet-msnip.c + M /trunk/epan/dissectors/packet-nbd.c + M /trunk/epan/dissectors/packet-ndmp.c + M /trunk/epan/dissectors/packet-netdump.c + M /trunk/epan/dissectors/packet-nhrp.c + M /trunk/epan/dissectors/packet-omapi.c + M /trunk/epan/dissectors/packet-pagp.c M /trunk/epan/dissectors/packet-pppoe.c + M /trunk/epan/dissectors/packet-rdt.c + M /trunk/epan/dissectors/packet-retix-bpdu.c + M /trunk/epan/dissectors/packet-rgmp.c + M /trunk/epan/dissectors/packet-rmp.c + M /trunk/epan/dissectors/packet-rtnet.c + M /trunk/epan/dissectors/packet-rtps.c + M /trunk/epan/dissectors/packet-rtps2.c + M /trunk/epan/dissectors/packet-s5066.c + M /trunk/epan/dissectors/packet-smb-browse.c + M /trunk/epan/dissectors/packet-smb-mailslot.c + M /trunk/epan/dissectors/packet-smb.c + M /trunk/epan/dissectors/packet-t125.c + M /trunk/epan/dissectors/packet-t38.c + M /trunk/epan/dissectors/packet-teamspeak2.c + M /trunk/epan/dissectors/packet-wccp.c + M /trunk/epan/dissectors/packet-winsrepl.c + M /trunk/epan/dissectors/packet-wsp.c + M /trunk/epan/dissectors/packet-x224.c + M /trunk/epan/dissectors/packet-zbee-nwk.c + M /trunk/epan/dissectors/packet-zbee-zcl.c + M /trunk/plugins/ethercat/packet-ethercat-frame.c + M /trunk/plugins/m2m/packet-m2m.c + M /trunk/plugins/profinet/packet-pn-mrp.c + M /trunk/plugins/unistim/packet-unistim.c + M /trunk/plugins/wimax/packet-wmx.c + M /trunk/plugins/wimaxasncp/packet-wimaxasncp.c -The actual length of the PPPoE payload is returned by -tvb_reported_length_remaining(), not by tvb_length_remaining() - -tvb_length_remaining() shows only the amount of *captured* data -remaining, but the capture might have been done with a snapshot length -that cut the packet data short. - -The payload length from the PPPoE header could legitimately be different -from the actual length of the PPPoE payload if there's not enough PPPoE -payload to avoid padding at the E(thernet) level. Only complain if -there shouldn't have been any padding. - -Report an "expert" warning if the payload length looks wrong. - -Update a comment to reflect current reality (as of many many years ago, -when we went all-tvbuff). - +Don't guard col_clear with col_check ------------------------------------------------------------------------ -r22771 | guy | 2007-09-02 16:32:43 -0700 (Sun, 02 Sep 2007) | 11 lines +r29347 | krj | 2009-08-09 03:50:30 -0700 (Sun, 09 Aug 2009) | 4 lines Changed paths: - M /trunk/capture_loop.c - -For bug 1685, check for the errors reported on at least some platforms -when an interface goes down or goes away, and, in that case, just report -that, rather than reporting a more technical error and indicating that -the error should be reported to the Wireshark developers. + M /trunk/epan/dissectors/packet-fcels.c -Line-break the "please report this to the Wireshark developers" error -differently (so that it doesn't look weird if the dialog box line-wraps -it). +Don't use DISSECTOR_ASSERT to check source/destination address type. -Fix indentation. +Fixes https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=3825 ------------------------------------------------------------------------ -r22772 | wmeier | 2007-09-02 16:37:40 -0700 (Sun, 02 Sep 2007) | 2 lines +r29348 | gerald | 2009-08-09 08:03:28 -0700 (Sun, 09 Aug 2009) | 1 line Changed paths: - M /trunk/gtk/uat_gui.c - -Fix my previous patch to enable esc on window - ------------------------------------------------------------------------- -r22773 | guy | 2007-09-02 16:51:51 -0700 (Sun, 02 Sep 2007) | 2 lines -Changed paths: - M /trunk/epan/dissectors/packet-pppoe.c - -tvb_reported_length() returns a gint, so assign its value to a gint. + M /trunk/epan/enterprise-numbers + M /trunk/manuf +[Automatic manuf and enterprise-numbers update for 2009-08-09] ------------------------------------------------------------------------ -r22774 | wmeier | 2007-09-02 17:17:47 -0700 (Sun, 02 Sep 2007) | 2 lines +r29351 | wmeier | 2009-08-09 08:07:35 -0700 (Sun, 09 Aug 2009) | 2 lines Changed paths: - M /trunk/gtk/filter_dlg.c + M /trunk/plugins/wimax/msg_arq.c + M /trunk/plugins/wimax/msg_dreg.c + M /trunk/plugins/wimax/msg_pmc.c -default window_cancel_butoon_cb is not appropriate since a specific cancel cb is specified. +'if(proto_... == -1)' not req'd; Don't register ett[] more than once; ------------------------------------------------------------------------ -r22775 | jake | 2007-09-02 22:56:48 -0700 (Sun, 02 Sep 2007) | 2 lines +r29352 | wmeier | 2009-08-09 08:49:02 -0700 (Sun, 09 Aug 2009) | 2 lines Changed paths: - M /trunk/epan/dissectors/packet-mtp2.c - -Fix for bug 1816: -Add status value to LSSU info column. ------------------------------------------------------------------------- -r22776 | guy | 2007-09-02 23:44:54 -0700 (Sun, 02 Sep 2007) | 2 lines -Changed paths: - M /trunk/epan/dissectors/packet-iuup.c - -guint8, not gchar, is the appropriate type for a byte. + M /trunk/epan/proto.c ------------------------------------------------------------------------- -r22777 | etxrab | 2007-09-03 09:39:07 -0700 (Mon, 03 Sep 2007) | 2 lines -Changed paths: - M /trunk/epan/dissectors/packet-bssgp.c +g_error() if registering a subtree item type already registered (or not initialized to -1). -BSSGP.TLLI is not recognized properly in filter -http://bugs.wireshark.org/bugzilla/show_bug.cgi?id=1384 ------------------------------------------------------------------------ -r22778 | etxrab | 2007-09-03 09:40:51 -0700 (Mon, 03 Sep 2007) | 2 lines +r29353 | wmeier | 2009-08-09 09:48:28 -0700 (Sun, 09 Aug 2009) | 2 lines Changed paths: - M /trunk/asn1/ranap/packet-ranap-template.c - M /trunk/asn1/ranap/ranap.cnf - M /trunk/epan/dissectors/packet-ranap.c + M /trunk/plugins/sercosiii/packet-sercosiii_1v1.c + M /trunk/plugins/sercosiii/packet-sercosiii_1v1_at.c + M /trunk/plugins/sercosiii/packet-sercosiii_1v1_at_devstat.c + M /trunk/plugins/sercosiii/packet-sercosiii_1v1_hp.c + M /trunk/plugins/sercosiii/packet-sercosiii_1v1_mdt.c + M /trunk/plugins/sercosiii/packet-sercosiii_1v1_mdt_devctrl.c + M /trunk/plugins/sercosiii/packet-sercosiii_1v1_mst.c + M /trunk/plugins/sercosiii/packet-sercosiii_1v1_svc.c -Incorrectly decoded IMSI in RANAP prot./id-CommonID procedure -http://bugs.wireshark.org/bugzilla/show_bug.cgi?id=1713 ------------------------------------------------------------------------- -r22779 | etxrab | 2007-09-03 09:42:28 -0700 (Mon, 03 Sep 2007) | 2 lines -Changed paths: - M /trunk/epan/dissectors/packet-gtp.c +(Trivial): Remove uneeded #includes; make a few fcns static; -Wireshark packet-gtp.c error in decoding IMEI. -http://bugs.wireshark.org/bugzilla/show_bug.cgi?id=1536 ------------------------------------------------------------------------ -r22780 | etxrab | 2007-09-03 22:22:43 -0700 (Mon, 03 Sep 2007) | 6 lines +r29354 | krj | 2009-08-09 10:33:23 -0700 (Sun, 09 Aug 2009) | 1 line Changed paths: - M /trunk/epan/dissectors/packet-sdp.c + M /trunk/epan/proto.c + M /trunk/epan/proto.h + M /trunk/file.c + M /trunk/gtk/iax2_analysis.c + M /trunk/gtk/main_proto_draw.c M /trunk/gtk/rtp_analysis.c + M /trunk/print.c + M /trunk/proto_hier_stats.c + M /trunk/tap-protohierstat.c -From Stas Maximov: -RTP analysis' jitter values are thrown off by RTP events -http://bugs.wireshark.org/bugzilla/show_bug.cgi?id=1076 -a) Ephemeral string (packet duration) was inserted into long-term hash of -dynamic payloads -b) There was no clock_rate mapping for MIME type "telephone-event". +Add PNODE_FINFO. We've been using PITEM_FINFO on proto_node's. This works because proto_item is typedefed to proto_node. We shouldn't rely on this since this is an implementation detail. ------------------------------------------------------------------------ -r22781 | jake | 2007-09-03 23:55:52 -0700 (Mon, 03 Sep 2007) | 8 lines +r29355 | krj | 2009-08-09 10:57:31 -0700 (Sun, 09 Aug 2009) | 1 line Changed paths: - M /trunk/epan/dissectors/packet-hsrp.c - -From Munenori Ohuchi: -This patch adds a new feature to dissect HSRPv2 packets. - -One of the main features of HSRPv2 can enable using HSRP on IPv6. In order to -achieve this new feature, HSRPv2 packet format is totally different from -HSRPv1. HSRPv2 introduces new TLV formats. - -This patch can decode these new formats of HSPRv2. ------------------------------------------------------------------------- -r22782 | wmeier | 2007-09-04 05:37:19 -0700 (Tue, 04 Sep 2007) | 2 lines -Changed paths: - M /trunk/gtk/uat_gui.c - -enable esc for new/edit/delete dialogs; remove some redundant code; + M /trunk/asn1/snmp/packet-snmp-template.c + M /trunk/epan/dfilter/dfilter-macro.c + M /trunk/epan/dissectors/packet-diameter.c + M /trunk/epan/dissectors/packet-snmp.c + M /trunk/epan/expert.c + M /trunk/epan/proto.c + M /trunk/epan/proto.h + M /trunk/gtk/expert_comp_table.c + M /trunk/plugins/wimax/packet-wmx.c + M /trunk/plugins/wimax/wimax_harq_map_decoder.c + M /trunk/proto_hier_stats.c +Add PTREE_FINFO and use PITEM_FINFO when possible. ------------------------------------------------------------------------ -r22783 | etxrab | 2007-09-04 09:55:48 -0700 (Tue, 04 Sep 2007) | 2 lines +r29356 | krj | 2009-08-09 11:05:44 -0700 (Sun, 09 Aug 2009) | 1 line Changed paths: - M /trunk/asn1/ansi_map/ansi_map.asn - M /trunk/epan/dissectors/packet-ansi_map.c + M /trunk/epan/dissectors/packet-ncp2222.inc -ANSI MAP systemMyTypeCode should be OPTIONAL -http://bugs.wireshark.org/bugzilla/show_bug.cgi?id=1820 +Use PTREE_FINFO. ------------------------------------------------------------------------ -r22784 | etxrab | 2007-09-04 09:57:07 -0700 (Tue, 04 Sep 2007) | 1 line +r29357 | krj | 2009-08-09 11:15:36 -0700 (Sun, 09 Aug 2009) | 1 line Changed paths: - M /trunk/epan/dissectors/packet-per.c + M /trunk/epan/proto.h -Get correct value for bitstrings. +Use PITEM_FINFO. ------------------------------------------------------------------------ -r22785 | etxrab | 2007-09-04 12:36:07 -0700 (Tue, 04 Sep 2007) | 1 line +r29358 | krj | 2009-08-09 12:23:13 -0700 (Sun, 09 Aug 2009) | 1 line Changed paths: - M /trunk/epan/dissectors/packet-per.c + M /trunk/epan/emem.c -value_tvb=out_tvb, remove unused variables. +Split common parts of se_alloc and ep_alloc into emem_alloc. ------------------------------------------------------------------------ -r22786 | stig | 2007-09-04 14:46:41 -0700 (Tue, 04 Sep 2007) | 3 lines +r29359 | krj | 2009-08-09 13:10:19 -0700 (Sun, 09 Aug 2009) | 1 line Changed paths: - M /trunk/asn1/disp/disp.cnf - M /trunk/asn1/dop/dop.cnf - M /trunk/asn1/dop/packet-dop-template.c - M /trunk/epan/dissectors/packet-disp.c - M /trunk/epan/dissectors/packet-dop.c - -Rewrote handling of parameters to get rid of "funky" oid strings. -Added expert info for unknown binding-parameters. + M /trunk/epan/emem.c +Split common parts of ep_free_all and se_free_all into emem_free_all. ------------------------------------------------------------------------ -r22787 | stig | 2007-09-04 14:49:14 -0700 (Tue, 04 Sep 2007) | 2 lines +r29360 | krj | 2009-08-09 13:28:38 -0700 (Sun, 09 Aug 2009) | 1 line Changed paths: - M /trunk/epan/dissectors/packet-per.c - -Fixed compiler warnings to get the buildbot going. + M /trunk/epan/emem.c +g_error() requires a string literal. ------------------------------------------------------------------------ -r22788 | morriss | 2007-09-04 15:13:26 -0700 (Tue, 04 Sep 2007) | 1 line +r29361 | krj | 2009-08-09 14:10:04 -0700 (Sun, 09 Aug 2009) | 1 line Changed paths: - M /trunk/capture_ui_utils.c + M /trunk/epan/emem.c -Don't call get_interface_descriptive_name() on a NULL iface: fixes a segfault when doing Statistics->Summary when you didn't capture anything (but rather read in a file) +Add unsigned int typecast ------------------------------------------------------------------------ -r22789 | sahlberg | 2007-09-04 16:27:34 -0700 (Tue, 04 Sep 2007) | 7 lines +r29362 | jmayer | 2009-08-10 07:55:47 -0700 (Mon, 10 Aug 2009) | 10 lines Changed paths: - M /trunk/epan/dissectors/packet-sdp.c + M /trunk/epan/dissectors/packet-ip.c -we dont have g_hash_table_new_full() on gtk1 -use g_hash_table_new() on gtk1 and leak memory instead +Ivan Sy <ivan_jr@yahoo.com> via bug 3814 +TTL-Check for local network group addresses: Normally the +only valid TTL is 1. Add a check for VRRP and GLBP, where +the only valid TTL is 255. -this should actually a be using an se_tree instead of hashtables +Me: change the logic so the funtion returns the valid ttl + instead of true/false. ------------------------------------------------------------------------ -r22790 | sahlberg | 2007-09-04 16:35:29 -0700 (Tue, 04 Sep 2007) | 4 lines +r29363 | gerald | 2009-08-10 08:33:54 -0700 (Mon, 10 Aug 2009) | 2 lines Changed paths: - M /trunk/epan/privileges.c - -on unix, we dont have size_t until we have imported all the other -includes which breaks emem.h + M /trunk/epan/dissectors/packet-ip.c +Fix the build. ------------------------------------------------------------------------ -r22791 | sahlberg | 2007-09-04 17:29:31 -0700 (Tue, 04 Sep 2007) | 3 lines +r29364 | gerald | 2009-08-10 09:12:55 -0700 (Mon, 10 Aug 2009) | 3 lines Changed paths: - M /trunk/epan/dissectors/packet-nfs.c - -start prettifying nfsv4 + M /trunk/wiretap/erf.c +Don't try to allocate more than WTAP_MAX_PACKET_SIZE. Fixes a crash +reported in bug 3849. ------------------------------------------------------------------------ -r22792 | etxrab | 2007-09-04 22:48:44 -0700 (Tue, 04 Sep 2007) | 1 line +r29365 | krj | 2009-08-10 09:36:44 -0700 (Mon, 10 Aug 2009) | 1 line Changed paths: - M /trunk/asn1/dop/Makefile - M /trunk/asn1/dop/Makefile.nmake - M /trunk/asn1/dop/dop-exp.cnf - M /trunk/asn1/dop/packet-dop-template.c - M /trunk/epan/dissectors/packet-dop.c - M /trunk/epan/dissectors/packet-dop.h + M /trunk/epan/emem.c -Include expert.h and while at it change to use -X and -T options for asn2wrs. +Use ! defined(EP_DEBUG_FREE) && ! defined(SE_DEBUG_FREE) to guard canary code to get things compiling after r29358. ------------------------------------------------------------------------ -r22793 | jake | 2007-09-04 23:59:24 -0700 (Tue, 04 Sep 2007) | 9 lines +r29366 | guy | 2009-08-10 11:22:05 -0700 (Mon, 10 Aug 2009) | 5 lines Changed paths: - M /trunk/epan/dissectors/packet-netflow.c + M /trunk/wiretap/erf.c -From Munenori Ohuchi: -packet-netflow.c is lack of the capability to decode ipv6 address related fields in netflow v9. +Update a comment - a bad packet size could also be the result of a file +not actually being an ERF file. -This patch enables dissecting the following fields: - Type 27 IPV6_SRC_ADDR, - Type 28 IPV6_DST_ADDR, - Type 29 IPV6_SRC_MASK, - Type 30 IPV6_DST_MASK and - Type 62 IPV6_NEXT_HOP. ------------------------------------------------------------------------- -r22794 | stig | 2007-09-05 00:35:59 -0700 (Wed, 05 Sep 2007) | 2 lines -Changed paths: - M /trunk/asn1/rtse/rtse.cnf - M /trunk/epan/dissectors/packet-rtse.c - -Check object_identifier_id before use. +Don't compute the packet size until you know that rlen is valid. ------------------------------------------------------------------------ -r22795 | wmeier | 2007-09-05 07:59:37 -0700 (Wed, 05 Sep 2007) | 3 lines +r29367 | wmeier | 2009-08-10 11:45:47 -0700 (Mon, 10 Aug 2009) | 5 lines Changed paths: - M /trunk/gtk/filter_dlg.c - -Prevent Gtk-Critical msg when invoking "+Expression" from Filter Toolbar in main window; -Fixes bug reported by Toralf F?\195?\182rster + M /trunk/epan/dissectors/packet-redbackli.c ------------------------------------------------------------------------- -r22796 | etxrab | 2007-09-05 15:24:40 -0700 (Wed, 05 Sep 2007) | 2 lines -Changed paths: - M /trunk/asn1/ansi_map/ansi_map.asn - M /trunk/asn1/ansi_map/packet-ansi_map-template.c - M /trunk/epan/dissectors/packet-ansi_map.c +(Quick) fix for bug #3836; +Allow the DIR ("direction") AVP to be of variable length + (in the absence of any documentation for this protocol). + See the source for further comments. -Fix the asn1 code for WIN-TriggerList and systemMyTypeCode plus -a copy-paste error in the hf fields. ------------------------------------------------------------------------ -r22797 | guy | 2007-09-05 15:43:51 -0700 (Wed, 05 Sep 2007) | 2 lines +r29368 | etxrab | 2009-08-10 12:48:42 -0700 (Mon, 10 Aug 2009) | 3 lines Changed paths: - M /trunk/epan/dissectors/packet-ieee80211.c - -Fix indentation. + M /trunk/epan/dissectors/packet-gsm_a_common.c +From Gerasimos Dimitriadis: +DTAP decoding of Mobile Station Classmark 3. +https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=3819 ------------------------------------------------------------------------ -r22798 | ulfl | 2007-09-05 16:03:58 -0700 (Wed, 05 Sep 2007) | 1 line +r29369 | etxrab | 2009-08-10 12:53:12 -0700 (Mon, 10 Aug 2009) | 3 lines Changed paths: - M /trunk/config.nmake + M /trunk/epan/dissectors/packet-giop.c -remove comment which compiler version works - they all work +From Steve Osselton: +GIOP dissector update for MIOP. +https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=3847 ------------------------------------------------------------------------ -r22799 | ulfl | 2007-09-05 16:09:39 -0700 (Wed, 05 Sep 2007) | 3 lines +r29370 | etxrab | 2009-08-10 13:52:56 -0700 (Mon, 10 Aug 2009) | 3 lines Changed paths: - M /trunk/Makefile.nmake - -- "quote" source dir of packaging_zip1 and packaging_zip2, so it also works with spaces in this path + M /trunk/color_filters.c + M /trunk/epan/column-utils.c + M /trunk/file.c + M /trunk/gtk/new_packet_list.c + M /trunk/gtk/packet_list_store.c + M /trunk/gtk/packet_list_store.h + M /trunk/ui_util.h -- epan now depends on zlib and wiretap, add dependencies accordingly +From Kovarththanan Rajaratnam: +- Compute and cache color/custom filters dynamically. +- Delay column construction. ------------------------------------------------------------------------ -r22800 | martinm | 2007-09-06 03:05:41 -0700 (Thu, 06 Sep 2007) | 2 lines +r29371 | wmeier | 2009-08-10 14:07:15 -0700 (Mon, 10 Aug 2009) | 3 lines Changed paths: - A /trunk/plugins/wimaxasncp - A /trunk/plugins/wimaxasncp/AUTHORS - A /trunk/plugins/wimaxasncp/COPYING - A /trunk/plugins/wimaxasncp/ChangeLog - A /trunk/plugins/wimaxasncp/Makefile.am - A /trunk/plugins/wimaxasncp/Makefile.common - A /trunk/plugins/wimaxasncp/Makefile.nmake - A /trunk/plugins/wimaxasncp/moduleinfo.h - A /trunk/plugins/wimaxasncp/moduleinfo.nmake - A /trunk/plugins/wimaxasncp/packet-wimaxasncp.c - A /trunk/plugins/wimaxasncp/packet-wimaxasncp.h - A /trunk/plugins/wimaxasncp/plugin.rc.in + M /trunk/epan/dissectors/packet-pppoe.c -Add wimaxasncp plugin folder contents (other changes will follow) +Validate two tag field lengths before attempting to do proto_tree_add_item(); +Fixes bug #3841. ------------------------------------------------------------------------ -r22801 | martinm | 2007-09-06 03:14:49 -0700 (Thu, 06 Sep 2007) | 2 lines +r29372 | wmeier | 2009-08-10 14:46:30 -0700 (Mon, 10 Aug 2009) | 2 lines Changed paths: - M /trunk/AUTHORS - M /trunk/configure.in - M /trunk/plugins/Makefile.am - M /trunk/plugins/Makefile.nmake + M /trunk/epan/dissectors/packet-pppoe.c -Build WiMAX ASN Control Plane dissector plugin +Initialize a variable to keep GCC happy .... ------------------------------------------------------------------------ -r22802 | martinm | 2007-09-06 03:50:17 -0700 (Thu, 06 Sep 2007) | 2 lines +r29373 | guy | 2009-08-10 15:15:22 -0700 (Mon, 10 Aug 2009) | 10 lines Changed paths: - M /trunk/epan/dissectors/packet-catapult-dct2000.c + M /trunk/epan/dissectors/packet-pppoe.c -Map "wimax" -> "wimaxasncp" +For TLV items that are a single integral value and thus must have a +certain length: ------------------------------------------------------------------------- -r22803 | stig | 2007-09-06 03:53:42 -0700 (Thu, 06 Sep 2007) | 2 lines -Changed paths: - M /trunk/plugins/wimaxasncp + attach the expert item to the length field if we're showing it, + otherwise put in a text item for the malformed TLV and attach + the expert item to that; -Add default svn:ignore files to wimaxasncp plugin. + don't give up, as we'll just skip the bad item and move on to + the next item. ------------------------------------------------------------------------ -r22804 | wmeier | 2007-09-06 05:46:29 -0700 (Thu, 06 Sep 2007) | 2 lines +r29374 | etxrab | 2009-08-11 00:41:46 -0700 (Tue, 11 Aug 2009) | 3 lines Changed paths: - M /trunk/gtk/sctp_stat_dlg.c - -Enable esc key for SCTP Associations window. + M /trunk/epan/dissectors/packet-gtpv2.c +From swapnil: +Another Minor Bug for ULI in Packet-gtpv2.c +https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=3862 ------------------------------------------------------------------------ -r22805 | stig | 2007-09-06 07:02:35 -0700 (Thu, 06 Sep 2007) | 2 lines +r29375 | krj | 2009-08-11 02:24:56 -0700 (Tue, 11 Aug 2009) | 9 lines Changed paths: - M /trunk/epan/libwireshark.def + M /trunk/epan/emem.c + M /trunk/epan/emem.h -Added ipprotostr to libwireshark.def +We now expose the following environment variables: ------------------------------------------------------------------------- -r22806 | martinm | 2007-09-06 07:14:09 -0700 (Thu, 06 Sep 2007) | 2 lines -Changed paths: - M /trunk/plugins/wimaxasncp/packet-wimaxasncp.c + * WIRESHARK_DEBUG_EP_NO_CHUNKS + * WIRESHARK_DEBUG_SE_NO_CHUNKS + * WIRESHARK_DEBUG_EP_NO_CANARY + * WIRESHARK_DEBUG_SE_NO_CANARY -Fix the unsigned errors. Not sure about the other windows errors yet... +This allows us to enable/disable memory chunks and canaries at runtime _without_ needing to recompile. ------------------------------------------------------------------------ -r22807 | etxrab | 2007-09-06 09:27:17 -0700 (Thu, 06 Sep 2007) | 1 line +r29376 | etxrab | 2009-08-11 03:32:46 -0700 (Tue, 11 Aug 2009) | 3 lines Changed paths: - M /trunk/asn1/ansi_map/ansi_map.cnf - M /trunk/asn1/ansi_map/packet-ansi_map-template.c - M /trunk/epan/dissectors/packet-ansi_map.c + M /trunk/epan/dissectors/packet-gtpv2.c -Get rid of get_ber_last_reated_item() and fix dissection of wIN-TriggerList. +From swapnil: +Bugs Fixed in ULI in packet-gtpv2.c +https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=3860 ------------------------------------------------------------------------ -r22808 | etxrab | 2007-09-06 09:28:08 -0700 (Thu, 06 Sep 2007) | 1 line +r29377 | etxrab | 2009-08-11 05:22:00 -0700 (Tue, 11 Aug 2009) | 3 lines Changed paths: - M /trunk/epan/dissectors/packet-per.c + M /trunk/epan/dissectors/packet-gsm_a_common.c -Remove debug code and a "lost" line. +From Gerasimos Dimitriadis: +DTAP decoding of Mobile Station Classmark 3 (R4 and R5). +https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=3866 ------------------------------------------------------------------------ -r22809 | guy | 2007-09-06 09:55:03 -0700 (Thu, 06 Sep 2007) | 2 lines +r29378 | wmeier | 2009-08-11 06:44:35 -0700 (Tue, 11 Aug 2009) | 4 lines Changed paths: - M /trunk/plugins/wimaxasncp/Makefile.nmake + M /trunk/epan/dissectors/packet-p_mul.c -Add .c.obj:: inference rule (to cause "batch compile") +Don't coerce a (void *) to a (guint32 *). +The (void *) pointer in this case may point to +"unaligned" data. ------------------------------------------------------------------------ -r22810 | guy | 2007-09-06 09:57:41 -0700 (Thu, 06 Sep 2007) | 2 lines +r29379 | gerald | 2009-08-11 10:53:39 -0700 (Tue, 11 Aug 2009) | 2 lines Changed paths: - M /trunk/config.h.win32 + M /trunk/epan/tvbuff.h -Fix a comment. +Be a little more explicit in our description of tvb_get_ptr. ------------------------------------------------------------------------ -r22811 | gerald | 2007-09-06 11:26:04 -0700 (Thu, 06 Sep 2007) | 9 lines +r29380 | krj | 2009-08-11 11:08:03 -0700 (Tue, 11 Aug 2009) | 4 lines Changed paths: - M /trunk/docbook/release-notes.xml - M /trunk/epan/dissectors/packet-dnp.c - -Fix problems found by Beyond Security: - -Instead of overflowing an unsigned int when determining the number of -items in a range, use a signed int and check for a negative value. Make -sure our offset increments as we step through each item. This should -avoid large/inifinite loops. - -Fix the size of hf_dnp3_al_range_stop32. + M /trunk/epan/epan.c + M /trunk/epan/epan.h + M /trunk/epan/libwireshark.def + M /trunk/epan/proto.c + M /trunk/epan/proto.h + M /trunk/proto_hier_stats.c ------------------------------------------------------------------------- -r22812 | etxrab | 2007-09-06 14:25:41 -0700 (Thu, 06 Sep 2007) | 3 lines -Changed paths: - M /trunk/epan/dissectors/packet-3g-a11.c - M /trunk/plugins/wimaxasncp/packet-wimaxasncp.c +TRY_TO_FAKE_THIS_ITEM now fakes FT_PROTOCOL per default. If there are any users (e.g. proto_hier_stats.c, others?) that relies on FT_PROTOCOL nodes being created they'll now need to call the newly introduced epan_dissect_fake_protocols() to disable this optimization. -Add A11 RRQ-CVSE-Active Start Airlink Record-Subtype 108 is expressed to Subnet. +Also make use of TRY_TO_FAKE_THIS_ITEM in proto_tree_add_text_node(), proto_tree_add_none_format() and proto_tree_add_protocol_format(). -Plus Temp change VALS(sminmpec_values) to NULL to let the buildbot do arun. ------------------------------------------------------------------------ -r22813 | etxrab | 2007-09-06 14:33:57 -0700 (Thu, 06 Sep 2007) | 2 lines +r29381 | krj | 2009-08-11 11:16:55 -0700 (Tue, 11 Aug 2009) | 1 line Changed paths: - M /trunk/plugins/wimaxasncp/packet-wimaxasncp.c + M /trunk/epan/tvbuff.c -Change it back... -Plus Temp change VALS(sminmpec_values) to NULL to let the buildbot do arun. +Turn a comment in fast_ensure_contiguous() into a DISSECTOR_ASSERT() to make the implied requirement explicit. ------------------------------------------------------------------------ -r22814 | morriss | 2007-09-06 14:57:56 -0700 (Thu, 06 Sep 2007) | 1 line +r29382 | krj | 2009-08-11 11:28:10 -0700 (Tue, 11 Aug 2009) | 1 line Changed paths: - M /trunk/epan/dissectors/packet-sctp.c + M /trunk/epan/tvbuff.c -Count the number of TSNs gap-acked in a SACK. Warn the user (with an Expert info) if the number is greater than, say, 100. Also reindent large portions of the sack dissector function to make it readable. +(Trivial change) move ensure_contiguous() to reflect call hierarchy ------------------------------------------------------------------------ -r22815 | stig | 2007-09-06 15:26:09 -0700 (Thu, 06 Sep 2007) | 2 lines +r29383 | gerald | 2009-08-11 11:37:59 -0700 (Tue, 11 Aug 2009) | 2 lines Changed paths: - M /trunk/asn1/ansi_map/packet-ansi_map-template.c - M /trunk/epan/dissectors/packet-ansi_map.c + M /trunk/epan/dissectors/packet-sccp.c -Fixed a warning: 'j' may be used uninitialized in this function. +Add a bunch of length checks. Fixes bug 3826. ------------------------------------------------------------------------ -r22816 | stig | 2007-09-06 15:29:04 -0700 (Thu, 06 Sep 2007) | 3 lines +r29384 | gerald | 2009-08-11 13:58:36 -0700 (Tue, 11 Aug 2009) | 2 lines Changed paths: - M /trunk/epan/dissectors/packet-dmp.c + M /trunk/epan/dissectors/packet-bacapp.c + M /trunk/epan/dissectors/packet-bacapp.h -Corrected some types, instead of adding a cast (from r21142). -Reindented file. +Add some length checks. Fixes a few recent fuzz bugs. ------------------------------------------------------------------------ -r22817 | stig | 2007-09-06 16:32:46 -0700 (Thu, 06 Sep 2007) | 2 lines +r29385 | gerald | 2009-08-11 14:11:12 -0700 (Tue, 11 Aug 2009) | 2 lines Changed paths: - M /trunk/epan/dissectors/Makefile.common - M /trunk/epan/dissectors/packet-tnef.c + M /trunk/epan/dissectors/packet-ieee80211.c -Moved packet-imf.c and packet-tnef.c from ASN_DISSECTOR_SRC to CLEAN_DISSECTOR_SRC, as they are not generated from ASN1. +Use the right size for FT_UINT16. ------------------------------------------------------------------------ -r22818 | martinm | 2007-09-07 02:56:19 -0700 (Fri, 07 Sep 2007) | 2 lines +r29386 | etxrab | 2009-08-11 14:27:36 -0700 (Tue, 11 Aug 2009) | 3 lines Changed paths: - M /trunk/plugins/wimaxasncp/packet-wimaxasncp.c - -Try Stephen Croll's workaround. + M /trunk/epan/dissectors/packet-gtpv2.c +From swapnil: +Small Bug in TFT (Flow label) and ULI. +https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=3876 ------------------------------------------------------------------------ -r22819 | martinm | 2007-09-07 06:53:49 -0700 (Fri, 07 Sep 2007) | 6 lines +r29387 | rbalint | 2009-08-11 16:20:03 -0700 (Tue, 11 Aug 2009) | 4 lines Changed paths: - M /trunk/plugins/wimaxasncp/packet-wimaxasncp.c + M /trunk/epan/dissectors/packet-icmpv6.c -Small cleanup: -- remove unprintable chars (pasted from formatted spec doc?) -- use _U_ for unsused function argument -- remove accidental(?) assignment in function parameter -- make indentation consistent by removing the (few) tabs in the file +From Ivan Sy (with minor modifications): +Show Teredo Connectivity tests. +Fix offset of ICMPv6 sequence number. ------------------------------------------------------------------------ -r22820 | stig | 2007-09-07 07:02:32 -0700 (Fri, 07 Sep 2007) | 2 lines +r29388 | gerald | 2009-08-11 16:29:21 -0700 (Tue, 11 Aug 2009) | 2 lines Changed paths: - M /trunk/epan/dissectors/Makefile.common - M /trunk/epan/dissectors/packet-ssl-utils.c + M /trunk/epan/dissectors/packet-gtp.c + M /trunk/epan/dissectors/packet-gtpv2.c -Fixed compiler warnings. +Add some length checks. ------------------------------------------------------------------------ -r22821 | stig | 2007-09-07 08:04:31 -0700 (Fri, 07 Sep 2007) | 2 lines +r29389 | gerald | 2009-08-11 16:44:22 -0700 (Tue, 11 Aug 2009) | 3 lines Changed paths: - M /trunk/epan/dissectors/Makefile.common + M /trunk/epan/dissectors/packet-gsm_a_rr.c -Hm. Not so clean on all compilers... +Instead of calling DISSECTOR_ASSERT_NOT_REACHED, just say the subchannel +is unknown. Fixes bug 3864. ------------------------------------------------------------------------ -r22822 | stig | 2007-09-07 08:21:08 -0700 (Fri, 07 Sep 2007) | 2 lines +r29390 | jake | 2009-08-11 16:52:04 -0700 (Tue, 11 Aug 2009) | 2 lines Changed paths: - M /trunk/epan/dissectors/Makefile.common - M /trunk/epan/dissectors/packet-ssl-utils.c + M /trunk/epan/dissectors/packet-gsm_a_rr.c -Argh! Used the wrong length modifier for size_t. +Complete the fix in r29389. ------------------------------------------------------------------------ -r22823 | martinm | 2007-09-07 08:24:43 -0700 (Fri, 07 Sep 2007) | 2 lines +r29391 | jake | 2009-08-11 17:02:23 -0700 (Tue, 11 Aug 2009) | 1 line Changed paths: - M /trunk/packaging/nsis/wireshark.nsi - -Crap - missed this one! + M /trunk/gtk/graph_analysis.c +Restore the formatting of the saved graph. ------------------------------------------------------------------------ -r22824 | martinm | 2007-09-07 08:58:24 -0700 (Fri, 07 Sep 2007) | 2 lines +r29392 | kukosa | 2009-08-11 23:10:08 -0700 (Tue, 11 Aug 2009) | 1 line Changed paths: - M /trunk/plugins/wimaxasncp/packet-wimaxasncp.c - -Replace remaining non-printable characters that looked like spaces with real spaces. + M /trunk/epan/dissectors/packet-ssl-utils.c +fix memoryleak causing crash with long SSL traces ------------------------------------------------------------------------ -r22825 | stig | 2007-09-07 12:05:55 -0700 (Fri, 07 Sep 2007) | 26 lines +r29393 | rbalint | 2009-08-12 05:55:27 -0700 (Wed, 12 Aug 2009) | 2 lines Changed paths: - M /trunk/epan/dissectors/packet-bfd.c + M /trunk/epan/dissectors/packet-icmpv6.c -From Todd J Martin: -The attached patch to packet-bfd.c adds the following enhancements to BFD -decoding: -- The Authentication Section is now decoded. All of the authentication methods -are supported. Verification of checksums is not implemented. -- BFD flags are now shown in a tree -- Added support for the M flag -- Added a display filter for the message length -- For the Desired Min TX Interval, Required Min RX Interval, and Required Min -Echo RX Interval fields, the time value is now printed in both milliseconds and -microseconds. (Previously, only milliseconds was being shown.) The PDU -represents the time in microseconds, but most implementations deal in -milliseconds. -- Added a warning to flag the packet if the Authentication bit is set, but the -full Authentication Section is not present. -- Added descriptions for most of the fields -- Fix the name of the protocol. BFD stands for Bidirectional Forwarding -Detection and not Bi-directional Fault Detection. -- Register the protocol on the UDP multihop port (4784). -- Change the filter name for the protocol from bfdcontrol to bfd since all of -the other display filters started with bfd. - - -Removed unused hf_bfd_auth_checksum. -Modified printing of the ':' at the end of the Authentication tree. - ------------------------------------------------------------------------- -r22826 | morriss | 2007-09-07 14:46:31 -0700 (Fri, 07 Sep 2007) | 1 line -Changed paths: - M /trunk/epan/dissectors/packet-sctp.c +Fix COL_INFO and COL_PROTOCOL for Teredo Direct IPv6 Connectivity Test -If the whole packet was not captured (e.g., due to the snapshot length), do not attempt to verify the checksum of the packet. Rather, inform the user that we didn't/couldn't verify the checksum. ------------------------------------------------------------------------ -r22827 | guy | 2007-09-07 15:11:01 -0700 (Fri, 07 Sep 2007) | 8 lines +r29394 | krj | 2009-08-12 08:12:19 -0700 (Wed, 12 Aug 2009) | 4 lines Changed paths: - M /trunk/epan/dissectors/Makefile.common - D /trunk/epan/dissectors/packet-dcerpc-afs4int.c - M /trunk/epan/dissectors/packet-dcerpc-bossvr.c - A /trunk/epan/dissectors/packet-dcerpc-fileexp.c (from /trunk/epan/dissectors/packet-dcerpc-afs4int.c:22811) - M /trunk/epan/dissectors/packet-dcerpc-fldb.c - M /trunk/epan/dissectors/packet-dcerpc-icl_rpc.c - M /trunk/epan/dissectors/packet-dcerpc-rep_proc.c - M /trunk/epan/dissectors/packet-dcerpc-tkn4int.c - M /trunk/epan/dissectors/packet-dcerpc-ubikdisk.c - M /trunk/epan/dissectors/packet-dcerpc-ubikvote.c + M /trunk/epan/dissectors/packet-gtpv2.c -Change the long protocol name dissectors for various DFS protocols to -indicate that they're for DFS; update comments as well. +From William Preston via. 3549: -Rename packet-dcerpc-afs4int.c to packet-dcerpc-fileexp.c, and change -the short and filter names for the protocol, and the names for the -filterable fields, to reflect the fact that it's for the File Exporter -protocol in DFS. ("AFS 4" = DCE DFS.) +A typo in 2 of the field names causes the apn not to be displayed. ------------------------------------------------------------------------ -r22828 | jmayer | 2007-09-08 06:22:27 -0700 (Sat, 08 Sep 2007) | 3 lines +r29395 | gerald | 2009-08-12 10:08:08 -0700 (Wed, 12 Aug 2009) | 4 lines Changed paths: - M /trunk/epan/dissectors/packet-isakmp.c + M /trunk/tools/fuzz-test.sh -- Slightly improved dissection of Cisco's fragmented ISAKMP. -- Corrected misdetection of CISCO-UNITY VID. +Temporarily disable dissector bug checking. Fixing the ones we've found +so far will take a while and in the meantime looking for dissector +assertions is keeping us from finding more serious bugs. ------------------------------------------------------------------------ -r22829 | ulfl | 2007-09-09 06:05:32 -0700 (Sun, 09 Sep 2007) | 1 line +r29396 | krj | 2009-08-12 11:24:49 -0700 (Wed, 12 Aug 2009) | 1 line Changed paths: - M /trunk/epan/unicode-utils.c + M /trunk/epan/proto.c -remove unused #else +DISSECTOR_ASSERT on FT_PCRE in construct_match_selected_string(). ------------------------------------------------------------------------ -r22830 | ulfl | 2007-09-09 06:09:14 -0700 (Sun, 09 Sep 2007) | 1 line +r29397 | krj | 2009-08-12 12:32:54 -0700 (Wed, 12 Aug 2009) | 1 line Changed paths: - M /trunk/Makefile.nmake + M /trunk/epan/reassemble.c -don't try to put a ## comment after the touch call, this will end up in a few strange new files generated +White space changes ------------------------------------------------------------------------ -r22831 | ulfl | 2007-09-09 06:59:58 -0700 (Sun, 09 Sep 2007) | 1 line +r29398 | etxrab | 2009-08-12 15:40:13 -0700 (Wed, 12 Aug 2009) | 3 lines Changed paths: - A /trunk/all.vcproj - A /trunk/doc/doc.vcproj - A /trunk/docbook/docbook.vcproj - A /trunk/dumpcap.vcproj - A /trunk/epan/libwireshark.vcproj - A /trunk/gtk/libui.vcproj - A /trunk/packaging.vcproj - A /trunk/plugins/plugins.vcproj - A /trunk/tshark.vcproj - A /trunk/wireshark-gtk1.vcproj - A /trunk/wireshark-gtk2.vcproj - A /trunk/wireshark.sln - A /trunk/wiretap/libwiretap.vcproj + M /trunk/epan/dissectors/packet-gsm_a_common.c -start an experiment to provide MS Visual Studio 2005 solution / project files for a lot easier debugging. They still use the underlying Makefile.nmake files for the actual build process. +From Gerasimos Dimitriadis: +DTAP decoding of Mobile Station Classmark 3 (R6). +https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=3886 ------------------------------------------------------------------------ -r22832 | ulfl | 2007-09-09 07:58:02 -0700 (Sun, 09 Sep 2007) | 1 line +r29399 | etxrab | 2009-08-13 00:56:13 -0700 (Thu, 13 Aug 2009) | 3 lines Changed paths: - M /trunk/all.vcproj - M /trunk/dumpcap.vcproj - M /trunk/epan/libwireshark.vcproj - M /trunk/gtk/libui.vcproj - M /trunk/packaging.vcproj - M /trunk/tshark.vcproj - M /trunk/wireshark-gtk1.vcproj - M /trunk/wireshark-gtk2.vcproj - M /trunk/wiretap/libwiretap.vcproj + M /trunk/epan/dissectors/packet-gsm_a_common.c -translate some german to english +From Gerasimos Dimitriadis: +DTAP decoding of Mobile Station Classmark 3 (R7 and R8) +https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=3891 ------------------------------------------------------------------------ -r22833 | ulfl | 2007-09-09 07:58:56 -0700 (Sun, 09 Sep 2007) | 1 line +r29400 | kukosa | 2009-08-13 02:07:03 -0700 (Thu, 13 Aug 2009) | 1 line Changed paths: - A /trunk/epan/dissectors/dissectors.vcproj - M /trunk/wireshark.sln + M /trunk/epan/dissectors/packet-dtls.c + M /trunk/epan/dissectors/packet-ssl-utils.c + M /trunk/epan/dissectors/packet-ssl-utils.h + M /trunk/epan/dissectors/packet-ssl.c -add a dissectors project, so MSVC "jump to error" works +Fix SSL decryption failure if client and server have the same TCP port ------------------------------------------------------------------------ -r22834 | jake | 2007-09-10 00:21:27 -0700 (Mon, 10 Sep 2007) | 2 lines +r29401 | kukosa | 2009-08-13 03:36:53 -0700 (Thu, 13 Aug 2009) | 1 line Changed paths: - M /trunk/gtk/voip_calls.c - M /trunk/gtk/voip_calls.h - M /trunk/gtk/voip_calls_dlg.c - M /trunk/plugins/unistim/packet-unistim.c - M /trunk/plugins/unistim/packet-unistim.h + M /trunk/epan/dissectors/packet-ssl-utils.c -From Chad Singer: -UNISTIM Tap interface plus call grapher. +use G_GSIZE_MODIFIER instead of %zd which is not supported by MSVC ------------------------------------------------------------------------ -r22835 | wmeier | 2007-09-10 07:00:12 -0700 (Mon, 10 Sep 2007) | 2 lines +r29402 | kukosa | 2009-08-13 04:12:35 -0700 (Thu, 13 Aug 2009) | 1 line Changed paths: - M /trunk/Makefile.nmake - -Fix my earlier typo. + M /trunk/epan/dissectors/packet-ssl-utils.c +fix build failure without GnuTLS ------------------------------------------------------------------------ -r22836 | wmeier | 2007-09-10 10:10:42 -0700 (Mon, 10 Sep 2007) | 7 lines +r29403 | krj | 2009-08-13 05:17:20 -0700 (Thu, 13 Aug 2009) | 4 lines Changed paths: - M /trunk/docbook/wsdg_src/WSDG_chapter_build_intro.xml - M /trunk/docbook/wsdg_src/WSDG_chapter_dissection.xml - M /trunk/docbook/wsdg_src/WSDG_chapter_env_intro.xml - M /trunk/docbook/wsdg_src/WSDG_chapter_libraries.xml - M /trunk/docbook/wsdg_src/WSDG_chapter_quick_setup.xml - M /trunk/docbook/wsdg_src/WSDG_chapter_sources.xml - M /trunk/docbook/wsdg_src/WSDG_chapter_tools.xml - M /trunk/docbook/wsdg_src/WSDG_chapter_userinterface.xml - M /trunk/docbook/wsdg_src/WSDG_chapter_works.xml - M /trunk/docbook/wsdg_src/WSDG_preface.xml - -General cleanup; Update 'Win32 Automated library download' section slightly; -Cleanup: - - relatively minor wording changes - - spelling - - typos - - minor formatting changes + M /trunk/epan/dissectors/packet-gsm_a_rr.c ------------------------------------------------------------------------- -r22837 | wmeier | 2007-09-10 14:02:58 -0700 (Mon, 10 Sep 2007) | 2 lines -Changed paths: - M /trunk/docbook/wsug_src/WSUG_app_files.xml - M /trunk/docbook/wsug_src/WSUG_app_howitworks.xml - M /trunk/docbook/wsug_src/WSUG_app_messages.xml - M /trunk/docbook/wsug_src/WSUG_app_tools.xml - M /trunk/docbook/wsug_src/WSUG_chapter_advanced.xml - M /trunk/docbook/wsug_src/WSUG_chapter_build_install.xml - M /trunk/docbook/wsug_src/WSUG_chapter_capture.xml - M /trunk/docbook/wsug_src/WSUG_chapter_introduction.xml - M /trunk/docbook/wsug_src/WSUG_chapter_io.xml - M /trunk/docbook/wsug_src/WSUG_chapter_use.xml - M /trunk/docbook/wsug_src/WSUG_preface.xml +Make sure that we find the "data" dissector during handoff else we might crash if the received payload was less than 2 bytes. -Some cleanup: correct some grammar and do a few minor rewordings +Fixes https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=3893 ------------------------------------------------------------------------ -r22838 | wmeier | 2007-09-10 14:18:11 -0700 (Mon, 10 Sep 2007) | 2 lines +r29404 | krj | 2009-08-13 12:42:46 -0700 (Thu, 13 Aug 2009) | 1 line Changed paths: - M /trunk/docbook/wsug_src/WSUG_app_tools.xml - -Undo one unintended change. + M /trunk/epan/epan.c + M /trunk/epan/epan.h + M /trunk/epan/libwireshark.def + M /trunk/file.c + M /trunk/gtk/iax2_analysis.c + M /trunk/gtk/main.c + M /trunk/gtk/new_packet_list.c + M /trunk/gtk/rtp_analysis.c + M /trunk/gtk/sctp_assoc_analyse.c + M /trunk/gtk/tcp_graph.c + M /trunk/proto_hier_stats.c + M /trunk/rawshark.c + M /trunk/tshark.c +Introduce epan_dissect_init()/epan_dissect_cleanup(). These are used to initialise/cleanup stack allocated 'edt' structures. This should speed up dissection since we avoid some malloc traffic. ------------------------------------------------------------------------ -r22839 | wmeier | 2007-09-10 14:50:01 -0700 (Mon, 10 Sep 2007) | 2 lines +r29405 | krj | 2009-08-13 13:00:36 -0700 (Thu, 13 Aug 2009) | 1 line Changed paths: - M /trunk/docbook/wsdg_src/WSDG_chapter_tools.xml - -Correct (essentially revert) the reference to the Microsoft Debugging Tools; + M /trunk/gtk/new_packet_list.c +Add needed header due to stack allocated 'edt' structure ------------------------------------------------------------------------ -r22840 | wmeier | 2007-09-10 15:28:42 -0700 (Mon, 10 Sep 2007) | 4 lines +r29406 | etxrab | 2009-08-13 14:36:01 -0700 (Thu, 13 Aug 2009) | 1 line Changed paths: - M /trunk/gtk/color_edit_dlg.c - -Fix bug in View ! Color Filter ! New ! (Fore|Back)ground Color & etc code -which resulted in a GtkCritcal msg and in disabling the "(Fore|Back)ground Color" -button when esc used to close the widget. + M /trunk/gtk/new_packet_list.c + M /trunk/gtk/packet_list_store.c +Get the pointer to the packet list record and use the data directly. ------------------------------------------------------------------------ -r22841 | sfisher | 2007-09-10 16:50:46 -0700 (Mon, 10 Sep 2007) | 4 lines +r29407 | etxrab | 2009-08-13 14:46:00 -0700 (Thu, 13 Aug 2009) | 1 line Changed paths: - M /trunk/gtk/follow_dlg.c - M /trunk/gtk/follow_stream.c - M /trunk/gtk/follow_stream.h - M /trunk/gtk/ssl-dlg.c - - -Some more code merging / cleanup in the Follow TCP & SSL Stream features - + M /trunk/gtk/new_packet_list.c +Start to implement display filtering. ------------------------------------------------------------------------ -r22842 | wmeier | 2007-09-11 07:36:09 -0700 (Tue, 11 Sep 2007) | 2 lines +r29408 | krj | 2009-08-13 22:22:12 -0700 (Thu, 13 Aug 2009) | 1 line Changed paths: - M /trunk/docbook/wsug_src/WSUG_chapter_io.xml - M /trunk/docbook/wsug_src/WSUG_chapter_work.xml - -Some cleanup for Chapters 5 & 6: typos, spelling and minor rewording/additions. + M /trunk/file.c +Always add packet to the new packet list regardless of whether the packet passed the display filter test or not. We do this because we do the filtering inside the new packet list. ------------------------------------------------------------------------ -r22843 | jake | 2007-09-11 09:54:27 -0700 (Tue, 11 Sep 2007) | 1 line +r29409 | krj | 2009-08-13 22:49:57 -0700 (Thu, 13 Aug 2009) | 1 line Changed paths: - M /trunk/gtk/about_dlg.c + M /trunk/file.c -Make the splash screen look just a little bit better. +Make display filtering work for NEW_PACKET_LIST. This didn't work previously because we would simply append the new filtered packets onto the existing ones. ------------------------------------------------------------------------ -r22844 | etxrab | 2007-09-11 09:57:42 -0700 (Tue, 11 Sep 2007) | 1 line +r29410 | krj | 2009-08-14 03:17:13 -0700 (Fri, 14 Aug 2009) | 4 lines Changed paths: - M /trunk/radius/dictionary.3gpp - M /trunk/radius/dictionary.3gpp2 + M /trunk/plugins/ethercat/Makefile.nmake -Add AVP:s ------------------------------------------------------------------------- -r22845 | etxrab | 2007-09-11 09:58:25 -0700 (Tue, 11 Sep 2007) | 1 line -Changed paths: - M /trunk/epan/dissectors/packet-l2tp.c - M /trunk/epan/dissectors/packet-lapd.c +From Artem Tamazov via. 3899: -Update valuestrings and comments. ------------------------------------------------------------------------- -r22846 | etxrab | 2007-09-11 09:59:57 -0700 (Tue, 11 Sep 2007) | 3 lines -Changed paths: - M /trunk/epan/dissectors/packet-sndcp.c +Remove superfluous /MP -From cyrille colin: -PATCH : SNDCP reassembly fails / overlaps when same NPDU number in another call -http://bugs.wireshark.org/bugzilla/show_bug.cgi?id=1755 ------------------------------------------------------------------------ -r22847 | wmeier | 2007-09-11 11:55:11 -0700 (Tue, 11 Sep 2007) | 2 lines +r29411 | krj | 2009-08-14 06:33:17 -0700 (Fri, 14 Aug 2009) | 1 line Changed paths: - M /trunk/docbook/wsug_src/WSUG_chapter_advanced.xml - -Some cleanup for Chapter 7: typos, spelling and minor reformatting/rewording.. + M /trunk/gtk/new_packet_list.c +Don't attach our original packet list model in new_packet_list_thaw(). It's pointless because we override it in filter_function(). ------------------------------------------------------------------------ -r22848 | wmeier | 2007-09-11 13:56:14 -0700 (Tue, 11 Sep 2007) | 2 lines +r29412 | etxrab | 2009-08-14 08:31:59 -0700 (Fri, 14 Aug 2009) | 3 lines Changed paths: - M /trunk/docbook/wsug_src/WSUG_chapter_advanced.xml - -Fix some links to external web pages: Turn some intended entity refs into real entity refs + M /trunk/diameter/TGPPRx.xml + M /trunk/diameter/dictionary.xml +Typos. +Fixes: +https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=3878 ------------------------------------------------------------------------ -r22849 | jake | 2007-09-11 14:31:21 -0700 (Tue, 11 Sep 2007) | 7 lines +r29413 | krj | 2009-08-14 08:44:57 -0700 (Fri, 14 Aug 2009) | 1 line Changed paths: - M /trunk/wiretap/libpcap.c - -From Pieter de Boer: -tshark can read a HP-UX nettl IP packet dump (written with 'nettl -traceon all --entity ns_ls_ip -file dump'), but cannot convert it to a pcap raw IP packet -dump, with 'tshark -r dump.nettl -w dump.pcap'. A single-line patch to -wiretap/libpcap.c makes it possible to do this. + M /trunk/gtk/new_packet_list.c -The input file uses encapsulation type WTAP_ENCAP_NETTL_RAW_IP. +Make next/previous frame work again with the new filter model. ------------------------------------------------------------------------ -r22850 | jake | 2007-09-11 22:57:53 -0700 (Tue, 11 Sep 2007) | 5 lines +r29414 | krj | 2009-08-14 08:56:23 -0700 (Fri, 14 Aug 2009) | 1 line Changed paths: - M /trunk/epan/dissectors/packet-acn.c - M /trunk/epan/dissectors/packet-acn.h + M /trunk/gtk/new_packet_list.c -From Bill Florac: -1) DMP "range" addresses can cause packet dissection failure. -2) A NULL return of match_strval() is not handled. -3) DMP addresses should be displayed in hex. -4) ep_alloc should not be used, use static variables. +Make first/last frame work again with the new filter model. ------------------------------------------------------------------------ -r22851 | jmayer | 2007-09-11 23:31:09 -0700 (Tue, 11 Sep 2007) | 3 lines +r29415 | krj | 2009-08-14 11:29:32 -0700 (Fri, 14 Aug 2009) | 1 line Changed paths: - M /trunk/epan/dissectors/packet-isakmp.c - -If we find a fragmented ike packet, dissect the stuff -that fits into the first fragment. + M /trunk/gtk/main.c + M /trunk/gtk/new_packet_list.c +New packet list: right clicking on a row now selects the given row. ------------------------------------------------------------------------ -r22852 | wmeier | 2007-09-12 07:50:27 -0700 (Wed, 12 Sep 2007) | 2 lines +r29416 | krj | 2009-08-14 11:32:44 -0700 (Fri, 14 Aug 2009) | 1 line Changed paths: - M /trunk/text2pcap.c - -Output err msg if strptime fails converting input time; + M /trunk/gtk/new_packet_list.c +Remove unused functions/prototypes ------------------------------------------------------------------------ -r22853 | wmeier | 2007-09-12 08:32:09 -0700 (Wed, 12 Sep 2007) | 5 lines +r29417 | krj | 2009-08-14 11:49:48 -0700 (Fri, 14 Aug 2009) | 1 line Changed paths: - M /trunk/docbook/wsluarm.xml - -From Patrick Lundquist: -the Lua dissector example in wsluarm.xml uses C defines instead of Lua -defines where display bases for ProtoFields are used. - + M /trunk/gtk/new_packet_list.c +Make mark/unmark frame work with the new filter model ------------------------------------------------------------------------ -r22854 | etxrab | 2007-09-12 09:45:53 -0700 (Wed, 12 Sep 2007) | 1 line +r29418 | krj | 2009-08-14 11:59:15 -0700 (Fri, 14 Aug 2009) | 1 line Changed paths: - M /trunk/asn1/ansi_map/Makefile - M /trunk/asn1/ansi_map/Makefile.nmake - M /trunk/asn1/ansi_map/ansi_map.asn - M /trunk/asn1/ansi_map/ansi_map.cnf - M /trunk/asn1/ansi_map/packet-ansi_map-template.c - M /trunk/asn1/tcap/ansi_tcap.cnf - M /trunk/asn1/tcap/packet-ansi_tcap-template.c - M /trunk/asn1/tcap/packet-tcap-template.c - M /trunk/epan/dissectors/packet-ansi_map.c - M /trunk/epan/dissectors/packet-ansi_map.h - M /trunk/epan/dissectors/packet-ansi_tcap.c - M /trunk/epan/dissectors/packet-ansi_tcap.h - M /trunk/epan/dissectors/packet-tcap.c + M /trunk/gtk/new_packet_list.c -Use the new ANSI TCAP dissector. +Remove the hacky row_from_iter() function and use new_packet_list_get_record() instead. Alas, new_packet_list_get_record() is also somewhat hacky in its nature, but hey at least we're using one less hacky thing. ------------------------------------------------------------------------ -r22855 | etxrab | 2007-09-12 11:12:18 -0700 (Wed, 12 Sep 2007) | 1 line +r29419 | krj | 2009-08-14 12:35:01 -0700 (Fri, 14 Aug 2009) | 1 line Changed paths: - M /trunk/asn1/ansi_map/ansi_map.asn - M /trunk/asn1/ansi_map/packet-ansi_map-template.c - M /trunk/asn1/tcap/ansi_tcap.cnf - M /trunk/asn1/tcap/packet-ansi_tcap-template.c - M /trunk/epan/dissectors/packet-ansi_map.c - M /trunk/epan/dissectors/packet-ansi_tcap.c + M /trunk/gtk/main.c + M /trunk/gtk/main.h + M /trunk/gtk/menus.c + M /trunk/gtk/new_packet_list.c + M /trunk/gtk/new_packet_list.h -Warning fixes. +Make 'Apply as filter'/'Prepare filter' work for new packet list. ------------------------------------------------------------------------ -r22856 | wmeier | 2007-09-12 14:34:48 -0700 (Wed, 12 Sep 2007) | 2 lines +r29420 | martinm | 2009-08-14 18:29:29 -0700 (Fri, 14 Aug 2009) | 2 lines Changed paths: - M /trunk/docbook/README.txt - -Add info for Fedora 7 + M /trunk/epan/dissectors/packet-catapult-dct2000.c ------------------------------------------------------------------------- -r22857 | jake | 2007-09-12 14:46:55 -0700 (Wed, 12 Sep 2007) | 1 line -Changed paths: - M /trunk/plugins/unistim/TODO - M /trunk/plugins/unistim/packet-unistim.c +Allow s1ap not to be dissected (to avoid seeing errors, possibly due to proprietary variants). -Implement dissect_message loop i.s.o. recursive calls. ------------------------------------------------------------------------ -r22858 | etxrab | 2007-09-12 22:22:51 -0700 (Wed, 12 Sep 2007) | 2 lines +r29421 | krj | 2009-08-14 20:57:14 -0700 (Fri, 14 Aug 2009) | 1 line Changed paths: - M /trunk/asn1/cms/Makefile - M /trunk/asn1/cms/Makefile.nmake - M /trunk/asn1/cms/cms-exp.cnf - M /trunk/epan/dissectors/packet-cms.c - M /trunk/epan/dissectors/packet-cms.h + M /trunk/gtk/menus.c -Regenerate with -X and -T option. -Should "sha-1 OBJECT IDENTIFIER..." etc be registerd as oid names? +Don't exclude functionality we already support ------------------------------------------------------------------------ -r22859 | wmeier | 2007-09-13 07:47:29 -0700 (Thu, 13 Sep 2007) | 2 lines +r29422 | krj | 2009-08-14 21:05:04 -0700 (Fri, 14 Aug 2009) | 1 line Changed paths: - M /trunk/docbook/wsug_src/WSUG_app_files.xml - M /trunk/docbook/wsug_src/WSUG_app_messages.xml - M /trunk/docbook/wsug_src/WSUG_app_tools.xml - M /trunk/docbook/wsug_src/WSUG_chapter_advanced.xml - M /trunk/docbook/wsug_src/WSUG_chapter_build_install.xml - M /trunk/docbook/wsug_src/WSUG_chapter_customize.xml - M /trunk/docbook/wsug_src/WSUG_chapter_introduction.xml - M /trunk/docbook/wsug_src/WSUG_chapter_statistics.xml - M /trunk/docbook/wsug_src/WSUG_chapter_work.xml - -Cleanup: mostly Chapter 8 and beyond: the usual minor rewording and reformatting, typos, spelling, grammar & etc. + M /trunk/gtk/menus.c +Find next/previous mark is also supported so don't exclude it ------------------------------------------------------------------------ -r22860 | wmeier | 2007-09-13 08:04:41 -0700 (Thu, 13 Sep 2007) | 2 lines +r29423 | krj | 2009-08-14 21:19:45 -0700 (Fri, 14 Aug 2009) | 1 line Changed paths: - M /trunk/docbook/wsdg_src/WSDG_chapter_env_intro.xml - -Fix Typo + M /trunk/gtk/menus.c + M /trunk/gtk/new_packet_list.c + M /trunk/gtk/new_packet_list.h +Add support for mark/unmark all frames in our new packet list ------------------------------------------------------------------------ -r22861 | lego | 2007-09-13 09:49:51 -0700 (Thu, 13 Sep 2007) | 5 lines +r29424 | krj | 2009-08-14 21:24:43 -0700 (Fri, 14 Aug 2009) | 1 line Changed paths: - M /trunk/asn1/snmp/packet-snmp-template.c - M /trunk/epan/dissectors/packet-cops.c - M /trunk/epan/dissectors/packet-snmp.c - M /trunk/epan/oids.c - M /trunk/epan/oids.h - -Given the opportunity I check in the changes to snmp I got in this machine. - -- Indexing (implied and not) is OK now, however indexes for related tables (AUGMENT, EXTEND, etc) are registered many times. - + M /trunk/gtk/menus.c +Enable 'Mark Packet' in the Edit menu ------------------------------------------------------------------------ -r22862 | jake | 2007-09-13 11:47:10 -0700 (Thu, 13 Sep 2007) | 1 line +r29425 | krj | 2009-08-14 22:06:27 -0700 (Fri, 14 Aug 2009) | 1 line Changed paths: - M /trunk/plugins/unistim/TODO - M /trunk/plugins/unistim/packet-unistim.c + M /trunk/gtk/new_packet_list.c -Add RT(C)P conversation setup. +Avoid superfluous g_strdup() ------------------------------------------------------------------------ -r22863 | jake | 2007-09-13 11:47:54 -0700 (Thu, 13 Sep 2007) | 1 line +r29426 | krj | 2009-08-14 22:26:02 -0700 (Fri, 14 Aug 2009) | 1 line Changed paths: - M /trunk/epan/dissectors/packet-rtp.c + M /trunk/gtk/packet_list_store.c -Allow for full size setup method name. +Micro optimize by storing PACKET_LIST(tree_model) into a local variable and using that instead of computing PACKET_LIST(tree_model) each time. ------------------------------------------------------------------------ -r22864 | jake | 2007-09-13 11:51:32 -0700 (Thu, 13 Sep 2007) | 2 lines +r29427 | krj | 2009-08-14 23:38:10 -0700 (Fri, 14 Aug 2009) | 8 lines Changed paths: - M /trunk/epan/dissectors/packet-bootp.c + M /trunk/epan/dissectors/packet-bthci_acl.c + M /trunk/epan/dissectors/packet-btl2cap.c + M /trunk/epan/dissectors/packet-btrfcomm.c + M /trunk/epan/packet.c + M /trunk/epan/packet.h + M /trunk/epan/reassemble.c + M /trunk/epan/reassemble_test.c + M /trunk/epan/wslua/wslua_dumper.c + M /trunk/print.c -From Thomas Sillaber: -Attached is a patch for packet-bootp.c to support Alcatel-Lucent TFTP1 and TFTP2 vendor specific options. ------------------------------------------------------------------------- -r22865 | jmayer | 2007-09-13 13:06:41 -0700 (Thu, 13 Sep 2007) | 4 lines -Changed paths: - M /trunk/epan/dissectors/packet-isakmp.c +This patch introduces packet_add_new_data_source() which effectively deprecates add_new_data_source(). This is based on the following observation: -- Resassemble Cisco ike fragementation -- Rename some variables from ike to isakmp to make - things consistent (not right, just consistent) +1) The tvb + name (aka. data_source) is only used when the protocol tree is visible ------------------------------------------------------------------------- -r22866 | etxrab | 2007-09-13 13:20:11 -0700 (Thu, 13 Sep 2007) | 1 line -Changed paths: - M /trunk/asn1/ansi_map/packet-ansi_map-template.c - M /trunk/asn1/tcap/ansi_tcap.cnf - M /trunk/asn1/tcap/packet-ansi_tcap-template.c - M /trunk/epan/dissectors/packet-ansi_map.c - M /trunk/epan/dissectors/packet-ansi_tcap.c +The current implementation of add_new_data_source() doesn't take this into account and simply allocates a data_source regardless. This is what packet_add_new_data_source() tries to rectify. -Try to protect the hash table... ------------------------------------------------------------------------- -r22867 | etxrab | 2007-09-13 13:24:50 -0700 (Thu, 13 Sep 2007) | 1 line -Changed paths: - M /trunk/asn1/tcap/packet-ansi_tcap-template.c - M /trunk/epan/dissectors/packet-ansi_tcap.c +A couple of dissectors have already been switched over to the new packet_add_new_data_source(). Many are still missing. Help appreciated! -Remove debug code. ------------------------------------------------------------------------ -r22868 | lego | 2007-09-13 13:27:05 -0700 (Thu, 13 Sep 2007) | 3 lines +r29428 | krj | 2009-08-15 01:05:10 -0700 (Sat, 15 Aug 2009) | 1 line Changed paths: - M /trunk/asn1/snmp/packet-snmp-template.c - M /trunk/epan/dissectors/packet-snmp.c - -eliminate an anonymous enum. - + M /trunk/epan/dissectors/packet-frame.c +The frame dissector contains a kludge to workaround the fact that the Protocol Hierarchy stats tap always needs the protocol node to appear even though no color, display filter etc. reference it. This is no longer needed due to r29380. ------------------------------------------------------------------------ -r22869 | sfisher | 2007-09-13 15:11:50 -0700 (Thu, 13 Sep 2007) | 5 lines +r29429 | krj | 2009-08-15 01:38:50 -0700 (Sat, 15 Aug 2009) | 1 line Changed paths: - M /trunk/gtk/follow_dlg.c - M /trunk/gtk/follow_stream.c - M /trunk/gtk/follow_stream.h - M /trunk/gtk/ssl-dlg.c - - -Finish the major part of merging duplicate code between follow TCP & SSL -stream functions. - + M /trunk/epan/proto.c +This should have been part of r29428. This patch forces proto_field_is_referenced() to respect the fake_protocols flag set by Protocol Hierarchy stats tap. ------------------------------------------------------------------------ -r22870 | sfisher | 2007-09-13 15:25:20 -0700 (Thu, 13 Sep 2007) | 4 lines +r29430 | krj | 2009-08-15 02:13:16 -0700 (Sat, 15 Aug 2009) | 1 line Changed paths: - M /trunk/gtk/Makefile.am - M /trunk/gtk/Makefile.common - D /trunk/gtk/follow_dlg.c - D /trunk/gtk/follow_dlg.h - A /trunk/gtk/follow_ssl.c (from /trunk/gtk/ssl-dlg.c:22869) - A /trunk/gtk/follow_ssl.h (from /trunk/gtk/ssl-dlg.h:22840) - A /trunk/gtk/follow_tcp.c (from /trunk/gtk/follow_dlg.c:22869) - A /trunk/gtk/follow_tcp.h (from /trunk/gtk/follow_dlg.h:22840) - M /trunk/gtk/font_utils.c - M /trunk/gtk/main.c - M /trunk/gtk/menu.c - D /trunk/gtk/ssl-dlg.c - D /trunk/gtk/ssl-dlg.h - M /trunk/gtk/stream_prefs.c - - -Standardize filenames and function names for Follow TCP & SSL stream functions - + M /trunk/epan/except.c +Switch over to using GLib's g_malloc/g_free in the name of consistency. ------------------------------------------------------------------------ -r22871 | jake | 2007-09-13 23:51:07 -0700 (Thu, 13 Sep 2007) | 1 line +r29431 | krj | 2009-08-15 04:21:36 -0700 (Sat, 15 Aug 2009) | 1 line Changed paths: - M /trunk/asn1/snmp/packet-snmp-template.c - M /trunk/epan/dissectors/packet-snmp.c + M /trunk/plugins/ethercat/packet-ecatmb.c + M /trunk/plugins/ethercat/packet-esl.c -Try to get the Windows buildbot going by avoiding namespace collision. +Use HFILL instead of hard coding the values ------------------------------------------------------------------------ -r22872 | jmayer | 2007-09-14 02:59:19 -0700 (Fri, 14 Sep 2007) | 2 lines +r29432 | krj | 2009-08-15 05:29:25 -0700 (Sat, 15 Aug 2009) | 1 line Changed paths: - M /trunk/epan/dissectors/packet-isakmp.c - -Small cleanup + M /trunk/epan/tvbuff.c +Make mem chunk static ------------------------------------------------------------------------ -r22873 | jmayer | 2007-09-14 04:50:58 -0700 (Fri, 14 Sep 2007) | 3 lines +r29433 | krj | 2009-08-15 05:41:24 -0700 (Sat, 15 Aug 2009) | 1 line Changed paths: - M /trunk/epan/dissectors/packet-isakmp.c - -Move the fragmentation info and the defragmented isakmp message -to the top level tree. + M /trunk/epan/tvbuff.c +Add a missing DISSECTOR_ASSERT in tvb_init() ------------------------------------------------------------------------ -r22874 | gerald | 2007-09-14 08:36:13 -0700 (Fri, 14 Sep 2007) | 2 lines +r29434 | krj | 2009-08-15 06:24:59 -0700 (Sat, 15 Aug 2009) | 1 line Changed paths: - M /trunk/epan/dissectors/packet-dmp.c - -Add a cast to allow compilation on Vista. + M /trunk/epan/tvbuff.c +Use the slice allocator if GLIB >= 2,10,0 as suggested by Anders Broman ------------------------------------------------------------------------ -r22875 | tuexen | 2007-09-14 14:30:26 -0700 (Fri, 14 Sep 2007) | 3 lines +r29435 | krj | 2009-08-15 07:13:36 -0700 (Sat, 15 Aug 2009) | 1 line Changed paths: - M /trunk/epan/dissectors/packet-sctp.c - -Change the ADDIP error causes as changed by IANA for RFC 5061 publication. - + M /trunk/file.c +Inline a few checks in the add_packet_to_packet_list() function since it's called in tight loop. This will help us to avoid calling functions that simply returns. This is especially the case when we're dealing with the new packet list due to its dissect-on-demand nature where colour/column construction is delayed until the row becomes visible. ------------------------------------------------------------------------ -r22876 | jake | 2007-09-14 15:25:07 -0700 (Fri, 14 Sep 2007) | 1 line +r29436 | etxrab | 2009-08-15 14:12:56 -0700 (Sat, 15 Aug 2009) | 1 line Changed paths: - M /trunk/docbook/wsug_src/WSUG_app_messages.xml + M /trunk/gtk/new_packet_list.c -Add "Session setup by" information field description +Prepare for storing column data in packet list store. ------------------------------------------------------------------------ -r22877 | gerald | 2007-09-14 17:18:17 -0700 (Fri, 14 Sep 2007) | 5 lines +r29437 | etxrab | 2009-08-15 14:59:03 -0700 (Sat, 15 Aug 2009) | 1 line Changed paths: - M /trunk/epan/libwireshark.def - M /trunk/epan/privileges.c - M /trunk/epan/privileges.h - M /trunk/gtk/main.c - M /trunk/gtk/recent.c - M /trunk/gtk/recent.h - M /trunk/tshark.c - M /trunk/version_info.c - M /trunk/version_info.h - -Add routines under Windows to check if npf.sys is running, and to -fetch the major OS version. If we're running Windows >= 6 (Vista) -_and_ npf.sys isn't running, warn the user in Wireshark and TShark. -Add a recent prefs item to disable the warning in Wireshark. + M /trunk/gtk/new_packet_list.c +Try to please build bot ------------------------------------------------------------------------ -r22878 | sfisher | 2007-09-15 22:42:02 -0700 (Sat, 15 Sep 2007) | 4 lines +r29438 | sfisher | 2009-08-15 19:35:44 -0700 (Sat, 15 Aug 2009) | 4 lines Changed paths: - M /trunk/gtk/follow_ssl.c - M /trunk/gtk/follow_tcp.c - + M /trunk/gtk/new_packet_list.c -Free some recently added strings when we are done with them. +Mark function paramter as unused with _U_ to please gcc. ------------------------------------------------------------------------- -r22879 | jake | 2007-09-16 02:07:30 -0700 (Sun, 16 Sep 2007) | 5 lines -Changed paths: - M /trunk/epan/dissectors/packet-fc.c -The Fibre Channel protocol defines a virtual fabric tag (VFT) similar to -ethernet's VLAN tag. It is sometimes called the VSAN tag. -It used to be proprietary, but now it's standard. -Wireshark currently displays it as an 8-byte field without dissecting it further. -It'd be nice to have it broken down into fields. A patch is attached. ------------------------------------------------------------------------ -r22880 | jake | 2007-09-16 05:56:12 -0700 (Sun, 16 Sep 2007) | 4 lines +r29439 | krj | 2009-08-15 21:08:00 -0700 (Sat, 15 Aug 2009) | 5 lines Changed paths: - M /trunk/epan/dissectors/packet-fcels.h + M /trunk/gtk/new_packet_list.c + M /trunk/gtk/packet_list_store.c + M /trunk/gtk/packet_list_store.h -From Joe Eykholt -The decodes of FC ELS opcodes is incomplete. The attached patch adds a few -more that are sometimes seen (ECHO, RTV, RLS, REC, and LKA). -The list is still incomplete. ------------------------------------------------------------------------- -r22881 | stig | 2007-09-16 06:18:18 -0700 (Sun, 16 Sep 2007) | 3 lines -Changed paths: - M /trunk/epan/dissectors/packet-tcp.c +Switch over to using GPtrArray instead of manually g_renew'ing. This switch has some benefits: -Always show real window size in the Info column for SYN packets. -Added window size for non-ack packets (was removed in r16884). +1) We don't have to manually resize +2) GPtrArray uses a sligtly more efficient allocation scheme. It increases the size of the array exponentially which reduces the amount of memcpy's we have to do when we resize the array ------------------------------------------------------------------------ -r22882 | jake | 2007-09-16 07:22:06 -0700 (Sun, 16 Sep 2007) | 2 lines +r29440 | krj | 2009-08-15 21:54:33 -0700 (Sat, 15 Aug 2009) | 1 line Changed paths: - M /trunk/plugins/v5ua/moduleinfo.h - M /trunk/plugins/v5ua/moduleinfo.nmake - M /trunk/plugins/v5ua/packet-v5ua.c + M /trunk/epan/reassemble.c -Fix for bug 1687: -Add RFC 3807 defined V5 interface boundary primitives message class. +Use the slice allocator if GLIB >= 2,10,0 ------------------------------------------------------------------------ -r22883 | gerald | 2007-09-16 12:28:58 -0700 (Sun, 16 Sep 2007) | 2 lines +r29441 | krj | 2009-08-16 00:29:11 -0700 (Sun, 16 Aug 2009) | 1 line Changed paths: - M /trunk/docbook/release-notes.xml - M /trunk/epan/dissectors/packet-ssl-utils.h - M /trunk/epan/dissectors/packet-ssl.c - -Fix a buffer overflow found by Stefan Esser (untested). + M /trunk/epan/exceptions.h + M /trunk/epan/tvbuff.c +Remove a non thread-safe usage (useful when/if we ever support threading) of a static tvbuff in tvb_new_real_data(). The current version uses a static 'last_tvb' to keep track of the last allocated tvbuff. This is needed because some of the function we call can throw an exception. This patch improves this strategy by throwing an exception (if needed) before we try to allocate the tvbuff. This way we avoid a memleak _and_ we don't have to track the 'last_tvb' tvbuff. ------------------------------------------------------------------------ -r22884 | kukosa | 2007-09-17 03:39:09 -0700 (Mon, 17 Sep 2007) | 1 line +r29442 | krj | 2009-08-16 01:18:17 -0700 (Sun, 16 Aug 2009) | 1 line Changed paths: - M /trunk/asn1/Makefile.am - M /trunk/asn1/Makefile.nmake - A /trunk/asn1/sabp - A /trunk/asn1/sabp/Makefile - A /trunk/asn1/sabp/Makefile.nmake - A /trunk/asn1/sabp/SABP-CommonDataTypes.asn - A /trunk/asn1/sabp/SABP-Constants.asn - A /trunk/asn1/sabp/SABP-Containers.asn - A /trunk/asn1/sabp/SABP-IEs.asn - A /trunk/asn1/sabp/SABP-PDU-Contents.asn - A /trunk/asn1/sabp/SABP-PDU-Descriptions.asn - A /trunk/asn1/sabp/packet-sabp-template.c - A /trunk/asn1/sabp/sabp.cnf - M /trunk/epan/dissectors/Makefile.common + M /trunk/epan/tvbuff.c -SABP protocol implemented (not tested as traces are not available) +Make some of the check_XXX functions accept the length/reported length of the tvbuff as arguments instead the tvbuff. We'll need this feature in order to remove the non-thread usage of the 'last_tvb' variable in tvb_new_subset() ------------------------------------------------------------------------ -r22885 | kukosa | 2007-09-17 04:00:42 -0700 (Mon, 17 Sep 2007) | 1 line +r29443 | krj | 2009-08-16 02:18:17 -0700 (Sun, 16 Aug 2009) | 1 line Changed paths: - M /trunk/asn1/sabp/Makefile - M /trunk/asn1/sabp/Makefile.nmake - M /trunk/asn1/sabp/SABP-CommonDataTypes.asn - M /trunk/asn1/sabp/SABP-Constants.asn - M /trunk/asn1/sabp/SABP-Containers.asn - M /trunk/asn1/sabp/SABP-IEs.asn - M /trunk/asn1/sabp/SABP-PDU-Contents.asn - M /trunk/asn1/sabp/SABP-PDU-Descriptions.asn - M /trunk/asn1/sabp/packet-sabp-template.c - M /trunk/asn1/sabp/sabp.cnf - A /trunk/epan/dissectors/packet-sabp.c + M /trunk/epan/tvbuff.c -add missing file and change file attributes +Remove the non-thread safe usage of 'last_tvb' variable in tvb_new_subset() ------------------------------------------------------------------------ -r22886 | stig | 2007-09-17 04:53:33 -0700 (Mon, 17 Sep 2007) | 4 lines +r29444 | krj | 2009-08-16 02:48:25 -0700 (Sun, 16 Aug 2009) | 1 line Changed paths: - M /trunk/asn1/h248/Makefile - M /trunk/asn1/h450/Makefile - M /trunk/asn1/inap/Makefile - M /trunk/asn1/nbap/Makefile - M /trunk/asn1/ranap/Makefile - M /trunk/asn1/rnsap/Makefile - M /trunk/asn1/sabp/Makefile - M /trunk/asn1/snmp/Makefile - M /trunk/asn1/t38/Makefile - D /trunk/asn1/x501 - -Modified some ASN1 Makefiles to compile on unix. -Added some clean targets. -Removed asn1/x501 directory. + M /trunk/epan/tvbuff.c +Remove unused parameters ------------------------------------------------------------------------ -r22887 | stig | 2007-09-17 05:12:02 -0700 (Mon, 17 Sep 2007) | 6 lines +r29445 | krj | 2009-08-16 03:53:47 -0700 (Sun, 16 Aug 2009) | 4 lines Changed paths: - M /trunk/epan/dissectors/packet-eth.c - M /trunk/epan/dissectors/packet-ieee80211.c - M /trunk/epan/proto.c - M /trunk/epan/proto.h - M /trunk/gtk/main.c - M /trunk/gtk/proto_draw.c + M /trunk/epan/tvbuff.c + M /trunk/epan/tvbuff.h -Added functionality to highlight the FCS bytes in Ethernet and IEEE 802.11 -packets in the Packet Details View. +Add a new function, tvb_new_subset_remaining(), which is a sligtly optimized version of tvb_new_subset(). The latter can be mapped to the former by tvb_new_subset(tvb, offset, -1 /* backing_length */, -1 /* reported_length */). We can disable some bounds checking because 'backing_length' and 'reported_length' are hardcoded to -1. -This "appendix" bytes are not copied with the Copy functions or in the -Export Selected Packet Bytes. +The current implementation of tvb_new_subset_remaining() only has the THROW_ON(reported_length < 1) check removed when compared to tvb_new_subset(). So there's room for improvement in this function. We should be able to disable some more (redundant) bounds checking. ------------------------------------------------------------------------ -r22888 | kukosa | 2007-09-17 06:23:25 -0700 (Mon, 17 Sep 2007) | 1 line +r29446 | krj | 2009-08-16 05:36:22 -0700 (Sun, 16 Aug 2009) | 1 line Changed paths: - M /trunk/asn1/qsig/packet-qsig-template.c - M /trunk/asn1/qsig/qsig-exp.cnf - M /trunk/asn1/qsig/qsig.cnf - M /trunk/epan/dissectors/packet-qsig.c - M /trunk/epan/dissectors/packet-qsig.h - M /trunk/epan/libwireshark.def - -Support of QSIG Extensions ------------------------------------------------------------------------- -r22889 | stig | 2007-09-17 07:10:34 -0700 (Mon, 17 Sep 2007) | 6 lines -Changed paths: - M /trunk/AUTHORS + M /trunk/asn1/ldap/packet-ldap-template.c + M /trunk/asn1/mpeg-pes/packet-mpeg-pes-template.c + M /trunk/asn1/pres/packet-pres-template.c + M /trunk/asn1/snmp/packet-snmp-template.c + M /trunk/asn1/spnego/packet-spnego-template.c + M /trunk/asn1/t38/packet-t38-template.c + M /trunk/epan/dissectors/packet-3com-xns.c + M /trunk/epan/dissectors/packet-afp.c + M /trunk/epan/dissectors/packet-aim-icq.c + M /trunk/epan/dissectors/packet-aim-messaging.c + M /trunk/epan/dissectors/packet-aim.c + M /trunk/epan/dissectors/packet-airopeek.c + M /trunk/epan/dissectors/packet-ap1394.c + M /trunk/epan/dissectors/packet-arcnet.c + M /trunk/epan/dissectors/packet-artnet.c + M /trunk/epan/dissectors/packet-asap.c + M /trunk/epan/dissectors/packet-atalk.c + M /trunk/epan/dissectors/packet-atm.c + M /trunk/epan/dissectors/packet-ayiya.c + M /trunk/epan/dissectors/packet-bacnet.c + M /trunk/epan/dissectors/packet-bat.c + M /trunk/epan/dissectors/packet-bctp.c + M /trunk/epan/dissectors/packet-ber.c + M /trunk/epan/dissectors/packet-bssgp.c + M /trunk/epan/dissectors/packet-capwap.c + M /trunk/epan/dissectors/packet-cdp.c + M /trunk/epan/dissectors/packet-chdlc.c + M /trunk/epan/dissectors/packet-cisco-erspan.c + M /trunk/epan/dissectors/packet-clnp.c + M /trunk/epan/dissectors/packet-cosine.c + M /trunk/epan/dissectors/packet-dccp.c + M /trunk/epan/dissectors/packet-dcerpc.c + M /trunk/epan/dissectors/packet-dcp-etsi.c + M /trunk/epan/dissectors/packet-dsi.c + M /trunk/epan/dissectors/packet-dtpt.c + M /trunk/epan/dissectors/packet-dua.c + M /trunk/epan/dissectors/packet-eapol.c + M /trunk/epan/dissectors/packet-egd.c + M /trunk/epan/dissectors/packet-ehs.c + M /trunk/epan/dissectors/packet-eigrp.c + M /trunk/epan/dissectors/packet-enc.c + M /trunk/epan/dissectors/packet-enrp.c + M /trunk/epan/dissectors/packet-erf.c + M /trunk/epan/dissectors/packet-ethertype.c + M /trunk/epan/dissectors/packet-fc.c + M /trunk/epan/dissectors/packet-fcct.c + M /trunk/epan/dissectors/packet-fcip.c + M /trunk/epan/dissectors/packet-fcsb3.c + M /trunk/epan/dissectors/packet-fcswils.c + M /trunk/epan/dissectors/packet-fddi.c + M /trunk/epan/dissectors/packet-fefd.c + M /trunk/epan/dissectors/packet-fr.c + M /trunk/epan/dissectors/packet-giop.c + M /trunk/epan/dissectors/packet-gmrp.c + M /trunk/epan/dissectors/packet-gprs-ns.c + M /trunk/epan/dissectors/packet-gre.c + M /trunk/epan/dissectors/packet-gsm_map.c + M /trunk/epan/dissectors/packet-gsm_sms.c + M /trunk/epan/dissectors/packet-gsm_sms_ud.c + M /trunk/epan/dissectors/packet-gssapi.c + M /trunk/epan/dissectors/packet-gtp.c + M /trunk/epan/dissectors/packet-gvrp.c + M /trunk/epan/dissectors/packet-hci_h1.c + M /trunk/epan/dissectors/packet-hci_h4.c + M /trunk/epan/dissectors/packet-hip.c + M /trunk/epan/dissectors/packet-hpext.c + M /trunk/epan/dissectors/packet-hsrp.c + M /trunk/epan/dissectors/packet-iax2.c + M /trunk/epan/dissectors/packet-icap.c + M /trunk/epan/dissectors/packet-icmp.c + M /trunk/epan/dissectors/packet-icmpv6.c + M /trunk/epan/dissectors/packet-idp.c + M /trunk/epan/dissectors/packet-ieee80211.c + M /trunk/epan/dissectors/packet-ieee8021ah.c + M /trunk/epan/dissectors/packet-ieee8023.c + M /trunk/epan/dissectors/packet-ieee802a.c + M /trunk/epan/dissectors/packet-imf.c + M /trunk/epan/dissectors/packet-ip.c + M /trunk/epan/dissectors/packet-ipars.c + M /trunk/epan/dissectors/packet-ipfc.c + M /trunk/epan/dissectors/packet-ipp.c + M /trunk/epan/dissectors/packet-ipsec.c + M /trunk/epan/dissectors/packet-ipv6.c + M /trunk/epan/dissectors/packet-ipx.c + M /trunk/epan/dissectors/packet-isl.c + M /trunk/epan/dissectors/packet-isup.c + M /trunk/epan/dissectors/packet-itdm.c + M /trunk/epan/dissectors/packet-iua.c + M /trunk/epan/dissectors/packet-iuup.c + M /trunk/epan/dissectors/packet-iwarp-ddp-rdmap.c + M /trunk/epan/dissectors/packet-jabber.c + M /trunk/epan/dissectors/packet-juniper.c + M /trunk/epan/dissectors/packet-jxta.c + M /trunk/epan/dissectors/packet-kpasswd.c + M /trunk/epan/dissectors/packet-l2tp.c + M /trunk/epan/dissectors/packet-lanforge.c + M /trunk/epan/dissectors/packet-lapb.c + M /trunk/epan/dissectors/packet-lapd.c + M /trunk/epan/dissectors/packet-ldap.c + M /trunk/epan/dissectors/packet-lge_monitor.c + M /trunk/epan/dissectors/packet-llc.c + M /trunk/epan/dissectors/packet-loop.c + M /trunk/epan/dissectors/packet-lwapp.c + M /trunk/epan/dissectors/packet-m2pa.c + M /trunk/epan/dissectors/packet-m2ua.c + M /trunk/epan/dissectors/packet-m3ua.c + M /trunk/epan/dissectors/packet-mdshdr.c + M /trunk/epan/dissectors/packet-mgcp.c + M /trunk/epan/dissectors/packet-mikey.c + M /trunk/epan/dissectors/packet-miop.c + M /trunk/epan/dissectors/packet-mip.c + M /trunk/epan/dissectors/packet-mip6.c + M /trunk/epan/dissectors/packet-mmse.c + M /trunk/epan/dissectors/packet-mpeg-pes.c + M /trunk/epan/dissectors/packet-mpls.c + M /trunk/epan/dissectors/packet-mq.c + M /trunk/epan/dissectors/packet-msdp.c + M /trunk/epan/dissectors/packet-msrp.c + M /trunk/epan/dissectors/packet-mtp2.c + M /trunk/epan/dissectors/packet-mtp3.c + M /trunk/epan/dissectors/packet-mtp3mg.c + M /trunk/epan/dissectors/packet-nbipx.c + M /trunk/epan/dissectors/packet-nbns.c + M /trunk/epan/dissectors/packet-ncp.c + M /trunk/epan/dissectors/packet-ndmp.c + M /trunk/epan/dissectors/packet-ndps.c + M /trunk/epan/dissectors/packet-netbios.c + M /trunk/epan/dissectors/packet-nhrp.c + M /trunk/epan/dissectors/packet-nsip.c + M /trunk/epan/dissectors/packet-null.c + M /trunk/epan/dissectors/packet-osi.c + M /trunk/epan/dissectors/packet-ositp.c + M /trunk/epan/dissectors/packet-ospf.c + M /trunk/epan/dissectors/packet-pcli.c + M /trunk/epan/dissectors/packet-pdcp-lte.c + M /trunk/epan/dissectors/packet-pflog.c + M /trunk/epan/dissectors/packet-pgm.c + M /trunk/epan/dissectors/packet-pim.c + M /trunk/epan/dissectors/packet-pktc.c + M /trunk/epan/dissectors/packet-pktgen.c + M /trunk/epan/dissectors/packet-ppi.c + M /trunk/epan/dissectors/packet-ppp.c + M /trunk/epan/dissectors/packet-pptp.c + M /trunk/epan/dissectors/packet-pres.c + M /trunk/epan/dissectors/packet-pw-atm.c + M /trunk/epan/dissectors/packet-pw-eth.c + M /trunk/epan/dissectors/packet-pw-hdlc.c + M /trunk/epan/dissectors/packet-q931.c + M /trunk/epan/dissectors/packet-radiotap.c + M /trunk/epan/dissectors/packet-raw.c + M /trunk/epan/dissectors/packet-redback.c + M /trunk/epan/dissectors/packet-redbackli.c + M /trunk/epan/dissectors/packet-rmcp.c + M /trunk/epan/dissectors/packet-rmi.c + M /trunk/epan/dissectors/packet-rmp.c + M /trunk/epan/dissectors/packet-rmt-alc.c + M /trunk/epan/dissectors/packet-roofnet.c + M /trunk/epan/dissectors/packet-rpc.c + M /trunk/epan/dissectors/packet-rpl.c + M /trunk/epan/dissectors/packet-rtnet.c + M /trunk/epan/dissectors/packet-rtp.c + M /trunk/epan/dissectors/packet-rudp.c + M /trunk/epan/dissectors/packet-rx.c + M /trunk/epan/dissectors/packet-sap.c + M /trunk/epan/dissectors/packet-sctp.c + M /trunk/epan/dissectors/packet-sdlc.c + M /trunk/epan/dissectors/packet-sdp.c + M /trunk/epan/dissectors/packet-ses.c + M /trunk/epan/dissectors/packet-simulcrypt.c + M /trunk/epan/dissectors/packet-sll.c + M /trunk/epan/dissectors/packet-smb.c + M /trunk/epan/dissectors/packet-smb2.c + M /trunk/epan/dissectors/packet-sna.c + M /trunk/epan/dissectors/packet-snaeth.c + M /trunk/epan/dissectors/packet-sndcp.c + M /trunk/epan/dissectors/packet-snmp.c + M /trunk/epan/dissectors/packet-spnego.c + M /trunk/epan/dissectors/packet-spp.c + M /trunk/epan/dissectors/packet-srp.c + M /trunk/epan/dissectors/packet-ssl.c + M /trunk/epan/dissectors/packet-sua.c + M /trunk/epan/dissectors/packet-symantec.c + M /trunk/epan/dissectors/packet-t38.c + M /trunk/epan/dissectors/packet-tali.c + M /trunk/epan/dissectors/packet-tcp.c + M /trunk/epan/dissectors/packet-tds.c + M /trunk/epan/dissectors/packet-teamspeak2.c + M /trunk/epan/dissectors/packet-telkonet.c + M /trunk/epan/dissectors/packet-teredo.c M /trunk/epan/dissectors/packet-tipc.c + M /trunk/epan/dissectors/packet-tns.c + M /trunk/epan/dissectors/packet-tr.c + M /trunk/epan/dissectors/packet-tte.c + M /trunk/epan/dissectors/packet-turbocell.c + M /trunk/epan/dissectors/packet-tzsp.c + M /trunk/epan/dissectors/packet-ucp.c + M /trunk/epan/dissectors/packet-udld.c + M /trunk/epan/dissectors/packet-usb.c + M /trunk/epan/dissectors/packet-v120.c + M /trunk/epan/dissectors/packet-v5ua.c + M /trunk/epan/dissectors/packet-vcdu.c + M /trunk/epan/dissectors/packet-vines.c + M /trunk/epan/dissectors/packet-wcp.c + M /trunk/epan/dissectors/packet-wfleet-hdlc.c + M /trunk/epan/dissectors/packet-wsp.c + M /trunk/epan/dissectors/packet-wtp.c + M /trunk/epan/dissectors/packet-x224.c + M /trunk/epan/dissectors/packet-x25.c + M /trunk/epan/dissectors/packet-zbee-aps.c + M /trunk/epan/dissectors/packet-zbee-nwk.c + M /trunk/epan/dissectors/packet-zbee-zdp.c + M /trunk/epan/libwireshark.def + M /trunk/epan/reassemble.c + M /trunk/plugins/docsis/packet-bpkmreq.c + M /trunk/plugins/docsis/packet-bpkmrsp.c + M /trunk/plugins/docsis/packet-dsaack.c + M /trunk/plugins/docsis/packet-dsareq.c + M /trunk/plugins/docsis/packet-dsarsp.c + M /trunk/plugins/docsis/packet-dscack.c + M /trunk/plugins/docsis/packet-dscreq.c + M /trunk/plugins/docsis/packet-dscrsp.c + M /trunk/plugins/docsis/packet-dsdreq.c + M /trunk/plugins/docsis/packet-regack.c + M /trunk/plugins/docsis/packet-regreq.c + M /trunk/plugins/docsis/packet-regreqmp.c + M /trunk/plugins/docsis/packet-regrsp.c + M /trunk/plugins/docsis/packet-regrspmp.c + M /trunk/plugins/docsis/packet-uccreq.c + M /trunk/plugins/ethercat/packet-esl.c + M /trunk/plugins/ethercat/packet-ethercat-frame.c + M /trunk/plugins/irda/packet-ircomm.c + M /trunk/plugins/irda/packet-irda.c + M /trunk/plugins/profinet/packet-dcom-cba-acco.c + M /trunk/plugins/profinet/packet-pn-mrp.c + M /trunk/plugins/sercosiii/packet-sercosiii_1v1_at.c + M /trunk/plugins/sercosiii/packet-sercosiii_1v1_mdt.c -From Martin Peylo: -- reassembling of fragmented TIPCv2 messages -- calling of heuristic subdissectors -- multicast upper+lower bound header fields are now shown -- corrects few typos in the comments in packet-tipc.c - ------------------------------------------------------------------------- -r22890 | martinm | 2007-09-17 09:03:49 -0700 (Mon, 17 Sep 2007) | 1 line -Changed paths: - M /trunk/epan/dissectors/packet-catapult-dct2000.c - -Handle tty messages, diameter_r7, sabp +Switch a bunch of dissectors over to using tvb_new_subset_remaining() ------------------------------------------------------------------------ -r22891 | morriss | 2007-09-17 10:53:50 -0700 (Mon, 17 Sep 2007) | 1 line +r29447 | gerald | 2009-08-16 08:03:26 -0700 (Sun, 16 Aug 2009) | 1 line Changed paths: - M /trunk/asn1/tcap/packet-ansi_tcap-template.c - M /trunk/epan/dissectors/packet-ansi_tcap.c + M /trunk/epan/enterprise-numbers + M /trunk/manuf -From Florent Drouin: malloc the size of the structure, not the size of a pointer to the structure. Hopefully this will fix bug 1844. +[Automatic manuf and enterprise-numbers update for 2009-08-16] ------------------------------------------------------------------------ -r22892 | morriss | 2007-09-17 10:58:49 -0700 (Mon, 17 Sep 2007) | 1 line +r29450 | krj | 2009-08-16 08:33:05 -0700 (Sun, 16 Aug 2009) | 1 line Changed paths: - M /trunk/asn1/ansi_map/packet-ansi_map-template.c - M /trunk/epan/dissectors/packet-ansi_map.c + M /trunk/gtk/new_packet_list.c -(Again, this time for ANSI MAP) From Florent Drouin: malloc the size of the structure, not the size of a pointer to the structure. Hopefully this will fix bug 1844. +Add missing call to packets_bar_update() after thaw'ing ------------------------------------------------------------------------ -r22893 | stig | 2007-09-17 11:24:20 -0700 (Mon, 17 Sep 2007) | 2 lines +r29451 | krj | 2009-08-16 21:23:47 -0700 (Sun, 16 Aug 2009) | 4 lines Changed paths: - M /trunk/asn1/tcap/Makefile - -Updated tcap Makefile to also build ANSI TCAP on unix. + M /trunk/epan/except.c ------------------------------------------------------------------------- -r22894 | gerald | 2007-09-17 11:40:34 -0700 (Mon, 17 Sep 2007) | 2 lines -Changed paths: - M /trunk/packaging/nsis/GetWindowsVersion.nsh - M /trunk/packaging/nsis/wireshark.nsi +Add proper type cast. -Enable NPF by default under Vista. +Thanks to Martin for reporting this. ------------------------------------------------------------------------ -r22895 | stig | 2007-09-17 15:42:15 -0700 (Mon, 17 Sep 2007) | 2 lines +r29452 | krj | 2009-08-17 04:13:36 -0700 (Mon, 17 Aug 2009) | 1 line Changed paths: - M /trunk/configure.in - -Added test to the libsmi AM_CONDITIONAL to remove a error message in configure. + M /trunk/epan/proto.c +Don't do PROTO_REGISTRAR_GET_NTH twice. ------------------------------------------------------------------------ -r22896 | kukosa | 2007-09-18 04:46:50 -0700 (Tue, 18 Sep 2007) | 2 lines +r29453 | krj | 2009-08-17 04:21:33 -0700 (Mon, 17 Aug 2009) | 1 line Changed paths: - M /trunk/asn1/sabp/sabp.cnf - M /trunk/epan/dissectors/packet-per.c - M /trunk/epan/dissectors/packet-sabp.c + M /trunk/epan/proto.c -PER: fix bitstring handling if SIZE(n) where n<=16 -SABP: implement some forgotten code +Move the NULL pointer 'tree' check under TRY_TO_FAKE_THIS_ITEMs umbrella ------------------------------------------------------------------------ -r22897 | kukosa | 2007-09-18 04:49:26 -0700 (Tue, 18 Sep 2007) | 1 line +r29454 | etxrab | 2009-08-17 08:05:43 -0700 (Mon, 17 Aug 2009) | 1 line Changed paths: - M /trunk/asn1/qsig/Makefile + M /trunk/epan/column-utils.c + M /trunk/gtk/new_packet_list.c + M /trunk/gtk/packet_list_store.c -missing SYNC-SIG.asn in unix makefile +Prepare to store column data from pinfo. ------------------------------------------------------------------------ -r22898 | stig | 2007-09-18 05:33:54 -0700 (Tue, 18 Sep 2007) | 2 lines +r29455 | etxrab | 2009-08-17 08:13:58 -0700 (Mon, 17 Aug 2009) | 1 line Changed paths: - M /trunk/asn1/gsmmap/Makefile - -Added missing MAP-Errors.asn in unix Makefile. + M /trunk/gtk/new_packet_list.c +Remove #if 0 ------------------------------------------------------------------------ -r22899 | stig | 2007-09-18 05:37:52 -0700 (Tue, 18 Sep 2007) | 2 lines +r29456 | krj | 2009-08-17 10:19:31 -0700 (Mon, 17 Aug 2009) | 4 lines Changed paths: - M /trunk/asn1/qsig/Makefile - -Adding SYNC-SIG.asn twice is not such a good idea... + M /trunk/epan/dissectors/packet-dect.c ------------------------------------------------------------------------- -r22900 | stig | 2007-09-18 05:47:40 -0700 (Tue, 18 Sep 2007) | 2 lines -Changed paths: - A /trunk/asn1/inap/inap-exp.cnf +setbit() is (AFAIK) defined in <sys/param.h> (OpenBSD) so rename to dect_setbit() to avoid clash. getbit() is also renamed for consistency. -Added inap-exp.cnf as camel depends on this. +Fixes the issue reported by Stan: http://www.wireshark.org/lists/wireshark-users/200908/msg00128.html ------------------------------------------------------------------------ -r22901 | stig | 2007-09-18 06:03:18 -0700 (Tue, 18 Sep 2007) | 2 lines +r29457 | jake | 2009-08-17 12:10:19 -0700 (Mon, 17 Aug 2009) | 2 lines Changed paths: - M /trunk/asn1/Makefile.am + M /trunk/gtk/graph_analysis.c -And add it to the Makefile... +Change window_new() to dlg_window_new() and destroy the window with the top level window. ------------------------------------------------------------------------ -r22902 | wmeier | 2007-09-18 08:30:34 -0700 (Tue, 18 Sep 2007) | 2 lines +r29458 | krj | 2009-08-17 13:14:59 -0700 (Mon, 17 Aug 2009) | 1 line Changed paths: - M /trunk/text2pcap.c - -If bad date/time: use 1/1/70 00:00:00 local time; Add some addt'l output if debug option used + M /trunk/epan/except.c +As pointed out by Guy, we should probably explain why the gulong -> size_t cast is 'safe' ------------------------------------------------------------------------ -r22903 | jmayer | 2007-09-18 08:59:40 -0700 (Tue, 18 Sep 2007) | 7 lines +r29459 | sfisher | 2009-08-17 17:32:11 -0700 (Mon, 17 Aug 2009) | 7 lines Changed paths: - D /trunk/asn1/inap/inap-exp.cnf - -Remove autogenerated file: + M /trunk/epan/dissectors/packet-x224.c -# Do not modify this file. -# It is created automatically by the ASN.1 to Wireshark dissector compiler -# ./inap-exp.cnf +Display Microsoft's Remote Desktop Protocol (RDP) extension to the X.224 +connection request that shows the session load balancing information. There +appears to be more dissecting that can be done for this field, but I don't +have any sample captures to test this. + ------------------------------------------------------------------------ -r22904 | jmayer | 2007-09-18 09:00:51 -0700 (Tue, 18 Sep 2007) | 2 lines +r29460 | jake | 2009-08-17 23:41:12 -0700 (Mon, 17 Aug 2009) | 3 lines Changed paths: - M /trunk/epan/dissectors/packet-extreme.c + M /trunk/epan/dissectors/packet-gtpv2.c -Try to improve dissection of ELSM message (guesswork) +From Swapnil Barai: +Minor Bug in Bearer Context in Packet-gtpv2.c fixed. ------------------------------------------------------------------------ -r22905 | jmayer | 2007-09-18 09:31:03 -0700 (Tue, 18 Sep 2007) | 3 lines +r29461 | etxrab | 2009-08-18 01:00:05 -0700 (Tue, 18 Aug 2009) | 2 lines Changed paths: - M /trunk/asn1/Makefile.am - -Remove the autogenerated file. Will fix the camel build process tomorrow -to automatically regenerate inap-exp.cnf if it doesn't exist. + M /trunk/diameter/TGPPRx.xml + M /trunk/diameter/gqpolicy.xml +From Mathias de Paulis Nilsson: +Updates to V8.5.0. ------------------------------------------------------------------------ -r22906 | martinm | 2007-09-19 02:27:34 -0700 (Wed, 19 Sep 2007) | 2 lines +r29462 | etxrab | 2009-08-18 04:39:55 -0700 (Tue, 18 Aug 2009) | 1 line Changed paths: - M /trunk/epan/dissectors/packet-sip.c - -Add authentication ik and ck parameters. + M /trunk/asn1/nbap/nbap.cnf + M /trunk/asn1/ranap/ranap.cnf + M /trunk/asn1/s1ap/s1ap.cnf + M /trunk/epan/dissectors/packet-nbap.c + M /trunk/epan/dissectors/packet-ranap.c + M /trunk/epan/dissectors/packet-s1ap.c +Typo: parameter_tvb to be used. ------------------------------------------------------------------------ -r22907 | bondolo | 2007-09-19 09:34:06 -0700 (Wed, 19 Sep 2007) | 3 lines +r29463 | etxrab | 2009-08-18 05:15:36 -0700 (Tue, 18 Aug 2009) | 1 line Changed paths: - M /trunk/epan/packet.c - -call_dissector() provides generic 'data' handler for unrecognized data types. call_dissector_only() fails gracefully for unrecognized types. The handler for generic 'data' should avoid the variant that potentially could result in recursively calling itself. - + M /trunk/asn1/s1ap/s1ap.cnf + M /trunk/epan/dissectors/packet-s1ap.c +Make build bot happy? ------------------------------------------------------------------------ -r22908 | martinm | 2007-09-19 10:33:08 -0700 (Wed, 19 Sep 2007) | 2 lines +r29464 | morriss | 2009-08-18 06:25:49 -0700 (Tue, 18 Aug 2009) | 1 line Changed paths: - M /trunk/epan/dissectors/packet-smpp.c - -Make this dissector finable by name. + M /trunk/epan/dissectors/packet-sccp.c +Add an expert info noting that an ANSI message with the national indicator set to 0 (international) is unusual. ------------------------------------------------------------------------ -r22909 | jake | 2007-09-19 11:54:31 -0700 (Wed, 19 Sep 2007) | 1 line +r29465 | stig | 2009-08-18 07:37:25 -0700 (Tue, 18 Aug 2009) | 2 lines Changed paths: - M /trunk/epan/dissectors/packet-mikey.c + M /trunk/cmake/modules/FindGLIB2.cmake + M /trunk/cmake/modules/FindGTK2.cmake -Cleanup the source somewhat. ------------------------------------------------------------------------- -r22910 | jake | 2007-09-19 11:57:09 -0700 (Wed, 19 Sep 2007) | 2 lines -Changed paths: - M /trunk/plugins/unistim/basic.h +Search for includes and libs in /opt/local/ (MacPorts). -From Don Newton: -Added phone type using Nortel branded Polycom unistim conference phone. ------------------------------------------------------------------------ -r22911 | jake | 2007-09-19 13:12:38 -0700 (Wed, 19 Sep 2007) | 1 line +r29466 | etxrab | 2009-08-18 07:39:32 -0700 (Tue, 18 Aug 2009) | 1 line Changed paths: - M /trunk/epan/dissectors/packet-mikey.c + M /trunk/epan/dissectors/packet-gsm_a_gm.c -Add UDP and TCP port preferences. +Minor clean up. ------------------------------------------------------------------------ -r22912 | etxrab | 2007-09-19 14:02:41 -0700 (Wed, 19 Sep 2007) | 1 line +r29467 | etxrab | 2009-08-18 07:40:51 -0700 (Tue, 18 Aug 2009) | 2 lines Changed paths: - M /trunk/epan/dissectors/packet-lapd.c - M /trunk/epan/lapd_sapi.h + M /trunk/gtk/menus.c + M /trunk/gtk/new_packet_list.c + M /trunk/gtk/new_packet_list.h -Make it possible to use GSM SAPI:s +Make copy summary work for new_packet_list. +XXX The enum in .h file does not seem to work??? ------------------------------------------------------------------------ -r22913 | gerald | 2007-09-19 14:39:52 -0700 (Wed, 19 Sep 2007) | 3 lines +r29468 | jake | 2009-08-18 10:36:30 -0700 (Tue, 18 Aug 2009) | 2 lines Changed paths: - M /trunk/epan/dissectors/packet-ieee80211.c + M /trunk/gtk/rtp_player.c -Append the packet type and flags to the top-level 802.11 tree item, and append -the flags to the info column. Make the info column presentation consistent. +Properly handle closing/destruction of RTP player window. ------------------------------------------------------------------------ -r22914 | gerald | 2007-09-19 15:57:40 -0700 (Wed, 19 Sep 2007) | 2 lines +r29469 | etxrab | 2009-08-18 16:00:42 -0700 (Tue, 18 Aug 2009) | 1 line Changed paths: - M /trunk/docbook/release-notes.xml - -Add an item for ANSI MAP. + M /trunk/gtk/new_packet_list.c + M /trunk/gtk/new_packet_list.h + M /trunk/gtk/recent.c +Add new_packet_list_recent_write_all(). ------------------------------------------------------------------------ -r22915 | jake | 2007-09-19 23:50:53 -0700 (Wed, 19 Sep 2007) | 4 lines +r29470 | etxrab | 2009-08-18 23:04:30 -0700 (Tue, 18 Aug 2009) | 1 line Changed paths: - M /trunk/epan/dissectors/packet-fcoe.c + M /trunk/gtk/new_packet_list.c -From Joe Eykholt: -At an August 2007 meeting, a T11 committee made changes to the encapsulation -protocol for FCoE. For the latest info, see http://fcoe.com. -The attached patch will update the dissector to handle the new version also. +Fix a memmory leak. ------------------------------------------------------------------------ -r22916 | wmeier | 2007-09-20 09:12:17 -0700 (Thu, 20 Sep 2007) | 2 lines +r29471 | etxrab | 2009-08-19 00:55:11 -0700 (Wed, 19 Aug 2009) | 3 lines Changed paths: - M /trunk/doc/text2pcap.pod - M /trunk/text2pcap.c - -When -t option: Use current date or time fields for unspecified fields; Fixes bug #1836. + M /trunk/epan/column-utils.c + M /trunk/epan/column_info.h +From Didier Gautheron: +Extracted from optimizations patch http://wiki.wireshark.org/Development/Optimization +Make col_expr const gchar. ------------------------------------------------------------------------ -r22917 | etxrab | 2007-09-21 10:07:05 -0700 (Fri, 21 Sep 2007) | 1 line +r29472 | etxrab | 2009-08-19 02:32:56 -0700 (Wed, 19 Aug 2009) | 3 lines Changed paths: - M /trunk/epan/dissectors/packet-gsm_a.c + M /trunk/epan/dissectors/packet-gsm_a_rr.c -Make it possible to decode messages on the CCCH link. +From Jan L?\195?\188bbe: +packet-gsm_a_rr.c: flip gsm_a_rr_mv_vals, 0 means vaild. +https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=3915 ------------------------------------------------------------------------ -r22918 | jake | 2007-09-21 11:56:49 -0700 (Fri, 21 Sep 2007) | 1 line +r29473 | etxrab | 2009-08-19 04:34:40 -0700 (Wed, 19 Aug 2009) | 3 lines Changed paths: - M /trunk/epan/dissectors/packet-gsm_a.c + M /trunk/epan/dissectors/packet-eigrp.c -Get the GSM A Interface dissector to compile again. +From Jochen Bartl: +EIGRP dissector enhancements (IPv6, Stub routing, Authentication TLVs) +https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=3907 ------------------------------------------------------------------------ -r22919 | etxrab | 2007-09-21 12:53:42 -0700 (Fri, 21 Sep 2007) | 1 line +r29474 | jmayer | 2009-08-19 05:25:40 -0700 (Wed, 19 Aug 2009) | 5 lines Changed paths: - A /trunk/epan/dissectors/packet-rsl.c + M /trunk/epan/dissectors/packet-capwap.c -Start of a Radio Signalling Link (RSL) dissector (3GPP TS 48.058). ------------------------------------------------------------------------- -r22920 | etxrab | 2007-09-21 12:54:20 -0700 (Fri, 21 Sep 2007) | 2 lines -Changed paths: - M /trunk/epan/dissectors/Makefile.common +Add support for Radio Mac/Wireless Specific Information optional +header fields. This patch lacks handling of padding since a) I don't +have a trace containing padding and b) I don't understand the +wording in the rfc (it's to ambigous for my liking). -Start of a Radio Signalling Link (RSL) dissector (3GPP TS 48.058). -And the makefile :) ------------------------------------------------------------------------ -r22921 | gerald | 2007-09-21 15:39:02 -0700 (Fri, 21 Sep 2007) | 2 lines +r29475 | krj | 2009-08-19 06:52:15 -0700 (Wed, 19 Aug 2009) | 4 lines Changed paths: - M /trunk/epan/dissectors/packet-rsl.c + M /trunk/file.c + +We shouldn't conditionalise on _filtering_ tap listerners to determine whether tapping should be performed or not. We also need to handle _normal_ tap listerners. This change backs out the regression introduced in r29435. -Fix compiler warnings. +Thanks to Didier: https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=3916 ------------------------------------------------------------------------ -r22922 | gerald | 2007-09-21 16:04:56 -0700 (Fri, 21 Sep 2007) | 3 lines +r29476 | jmayer | 2009-08-19 08:42:24 -0700 (Wed, 19 Aug 2009) | 5 lines Changed paths: - M /trunk/gtk/main.c + M /trunk/epan/dissectors/packet-capwap.c -Spell out each of the units in the status bar. A few people have remarked -that this would be helpful for new users. +As pointed out by Alexis La Goutte via PM, r29474 didn't +support the different MAC formats (eui48 and eui64) properly. +Now, eui48 is printed as mac, the rest is still handled as +blob. ------------------------------------------------------------------------ -r22923 | gerald | 2007-09-21 17:16:45 -0700 (Fri, 21 Sep 2007) | 4 lines +r29477 | etxrab | 2009-08-19 11:36:36 -0700 (Wed, 19 Aug 2009) | 5 lines Changed paths: - M /trunk/epan/column.c - M /trunk/epan/column_info.h - -Simplify the parsing of column preferences, which should make it easier -to add column prefs in the future. Fix up whitespace in a couple of -places. + A /trunk/gtk/expert_dlg.h +From Didier Gautheron: +Part 1 +Extracted from optimizations patch http://wiki.wireshark.org/Development/Optimization +Optimize expert info. +Slightly changed by me. ------------------------------------------------------------------------ -r22924 | jake | 2007-09-23 12:40:54 -0700 (Sun, 23 Sep 2007) | 5 lines +r29478 | etxrab | 2009-08-19 11:37:13 -0700 (Wed, 19 Aug 2009) | 5 lines Changed paths: - M /trunk/epan/dissectors/packet-bthci_cmd.c - M /trunk/epan/dissectors/packet-bthci_evt.c - M /trunk/epan/dissectors/packet-hci_h4.h + M /trunk/epan/libwireshark.def + M /trunk/epan/strutil.c + M /trunk/epan/strutil.h + M /trunk/gtk/Makefile.common + M /trunk/gtk/expert_comp_dlg.c + M /trunk/gtk/expert_comp_table.c + M /trunk/gtk/expert_comp_table.h + M /trunk/gtk/expert_dlg.c -From Allan M. Madsen: -Wireshark is only supporting a very old and deprecated version of the Bluetooth -specification (1.1). The Bluetooth SIG recently ratified version 2.1 of the -Bluetooth specification and a lot of enhancements have been added to the -specification. The HCI dissectors needs a major update to match these changes. +From Didier Gautheron: +Part 2 +Extracted from optimizations patch http://wiki.wireshark.org/Development/Optimization +Optimize expert info. +Slightly changed by me. ------------------------------------------------------------------------ -r22925 | etxrab | 2007-09-23 13:57:00 -0700 (Sun, 23 Sep 2007) | 1 line +r29479 | etxrab | 2009-08-19 11:39:30 -0700 (Wed, 19 Aug 2009) | 1 line Changed paths: - M /trunk/epan/dissectors/packet-gsm_a.c - M /trunk/epan/dissectors/packet-rsl.c + M /trunk/gtk/Makefile.nmake -Decode more IE's +Make it possible to run checkapi with "deprecated-gtk-todo". ------------------------------------------------------------------------ -r22926 | guy | 2007-09-23 15:10:59 -0700 (Sun, 23 Sep 2007) | 2 lines +r29480 | krj | 2009-08-19 12:08:34 -0700 (Wed, 19 Aug 2009) | 1 line Changed paths: - M /trunk/epan/dissectors/packet-gsm_a.c - -Close yer comments. + M /trunk/epan/proto.c +Move TRY_TO_FAKE_THIS_ITEM to all public proto_xxx methods. Currently we rely on our internal (static) helper functions to do the faking. However, when they fake a protocol tree, they usually return a valid tree (although a dummy tree it is still a valid one). This means that we end up calling proto_tree_set_representation + friends on it for no reason. By moving TRY_TO_FAKE_THIS_ITEM to the public proto_xxx methods we're able to bail immediately (when we're allowed to do so). ------------------------------------------------------------------------ -r22927 | etxrab | 2007-09-23 15:30:08 -0700 (Sun, 23 Sep 2007) | 1 line +r29481 | etxrab | 2009-08-19 12:20:45 -0700 (Wed, 19 Aug 2009) | 1 line Changed paths: - M /trunk/epan/dissectors/packet-rsl.c + M /trunk/gtk/expert_dlg.c -Fix a typo. +Destroy window with parent, update label when showing window. ------------------------------------------------------------------------ -r22928 | wmeier | 2007-09-23 17:42:34 -0700 (Sun, 23 Sep 2007) | 2 lines +r29482 | etxrab | 2009-08-20 00:26:16 -0700 (Thu, 20 Aug 2009) | 5 lines Changed paths: - M /trunk/epan/dissectors/packet-rsl.c + M /trunk/epan/dissectors/packet-gsm_a_common.h + M /trunk/epan/dissectors/packet-gsm_a_gm.c + M /trunk/epan/dissectors/packet-gsm_a_rr.c + M /trunk/epan/dissectors/packet-gtpv2.c + M /trunk/epan/dissectors/packet-nas_eps.c -#if 0 dissect_rsl_ie_meas_res_no and dissect_rsl_ie_message_id so buildbot doesn't error out. +From Harald Welte : +Connect RRLP to GSM A DTAP application info message. +https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=3919 +From me try to fix missuse of pinfo. ------------------------------------------------------------------------ -r22929 | jake | 2007-09-23 23:19:56 -0700 (Sun, 23 Sep 2007) | 6 lines +r29483 | etxrab | 2009-08-20 02:49:32 -0700 (Thu, 20 Aug 2009) | 1 line Changed paths: - M /trunk/gtk/voip_calls.c - M /trunk/plugins/unistim/Makefile.common - M /trunk/plugins/unistim/header_field.h - M /trunk/plugins/unistim/packet-unistim.c - A /trunk/plugins/unistim/uftp.h + M /trunk/epan/frame_data.h -From Chad Singer: -I fixed a bug in packet_unistim.c which was causing a 'malformed packet' to -appear when an open stream command is read with no endpoint ip (as is sometimes -done) I added a simple msg_len check to avoid this. -I also added UFTP to the unistim dissector and adjusted the unistim call-detection -in voip-info.c to start on an open stream as well as keypresses.. +Prepare to store column text in frame data directly. ------------------------------------------------------------------------ -r22930 | jake | 2007-09-23 23:42:59 -0700 (Sun, 23 Sep 2007) | 1 line +r29484 | martinm | 2009-08-20 06:16:34 -0700 (Thu, 20 Aug 2009) | 1 line Changed paths: - M /trunk/gtk/voip_calls.c + M /trunk/gtk/mac_lte_stat_dlg.c -Get rid of the last warning. +Trivial formatting changes ------------------------------------------------------------------------ -r22931 | jake | 2007-09-23 23:46:59 -0700 (Sun, 23 Sep 2007) | 4 lines +r29485 | martinm | 2009-08-20 06:25:41 -0700 (Thu, 20 Aug 2009) | 1 line Changed paths: - M /trunk/epan/dissectors/packet-ip.c + M /trunk/AUTHORS -From Jonathan: -Capture files generated on TCP segmentation offload (TSO) hardware have an -all-zero IP-length field in outbound packets. -Wireshark errors out on the small length and refuses to parse the packet further. +Update my entry ------------------------------------------------------------------------ -r22932 | jmayer | 2007-09-23 23:57:52 -0700 (Sun, 23 Sep 2007) | 4 lines +r29486 | krj | 2009-08-20 10:43:56 -0700 (Thu, 20 Aug 2009) | 1 line Changed paths: - M /trunk/tools/Makefile.am - M /trunk/tools/Makefile.nmake - -ome files were left even after "make maintainer-clean". Found -with "svn status --no-ignore". - + M /trunk/tools/fuzz-test.sh +Add error probability command line parameter ------------------------------------------------------------------------ -r22933 | jmayer | 2007-09-23 23:58:23 -0700 (Sun, 23 Sep 2007) | 4 lines +r29487 | jake | 2009-08-20 12:41:53 -0700 (Thu, 20 Aug 2009) | 3 lines Changed paths: - M /trunk/wiretap/Makefile.am - -Add ascend-grammar.h explicitely to the generation rules, otherwise -make distclean on a really clean source tree will fail. - + M /trunk/plugins/docsis/Makefile.common + A /trunk/plugins/docsis/packet-bintrngreq.c + M /trunk/plugins/docsis/packet-docsis.h + M /trunk/plugins/docsis/packet-macmgmt.c +From Geoffrey Kimball: +DOCSIS 3.0 includes a new Bonded Initial Ranging Request (B-INIT-RNG-REQ) MAC +Management type (34). A simple dissector is needed to decode this message. ------------------------------------------------------------------------ -r22934 | jmayer | 2007-09-23 23:59:40 -0700 (Sun, 23 Sep 2007) | 3 lines +r29488 | jake | 2009-08-20 22:37:33 -0700 (Thu, 20 Aug 2009) | 2 lines Changed paths: - M /trunk/Makefile.am - M /trunk/Makefile.nmake - M /trunk/acinclude.m4 - M /trunk/asn1/snmp/packet-snmp-template.c - M /trunk/config.nmake - M /trunk/configure.in M /trunk/epan/Makefile.am - M /trunk/epan/Makefile.nmake - M /trunk/epan/dissectors/Makefile.nmake - M /trunk/epan/dissectors/packet-snmp.c - M /trunk/gtk/Makefile.nmake - M /trunk/packaging/nsis/Makefile.nmake - -Get rid of the remains of NET-SNMP in the build process. - - ------------------------------------------------------------------------- -r22935 | jmayer | 2007-09-24 00:00:59 -0700 (Mon, 24 Sep 2007) | 336 lines -Changed paths: - M /trunk/tools/pidl/idl.yp - M /trunk/tools/pidl/lib/Parse/Pidl/IDL.pm - M /trunk/tools/pidl/lib/Parse/Pidl/NDR.pm - M /trunk/tools/pidl/lib/Parse/Pidl/Samba3/ClientNDR.pm - M /trunk/tools/pidl/lib/Parse/Pidl/Samba3/ServerNDR.pm - M /trunk/tools/pidl/lib/Parse/Pidl/Samba4/EJS.pm - M /trunk/tools/pidl/lib/Parse/Pidl/Samba4/Header.pm - M /trunk/tools/pidl/lib/Parse/Pidl/Samba4/NDR/Client.pm - M /trunk/tools/pidl/lib/Parse/Pidl/Samba4/NDR/Parser.pm - M /trunk/tools/pidl/lib/Parse/Pidl/Samba4/NDR/Server.pm - M /trunk/tools/pidl/lib/Parse/Pidl/Samba4/SWIG.pm - M /trunk/tools/pidl/lib/Parse/Pidl/Samba4/TDR.pm - M /trunk/tools/pidl/lib/Parse/Pidl/Samba4/Template.pm - M /trunk/tools/pidl/lib/Parse/Pidl/Samba4.pm - M /trunk/tools/pidl/lib/Parse/Pidl/Typelist.pm - M /trunk/tools/pidl/lib/Parse/Pidl/Util.pm - M /trunk/tools/pidl/pidl - M /trunk/tools/pidl/tests/Util.pm - M /trunk/tools/pidl/tests/header.pl - M /trunk/tools/pidl/tests/ndr.pl - M /trunk/tools/pidl/tests/parse_idl.pl - M /trunk/tools/pidl/tests/samba3-cli.pl - M /trunk/tools/pidl/tests/util.pl - - -Update pidl to current samba tree. This changes the license -of the *tool* to GPLv3. The license of the generated code is -is most likely not affected (see mail on wireshark-dev from Jelmer). - -Update from samba tree revision 23750 to 25198 -============================ Samba log start ============ ------------------------------------------------------------------------- -r23792 | tridge | 2007-07-10 04:07:03 +0200 (Tue, 10 Jul 2007) | 6 lines - -convert Samba4 to GPLv3 - -There are still a few tidyups of old FSF addresses to come (in both s3 -and s4). More commits soon. ------------------------------------------------------------------------- -r24407 | metze | 2007-08-14 13:50:45 +0200 (Tue, 14 Aug 2007) | 6 lines - -$element->{ARRAY_LEN} doesn't exist... - -and a few lines above we use $element->{ORIGINAL}->{ARRAY_LEN} -I assume it was just forgotten in the update. - -metze ------------------------------------------------------------------------- -r24446 | metze | 2007-08-15 08:08:02 +0200 (Wed, 15 Aug 2007) | 4 lines - -We only need one genric GenerateFunctionInEnv -function - -metze ------------------------------------------------------------------------- -r24447 | metze | 2007-08-15 10:55:16 +0200 (Wed, 15 Aug 2007) | 3 lines - -fix samba3-cli pidl tests - -metze ------------------------------------------------------------------------- -r24452 | metze | 2007-08-15 11:18:25 +0200 (Wed, 15 Aug 2007) | 4 lines - -bail out instead of only giving a warning on -incorrect idl files - -metze ------------------------------------------------------------------------- -r24454 | metze | 2007-08-15 12:23:28 +0200 (Wed, 15 Aug 2007) | 3 lines - -when level 0 is a pointer we need to look for an array in level 1... - -metze ------------------------------------------------------------------------- -r24463 | metze | 2007-08-15 16:02:23 +0200 (Wed, 15 Aug 2007) | 4 lines - -we have a function to correctly create an $env object -so don't try it manually and introduce bugs:-) - -metze ------------------------------------------------------------------------- -r24482 | metze | 2007-08-16 12:07:19 +0200 (Thu, 16 Aug 2007) | 3 lines - -white space cleanup only... - -metze ------------------------------------------------------------------------- -r24484 | metze | 2007-08-16 12:54:11 +0200 (Thu, 16 Aug 2007) | 3 lines - -pass down $ndr tree instead of the $pidl tree to Samba4/Header.pm - -metze ------------------------------------------------------------------------- -r24487 | metze | 2007-08-16 15:27:41 +0200 (Thu, 16 Aug 2007) | 3 lines - -fix formating and add defined($opt_header) - -metze ------------------------------------------------------------------------- -r24488 | metze | 2007-08-16 15:29:38 +0200 (Thu, 16 Aug 2007) | 3 lines - -enum's and bitmap's not have nested types - -metze ------------------------------------------------------------------------- -r24489 | metze | 2007-08-16 15:34:54 +0200 (Thu, 16 Aug 2007) | 4 lines - -only typedef enum { ... } foo; enum's should look -for has_properties() of $enum->{PARENT} - -metze ------------------------------------------------------------------------- -r24490 | metze | 2007-08-16 15:39:30 +0200 (Thu, 16 Aug 2007) | 8 lines - -For ParseBitmap() we use Parse::Pidl::Typelist::bitmap_type_fn() -so for ParseEnum() we should also use Parse::Pidl::Typelist::enum_type_fn(). - -Also the base_type() property isn't standard IDL and we should not support it. - -This changes TDR enum to also to default to uint16 (as with NDR enums). - -metze ------------------------------------------------------------------------- -r24492 | metze | 2007-08-16 15:41:48 +0200 (Thu, 16 Aug 2007) | 4 lines - -Parse::Pidl::Samba4::Header::Parse() now takes an $ndr tree -not the $pidl tree anymore. - -metze ------------------------------------------------------------------------- -r24493 | metze | 2007-08-16 16:42:22 +0200 (Thu, 16 Aug 2007) | 11 lines - -- it turns out that - foreach my $e (@{$union->{ELEMENTS}}) { - changes $union->{ELEMENTS} from undef into an empty array. - this removes the difference between - struct foo { }; and struct foo; - So we need to explicit return before. -- we should return the same element for layout for - structs and unions with no elements. -- fix the testsuite to match - -metze ------------------------------------------------------------------------- -r24505 | metze | 2007-08-17 09:06:02 +0200 (Fri, 17 Aug 2007) | 3 lines - -pass down $fn one level - -metze ------------------------------------------------------------------------- -r24506 | metze | 2007-08-17 09:46:34 +0200 (Fri, 17 Aug 2007) | 3 lines - -pass $fn down one more layer - -metze ------------------------------------------------------------------------- -r24507 | metze | 2007-08-17 10:05:57 +0200 (Fri, 17 Aug 2007) | 3 lines - -pass $d down to HeaderTypedef - -metze ------------------------------------------------------------------------- -r24508 | metze | 2007-08-17 10:47:38 +0200 (Fri, 17 Aug 2007) | 3 lines - -add HeaderTypeNew() which will go if everything is converted - -metze ------------------------------------------------------------------------- -r24509 | metze | 2007-08-17 11:01:19 +0200 (Fri, 17 Aug 2007) | 4 lines - -pass down the full ndr elements instead of the old pidl elements -from ->{ORIGINAL} - -metze ------------------------------------------------------------------------- -r24511 | metze | 2007-08-17 11:12:13 +0200 (Fri, 17 Aug 2007) | 3 lines - -pass the correct thing to fatal() - -metze ------------------------------------------------------------------------- -r24514 | metze | 2007-08-17 13:09:46 +0200 (Fri, 17 Aug 2007) | 3 lines - -IS_* elemements sound be perl integers consistantly... - -metze ------------------------------------------------------------------------- -r24515 | metze | 2007-08-17 13:24:25 +0200 (Fri, 17 Aug 2007) | 3 lines - -use fatal() wrapper instead of die() directly - -metze ------------------------------------------------------------------------- -r24516 | metze | 2007-08-17 14:04:41 +0200 (Fri, 17 Aug 2007) | 3 lines - -don't use ->{ORIGINAL} - -metze ------------------------------------------------------------------------- -r24517 | metze | 2007-08-17 14:55:47 +0200 (Fri, 17 Aug 2007) | 4 lines - -move skipping pointer before an array logic into the -pointer loop as we do in other places - -metze ------------------------------------------------------------------------- -r24518 | metze | 2007-08-17 15:01:51 +0200 (Fri, 17 Aug 2007) | 4 lines - -get rid of using ->{ORIGINAL} and move stuff -into subfunctions - -metze ------------------------------------------------------------------------- -r24520 | metze | 2007-08-17 15:08:00 +0200 (Fri, 17 Aug 2007) | 4 lines - -make use of the new ElementStars() and ArrayBrackets() -functions - -metze ------------------------------------------------------------------------- -r24521 | metze | 2007-08-17 15:42:09 +0200 (Fri, 17 Aug 2007) | 3 lines - -we don't yet have optional args to DeclLong() - -metze ------------------------------------------------------------------------- -r24522 | metze | 2007-08-17 15:45:18 +0200 (Fri, 17 Aug 2007) | 3 lines - -make the "skip pointer to an array" logic a bit easier - -metze ------------------------------------------------------------------------- -r24523 | metze | 2007-08-17 15:47:03 +0200 (Fri, 17 Aug 2007) | 4 lines - -we don't support multi-dimentional [out] arrays -for the samba3 server stubs yet, so bail out. - -metze ------------------------------------------------------------------------- -r24524 | metze | 2007-08-17 15:53:12 +0200 (Fri, 17 Aug 2007) | 3 lines - -make use of ElementStars() - -metze ------------------------------------------------------------------------- -r24535 | metze | 2007-08-18 12:30:40 +0200 (Sat, 18 Aug 2007) | 4 lines - -rename struct dcerpc_interface_call -> struct ndr_interface_call -and move it to librpc/ndr/libndr.h - -metze ------------------------------------------------------------------------- -r24540 | metze | 2007-08-18 14:25:37 +0200 (Sat, 18 Aug 2007) | 4 lines - -rename struct dcerpc_endpoint_list/struct dcerpc_authservice_list -into ndr_interface_string_array and move it to libndr.h - -metze ------------------------------------------------------------------------- -r24551 | metze | 2007-08-19 22:46:45 +0200 (Sun, 19 Aug 2007) | 6 lines - -rename dcerpc_interface_table -> ndr_interface_table -rename dcerpc_interface_list -> ndr_interface_list - -and move them to libndr.h - -metze ------------------------------------------------------------------------- -r24557 | metze | 2007-08-19 23:23:03 +0200 (Sun, 19 Aug 2007) | 3 lines - -rename 'dcerpc_table_' -> 'ndr_table_' - -metze ------------------------------------------------------------------------- -r24560 | metze | 2007-08-20 00:09:21 +0200 (Mon, 20 Aug 2007) | 3 lines - -rename some DCERPC_ prefixes into NDR_ - -metze ------------------------------------------------------------------------- -r24563 | metze | 2007-08-20 00:23:17 +0200 (Mon, 20 Aug 2007) | 3 lines - -remove unused DCERPC specific stuff from the generated NDR code - -metze ------------------------------------------------------------------------- -r24592 | metze | 2007-08-21 14:19:56 +0200 (Tue, 21 Aug 2007) | 4 lines - -pass down the ndr_interface_table in the samba3 client bindings -instead of the pull and push functions - -metze ------------------------------------------------------------------------- -r24596 | metze | 2007-08-21 16:06:33 +0200 (Tue, 21 Aug 2007) | 7 lines - -- talloc request structure for the samba3 server bindings - and make that the primary context for the request - which the implementations can also use. -- go via functions pointers in the ndr_interface_table - instead of calling functions directly. - -metze ------------------------------------------------------------------------- -r24717 | jelmer | 2007-08-27 20:43:18 +0200 (Mon, 27 Aug 2007) | 2 lines - D /branches/SAMBA_4_0/BRANCH.TODO - -Some more easy bool conversions, update TODO for registry - ------------------------------------------------------------------------- -r24721 | jelmer | 2007-08-27 21:47:23 +0200 (Mon, 27 Aug 2007) | 1 line - -Avoid True and False because they are only available within Samba. ------------------------------------------------------------------------- -r24812 | jelmer | 2007-08-31 00:25:59 +0200 (Fri, 31 Aug 2007) | 1 line - -Fix headers for external users. ------------------------------------------------------------------------- -r24815 | jelmer | 2007-08-31 02:03:54 +0200 (Fri, 31 Aug 2007) | 1 line - -Support cpp_quote(). ------------------------------------------------------------------------- -r24816 | jelmer | 2007-08-31 02:31:32 +0200 (Fri, 31 Aug 2007) | 4 lines - D /branches/SAMBA_4_0/source/include/core.h - -Move the rest of the contents of core.h to more appropriate places. -include/ now only contains build system related headers, all other headers are -now near the source code they're related to. - ------------------------------------------------------------------------- -r24983 | metze | 2007-09-06 15:48:01 +0200 (Thu, 06 Sep 2007) | 4 lines - -setup the correct talloc name for structures used in the generated -server stubs - -metze ------------------------------------------------------------------------- -r25114 | metze | 2007-09-12 14:31:19 +0200 (Wed, 12 Sep 2007) | 7 lines -handle structs and unions without typedefs better -in can_contain_deffered() +List the new DOCSIS dissector file here as well. -jelmer: we need to handle this more genericly, I assume - we have a lot of other related bugs - -metze ------------------------------------------------------------------------- -r25166 | jelmer | 2007-09-14 20:06:51 +0200 (Fri, 14 Sep 2007) | 1 line - -Simplify can_contain_deferred and add tests for it. ------------------------------------------------------------------------ -r25168 | jelmer | 2007-09-14 20:26:23 +0200 (Fri, 14 Sep 2007) | 1 line - -Fix include for gen_ndr/misc.h. Patch by Julien Kerihuel. ------------------------------------------------------------------------- -r25185 | jelmer | 2007-09-16 01:03:34 +0200 (Sun, 16 Sep 2007) | 1 line - -Check that can_contain_deferred returns true if one of the members of a type can contain deferred data. ------------------------------------------------------------------------- -============================ Samba log end ============== - ------------------------------------------------------------------------- -r22936 | kukosa | 2007-09-24 04:01:53 -0700 (Mon, 24 Sep 2007) | 2 lines +r29489 | etxrab | 2009-08-21 03:12:47 -0700 (Fri, 21 Aug 2009) | 3 lines Changed paths: - M /trunk/asn1/h225/h225.cnf - M /trunk/asn1/h450/Makefile - M /trunk/asn1/h450/Makefile.nmake - M /trunk/asn1/h450/h450-ros-exp.cnf - M /trunk/asn1/h450/h450-ros.cnf - M /trunk/asn1/q932/Makefile - M /trunk/asn1/q932/Makefile.nmake - M /trunk/asn1/q932/packet-q932-ros-template.c - M /trunk/asn1/q932/q932-ros.cnf - A /trunk/asn1/ros/ros-err.cnf - A /trunk/asn1/ros/ros-inv.cnf - A /trunk/asn1/ros/ros-rej.cnf - A /trunk/asn1/ros/ros-res.cnf - M /trunk/epan/asn1.h - M /trunk/epan/dissectors/packet-h225.c - M /trunk/epan/dissectors/packet-h450-ros.c - M /trunk/epan/dissectors/packet-h450-ros.h - M /trunk/epan/dissectors/packet-h450.c - M /trunk/epan/dissectors/packet-q932-ros.c + M /trunk/epan/column-utils.c M /trunk/epan/libwireshark.def + M /trunk/file.c + M /trunk/gtk/new_packet_list.c + M /trunk/gtk/packet_list_store.c + M /trunk/gtk/packet_list_store.h -improvements in ROS handling in Q.932 and H.450 -move common ROS code into ros/ros-*.cnf files +Use col_text in frame data. +- colum-utils needs more work, based on + Didier Gautherons optimizations patch http://wiki.wireshark.org/Development/Optimization ------------------------------------------------------------------------ -r22937 | kukosa | 2007-09-24 05:46:02 -0700 (Mon, 24 Sep 2007) | 1 line +r29490 | krj | 2009-08-21 04:03:30 -0700 (Fri, 21 Aug 2009) | 1 line Changed paths: - M /trunk/config.h.win32 + M /trunk/epan/dissectors/packet-iax2.c + M /trunk/epan/proto.c + M /trunk/epan/proto.h + M /trunk/file.c + M /trunk/gtk/expert_comp_table.c + M /trunk/gtk/main_proto_draw.c + M /trunk/gtk/rtp_analysis.c + M /trunk/plugins/wimax/packet-wmx.c + M /trunk/print.c + M /trunk/proto_hier_stats.c -remove forgotten @HAVE_NET_SNMP@ +Also fake empty field_info's by gracefully handling NULL field_info pointer elsewhere. ------------------------------------------------------------------------ -r22938 | jmayer | 2007-09-24 06:49:25 -0700 (Mon, 24 Sep 2007) | 6 lines +r29491 | krj | 2009-08-21 04:31:21 -0700 (Fri, 21 Aug 2009) | 1 line Changed paths: - M /trunk/tools/asn2wrs.py - -Add command line switch - -D dir : Directory for input_file(s) (default: '.') -to allow asn2wrs being used in out of tree builds. - -Beautify -h output a bit. + M /trunk/epan/dfilter/dfilter.c +Handle a text NULL pointer more gracefully ------------------------------------------------------------------------ -r22939 | jmayer | 2007-09-24 09:05:51 -0700 (Mon, 24 Sep 2007) | 17 lines +r29492 | wmeier | 2009-08-21 07:36:27 -0700 (Fri, 21 Aug 2009) | 2 lines Changed paths: - M /trunk/tools/pidl/lib/Parse/Pidl/Samba4/Header.pm - M /trunk/tools/pidl/lib/Parse/Pidl/Samba4/NDR/Parser.pm - -Update from samba tree revision 25198 to 25306 -============================ Samba log start ============ ------------------------------------------------------------------------- -r25301 | jelmer | 2007-09-23 23:35:03 +0200 (Sun, 23 Sep 2007) | 1 line - A /branches/SAMBA_4_0/source/libcli/raw/clierror.c (from /branches/SAMBA_4_0/source/libcli/util/clierror.c:25300) - D /branches/SAMBA_4_0/source/libcli/util/clierror.c - D /branches/SAMBA_4_0/source/libcli/util/nt_status.h - D /branches/SAMBA_4_0/source/libcli/util/nterr.h - A /branches/SAMBA_4_0/source/libcli/util/ntstatus.h (from /branches/SAMBA_4_0/source/libcli/util/nterr.h:25300) - A /branches/SAMBA_4_0/source/libcli/util/werror.h (from /branches/SAMBA_4_0/source/libcli/util/nt_status.h:25300) - -Merge my includes.h cleanups. ------------------------------------------------------------------------- ------------------------------------------------------------------------- -============================ Samba log end ============== + M /trunk/plugins/asn1/asn1.c + M /trunk/plugins/asn1/packet-asn1.c + M /trunk/plugins/docsis/packet-bintrngreq.c + M /trunk/plugins/docsis/packet-bpkmattr.c + M /trunk/plugins/docsis/packet-bpkmreq.c + M /trunk/plugins/docsis/packet-bpkmrsp.c + M /trunk/plugins/docsis/packet-dccack.c + M /trunk/plugins/docsis/packet-dccreq.c + M /trunk/plugins/docsis/packet-dccrsp.c + M /trunk/plugins/docsis/packet-dcd.c + M /trunk/plugins/docsis/packet-docsis.c + M /trunk/plugins/docsis/packet-dsaack.c + M /trunk/plugins/docsis/packet-dsareq.c + M /trunk/plugins/docsis/packet-dsarsp.c + M /trunk/plugins/docsis/packet-dscack.c + M /trunk/plugins/docsis/packet-dscreq.c + M /trunk/plugins/docsis/packet-dscrsp.c + M /trunk/plugins/docsis/packet-dsdreq.c + M /trunk/plugins/docsis/packet-dsdrsp.c + M /trunk/plugins/docsis/packet-intrngreq.c + M /trunk/plugins/docsis/packet-macmgmt.c + M /trunk/plugins/docsis/packet-map.c + M /trunk/plugins/docsis/packet-mdd.c + M /trunk/plugins/docsis/packet-regack.c + M /trunk/plugins/docsis/packet-regreq.c + M /trunk/plugins/docsis/packet-regreqmp.c + M /trunk/plugins/docsis/packet-regrsp.c + M /trunk/plugins/docsis/packet-regrspmp.c + M /trunk/plugins/docsis/packet-rngreq.c + M /trunk/plugins/docsis/packet-rngrsp.c + M /trunk/plugins/docsis/packet-sync.c + M /trunk/plugins/docsis/packet-tlv.c + M /trunk/plugins/docsis/packet-type29ucd.c + M /trunk/plugins/docsis/packet-uccreq.c + M /trunk/plugins/docsis/packet-uccrsp.c + M /trunk/plugins/docsis/packet-ucd.c + M /trunk/plugins/docsis/packet-vendor.c + M /trunk/plugins/ethercat/packet-ams.c + M /trunk/plugins/ethercat/packet-ecatmb.c + M /trunk/plugins/ethercat/packet-ethercat-datagram.c + M /trunk/plugins/ethercat/packet-ethercat-frame.c + M /trunk/plugins/ethercat/packet-ioraw.c + M /trunk/plugins/ethercat/packet-nv.c + M /trunk/plugins/gryphon/packet-gryphon.c + M /trunk/plugins/irda/packet-ircomm.c + M /trunk/plugins/irda/packet-irda.c + M /trunk/plugins/wimaxasncp/packet-wimaxasncp.c +(Minor) Remove unneeded #includes. ------------------------------------------------------------------------ -r22940 | stig | 2007-09-24 12:56:17 -0700 (Mon, 24 Sep 2007) | 3 lines +r29493 | martinm | 2009-08-21 08:16:27 -0700 (Fri, 21 Aug 2009) | 3 lines Changed paths: - M /trunk/plugins/unistim/packet-unistim.c - M /trunk/plugins/unistim/uftp.h + M /trunk/epan/proto.c -From Don Newton: -added null termination to uftp and cleaned comments in packet-unistim.c +Don't try TRY_TO_FAKE_THIS_ITEM in proto_tree_add_bits_ret_val(), as otherwise +the side effect 'return_value' getting set doesn't happen. ------------------------------------------------------------------------ -r22941 | etxrab | 2007-09-24 14:26:31 -0700 (Mon, 24 Sep 2007) | 1 line +r29494 | krj | 2009-08-21 10:11:02 -0700 (Fri, 21 Aug 2009) | 4 lines Changed paths: - M /trunk/epan/dissectors/packet-gsm_a.c - M /trunk/epan/dissectors/packet-gsm_a.h - M /trunk/epan/dissectors/packet-rsl.c + M /trunk/epan/proto.c -More IE:s ------------------------------------------------------------------------- -r22942 | wmeier | 2007-09-24 14:34:58 -0700 (Mon, 24 Sep 2007) | 2 lines -Changed paths: - M /trunk/gtk/color_edit_dlg.c +Delay TRY_TO_FAKE_THIS_ITEM() in proto_tree_add_bits_ret_val() until we know it is safe. -Fix bug #1457: Undersized array causing "smashed stack". +Thanks to Martin for pointing this out in r29493. ------------------------------------------------------------------------ -r22943 | etxrab | 2007-09-24 14:51:41 -0700 (Mon, 24 Sep 2007) | 1 line +r29495 | jake | 2009-08-21 11:54:28 -0700 (Fri, 21 Aug 2009) | 1 line Changed paths: - M /trunk/epan/dissectors/packet-rsl.c + M /trunk/plugins/docsis/Makefile.common + D /trunk/plugins/docsis/packet-docsis.h -Fix warnings. +Remove unneeded #includes. ------------------------------------------------------------------------ -r22944 | sahlberg | 2007-09-24 20:38:28 -0700 (Mon, 24 Sep 2007) | 3 lines +r29496 | jake | 2009-08-21 11:56:15 -0700 (Fri, 21 Aug 2009) | 1 line Changed paths: - M /trunk/epan/dissectors/packet-ctdb.c - -add more control names - + M /trunk/plugins/docsis/packet-docsis.c +Remove unneeded #includes. ------------------------------------------------------------------------ -r22945 | sahlberg | 2007-09-24 21:15:30 -0700 (Mon, 24 Sep 2007) | 4 lines +r29497 | krj | 2009-08-21 12:48:11 -0700 (Fri, 21 Aug 2009) | 1 line Changed paths: - M /trunk/asn1/ldap/ldap.cnf - M /trunk/epan/dissectors/packet-ldap.c - -add support for yet another random combination of authentication -wrappers that can be used when connecting with sasl - + M /trunk/epan/dissectors/packet-miop.c + M /trunk/epan/dissectors/packet-ziop.c +Remove unneeded #includes ------------------------------------------------------------------------ -r22946 | gerald | 2007-09-24 22:12:44 -0700 (Mon, 24 Sep 2007) | 10 lines +r29498 | tuexen | 2009-08-21 13:10:51 -0700 (Fri, 21 Aug 2009) | 3 lines Changed paths: - M /trunk/gtk/color_dlg.c - M /trunk/gtk/color_edit_dlg.c - -In newer versions of GTK+ 2.x, if you have the mouse positioned above a -button that goes from insensitive to sensitive, the button won't respond -to mouse clicks. - -This caused the Coloring Rules dialog behavior reported in bug 699. Work -around it by not making the up/down buttons insensitive while we're moving -a rule. + M /trunk/gtk/sctp_graph_dlg.c + M /trunk/gtk/sctp_stat.c -Fixup whitespace. +From Irene Ruengeler: Fix two bugs regarding plotted TSNs reported by +Christian Constantin. ------------------------------------------------------------------------ -r22947 | sake | 2007-09-24 22:42:22 -0700 (Mon, 24 Sep 2007) | 3 lines +r29499 | krj | 2009-08-21 13:25:24 -0700 (Fri, 21 Aug 2009) | 1 line Changed paths: - M /trunk/wiretap/netscreen.c - -Allow the output of NetScreen VSI interfaces to be parsed. - + M /trunk/epan/dissectors/ncp2222.py + M /trunk/epan/dissectors/packet-amr.c + M /trunk/epan/dissectors/packet-ansi_637.c + M /trunk/epan/dissectors/packet-ansi_683.c + M /trunk/epan/dissectors/packet-ansi_801.c + M /trunk/epan/dissectors/packet-ansi_tcap.c + M /trunk/epan/dissectors/packet-atm.c + M /trunk/epan/dissectors/packet-camel.c + M /trunk/epan/dissectors/packet-dcerpc-dce122.c + M /trunk/epan/dissectors/packet-dcom.c + M /trunk/epan/dissectors/packet-diameter.c + M /trunk/epan/dissectors/packet-e164.h + M /trunk/epan/dissectors/packet-e212.h + M /trunk/epan/dissectors/packet-erf.c + M /trunk/epan/dissectors/packet-gprs-llc.c + M /trunk/epan/dissectors/packet-gsm_map.c + M /trunk/epan/dissectors/packet-gsm_sms.c + M /trunk/epan/dissectors/packet-gssapi.c + M /trunk/epan/dissectors/packet-h225.c + M /trunk/epan/dissectors/packet-h245.c + M /trunk/epan/dissectors/packet-h248.c + M /trunk/epan/dissectors/packet-h261.c + M /trunk/epan/dissectors/packet-h263p.c + M /trunk/epan/dissectors/packet-h264.c + M /trunk/epan/dissectors/packet-hip.c + M /trunk/epan/dissectors/packet-inap.c + M /trunk/epan/dissectors/packet-iscsi.c + M /trunk/epan/dissectors/packet-isis-hello.c + M /trunk/epan/dissectors/packet-isis-lsp.c + M /trunk/epan/dissectors/packet-itdm.c + M /trunk/epan/dissectors/packet-lge_monitor.c + M /trunk/epan/dissectors/packet-m3ua.c + M /trunk/epan/dissectors/packet-mp4ves.c + M /trunk/epan/dissectors/packet-msrp.c + M /trunk/epan/dissectors/packet-mtp2.c + M /trunk/epan/dissectors/packet-nt-sonmp.c + M /trunk/epan/dissectors/packet-portmap.c + M /trunk/epan/dissectors/packet-sccp.c + M /trunk/epan/dissectors/packet-sdp.c + M /trunk/epan/dissectors/packet-sigcomp.c + M /trunk/epan/dissectors/packet-smb-sidsnooping.c + M /trunk/epan/dissectors/packet-snmp.c + M /trunk/epan/dissectors/packet-tcap.c + M /trunk/epan/dissectors/packet-tcp.h + M /trunk/epan/dissectors/packet-turbocell.c + M /trunk/epan/dissectors/packet-uma.c + M /trunk/epan/dissectors/packet-zep.c +Sanitize epan includes ------------------------------------------------------------------------ -r22948 | sahlberg | 2007-09-25 00:47:00 -0700 (Tue, 25 Sep 2007) | 11 lines +r29500 | krj | 2009-08-21 13:32:50 -0700 (Fri, 21 Aug 2009) | 1 line Changed paths: - M /trunk/asn1/ldap/packet-ldap-template.c - M /trunk/epan/dissectors/packet-ldap.c - -not all SASL protected blobs use a GSS wrapper for the payload so we -cant check that the payload starts with BER tag 0x60 and an oid. -instead check that the length byte (first 4 bytes) look sane and if -SASL authentication has been negotiated on the connection - -also, sometimes clients will mix both non-SASL and SASL protected LDAP -traffic on the same tcp connection by initially performing simple -unauthenticated searches on the database before performing the Bind. - - + M /trunk/asn1/ansi-tcap/packet-ansi_tcap-template.c + M /trunk/asn1/camel/packet-camel-template.c + M /trunk/asn1/gsmmap/packet-gsmmap-template.c + M /trunk/asn1/h225/packet-h225-template.c + M /trunk/asn1/h245/packet-h245-template.c + M /trunk/asn1/h248/packet-h248-template.c + M /trunk/asn1/inap/packet-inap-template.c + M /trunk/asn1/snmp/packet-snmp-template.c + M /trunk/asn1/tcap/packet-tcap-template.c +Sanitize epan includes ------------------------------------------------------------------------ -r22949 | sahlberg | 2007-09-25 01:05:17 -0700 (Tue, 25 Sep 2007) | 7 lines +r29501 | krj | 2009-08-21 13:40:49 -0700 (Fri, 21 Aug 2009) | 1 line Changed paths: - M /trunk/asn1/ldap/ldap.cnf - M /trunk/epan/dissectors/packet-ldap.c - -only set ldap_info->first_auth_frame to 0 first time we see the -authentication packet or else we will get inconsistent dissection when -clicking on packets. -(inconsistent as in : a certain packet might/might not be dissected as -LDAP/SASL depending on which packets we clicked on previously) - + M /trunk/asn1/pkcs12/packet-pkcs12-template.c + M /trunk/epan/dissectors/packet-pkcs12.c + M /trunk/packaging/u3/tools/sysdep.h +Use <gcrypt.h> instead of 'gcrypt.h' ------------------------------------------------------------------------ -r22950 | jmayer | 2007-09-25 03:30:55 -0700 (Tue, 25 Sep 2007) | 6 lines +r29502 | krj | 2009-08-21 13:51:13 -0700 (Fri, 21 Aug 2009) | 1 line Changed paths: - M /trunk/asn1/Makefile.am - A /trunk/asn1/Makefile.inc - A /trunk/asn1/Makefile.inc.nmake - M /trunk/asn1/Makefile.nmake - M /trunk/asn1/camel - D /trunk/asn1/camel/Makefile - A /trunk/asn1/camel/Makefile.am - A /trunk/asn1/camel/Makefile.common - M /trunk/asn1/camel/Makefile.nmake - -- Rework the Makefile structure to generate external -cnf files - a protocol depends on. -- Make sure we need to add asn files to only 1 Makefile instead - of 3 (Makefile, Makefile.nmake, ../Makefile.am) -- Change the Makefiles of the camel protocol to use the new structure. + M /trunk/epan/base64.h + M /trunk/epan/camel-persistentdata.c + M /trunk/epan/codecs.h + M /trunk/epan/rtp_pt.h + M /trunk/epan/t35.h + M /trunk/epan/tap.c + M /trunk/epan/tap.h + M /trunk/epan/tcap-persistentdata.c + M /trunk/epan/tcap-persistentdata.h + M /trunk/epan/to_str.h +Sanitize epan includes ------------------------------------------------------------------------ -r22951 | kukosa | 2007-09-25 04:58:35 -0700 (Tue, 25 Sep 2007) | 1 line +r29503 | krj | 2009-08-21 16:02:59 -0700 (Fri, 21 Aug 2009) | 1 line Changed paths: - M /trunk/asn1/Makefile.am - M /trunk/asn1/Makefile.inc.nmake - M /trunk/asn1/camel/Makefile.common - A /trunk/asn1/h245/Makefile.am - A /trunk/asn1/h245/Makefile.common - M /trunk/asn1/h245/Makefile.nmake - A /trunk/asn1/nbap/Makefile.am - A /trunk/asn1/nbap/Makefile.common - M /trunk/asn1/nbap/Makefile.nmake - A /trunk/asn1/ranap/Makefile.am - A /trunk/asn1/ranap/Makefile.common - M /trunk/asn1/ranap/Makefile.nmake - A /trunk/asn1/rnsap/Makefile.am - A /trunk/asn1/rnsap/Makefile.common - M /trunk/asn1/rnsap/Makefile.nmake - A /trunk/asn1/sabp/Makefile.am - A /trunk/asn1/sabp/Makefile.common - M /trunk/asn1/sabp/Makefile.nmake - M /trunk/epan/dissectors/packet-nbap.c - M /trunk/epan/dissectors/packet-rnsap.c + M /trunk/epan/proto.c -put few simple ASN.1 dissectors into the new makefile structure +Don't dereference pointer before checking for NULL ------------------------------------------------------------------------ -r22952 | kukosa | 2007-09-25 05:17:48 -0700 (Tue, 25 Sep 2007) | 1 line +r29504 | etxrab | 2009-08-22 09:17:42 -0700 (Sat, 22 Aug 2009) | 2 lines Changed paths: - M /trunk/asn1/Makefile.am + M /trunk/gtk/expert_comp_table.c + M /trunk/gtk/expert_dlg.c -remove trailing backslash on the last line of list +expert_comp_table.c: Minor cleanup +expert_dlg.c change GtkOptionMenu to GtkComboBox. ------------------------------------------------------------------------ -r22953 | jmayer | 2007-09-25 07:07:53 -0700 (Tue, 25 Sep 2007) | 4 lines +r29505 | wmeier | 2009-08-22 10:12:33 -0700 (Sat, 22 Aug 2009) | 4 lines Changed paths: - M /trunk/configure.in - -I forgot to commit the necessary change to configure.in, -so the distcheck failed. Fix that. + M /trunk/epan/crc32.c +Additional validation of 'len' for crc32_ccitt_tvb... fcns; +(-1 is not a valid length); +First of 2 fixes for crash reported in Bug #3925. ------------------------------------------------------------------------ -r22954 | jmayer | 2007-09-25 07:09:08 -0700 (Tue, 25 Sep 2007) | 1 line +r29506 | jake | 2009-08-22 10:28:54 -0700 (Sat, 22 Aug 2009) | 4 lines Changed paths: - M /trunk/manuf - M /trunk/wka.tmpl + M /trunk/epan/dissectors/packet-dns.c -Small change about extreme EAPSv2 address and update manuf +From Ivan Sy: +NSEC3PARAM RR (RFC 5155), APL RR (RFC 3123), PX RR (RFC 2163), GPOS RR (RFC 1712), +NSAP RR (RFC 1706), NSAP-PTR RR (RFC 1348), AFSDB, RP, X25, ISDN, RT, RR (RFC 1183). +Also cleanup of protocol tree dependancies. ------------------------------------------------------------------------ -r22955 | etxrab | 2007-09-25 09:09:58 -0700 (Tue, 25 Sep 2007) | 1 line +r29507 | krj | 2009-08-22 12:29:44 -0700 (Sat, 22 Aug 2009) | 1 line Changed paths: - M /trunk/Makefile.nmake - M /trunk/config.nmake - M /trunk/packaging/nsis/Makefile.nmake - M /trunk/packaging/nsis/wireshark.nsi - M /trunk/tools/win32-setup.sh + M /trunk/epan/column-utils.c -Use GTK+ 2.12 +We initialize col_expr and col_expr_val in col_init() so there's no need to initialize them again in col_set_xxx() ------------------------------------------------------------------------ -r22956 | etxrab | 2007-09-25 09:51:49 -0700 (Tue, 25 Sep 2007) | 3 lines +r29508 | krj | 2009-08-22 12:53:54 -0700 (Sat, 22 Aug 2009) | 1 line Changed paths: - M /trunk/asn1/ldap/packet-ldap-template.c - M /trunk/epan/dissectors/packet-ldap.c - -Fix: -packet-ldap-template.c(1330) : error C2220: warning treated as error - no object file generated -packet-ldap-template.c(1330) : warning C4101: 'gss_len' : unreferenced local var iable NMAKE : fatal error U1077: 'cl' : ------------------------------------------------------------------------- -r22957 | jmayer | 2007-09-25 10:09:01 -0700 (Tue, 25 Sep 2007) | 4 lines -Changed paths: - M /trunk/asn1/Makefile.am - M /trunk/asn1/acp133 - D /trunk/asn1/acp133/Makefile - A /trunk/asn1/acp133/Makefile.am - A /trunk/asn1/acp133/Makefile.common - M /trunk/asn1/acp133/Makefile.nmake - M /trunk/asn1/camel - M /trunk/asn1/h245 - D /trunk/asn1/h245/Makefile - M /trunk/asn1/nbap - D /trunk/asn1/nbap/Makefile - M /trunk/asn1/ranap - D /trunk/asn1/ranap/Makefile - M /trunk/asn1/rnsap - D /trunk/asn1/rnsap/Makefile - M /trunk/asn1/sabp - D /trunk/asn1/sabp/Makefile - M /trunk/configure.in - -Convert acp133 to new build structure. - -Update some svn:ignore files, remove no longer needed Makefiles + M /trunk/epan/dissectors/packet-tcp.c +Remove col_check() guard wrt. COL_REL_CONV_TIME/COL_DELTA_CONV_TIME ------------------------------------------------------------------------ -r22958 | jmayer | 2007-09-25 11:02:49 -0700 (Tue, 25 Sep 2007) | 2 lines +r29509 | rbalint | 2009-08-22 15:46:41 -0700 (Sat, 22 Aug 2009) | 3 lines Changed paths: - M /trunk/asn1/Makefile.am - M /trunk/asn1/Makefile.inc - M /trunk/asn1/Makefile.inc.nmake - M /trunk/asn1/acp133 - M /trunk/asn1/acp133/Makefile.common - M /trunk/asn1/acse - D /trunk/asn1/acse/Makefile - A /trunk/asn1/acse/Makefile.am - A /trunk/asn1/acse/Makefile.common - M /trunk/asn1/acse/Makefile.nmake - M /trunk/asn1/acse/acse-exp.cnf - M /trunk/asn1/ansi_map - D /trunk/asn1/ansi_map/Makefile - A /trunk/asn1/ansi_map/Makefile.am - A /trunk/asn1/ansi_map/Makefile.common - M /trunk/asn1/ansi_map/Makefile.nmake - M /trunk/asn1/camel - M /trunk/asn1/cdt - D /trunk/asn1/cdt/Makefile - A /trunk/asn1/cdt/Makefile.am - A /trunk/asn1/cdt/Makefile.common - M /trunk/asn1/cdt/Makefile.nmake - M /trunk/asn1/cdt/cdt-exp.cnf - M /trunk/asn1/cmip - D /trunk/asn1/cmip/Makefile - A /trunk/asn1/cmip/Makefile.am - A /trunk/asn1/cmip/Makefile.common - M /trunk/asn1/cmip/Makefile.nmake - M /trunk/asn1/cmip/cmip-exp.cnf - M /trunk/asn1/cms - D /trunk/asn1/cms/Makefile - A /trunk/asn1/cms/Makefile.am - A /trunk/asn1/cms/Makefile.common - M /trunk/asn1/cms/Makefile.nmake - M /trunk/asn1/cms/cms-exp.cnf - M /trunk/configure.in - -Change some additional protocols to the new build system + M /trunk/epan/dissectors/packet-giop.c ------------------------------------------------------------------------- -r22959 | ulfl | 2007-09-25 12:22:31 -0700 (Tue, 25 Sep 2007) | 1 line -Changed paths: - M /trunk/all.vcproj +From Frederic Peters (made endian-aware by me): +fixed segfault with some GIOP packets -also do a distclean when doing a clean for the all target ------------------------------------------------------------------------ -r22960 | stig | 2007-09-25 12:30:26 -0700 (Tue, 25 Sep 2007) | 2 lines +r29510 | rbalint | 2009-08-22 15:49:59 -0700 (Sat, 22 Aug 2009) | 6 lines Changed paths: - M /trunk/epan/dissectors/packet-eth.c + M /trunk/dumpcap.c -Highlight whole ethernet trailer in Packet Details View. +From Rob Leslie <rob@mars.org>: +[PATCH] Fix dumpcap believing error on ^C i.e. pcap_breakloop() +When ^C was pressed during a packet capture, dumpcap believed a pcap +error had occurred. We check the return value more closely to avoid +this problem. ------------------------------------------------------------------------ -r22961 | jake | 2007-09-25 12:42:46 -0700 (Tue, 25 Sep 2007) | 19 lines +r29511 | krj | 2009-08-22 22:20:30 -0700 (Sat, 22 Aug 2009) | 1 line Changed paths: - M /trunk/epan/dissectors/packet-dcp.c - -From Gerrit Renker: -This is an update for the DCCP dissector and has previously been sent to -the DCCP dissector maintainer, Francesco Fondelli, who supplied -the Acked-by. I have been using it with profit for several weeks. + M /trunk/epan/dissectors/packet-giop.c -This patch provides the following extensions: - * type-dependent decoding of feature-negotiation options (NN and SP types of -options, NN is a 1..6 byte value in network-byte-order, SP is always a list of -unsigned char) - * decoding for CCID3 Send Loss Event Rate feature - * some pretty-printing of options - * decoding of CCID3-specific options - - Loss Event Rate (receiver report) - - Receive Rate (also reported by receiver) - * there was a change in the spec - the NDP count at sometime `grew' from 3 to -6 bytes (it was the same in the kernel). I have updated the data type from uint32 to -uint64 - * utility function to decode from network-byte-order into host byte order with -variable length +Avoid 'cast to pointer from integer of different size' ------------------------------------------------------------------------ -r22962 | gerald | 2007-09-25 12:52:19 -0700 (Tue, 25 Sep 2007) | 2 lines +r29512 | jmayer | 2009-08-22 23:57:16 -0700 (Sat, 22 Aug 2009) | 4 lines Changed paths: - M /trunk/capinfos.c - -Add the file encapsulation. + M /trunk/epan/dissectors/Makefile.common + M /trunk/epan/dissectors/packet-fmp_notify.c + D /trunk/epan/dissectors/packet-fmp_notify.h + M /trunk/epan/dissectors/packet-scsi-mmc.h + M /trunk/epan/oids.h + M /trunk/gtk/airpcap_dlg.h ------------------------------------------------------------------------- -r22963 | ulfl | 2007-09-25 12:52:51 -0700 (Tue, 25 Sep 2007) | 1 line -Changed paths: - M /trunk/asn1/Makefile.inc.nmake +Get rid of a bunch of "warning: redundant redeclaration of" messages. +In that process, include the contents of packet-fmp_notify.h directly +in packet-fmp_notify.c - it wasn't used anywhere else. -fix a typo in the source files target, took me more than an hour to find it :-((( ------------------------------------------------------------------------ -r22964 | wmeier | 2007-09-25 12:59:50 -0700 (Tue, 25 Sep 2007) | 2 lines +r29513 | krj | 2009-08-23 02:07:54 -0700 (Sun, 23 Aug 2009) | 4 lines Changed paths: - M /trunk/wiretap/catapult_dct2000.c - -Add error checking for fwrites; replacement for one of patches provided in bug #1864 + M /trunk/epan/column-utils.c + M /trunk/epan/column.c + M /trunk/epan/column_info.h + M /trunk/epan/dissectors/packet-vlan.c + M /trunk/gtk/new_packet_list.c ------------------------------------------------------------------------- -r22965 | wmeier | 2007-09-25 13:34:06 -0700 (Tue, 25 Sep 2007) | 2 lines -Changed paths: - M /trunk/wiretap/catapult_dct2000.c +Custom columfication: -Fix whitespace of newly added lines to match rest of file +* Deprecate COL_COS_VALUE (L2 COS Value (802.1p)). Use vlan.priority ------------------------------------------------------------------------ -r22966 | sake | 2007-09-25 13:37:13 -0700 (Tue, 25 Sep 2007) | 13 lines +r29514 | krj | 2009-08-23 02:16:58 -0700 (Sun, 23 Aug 2009) | 8 lines Changed paths: - M /trunk/epan/dissectors/packet-tcp.c - M /trunk/epan/dissectors/packet-tcp.h - -This patch adds two new fields to the tcp-dissector: - -tcp.time_relative ==> the time that has elapsed since the - first packet that was seen in the current TCP stream + M /trunk/epan/prefs.c -tcp.time_delta ==> the time that has elapsed since the - last packet that was seen in the current TCP stream +Add initial code to handle the migration to custom columns by mapping the deprecated columns into their custom column counterparts when we read the preference file. -Calculating these timestamps is turned off by default to not -use the extra memory that is needed for the per-packet-data. -It can be turned on through the TCP protocol preferences +There are still many todos in this area: +1) We need to either warn the user that he/she needs to click "Save" in the preference dialog so we can "flush" the old predefined column or apply this change ourself silently. +2) The predefined columns need to be removed from the "Columns" UI. +3) .... ------------------------------------------------------------------------ -r22967 | gerald | 2007-09-25 14:35:20 -0700 (Tue, 25 Sep 2007) | 2 lines +r29515 | krj | 2009-08-23 02:52:57 -0700 (Sun, 23 Aug 2009) | 4 lines Changed paths: - M /trunk/docbook/release-notes.xml + M /trunk/epan/column-utils.c + M /trunk/epan/dissectors/packet-iax2.c + M /trunk/epan/prefs.c + M /trunk/epan/wslua/wslua_pinfo.c + M /trunk/gtk/new_packet_list.c -Add an item about the coloring rules crash fix. +Custom columfication: ------------------------------------------------------------------------- -r22968 | ulfl | 2007-09-25 14:38:54 -0700 (Tue, 25 Sep 2007) | 1 line -Changed paths: - M /trunk/doc/tshark.pod +* Deprecate COL_CIRCUIT_ID (Circuit ID). Use iax2.call -clarify tshark -B (file format) option ------------------------------------------------------------------------ -r22969 | ulfl | 2007-09-25 14:55:06 -0700 (Tue, 25 Sep 2007) | 11 lines +r29516 | krj | 2009-08-23 03:20:42 -0700 (Sun, 23 Aug 2009) | 4 lines Changed paths: - M /trunk/Makefile.common - M /trunk/capture.c - M /trunk/capture_opts.c - M /trunk/tshark.c - M /trunk/tshark.vcproj - -as "advertised" some days ago: -rewrite the tshark capture code almost completely, to use dumpcap instead of it's own pcap functionality. + M /trunk/epan/column-utils.c + M /trunk/epan/column.c + M /trunk/epan/column_info.h + M /trunk/epan/dissectors/packet-nettl.c + M /trunk/epan/prefs.c + M /trunk/epan/wslua/wslua_pinfo.c + M /trunk/gtk/new_packet_list.c -This works on Win32 and should work on unix/linux (but I'm not sure here). Some stuff needs to be cleaned up, some more may need to be rewritten to specifically work with unix/win32. Futher work needs to be done at: +Custom columfication: -1. read filters (simply document current behaviour?) -2. event loop polling -3. privileges -4. code cleanup (e.g. in capture_loop.c) +* Deprecate COL_HPUX_SUBSYS (HP-UX Nettl Subsystem). Use nettl.subsys -Be prepared that tshark might not work as before / expected at least in the next days! ------------------------------------------------------------------------ -r22970 | ulfl | 2007-09-25 14:56:43 -0700 (Tue, 25 Sep 2007) | 1 line +r29517 | krj | 2009-08-23 03:25:51 -0700 (Sun, 23 Aug 2009) | 4 lines Changed paths: - M /trunk/plugins/profinet/packet-dcerpc-pn-io.c + M /trunk/epan/column-utils.c + M /trunk/epan/column.c + M /trunk/epan/column_info.h + M /trunk/epan/dissectors/packet-nettl.c + M /trunk/epan/prefs.c + M /trunk/epan/wslua/wslua_pinfo.c + M /trunk/gtk/new_packet_list.c -slightly better summary of IODWriteRes and don't repeat AR info for each IODWriteRes_header ------------------------------------------------------------------------- -r22971 | ulfl | 2007-09-25 14:57:25 -0700 (Tue, 25 Sep 2007) | 1 line -Changed paths: - M /trunk/epan/dissectors/dissectors.vcproj +Custom columfication: -add some more files ------------------------------------------------------------------------- -r22972 | ulfl | 2007-09-25 14:59:19 -0700 (Tue, 25 Sep 2007) | 1 line -Changed paths: - M /trunk/wireshark.sln +* Deprecate COL_HPUX_DEVID (HP-UX Device ID). Use nettl.devid -add a "build.0" configuration, MSVC 2005 wants to have it (for whatever reasons) ------------------------------------------------------------------------ -r22973 | ulfl | 2007-09-25 15:38:39 -0700 (Tue, 25 Sep 2007) | 1 line +r29518 | krj | 2009-08-23 04:12:12 -0700 (Sun, 23 Aug 2009) | 4 lines Changed paths: - M /trunk/Makefile.common + M /trunk/epan/column-utils.c + M /trunk/epan/dissectors/packet-ip.c + M /trunk/epan/prefs.c + M /trunk/gtk/new_packet_list.c -remove trailing backslash ------------------------------------------------------------------------- -r22974 | ulfl | 2007-09-25 16:23:56 -0700 (Tue, 25 Sep 2007) | 1 line -Changed paths: - M /trunk/tshark.c +Custom columfication: -add a dummy function, so unix/linux version should at least compile ------------------------------------------------------------------------- -r22975 | ulfl | 2007-09-25 17:03:30 -0700 (Tue, 25 Sep 2007) | 1 line -Changed paths: - M /trunk/tshark.c +* Deprecate COL_DSCP_VALUE (IP DSCP Value). Use ip.dsfield -solve some more of the unix specific buildbot problems ------------------------------------------------------------------------ -r22976 | guy | 2007-09-25 17:41:00 -0700 (Tue, 25 Sep 2007) | 9 lines +r29519 | krj | 2009-08-23 04:13:53 -0700 (Sun, 23 Aug 2009) | 1 line Changed paths: - M /trunk/doc/README.developer - M /trunk/epan/dissectors/packet-dcp.c - -Don't use - - case N ... M: - -as that's not supported by all compilers. - -Say so in the Portability section of README.developer, in the hopes of -discouraging others from using that GCCism. + M /trunk/epan/column-utils.c +#if 0 col_set_circuit_id(). It isn't being used ------------------------------------------------------------------------ -r22977 | ulfl | 2007-09-25 17:44:47 -0700 (Tue, 25 Sep 2007) | 1 line +r29520 | tuexen | 2009-08-23 04:30:54 -0700 (Sun, 23 Aug 2009) | 3 lines Changed paths: - M /trunk/tshark.c + M /trunk/epan/dissectors/packet-sctp.c + M /trunk/epan/sctpppids.h + +Update list of PPIDs. +This fixes bug 3928. -the Ubuntu / OS X buildbots don't seem to like G_STATIC_MUTEX_INIT (for whatever reason), try to use g_static_mutex_init() instead ------------------------------------------------------------------------ -r22978 | guy | 2007-09-25 19:21:31 -0700 (Tue, 25 Sep 2007) | 2 lines +r29521 | krj | 2009-08-23 04:35:53 -0700 (Sun, 23 Aug 2009) | 1 line Changed paths: - M /trunk/epan/dissectors/packet-dcp.c - -A guint8 can never be > 255. + M /trunk/epan/prefs.c +Avoid signed/unsigned comparison ------------------------------------------------------------------------ -r22979 | guy | 2007-09-25 19:36:22 -0700 (Tue, 25 Sep 2007) | 8 lines +r29522 | krj | 2009-08-23 05:16:10 -0700 (Sun, 23 Aug 2009) | 4 lines Changed paths: - M /trunk/epan/dissectors/packet-dcp.c - -Squelch *another* "case M ... N:". + M /trunk/epan/column-utils.c + M /trunk/epan/column.c + M /trunk/epan/column_info.h + M /trunk/epan/dissectors/packet-fr.c + M /trunk/epan/prefs.c + M /trunk/gtk/new_packet_list.c -To quote doc/README.developer: +Custom columnfication: - Don't use "inline"; not all compilers support it. If you want to have a - function be an inline function if the compiler supports it, use - G_INLINE_FUNC, which is declared by <glib.h>. +* Deprecate COL_FR_DLCI (Frame Relay DLCI). Use fr.dlci ------------------------------------------------------------------------ -r22980 | sfisher | 2007-09-25 20:05:42 -0700 (Tue, 25 Sep 2007) | 13 lines +r29523 | krj | 2009-08-23 05:24:14 -0700 (Sun, 23 Aug 2009) | 4 lines Changed paths: - M /trunk/doc/README.developer - M /trunk/epan/dissectors/packet-dcp.c - - -The dissector packet-dcp.c now fails to compile on MacOS X (gcc 4.0.1/Apple). Change G_INLINE_FUNC back to inline per GLib documentation (also remove recommendation in developer's guide to not use inline): - -http://library.gnome.org/devel/glib/unstable/glib-Miscellaneous-Macros.html#id2571572 - -G_INLINE_FUNC - -#define G_INLINE_FUNC -This macro is used to export function prototypes so they can be linked with an external version when no inlining is performed. The file which implements the functions should define G_IMPLEMENTS_INLINES before including the headers which contain G_INLINE_FUNC declarations. Since inlining is very compiler-dependent using these macros correctly is very difficult. Their use is strongly discouraged. + M /trunk/epan/column-utils.c + M /trunk/epan/column-utils.h + M /trunk/epan/column.c + M /trunk/epan/column_info.h + M /trunk/epan/dissectors/packet-tcp.c + M /trunk/epan/prefs.c + M /trunk/gtk/new_packet_list.c -This macro is often mistaken for a replacement for the inline keyword; inline is already declared in a portable manner in the glib headers and can be used normally. +Custom columnfication: +* Deprecate COL_REL_CONV_TIME (Relative time (conversation)). Use tcp.time_relative ------------------------------------------------------------------------ -r22981 | sfisher | 2007-09-25 20:31:41 -0700 (Tue, 25 Sep 2007) | 7 lines +r29524 | krj | 2009-08-23 05:30:48 -0700 (Sun, 23 Aug 2009) | 4 lines Changed paths: - M /trunk/Makefile.common - + M /trunk/epan/column-utils.c + M /trunk/epan/dissectors/packet-tcp.c + M /trunk/epan/prefs.c + M /trunk/gtk/new_packet_list.c -Move sync_pipe_write.c to WIRESHARK_COMMON_SRC since it is now also needed -by tshark as well as Wireshark to fix compilation on Unix platforms. -This is due to the introduction of capture_sync.c (which calls -sync_pipe_errmsg_to_parent) to tshark_SOURCES in SVN revision 22969. +Custom columnfication: +* Deprecate COL_DELTA_CONV_TIME (Delta time (conversation)). Use tcp.time_delta ------------------------------------------------------------------------ -r22982 | guy | 2007-09-25 23:53:38 -0700 (Tue, 25 Sep 2007) | 3 lines +r29525 | gerald | 2009-08-23 08:03:28 -0700 (Sun, 23 Aug 2009) | 1 line Changed paths: - M /trunk/epan/dissectors/packet-dcp.c - -Make the number of bytes just a guint, in the hopes that it'll squelch -some of the warnings. + M /trunk/epan/enterprise-numbers + M /trunk/manuf +[Automatic manuf and enterprise-numbers update for 2009-08-23] ------------------------------------------------------------------------ -r22983 | jmayer | 2007-09-26 00:09:51 -0700 (Wed, 26 Sep 2007) | 2 lines +r29528 | jake | 2009-08-23 10:18:29 -0700 (Sun, 23 Aug 2009) | 7 lines Changed paths: - M /trunk/epan/dissectors/packet-smb-pipe.c - M /trunk/epan/dissectors/packet-tds.c - M /trunk/gtk/proto_draw.c - -"fix" some warnings about "might be used uninitialized" variables + M /trunk/epan/dissectors/packet-icmpv6.c ------------------------------------------------------------------------- -r22984 | jmayer | 2007-09-26 00:10:40 -0700 (Wed, 26 Sep 2007) | 2 lines -Changed paths: - M /trunk/epan/dissectors/packet-extreme.c +From Ivan Sy: +Per RFC 3810 - Multicast Listener Discovery Version 2 (MLDv2) for IPv6, +Add Number of Sources. Also to show Record Type's numeric value and not +just its equivalent. -Beginnings of EAPS shared link packet dissection (EAPSv2) +Cleaned up presentation and included record number as well. ------------------------------------------------------------------------ -r22985 | jmayer | 2007-09-26 01:38:43 -0700 (Wed, 26 Sep 2007) | 1 line +r29529 | krj | 2009-08-23 11:13:03 -0700 (Sun, 23 Aug 2009) | 8 lines Changed paths: - M /trunk/epan/dissectors/packet-extreme.c + M /trunk/gtk/expert_comp_table.c + M /trunk/gtk/expert_dlg.c -Decode role on shared link ------------------------------------------------------------------------- -r22986 | martinm | 2007-09-26 07:47:22 -0700 (Wed, 26 Sep 2007) | 4 lines -Changed paths: - M /trunk/plugins/wimaxasncp/packet-wimaxasncp.c +From Didier gautheron via bug 3929: -- show type (number) of unrecognised tlvs in the tlv root item -- also add this as an expert item -- tlv root item is now an FT_BYTES item (allowing filtering on whole tlv contents) +* Don't use g_string_chunk_clear(). It is only defined if GLib >= 2.14 ------------------------------------------------------------------------- -r22987 | gerald | 2007-09-26 08:48:45 -0700 (Wed, 26 Sep 2007) | 2 lines -Changed paths: - M /trunk/doc/capinfos.pod +From me: -Add the -E (encapsulation) flag. +* Whitespace fixes ------------------------------------------------------------------------ -r22988 | etxrab | 2007-09-26 12:00:48 -0700 (Wed, 26 Sep 2007) | 1 line +r29530 | krj | 2009-08-23 11:32:29 -0700 (Sun, 23 Aug 2009) | 5 lines Changed paths: - M /trunk/packaging/u3/win32/makefile.nmake + M /trunk/epan/dissectors/packet-bootp.c + M /trunk/gtk/expert_comp_dlg.c + M /trunk/gtk/expert_dlg.c -Try to fix the U3 build. ------------------------------------------------------------------------- -r22989 | etxrab | 2007-09-26 12:01:29 -0700 (Wed, 26 Sep 2007) | 1 line -Changed paths: - M /trunk/epan/dissectors/packet-rsl.c +From Didier gautheron via bug 3929: -Further IE dissection. ------------------------------------------------------------------------- -r22990 | etxrab | 2007-09-26 12:50:53 -0700 (Wed, 26 Sep 2007) | 1 line -Changed paths: - M /trunk/epan/dissectors/packet-rsl.c +* Expert Info / Expert Info Composite requires a full protocol tree. +* Delay tree NULL pointer check in bootp dissector -The unused pinfo strikes back (again). ------------------------------------------------------------------------ -r22991 | etxrab | 2007-09-26 14:37:57 -0700 (Wed, 26 Sep 2007) | 1 line +r29531 | jake | 2009-08-23 12:16:35 -0700 (Sun, 23 Aug 2009) | 2 lines Changed paths: - M /trunk/epan/dissectors/packet-rsl.c + M /trunk/epan/dissectors/packet-fc.c + M /trunk/wiretap/pcap-common.c + M /trunk/wiretap/wtap.c + M /trunk/wiretap/wtap.h -Fix unused functions. +From kahou: +Add Fibre Channel Delimiter Dissector for Fibre Channel FC2. ------------------------------------------------------------------------ -r22992 | stig | 2007-09-26 15:50:53 -0700 (Wed, 26 Sep 2007) | 5 lines +r29532 | wmeier | 2009-08-23 16:52:40 -0700 (Sun, 23 Aug 2009) | 2 lines Changed paths: - M /trunk/gtk/io_stat.c + M /trunk/epan/dissectors/packet-icmpv6.c -- Added Tick interval 1 min and 10 min. -- Draw an empty graph if no items in given tick interval. -- Initialize interval_delta so we don't get overlaping x-scale labels. -- Some whitespace cleanup. +Rework code slightly to prevent a GCC 'strict-aliasing' warning. ------------------------------------------------------------------------ -r22993 | stig | 2007-09-26 15:55:36 -0700 (Wed, 26 Sep 2007) | 2 lines +r29533 | stig | 2009-08-24 01:00:39 -0700 (Mon, 24 Aug 2009) | 3 lines Changed paths: - M /trunk/docbook/wsug_src/WSUG_chapter_statistics.xml + M /trunk/epan/dissectors/packet-icmpv6.c + M /trunk/epan/dissectors/packet-ipv6.h -Added 1 min and 10 min tick intervals to the user guide. +From Ivan Sy via bug 3931: +Added ND Proxy Flag for IPv6 RA flag. ------------------------------------------------------------------------ -r22994 | kukosa | 2007-09-26 23:03:45 -0700 (Wed, 26 Sep 2007) | 1 line +r29534 | kukosa | 2009-08-24 02:05:15 -0700 (Mon, 24 Aug 2009) | 1 line Changed paths: - M /trunk/asn1/Makefile.am - D /trunk/asn1/rrc/Makefile - M /trunk/asn1/rrc/Makefile.nmake - D /trunk/asn1/rrlp/Makefile - M /trunk/asn1/rrlp/Makefile.nmake - D /trunk/asn1/t38/Makefile - M /trunk/asn1/t38/Makefile.nmake - D /trunk/asn1/ulp/Makefile - M /trunk/asn1/ulp/Makefile.nmake - M /trunk/config.nmake - M /trunk/epan/dissectors/packet-t38.c - M /trunk/epan/dissectors/packet-t38.h + M /trunk/asn1/h450-ros/packet-h450-ros-template.c + M /trunk/asn1/q932-ros/packet-q932-ros-template.c + M /trunk/asn1/ros/ros-err.cnf + M /trunk/asn1/ros/ros-inv.cnf + M /trunk/asn1/ros/ros-res.cnf + M /trunk/epan/dissectors/packet-h450-ros.c + M /trunk/epan/dissectors/packet-q932-ros.c -put next few simple ASN.1 dissectors into the new makefile structure +Expert info for undecoded Q.932 and H.450 operations ------------------------------------------------------------------------ -r22995 | kukosa | 2007-09-27 00:08:47 -0700 (Thu, 27 Sep 2007) | 1 line +r29535 | etxrab | 2009-08-24 02:05:23 -0700 (Mon, 24 Aug 2009) | 14 lines Changed paths: - A /trunk/asn1/rrc/Makefile.am - A /trunk/asn1/rrc/Makefile.common - A /trunk/asn1/rrlp/Makefile.am - A /trunk/asn1/rrlp/Makefile.common - A /trunk/asn1/t38/Makefile.am - A /trunk/asn1/t38/Makefile.common - A /trunk/asn1/ulp/Makefile.am - A /trunk/asn1/ulp/Makefile.common + M /trunk/epan/dissectors/packet-tcp.c -add forgotten makefiles ------------------------------------------------------------------------- -r22996 | kukosa | 2007-09-27 01:33:53 -0700 (Thu, 27 Sep 2007) | 1 line -Changed paths: - M /trunk/config.nmake - M /trunk/configure.in -revert changes in config.nmake committed by mistake and commit configure.in ------------------------------------------------------------------------- -r22997 | jmayer | 2007-09-27 02:24:38 -0700 (Thu, 27 Sep 2007) | 1 line -Changed paths: - M /trunk/asn1/Makefile.am - M /trunk/asn1/dap - D /trunk/asn1/dap/Makefile - A /trunk/asn1/dap/Makefile.am - A /trunk/asn1/dap/Makefile.common - M /trunk/asn1/dap/Makefile.nmake - M /trunk/asn1/dap/dap-exp.cnf - M /trunk/configure.in +From: : " Michael" -Convert asn1/dap/ ------------------------------------------------------------------------- -r22998 | morriss | 2007-09-27 07:11:57 -0700 (Thu, 27 Sep 2007) | 1 line -Changed paths: - M /trunk/epan/dissectors/packet-nsip.c +packet-tcp marks a row as unwritable if there is more +than 1 PDU in a packet to prevent overwriting of the +protocol column. -As requested by Juan Wortley on -users: instead of allowing only 2 UDP ports to be dissected as NSIP, allow a range. Obsolete the old preferences. ------------------------------------------------------------------------- -r22999 | morriss | 2007-09-27 08:58:54 -0700 (Thu, 27 Sep 2007) | 8 lines -Changed paths: - M /trunk/tshark.c - -(Try to) get tshark capturing working on *NIX (it works for me anyway): -We can simply block waiting for input from the child process because we are -in a CLI that does not need to worry about updating a GUI while we're waiting -for packets and so forth. +However this breaks the proto,colinfo tap which checks +rows are writable or dies EVEN if it doesn't alter anything. -Before I realized that I wrote a working (for me) method using select() that -I've left in for now (#ifdef'd out). +Suggested patch attached to restore the initial value +after all PDUs have been processed. +https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=3675 ------------------------------------------------------------------------ -r23000 | sake | 2007-09-27 11:36:17 -0700 (Thu, 27 Sep 2007) | 15 lines +r29536 | etxrab | 2009-08-24 02:29:05 -0700 (Mon, 24 Aug 2009) | 1 line Changed paths: - M /trunk/wiretap/iseries.c - -From Martin Warnes: - -Attached is a small patch that correct an issue with reading certain IBM -iSeries Comms traces. - -Traces where data has been dropped for whatever reason now have the -packet number suffixed with an asterix "*", this causes the current -iSeries wiretap routine to report a "bad" header. The attached patch -simply scans the packet number field and removes any "* characters prior -to scanning, the fact that data may be missing is more than adequately -reported later by current wireshark packet processing. - -Regards .. Martin - + M /trunk/epan/dissectors/packet-tcp.c +packet-tcp.c:1551: warning: 'cleared_writable' may be used uninitialized in this function ------------------------------------------------------------------------ -r23001 | stig | 2007-09-27 14:27:34 -0700 (Thu, 27 Sep 2007) | 2 lines +r29537 | wmeier | 2009-08-24 07:30:55 -0700 (Mon, 24 Aug 2009) | 2 lines Changed paths: - M /trunk/asn1/rrc - M /trunk/asn1/rrlp - M /trunk/asn1/t38 - M /trunk/asn1/ulp + M /trunk/gtk/sctp_stat.c -Added default svn:ignore for asn1 rrlp, rrc, ulp and t38. +Rework code slightly to prevent a GCC 'breaking strict-aliasing rules' warning ------------------------------------------------------------------------ -r23002 | stig | 2007-09-27 14:48:25 -0700 (Thu, 27 Sep 2007) | 2 lines +r29538 | wmeier | 2009-08-24 08:17:58 -0700 (Mon, 24 Aug 2009) | 2 lines Changed paths: - M /trunk/asn1/ranap/Makefile.common + M /trunk/epan/dissectors/packet-icmpv6.c -Updated to include the ranap header file. +Remove unneeded #includes; Clean up indentation; Comment a few "closing braces". ------------------------------------------------------------------------ -r23003 | gerald | 2007-09-27 16:49:05 -0700 (Thu, 27 Sep 2007) | 3 lines +r29539 | etxrab | 2009-08-24 09:11:00 -0700 (Mon, 24 Aug 2009) | 2 lines Changed paths: - M /trunk/tshark.c - -Load wpcap.dll, since we still use it for some things. This should hopefully -fix Buildbot. + M /trunk/gtk/expert_comp_table.c + M /trunk/gtk/expert_dlg.c + M /trunk/gtk/expert_dlg.h +Use list_store isf deprecated clist. +Try to optimize expert_comp_table. ------------------------------------------------------------------------ -r23004 | sahlberg | 2007-09-27 22:50:19 -0700 (Thu, 27 Sep 2007) | 6 lines +r29540 | guy | 2009-08-24 11:20:20 -0700 (Mon, 24 Aug 2009) | 5 lines Changed paths: - M /trunk/epan/dissectors/packet-eth.c - M /trunk/epan/dissectors/packet-ip.c + M /trunk/gtk/expert_dlg.c -queue the ip/eth headers for tapping before calling any subdissectors -so that they can be tapped even if the subdissectors cause an exception +We no longer need the "ascending arrow" and "descending arrow" images +for clists, as we're not using a clist. - -this fixes bug 1527 +Clean up white space, and use C89 comments rather than C99/C++ comments. ------------------------------------------------------------------------ -r23005 | etxrab | 2007-09-27 23:06:36 -0700 (Thu, 27 Sep 2007) | 1 line +r29541 | etxrab | 2009-08-24 11:45:01 -0700 (Mon, 24 Aug 2009) | 1 line Changed paths: - M /trunk/tools/win32-setup.sh + M /trunk/gtk/color_utils.c + M /trunk/gtk/color_utils.h -Use the tag for downloading. +Use our own version of gdk_color_to_string if GTK < 2.12 ------------------------------------------------------------------------ -r23006 | sahlberg | 2007-09-28 00:08:52 -0700 (Fri, 28 Sep 2007) | 9 lines +r29542 | etxrab | 2009-08-24 13:33:49 -0700 (Mon, 24 Aug 2009) | 3 lines Changed paths: - M /trunk/epan/dissectors/packet-ndmp.c - -ndmp and tcp encapsulation of esp both use port 10000 - -make ndmp a heuristic dissector so it will "win" over tcp esp if the -packets look like ndmp and if "preferences/tcp/heuristic dissectors -first has been -chosen" - - + M /trunk/gtk/expert_comp_table.c +From Didier Gautheron: +Speed up expert info composite. +https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=3935 ------------------------------------------------------------------------ -r23007 | sahlberg | 2007-09-28 00:25:50 -0700 (Fri, 28 Sep 2007) | 3 lines +r29543 | etxrab | 2009-08-24 13:54:25 -0700 (Mon, 24 Aug 2009) | 2 lines Changed paths: - M /trunk/epan/dissectors/packet-ndmp.c - A /trunk/epan/dissectors/packet-ndmp.h - -add a function to test if a packet is ndmp or not - + M /trunk/epan/dissectors/packet-bssgp.c +Make it possible to use bssgp.tlli as custom column. +Remove COL_BSSGP_TLLI and CHECK_COL. ------------------------------------------------------------------------ -r23008 | sahlberg | 2007-09-28 00:26:40 -0700 (Fri, 28 Sep 2007) | 3 lines +r29544 | guy | 2009-08-24 14:38:57 -0700 (Mon, 24 Aug 2009) | 2 lines Changed paths: - M /trunk/epan/dissectors/Makefile.common - -add ndmp.h to the makefile + M /trunk/gtk/color_utils.h +Fix typo. ------------------------------------------------------------------------ -r23009 | sahlberg | 2007-09-28 00:34:42 -0700 (Fri, 28 Sep 2007) | 13 lines +r29545 | guy | 2009-08-24 18:01:55 -0700 (Mon, 24 Aug 2009) | 2 lines Changed paths: - M /trunk/epan/dissectors/packet-ipsec-tcp.c - -this silly protocol uses the same port as ndmp and worse, there is -nothing really in the header to identify it reliably as silly -vendor specific encapsulation - -10000 is actually registered by iana for ndmp so it makes no sense for -a lazy vendor to use it by default. + M /trunk/gtk/color_utils.c -make it check if the packet is ndmp first before assuming that anything -that goes to port 10000 must be some lazy vendor specific protocol - -grrr - - ------------------------------------------------------------------------- -r23010 | morriss | 2007-09-28 06:33:54 -0700 (Fri, 28 Sep 2007) | 1 line -Changed paths: - M /trunk/doc/README.developer +Fix another typo. -Add notes suggesting not to use hidden fields but if you're going to, use PROTO_ITEM_SET_HIDDEN() instead of proto_tree_add_*_hidden(). (I thought that was in here already...) Suggest putting fields-you-want-hidden in subtrees where they can be found by ordinary users. ------------------------------------------------------------------------ -r23011 | morriss | 2007-09-28 06:39:20 -0700 (Fri, 28 Sep 2007) | 1 line +r29546 | etxrab | 2009-08-24 22:42:14 -0700 (Mon, 24 Aug 2009) | 3 lines Changed paths: - M /trunk/doc/README.developer + M /trunk/epan/column.c + M /trunk/epan/column_info.h + M /trunk/epan/prefs.c + M /trunk/gtk/new_packet_list.c -Add a small note saying not to use proto_tree_add_text() in new code unless you have a specific reason (like those given in the next paragraphs). + Custom columnfication: + + * Deprecate COL_BSSGP_TLLI (GPRS BSSGP IE TLLI). Use bssgp.tlli ------------------------------------------------------------------------ -r23012 | sake | 2007-09-28 07:37:15 -0700 (Fri, 28 Sep 2007) | 3 lines +r29547 | guy | 2009-08-24 23:11:57 -0700 (Mon, 24 Aug 2009) | 2 lines Changed paths: - M /trunk/wiretap/netscreen.c + M /trunk/epan/column.c -When reading NetScreen snoop output, allow the '.' in interface names -so that packets on subinterfaces are accepted too. +Note in dlist[] that COL_BSSGP_TLLI is deprecated. ------------------------------------------------------------------------ -r23013 | martinm | 2007-09-28 09:17:22 -0700 (Fri, 28 Sep 2007) | 2 lines +r29548 | martinm | 2009-08-25 04:01:51 -0700 (Tue, 25 Aug 2009) | 2 lines Changed paths: M /trunk/epan/dissectors/packet-catapult-dct2000.c + M /trunk/epan/dissectors/packet-mac-lte.c -Handle IPv6 addresses in ipprim headers. - ------------------------------------------------------------------------- -r23014 | morriss | 2007-09-28 09:34:59 -0700 (Fri, 28 Sep 2007) | 1 line -Changed paths: - M /trunk/tshark.c +Show CRC errors for RARs. -Specify that -l causes tshark to flush the *standard* output (from bug 1875). The man page already states this ------------------------------------------------------------------------ -r23015 | wmeier | 2007-09-28 10:22:03 -0700 (Fri, 28 Sep 2007) | 2 lines +r29549 | etxrab | 2009-08-25 10:22:32 -0700 (Tue, 25 Aug 2009) | 5 lines Changed paths: - M /trunk/wiretap/k12.c + M /trunk/epan/dissectors/packet-gsm_a_rr.c -Add error checking for fwrites; replacement for the 2nd of the patches provided in bug #1864 +From Mike Morrin: +Minor errors in gsm rr dissectors +https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=3889 +Modified accoring to comments from Pascal Quantin(I hope I got it right). ------------------------------------------------------------------------ -r23016 | bondolo | 2007-09-28 11:23:59 -0700 (Fri, 28 Sep 2007) | 3 lines +r29550 | gerald | 2009-08-25 10:55:55 -0700 (Tue, 25 Aug 2009) | 2 lines Changed paths: - M /trunk/epan/addr_resolv.c - M /trunk/epan/addr_resolv.h - M /trunk/epan/column-utils.c - -Changes get_addr_name_buf() to use the more common convention where the provided buffer size is the entire size of the buffer including the space for the terminating \0 + M /trunk/tools/make-dissector-reg.py +Add more information to the comments at the top of the files we generate. ------------------------------------------------------------------------ -r23017 | bondolo | 2007-09-28 12:00:45 -0700 (Fri, 28 Sep 2007) | 6 lines +r29551 | etxrab | 2009-08-25 14:10:35 -0700 (Tue, 25 Aug 2009) | 6 lines Changed paths: M /trunk/epan/column-utils.c + M /trunk/epan/epan.c + M /trunk/epan/epan.h + M /trunk/epan/proto.c + M /trunk/epan/proto.h -Special casing is no longer necessary for formatting of AT_STRINGZ in col_set_addr() as -address_to_str_buf() does now take COL_MAX_LEN as a parameter. - -Add support for AT_URI to col_expr for addresses in col_set_addr(). The field names are "uri.src" and "uri.dst". - - ------------------------------------------------------------------------- -r23018 | jake | 2007-09-28 12:16:05 -0700 (Fri, 28 Sep 2007) | 2 lines -Changed paths: - M /trunk/epan/dissectors/packet-data.c - -Why do I have to enable the Bytes View to see the (start of) data of the Data dissector? -Adding the data as a subtree to the Data dissector. ------------------------------------------------------------------------- -r23019 | bondolo | 2007-09-28 13:53:56 -0700 (Fri, 28 Sep 2007) | 6 lines -Changed paths: - M /trunk/epan/dissectors/packet-jxta.c - -Improves dissection of JXTA traffic from http connections. - -Improved address display in packet summary panes. - -more options for jxta pdu filtering by addresses. +From Didier Gautheron: +move custom col set from proto_tree_set_xxx() to +epan_dissect_fill_in_columns(). +https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=3930 +I'v added the new functions to the .h files. ------------------------------------------------------------------------ -r23020 | gerald | 2007-09-28 16:40:51 -0700 (Fri, 28 Sep 2007) | 2 lines +r29552 | wmeier | 2009-08-25 14:54:12 -0700 (Tue, 25 Aug 2009) | 3 lines Changed paths: - M /trunk/test/suite-capture.sh + M /trunk/epan/dissectors/packet-tpncp.c -Support Solaris along with Windows. +Init two struct members so gcc 4.1.4 doesn't complain about "may be used uninitialized"; +Also: use gboolean for a true/false variable. ------------------------------------------------------------------------ -r23021 | guy | 2007-09-28 17:58:20 -0700 (Fri, 28 Sep 2007) | 2 lines +r29553 | martinm | 2009-08-25 16:01:03 -0700 (Tue, 25 Aug 2009) | 2 lines Changed paths: - M /trunk/version_info.c + M /trunk/epan/proto.h -We don't use NetSNMP any more. +Add missing semicolon. ------------------------------------------------------------------------ -r23022 | guy | 2007-09-28 18:01:02 -0700 (Fri, 28 Sep 2007) | 2 lines +r29554 | wmeier | 2009-08-25 16:03:10 -0700 (Tue, 25 Aug 2009) | 2 lines Changed paths: - M /trunk/dumpcap.c + M /trunk/epan/dissectors/packet-ssl-utils.c -We don't use NetSNMP any more. +Rework code slightly to prevent several GCC "breaking strict-aliasing rules" warnings ------------------------------------------------------------------------ -r23023 | guy | 2007-09-28 18:14:16 -0700 (Fri, 28 Sep 2007) | 2 lines +r29555 | wmeier | 2009-08-25 19:06:39 -0700 (Tue, 25 Aug 2009) | 2 lines Changed paths: - M /trunk/capture_sync.c + M /trunk/epan/column-utils.h -The fork_child argument to sync_interface_stats_close is unused on UN*X. +Add missing prototype .... ------------------------------------------------------------------------ -r23024 | guy | 2007-09-28 18:15:11 -0700 (Fri, 28 Sep 2007) | 4 lines +r29556 | etxrab | 2009-08-25 21:36:14 -0700 (Tue, 25 Aug 2009) | 3 lines Changed paths: - M /trunk/dumpcap.c - M /trunk/sync_pipe.h - M /trunk/sync_pipe_write.c - -Don't hardcode the notion that the sync pipe is the standard output into -sync_pipe_errmsg_to_parent(); have it take the FD for the sync pipe as -an argument. + M /trunk/epan/dissectors/packet-gtpv2.c +From swapnil: +Bug in Traffic Aggregate Description (TAD) IE in Packet-gtpv2.c fixed. +https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=3940 ------------------------------------------------------------------------ -r23025 | guy | 2007-09-28 18:36:03 -0700 (Fri, 28 Sep 2007) | 4 lines +r29557 | etxrab | 2009-08-25 21:37:08 -0700 (Tue, 25 Aug 2009) | 1 line Changed paths: - M /trunk/capture_sync.c - M /trunk/dumpcap.c - -Make the "-Z" argument to dumpcap take an argument that's the file -descriptor to use as the sync pipe. For now, always pass 1, so the sync -pipe is the standard output of dumpcap. + M /trunk/gtk/expert_comp_dlg.c +Make it possible to close and reactivate the window. ------------------------------------------------------------------------ -r23026 | guy | 2007-09-28 19:05:09 -0700 (Fri, 28 Sep 2007) | 4 lines +r29558 | etxrab | 2009-08-25 22:10:12 -0700 (Tue, 25 Aug 2009) | 3 lines Changed paths: - M /trunk/tshark.c - -Clean up indentation a bit. - -Count packets even if we're not dissecting them. + M /trunk/epan/dissectors/packet-ethertype.c + M /trunk/epan/etypes.h +From dragonlinux: +Add QNX OS VER 6's qnet ethernet protocol number. +https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=3934 ------------------------------------------------------------------------ -r23027 | guy | 2007-09-28 19:05:31 -0700 (Fri, 28 Sep 2007) | 2 lines +r29559 | krj | 2009-08-25 23:54:48 -0700 (Tue, 25 Aug 2009) | 1 line Changed paths: - M /trunk/capinfos.c - -Fix typo. + M /trunk/config.nmake +win-iconv is statically linked as part of Glib >= 2.14.5, so remove it from config.nmake ------------------------------------------------------------------------ -r23028 | guy | 2007-09-28 19:10:25 -0700 (Fri, 28 Sep 2007) | 2 lines +r29560 | krj | 2009-08-26 00:05:50 -0700 (Wed, 26 Aug 2009) | 1 line Changed paths: - M /trunk/README - -Update to reflect that we're using libsmi, not Net-SNMP. + M /trunk/config.nmake +Reorder so that mandatory requirements appear in succession ------------------------------------------------------------------------ -r23029 | guy | 2007-09-28 19:20:17 -0700 (Fri, 28 Sep 2007) | 3 lines +r29561 | stig | 2009-08-26 00:26:17 -0700 (Wed, 26 Aug 2009) | 3 lines Changed paths: - M /trunk/epan/dissectors/packet-jxta.c + M /trunk/epan/dissectors/packet-radius.c -"pinfo->match_string" is a "const char *"; save it into a variable of -the same type - that makes compilers much happier. +From Thierry Andry via bug 3941: +Added preference to set radius request TTL. ------------------------------------------------------------------------ -r23030 | guy | 2007-09-28 19:27:04 -0700 (Fri, 28 Sep 2007) | 2 lines +r29562 | martinm | 2009-08-26 02:13:14 -0700 (Wed, 26 Aug 2009) | 2 lines Changed paths: - M /trunk/tshark.c + M /trunk/epan/dissectors/packet-mac-lte.c -Get rid of a forward declaration of a routine that no longer exists. +Make UL grant size a (generated) field of its own (for easier use as a custom column or IO graph filter). ------------------------------------------------------------------------ -r23031 | sake | 2007-09-29 00:55:25 -0700 (Sat, 29 Sep 2007) | 7 lines +r29563 | wmeier | 2009-08-26 06:58:17 -0700 (Wed, 26 Aug 2009) | 2 lines Changed paths: - M /trunk/wiretap/netscreen.c - -When reading NetScreen snoop output, only use WTAP_ENCAP_PER_PACKET -if there are packets with different encapsulationtype in the file. -Otherwise use the encapsulationtype of the packets in the file. + M /trunk/gtk/rtp_stream.h -This makes it possible to save the imported data as libpcap file -(or any other format that does not support per-packet encapsulation). +Fix some indentation ------------------------------------------------------------------------ -r23032 | guy | 2007-09-29 16:42:45 -0700 (Sat, 29 Sep 2007) | 5 lines +r29564 | kukosa | 2009-08-26 08:10:31 -0700 (Wed, 26 Aug 2009) | 1 line Changed paths: - M /trunk/README.bsd - -Include DragonFly BSD in the list of BSDs to which this applies. - -Add information on how to set the mode, owner, and/or group of the BPF -devices in FreeBSD with devfs. + M /trunk/asn1/t38/packet-t38-template.c + M /trunk/epan/dissectors/packet-t38.c + M /trunk/epan/libwireshark.def +export t38_add_address, prefer destination port for T.38 conversation searching ------------------------------------------------------------------------ -r23033 | guy | 2007-09-29 17:03:38 -0700 (Sat, 29 Sep 2007) | 2 lines +r29565 | wmeier | 2009-08-26 09:39:34 -0700 (Wed, 26 Aug 2009) | 2 lines Changed paths: - M /trunk/README.macos + M /trunk/doc/README.developer -Wireshark builds with 10.4's X11 as well. +From dragonlinux AT gmail.com: Fix incorrect location of a right brace; ------------------------------------------------------------------------ -r23034 | guy | 2007-09-29 17:18:44 -0700 (Sat, 29 Sep 2007) | 17 lines +r29566 | etxrab | 2009-08-26 10:26:26 -0700 (Wed, 26 Aug 2009) | 3 lines Changed paths: - M /trunk/AUTHORS - M /trunk/debian/wireshark-root.desktop - M /trunk/wireshark.desktop - -From St?\195?\169phane Loeuillet: patches to fix problems with the .desktop files -found by desktop-file-validate: - - wireshark.desktop: warning: value "" for key "Path" in group "Desktop Entry" - does not look like an absolute path - wireshark.desktop: warning: value "GNOME;Application;Network;" for key - "Categories" in group "Desktop Entry" contains a deprecated value - "Application" - - wireshark-root.desktop: warning: key "Encoding" in group "Desktop Entry" is - deprecated - wireshark-root.desktop: warning: value "" for key "Path" in group "Desktop - Entry" does not look like an absolute path - wireshark-root.desktop: warning: value "GNOME;Application;Network;" for key - "Categories" in group "Desktop Entry" contains a deprecated value - "Application" + M /trunk/gtk/expert_comp_table.c + M /trunk/gtk/expert_comp_table.h + M /trunk/gtk/expert_dlg.c + M /trunk/gtk/main_proto_draw.c + M /trunk/gtk/main_proto_draw.h +From Didier Gautheron: +expert info clean up, +https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=3948 ------------------------------------------------------------------------ -r23035 | stig | 2007-09-30 03:07:56 -0700 (Sun, 30 Sep 2007) | 2 lines +r29567 | guy | 2009-08-26 12:17:25 -0700 (Wed, 26 Aug 2009) | 3 lines Changed paths: - M /trunk/configure.in + M /trunk/packaging/macosx/Resources/themes/Clearlooks-Quicksilver-OSX/gtk-2.0/pre_gtkrc -Try xdg-open before htmlview. +Note that we might want to look at some other themes, to see if any are +more like OS X (especially more like Leopard). ------------------------------------------------------------------------ -r23036 | guy | 2007-09-30 15:13:38 -0700 (Sun, 30 Sep 2007) | 8 lines +r29568 | wmeier | 2009-08-26 12:27:49 -0700 (Wed, 26 Aug 2009) | 2 lines Changed paths: - M /trunk/editcap.c - -Clean up indentation. - -"time_t" is not guaranteed to be an "unsigned long"; when printing it -with %lu, cast it to "unsigned long". + M /trunk/capture.c + M /trunk/color_filters.c + M /trunk/epan/dissectors/packet-bootp.c + M /trunk/epan/dissectors/packet-catapult-dct2000.c + M /trunk/epan/dissectors/packet-fix.c + M /trunk/epan/dissectors/packet-http.c + M /trunk/epan/dissectors/packet-kismet.c + M /trunk/epan/dissectors/packet-ldss.c + M /trunk/epan/dissectors/packet-memcache.c + M /trunk/epan/dissectors/packet-mgcp.c + M /trunk/epan/dissectors/packet-nfs.c + M /trunk/epan/dissectors/packet-pop.c + M /trunk/epan/dissectors/packet-quakeworld.c + M /trunk/epan/dissectors/packet-radius.c + M /trunk/epan/dissectors/packet-rlogin.c + M /trunk/epan/dissectors/packet-rtcp.c + M /trunk/epan/dissectors/packet-rtsp.c + M /trunk/epan/dissectors/packet-sdp.c + M /trunk/epan/dissectors/packet-ssh.c + M /trunk/epan/dissectors/packet-tftp.c + M /trunk/epan/dissectors/packet-user_encap.c + M /trunk/epan/ftypes/ftype-bytes.c + M /trunk/epan/ftypes/ftype-double.c + M /trunk/epan/ftypes/ftype-integer.c + M /trunk/epan/ftypes/ftype-string.c + M /trunk/epan/ftypes/ftype-time.c + M /trunk/epan/ftypes/ftype-tvbuff.c + M /trunk/epan/plugins.c + M /trunk/epan/prefs.c + M /trunk/epan/req_resp_hdrs.c + M /trunk/fileset.c + M /trunk/gtk/rtp_stream.c + M /trunk/gtk/rtp_stream_dlg.c + M /trunk/packet-range.c + M /trunk/plugins/wimaxasncp/packet-wimaxasncp.c + M /trunk/proto_hier_stats.c + M /trunk/tap-rtp-common.c -The "secs" field of a wtap_nstime, however, *is* defined to be a time_t; -there's no need to cast it to time_t. +(FWIW) One step towards including stdio.h & stdlib.h only when req'd. ------------------------------------------------------------------------ -r23037 | guy | 2007-09-30 15:34:15 -0700 (Sun, 30 Sep 2007) | 3 lines +r29569 | wmeier | 2009-08-26 12:28:20 -0700 (Wed, 26 Aug 2009) | 2 lines Changed paths: - M /trunk/dumpcap.c + M /trunk/wiretap/wtap.h -"get_compiled_version_info()" appends to the string text starting with -"with", so we shouldn't put our own "with" in there. +#include <stdio.h> no longer req'd. ------------------------------------------------------------------------ -r23038 | sahlberg | 2007-09-30 15:34:19 -0700 (Sun, 30 Sep 2007) | 3 lines +r29570 | wmeier | 2009-08-26 12:30:44 -0700 (Wed, 26 Aug 2009) | 2 lines Changed paths: - M /trunk/epan/dissectors/packet-dcerpc-fldb.c - M /trunk/epan/dissectors/packet-fcct.c - M /trunk/epan/dissectors/packet-fcdns.c - M /trunk/epan/dissectors/packet-fcels.c - M /trunk/epan/dissectors/packet-fcip.c - M /trunk/epan/dissectors/packet-fr.c - M /trunk/epan/dissectors/packet-ftam.c - -update filter fields for bug 1803 + M /trunk/epan/dissectors/packet-ipsec.c +Reformat some long lines for readability.... ------------------------------------------------------------------------ -r23039 | sahlberg | 2007-09-30 16:14:18 -0700 (Sun, 30 Sep 2007) | 15 lines +r29571 | guy | 2009-08-26 12:58:23 -0700 (Wed, 26 Aug 2009) | 2 lines Changed paths: - M /trunk/epan/dissectors/packet-radius.c - -change dissect_radius() to become a new-style dissector that can reject -packets that doesnt look like valid radius. - -verify that a packet is radius by checking that the command code is -known and also that the length is between 20 and 4096 bytes - -move the tap data to be ep_allocated instead of a static global variable - -dont use tvb_memcpy() to read a structure off the wiredata -use tvb_get_... to unmarshall the fields explicitely - - + M /trunk/packaging/macosx/Resources/themes/Clearlooks-Quicksilver-OSX/gtk-2.0/pre_gtkrc -this fixes bug 1634 +Add another theme candidate. ------------------------------------------------------------------------ -r23040 | wmeier | 2007-09-30 17:22:39 -0700 (Sun, 30 Sep 2007) | 2 lines +r29572 | martinm | 2009-08-26 15:31:06 -0700 (Wed, 26 Aug 2009) | 2 lines Changed paths: - M /trunk/tshark.c - -Add 'C' as a valid -N option in error message. + M /trunk/epan/column-utils.c ------------------------------------------------------------------------- -r23041 | ulfl | 2007-10-01 22:04:35 -0700 (Mon, 01 Oct 2007) | 1 line -Changed paths: - M /trunk/plugins/profinet/packet-dcerpc-pn-io.c +Show correct time value for "Time since previous displayed frame". -update to latest IEC draft ------------------------------------------------------------------------ -r23042 | ulfl | 2007-10-01 22:07:13 -0700 (Mon, 01 Oct 2007) | 1 line +r29573 | wmeier | 2009-08-26 15:45:07 -0700 (Wed, 26 Aug 2009) | 2 lines Changed paths: - M /trunk/epan/packet.c + M /trunk/gtk/about_dlg.c -be a bit more verbose, if the name given to register_dissector_table() is not unique (e.g. because of a buggy/duplicated plugin) ------------------------------------------------------------------------- -r23043 | kukosa | 2007-10-01 23:52:11 -0700 (Mon, 01 Oct 2007) | 1 line -Changed paths: - M /trunk/tools/asn2wrs.py +Keep Solaris buildbot happy .... -support of 'ANY DEFINED BY' from X.208 which is obsolete but still used in some RFCs ------------------------------------------------------------------------ -r23044 | sahlberg | 2007-10-02 01:21:25 -0700 (Tue, 02 Oct 2007) | 6 lines +r29574 | gerald | 2009-08-26 16:16:37 -0700 (Wed, 26 Aug 2009) | 8 lines Changed paths: - M /trunk/epan/dissectors/packet-ctdb.c - -get rid of a check for null we dont need - + M /trunk/Makefile.nmake + M /trunk/config.nmake + M /trunk/dumpcap.c + M /trunk/packaging/nsis/wireshark.nsi -coverity 257 +Add a compile-time option to use a separate thread for reading from +pipes. Enable this by default on Windows. Remove code that tried to +use WaitForSingleObject on a pipe (which Windows doesn't support). Use +native file handles and system calls on Windows (which fixes a problem +with partial reads I ran into during testing). +This should fix bug 1759. ------------------------------------------------------------------------ -r23045 | sahlberg | 2007-10-02 01:27:39 -0700 (Tue, 02 Oct 2007) | 4 lines +r29575 | wmeier | 2009-08-26 16:24:22 -0700 (Wed, 26 Aug 2009) | 2 lines Changed paths: - M /trunk/epan/dissectors/packet-dcerpc-samr.c - M /trunk/epan/dissectors/pidl/samr.cnf - -remove a test for null that we dont need since the variable can not be -null at this point + M /trunk/gtk/about_dlg.c + M /trunk/print.h +Add #include <stdio.h> to print.h; Undo the previous change to about_dlg.c ------------------------------------------------------------------------ -r23046 | sahlberg | 2007-10-02 01:33:38 -0700 (Tue, 02 Oct 2007) | 3 lines +r29576 | wmeier | 2009-08-26 19:53:13 -0700 (Wed, 26 Aug 2009) | 2 lines Changed paths: - M /trunk/epan/dissectors/packet-jxta.c - -coverity 263 check if variable is null before dereferencing it + M /trunk/dumpcap.c + M /trunk/epan/prefs-int.h + M /trunk/gtk/main.c +Add #include <stdio.h> in a few places for Solaris ------------------------------------------------------------------------ -r23047 | kukosa | 2007-10-02 02:26:28 -0700 (Tue, 02 Oct 2007) | 1 line +r29577 | wmeier | 2009-08-26 20:54:57 -0700 (Wed, 26 Aug 2009) | 2 lines Changed paths: - M /trunk/epan/dissectors/packet-ssl-utils.c + M /trunk/gtk/capture_dlg.c + M /trunk/gtk/cfilter_combo_utils.c + M /trunk/gtk/graph_analysis.c + M /trunk/gtk/iax2_analysis.c + M /trunk/gtk/main_filter_toolbar.c + M /trunk/gtk/main_packet_list.c + M /trunk/gtk/menus.c + M /trunk/gtk/new_packet_list.c + M /trunk/gtk/rtp_analysis.c -review and update list of TLS cipher suites ------------------------------------------------------------------------- -r23048 | morriss | 2007-10-02 07:45:20 -0700 (Tue, 02 Oct 2007) | 1 line -Changed paths: - M /trunk/epan/dissectors/packet-cpfi.c +Add #include <stdio.h> in a few more places for Solaris. -Make the CPFI dissector new style: return 0 in several cases (including if we don't have MAC addresses for the packet) to give other dissectors a chance to dissect the packet. I rearranged the code quite a bit here and don't have a sample capture to test against: hopefully I didn't break anything. ------------------------------------------------------------------------ -r23049 | stig | 2007-10-02 08:46:17 -0700 (Tue, 02 Oct 2007) | 2 lines +r29578 | wmeier | 2009-08-26 21:47:28 -0700 (Wed, 26 Aug 2009) | 2 lines Changed paths: - M /trunk/epan/dissectors/packet-udp.c + M /trunk/gtk/airpcap_gui_utils.c + M /trunk/gtk/compare_stat.c + M /trunk/gtk/dcerpc_stat.c + M /trunk/gtk/io_stat.c + M /trunk/gtk/mcast_stream.c + M /trunk/gtk/rpc_progs.c + M /trunk/gtk/rpc_stat.c + M /trunk/gtk/scsi_stat.c + M /trunk/gtk/sctp_stat_dlg.c + M /trunk/gtk/tcp_graph.c + M /trunk/gtk/voip_calls_dlg.c -Do not indicate bogus length if inside an icmp. +Add #include <stdio.h> in a few more places .... ------------------------------------------------------------------------ -r23050 | stig | 2007-10-02 09:27:52 -0700 (Tue, 02 Oct 2007) | 2 lines +r29579 | wmeier | 2009-08-26 22:04:05 -0700 (Wed, 26 Aug 2009) | 2 lines Changed paths: - M /trunk/epan/proto.c + M /trunk/gtk/funnel_stat.c -Added a missing break - fixing bug 1890. +Add #include <stdio.h> ------------------------------------------------------------------------ -r23051 | stig | 2007-10-02 09:46:49 -0700 (Tue, 02 Oct 2007) | 2 lines +r29580 | krj | 2009-08-26 22:04:29 -0700 (Wed, 26 Aug 2009) | 1 line Changed paths: - M /trunk/epan/dissectors/packet-nfs.c - -Use given length when decoding fhandles as unknown. + M /trunk/Makefile.nmake + M /trunk/config.nmake + M /trunk/epan/Makefile.nmake + M /trunk/packaging/nsis/Makefile.nmake +Windows: remove all references to ICONV_DIR, because we use the statically linked win-iconv instead ------------------------------------------------------------------------ -r23052 | stig | 2007-10-02 12:02:58 -0700 (Tue, 02 Oct 2007) | 2 lines +r29581 | wmeier | 2009-08-26 22:17:40 -0700 (Wed, 26 Aug 2009) | 2 lines Changed paths: - M /trunk/epan/dissectors/packet-ncp2222.inc + M /trunk/gtk/supported_protos_dlg.c -Check return value from ptvcursor_add in an attempt to fix bug 1886. +Add #include <stdio.h> ------------------------------------------------------------------------ -r23053 | etxrab | 2007-10-02 13:09:15 -0700 (Tue, 02 Oct 2007) | 1 line +r29582 | etxrab | 2009-08-26 22:34:06 -0700 (Wed, 26 Aug 2009) | 2 lines Changed paths: - M /trunk/epan/dissectors/packet-gsm_a.c - M /trunk/epan/dissectors/packet-gsm_a.h - M /trunk/epan/dissectors/packet-rsl.c + M /trunk/gtk/expert_dlg.c + M /trunk/gtk/gui_utils.c + M /trunk/gtk/gui_utils.h -Dissect more IE's +Don't copy const strings, store the pointer in the list store instead, +saves memory. ------------------------------------------------------------------------ -r23054 | etxrab | 2007-10-02 13:28:11 -0700 (Tue, 02 Oct 2007) | 1 line +r29583 | etxrab | 2009-08-26 23:57:53 -0700 (Wed, 26 Aug 2009) | 1 line Changed paths: - M /trunk/epan/dissectors/packet-rsl.c + M /trunk/gtk/expert_dlg.c + M /trunk/gtk/gui_utils.c + M /trunk/gtk/gui_utils.h -Fix comments +make the columns sortable. ------------------------------------------------------------------------ -r23055 | sahlberg | 2007-10-02 14:21:55 -0700 (Tue, 02 Oct 2007) | 3 lines +r29584 | stig | 2009-08-27 04:58:03 -0700 (Thu, 27 Aug 2009) | 2 lines Changed paths: - M /trunk/epan/dissectors/packet-rsl.c - -ifdef out a function that is not yet used + M /trunk/gtk/wlan_stat_dlg.c +Remove the three dots in the menu item. ------------------------------------------------------------------------ -r23056 | sahlberg | 2007-10-02 14:26:22 -0700 (Tue, 02 Oct 2007) | 5 lines +r29585 | krj | 2009-08-27 08:32:57 -0700 (Thu, 27 Aug 2009) | 1 line Changed paths: - M /trunk/epan/dissectors/packet-ansi_a.c - -bug 1872 - -from chris maynard fix some filter names for ansi_a - + M /trunk/CMakeLists.txt +Move configure checks to ConfigureChecks.cmake ------------------------------------------------------------------------ -r23057 | sahlberg | 2007-10-02 15:04:07 -0700 (Tue, 02 Oct 2007) | 7 lines +r29586 | krj | 2009-08-27 08:35:33 -0700 (Thu, 27 Aug 2009) | 1 line Changed paths: - M /trunk/plugins/sbus/packet-sbus.c - -make the sbus dissector nwe-style and make it check that the packet does -indeed look like sbus before taking it. - - -this fixes bug 1871 - + A /trunk/ConfigureChecks.cmake +Add ConfigureChecks.cmake ------------------------------------------------------------------------ -r23058 | sake | 2007-10-03 07:02:08 -0700 (Wed, 03 Oct 2007) | 9 lines +r29587 | gerald | 2009-08-27 08:46:53 -0700 (Thu, 27 Aug 2009) | 4 lines Changed paths: - M /trunk/epan/column-utils.c - M /trunk/epan/column-utils.h - M /trunk/epan/column.c - M /trunk/epan/column_info.h - M /trunk/epan/dissectors/packet-tcp.c - M /trunk/epan/libwireshark.def - -This patch adds two new column types: -- COL_REL_CONV_TIME which is used to display the time relative to the first frame that was seen in the conversation -- COL_DELTA_CONV_TIME which is used to display the delta time from the previous frame of the conversation - -It also adds the function "col_set_time()" to "epan/column-utils.[ch]" which can be called from within a dissector to set either of these two columns to the appropiate time. - -Last but not least, it lets the tcp-dissector make use of these two columns. + M /trunk/dumpcap.c +Check for INVALID_HANDLE_VALUE instead of NULL on Windows. This keeps +us from feeding a NULL pointer to pcap_compile if we can't open our +pipe. Fix up a couple of error messages. ------------------------------------------------------------------------ -r23059 | stig | 2007-10-03 08:00:58 -0700 (Wed, 03 Oct 2007) | 2 lines +r29588 | krj | 2009-08-27 08:55:58 -0700 (Thu, 27 Aug 2009) | 1 line Changed paths: - M /trunk/epan/dissectors/packet-scsi.c - -Use correct offset for sccs, bque and reladdr flags. + M /trunk/CMakeLists.txt +Remove zlib from the set of mandatory packages (it isn't) ------------------------------------------------------------------------ -r23060 | stig | 2007-10-03 09:22:50 -0700 (Wed, 03 Oct 2007) | 4 lines +r29589 | krj | 2009-08-27 09:11:16 -0700 (Thu, 27 Aug 2009) | 1 line Changed paths: - M /trunk/epan/dissectors/packet-scsi.c - -Updated scsi_verdesc_val from appendix D in spc-3. -Dump Inquiry Vendor Specific and Reserved fields as bytes. -(still missing dumping of Clocking/QAS/IUS bits) + M /trunk/CMakeLists.txt +We require CMake >= 2.6 so we don't have to repeat the expressions in endif() + friends ------------------------------------------------------------------------ -r23061 | sake | 2007-10-03 10:07:19 -0700 (Wed, 03 Oct 2007) | 4 lines +r29590 | gerald | 2009-08-27 16:55:48 -0700 (Thu, 27 Aug 2009) | 3 lines Changed paths: - M /trunk/epan/req_resp_hdrs.c - -Fixes reassembly of chunked http-responses spanning multiple tcp segments -(bugs 1581,1851 and 1868) + M /trunk/dumpcap.c +Properly set our file descriptor when we're capturing from a pipe on +non-Windows systems. ------------------------------------------------------------------------ -r23062 | ulfl | 2007-10-03 10:57:57 -0700 (Wed, 03 Oct 2007) | 1 line +r29591 | etxrab | 2009-08-27 22:17:14 -0700 (Thu, 27 Aug 2009) | 1 line Changed paths: - M /trunk/wiretap/README.developer + M /trunk/dumpcap.c -update to changes in the source files +Make the windows build compile. ------------------------------------------------------------------------ -r23063 | ulfl | 2007-10-03 10:59:33 -0700 (Wed, 03 Oct 2007) | 1 line +r29592 | etxrab | 2009-08-27 22:19:52 -0700 (Thu, 27 Aug 2009) | 2 lines Changed paths: - M /trunk/wiretap/wtap.h + M /trunk/file.c + M /trunk/file.h + M /trunk/gtk/main_statusbar.c -fix some comments and sort functions by functionality +Compute the loading time and show it in the main status bar. +(Modified code from Didier Gautheron). ------------------------------------------------------------------------ -r23064 | ulfl | 2007-10-03 11:02:27 -0700 (Wed, 03 Oct 2007) | 1 line +r29593 | etxrab | 2009-08-27 23:21:16 -0700 (Thu, 27 Aug 2009) | 1 line Changed paths: - M /trunk/plugins/profinet/packet-dcerpc-pn-io.c + M /trunk/config.nmake + M /trunk/tools/win32-setup.sh -check version of each block and don't try to dissect a block if the version is not as expected (to avoid "miss-dissections") +Use GTK+ 2.16.5 and Glib 2.20.4. ------------------------------------------------------------------------ -r23065 | stig | 2007-10-03 12:35:32 -0700 (Wed, 03 Oct 2007) | 2 lines +r29594 | jmayer | 2009-08-28 02:38:34 -0700 (Fri, 28 Aug 2009) | 8 lines Changed paths: - M /trunk/plugins/profinet/packet-dcerpc-pn-io.c - -Added parentheses to make the buildbot happy. + M /trunk/epan/proto.c ------------------------------------------------------------------------- -r23066 | martinm | 2007-10-04 03:24:59 -0700 (Thu, 04 Oct 2007) | 3 lines -Changed paths: - M /trunk/epan/dissectors/packet-sip.c +After asking on the list and receiving no feedback, I'll +just commit this: -Make selected length of first line include \r\n (as header lines do). -Make 'Message Body' a proper filterable field. +Change the checks for type FT_IPv6 to no longer require +a lenght of exaclty 16 bytes, but something between +0 and 16 bytes. That way, we can filter on prefixes +that do not provide the whole length of 16 bytes. ------------------------------------------------------------------------ -r23067 | stig | 2007-10-04 06:22:40 -0700 (Thu, 04 Oct 2007) | 2 lines +r29595 | wmeier | 2009-08-28 06:52:52 -0700 (Fri, 28 Aug 2009) | 2 lines Changed paths: - M /trunk/epan/dissectors/packet-h261.c - -Mask out correct bits in EBIT. + M /trunk/epan/dissectors/packet-zbee-zcl.c ------------------------------------------------------------------------- -r23068 | kukosa | 2007-10-05 00:36:51 -0700 (Fri, 05 Oct 2007) | 2 lines -Changed paths: - M /trunk/tools/asn2wrs.py +Validate a function parameter -do not prepend './' before input file name if -D <dir> option is not used -it made problem with absolute path usage ------------------------------------------------------------------------ -r23069 | kukosa | 2007-10-05 00:44:03 -0700 (Fri, 05 Oct 2007) | 1 line +r29596 | krj | 2009-08-28 08:59:20 -0700 (Fri, 28 Aug 2009) | 1 line Changed paths: - M /trunk/asn1/h225/h225-exp.cnf - M /trunk/asn1/h225/h225.cnf - M /trunk/asn1/h245/h245-exp.cnf - M /trunk/asn1/h245/h245.cnf - M /trunk/asn1/h450/packet-h450-template.c - M /trunk/epan/dissectors/packet-h225.c - M /trunk/epan/dissectors/packet-h225.h - M /trunk/epan/dissectors/packet-h245.c - M /trunk/epan/dissectors/packet-h245.h - M /trunk/epan/dissectors/packet-h450.c - M /trunk/epan/libwireshark.def - M /trunk/gtk/h225_counter.c - M /trunk/tap-h225counter.c + M /trunk/config.nmake -export more types from H.225.0 and H.245 which will be necessary for H.460.x, H.323 (Annex M,R), H.501 +Indicate where the some of the macros are used ------------------------------------------------------------------------ -r23070 | kukosa | 2007-10-05 00:46:06 -0700 (Fri, 05 Oct 2007) | 1 line +r29597 | gerald | 2009-08-28 09:08:27 -0700 (Fri, 28 Aug 2009) | 2 lines Changed paths: - M /trunk/asn1/Makefile.inc - M /trunk/asn1/Makefile.inc.nmake + M /trunk/doc/tshark.pod -allow to omit -p <proto> option ------------------------------------------------------------------------- -r23071 | kukosa | 2007-10-05 02:08:57 -0700 (Fri, 05 Oct 2007) | 1 line -Changed paths: - M /trunk/asn1/Makefile.inc +Add an example for generating CSV output. -try to fix Linux makefile ------------------------------------------------------------------------ -r23072 | kukosa | 2007-10-05 03:38:30 -0700 (Fri, 05 Oct 2007) | 1 line +r29598 | wmeier | 2009-08-28 09:36:24 -0700 (Fri, 28 Aug 2009) | 3 lines Changed paths: - M /trunk/asn1/Makefile.inc + M /trunk/epan/dissectors/packet-netflow.c -comment out some lines till I learn how to write Linux makefile ------------------------------------------------------------------------- -r23073 | kukosa | 2007-10-05 04:15:00 -0700 (Fri, 05 Oct 2007) | 1 line -Changed paths: - M /trunk/asn1/Makefile.inc +Don't coerce a possibly unaligned ptr to a (guint32 *); +Also: Calculate the same template hash whether on a LE or BE machine. -next fix of my mistake :( ------------------------------------------------------------------------ -r23074 | richardv | 2007-10-05 07:45:21 -0700 (Fri, 05 Oct 2007) | 2 lines +r29599 | wmeier | 2009-08-28 09:52:05 -0700 (Fri, 28 Aug 2009) | 2 lines Changed paths: - M /trunk/asn1/Makefile.inc + M /trunk/epan/dissectors/packet-dcm.c -hopefully this will do what Thomas wants for NO_PROTO_OPT +Fix possible memmove with a NULL poiunter. ------------------------------------------------------------------------ -r23075 | morriss | 2007-10-05 14:25:35 -0700 (Fri, 05 Oct 2007) | 12 lines +r29600 | wmeier | 2009-08-28 11:37:53 -0700 (Fri, 28 Aug 2009) | 4 lines Changed paths: - M /trunk/epan/dissectors/packet-netflow.c - -From Andrew Feren via http://bugs.wireshark.org/bugzilla/show_bug.cgi?id=1606 : -1) IPFIX port (4739) should be configurable without recompiling -2) It should be possible to specify more than one port to be dissected as - Netflow and/or IPFIX -3) Netflow should recognize UDP ports 2055 and 9996 (Both are common) + M /trunk/epan/dissectors/packet-ipmi-transport.c -Also (from me): -- make Netflow a "new style" dissector: return 0 if it doesn't appear to be a - valid netflow packet -- register the old preference (cflow.udp.port) as obsolete so users don't see - warnings about it not being valid +Fix if test in fcn rs11(): +return if either (as opposed to both) of the required sparameters is not present; +(Found by clang scan-build). ------------------------------------------------------------------------ -r23076 | gerald | 2007-10-05 14:38:59 -0700 (Fri, 05 Oct 2007) | 3 lines +r29601 | wmeier | 2009-08-28 12:15:43 -0700 (Fri, 28 Aug 2009) | 3 lines Changed paths: - M /trunk/asn1/Makefile.inc - M /trunk/asn1/Makefile.inc.nmake - -In the various Makefiles, remove checks for NO_PROTO_OPT and allow PROT_OPT -to be overridden further up the chain, e.g. in Makefile.common + M /trunk/epan/dissectors/packet-dcerpc.c ------------------------------------------------------------------------- -r23077 | morriss | 2007-10-05 15:39:06 -0700 (Fri, 05 Oct 2007) | 1 line -Changed paths: - M /trunk/capture_info.c +Fix code which could access uninitialized variables and display incorrect text in COL_INFO. +(Found by clang scan-build). -If wtap_open_offline() fails, print the errno too ------------------------------------------------------------------------ -r23078 | stig | 2007-10-05 16:47:37 -0700 (Fri, 05 Oct 2007) | 8 lines +r29602 | etxrab | 2009-08-28 14:34:59 -0700 (Fri, 28 Aug 2009) | 8 lines Changed paths: - M /trunk/AUTHORS - M /trunk/epan/dissectors/packet-wbxml.c - -From Andrei Rubaniuk: -This patch adds support for IMPS 1.3 protocol dissection and also -updates IMPS 1.2 protocol to approved release version. + M /trunk/epan/dissectors/Makefile.common + A /trunk/epan/dissectors/packet-nb_rtpmux.c + M /trunk/epan/dissectors/packet-rtcp.c -From me: -- Updated vals_wbxml_public_ids table. -- Reindented file. +From Neil Piercy: +Add new protocol for 3GPP 29.414 (Nb interface RTP Mux). +- Don't use C++-style comments (comments beginning with "//") +- Don't declare variables in the middle of executable code; not all C +compilers support that. +- Dont register preferences when none present. +- Removed CHECK_COL ------------------------------------------------------------------------ -r23079 | stig | 2007-10-06 04:28:09 -0700 (Sat, 06 Oct 2007) | 5 lines +r29603 | guy | 2009-08-28 18:08:31 -0700 (Fri, 28 Aug 2009) | 13 lines Changed paths: - M /trunk/epan/dissectors/packet-p_mul.c - -- Added option to use relative message id (MSID) -- Added generated entry for total missing sequence numbers -- Added expert info on invalid ack info length -- Added count of ack in info column + M /trunk/epan/dissectors/packet-nb_rtpmux.c ------------------------------------------------------------------------- -r23080 | stig | 2007-10-06 13:37:52 -0700 (Sat, 06 Oct 2007) | 4 lines -Changed paths: - M /trunk/asn1/x411/packet-x411-template.c - M /trunk/asn1/x411/x411.cnf - M /trunk/epan/dissectors/packet-x411.c +Note that the "heuristic" is fatally weak, and must be strengthened or +eliminated. -- Initialize address_item in MessageIdentifier to avoid a crash in handling - LocalIdentifier when problems with the GlobalDomainIdentifier. -- Initialize global pointers to avoid potential crashes. +Fix indentation. ------------------------------------------------------------------------- -r23081 | etxrab | 2007-10-07 08:14:27 -0700 (Sun, 07 Oct 2007) | 1 line -Changed paths: - M /trunk/epan/dissectors/packet-ethertype.c - M /trunk/epan/etypes.h +Use tvb_reported_length(), so we throw an exception for packets cut +short by a snapshot length. -Add ethertype for IEEE 802.1ag Connectivity Fault Management (CFM) protocol ------------------------------------------------------------------------- -r23082 | etxrab | 2007-10-07 09:02:04 -0700 (Sun, 07 Oct 2007) | 16 lines -Changed paths: - M /trunk/asn1/pkix1explicit/Makefile - M /trunk/asn1/pkix1explicit/Makefile.nmake - M /trunk/asn1/pkix1explicit/PKIX1EXPLICIT93.asn - M /trunk/asn1/pkix1explicit/pkix1explicit-exp.cnf - M /trunk/asn1/pkix1explicit/pkix1explicit.cnf - M /trunk/asn1/pkix1explicit/pkix1explicit_exp.cnf - M /trunk/asn1/pkix1implicit/Makefile - M /trunk/asn1/pkix1implicit/Makefile.nmake - M /trunk/asn1/pkix1implicit/PKIX1IMPLICIT93.asn - M /trunk/asn1/pkix1implicit/pkix1implicit-exp.cnf - M /trunk/asn1/pkix1implicit/pkix1implicit.cnf - M /trunk/asn1/pkix1implicit/pkix1implicit_exp.cnf - M /trunk/asn1/pkixcmp/CMP.asn - M /trunk/asn1/pkixcmp/Makefile - M /trunk/asn1/pkixcmp/Makefile.nmake - M /trunk/asn1/pkixcmp/cmp-exp.cnf - M /trunk/asn1/pkixcmp/cmp.cnf - M /trunk/asn1/pkixcrmf/CRMF.asn - M /trunk/asn1/pkixcrmf/Makefile - M /trunk/asn1/pkixcrmf/Makefile.nmake - M /trunk/asn1/pkixcrmf/crmf-exp.cnf - M /trunk/asn1/pkixcrmf/crmf.cnf - M /trunk/epan/dissectors/packet-cmp.c - M /trunk/epan/dissectors/packet-cmp.h - M /trunk/epan/dissectors/packet-crmf.c - M /trunk/epan/dissectors/packet-crmf.h - M /trunk/epan/dissectors/packet-pkix1explicit.c - M /trunk/epan/dissectors/packet-pkix1explicit.h - M /trunk/epan/dissectors/packet-pkix1implicit.c - M /trunk/epan/dissectors/packet-pkix1implicit.h - -From Martin Peylo: -http://bugs.wireshark.org/bugzilla/show_bug.cgi?id=1888 - -There are new versions of CMP (v2) in RFC4210 and CRMF (v2) in RFC4211. The -right to exist of CRMF is bound to CMP so I don't split that into two bug -reports. - -I'll upload the new (slightly handmassaged) ASN.1 files for both protocols, -along with patches for the respective cnf files, where I also added new -#.REGISTER statements. - -Additionally I had to export some definitions from pkix1explicit (Attribute, -Time, UniqueIdentifier and Version) and from pkix1implicit (KeyIdentifier). -I'll also upload a patch for that. - -I uploaded a CMPv2 sample (with errors in the protocol!) to the wiki. ------------------------------------------------------------------------- -r23083 | jmayer | 2007-10-07 13:02:30 -0700 (Sun, 07 Oct 2007) | 3 lines -Changed paths: - M /trunk/asn1/Makefile.am - D /trunk/asn1/acse/acse-exp.cnf - D /trunk/asn1/cdt/cdt-exp.cnf - D /trunk/asn1/cmip/cmip-exp.cnf - D /trunk/asn1/cms/cms-exp.cnf - D /trunk/asn1/dap/dap-exp.cnf - M /trunk/asn1/disp - D /trunk/asn1/disp/Makefile - A /trunk/asn1/disp/Makefile.am - A /trunk/asn1/disp/Makefile.common - M /trunk/asn1/disp/Makefile.nmake - D /trunk/asn1/disp/disp-exp.cnf - M /trunk/asn1/dop - D /trunk/asn1/dop/Makefile - A /trunk/asn1/dop/Makefile.am - A /trunk/asn1/dop/Makefile.common - M /trunk/asn1/dop/Makefile.nmake - D /trunk/asn1/dop/dop-exp.cnf - D /trunk/asn1/dop/x501-exp.cnf - M /trunk/asn1/dsp - D /trunk/asn1/dsp/Makefile - A /trunk/asn1/dsp/Makefile.am - A /trunk/asn1/dsp/Makefile.common - M /trunk/asn1/dsp/Makefile.nmake - D /trunk/asn1/dsp/dsp-exp.cnf - M /trunk/asn1/ess - D /trunk/asn1/ess/Makefile - A /trunk/asn1/ess/Makefile.am - A /trunk/asn1/ess/Makefile.common - M /trunk/asn1/ess/Makefile.nmake - M /trunk/asn1/ftam - D /trunk/asn1/ftam/Makefile - A /trunk/asn1/ftam/Makefile.am - A /trunk/asn1/ftam/Makefile.common - M /trunk/asn1/ftam/Makefile.nmake - D /trunk/asn1/ftam/ftam-exp.cnf - M /trunk/asn1/gnm - D /trunk/asn1/gnm/Makefile - A /trunk/asn1/gnm/Makefile.am - A /trunk/asn1/gnm/Makefile.common - M /trunk/asn1/gnm/Makefile.nmake - M /trunk/asn1/gsmmap - D /trunk/asn1/gsmmap/Makefile - A /trunk/asn1/gsmmap/Makefile.am - A /trunk/asn1/gsmmap/Makefile.common - M /trunk/asn1/gsmmap/Makefile.nmake - D /trunk/asn1/gsmmap/gsm_map-exp.cnf - D /trunk/asn1/gsmmap/packet-gsm_map-template.c - D /trunk/asn1/gsmmap/packet-gsm_map-template.h - A /trunk/asn1/gsmmap/packet-gsmmap-template.c (from /trunk/asn1/gsmmap/packet-gsm_map-template.c:23082) - A /trunk/asn1/gsmmap/packet-gsmmap-template.h (from /trunk/asn1/gsmmap/packet-gsm_map-template.h:23082) - M /trunk/configure.in +Don't bother showing or dissecting the payload if there isn't any. -Convert some more protocols to new Makefile style. -Renamed the gsmmap template files to not contain an _ +Don't show an item with a zero-length payload as going to the end of the +packet. ------------------------------------------------------------------------ -r23084 | jmayer | 2007-10-07 13:11:09 -0700 (Sun, 07 Oct 2007) | 1 line +r29604 | wmeier | 2009-08-28 18:46:42 -0700 (Fri, 28 Aug 2009) | 6 lines Changed paths: - M /trunk/asn1/Makefile.inc - M /trunk/asn1/Makefile.inc.nmake + M /trunk/epan/dissectors/packet-nb_rtpmux.c -Swap order of external and local sources ------------------------------------------------------------------------- -r23085 | jmayer | 2007-10-07 14:07:33 -0700 (Sun, 07 Oct 2007) | 1 line -Changed paths: - M /trunk/asn1/h225 - D /trunk/asn1/h225/Makefile - A /trunk/asn1/h225/Makefile.am - A /trunk/asn1/h225/Makefile.common - M /trunk/asn1/h225/Makefile.nmake - D /trunk/asn1/h225/h225-exp.cnf - M /trunk/asn1/h235 - D /trunk/asn1/h235/Makefile - A /trunk/asn1/h235/Makefile.am - A /trunk/asn1/h235/Makefile.common - M /trunk/asn1/h235/Makefile.nmake - M /trunk/asn1/h248 - D /trunk/asn1/h248/Makefile - A /trunk/asn1/h248/Makefile.am - A /trunk/asn1/h248/Makefile.common - M /trunk/asn1/h248/Makefile.nmake +Cleanup: +- proto_reg_handoff: 'if (!inited)' not req'd; +- Remove unneeded #includes; +- Use NULL instead of " for 'blurbs'; +- Remove unneeded foward reference. -convert to new Makefile structure ------------------------------------------------------------------------ -r23086 | richardv | 2007-10-07 16:23:23 -0700 (Sun, 07 Oct 2007) | 1 line +r29605 | wmeier | 2009-08-28 19:22:28 -0700 (Fri, 28 Aug 2009) | 2 lines Changed paths: - M /trunk/epan/dissectors/packet-ieee80211.c + M /trunk/epan/dissectors/packet-rtcp.c -From Chris Maynard <christopher.maynard@gtech.com>: Incorrect display filter field naming convention. ------------------------------------------------------------------------- -r23087 | richardv | 2007-10-07 16:30:14 -0700 (Sun, 07 Oct 2007) | 1 line -Changed paths: - M /trunk/epan/dissectors/packet-llc.c +Replace "" by NULL in blurbs; Cleanup indentation. -From Chris Maynard <christopher.maynard@gtech.com>: Incorrect display filter field naming convention. ------------------------------------------------------------------------ -r23088 | richardv | 2007-10-07 16:46:44 -0700 (Sun, 07 Oct 2007) | 12 lines +r29606 | wmeier | 2009-08-28 19:25:04 -0700 (Fri, 28 Aug 2009) | 3 lines Changed paths: - M /trunk/plugins/docsis/packet-bpkmattr.c - M /trunk/plugins/docsis/packet-bpkmreq.c - M /trunk/plugins/docsis/packet-bpkmrsp.c - M /trunk/plugins/docsis/packet-dccack.c - M /trunk/plugins/docsis/packet-dccreq.c - M /trunk/plugins/docsis/packet-dccrsp.c - M /trunk/plugins/docsis/packet-dcd.c - M /trunk/plugins/docsis/packet-dsaack.c - M /trunk/plugins/docsis/packet-dsareq.c - M /trunk/plugins/docsis/packet-dsarsp.c - M /trunk/plugins/docsis/packet-dscack.c - M /trunk/plugins/docsis/packet-dscreq.c - M /trunk/plugins/docsis/packet-dscrsp.c - M /trunk/plugins/docsis/packet-dsdreq.c - M /trunk/plugins/docsis/packet-dsdrsp.c - M /trunk/plugins/docsis/packet-intrngreq.c - M /trunk/plugins/docsis/packet-macmgmt.c - M /trunk/plugins/docsis/packet-map.c - M /trunk/plugins/docsis/packet-regack.c - M /trunk/plugins/docsis/packet-regreq.c - M /trunk/plugins/docsis/packet-regrsp.c - M /trunk/plugins/docsis/packet-rngreq.c - M /trunk/plugins/docsis/packet-rngrsp.c - M /trunk/plugins/docsis/packet-tlv.c - M /trunk/plugins/docsis/packet-type29ucd.c - M /trunk/plugins/docsis/packet-uccreq.c - M /trunk/plugins/docsis/packet-uccrsp.c - M /trunk/plugins/docsis/packet-ucd.c - M /trunk/plugins/docsis/packet-vendor.c - -From Chris Maynard <christopher.maynard@gtech.com>: - -With the exception of docsis's packet-tlv.c file, these are all simple problems -with the prefix not exactly set to PROTOABBREV. For example, for -packet-bpkmattr.c, the field names are prefixed with "docsis.bpkmattr." instead -of "docsis_bpkmattr.". - -packet-tlv.c had one mis-named field, namely "docsis.cos.sid". It has been -changed to "docsis_tlv.cos.sid" in the patch to be attached, which includes -patches for 29 files in the plugins/docsis/ directory ... + M /trunk/epan/dissectors/packet-rtp.c +Replace "repeated blurb" by NULL in two cases; +Reformat a long line. ------------------------------------------------------------------------ -r23089 | avaquero | 2007-10-07 17:31:26 -0700 (Sun, 07 Oct 2007) | 1 line +r29607 | guy | 2009-08-28 19:32:33 -0700 (Fri, 28 Aug 2009) | 16 lines Changed paths: - M /trunk/gtk/graph_analysis.c - M /trunk/gtk/rtp_player.c - M /trunk/gtk/voip_calls_dlg.c + M /trunk/epan/dissectors/packet-nb_rtpmux.c -VoIP Calls changes: Add the file name to the title window in VoIP calls, Voip graph and RTP player windows. Make the calls selection using standard multiple selection using the GTK buildin functions. Add a 'Select All' buttom to the VoIP calls window. ------------------------------------------------------------------------- -r23090 | richardv | 2007-10-07 17:32:03 -0700 (Sun, 07 Oct 2007) | 4 lines -Changed paths: - M /trunk/epan/dissectors/packet-dcerpc-nt.c - M /trunk/epan/dissectors/packet-dhcpv6.c - M /trunk/epan/dissectors/packet-dtp.c - M /trunk/epan/dissectors/packet-dvmrp.c +Note what the 3GPP spec is for this protocol. -From Chris Maynard <christopher.maynard@gtech.com> / Bug 1798: packet-d*.c display filter fields incorrectly named. +Suggest a possible less-weak heuristic. +Note that we're not checking the T bit and handling RTP header +compression. +At least as I read TS 29.414, the length indicator isn't supposed to be +zero; however, a length indicator of 0 doesn't keep us from dissecting +further, so just don't bother dissecting the payload. We should, +perhaps, add an expert info for this. ------------------------------------------------------------------------- -r23091 | kukosa | 2007-10-08 01:08:25 -0700 (Mon, 08 Oct 2007) | 1 line -Changed paths: - M /trunk/asn1/Makefile.am - D /trunk/asn1/qsig/Makefile - A /trunk/asn1/qsig/Makefile.am - A /trunk/asn1/qsig/Makefile.common - M /trunk/asn1/qsig/Makefile.nmake - M /trunk/configure.in +We should perhaps also catch exceptions thrown when dissecting the RTP +packet, so a malformed RTP packet will still let us continue dissecting +the rest of the Nb packet. -change QSIQ ASN.1 dissector to the new makefile structure ------------------------------------------------------------------------ -r23092 | etxrab | 2007-10-08 04:41:21 -0700 (Mon, 08 Oct 2007) | 13 lines +r29608 | krj | 2009-08-28 21:39:59 -0700 (Fri, 28 Aug 2009) | 1 line Changed paths: - M /trunk/epan/dissectors/Makefile.common - A /trunk/epan/dissectors/packet-erf.c - A /trunk/epan/dissectors/packet-erf.h - M /trunk/epan/dissectors/packet-mtp2.c - M /trunk/wiretap/erf.c - M /trunk/wiretap/erf.h - M /trunk/wiretap/libpcap.c - M /trunk/wiretap/wtap-int.h - M /trunk/wiretap/wtap.c - M /trunk/wiretap/wtap.h - -From Florent DROUIN: -This is a replacement of the existing decoding of ERF files (Extensible Record -Format from Endace). -For the decoding of the ERF files, according to the "type of record" given in -the ERF header, several decoders can be used. Up to now, the decoder is -determined according to an environment variable, or with a kind of heuristic. -And, all the treatment is done during the file extraction. + M /trunk/epan/dissectors/packet-nb_rtpmux.c -The new architecture, will separate the ERF file decoding, and the ERF record -decoding. The ERF records will be decoded with a specific dissector. This -dissector can be configured with options, to replace the environment variable. - -http://bugs.wireshark.org/bugzilla/show_bug.cgi?id=1839 +Indent comments ------------------------------------------------------------------------ -r23093 | gmorris | 2007-10-08 04:50:53 -0700 (Mon, 08 Oct 2007) | 1 line +r29609 | krj | 2009-08-28 21:43:52 -0700 (Fri, 28 Aug 2009) | 1 line Changed paths: - M /trunk/epan/dissectors/ncp2222.py + M /trunk/epan/dissectors/packet-nb_rtpmux.c -Add 0x7d00 Connection Not Logged In return value to NCP 87/34. +We need to handoff even when we don't have a tree ------------------------------------------------------------------------ -r23094 | etxrab | 2007-10-08 08:58:22 -0700 (Mon, 08 Oct 2007) | 1 line +r29610 | krj | 2009-08-28 21:47:28 -0700 (Fri, 28 Aug 2009) | 1 line Changed paths: - M /trunk/epan/dissectors/packet-fix.c - -Register to TCP port 0 to be able to do "decode as". ------------------------------------------------------------------------- -r23095 | morriss | 2007-10-08 10:56:10 -0700 (Mon, 08 Oct 2007) | 1 line -Changed paths: - M /trunk/test/suite-capture.sh + M /trunk/epan/dissectors/packet-nb_rtpmux.c -Temporarily disable 'Capture 10 packets using stdout' test for tshark until we can get that working +Use NB_RTPMUX as protocol short name ------------------------------------------------------------------------ -r23096 | stig | 2007-10-08 12:27:30 -0700 (Mon, 08 Oct 2007) | 2 lines +r29611 | krj | 2009-08-28 22:35:50 -0700 (Fri, 28 Aug 2009) | 1 line Changed paths: - M /trunk/asn1/Makefile.am - -h225, h235 and h248 was moved to new Makefile structure - ------------------------------------------------------------------------- -r23097 | stig | 2007-10-08 12:52:46 -0700 (Mon, 08 Oct 2007) | 2 lines -Changed paths: - M /trunk/configure.in - -h225, h235 and h248 was moved to new Makefile structure + M /trunk/config.nmake +Remove GCC_GLIB_CFLAGS. It isn't being used ------------------------------------------------------------------------ -r23098 | etxrab | 2007-10-08 12:58:35 -0700 (Mon, 08 Oct 2007) | 1 line +r29612 | krj | 2009-08-28 22:39:33 -0700 (Fri, 28 Aug 2009) | 1 line Changed paths: - M /trunk/epan/dissectors/packet-rsl.c + M /trunk/config.nmake -All IE:s handled. +Simplify logic wrt. GTK_INST_VERSION ------------------------------------------------------------------------ -r23099 | stig | 2007-10-08 13:02:20 -0700 (Mon, 08 Oct 2007) | 2 lines +r29613 | krj | 2009-08-28 22:46:45 -0700 (Fri, 28 Aug 2009) | 1 line Changed paths: - M /trunk/asn1/qsig - -Added default svn:ignore targets for qsig. + M /trunk/config.nmake +Simplify logic wrt. PANGO_INST_VERSION ------------------------------------------------------------------------ -r23100 | stig | 2007-10-08 13:10:44 -0700 (Mon, 08 Oct 2007) | 2 lines +r29614 | krj | 2009-08-28 23:42:23 -0700 (Fri, 28 Aug 2009) | 1 line Changed paths: - M /trunk/epan/dissectors/packet-rsl.c - -Added some forgotten return types. + M /trunk/capture-wpcap.c + M /trunk/capture_wpcap_packet.c + M /trunk/epan/dfilter/syntax-tree.h + M /trunk/epan/ftypes/ftype-double.c + M /trunk/epan/proto.c +Use G_STRINGIFY/G_PASTE ------------------------------------------------------------------------ -r23101 | jmayer | 2007-10-08 13:14:07 -0700 (Mon, 08 Oct 2007) | 3 lines +r29615 | krj | 2009-08-29 00:53:48 -0700 (Sat, 29 Aug 2009) | 1 line Changed paths: - M /trunk/asn1/h245 - M /trunk/asn1/nbap - M /trunk/asn1/ranap - M /trunk/asn1/rnsap - M /trunk/asn1/sabp - -Small update to svn:ignore - + M /trunk/capture-wpcap.c + M /trunk/capture_wpcap_packet.c + M /trunk/epan/dfilter/syntax-tree.h + M /trunk/epan/ftypes/ftype-double.c + M /trunk/epan/proto.c +Revert r29614 until I figure out why buildbot doesn't like it ------------------------------------------------------------------------ -r23102 | jmayer | 2007-10-08 16:52:21 -0700 (Mon, 08 Oct 2007) | 3 lines +r29616 | krj | 2009-08-29 01:19:16 -0700 (Sat, 29 Aug 2009) | 1 line Changed paths: - M /trunk/asn1/Makefile.am - M /trunk/asn1/h450 - D /trunk/asn1/h450/Makefile - A /trunk/asn1/h450/Makefile.am (from /trunk/asn1/acse/Makefile.am:23101) - A /trunk/asn1/h450/Makefile.common (from /trunk/asn1/acse/Makefile.common:23101) - R /trunk/asn1/h450/Makefile.nmake (from /trunk/asn1/acse/Makefile.nmake:23101) - D /trunk/asn1/h450/Remote-Operations-Apdus.asn - D /trunk/asn1/h450/h450-ros-exp.cnf - D /trunk/asn1/h450/h450-ros.cnf - M /trunk/asn1/h450/h450.cnf - D /trunk/asn1/h450/packet-h450-ros-template.c - D /trunk/asn1/h450/packet-h450-ros-template.h - A /trunk/asn1/h450-ros - A /trunk/asn1/h450-ros/Makefile.am (from /trunk/asn1/acse/Makefile.am:23101) - A /trunk/asn1/h450-ros/Makefile.common - A /trunk/asn1/h450-ros/Makefile.nmake (from /trunk/asn1/acse/Makefile.nmake:23101) - A /trunk/asn1/h450-ros/Remote-Operations-Apdus.asn (from /trunk/asn1/h450/Remote-Operations-Apdus.asn:23101) - A /trunk/asn1/h450-ros/h450-ros.cnf (from /trunk/asn1/h450/h450-ros.cnf:23101) - A /trunk/asn1/h450-ros/packet-h450-ros-template.c (from /trunk/asn1/h450/packet-h450-ros-template.c:23101) - A /trunk/asn1/h450-ros/packet-h450-ros-template.h (from /trunk/asn1/h450/packet-h450-ros-template.h:23101) - M /trunk/configure.in - -Convert h450 to new Makefile structure. Split h450.ros -out into h450-ros. + M /trunk/Makefile.nmake + M /trunk/capture-wpcap.c + M /trunk/config.h.win32 + M /trunk/config.nmake +We require WinPcap > 3.0 so get rid of WPCAP_CONSTIFIED_CONFIG ------------------------------------------------------------------------ -r23103 | jmayer | 2007-10-08 18:23:21 -0700 (Mon, 08 Oct 2007) | 1 line +r29617 | krj | 2009-08-29 01:44:49 -0700 (Sat, 29 Aug 2009) | 1 line Changed paths: - M /trunk/asn1/h225/Makefile.common + D /trunk/cmake/modules/FindGLIB.cmake -Add some dependencies +We no longer support GLib 1.x ------------------------------------------------------------------------ -r23104 | jmayer | 2007-10-08 18:25:40 -0700 (Mon, 08 Oct 2007) | 3 lines +r29618 | krj | 2009-08-29 02:13:28 -0700 (Sat, 29 Aug 2009) | 1 line Changed paths: - M /trunk/asn1/Makefile.am - M /trunk/asn1/logotype-cert-extn - D /trunk/asn1/logotype-cert-extn/Makefile - A /trunk/asn1/logotype-cert-extn/Makefile.am - A /trunk/asn1/logotype-cert-extn/Makefile.common - M /trunk/asn1/logotype-cert-extn/Makefile.nmake - D /trunk/asn1/logotype-cert-extn/logotype-cert-extn.cnf - A /trunk/asn1/logotype-cert-extn/logotypecertextn.cnf (from /trunk/asn1/logotype-cert-extn/logotype-cert-extn.cnf:23102) - D /trunk/asn1/logotype-cert-extn/packet-logotype-cert-extn-template.c - D /trunk/asn1/logotype-cert-extn/packet-logotype-cert-extn-template.h - A /trunk/asn1/logotype-cert-extn/packet-logotypecertextn-template.c (from /trunk/asn1/logotype-cert-extn/packet-logotype-cert-extn-template.c:23102) - A /trunk/asn1/logotype-cert-extn/packet-logotypecertextn-template.h (from /trunk/asn1/logotype-cert-extn/packet-logotype-cert-extn-template.h:23102) - M /trunk/configure.in - -Convert to new Makefile structure. Rename some files to -use same spelling as generated protocol name. + M /trunk/CMakeLists.txt +Rename build target to lowercase for consistency ------------------------------------------------------------------------ -r23105 | ulfl | 2007-10-08 22:37:34 -0700 (Mon, 08 Oct 2007) | 1 line +r29619 | wmeier | 2009-08-29 10:00:22 -0700 (Sat, 29 Aug 2009) | 3 lines Changed paths: - M /trunk/wiretap/README.developer + M /trunk/gtk/rtp_stream_dlg.c -minor updates ------------------------------------------------------------------------- -r23106 | ulfl | 2007-10-08 22:39:48 -0700 (Mon, 08 Oct 2007) | 2 lines -Changed paths: - M /trunk/plugins/profinet/packet-dcerpc-pn-io.c +Fix potential crash due to NULL dereference. +(Found by clang scan-build) -- add DomainName fields for PDInterfaceMrpDataAdjust and PDInterfaceMrpDataReal -- lower expert info level if AR wasn't found ------------------------------------------------------------------------ -r23107 | ulfl | 2007-10-08 23:55:24 -0700 (Mon, 08 Oct 2007) | 1 line +r29620 | krj | 2009-08-29 23:18:43 -0700 (Sat, 29 Aug 2009) | 1 line Changed paths: - M /trunk/test/README.test + M /trunk/cmake/modules/FindLEX.cmake + M /trunk/cmake/modules/FindSED.cmake + M /trunk/cmake/modules/FindYACC.cmake -alpha -> beta +Fix PATH typo. Should have been PATHS ------------------------------------------------------------------------ -r23108 | kukosa | 2007-10-09 01:50:35 -0700 (Tue, 09 Oct 2007) | 2 lines +r29621 | krj | 2009-08-29 23:24:44 -0700 (Sat, 29 Aug 2009) | 1 line Changed paths: - M /trunk/asn1/h450/Makefile.common - M /trunk/asn1/h450-ros/Makefile.common + M /trunk/CMakeLists.txt -remove rule for $(EXTRA_CNF) as ros/ros-{inv,res,err,rej}.cnf are not generated -minor changes +Add WIN32 platform sources ------------------------------------------------------------------------ -r23109 | martinm | 2007-10-09 04:10:59 -0700 (Tue, 09 Oct 2007) | 2 lines +r29622 | krj | 2009-08-30 00:09:29 -0700 (Sun, 30 Aug 2009) | 1 line Changed paths: - D /trunk/asn1/inap/Makefile - A /trunk/asn1/inap/Makefile.am - A /trunk/asn1/inap/Makefile.common - D /trunk/asn1/ldap/Makefile - A /trunk/asn1/ldap/Makefile.am - A /trunk/asn1/ldap/Makefile.common - -Try to fix the build... + M /trunk/wiretap/CMakeLists.txt + M /trunk/wsutil/CMakeLists.txt +On Windows a shared library in divided into a DLL part (RUNTIME) and an import lib (ARCHIVE). ------------------------------------------------------------------------ -r23110 | morriss | 2007-10-09 06:34:08 -0700 (Tue, 09 Oct 2007) | 1 line +r29623 | krj | 2009-08-30 01:50:47 -0700 (Sun, 30 Aug 2009) | 1 line Changed paths: - M /trunk/test/suite-capture.sh + M /trunk/CMakeLists.txt -As requested on -dev, put the (currently failing) 'Capture 10 packets using stdout' test back in for tshark +Find Win32 bundled packages ------------------------------------------------------------------------ -r23111 | jmayer | 2007-10-09 08:31:16 -0700 (Tue, 09 Oct 2007) | 2 lines +r29624 | krj | 2009-08-30 01:51:43 -0700 (Sun, 30 Aug 2009) | 1 line Changed paths: - M /trunk/asn1/inap/Makefile.common - -Add the missing content... + A /trunk/cmake/modules/FindWSWIN32.cmake +Add new windows cmake module finder ------------------------------------------------------------------------ -r23112 | jmayer | 2007-10-09 08:33:30 -0700 (Tue, 09 Oct 2007) | 3 lines +r29625 | sake | 2009-08-30 03:35:48 -0700 (Sun, 30 Aug 2009) | 3 lines Changed paths: - M /trunk/asn1/inap - M /trunk/asn1/inap/Makefile.nmake + M /trunk/file.h -Somehow I forgot to check in some directories. +Some minor corrections in function descriptions ------------------------------------------------------------------------ -r23113 | jmayer | 2007-10-09 10:58:29 -0700 (Tue, 09 Oct 2007) | 2 lines +r29626 | krj | 2009-08-30 07:12:56 -0700 (Sun, 30 Aug 2009) | 1 line Changed paths: - M /trunk/asn1/Makefile.am - M /trunk/asn1/mms - D /trunk/asn1/mms/Makefile - A /trunk/asn1/mms/Makefile.am - A /trunk/asn1/mms/Makefile.common - M /trunk/asn1/mms/Makefile.nmake - M /trunk/asn1/mpeg - D /trunk/asn1/mpeg/Makefile - A /trunk/asn1/mpeg/Makefile.am - A /trunk/asn1/mpeg/Makefile.common - M /trunk/asn1/mpeg/Makefile.nmake - D /trunk/asn1/mpeg/mpeg-pes.asn - D /trunk/asn1/mpeg/mpeg-pes.cnf - D /trunk/asn1/mpeg/packet-mpeg-pes-template.c - A /trunk/asn1/mpeg-pes - A /trunk/asn1/mpeg-pes/Makefile.am (from /trunk/asn1/acse/Makefile.am:23112) - A /trunk/asn1/mpeg-pes/Makefile.common (from /trunk/asn1/acse/Makefile.common:23112) - A /trunk/asn1/mpeg-pes/Makefile.nmake (from /trunk/asn1/acse/Makefile.nmake:23112) - A /trunk/asn1/mpeg-pes/mpeg-pes.asn (from /trunk/asn1/mpeg/mpeg-pes.asn:23112) - A /trunk/asn1/mpeg-pes/mpeg-pes.cnf (from /trunk/asn1/mpeg/mpeg-pes.cnf:23112) - A /trunk/asn1/mpeg-pes/packet-mpeg-pes-template.c (from /trunk/asn1/mpeg/packet-mpeg-pes-template.c:23112) - M /trunk/configure.in - -More Makefile updates + M /trunk/CMakeLists.txt +Disable standard library deprecation when MSVC >= 2005 ------------------------------------------------------------------------ -r23114 | jmayer | 2007-10-09 10:59:22 -0700 (Tue, 09 Oct 2007) | 3 lines +r29627 | gerald | 2009-08-30 08:03:26 -0700 (Sun, 30 Aug 2009) | 1 line Changed paths: - D /trunk/asn1/mpeg - A /trunk/asn1/mpeg-audio (from /trunk/asn1/mpeg:23113) - -Rename mpeg to mpeg-audio, mpeg-pes got its own -dir already + M /trunk/epan/enterprise-numbers + M /trunk/manuf +[Automatic manuf and enterprise-numbers update for 2009-08-30] ------------------------------------------------------------------------ -r23115 | jmayer | 2007-10-09 11:09:19 -0700 (Tue, 09 Oct 2007) | 2 lines +r29630 | krj | 2009-08-30 08:06:28 -0700 (Sun, 30 Aug 2009) | 1 line Changed paths: - D /trunk/asn1/mpeg-audio/mpeg-audio-exp.cnf - D /trunk/asn1/mpeg-audio/mpeg-pes-exp.cnf - -No generated files please. + M /trunk/ConfigureChecks.cmake +Add a couple of Windows header files ------------------------------------------------------------------------ -r23116 | jmayer | 2007-10-09 11:47:12 -0700 (Tue, 09 Oct 2007) | 2 lines +r29631 | krj | 2009-08-30 10:09:40 -0700 (Sun, 30 Aug 2009) | 1 line Changed paths: - M /trunk/asn1/Makefile.am - M /trunk/asn1/ns-cert-exts - D /trunk/asn1/ns-cert-exts/Makefile - A /trunk/asn1/ns-cert-exts/Makefile.am - A /trunk/asn1/ns-cert-exts/Makefile.common - M /trunk/asn1/ns-cert-exts/Makefile.nmake - M /trunk/asn1/ocsp - D /trunk/asn1/ocsp/Makefile - A /trunk/asn1/ocsp/Makefile.am - A /trunk/asn1/ocsp/Makefile.common - M /trunk/asn1/ocsp/Makefile.nmake - M /trunk/asn1/pkcs1 - D /trunk/asn1/pkcs1/Makefile - A /trunk/asn1/pkcs1/Makefile.am - A /trunk/asn1/pkcs1/Makefile.common - M /trunk/asn1/pkcs1/Makefile.nmake - M /trunk/asn1/pkcs12 - D /trunk/asn1/pkcs12/Makefile - A /trunk/asn1/pkcs12/Makefile.am - A /trunk/asn1/pkcs12/Makefile.common - M /trunk/asn1/pkcs12/Makefile.nmake - M /trunk/asn1/pkinit - D /trunk/asn1/pkinit/Makefile - A /trunk/asn1/pkinit/Makefile.am - A /trunk/asn1/pkinit/Makefile.common - M /trunk/asn1/pkinit/Makefile.nmake - D /trunk/asn1/pkinit/pkinit_exp.cnf - M /trunk/configure.in - -More Makefile conversions + M /trunk/config.h.win32 +Add a couple of comments to HAVE_DIRECT_H, HAVE_WINDOWS_H and HAVE_WINSOCK2_H ------------------------------------------------------------------------ -r23117 | gerald | 2007-10-09 11:48:46 -0700 (Tue, 09 Oct 2007) | 3 lines +r29632 | krj | 2009-08-30 10:23:47 -0700 (Sun, 30 Aug 2009) | 1 line Changed paths: - M /trunk/epan/dissectors/packet-bootp.c - -Add support for RFC 4243. Tested using a malformed packet, but it should be -correct. + M /trunk/config.h.win32 +Remove outdated comments regarding ZLIB_DLL. We don't have to define this before including zlib.h. This is automatically done if _WIN32 is defined ------------------------------------------------------------------------ -r23118 | morriss | 2007-10-09 11:58:34 -0700 (Tue, 09 Oct 2007) | 1 line +r29633 | krj | 2009-08-30 11:30:14 -0700 (Sun, 30 Aug 2009) | 1 line Changed paths: - M /trunk/epan/dissectors/packet-sctp.c - -Replace a (small) for loop with a memset(). Don't memset() the entire sctp_info.tvb array--it contains 2k pointers (8k or 16k of memory)--each time we start dissecting a frame. This speeds up loading a capture file full of SCTP packets by 6-8%. ------------------------------------------------------------------------- -r23119 | jmayer | 2007-10-09 12:19:36 -0700 (Tue, 09 Oct 2007) | 2 lines -Changed paths: - M /trunk/asn1/Makefile.am - M /trunk/asn1/pkix1explicit - D /trunk/asn1/pkix1explicit/Makefile - A /trunk/asn1/pkix1explicit/Makefile.am - A /trunk/asn1/pkix1explicit/Makefile.common - M /trunk/asn1/pkix1explicit/pkix1explicit-exp.cnf - M /trunk/asn1/pkix1implicit - D /trunk/asn1/pkix1implicit/Makefile - A /trunk/asn1/pkix1implicit/Makefile.am - A /trunk/asn1/pkix1implicit/Makefile.common - M /trunk/asn1/pkix1implicit/Makefile.nmake - D /trunk/asn1/pkix1implicit/pkix1implicit-exp.cnf - M /trunk/asn1/pkixcmp - D /trunk/asn1/pkixcmp/Makefile - A /trunk/asn1/pkixcmp/Makefile.am - A /trunk/asn1/pkixcmp/Makefile.common - D /trunk/asn1/pkixcmp/cmp-exp.cnf - M /trunk/asn1/pkixcrmf - D /trunk/asn1/pkixcrmf/Makefile - A /trunk/asn1/pkixcrmf/Makefile.am - A /trunk/asn1/pkixcrmf/Makefile.common - M /trunk/asn1/pkixcrmf/Makefile.nmake - D /trunk/asn1/pkixcrmf/crmf-exp.cnf - M /trunk/asn1/pkixproxy - D /trunk/asn1/pkixproxy/Makefile - A /trunk/asn1/pkixproxy/Makefile.am - A /trunk/asn1/pkixproxy/Makefile.common - M /trunk/asn1/pkixproxy/Makefile.nmake - M /trunk/asn1/pkixqualified - D /trunk/asn1/pkixqualified/Makefile - A /trunk/asn1/pkixqualified/Makefile.am - A /trunk/asn1/pkixqualified/Makefile.common - M /trunk/asn1/pkixqualified/Makefile.nmake - M /trunk/asn1/pkixtsp - D /trunk/asn1/pkixtsp/Makefile - A /trunk/asn1/pkixtsp/Makefile.am - A /trunk/asn1/pkixtsp/Makefile.common - M /trunk/asn1/pkixtsp/Makefile.nmake - M /trunk/asn1/pres - D /trunk/asn1/pres/Makefile - A /trunk/asn1/pres/Makefile.am - A /trunk/asn1/pres/Makefile.common - M /trunk/asn1/pres/Makefile.nmake - M /trunk/configure.in - -Last set of changes to convert Makefiles for today + M /trunk/Makefile.nmake + M /trunk/config.h.win32 + M /trunk/config.nmake +Remove superfluous config parameters ------------------------------------------------------------------------ -r23120 | jmayer | 2007-10-09 12:20:46 -0700 (Tue, 09 Oct 2007) | 2 lines +r29634 | krj | 2009-08-30 11:40:09 -0700 (Sun, 30 Aug 2009) | 1 line Changed paths: - D /trunk/asn1/pkix1explicit/pkix1explicit-exp.cnf - -Don't keep -exp.cnf files in the tree. + M /trunk/capture-pcap-util-int.h +Move config.h include to start of file ------------------------------------------------------------------------ -r23121 | jmayer | 2007-10-09 12:40:59 -0700 (Tue, 09 Oct 2007) | 2 lines +r29635 | krj | 2009-08-31 11:16:16 -0700 (Mon, 31 Aug 2009) | 1 line Changed paths: - M /trunk/asn1/Makefile.inc - M /trunk/asn1/cmip/Makefile.common - -Fix order of external files (without affecting other protos). + M /trunk/gtk/file_dlg_win32.c + M /trunk/wsutil/libwsutil.def + M /trunk/wsutil/unicode-utils.c + M /trunk/wsutil/unicode-utils.h +Add utf_8to16_snprintf() which creates a UTF16 string according to the given format string. The format string + arguments are expected to be in UTF-8 format. This change effectively removes the only place where we use PRIu64. ------------------------------------------------------------------------ -r23122 | guy | 2007-10-09 15:02:39 -0700 (Tue, 09 Oct 2007) | 3 lines +r29636 | krj | 2009-08-31 11:28:10 -0700 (Mon, 31 Aug 2009) | 1 line Changed paths: - M /trunk/asn1/Makefile.nmake - -There isn't an "mpeg" directory, there are "mpeg-audio" and "mpeg-pes" -directories. + M /trunk/doc/README.developer +We don't use PRId64, PRIu64, PRIx64, PRIX64, and PRIo64 internally in Wireshark, so don't encourage people to use them. Use G_GINT64_FORMAT + friends instead. ------------------------------------------------------------------------ -r23123 | guy | 2007-10-09 15:54:29 -0700 (Tue, 09 Oct 2007) | 2 lines +r29637 | etxrab | 2009-08-31 11:37:15 -0700 (Mon, 31 Aug 2009) | 3 lines Changed paths: - M /trunk/asn1/Makefile.inc.nmake - -Just check whether NEED_PACKET_PROTO_H is defined at all. + M /trunk/epan/dissectors/packet-gsm_a_dtap.c +From Gerasimos Dimitriadis: +DTAP decoding of Cause Diagnostics. +https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=3968 ------------------------------------------------------------------------ -r23124 | guy | 2007-10-09 18:31:36 -0700 (Tue, 09 Oct 2007) | 8 lines +r29638 | krj | 2009-08-31 11:38:07 -0700 (Mon, 31 Aug 2009) | 1 line Changed paths: - M /trunk/capture_sync.c - M /trunk/dumpcap.c - -Make the sync pipe the standard error, not the standard output, of -dumpcap, when using it as a capture child; leave the standard output -alone, in case tshark was told to write the capture to the standard -error. - -Get rid of the argument to the "-Z" option to dumpcap; it might not work -on Windows. + M /trunk/config.h.win32 +Remove PRId64, PRIu64, PRIx64, PRIX64, and PRIo64 which are unused ------------------------------------------------------------------------ -r23125 | guy | 2007-10-09 18:34:46 -0700 (Tue, 09 Oct 2007) | 2 lines +r29639 | krj | 2009-08-31 11:48:16 -0700 (Mon, 31 Aug 2009) | 1 line Changed paths: - M /trunk/asn1/ldap - -Set svn:ignore appropriately. + M /trunk/CMakeLists.txt + D /trunk/cmake/modules/Check64BitFormat.c.in + D /trunk/cmake/modules/Check64BitFormat.cmake + M /trunk/cmakeconfig.h.in +CMake: Remove PRId64, PRIu64, PRIx64, PRIX64, and PRIo64 which are unused ------------------------------------------------------------------------ -r23126 | kukosa | 2007-10-10 00:55:36 -0700 (Wed, 10 Oct 2007) | 1 line +r29640 | krj | 2009-08-31 11:59:21 -0700 (Mon, 31 Aug 2009) | 1 line Changed paths: - M /trunk/asn1/h450/Makefile.common - M /trunk/asn1/nbap/Makefile.common - M /trunk/asn1/rnsap/Makefile.common - M /trunk/asn1/rrc/Makefile.common - M /trunk/asn1/rrlp/Makefile.common - M /trunk/asn1/sabp/Makefile.common - M /trunk/asn1/ulp/Makefile.common + M /trunk/config.h.win32 -comment out NEED_PACKET_PROTO_H as it is tested now for defining not for value +Reorder (no functionality change) ------------------------------------------------------------------------ -r23127 | jmayer | 2007-10-10 01:09:19 -0700 (Wed, 10 Oct 2007) | 2 lines +r29641 | tuexen | 2009-08-31 12:13:50 -0700 (Mon, 31 Aug 2009) | 3 lines Changed paths: - M /trunk/asn1/Makefile.am - M /trunk/asn1/Makefile.inc.nmake - M /trunk/asn1/dap/Makefile.common - M /trunk/asn1/dsp/Makefile.common - D /trunk/asn1/h245/h245-exp.cnf - M /trunk/asn1/ldap/Makefile.nmake - D /trunk/asn1/mms/mms-exp.cnf - M /trunk/asn1/q932 - D /trunk/asn1/q932/Facility-Information-Element-Components.asn - D /trunk/asn1/q932/Makefile - A /trunk/asn1/q932/Makefile.am - A /trunk/asn1/q932/Makefile.common - M /trunk/asn1/q932/Makefile.nmake - D /trunk/asn1/q932/packet-q932-ros-template.c - M /trunk/asn1/q932/q932-exp.cnf - D /trunk/asn1/q932/q932-ros.cnf - A /trunk/asn1/q932-ros - A /trunk/asn1/q932-ros/Facility-Information-Element-Components.asn (from /trunk/asn1/q932/Facility-Information-Element-Components.asn:23115) - A /trunk/asn1/q932-ros/Makefile.am (from /trunk/asn1/acse/Makefile.am:23115) - A /trunk/asn1/q932-ros/Makefile.common (from /trunk/asn1/acse/Makefile.common:23115) - A /trunk/asn1/q932-ros/Makefile.nmake (from /trunk/asn1/acse/Makefile.nmake:23115) - A /trunk/asn1/q932-ros/packet-q932-ros-template.c (from /trunk/asn1/q932/packet-q932-ros-template.c:23115) - A /trunk/asn1/q932-ros/q932-ros.cnf (from /trunk/asn1/q932/q932-ros.cnf:23115) - M /trunk/asn1/ros - D /trunk/asn1/ros/Makefile - A /trunk/asn1/ros/Makefile.am - A /trunk/asn1/ros/Makefile.common - M /trunk/asn1/ros/Makefile.nmake - M /trunk/asn1/rtse - D /trunk/asn1/rtse/Makefile - A /trunk/asn1/rtse/Makefile.am - A /trunk/asn1/rtse/Makefile.common - M /trunk/asn1/rtse/Makefile.nmake - M /trunk/asn1/rtse/rtse-exp.cnf - M /trunk/asn1/s4406 - D /trunk/asn1/s4406/Makefile - A /trunk/asn1/s4406/Makefile.am - A /trunk/asn1/s4406/Makefile.common - M /trunk/asn1/s4406/Makefile.nmake - M /trunk/asn1/smrse - D /trunk/asn1/smrse/Makefile - A /trunk/asn1/smrse/Makefile.am - A /trunk/asn1/smrse/Makefile.common - M /trunk/asn1/smrse/Makefile.nmake - M /trunk/asn1/snmp - D /trunk/asn1/snmp/Makefile - A /trunk/asn1/snmp/Makefile.am - A /trunk/asn1/snmp/Makefile.common - M /trunk/asn1/snmp/Makefile.nmake - M /trunk/asn1/snmp/snmp-exp.cnf - M /trunk/asn1/spnego - D /trunk/asn1/spnego/Makefile - A /trunk/asn1/spnego/Makefile.am - A /trunk/asn1/spnego/Makefile.common - M /trunk/asn1/spnego/Makefile.nmake - M /trunk/asn1/t38/Makefile.common - D /trunk/asn1/t38/T38(1998).asn - D /trunk/asn1/t38/T38(2002).asn - A /trunk/asn1/t38/T38_1998.asn (from /trunk/asn1/t38/T38(1998).asn:23115) - A /trunk/asn1/t38/T38_2002.asn (from /trunk/asn1/t38/T38(2002).asn:23115) - M /trunk/configure.in - -More conversions and updates to existing Makefile stuff + M /trunk/dumpcap.c ------------------------------------------------------------------------- -r23128 | kukosa | 2007-10-10 01:14:36 -0700 (Wed, 10 Oct 2007) | 2 lines -Changed paths: - M /trunk/asn1/h225/Makefile.am - M /trunk/asn1/h225/Makefile.common - M /trunk/asn1/h225/Makefile.nmake +Use a timeout of a second for Mac OS X, when building +a 64-bit application. Workaround a bug in Mac OS X... -solution for different submake calling on Windows and Linux -only one dissector is committed to test it ------------------------------------------------------------------------ -r23129 | jmayer | 2007-10-10 01:37:30 -0700 (Wed, 10 Oct 2007) | 1 line +r29642 | etxrab | 2009-08-31 12:31:04 -0700 (Mon, 31 Aug 2009) | 1 line Changed paths: - M /trunk/asn1/q932-ros/Makefile.common + M /trunk/gtk/main.c -Undefine NEED_PACKET_PROTO_H +Connect F7 and F8 for new_packet_list. ------------------------------------------------------------------------ -r23130 | kukosa | 2007-10-10 01:42:19 -0700 (Wed, 10 Oct 2007) | 1 line +r29643 | krj | 2009-08-31 12:47:50 -0700 (Mon, 31 Aug 2009) | 1 line Changed paths: - M /trunk/asn1/Makefile.inc - M /trunk/asn1/Makefile.inc.nmake - M /trunk/asn1/h225/Makefile.am - M /trunk/asn1/h225/Makefile.common - M /trunk/asn1/h225/Makefile.nmake - M /trunk/asn1/h245/Makefile.common - -next step to solve dependency generation ------------------------------------------------------------------------- -r23131 | kukosa | 2007-10-10 03:25:09 -0700 (Wed, 10 Oct 2007) | 2 lines -Changed paths: - A /trunk/asn1/Makefile.preinc - A /trunk/asn1/Makefile.preinc.nmake - M /trunk/asn1/h225/Makefile.am - M /trunk/asn1/h225/Makefile.nmake - M /trunk/asn1/h245/Makefile.am - M /trunk/asn1/h245/Makefile.nmake - -better solution for different submake calling on Windows and Linux - ------------------------------------------------------------------------- -r23132 | kukosa | 2007-10-10 03:56:17 -0700 (Wed, 10 Oct 2007) | 1 line -Changed paths: - M /trunk/asn1/h235/Makefile.am - M /trunk/asn1/h235/Makefile.common - M /trunk/asn1/h235/Makefile.nmake - M /trunk/asn1/h450/Makefile.am - M /trunk/asn1/h450/Makefile.common - M /trunk/asn1/h450/Makefile.nmake - M /trunk/asn1/h450-ros/Makefile.am - M /trunk/asn1/h450-ros/Makefile.common - M /trunk/asn1/h450-ros/Makefile.nmake - M /trunk/asn1/q932/Makefile.am - M /trunk/asn1/q932/Makefile.common - M /trunk/asn1/q932/Makefile.nmake - M /trunk/asn1/q932-ros/Makefile.am - M /trunk/asn1/q932-ros/Makefile.common - M /trunk/asn1/q932-ros/Makefile.nmake - M /trunk/asn1/qsig/Makefile.am - M /trunk/asn1/qsig/Makefile.common - M /trunk/asn1/qsig/Makefile.nmake - -more makefiles changed to new export mechanism ------------------------------------------------------------------------- -r23133 | kukosa | 2007-10-10 04:05:10 -0700 (Wed, 10 Oct 2007) | 1 line -Changed paths: - M /trunk/asn1/dsp/Makefile.common - -missing backslash ------------------------------------------------------------------------- -r23134 | jmayer | 2007-10-10 05:06:30 -0700 (Wed, 10 Oct 2007) | 3 lines -Changed paths: - M /trunk/asn1/Makefile.am - M /trunk/asn1/tcap - D /trunk/asn1/tcap/DialoguePDUs.asn - D /trunk/asn1/tcap/Makefile - A /trunk/asn1/tcap/Makefile.am - A /trunk/asn1/tcap/Makefile.common - M /trunk/asn1/tcap/Makefile.nmake - D /trunk/asn1/tcap/TC-Notation-Extensions.asn - D /trunk/asn1/tcap/TCAP-Remote-Operations-Information-Objects.asn - D /trunk/asn1/tcap/TCAPMessages.asn - D /trunk/asn1/tcap/TCAPPackage.asn - D /trunk/asn1/tcap/UnidialoguePDUs.asn - D /trunk/asn1/tcap/ansi_tcap.cnf - D /trunk/asn1/tcap/packet-ansi_tcap-template.c - D /trunk/asn1/tcap/packet-ansi_tcap-template.h - A /trunk/asn1/tcap_ansi - A /trunk/asn1/tcap_ansi/DialoguePDUs.asn (from /trunk/asn1/tcap/DialoguePDUs.asn:23133) - A /trunk/asn1/tcap_ansi/Makefile.common (from /trunk/asn1/acse/Makefile.common:23133) - A /trunk/asn1/tcap_ansi/Makefile.nmake (from /trunk/asn1/acse/Makefile.nmake:23133) - A /trunk/asn1/tcap_ansi/TC-Notation-Extensions.asn (from /trunk/asn1/tcap/TC-Notation-Extensions.asn:23133) - A /trunk/asn1/tcap_ansi/TCAP-Remote-Operations-Information-Objects.asn (from /trunk/asn1/tcap/TCAP-Remote-Operations-Information-Objects.asn:23133) - A /trunk/asn1/tcap_ansi/TCAPMessages.asn (from /trunk/asn1/tcap/TCAPMessages.asn:23133) - A /trunk/asn1/tcap_ansi/TCAPPackage.asn (from /trunk/asn1/tcap/TCAPPackage.asn:23133) - A /trunk/asn1/tcap_ansi/UnidialoguePDUs.asn (from /trunk/asn1/tcap/UnidialoguePDUs.asn:23133) - A /trunk/asn1/tcap_ansi/ansi_tcap.cnf (from /trunk/asn1/tcap/ansi_tcap.cnf:23133) - A /trunk/asn1/tcap_ansi/packet-ansi_tcap-template.c (from /trunk/asn1/tcap/packet-ansi_tcap-template.c:23133) - A /trunk/asn1/tcap_ansi/packet-ansi_tcap-template.h (from /trunk/asn1/tcap/packet-ansi_tcap-template.h:23133) + M /trunk/Makefile.am + M /trunk/Makefile.common + M /trunk/config.h.win32 M /trunk/configure.in + M /trunk/debian/copyright + M /trunk/packaging/macosx/native-gtk/config.h + D /trunk/strcasecmp.c -Split tcap into tcap and ansi-tcap. Just assume that all the -extra asn files belong to ansi-tcap. - ------------------------------------------------------------------------- -r23135 | jmayer | 2007-10-10 05:07:49 -0700 (Wed, 10 Oct 2007) | 1 line -Changed paths: - A /trunk/asn1/tcap_ansi/Makefile.am (from /trunk/asn1/acse/Makefile.am:23133) - -Missed a file ------------------------------------------------------------------------- -r23136 | jmayer | 2007-10-10 05:09:19 -0700 (Wed, 10 Oct 2007) | 2 lines -Changed paths: - A /trunk/asn1/ansi-tcap (from /trunk/asn1/tcap_ansi:23134) - A /trunk/asn1/ansi-tcap/Makefile.am (from /trunk/asn1/tcap_ansi/Makefile.am:23135) - D /trunk/asn1/tcap_ansi - -You cannot rename a new directory unless checked in. - +Remove strcasecmp. We use g_ascii_strcasecmp exclusively ------------------------------------------------------------------------ -r23137 | wmeier | 2007-10-10 08:56:02 -0700 (Wed, 10 Oct 2007) | 2 lines +r29644 | jmayer | 2009-08-31 15:34:25 -0700 (Mon, 31 Aug 2009) | 5 lines Changed paths: - M /trunk/asn1/Makefile.am - M /trunk/configure.in - -Fix two typos: ansi_tcap --> ansi-tcap - ------------------------------------------------------------------------- -r23138 | jmayer | 2007-10-10 10:57:33 -0700 (Wed, 10 Oct 2007) | 4 lines -Changed paths: - M /trunk/asn1/Makefile.am - M /trunk/asn1/wlancertextn - D /trunk/asn1/wlancertextn/Makefile - A /trunk/asn1/wlancertextn/Makefile.am - A /trunk/asn1/wlancertextn/Makefile.common - M /trunk/asn1/wlancertextn/Makefile.nmake - M /trunk/asn1/x411 - D /trunk/asn1/x411/Makefile - A /trunk/asn1/x411/Makefile.am - A /trunk/asn1/x411/Makefile.common - M /trunk/asn1/x411/Makefile.nmake - M /trunk/asn1/x420 - D /trunk/asn1/x420/Makefile - A /trunk/asn1/x420/Makefile.am - A /trunk/asn1/x420/Makefile.common - M /trunk/asn1/x420/Makefile.nmake - D /trunk/asn1/x420/x420-exp.cnf - M /trunk/asn1/x509af - D /trunk/asn1/x509af/Makefile - A /trunk/asn1/x509af/Makefile.am - A /trunk/asn1/x509af/Makefile.common - M /trunk/asn1/x509af/Makefile.nmake - D /trunk/asn1/x509af/x509af-exp.cnf - M /trunk/asn1/x509ce - D /trunk/asn1/x509ce/Makefile - A /trunk/asn1/x509ce/Makefile.am - A /trunk/asn1/x509ce/Makefile.common - M /trunk/asn1/x509ce/Makefile.nmake - D /trunk/asn1/x509ce/x509ce-exp.cnf - M /trunk/asn1/x509if - D /trunk/asn1/x509if/Makefile - A /trunk/asn1/x509if/Makefile.am - A /trunk/asn1/x509if/Makefile.common - M /trunk/asn1/x509if/Makefile.nmake - D /trunk/asn1/x509if/x509if-exp.cnf - M /trunk/asn1/x509sat - D /trunk/asn1/x509sat/Makefile - A /trunk/asn1/x509sat/Makefile.am - A /trunk/asn1/x509sat/Makefile.common - M /trunk/asn1/x509sat/Makefile.nmake - D /trunk/asn1/x509sat/x509sat-exp.cnf - M /trunk/asn1/x721 - A /trunk/asn1/x721/Makefile.am - A /trunk/asn1/x721/Makefile.common - M /trunk/configure.in + M /trunk/epan/dissectors/packet-ip.c -Finish conversion (well, almost, need to add the -generation stuff to the x.../Makefile.common. -I love circular dependencies. +- Fix for bug 3965 as reported by Ivan Sy <ivan_jr@yahoo.com> + mDNS and LLMNR also deviate from the TTL=1 for 224.0.0.0/24 ------------------------------------------------------------------------- -r23139 | jmayer | 2007-10-10 10:59:01 -0700 (Wed, 10 Oct 2007) | 2 lines -Changed paths: - D /trunk/asn1/qsig/qsig-exp.cnf - -Another -exp.cnf file that managed to escape notice... +- Fix two warnings about removing const by casting. ------------------------------------------------------------------------ -r23140 | ulfl | 2007-10-10 11:33:21 -0700 (Wed, 10 Oct 2007) | 1 line -Changed paths: - M /trunk/plugins/profinet/packet-dcerpc-pn-io.c - -add FSParameterBlock and ARFSUDataAdjust blocks ------------------------------------------------------------------------- -r23141 | jmayer | 2007-10-10 12:03:24 -0700 (Wed, 10 Oct 2007) | 3 lines -Changed paths: - M /trunk/asn1/Makefile.nmake - M /trunk/asn1/acp133/Makefile.am - M /trunk/asn1/acp133/Makefile.nmake - M /trunk/asn1/acse/Makefile.am - M /trunk/asn1/acse/Makefile.nmake - M /trunk/asn1/ansi-tcap/Makefile.am - M /trunk/asn1/ansi-tcap/Makefile.nmake - M /trunk/asn1/ansi_map/Makefile.am - M /trunk/asn1/ansi_map/Makefile.nmake - M /trunk/asn1/camel/Makefile.am - M /trunk/asn1/camel/Makefile.nmake - M /trunk/asn1/cdt/Makefile.am - M /trunk/asn1/cdt/Makefile.nmake - M /trunk/asn1/cmip/Makefile.am - M /trunk/asn1/cmip/Makefile.nmake - M /trunk/asn1/cms/Makefile.am - M /trunk/asn1/cms/Makefile.nmake - M /trunk/asn1/dap/Makefile.am - M /trunk/asn1/dap/Makefile.nmake - M /trunk/asn1/disp/Makefile.am - M /trunk/asn1/disp/Makefile.nmake - M /trunk/asn1/dop/Makefile.am - M /trunk/asn1/dop/Makefile.nmake - M /trunk/asn1/dsp/Makefile.am - M /trunk/asn1/dsp/Makefile.nmake - M /trunk/asn1/ess/Makefile.am - M /trunk/asn1/ess/Makefile.nmake - M /trunk/asn1/ftam/Makefile.am - M /trunk/asn1/ftam/Makefile.nmake - M /trunk/asn1/gnm/Makefile.am - M /trunk/asn1/gnm/Makefile.nmake - M /trunk/asn1/gsmmap/Makefile.am - M /trunk/asn1/gsmmap/Makefile.nmake - M /trunk/asn1/h248/Makefile.am - M /trunk/asn1/h248/Makefile.nmake - M /trunk/asn1/h450/Makefile.nmake - M /trunk/asn1/inap/Makefile.am - M /trunk/asn1/inap/Makefile.nmake - M /trunk/asn1/ldap/Makefile.am - M /trunk/asn1/ldap/Makefile.nmake - M /trunk/asn1/logotype-cert-extn/Makefile.am - M /trunk/asn1/logotype-cert-extn/Makefile.nmake - M /trunk/asn1/mms/Makefile.am - M /trunk/asn1/mms/Makefile.nmake - M /trunk/asn1/mpeg-audio/Makefile.am - M /trunk/asn1/mpeg-audio/Makefile.nmake - M /trunk/asn1/mpeg-pes/Makefile.am - M /trunk/asn1/mpeg-pes/Makefile.nmake - M /trunk/asn1/nbap/Makefile.am - M /trunk/asn1/nbap/Makefile.nmake - M /trunk/asn1/ns-cert-exts/Makefile.am - M /trunk/asn1/ns-cert-exts/Makefile.nmake - M /trunk/asn1/ocsp/Makefile.am - M /trunk/asn1/ocsp/Makefile.nmake - M /trunk/asn1/pkcs1/Makefile.am - M /trunk/asn1/pkcs1/Makefile.nmake - M /trunk/asn1/pkcs12/Makefile.am - M /trunk/asn1/pkcs12/Makefile.nmake - M /trunk/asn1/pkinit/Makefile.am - M /trunk/asn1/pkinit/Makefile.nmake - M /trunk/asn1/pkix1explicit/Makefile.am - M /trunk/asn1/pkix1explicit/Makefile.nmake - M /trunk/asn1/pkix1implicit/Makefile.am - M /trunk/asn1/pkix1implicit/Makefile.nmake - M /trunk/asn1/pkixcmp/Makefile.am - M /trunk/asn1/pkixcmp/Makefile.nmake - M /trunk/asn1/pkixcrmf/Makefile.am - M /trunk/asn1/pkixcrmf/Makefile.nmake - M /trunk/asn1/pkixproxy/Makefile.am - M /trunk/asn1/pkixproxy/Makefile.nmake - M /trunk/asn1/pkixqualified/Makefile.am - M /trunk/asn1/pkixqualified/Makefile.nmake - M /trunk/asn1/pkixtsp/Makefile.am - M /trunk/asn1/pkixtsp/Makefile.nmake - M /trunk/asn1/pres/Makefile.am - M /trunk/asn1/pres/Makefile.nmake - M /trunk/asn1/ranap/Makefile.am - M /trunk/asn1/ranap/Makefile.nmake - M /trunk/asn1/rnsap/Makefile.am - M /trunk/asn1/rnsap/Makefile.nmake - M /trunk/asn1/ros/Makefile.am - M /trunk/asn1/ros/Makefile.nmake - M /trunk/asn1/rrc/Makefile.am - M /trunk/asn1/rrc/Makefile.nmake - M /trunk/asn1/rrlp/Makefile.am - M /trunk/asn1/rrlp/Makefile.nmake - M /trunk/asn1/rtse/Makefile.am - M /trunk/asn1/rtse/Makefile.nmake - M /trunk/asn1/s4406/Makefile.am - M /trunk/asn1/s4406/Makefile.nmake - M /trunk/asn1/sabp/Makefile.am - M /trunk/asn1/sabp/Makefile.nmake - M /trunk/asn1/smrse/Makefile.am - M /trunk/asn1/smrse/Makefile.nmake - M /trunk/asn1/snmp/Makefile.am - M /trunk/asn1/snmp/Makefile.nmake - M /trunk/asn1/spnego/Makefile.am - M /trunk/asn1/spnego/Makefile.nmake - M /trunk/asn1/t38/Makefile.am - M /trunk/asn1/t38/Makefile.nmake - M /trunk/asn1/tcap/Makefile.am - M /trunk/asn1/tcap/Makefile.nmake - M /trunk/asn1/ulp/Makefile.am - M /trunk/asn1/ulp/Makefile.nmake - M /trunk/asn1/wlancertextn/Makefile.am - M /trunk/asn1/wlancertextn/Makefile.nmake - M /trunk/asn1/x411/Makefile.am - M /trunk/asn1/x411/Makefile.nmake - M /trunk/asn1/x420/Makefile.am - M /trunk/asn1/x420/Makefile.nmake - M /trunk/asn1/x509af/Makefile.am - M /trunk/asn1/x509af/Makefile.nmake - M /trunk/asn1/x509ce/Makefile.am - M /trunk/asn1/x509ce/Makefile.nmake - M /trunk/asn1/x509if/Makefile.am - M /trunk/asn1/x509if/Makefile.nmake - M /trunk/asn1/x509sat/Makefile.am - M /trunk/asn1/x509sat/Makefile.nmake - M /trunk/asn1/x721/Makefile.am - -- Change Makefiles to include preinc -- Add missing new directories to asn1/Makefile.nmake - ------------------------------------------------------------------------- -r23142 | wmeier | 2007-10-10 13:47:36 -0700 (Wed, 10 Oct 2007) | 2 lines -Changed paths: - M /trunk/tools/win32-setup.sh - -Improve error msg when libraries out of date. - ------------------------------------------------------------------------- -r23143 | jmayer | 2007-10-10 15:26:40 -0700 (Wed, 10 Oct 2007) | 2 lines -Changed paths: - M /trunk/asn1/acp133/Makefile.common - M /trunk/asn1/acse/Makefile.common - M /trunk/asn1/ansi_map/Makefile.common - M /trunk/asn1/camel/Makefile.common - M /trunk/asn1/cmip/Makefile.common - M /trunk/asn1/cms/Makefile.common - M /trunk/asn1/dap/Makefile.common - M /trunk/asn1/disp/Makefile.common - M /trunk/asn1/dop/Makefile.common - M /trunk/asn1/dsp/Makefile.common - M /trunk/asn1/ess/Makefile.common - M /trunk/asn1/ftam/Makefile.common - M /trunk/asn1/gnm/Makefile.common - M /trunk/asn1/logotype-cert-extn/Makefile.common - M /trunk/asn1/mms/Makefile.common - M /trunk/asn1/ocsp/Makefile.common - M /trunk/asn1/pkcs1/Makefile.common - M /trunk/asn1/pkcs12/Makefile.common - M /trunk/asn1/pkinit/Makefile.common - M /trunk/asn1/pkix1implicit/Makefile.common - M /trunk/asn1/pkixcmp/Makefile.common - M /trunk/asn1/pkixcrmf/Makefile.common - M /trunk/asn1/pkixqualified/Makefile.common - M /trunk/asn1/pkixtsp/Makefile.common - M /trunk/asn1/pres/Makefile.common - M /trunk/asn1/s4406/Makefile.common - M /trunk/asn1/x411/Makefile.common - M /trunk/asn1/x420/Makefile.common - M /trunk/asn1/x509af/Makefile.common - M /trunk/asn1/x509ce/Makefile.common - M /trunk/asn1/x509if/Makefile.common - M /trunk/asn1/x509sat/Makefile.common - -Add missing dependencies and update syntax of existing ones. - ------------------------------------------------------------------------- -r23144 | wmeier | 2007-10-10 18:24:36 -0700 (Wed, 10 Oct 2007) | 2 lines +r29645 | jmayer | 2009-08-31 16:11:52 -0700 (Mon, 31 Aug 2009) | 3 lines Changed paths: - M /trunk/Makefile.nmake - -fix 'nmake ... clean' to include dumpcap specific objects - ------------------------------------------------------------------------- -r23145 | jmayer | 2007-10-10 22:27:27 -0700 (Wed, 10 Oct 2007) | 3 lines -Changed paths: - M /trunk/asn1/acp133/Makefile.common - M /trunk/asn1/acse/Makefile.common - M /trunk/asn1/ansi-tcap/Makefile.common - M /trunk/asn1/ansi_map/Makefile.common - M /trunk/asn1/camel/Makefile.common - M /trunk/asn1/cdt/Makefile.common - M /trunk/asn1/cmip/Makefile.common - M /trunk/asn1/cms/Makefile.common - M /trunk/asn1/dap/Makefile.common - M /trunk/asn1/disp/Makefile.common - M /trunk/asn1/dop/Makefile.common - M /trunk/asn1/dsp/Makefile.common - M /trunk/asn1/ess/Makefile.common - M /trunk/asn1/ftam/Makefile.common - M /trunk/asn1/gnm/Makefile.common - M /trunk/asn1/gsmmap/Makefile.common - M /trunk/asn1/h248/Makefile.common - M /trunk/asn1/inap/Makefile.common - M /trunk/asn1/ldap/Makefile.common - M /trunk/asn1/logotype-cert-extn/Makefile.common - M /trunk/asn1/mms/Makefile.common - M /trunk/asn1/mpeg-audio/Makefile.common - M /trunk/asn1/mpeg-pes/Makefile.common - M /trunk/asn1/ns-cert-exts/Makefile.common - M /trunk/asn1/ocsp/Makefile.common - M /trunk/asn1/pkinit/Makefile.common - M /trunk/asn1/pkix1explicit/Makefile.common - M /trunk/asn1/pkix1implicit/Makefile.common - M /trunk/asn1/pkixcmp/Makefile.common - M /trunk/asn1/pkixcrmf/Makefile.common - M /trunk/asn1/pkixproxy/Makefile.common - M /trunk/asn1/pkixqualified/Makefile.common - M /trunk/asn1/pkixtsp/Makefile.common - M /trunk/asn1/pres/Makefile.common - M /trunk/asn1/q932/Makefile.common - M /trunk/asn1/qsig/Makefile.common - M /trunk/asn1/ros/Makefile.common - M /trunk/asn1/rtse/Makefile.common - M /trunk/asn1/s4406/Makefile.common - M /trunk/asn1/smrse/Makefile.common - M /trunk/asn1/snmp/Makefile.common - M /trunk/asn1/spnego/Makefile.common - M /trunk/asn1/tcap/Makefile.common - M /trunk/asn1/wlancertextn/Makefile.common - M /trunk/asn1/x411/Makefile.common - M /trunk/asn1/x420/Makefile.common - M /trunk/asn1/x509af/Makefile.common - M /trunk/asn1/x509ce/Makefile.common - M /trunk/asn1/x509if/Makefile.common - M /trunk/asn1/x509sat/Makefile.common - -- Remove -e option if the generated -exp.cnf file isn't used. -- Add EXPORT_FILES to all files that still contain -e. - ------------------------------------------------------------------------- -r23146 | kukosa | 2007-10-11 07:48:12 -0700 (Thu, 11 Oct 2007) | 1 line -Changed paths: - M /trunk/tools/asn2wrs.py - -put only file basename into #line directives ------------------------------------------------------------------------- -r23147 | wmeier | 2007-10-11 09:40:12 -0700 (Thu, 11 Oct 2007) | 2 lines -Changed paths: - M /trunk/epan/dissectors/packet-netflow.c - -From Andrew feren; Fix typos in two comments .... + M /trunk/ConfigureChecks.cmake + M /trunk/cmakeconfig.h.in ------------------------------------------------------------------------- -r23148 | jmayer | 2007-10-11 10:56:24 -0700 (Thu, 11 Oct 2007) | 1 line -Changed paths: - D /trunk/asn1/h235/h235-exp.cnf - D /trunk/asn1/q932/q932-exp.cnf - D /trunk/asn1/ranap/ranap-exp.cnf - D /trunk/asn1/ros/ros-exp.cnf - D /trunk/asn1/rtse/rtse-exp.cnf - D /trunk/asn1/snmp/snmp-exp.cnf - D /trunk/asn1/x411/x411-exp.cnf +Add check for HAVE_MKSTEMP to make build work again on +platforms that know about mkstemp(). -Remove the remaining autogenereated -exp.cnf files ------------------------------------------------------------------------ -r23149 | jake | 2007-10-11 12:40:58 -0700 (Thu, 11 Oct 2007) | 1 line +r29646 | etxrab | 2009-08-31 22:19:24 -0700 (Mon, 31 Aug 2009) | 1 line Changed paths: - M /trunk/epan/value_string.c + M /trunk/gtk/main_proto_draw.c -Allow for dynamic value string array selection. +Don't bother with a progress dialog for small Hex windows. ------------------------------------------------------------------------ -r23150 | etxrab | 2007-10-11 14:23:14 -0700 (Thu, 11 Oct 2007) | 1 line +r29647 | etxrab | 2009-09-01 00:29:16 -0700 (Tue, 01 Sep 2009) | 1 line Changed paths: - M /trunk/epan/dissectors/packet-gprs-llc.c - M /trunk/epan/dissectors/packet-h263.c - M /trunk/epan/dissectors/packet-isup.c - M /trunk/epan/dissectors/packet-megaco.c - M /trunk/epan/dissectors/packet-sip.c - M /trunk/epan/dissectors/packet-tpkt.c - M /trunk/epan/dissectors/packet-uma.c + M /trunk/gtk/main_proto_draw.c -Implement some of the minor possible speed improvment patches. +Typo ------------------------------------------------------------------------ -r23151 | stig | 2007-10-11 15:04:32 -0700 (Thu, 11 Oct 2007) | 2 lines +r29648 | etxrab | 2009-09-01 01:51:41 -0700 (Tue, 01 Sep 2009) | 5 lines Changed paths: - M /trunk/epan/dissectors/packet-bgp.c - -Swapped block-size and block-offset in BGP VPLS NLRI - fixes bug 1907. + M /trunk/file.c +- Read a min number if packets before checking if the progress bar should be updated. +- Calculate the progess before checking if progress bar should be +created or not. +- Dont update the progress to often on small files. +- Use data_offset rather than reading file_pos. ------------------------------------------------------------------------ -r23152 | wmeier | 2007-10-11 15:07:55 -0700 (Thu, 11 Oct 2007) | 2 lines +r29649 | tuexen | 2009-09-01 03:12:27 -0700 (Tue, 01 Sep 2009) | 2 lines Changed paths: - M /trunk/wiretap/ascend.c + M /trunk/gtk/sctp_assoc_analyse.c + M /trunk/gtk/sctp_error_dlg.c + M /trunk/gtk/sctp_stat_dlg.c -Tighten up heuristic used to identify Ascend capture file.... +From Irene Ruengeler: Get rid of legacy gtk code... ------------------------------------------------------------------------ -r23153 | stig | 2007-10-11 15:19:38 -0700 (Thu, 11 Oct 2007) | 4 lines +r29650 | tuexen | 2009-09-01 03:29:17 -0700 (Tue, 01 Sep 2009) | 3 lines Changed paths: - M /trunk/epan/dissectors/packet-sflow.c + M /trunk/gtk/sctp_assoc_analyse.c -From Andrew Feren: -Add preference to allow user to configure the port(s) to use when identifying -sFlow. +Out with debug output... ------------------------------------------------------------------------- -r23154 | morriss | 2007-10-11 15:49:52 -0700 (Thu, 11 Oct 2007) | 1 line -Changed paths: - M /trunk/asn1/tcap/packet-tcap-template.c - M /trunk/epan/dissectors/packet-tcap.c -Display TCAP parameter lengths in decimal (like packet-ber does). Fix hex-pane byte highlighting for primitive parameters with tags or lengths longer than 1 octet (contructed ones are OK). Finally, fix up the indenting in this function. ------------------------------------------------------------------------ -r23155 | jmayer | 2007-10-11 16:21:51 -0700 (Thu, 11 Oct 2007) | 2 lines +r29651 | martinm | 2009-09-01 04:15:24 -0700 (Tue, 01 Sep 2009) | 2 lines Changed paths: - M /trunk/tools/asn2wrs.py + M /trunk/file.c -Remove path at two more places from the output +Add volatile to avoid clobbered by longjmp warning. ------------------------------------------------------------------------ -r23156 | martinm | 2007-10-12 02:59:10 -0700 (Fri, 12 Oct 2007) | 2 lines +r29652 | krj | 2009-09-01 08:54:53 -0700 (Tue, 01 Sep 2009) | 1 line Changed paths: - M /trunk/plugins/wimaxasncp/ChangeLog - M /trunk/plugins/wimaxasncp/Makefile.am - M /trunk/plugins/wimaxasncp/Makefile.common - A /trunk/plugins/wimaxasncp/dictionary.dtd - A /trunk/plugins/wimaxasncp/dictionary.xml - M /trunk/plugins/wimaxasncp/packet-wimaxasncp.c - A /trunk/plugins/wimaxasncp/wimaxasncp_dict.l - -TLVs now defined in XML (from Stephen Croll). + M /trunk/gtk/packet_list_store.c +Plug memleak in new_packet_list_store_clear(). Make sure that we free the pointer array segment ------------------------------------------------------------------------ -r23157 | martinm | 2007-10-12 03:01:41 -0700 (Fri, 12 Oct 2007) | 3 lines +r29653 | krj | 2009-09-01 09:00:56 -0700 (Tue, 01 Sep 2009) | 4 lines Changed paths: - M /trunk/packaging/nsis/wireshark.nsi - -Install wimaxasncp TLV definition files (untested). -Q: are the plugins unconditionally installed by the win32 installer? i.e. should the installation of these files be conditional? + M /trunk/gtk/new_packet_list.c + M /trunk/gtk/packet_list_store.h ------------------------------------------------------------------------- -r23158 | martinm | 2007-10-12 03:44:49 -0700 (Fri, 12 Oct 2007) | 2 lines -Changed paths: - A /trunk/plugins/wimaxasncp/wimaxasncp_dict.h +We no longer store the column text in our record, so don't ever dereference the record column text pointer. In fact, remove it completely. This could cause a crash. -Add missing file. +While there, throw in a few g_assert()'s. ------------------------------------------------------------------------ -r23159 | martinm | 2007-10-12 04:13:59 -0700 (Fri, 12 Oct 2007) | 2 lines +r29654 | krj | 2009-09-01 10:09:36 -0700 (Tue, 01 Sep 2009) | 4 lines Changed paths: - M /trunk/packaging/u3/win32/makefile.nmake - -Also add wimaxasncp TLV desription files to U3 build. + M /trunk/epan/proto.c + M /trunk/gtk/menus.c + M /trunk/print.c ------------------------------------------------------------------------- -r23160 | martinm | 2007-10-12 05:26:38 -0700 (Fri, 12 Oct 2007) | 2 lines -Changed paths: - M /trunk/plugins/wimaxasncp/Makefile.common +From Richard Brodie via. Bug 3913: -Added missing header file for distcheck. +Free ptr array allocated through proto_find_finfo() ------------------------------------------------------------------------ -r23161 | martinm | 2007-10-12 06:29:54 -0700 (Fri, 12 Oct 2007) | 2 lines +r29655 | wmeier | 2009-09-01 10:17:14 -0700 (Tue, 01 Sep 2009) | 7 lines Changed paths: - M /trunk/plugins/wimaxasncp/Makefile.am + M /trunk/epan/dissectors/packet-3g-a11.c -Try to fix distcheck. Is this change appropriate? +Misc cleanup; +- Remove no longer needed usage of check_col(); +- Add some defensive coding; +- Change a few guints to gints; +- Add parentheses to a few expressions; +- Use consistent indentation. ------------------------------------------------------------------------ -r23162 | martinm | 2007-10-12 08:00:20 -0700 (Fri, 12 Oct 2007) | 2 lines +r29656 | krj | 2009-09-01 11:16:55 -0700 (Tue, 01 Sep 2009) | 12 lines Changed paths: - M /trunk/plugins/wimaxasncp/Makefile.nmake + M /trunk/epan/addr_resolv.c + M /trunk/epan/dfilter/dfilter.c + M /trunk/epan/proto.c + M /trunk/gtk/filter_dlg.c -Add targets for lex compilation. +From Jakub Zawadzki via. Bug 3330: ------------------------------------------------------------------------- -r23163 | morriss | 2007-10-12 08:41:53 -0700 (Fri, 12 Oct 2007) | 1 line -Changed paths: - M /trunk/plugins/ciscosm/packet-sm.c +* Fix memleak (df->deprecated in dfilter_free()) +* Free protocol hash tables on cleanup. +* Free protocols list on cleanup. +* Free memory allocated by fgetline() in parse_services_file() -Fix hex-pane byte highlighting for the PDU message type item ------------------------------------------------------------------------- -r23164 | martinm | 2007-10-12 09:51:42 -0700 (Fri, 12 Oct 2007) | 3 lines -Changed paths: - M /trunk/plugins/wimaxasncp/Makefile.nmake +From me: -Another blind attempt to fix the Windows buildbot. -Could someone please review this (I'm leaving for the day soon)? +* proto.c: set gmc_hfinfo to NULL after free +* proto.c: switch order of g_free() and g_list_remove() in proto_cleanup() ------------------------------------------------------------------------ -r23165 | gerald | 2007-10-12 11:26:47 -0700 (Fri, 12 Oct 2007) | 4 lines +r29657 | etxrab | 2009-09-01 11:29:11 -0700 (Tue, 01 Sep 2009) | 1 line Changed paths: - M /trunk/plugins/wimaxasncp/Makefile.nmake - M /trunk/plugins/wimaxasncp/wimaxasncp_dict.l - -Fix wimaxasncp compilation under Windows. Rename a macro that's defined -by the platform SDK, cast an int, and use the top-level Makefile.nmake.inc -to build wimaxasncp_dict.{c|obj}. + M /trunk/gtk/new_packet_list.c +In new_packet_list_append() all we need is in fdata. ------------------------------------------------------------------------ -r23166 | stig | 2007-10-12 12:13:31 -0700 (Fri, 12 Oct 2007) | 3 lines +r29658 | krj | 2009-09-01 11:44:08 -0700 (Tue, 01 Sep 2009) | 1 line Changed paths: - M /trunk/doc/README.binarytrees - M /trunk/doc/README.capture - M /trunk/doc/README.display_filter - M /trunk/doc/README.idl2wrs - M /trunk/doc/README.malloc - M /trunk/doc/README.packaging - M /trunk/doc/README.plugins - M /trunk/doc/README.stats_tree - M /trunk/doc/README.tapping - M /trunk/doc/README.xml-output - M /trunk/epan/proto.c - -From Andrew Feren: -Fix an assortment of typos and other minor errors in various README files + M /trunk/epan/addr_resolv.c +Remove superfluous NULL pointer checks wrt. g_malloc() and g_realloc() ------------------------------------------------------------------------ -r23167 | morriss | 2007-10-12 14:31:58 -0700 (Fri, 12 Oct 2007) | 1 line +r29659 | krj | 2009-09-01 12:19:41 -0700 (Tue, 01 Sep 2009) | 1 line Changed paths: - M /trunk/epan/dissectors/packet-pana.c + M /trunk/ConfigureChecks.cmake + M /trunk/cmakeconfig.h.in -Fix bug 1908: strengthen the PANA new-style-dissector heuristics by checking that the length of the first AVP is less than the length of the message. +Check for mkdtemp() ------------------------------------------------------------------------ -r23168 | morriss | 2007-10-12 15:55:17 -0700 (Fri, 12 Oct 2007) | 1 line +r29660 | krj | 2009-09-01 12:27:59 -0700 (Tue, 01 Sep 2009) | 1 line Changed paths: - M /trunk/epan/dtd_preparse.l + M /trunk/cmakeconfig.h.in -s/fopen()/eth_fopen()/ in an attempt to fix bug 1827: eth_fopen() deals with wide chars for us on Windows while fopen() does not. +Define some windows specific header files ------------------------------------------------------------------------ -r23169 | sake | 2007-10-13 00:33:32 -0700 (Sat, 13 Oct 2007) | 4 lines +r29661 | guy | 2009-09-01 12:31:41 -0700 (Tue, 01 Sep 2009) | 3 lines Changed paths: - M /trunk/doc/README.developer - -Update to README.developer describing the use of conversation timestamps -(which was added in SVN 22966 and 23058) + M /trunk/epan/addr_resolv.c +Check whether "size" points to something positive, not whether "size" +itself is positive (which makes no sense for a pointer). ------------------------------------------------------------------------ -r23170 | jake | 2007-10-13 10:18:16 -0700 (Sat, 13 Oct 2007) | 14 lines +r29663 | etxrab | 2009-09-01 22:48:38 -0700 (Tue, 01 Sep 2009) | 3 lines Changed paths: - M /trunk/epan/dissectors/Makefile.common - A /trunk/epan/dissectors/packet-cfm.c - A /trunk/epan/dissectors/packet-cfm.h - -From Keith Mercer : -I would like to submit the dissector that will add support for dissecting CFM -packets with the ethertype 0x8902 defined by the IEEE proposal for 802.1ag -Draft 8.1. This code has been tested using the CFM feature implemented on a -pre-GA build of the Spirent TestCenter, and the Alcatel-Lucent 7330 ISAM -product. Code has been reviewed and tested by the design team at -Alcatel-Lucent in the Access Network Department (AND). - -I have also added some elements for the ITU proposal Y.1731, where it will -recognize all additional opcodes for that proposal, and it will fully dissect -the AIS PDU. - -Fuzztest has been performed and has passed. + M /trunk/gtk/expert_comp_table.c + M /trunk/gtk/expert_dlg.c + Didier Gautheron: +Expert info clean up. +https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=3971 ------------------------------------------------------------------------ -r23171 | etxrab | 2007-10-13 14:59:33 -0700 (Sat, 13 Oct 2007) | 1 line +r29664 | etxrab | 2009-09-02 08:07:03 -0700 (Wed, 02 Sep 2009) | 2 lines Changed paths: - M /trunk/plugins/ciscosm/packet-sm.c + M /trunk/gtk/color_dlg.c + M /trunk/gtk/new_packet_list.c + M /trunk/gtk/new_packet_list.h -Decode SDP inside Cisco SM messages(huge guesswork). +Prepare abillity to add color filters with new packet list. +(Packets not recolored yet). ------------------------------------------------------------------------ -r23172 | sfisher | 2007-10-13 17:56:53 -0700 (Sat, 13 Oct 2007) | 5 lines +r29665 | jmayer | 2009-09-02 08:52:11 -0700 (Wed, 02 Sep 2009) | 2 lines Changed paths: - M /trunk/plugins/ciscosm/packet-sm.c - - -Fix Unix buildbots ("warning: 'msg_type' may be used uninitialized in this -function") + M /trunk/epan/dissectors/packet-ldap.c +No need to include packet-frame.h ------------------------------------------------------------------------ -r23173 | etxrab | 2007-10-14 08:44:05 -0700 (Sun, 14 Oct 2007) | 6 lines +r29666 | jmayer | 2009-09-02 09:33:01 -0700 (Wed, 02 Sep 2009) | 7 lines Changed paths: - A /trunk/plugins/ethercat - A /trunk/plugins/ethercat/AUTHORS - A /trunk/plugins/ethercat/COPYING - A /trunk/plugins/ethercat/Makefile.am - A /trunk/plugins/ethercat/Makefile.common - A /trunk/plugins/ethercat/Makefile.nmake - A /trunk/plugins/ethercat/moduleinfo.h - A /trunk/plugins/ethercat/moduleinfo.nmake - A /trunk/plugins/ethercat/packet-ams.c - A /trunk/plugins/ethercat/packet-ams.h - A /trunk/plugins/ethercat/packet-ecatmb.c - A /trunk/plugins/ethercat/packet-ecatmb.h - A /trunk/plugins/ethercat/packet-ethercat-datagram.c - A /trunk/plugins/ethercat/packet-ethercat-datagram.h - A /trunk/plugins/ethercat/packet-ethercat-frame.c - A /trunk/plugins/ethercat/packet-ethercat-frame.h - A /trunk/plugins/ethercat/packet-ioraw.c - A /trunk/plugins/ethercat/packet-ioraw.h - A /trunk/plugins/ethercat/packet-nv.c - A /trunk/plugins/ethercat/packet-nv.h - A /trunk/plugins/ethercat/plugin.rc.in - -Ethercat plugin -Author : -Richard Kuemmel <r.kuemmel[AT]beckhoff.de> + M /trunk/CMakeLists.txt + A /trunk/cmake/modules/UseLemon.cmake + A /trunk/epan/CMakeLists.txt + M /trunk/wiretap/CMakeLists.txt -Updates and bugfixes: -Peter Johansson <peterjohansson73[AT]gmail.com> ------------------------------------------------------------------------- -r23174 | etxrab | 2007-10-14 08:45:24 -0700 (Sun, 14 Oct 2007) | 6 lines -Changed paths: - M /trunk/epan/dissectors/packet-ethertype.c - M /trunk/epan/etypes.h - M /trunk/packaging/nsis/Makefile.nmake - M /trunk/packaging/nsis/wireshark.nsi - M /trunk/plugins/Makefile.am - M /trunk/plugins/Makefile.nmake +Beginnings of getting cmake to build stuff in epan. +It's only beginnings, so epan is commented out in +the subdirs statement. -Ethercat plugin -Author : -Richard Kuemmel <r.kuemmel[AT]beckhoff.de> +This is more a synch to avoid duplicate work and creating +conflicting patches to the cmake stuff. -Updates and bugfixes: -Peter Johansson <peterjohansson73[AT]gmail.com> ------------------------------------------------------------------------ -r23175 | etxrab | 2007-10-14 11:32:15 -0700 (Sun, 14 Oct 2007) | 1 line +r29667 | martinm | 2009-09-02 09:39:39 -0700 (Wed, 02 Sep 2009) | 2 lines Changed paths: - M /trunk/configure.in + M /trunk/epan/dissectors/packet-mac-lte.c + M /trunk/epan/dissectors/packet-mac-lte.h + M /trunk/gtk/mac_lte_stat_dlg.c -Forgotten file. ------------------------------------------------------------------------- -r23176 | etxrab | 2007-10-14 11:34:22 -0700 (Sun, 14 Oct 2007) | 1 line -Changed paths: - M /trunk/packaging/u3/win32/makefile.nmake +Add Semi-Persistent Scheduling (SPS) RNTI. -And U3 ... ------------------------------------------------------------------------ -r23177 | jake | 2007-10-14 14:01:01 -0700 (Sun, 14 Oct 2007) | 3 lines +r29668 | krj | 2009-09-02 10:15:20 -0700 (Wed, 02 Sep 2009) | 1 line Changed paths: - M /trunk/plugins/ethercat/Makefile.am - M /trunk/plugins/ethercat/Makefile.common - M /trunk/plugins/ethercat/moduleinfo.h - M /trunk/plugins/ethercat/moduleinfo.nmake - M /trunk/plugins/ethercat/packet-ams.h - M /trunk/plugins/ethercat/packet-ecatmb.h - M /trunk/plugins/ethercat/packet-ethercat-datagram.h - M /trunk/plugins/ethercat/packet-ethercat-frame.h - M /trunk/plugins/ethercat/packet-ioraw.h - M /trunk/plugins/ethercat/packet-nv.h + M /trunk/file.c + M /trunk/gtk/new_packet_list.c -Someone has a compromised filesystem since it contained all kinds of stuff from other plugins. -Tried to clean it up and get it in line with the rest of the codebase. -Still doesn't compile without warnings though. +Make sure that we select the last row if autoscroll is enabled. The scrolling is still very jumpy. It seems that we always select the first packet before moving to the end. ------------------------------------------------------------------------ -r23178 | etxrab | 2007-10-14 15:05:52 -0700 (Sun, 14 Oct 2007) | 2 lines +r29669 | sahlberg | 2009-09-02 10:24:52 -0700 (Wed, 02 Sep 2009) | 4 lines Changed paths: - M /trunk/packaging/u3/win32/makefile.nmake + M /trunk/epan/dissectors/packet-scsi-mmc.c -From Martin Mathieson: -Hopefully the u3 build will then be able to run to completion. ------------------------------------------------------------------------- -r23179 | etxrab | 2007-10-14 22:26:22 -0700 (Sun, 14 Oct 2007) | 1 line -Changed paths: - M /trunk/configure.in - M /trunk/plugins/Makefile.am +Add initial support to decode the ADIP and PhysicalInformation for MMC +media -Remove Ethercat from the makefiles ------------------------------------------------------------------------- -r23180 | etxrab | 2007-10-14 22:45:50 -0700 (Sun, 14 Oct 2007) | 1 line -Changed paths: - M /trunk/configure.in - M /trunk/plugins/Makefile.am -Remove Ethercat from the makefiles(second try) ------------------------------------------------------------------------ -r23181 | kukosa | 2007-10-15 04:51:01 -0700 (Mon, 15 Oct 2007) | 3 lines +r29670 | krj | 2009-09-02 10:29:52 -0700 (Wed, 02 Sep 2009) | 1 line Changed paths: - M /trunk/tools/asn2wrs.py + M /trunk/file.c + M /trunk/gtk/new_packet_list.c + M /trunk/ui_util.h -- new command line option -E which makes just .cnf export file -- new directive #.IMPORT which ignores nonexistent input file if -E is used -- type name parameter for #.FN_HDR and #.FN_FTR is optional if #.FN_PARS or #.FN_HDR precedes +Add seperate new_packet_list_moveto_end() which scrolls to the end _without_ selecting the last packet. ------------------------------------------------------------------------ -r23182 | kukosa | 2007-10-15 05:21:30 -0700 (Mon, 15 Oct 2007) | 1 line +r29671 | etxrab | 2009-09-02 10:51:48 -0700 (Wed, 02 Sep 2009) | 1 line Changed paths: - M /trunk/asn1/Makefile.inc - M /trunk/asn1/Makefile.inc.nmake + M /trunk/gtk/new_packet_list.c + M /trunk/gtk/new_packet_list.h + M /trunk/gtk/packet_list_store.c + M /trunk/gtk/packet_list_store.h -use the -E asn2wrs option to create exported cnf file +Adding new color rules should work now. ------------------------------------------------------------------------ -r23183 | kukosa | 2007-10-15 05:25:05 -0700 (Mon, 15 Oct 2007) | 2 lines +r29672 | etxrab | 2009-09-02 10:52:14 -0700 (Wed, 02 Sep 2009) | 1 line Changed paths: - M /trunk/asn1/q932/Makefile.common - M /trunk/asn1/qsig/Makefile.common + M /trunk/gtk/color_dlg.c -create exported cnf file for Q.932 and QSIG -(they are not used in any Wireshark dissector but they can be used in any plugin as few Q.932 and QSIG types are exported) +Adding new color rules should work now. ------------------------------------------------------------------------ -r23184 | martinm | 2007-10-15 05:32:19 -0700 (Mon, 15 Oct 2007) | 2 lines +r29673 | etxrab | 2009-09-02 10:59:56 -0700 (Wed, 02 Sep 2009) | 2 lines Changed paths: - M /trunk/Makefile.am - M /trunk/packaging/nsis/wireshark.nsi - M /trunk/packaging/u3/win32/makefile.nmake - M /trunk/plugins/wimaxasncp/Makefile.am - D /trunk/plugins/wimaxasncp/dictionary.dtd - D /trunk/plugins/wimaxasncp/dictionary.xml - A /trunk/wimaxasncp - A /trunk/wimaxasncp/dictionary.dtd - A /trunk/wimaxasncp/dictionary.xml - -In source tree, move wimaxasncp TLV files from plugin folder -> new top-level wimaxasncp folder. + M /trunk/gtk/new_packet_list.c +Trying to fix: + packets without color are randomly colorized. ------------------------------------------------------------------------ -r23185 | kukosa | 2007-10-15 07:04:55 -0700 (Mon, 15 Oct 2007) | 1 line +r29674 | etxrab | 2009-09-02 11:18:57 -0700 (Wed, 02 Sep 2009) | 2 lines Changed paths: - M /trunk/asn1/Makefile.inc + M /trunk/gtk/compare_stat.c + M /trunk/gtk/menus.c -fix ifdef/endif bug +Use new_packet_list_colorize_packets() where cf_colorize_packets(); +is used. ------------------------------------------------------------------------ -r23186 | kukosa | 2007-10-15 07:21:35 -0700 (Mon, 15 Oct 2007) | 1 line +r29675 | tuexen | 2009-09-02 12:15:02 -0700 (Wed, 02 Sep 2009) | 3 lines Changed paths: - M /trunk/asn1/Makefile.inc + M /trunk/gtk/new_packet_list.c -comment out EXPORT_FILES till some automake expert can look at it ------------------------------------------------------------------------- -r23187 | wmeier | 2007-10-15 09:44:31 -0700 (Mon, 15 Oct 2007) | 2 lines -Changed paths: - M /trunk/Makefile.nmake - M /trunk/epan/Makefile.nmake - M /trunk/plugins/Makefile.nmake - M /trunk/tools/Makefile.nmake +Mark unused parameter as such. -Fix Windows maintainer-clean/distclean/clean to recurse thru subdirs only once (instead of worst-case 1+2+3 times) ------------------------------------------------------------------------ -r23188 | etxrab | 2007-10-15 11:39:58 -0700 (Mon, 15 Oct 2007) | 2 lines +r29676 | tuexen | 2009-09-02 12:16:59 -0700 (Wed, 02 Sep 2009) | 4 lines Changed paths: - M /trunk/Makefile.am M /trunk/configure.in - M /trunk/plugins/ethercat/packet-ams.c - M /trunk/plugins/ethercat/packet-ams.h - M /trunk/plugins/ethercat/packet-ecatmb.h - M /trunk/plugins/ethercat/packet-ethercat-datagram.c - M /trunk/plugins/ethercat/packet-ethercat-datagram.h - M /trunk/plugins/ethercat/packet-ethercat-frame.c - M /trunk/plugins/ethercat/packet-ethercat-frame.h - M /trunk/plugins/ethercat/packet-ioraw.c - M /trunk/plugins/ethercat/packet-ioraw.h - M /trunk/plugins/ethercat/packet-nv.c - M /trunk/plugins/ethercat/packet-nv.h -From Peter Johansson: -addressing the compilation problems ------------------------------------------------------------------------- -r23189 | kukosa | 2007-10-15 11:44:53 -0700 (Mon, 15 Oct 2007) | 2 lines -Changed paths: - M /trunk/asn1/Makefile.nmake - M /trunk/asn1/h225/Makefile.common - M /trunk/asn1/h225/h225.cnf - M /trunk/asn1/h235/Makefile.common - M /trunk/asn1/h235/h235.cnf +Add --enable-new-packet-list to configure script. Default +is no for now. Should be kept in sync with the corresponding +Windows switch. -- add missing h450-ros and q932-ros clean rules to asn1/Makefile.nmake -- solve h225<->h235 cyclic dependency with usage of -E option and #.IMPORT directive ------------------------------------------------------------------------ -r23190 | etxrab | 2007-10-15 11:57:10 -0700 (Mon, 15 Oct 2007) | 2 lines +r29677 | krj | 2009-09-02 12:31:56 -0700 (Wed, 02 Sep 2009) | 1 line Changed paths: - M /trunk/Makefile.am - M /trunk/Makefile.nmake - M /trunk/configure.in - M /trunk/epan/dissectors/Makefile.common - A /trunk/epan/dissectors/packet-mgcp.c - A /trunk/epan/dissectors/packet-mgcp.h - M /trunk/packaging/nsis/Makefile.nmake - M /trunk/packaging/nsis/wireshark.nsi - M /trunk/packaging/u3/win32/makefile.nmake - M /trunk/plugins/Makefile.am - M /trunk/plugins/Makefile.nmake + M /trunk/file.c + M /trunk/gtk/new_packet_list.c -Make MGCP a builtin dissector to reduce the number of plugins. -(Leave the MGCP plugin dir for now). +Only try and select the last row if not already selected. This fix doesn't seem to work. Any suggestions? ------------------------------------------------------------------------ -r23191 | etxrab | 2007-10-15 12:19:33 -0700 (Mon, 15 Oct 2007) | 1 line +r29678 | krj | 2009-09-02 12:56:39 -0700 (Wed, 02 Sep 2009) | 1 line Changed paths: - M /trunk/plugins/Makefile.am + M /trunk/gtk/menus.c -Add ethercat again +Make sure that we deactivate before activating in menu_recent_read_finished(). This fixes a crash due to recent.gui_time_format being invalid (-1). Please review whether this is a correct fix ------------------------------------------------------------------------ -r23192 | etxrab | 2007-10-15 13:11:25 -0700 (Mon, 15 Oct 2007) | 1 line +r29679 | stig | 2009-09-02 14:04:41 -0700 (Wed, 02 Sep 2009) | 2 lines Changed paths: - M /trunk/epan/dissectors/packet-3com-njack.c - M /trunk/epan/dissectors/packet-actrace.c - M /trunk/epan/dissectors/packet-afp.c - M /trunk/epan/dissectors/packet-aim-buddylist.c - M /trunk/epan/dissectors/packet-aim-generic.c - M /trunk/epan/dissectors/packet-aim.c - M /trunk/epan/dissectors/packet-amqp.c - M /trunk/epan/dissectors/packet-aodv.c - M /trunk/epan/dissectors/packet-asf.c - M /trunk/epan/dissectors/packet-atalk.c + M /trunk/gtk/menus.c -Implement some of the minor possible speed improvment patches. ------------------------------------------------------------------------- -r23193 | etxrab | 2007-10-15 13:12:02 -0700 (Mon, 15 Oct 2007) | 1 line -Changed paths: - M /trunk/plugins/ethercat/packet-ecatmb.c +Also deactivate and activate menu for recent.gui_time_precision. -Try to fix the buildbot. ------------------------------------------------------------------------ -r23194 | wmeier | 2007-10-15 13:44:03 -0700 (Mon, 15 Oct 2007) | 2 lines +r29680 | etxrab | 2009-09-02 22:03:57 -0700 (Wed, 02 Sep 2009) | 2 lines Changed paths: - M /trunk/epan/dissectors/packet-aodv.c - M /trunk/epan/dissectors/packet-asf.c - -Fix col_add_str args; (I think this is correct) + M /trunk/gtk/new_packet_list.c +Don't set the minimum column width to the computed or stored value, +use a fixed minimum value and use the other as the size used to display the column. ------------------------------------------------------------------------ -r23195 | jmayer | 2007-10-15 14:15:57 -0700 (Mon, 15 Oct 2007) | 3 lines +r29681 | etxrab | 2009-09-02 22:35:21 -0700 (Wed, 02 Sep 2009) | 1 line Changed paths: - M /trunk/asn1/Makefile.am - M /trunk/asn1/Makefile.preinc - -MAKEFLAGS doesn't belong into Makefile.am - it's added automagically -when generating Makefile.in + M /trunk/gtk/new_packet_list.c +Right align COL_NUMBER. ------------------------------------------------------------------------ -r23196 | stig | 2007-10-15 14:46:08 -0700 (Mon, 15 Oct 2007) | 2 lines +r29682 | stig | 2009-09-03 03:40:06 -0700 (Thu, 03 Sep 2009) | 3 lines Changed paths: - M /trunk/plugins/ethercat/packet-ecatmb.c + M /trunk/gtk/new_packet_list.c -Fixed compiler errors. +Right justify "Packet length", "Cumulative bytes" and custom columns +displaying numerical values. ------------------------------------------------------------------------ -r23197 | etxrab | 2007-10-15 15:20:53 -0700 (Mon, 15 Oct 2007) | 1 line +r29683 | stig | 2009-09-03 03:50:30 -0700 (Thu, 03 Sep 2009) | 2 lines Changed paths: - M /trunk/gtk/voip_calls.c + M /trunk/gtk/new_packet_list.c -Change mgcp include. ------------------------------------------------------------------------- -r23198 | guy | 2007-10-15 15:54:21 -0700 (Mon, 15 Oct 2007) | 5 lines -Changed paths: - M /trunk/ChangeLog - -Checkin comments also talk about adding "$Id$", so don't expand "$Id$" -in this file - we don't give it its own RCS ID. - -Fix up some of the expanded $Id$s. +Adjusted int/uint check and fixed a comment in right justify check. ------------------------------------------------------------------------ -r23199 | etxrab | 2007-10-15 22:45:03 -0700 (Mon, 15 Oct 2007) | 1 line +r29684 | stig | 2009-09-03 04:37:12 -0700 (Thu, 03 Sep 2009) | 2 lines Changed paths: - M /trunk/gtk/mgcp_stat.c - M /trunk/tap-mgcpstat.c + M /trunk/gtk/recent.c -Change mgcp include. ------------------------------------------------------------------------- -r23200 | jake | 2007-10-15 22:47:55 -0700 (Mon, 15 Oct 2007) | 1 line -Changed paths: - D /trunk/epan/dissectors/packet-mgcp.c - D /trunk/epan/dissectors/packet-mgcp.h +Read column widths from recent file also for new packet list. -Don't just copy a file and check that in. Use svn copy to retain the history. ------------------------------------------------------------------------ -r23201 | jake | 2007-10-15 22:49:55 -0700 (Mon, 15 Oct 2007) | 2 lines +r29685 | krj | 2009-09-03 07:32:11 -0700 (Thu, 03 Sep 2009) | 4 lines Changed paths: - A /trunk/epan/dissectors/packet-mgcp.c (from /trunk/plugins/mgcp/packet-mgcp.c:23198) - A /trunk/epan/dissectors/packet-mgcp.h (from /trunk/plugins/mgcp/packet-mgcp.h:23198) + M /trunk/file.c + M /trunk/gtk/new_packet_list.c + M /trunk/ui_util.h -Make MGCP a builtin dissector to reduce the number of plugins. -(Leave the MGCP plugin dir for now). ------------------------------------------------------------------------- -r23202 | jmayer | 2007-10-16 06:59:40 -0700 (Tue, 16 Oct 2007) | 6 lines -Changed paths: - M /trunk/asn1/Makefile.inc - M /trunk/asn1/Makefile.inc.nmake - M /trunk/asn1/acp133 - M /trunk/asn1/acp133/acp133.cnf - M /trunk/asn1/acse - M /trunk/asn1/acse/acse.cnf - M /trunk/asn1/ansi-tcap - M /trunk/asn1/ansi_map - M /trunk/asn1/ansi_map/ansi_map.cnf - M /trunk/asn1/camel - M /trunk/asn1/camel/camel.cnf - M /trunk/asn1/cdt - M /trunk/asn1/cmip - M /trunk/asn1/cmip/cmip.cnf - M /trunk/asn1/cms - M /trunk/asn1/cms/cms.cnf - M /trunk/asn1/dap - M /trunk/asn1/dap/dap.cnf - M /trunk/asn1/disp - M /trunk/asn1/disp/disp.cnf - M /trunk/asn1/dop - M /trunk/asn1/dop/dop.cnf - M /trunk/asn1/dsp - M /trunk/asn1/dsp/dsp.cnf - M /trunk/asn1/ess - M /trunk/asn1/ess/ess.cnf - M /trunk/asn1/ftam - M /trunk/asn1/ftam/ftam.cnf - M /trunk/asn1/gnm - M /trunk/asn1/gnm/gnm.cnf - M /trunk/asn1/gsmmap - M /trunk/asn1/gsmmap/Makefile.common - M /trunk/asn1/gsmmap/gsmmap.cnf - M /trunk/asn1/h225 - M /trunk/asn1/h225/Makefile.common - M /trunk/asn1/h235 - M /trunk/asn1/h235/Makefile.common - M /trunk/asn1/h245 - M /trunk/asn1/h248 - M /trunk/asn1/h450 - M /trunk/asn1/h450/h450.cnf - M /trunk/asn1/h450-ros - M /trunk/asn1/inap - M /trunk/asn1/ldap - M /trunk/asn1/logotype-cert-extn - M /trunk/asn1/logotype-cert-extn/logotypecertextn.cnf - M /trunk/asn1/mms - M /trunk/asn1/mms/mms.cnf - M /trunk/asn1/mpeg-audio - M /trunk/asn1/mpeg-pes - M /trunk/asn1/nbap - M /trunk/asn1/ns-cert-exts - M /trunk/asn1/ocsp - M /trunk/asn1/ocsp/ocsp.cnf - M /trunk/asn1/pkcs1 - M /trunk/asn1/pkcs1/pkcs1.cnf - M /trunk/asn1/pkcs12 - M /trunk/asn1/pkcs12/pkcs12.cnf - M /trunk/asn1/pkinit - M /trunk/asn1/pkinit/pkinit.cnf - M /trunk/asn1/pkix1explicit - M /trunk/asn1/pkix1implicit - M /trunk/asn1/pkix1implicit/pkix1implicit.cnf - M /trunk/asn1/pkixcmp - M /trunk/asn1/pkixcmp/cmp.cnf - M /trunk/asn1/pkixcrmf - M /trunk/asn1/pkixcrmf/crmf.cnf - M /trunk/asn1/pkixproxy - M /trunk/asn1/pkixqualified - M /trunk/asn1/pkixqualified/pkixqualified.cnf - M /trunk/asn1/pkixtsp - M /trunk/asn1/pkixtsp/pkixtsp.cnf - M /trunk/asn1/pres - M /trunk/asn1/pres/pres.cnf - M /trunk/asn1/q932 - M /trunk/asn1/q932/Makefile.common - M /trunk/asn1/q932-ros - M /trunk/asn1/qsig - M /trunk/asn1/qsig/Makefile.common - M /trunk/asn1/ranap - M /trunk/asn1/rnsap - M /trunk/asn1/ros - M /trunk/asn1/rrc - M /trunk/asn1/rrlp - M /trunk/asn1/rtse - M /trunk/asn1/s4406 - M /trunk/asn1/s4406/s4406.cnf - M /trunk/asn1/sabp - M /trunk/asn1/smrse - M /trunk/asn1/snmp - M /trunk/asn1/spnego - M /trunk/asn1/t38 - M /trunk/asn1/tcap - M /trunk/asn1/ulp - M /trunk/asn1/wlancertextn - M /trunk/asn1/x411 - M /trunk/asn1/x411/x411.cnf - M /trunk/asn1/x420 - M /trunk/asn1/x420/x420.cnf - M /trunk/asn1/x509af - M /trunk/asn1/x509af/x509af.cnf - M /trunk/asn1/x509ce - M /trunk/asn1/x509ce/x509ce.cnf - M /trunk/asn1/x509if - M /trunk/asn1/x509if/x509if.cnf - M /trunk/asn1/x509sat - M /trunk/asn1/x509sat/x509sat.cnf - M /trunk/asn1/x721 - -- Fix svn:ignore for all directories -- gsmmap: uncomment -s option in gsmmap.cnf -- Fix cyclic dependencies: - + Remove EXPORT_CNF from dependencies for cnf files - + Replace all INCLUDE ...-exp.cnf with IMPORT ...-exp.cnf - ------------------------------------------------------------------------- -r23203 | jmayer | 2007-10-16 07:09:33 -0700 (Tue, 16 Oct 2007) | 2 lines -Changed paths: - M /trunk/asn1/Makefile.inc - M /trunk/asn1/Makefile.preinc - -Don't generate dissectors on top level make. - ------------------------------------------------------------------------- -r23204 | jmayer | 2007-10-16 07:30:41 -0700 (Tue, 16 Oct 2007) | 3 lines -Changed paths: - M /trunk/plugins/ethercat/packet-ecatmb.c +Make sure that we stop auto scroll if we start scrolling manually. -Fix a warning about different variable sizes that prevented compilation -with gcc. +Caveat: we jump to first frame when auto scroll is stopped ------------------------------------------------------------------------ -r23205 | morriss | 2007-10-16 07:54:51 -0700 (Tue, 16 Oct 2007) | 1 line +r29686 | krj | 2009-09-03 07:41:09 -0700 (Thu, 03 Sep 2009) | 1 line Changed paths: - M /trunk/plugins/ethercat/packet-ecatmb.c + M /trunk/file.c -sizeof() returns a 64-bit number when compiling for 64-bit (and a 32-bit number when compiling for 32-bit) so cast sizeof() values that are passed to g_snprintf() to guint (since that appears to be the intent of the display). +Remove superfluous assignment ------------------------------------------------------------------------ -r23206 | morriss | 2007-10-16 08:43:18 -0700 (Tue, 16 Oct 2007) | 7 lines +r29687 | martinm | 2009-09-03 09:42:16 -0700 (Thu, 03 Sep 2009) | 2 lines Changed paths: - M /trunk/doc/README.developer - M /trunk/epan/diam_dict.l - M /trunk/epan/dissectors/packet-giop.c - M /trunk/epan/dissectors/packet-isakmp.c - M /trunk/epan/dissectors/packet-ssl-utils.c - M /trunk/epan/dissectors/packet-ssl.c - M /trunk/epan/radius_dict.l - M /trunk/epan/uat.c - M /trunk/epan/uat_load.l - M /trunk/wiretap/file_util.h - M /trunk/wiretap/k12.c - -Change more fopen() to eth_fopen() to finish fixing bug 1827: - -http://bugs.wireshark.org/bugzilla/show_bug.cgi?id=1827 + M /trunk/epan/dissectors/packet-mac-lte.c -Update README.developer to tell developers not to use fopen() and friends -directly. - ------------------------------------------------------------------------- -r23207 | morriss | 2007-10-16 08:58:25 -0700 (Tue, 16 Oct 2007) | 1 line -Changed paths: - M /trunk/epan/dfilter/dfilter-macro.c - M /trunk/epan/wslua/init_wslua.c - M /trunk/text2pcap.c +Show UEId in info column for UL-SCH / DL-SCH frames. -A few more s/fopen/eth_fopen/ ------------------------------------------------------------------------ -r23208 | morriss | 2007-10-16 10:19:16 -0700 (Tue, 16 Oct 2007) | 9 lines +r29688 | krj | 2009-09-03 10:00:17 -0700 (Thu, 03 Sep 2009) | 1 line Changed paths: - M /trunk/epan/dissectors/packet-frame.c - M /trunk/epan/dissectors/packet-hci_h4.c - M /trunk/wiretap/libpcap.c - M /trunk/wiretap/wtap.c - M /trunk/wiretap/wtap.h - -From Paolo Abeni via bug 1751: - -http://bugs.wireshark.org/bugzilla/show_bug.cgi?id=1751 - -The patch adds support to wiretap for a new libpcap DLT for bluetooth captures. -This DLT carries the direction information, which now can be displayed -correctly. -The hci H4 dissector is updated to handle also the newly introduced wtap encap. + M /trunk/gtk/new_packet_list.c + M /trunk/gtk/packet_list_store.c + M /trunk/gtk/packet_list_store.h +Allocate and use an extra column at the end of the column list to indicate the 'magic' column which contains the _entire_ PacketListRecord ------------------------------------------------------------------------ -r23209 | morriss | 2007-10-16 11:28:27 -0700 (Tue, 16 Oct 2007) | 1 line +r29689 | krj | 2009-09-03 10:39:42 -0700 (Thu, 03 Sep 2009) | 1 line Changed paths: - M /trunk/Makefile.am - M /trunk/Makefile.nmake + M /trunk/gtk/new_packet_list.c + M /trunk/gtk/packet_list_store.c + M /trunk/gtk/packet_list_store.h -text2pcap now depends on libwiretap (for eth_fopen()) but only on Windows. Make it depend on libwiretap on *NIX, too, only to keep things in sync. +Add packet_list_visible_record() to avoid poking PacketListRecord in new_packet_list.c ------------------------------------------------------------------------ -r23210 | guy | 2007-10-16 12:01:58 -0700 (Tue, 16 Oct 2007) | 5 lines +r29690 | krj | 2009-09-03 10:56:57 -0700 (Thu, 03 Sep 2009) | 1 line Changed paths: - M /trunk/wiretap/Makefile.am - M /trunk/wiretap/configure.in - -Bug 1704 is fixed in the main branch by the simpler expedient of not -using modf() and thus not requiring libm. In addition, adding -lm to -the dependencies upsets the build on at least some platforms because -"-lm" isn't a pathname. + M /trunk/gtk/new_packet_list.c + M /trunk/gtk/packet_list_store.c +Only store the last column as G_TYPE_POINTER. Hopefully this will soon make us able to sort again ------------------------------------------------------------------------ -r23211 | sake | 2007-10-16 16:42:33 -0700 (Tue, 16 Oct 2007) | 7 lines +r29691 | gerald | 2009-09-03 11:15:23 -0700 (Thu, 03 Sep 2009) | 2 lines Changed paths: - M /trunk/epan/crypt/airpdcap.c - M /trunk/epan/crypt/airpdcap_system.h - M /trunk/epan/crypt/airpdcap_user.h - M /trunk/epan/dissectors/packet-dtpt.c - M /trunk/epan/dissectors/packet-fmp.c - M /trunk/epan/dissectors/packet-gdsdb.c - M /trunk/epan/dissectors/packet-ospf.c - M /trunk/epan/dissectors/packet-rsl.c - M /trunk/epan/dissectors/packet-ssl-utils.h - M /trunk/epan/oids.h - M /trunk/epan/wslua/wslua_dumper.c - M /trunk/epan/wslua/wslua_tvb.c - M /trunk/gtk/airpcap_dlg.c - M /trunk/gtk/airpcap_dlg.h - M /trunk/wiretap/k12.c - -From tmiller@hcjbtech.org : Spelling error on GDS DB protocol dissector: "Buffer lenght:" - -(recursively grepped through the source and corrected all occurences, even -the ones just in comments) - + M /trunk/docbook/release-notes.xml +Start the feature list for 1.4. ------------------------------------------------------------------------ -r23212 | jake | 2007-10-16 23:24:43 -0700 (Tue, 16 Oct 2007) | 1 line +r29692 | etxrab | 2009-09-04 03:53:37 -0700 (Fri, 04 Sep 2009) | 3 lines Changed paths: - M /trunk/epan/dissectors/packet-e164.c - M /trunk/epan/dissectors/packet-isup.c + M /trunk/epan/addr_resolv.c -Properly decode "South Africa" +From : Didier Gautheron +Addresse hash is slow on little endian CPU. +https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=3973 ------------------------------------------------------------------------ -r23213 | sake | 2007-10-17 00:14:56 -0700 (Wed, 17 Oct 2007) | 7 lines +r29693 | etxrab | 2009-09-04 04:06:52 -0700 (Fri, 04 Sep 2009) | 5 lines Changed paths: - M /trunk/epan/dissectors/packet-tcp.c - -Fix for bug 1542: - -When a SYN/ACK is missing in the capture, the base_seq used in -relative sequence numbers was not set correctly. I made the -setting of fwd->base_seq and rev->base_seq a little more solid. + M /trunk/epan/dissectors/packet-gsm_a_rr.c +From Vincent Helfre: +Dissect_ccch does not dissect sys info content. +Me: Remove check_col. +https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=3901 ------------------------------------------------------------------------ -r23214 | kukosa | 2007-10-17 02:51:27 -0700 (Wed, 17 Oct 2007) | 1 line +r29694 | jmayer | 2009-09-04 04:48:04 -0700 (Fri, 04 Sep 2009) | 1 line Changed paths: - M /trunk/epan/dissectors/packet-per.c - M /trunk/epan/dissectors/packet-per.h + M /trunk/epan/emem.c -make dissect_per_length_determinant() private +Include "proto.h" instead of <proto.h> ------------------------------------------------------------------------ -r23215 | kukosa | 2007-10-17 02:55:08 -0700 (Wed, 17 Oct 2007) | 2 lines +r29695 | tuexen | 2009-09-04 05:42:22 -0700 (Fri, 04 Sep 2009) | 2 lines Changed paths: - M /trunk/asn1/qsig/packet-qsig-template.c - M /trunk/epan/dissectors/packet-q932-ros.c - M /trunk/epan/dissectors/packet-q932.c - M /trunk/epan/dissectors/packet-q932.h - M /trunk/epan/dissectors/packet-qsig.c - M /trunk/epan/dissectors/packet-qsig.h + M /trunk/gtk/sctp_graph_dlg.c -- register QSIG over SIP -- regenerate Q932, Q932-ROS, QSIG from new makefiles ------------------------------------------------------------------------- -r23216 | kukosa | 2007-10-17 03:25:21 -0700 (Wed, 17 Oct 2007) | 8 lines -Changed paths: - M /trunk/asn1/Makefile.am - M /trunk/asn1/Makefile.nmake - M /trunk/asn1/h225/h225.cnf - M /trunk/asn1/h225/packet-h225-template.c - M /trunk/asn1/h235/Makefile.common - M /trunk/asn1/h235/h235.cnf - M /trunk/asn1/h235/packet-h235-template.c - M /trunk/asn1/h245/h245.cnf - M /trunk/asn1/h245/packet-h245-template.c - A /trunk/asn1/h323 - A /trunk/asn1/h323/Makefile.am - A /trunk/asn1/h323/Makefile.common - A /trunk/asn1/h323/Makefile.nmake - A /trunk/asn1/h323/RAS-PROTOCOL-TUNNEL.asn - A /trunk/asn1/h323/ROBUSTNESS-DATA.asn - A /trunk/asn1/h323/h323.cnf - A /trunk/asn1/h323/packet-h323-template.c - M /trunk/configure.in - M /trunk/epan/dissectors/Makefile.common - M /trunk/epan/dissectors/packet-h225.c - M /trunk/epan/dissectors/packet-h225.h - M /trunk/epan/dissectors/packet-h235.c - M /trunk/epan/dissectors/packet-h235.h - M /trunk/epan/dissectors/packet-h245.c - M /trunk/epan/dissectors/packet-h245.h - A /trunk/epan/dissectors/packet-h323.c - M /trunk/epan/dissectors/packet-h450-ros.c - M /trunk/epan/dissectors/packet-h450-ros.h - M /trunk/epan/dissectors/packet-h450.c - M /trunk/epan/dissectors/packet-t38.c - M /trunk/epan/dissectors/packet-t38.h - -new H.323 dissector - - Generic Extensible Framework helper - - Annex M1 (QSIG over H.323) - - Annex M4 - - Annex R -H.225/H.245 support for Generic Extensible Framework (GEF) -H.235 register MIKEY into new H.225/H.245 GEF tables -regenerate H.225,H.245,H.235,H.450,H.450-ROS,T.35 from new makefiles ------------------------------------------------------------------------- -r23217 | kukosa | 2007-10-17 04:06:14 -0700 (Wed, 17 Oct 2007) | 1 line -Changed paths: - M /trunk/epan/dissectors/Makefile.common - A /trunk/epan/dissectors/packet-h323.h +From Irene Ruengeler: Show duplicate TSNs in SACKs. -add forgotten packet-h323.h ------------------------------------------------------------------------ -r23218 | jake | 2007-10-17 11:25:01 -0700 (Wed, 17 Oct 2007) | 1 line +r29696 | tuexen | 2009-09-04 05:52:28 -0700 (Fri, 04 Sep 2009) | 2 lines Changed paths: - M /trunk/epan/dissectors/packet-smb-pipe.c - M /trunk/epan/dissectors/packet-smb2.c + M /trunk/gtk/sctp_graph_dlg.c -Flag error ------------------------------------------------------------------------- -r23219 | jake | 2007-10-17 11:25:29 -0700 (Wed, 17 Oct 2007) | 1 line -Changed paths: - M /trunk/epan/dissectors/packet-ncp2222.inc +Fix compilation. -Mask error ------------------------------------------------------------------------ -r23220 | jake | 2007-10-17 11:25:49 -0700 (Wed, 17 Oct 2007) | 1 line +r29697 | tuexen | 2009-09-04 06:10:59 -0700 (Fri, 04 Sep 2009) | 2 lines Changed paths: - M /trunk/epan/dissectors/packet-bootp.c - M /trunk/epan/dissectors/packet-pvfs2.c + M /trunk/gtk/sctp_graph_dlg.c -Logic error ------------------------------------------------------------------------- -r23221 | morriss | 2007-10-17 14:25:16 -0700 (Wed, 17 Oct 2007) | 1 line -Changed paths: - M /trunk/plugins/mate/mate_grammar.lemon - M /trunk/plugins/mate/mate_parser.l - M /trunk/plugins/wimaxasncp/wimaxasncp_dict.l +Fix handling of multiple duplicate TSNs. -s/fopen()/eth_fopen()/ in plugins/ (for bug 1827). ------------------------------------------------------------------------ -r23222 | stig | 2007-10-18 04:29:32 -0700 (Thu, 18 Oct 2007) | 2 lines +r29698 | tuexen | 2009-09-04 06:23:51 -0700 (Fri, 04 Sep 2009) | 2 lines Changed paths: - M /trunk/epan/libwireshark.def - -Add eth_stdio_open to libwireshark.def + M /trunk/gtk/sctp_graph_dlg.c ------------------------------------------------------------------------- -r23223 | grahamb | 2007-10-18 04:42:59 -0700 (Thu, 18 Oct 2007) | 1 line -Changed paths: - M /trunk/epan/libwireshark.def +Cleanup whitespaces. -Fixed sort order, used case-insensitive ascending ------------------------------------------------------------------------ -r23224 | grahamb | 2007-10-18 05:08:50 -0700 (Thu, 18 Oct 2007) | 1 line +r29699 | krj | 2009-09-04 10:42:03 -0700 (Fri, 04 Sep 2009) | 1 line Changed paths: - M /trunk - M /trunk/epan - M /trunk/plugins/agentx - M /trunk/plugins/artnet - M /trunk/plugins/asn1 - M /trunk/plugins/ciscosm - M /trunk/plugins/docsis - M /trunk/plugins/enttec - M /trunk/plugins/ethercat - M /trunk/plugins/giop - M /trunk/plugins/gryphon - M /trunk/plugins/irda - M /trunk/plugins/lwres - M /trunk/plugins/mate - M /trunk/plugins/opcua - M /trunk/plugins/opsi - M /trunk/plugins/pcli - M /trunk/plugins/profinet - M /trunk/plugins/rlm - M /trunk/plugins/rtnet - M /trunk/plugins/rudp - M /trunk/plugins/sbus - M /trunk/plugins/stats_tree - M /trunk/plugins/unistim - M /trunk/plugins/v5ua - M /trunk/plugins/wimaxasncp - M /trunk/tools/lemon - M /trunk/wiretap - -Updated svn:ignore props for win32 build ------------------------------------------------------------------------- -r23225 | stig | 2007-10-18 05:41:11 -0700 (Thu, 18 Oct 2007) | 2 lines -Changed paths: - M /trunk/asn1/h323 - -Added svn:ignore targets for asn1/h323 - ------------------------------------------------------------------------- -r23226 | kukosa | 2007-10-18 06:35:57 -0700 (Thu, 18 Oct 2007) | 6 lines -Changed paths: - M /trunk/asn1/Makefile.am - M /trunk/asn1/Makefile.nmake - M /trunk/asn1/h225/h225.cnf - M /trunk/asn1/h225/packet-h225-template.c - A /trunk/asn1/h460 - A /trunk/asn1/h460/CALL-PARTY-CATEGORY.asn - A /trunk/asn1/h460/CALL-PRIORITY.asn - A /trunk/asn1/h460/CIRCUIT-STATUS-MAP.asn - A /trunk/asn1/h460/MEDIA-TRAVERSAL.asn - A /trunk/asn1/h460/MESSAGE-BROADCAST.asn - A /trunk/asn1/h460/MLPP.asn - A /trunk/asn1/h460/Makefile.am - A /trunk/asn1/h460/Makefile.common - A /trunk/asn1/h460/Makefile.nmake - A /trunk/asn1/h460/NUMBER-PORTABILITY.asn - A /trunk/asn1/h460/QOS-MONITORING-EXTENDED-VOIP-REPORT.asn - A /trunk/asn1/h460/QOS-MONITORING-REPORT.asn - A /trunk/asn1/h460/SIGNALLING-CHANNEL-SUSPEND-REDIRECT.asn - A /trunk/asn1/h460/SIGNALLING-TRAVERSAL.asn - A /trunk/asn1/h460/h460.cnf - A /trunk/asn1/h460/packet-h460-template.c - M /trunk/configure.in - M /trunk/epan/dissectors/Makefile.common - M /trunk/epan/dissectors/packet-h225.c - M /trunk/epan/dissectors/packet-h225.h - A /trunk/epan/dissectors/packet-h460.c - M /trunk/epan/libwireshark.def - M /trunk/gtk/h225_counter.c - M /trunk/gtk/voip_calls.c - M /trunk/tap-h225counter.c - M /trunk/tools/asn2wrs.py + M /trunk/gtk/new_packet_list.c + M /trunk/gtk/packet_list_store.c + M /trunk/gtk/packet_list_store.h -H.460 new dissector implemented (H.460.2-H.460.22) -H.225 - - change RysMessage_vals to h225_Rasmessage_vals - - use #.PDU directive for H323-UserInformation and RasMessage instead of implementing it by hands - - register RasMessage_PDU as "h225.ras" dissector for calling it from H.460 -asn2wrs make PDUs exportable +Rename new_packet_list_reset_dissected to packet_list_reset_dissected ------------------------------------------------------------------------ -r23227 | wmeier | 2007-10-18 12:30:56 -0700 (Thu, 18 Oct 2007) | 2 lines +r29700 | wmeier | 2009-09-04 11:18:34 -0700 (Fri, 04 Sep 2009) | 3 lines Changed paths: - M /trunk/Makefile.nmake + M /trunk/epan/dissectors/packet-kingfisher.c -Updated GTK/Glib/Pango Libraries +From Rob Casey: Fix for: Incorrect station identifier parsing in Kingfisher dissector +See https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=3946 ------------------------------------------------------------------------ -r23228 | wmeier | 2007-10-18 12:47:45 -0700 (Thu, 18 Oct 2007) | 2 lines +r29701 | wmeier | 2009-09-04 11:40:02 -0700 (Fri, 04 Sep 2009) | 7 lines Changed paths: - M /trunk/Makefile.nmake + M /trunk/epan/dissectors/packet-kingfisher.c -Oops: Backout the library updates until libraries configured for download... (??) +A few minor revisions: +- if (check_col ...) no longer required; +- Use match_strval when verifying the fcn code; +- Add a missing #ifdef; +- Make a global variable static; +- Fix indentation to be consistent in a few places. ------------------------------------------------------------------------ -r23229 | etxrab | 2007-10-18 14:29:19 -0700 (Thu, 18 Oct 2007) | 1 line +r29705 | krj | 2009-09-05 03:36:29 -0700 (Sat, 05 Sep 2009) | 2 lines Changed paths: - M /trunk/Makefile.nmake - M /trunk/tools/win32-setup.sh - -Use gtk 2.12.1 ------------------------------------------------------------------------- -r23230 | sake | 2007-10-19 02:50:29 -0700 (Fri, 19 Oct 2007) | 18 lines -Changed paths: - M /trunk/epan/dissectors/packet-sflow.c - -From Andrew Feren: - -sFlow datagrams can contain sampled headers from conversations on the network. - -Often it is convenient to have wireshark dissect these payload headers, but -doing so can also have undesirable side effects. Dissected payload headers may -match filters looking for header fields that also happen to occur in the -payload. This can cause surprising results. - -Also TCP analysis will almost always flag errors on sampled headers. They are, -after all, just a sample and many sequence numbers are sure to be missing. + M /trunk/file.c + M /trunk/gtk/new_packet_list.c + M /trunk/gtk/packet_list_store.c + M /trunk/gtk/packet_list_store.h + M /trunk/ui_util.h -There is probably a more general way to resolve these issues, but adding -preferences to enable/disable tcp analysis and dissection of sampled headers -will be a good start. This will make it possible to examine the details of -sampled headers if desired or to disable dissection if the side effects of -dissecting sampled headers cause issues. +Get rid off GtkTreeModelFilter because the time to sort becomes unbearable when combined with GtkTreeSortable. This means that we now track which frames are visible in the our own packet list store. To do so, we now distinguish between physical and visible rows. All frames are added as physical rows. Only those that passes the display filter are marked as visible. ------------------------------------------------------------------------ -r23231 | wmeier | 2007-10-19 08:21:42 -0700 (Fri, 19 Oct 2007) | 2 lines +r29706 | stig | 2009-09-05 04:15:50 -0700 (Sat, 05 Sep 2009) | 2 lines Changed paths: - M /trunk/doc/README.plugins + M /trunk/gtk/packet_list_store.c -Minor update to reflect recent plugins/Makefile.nmake change to clean/distclean/maintainer-clean +Make it build without warnings. ------------------------------------------------------------------------ -r23232 | sfisher | 2007-10-19 15:40:42 -0700 (Fri, 19 Oct 2007) | 4 lines +r29707 | krj | 2009-09-05 04:58:44 -0700 (Sat, 05 Sep 2009) | 1 line Changed paths: - M /trunk/wiretap/iseries.c - - -Fix bug #1926: buffer overflow when parsing iseries files - + M /trunk/gtk/packet_list_store.c +Bail out gracefully on colums we cant sort on yet instead of crashing ------------------------------------------------------------------------ -r23233 | guy | 2007-10-19 19:34:41 -0700 (Fri, 19 Oct 2007) | 3 lines +r29708 | krj | 2009-09-05 05:42:44 -0700 (Sat, 05 Sep 2009) | 1 line Changed paths: - M /trunk/gtk/gui_utils.c - -Silently ignore bogus geometry subkeys, just as we silently ignore other -bogus entries in the recent file. This fixes bug 1925. + M /trunk/gtk/new_packet_list.c +Sort out some of the confusion r29706 introduced (visible vs. physical rows). We choose the wrong packet in the packet view because we used the physical row instead of the visible. I suspect there a couple more of these lurking. ------------------------------------------------------------------------ -r23234 | guy | 2007-10-19 20:45:47 -0700 (Fri, 19 Oct 2007) | 7 lines +r29709 | stig | 2009-09-05 06:06:45 -0700 (Sat, 05 Sep 2009) | 2 lines Changed paths: - M /trunk/epan/privileges.c + M /trunk/epan/prefs.c -In relinquish_special_privs_perm(), only relinquish special privileges -if we were given them; doing so when we weren't seems to change the -apparent group set in OS X 10.5 (and possibly 10.4 - the group set -manipulated by getgroups()/setgroups() isn't the full group set, and -changing your UID might cause the credential identity resolver daemon -not to give you your full group set). +Ignore preferences for deleted protocols "etheric" and "isup_thin". ------------------------------------------------------------------------ -r23235 | martinm | 2007-10-22 03:03:22 -0700 (Mon, 22 Oct 2007) | 2 lines +r29710 | krj | 2009-09-05 06:24:16 -0700 (Sat, 05 Sep 2009) | 1 line Changed paths: - M /trunk/Makefile.nmake - -Allow wimaxasncp plugin to be found in Windows dev build. + M /trunk/gtk/packet_list_store.c + M /trunk/gtk/packet_list_store.h +Make sure that we can resort with an active display filter ------------------------------------------------------------------------ -r23236 | martinm | 2007-10-22 03:47:23 -0700 (Mon, 22 Oct 2007) | 2 lines +r29711 | krj | 2009-09-05 06:27:34 -0700 (Sat, 05 Sep 2009) | 1 line Changed paths: - M /trunk/epan/dissectors/packet-sip.c - -Make some capitalisation more consistent. + M /trunk/gtk/new_packet_list.c + M /trunk/gtk/packet_list_store.c + M /trunk/gtk/packet_list_store.h +Get rid of row_data_t ------------------------------------------------------------------------ -r23237 | martinm | 2007-10-22 05:16:53 -0700 (Mon, 22 Oct 2007) | 2 lines +r29712 | stig | 2009-09-05 06:30:16 -0700 (Sat, 05 Sep 2009) | 2 lines Changed paths: - M /trunk/epan/dissectors/Makefile.common - D /trunk/epan/dissectors/packet-diameter-defs.h + M /trunk/gtk/main.c -Remove the no-longer-used packet-diameter-defs.h +Apply user font when changing profile with new packet list. ------------------------------------------------------------------------ -r23238 | kukosa | 2007-10-22 05:25:56 -0700 (Mon, 22 Oct 2007) | 1 line +r29713 | krj | 2009-09-05 06:46:17 -0700 (Sat, 05 Sep 2009) | 1 line Changed paths: - M /trunk/epan/asn1.h - M /trunk/epan/dissectors/packet-per.c + M /trunk/gtk/packet_list_store.c -add flags for optional fields of EXTERNAL type into asn1_ctx_t struct +Restore original condition in packet_list_iter_n_children() ------------------------------------------------------------------------ -r23239 | martinm | 2007-10-22 06:31:51 -0700 (Mon, 22 Oct 2007) | 4 lines +r29714 | stig | 2009-09-05 07:37:02 -0700 (Sat, 05 Sep 2009) | 3 lines Changed paths: - M /trunk/epan/dissectors/packet-umts_fp.c - -Show multi-byte variable length fields using FT_BYTES|BASE_HEX. + M /trunk/gtk/new_packet_list.c -Note that there is still a problem with 'Apply as filter' filters. They seem to remember the initial length of the item, and not the final length set using proto_item_set_len() (this is the case for groups of TBs/PDUs). Will investigate when time allows... +Fetch old column width values if we have not initialized the packet list, +so we don't write zero width values if closing before loading a capture. ------------------------------------------------------------------------ -r23240 | wmeier | 2007-10-22 08:13:41 -0700 (Mon, 22 Oct 2007) | 2 lines +r29715 | krj | 2009-09-05 08:25:53 -0700 (Sat, 05 Sep 2009) | 1 line Changed paths: - M /trunk/gtk/rtp_player.c - -From Jim Young: Simple one line patch resolves compiler warning.: Bug #1929 + M /trunk/gtk/new_packet_list.c +Remove dead code. We dont construct columns while reading the file. We do that when we have to display the frame ------------------------------------------------------------------------ -r23241 | gal | 2007-10-22 10:03:09 -0700 (Mon, 22 Oct 2007) | 3 lines +r29716 | krj | 2009-09-05 08:30:34 -0700 (Sat, 05 Sep 2009) | 1 line Changed paths: - M /trunk/asn1/ros/Makefile.common - M /trunk/epan/dissectors/packet-ros.c - M /trunk/epan/dissectors/packet-ros.h - -Update to use the -X and -T flags to asn2wrs. - + M /trunk/gtk/new_packet_list.c +Inline cache_columns() ------------------------------------------------------------------------ -r23242 | gal | 2007-10-22 10:08:03 -0700 (Mon, 22 Oct 2007) | 5 lines +r29717 | krj | 2009-09-05 08:46:47 -0700 (Sat, 05 Sep 2009) | 1 line Changed paths: - M /trunk/asn1/rtse/Makefile.common - M /trunk/asn1/rtse/rtse.cnf - M /trunk/epan/dissectors/packet-rtse.c - M /trunk/epan/dissectors/packet-rtse.h - -Update to use the -X and -T flags. -Removed some workaround code in the .cnf file. -There is still some code for handling an EXTERNAL (EXTERNALt) as the RTSE dissector has its own set of callbacks and consequently can't (currently) use the packet-ber.c functions. - + M /trunk/gtk/new_packet_list.c + M /trunk/gtk/packet_list_store.c + M /trunk/gtk/packet_list_store.h +Move new_packet_list_dissect() to packet_list_store.c. We need to have it there in order to dissect columns on the fly when we have to sort ------------------------------------------------------------------------ -r23243 | gal | 2007-10-22 10:13:08 -0700 (Mon, 22 Oct 2007) | 4 lines +r29718 | krj | 2009-09-05 09:35:05 -0700 (Sat, 05 Sep 2009) | 1 line Changed paths: - M /trunk/asn1/x411/Makefile.common - M /trunk/asn1/x411/x411.asn - M /trunk/asn1/x411/x411.cnf - M /trunk/epan/dissectors/packet-x411.c - M /trunk/epan/dissectors/packet-x411.h - -Update to use the -X and -T asn2wrs flags. -Removed the workaround code from the .cnf file. - + M /trunk/gtk/packet_list_store.c + M /trunk/gtk/packet_list_store.h +Dissect-on-the-fly when we have columns that are empty, i.e. columns containing strings (COL_INFO + friends). This allows us to sort on _all_ columns now. ------------------------------------------------------------------------ -r23244 | gal | 2007-10-22 10:14:42 -0700 (Mon, 22 Oct 2007) | 4 lines +r29719 | stig | 2009-09-05 11:13:48 -0700 (Sat, 05 Sep 2009) | 3 lines Changed paths: - M /trunk/asn1/x420/Makefile.common - M /trunk/epan/dissectors/packet-x420.c - M /trunk/epan/dissectors/packet-x420.h - -Update to use the -X and -T asn2wrs flags. -Straightforward. + M /trunk/gtk/main.c +Move reloading pane geometry to a point where we have the correct +main_first_pane and main_second_pane. ------------------------------------------------------------------------ -r23245 | gal | 2007-10-22 10:16:15 -0700 (Mon, 22 Oct 2007) | 3 lines +r29720 | krj | 2009-09-05 11:28:06 -0700 (Sat, 05 Sep 2009) | 1 line Changed paths: - M /trunk/asn1/s4406/Makefile.common - M /trunk/epan/dissectors/packet-s4406.c - M /trunk/epan/dissectors/packet-s4406.h - -Update to use the -X and -T asn2wrs flags. -Straightfoward. + M /trunk/epan/column-utils.c +Reorder col_fill_in() ------------------------------------------------------------------------ -r23246 | gal | 2007-10-22 10:17:15 -0700 (Mon, 22 Oct 2007) | 3 lines +r29721 | krj | 2009-09-05 11:39:46 -0700 (Sat, 05 Sep 2009) | 1 line Changed paths: - M /trunk/asn1/ess/Makefile.common - M /trunk/epan/dissectors/packet-ess.c - M /trunk/epan/dissectors/packet-ess.h - -Update to use the -X and -T asn2wrs flags. -Straightforward. + M /trunk/epan/column-utils.c + M /trunk/epan/prefs.c +COL_BSSGP_TLLI is deprecated ------------------------------------------------------------------------ -r23247 | gal | 2007-10-22 10:18:42 -0700 (Mon, 22 Oct 2007) | 3 lines +r29722 | krj | 2009-09-05 11:45:55 -0700 (Sat, 05 Sep 2009) | 1 line Changed paths: - M /trunk/asn1/dap/Makefile.common - M /trunk/asn1/dap/dap.cnf - M /trunk/epan/dissectors/packet-dap.c - M /trunk/epan/dissectors/packet-dap.h - -Update to use the -X and -T asn2wrs flags. -Straightforward. + M /trunk/epan/column-utils.c + M /trunk/epan/column-utils.h + M /trunk/epan/libwireshark.def +col_custom_set_fstr() is unused. Remove it ------------------------------------------------------------------------ -r23248 | gal | 2007-10-22 10:20:04 -0700 (Mon, 22 Oct 2007) | 3 lines +r29723 | krj | 2009-09-05 12:07:04 -0700 (Sat, 05 Sep 2009) | 1 line Changed paths: - M /trunk/asn1/disp/Makefile.common - M /trunk/epan/dissectors/packet-disp.c - M /trunk/epan/dissectors/packet-disp.h - -Update to use the -X and -T asn2wrs flags. -Straightforward. + M /trunk/gtk/packet_list_store.c +Don't copy constant column strings. This reduces memory foot print because COL_PROTOCOL is usually a constant string. This saves us 3-4 bytes for each frame ------------------------------------------------------------------------ -r23249 | gal | 2007-10-22 10:21:11 -0700 (Mon, 22 Oct 2007) | 4 lines +r29724 | stig | 2009-09-05 12:42:43 -0700 (Sat, 05 Sep 2009) | 2 lines Changed paths: - M /trunk/asn1/dsp/Makefile.common - M /trunk/epan/dissectors/packet-dsp.c - M /trunk/epan/dissectors/packet-dsp.h - -Update to use the -X and -T asn2wrs flags. -Straightforward. + M /trunk/gtk/main.c +Remove an obsolete gui_time_format setting. ------------------------------------------------------------------------ -r23250 | kukosa | 2007-10-22 12:29:29 -0700 (Mon, 22 Oct 2007) | 1 line +r29725 | stig | 2009-09-05 15:12:51 -0700 (Sat, 05 Sep 2009) | 2 lines Changed paths: - M /trunk/tools/asn2wrs.py + M /trunk/epan/dissectors/packet-capwap.c -fix export of ObjectFieldSpec and ObjectSetFieldSpec of CLASS ------------------------------------------------------------------------- -r23251 | jake | 2007-10-22 22:37:42 -0700 (Mon, 22 Oct 2007) | 2 lines -Changed paths: - M /trunk/epan/dissectors/packet-gdsdb.c +Changed type for "Wireless data" to FT_BYTES. -Fix for bug 1931 and bug 1932: -A never ending while loop and a value to string mapping error. ------------------------------------------------------------------------ -r23252 | etxrab | 2007-10-22 22:50:00 -0700 (Mon, 22 Oct 2007) | 6 lines +r29726 | krj | 2009-09-05 21:26:50 -0700 (Sat, 05 Sep 2009) | 4 lines Changed paths: - M /trunk/asn1/camel/camel.cnf M /trunk/asn1/camel/packet-camel-template.c - M /trunk/asn1/cdt/cdt.cnf - M /trunk/asn1/cmip/cmip.cnf - M /trunk/asn1/dap/dap.cnf - M /trunk/asn1/dap/packet-dap-template.c - M /trunk/asn1/disp/packet-disp-template.c - M /trunk/asn1/dop/packet-dop-template.c - M /trunk/asn1/dsp/packet-dsp-template.c - M /trunk/asn1/gsmmap/gsmmap.cnf - M /trunk/asn1/ldap/packet-ldap-template.c - M /trunk/asn1/ocsp/packet-ocsp-template.c + M /trunk/asn1/gsmmap/packet-gsmmap-template.c M /trunk/asn1/pkixcmp/packet-cmp-template.c - M /trunk/asn1/pkixtsp/packet-pkixtsp-template.c - M /trunk/asn1/rtse/rtse.cnf - M /trunk/asn1/s4406/packet-s4406-template.c - M /trunk/asn1/snmp/snmp.cnf - M /trunk/asn1/t38/packet-t38-template.c - M /trunk/asn1/t38/t38.cnf - M /trunk/asn1/tcap/tcap.cnf - M /trunk/asn1/x411/packet-x411-template.c - M /trunk/asn1/x420/packet-x420-template.c - M /trunk/asn1/x420/x420.cnf - M /trunk/asn1/x509af/packet-x509af-template.c - M /trunk/epan/dissectors/packet-bacapp.c - M /trunk/epan/dissectors/packet-ber.c - M /trunk/epan/dissectors/packet-bgp.c - M /trunk/epan/dissectors/packet-bpdu.c - M /trunk/epan/dissectors/packet-bssgp.c - M /trunk/epan/dissectors/packet-btl2cap.c - M /trunk/epan/dissectors/packet-btrfcomm.c + M /trunk/asn1/smrse/packet-smrse-template.c + M /trunk/epan/dissectors/packet-camel.c M /trunk/epan/dissectors/packet-catapult-dct2000.c - M /trunk/epan/dissectors/packet-cigi.c - M /trunk/epan/dissectors/packet-cimd.c - M /trunk/epan/dissectors/packet-cip.c - M /trunk/epan/dissectors/packet-cisco-wids.c - M /trunk/epan/dissectors/packet-clnp.c - M /trunk/epan/dissectors/packet-ctdb.c - M /trunk/epan/dissectors/packet-daap.c - M /trunk/epan/dissectors/packet-dcerpc-spoolss.c - M /trunk/epan/dissectors/packet-dcerpc.c - M /trunk/epan/dissectors/packet-dcom-remunkn.c - M /trunk/epan/dissectors/packet-dcp.c - M /trunk/epan/dissectors/packet-dec-dnart.c - M /trunk/epan/dissectors/packet-diameter.c - M /trunk/epan/dissectors/packet-distcc.c - M /trunk/epan/dissectors/packet-dmp.c - M /trunk/epan/dissectors/packet-dnp.c - M /trunk/epan/dissectors/packet-drda.c - M /trunk/epan/dissectors/packet-dtls.c - M /trunk/epan/dissectors/packet-echo.c - M /trunk/epan/dissectors/packet-edonkey.c - M /trunk/epan/dissectors/packet-enip.c - M /trunk/epan/dissectors/packet-epl.c - M /trunk/epan/dissectors/packet-epl_v1.c - M /trunk/epan/dissectors/packet-ethertype.c - M /trunk/epan/dissectors/packet-fcels.c - M /trunk/epan/dissectors/packet-fcip.c - M /trunk/epan/dissectors/packet-fcoe.c - M /trunk/epan/dissectors/packet-fix.c - M /trunk/epan/dissectors/packet-giop.c - M /trunk/epan/dissectors/packet-h1.c - M /trunk/epan/dissectors/packet-h248_annex_c.c - M /trunk/epan/dissectors/packet-hsrp.c - M /trunk/epan/dissectors/packet-iax2.c - M /trunk/epan/dissectors/packet-icep.c - M /trunk/epan/dissectors/packet-icmpv6.c - M /trunk/epan/dissectors/packet-ieee80211.c - M /trunk/epan/dissectors/packet-igap.c - M /trunk/epan/dissectors/packet-igrp.c - M /trunk/epan/dissectors/packet-imf.c - M /trunk/epan/dissectors/packet-ip.c - M /trunk/epan/dissectors/packet-ipmi.c - M /trunk/epan/dissectors/packet-ipv6.c - M /trunk/epan/dissectors/packet-isakmp.c - M /trunk/epan/dissectors/packet-iscsi.c - M /trunk/epan/dissectors/packet-isis-hello.c - M /trunk/epan/dissectors/packet-isis-lsp.c - M /trunk/epan/dissectors/packet-isis-snp.c - M /trunk/epan/dissectors/packet-isns.c - M /trunk/epan/dissectors/packet-iuup.c - M /trunk/epan/dissectors/packet-jxta.c - M /trunk/epan/dissectors/packet-kink.c - M /trunk/epan/dissectors/packet-ldp.c - M /trunk/epan/dissectors/packet-llc.c - M /trunk/epan/dissectors/packet-loop.c - M /trunk/epan/dissectors/packet-lwapp.c - M /trunk/epan/dissectors/packet-media.c - M /trunk/epan/dissectors/packet-mpls.c - M /trunk/epan/dissectors/packet-mq-pcf.c - M /trunk/epan/dissectors/packet-mq.c - M /trunk/epan/dissectors/packet-mrdisc.c - M /trunk/epan/dissectors/packet-ms-mms.c - M /trunk/epan/dissectors/packet-msn-messenger.c - M /trunk/epan/dissectors/packet-msnip.c - M /trunk/epan/dissectors/packet-msnlb.c - M /trunk/epan/dissectors/packet-mtp3mg.c - M /trunk/epan/dissectors/packet-multipart.c - M /trunk/epan/dissectors/packet-mysql.c - M /trunk/epan/dissectors/packet-nbd.c - M /trunk/epan/dissectors/packet-nbipx.c - M /trunk/epan/dissectors/packet-nbns.c - M /trunk/epan/dissectors/packet-ncp-sss.c - M /trunk/epan/dissectors/packet-ncp.c - M /trunk/epan/dissectors/packet-ncp2222.inc - M /trunk/epan/dissectors/packet-ndps.c - M /trunk/epan/dissectors/packet-netbios.c - M /trunk/epan/dissectors/packet-nhrp.c - M /trunk/epan/dissectors/packet-ntlmssp.c - M /trunk/epan/dissectors/packet-omapi.c - M /trunk/epan/dissectors/packet-p_mul.c - M /trunk/epan/dissectors/packet-pgsql.c - M /trunk/epan/dissectors/packet-portmap.c - M /trunk/epan/dissectors/packet-ppp.c - M /trunk/epan/dissectors/packet-pppoe.c - M /trunk/epan/dissectors/packet-pptp.c + M /trunk/epan/dissectors/packet-cmp.c + M /trunk/epan/dissectors/packet-dlm3.c + M /trunk/epan/dissectors/packet-gsm_map.c + M /trunk/epan/dissectors/packet-hip.c + M /trunk/epan/dissectors/packet-ieee802154.c + M /trunk/epan/dissectors/packet-mtp2.c + M /trunk/epan/dissectors/packet-nat-pmp.c M /trunk/epan/dissectors/packet-ptp.c - M /trunk/epan/dissectors/packet-pvfs2.c - M /trunk/epan/dissectors/packet-rgmp.c - M /trunk/epan/dissectors/packet-rmi.c - M /trunk/epan/dissectors/packet-rmt-norm.c - M /trunk/epan/dissectors/packet-rpc.c - M /trunk/epan/dissectors/packet-rsvp.c - M /trunk/epan/dissectors/packet-rsync.c - M /trunk/epan/dissectors/packet-rtps.c - M /trunk/epan/dissectors/packet-rtsp.c - M /trunk/epan/dissectors/packet-scsi-osd.c - M /trunk/epan/dissectors/packet-sigcomp.c - M /trunk/epan/dissectors/packet-slimp3.c - M /trunk/epan/dissectors/packet-smb.c - M /trunk/epan/dissectors/packet-smb2.c - M /trunk/epan/dissectors/packet-smtp.c - M /trunk/epan/dissectors/packet-sna.c - M /trunk/epan/dissectors/packet-sqloracle.c - M /trunk/epan/dissectors/packet-ssh.c - M /trunk/epan/dissectors/packet-ssl.c - M /trunk/epan/dissectors/packet-starteam.c - M /trunk/epan/dissectors/packet-symantec.c - M /trunk/epan/dissectors/packet-tcp.c - M /trunk/epan/dissectors/packet-telnet.c - M /trunk/epan/dissectors/packet-tftp.c - M /trunk/epan/dissectors/packet-tns.c - M /trunk/epan/dissectors/packet-tuxedo.c - M /trunk/epan/dissectors/packet-usb.c - M /trunk/epan/dissectors/packet-winsrepl.c - M /trunk/epan/dissectors/packet-wsp.c - M /trunk/epan/dissectors/packet-x11.c - M /trunk/epan/dissectors/packet-x29.c - M /trunk/epan/dissectors/packet-xdmcp.c - M /trunk/epan/dissectors/packet-ypserv.c - -Apply the small performance enhancment patches for: -- if offset is 0, tvb_length is the same as tvb_length_remaining, just faster. -Replace -- col_append_fstr() with faster col_append_str() -- col_add_str() with col_set_str() -when it's safe ------------------------------------------------------------------------- -r23253 | martinm | 2007-10-23 04:02:08 -0700 (Tue, 23 Oct 2007) | 7 lines -Changed paths: - M /trunk/epan/dissectors/packet-umts_fp.c - M /trunk/epan/proto.c - -Make groups of PDUs filterable as large FT_BYTES items -(where the initial length isn't readily available when item is first added) - -Note that this still won't work where an initial length of 0 is given for -the item that will later be extended using proto_item_set_len(), as the -pointer value part of the zero-length array will reamin NULL... - ------------------------------------------------------------------------- -r23254 | guy | 2007-10-23 19:12:46 -0700 (Tue, 23 Oct 2007) | 3 lines -Changed paths: - M /trunk/epan/dissectors/packet-diameter.c - -Make sure characters aren't sign-extended before being handed to -isalnum(). - ------------------------------------------------------------------------- -r23255 | guy | 2007-10-23 19:28:03 -0700 (Tue, 23 Oct 2007) | 4 lines -Changed paths: - M /trunk/epan/dissectors/Makefile.common - -packet-diameter.c should now compile without warnings. Mark it as a -clean dissector (so that the buildbots compile it with -Werror, in the -hopes of keeping it clean). - ------------------------------------------------------------------------- -r23256 | guy | 2007-10-23 20:33:35 -0700 (Tue, 23 Oct 2007) | 8 lines -Changed paths: - M /trunk/tshark.c - -Use sigaction(), not signal(), so we know what its semantics are (and so -that we can find out what the signal action for SIGHUP is without -changing it). - -That renders report_counts() safe to use at the end of a capture; do so. - -Clean up indentation. - ------------------------------------------------------------------------- -r23257 | guy | 2007-10-23 21:13:30 -0700 (Tue, 23 Oct 2007) | 3 lines -Changed paths: - M /trunk/tshark.c - -"sa_mask" in a "struct sigaction" is a sigset_t, which is not -necessarily an integral data type. Use sigemptyset() to clear it. + M /trunk/epan/dissectors/packet-rpl.c + M /trunk/epan/dissectors/packet-smrse.c + M /trunk/epan/dissectors/packet-wow.c + M /trunk/epan/dissectors/packet-zbee-aps.c + M /trunk/epan/dissectors/packet-zbee-nwk.c + M /trunk/epan/dissectors/packet-zbee-zdp.c + M /trunk/epan/value_string.c + M /trunk/epan/value_string.h ------------------------------------------------------------------------- -r23258 | guy | 2007-10-23 23:21:05 -0700 (Tue, 23 Oct 2007) | 3 lines -Changed paths: - M /trunk/asn1/mpeg-pes/packet-mpeg-pes-template.c - M /trunk/epan/dissectors/packet-mpeg-pes.c +Don't pass ep_alloc()'ed strings to col_set_str(). -"time_t" might be an "int" or might be a "long"; cast it to "long" and -print it with "%ld". (It's typically signed.) +Fixes https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=3984 ------------------------------------------------------------------------ -r23259 | guy | 2007-10-23 23:54:58 -0700 (Tue, 23 Oct 2007) | 6 lines +r29727 | krj | 2009-09-05 22:29:51 -0700 (Sat, 05 Sep 2009) | 1 line Changed paths: - M /trunk/asn1/h460/CALL-PARTY-CATEGORY.asn - M /trunk/asn1/h460/CALL-PRIORITY.asn - M /trunk/asn1/h460/CIRCUIT-STATUS-MAP.asn - M /trunk/asn1/h460/MEDIA-TRAVERSAL.asn - M /trunk/asn1/h460/MESSAGE-BROADCAST.asn - M /trunk/asn1/h460/MLPP.asn - M /trunk/asn1/h460/Makefile.am - M /trunk/asn1/h460/Makefile.common - M /trunk/asn1/h460/Makefile.nmake - M /trunk/asn1/h460/NUMBER-PORTABILITY.asn - M /trunk/asn1/h460/QOS-MONITORING-EXTENDED-VOIP-REPORT.asn - M /trunk/asn1/h460/QOS-MONITORING-REPORT.asn - M /trunk/asn1/h460/SIGNALLING-CHANNEL-SUSPEND-REDIRECT.asn - M /trunk/asn1/h460/SIGNALLING-TRAVERSAL.asn - M /trunk/asn1/h460/h460.cnf - M /trunk/asn1/h460/packet-h460-template.c - -Get rid of CRs, and set svn:eol-style to native. - -Set svn:keywords to Id while we're at it. - -Get rid of extra blank lines at the ends of files. + M /trunk/asn1/camel/packet-camel-template.c + M /trunk/asn1/gsmmap/packet-gsmmap-template.c + M /trunk/asn1/pkixcmp/packet-cmp-template.c + M /trunk/asn1/smrse/packet-smrse-template.c + M /trunk/epan/dissectors/packet-camel.c + M /trunk/epan/dissectors/packet-cmp.c + M /trunk/epan/dissectors/packet-gsm_map.c + M /trunk/epan/dissectors/packet-nat-pmp.c + M /trunk/epan/dissectors/packet-ptp.c + M /trunk/epan/dissectors/packet-smrse.c +s/col_add_fstr/col_add_str ------------------------------------------------------------------------ -r23260 | guy | 2007-10-23 23:56:07 -0700 (Tue, 23 Oct 2007) | 2 lines +r29728 | krj | 2009-09-05 22:49:00 -0700 (Sat, 05 Sep 2009) | 4 lines Changed paths: - M /trunk/asn1/h460/CALL-PARTY-CATEGORY.asn - M /trunk/asn1/h460/CALL-PRIORITY.asn - M /trunk/asn1/h460/CIRCUIT-STATUS-MAP.asn - M /trunk/asn1/h460/MEDIA-TRAVERSAL.asn - M /trunk/asn1/h460/MESSAGE-BROADCAST.asn - M /trunk/asn1/h460/MLPP.asn - M /trunk/asn1/h460/Makefile.am - M /trunk/asn1/h460/Makefile.common - M /trunk/asn1/h460/Makefile.nmake - M /trunk/asn1/h460/NUMBER-PORTABILITY.asn - M /trunk/asn1/h460/QOS-MONITORING-EXTENDED-VOIP-REPORT.asn - M /trunk/asn1/h460/QOS-MONITORING-REPORT.asn - M /trunk/asn1/h460/SIGNALLING-CHANNEL-SUSPEND-REDIRECT.asn - M /trunk/asn1/h460/SIGNALLING-TRAVERSAL.asn - M /trunk/asn1/h460/h460.cnf + M /trunk/gtk/new_packet_list.c + M /trunk/gtk/packet_list_store.c + M /trunk/gtk/packet_list_store.h -Set svn:eol-style to native and svn:keywords to Id. +Make sure that we can enable/disable color filtering. ------------------------------------------------------------------------- -r23261 | guy | 2007-10-24 00:14:34 -0700 (Wed, 24 Oct 2007) | 2 lines -Changed paths: - M /trunk/asn1/h460/packet-h460-template.c - M /trunk/epan/dissectors/packet-h460.c - -Squelch warnings about uninitialized structure members. +Fixes http://wiki.wireshark.org/Development/OptimizePacketList?action=diff&rev1=11&rev2=12 ------------------------------------------------------------------------ -r23262 | kukosa | 2007-10-24 01:30:46 -0700 (Wed, 24 Oct 2007) | 1 line +r29729 | krj | 2009-09-05 23:07:53 -0700 (Sat, 05 Sep 2009) | 1 line Changed paths: - M /trunk/epan/Makefile.common - A /trunk/epan/tap-voip.h - M /trunk/gtk/voip_calls.c - M /trunk/gtk/voip_calls.h - M /trunk/gtk/voip_calls_dlg.c + M /trunk/color_filters.c + M /trunk/color_filters.h + M /trunk/gtk/packet_list_store.c -add common VoIP TAP listener "voip" which can be used in arbitrary experimental/proprietary protocol (implemented e.g. in plugin) and allows it to make graphs and replay streams +Add NEW_PACKET_LIST guard to color_filters_colorize_packet() ------------------------------------------------------------------------ -r23263 | kukosa | 2007-10-24 02:10:43 -0700 (Wed, 24 Oct 2007) | 1 line +r29730 | krj | 2009-09-05 23:33:13 -0700 (Sat, 05 Sep 2009) | 1 line Changed paths: - M /trunk/gtk/voip_calls.c + M /trunk/epan/dissectors/packet-frame.c + M /trunk/epan/proto.c + M /trunk/epan/proto.h -fix voip_calls.c:126: warning: missing initializer +The frame dissector disables the TRY_TO_FAKE_THIS_ITEM() optimization by marking the protocol tree as permamently visible. It only needs to disable the optimization temporarily while it creates the protocol item it intends to use proto_item_append_string() on ------------------------------------------------------------------------ -r23264 | martinm | 2007-10-24 02:21:13 -0700 (Wed, 24 Oct 2007) | 2 lines +r29731 | krj | 2009-09-06 00:24:54 -0700 (Sun, 06 Sep 2009) | 1 line Changed paths: - M /trunk/gtk/voip_calls_dlg.c - -Add missing case. + M /trunk/epan/proto.c + M /trunk/epan/proto.h +Introduce TRY_TO_FAKE_THIS_REPR which is an optimization similar to the existing TRY_TO_FAKE_THIS_ITEM. The purpose of TRY_TO_FAKE_THIS_REPR is to avoid generating the string representation for the protocol item. There is no point in doing this if the protocol tree isn't visible. In this case the result will be discarded any way. ------------------------------------------------------------------------ -r23265 | etxrab | 2007-10-24 08:04:01 -0700 (Wed, 24 Oct 2007) | 1 line +r29732 | krj | 2009-09-06 00:33:07 -0700 (Sun, 06 Sep 2009) | 1 line Changed paths: - M /trunk/epan/dissectors/packet-diameter.c - M /trunk/epan/dissectors/packet-uma.c + M /trunk/epan/proto.c -Add port ranges. +This fix was supposed to be in r29731 which some how only contained whitespace changes. ------------------------------------------------------------------------ -r23266 | gerald | 2007-10-24 09:32:51 -0700 (Wed, 24 Oct 2007) | 2 lines +r29733 | krj | 2009-09-06 00:55:17 -0700 (Sun, 06 Sep 2009) | 7 lines Changed paths: - M /trunk/epan/dissectors/packet-diameter.c - M /trunk/epan/dissectors/packet-uma.c + M /trunk/epan/dissectors/packet-frame.c + M /trunk/epan/packet.c + M /trunk/epan/packet_info.h -Remove a couple of unused variables. +We track all protocols that appear in each packet in the frame dissector. This is an expensive operation because we: ------------------------------------------------------------------------- -r23267 | gerald | 2007-10-24 09:43:45 -0700 (Wed, 24 Oct 2007) | 2 lines -Changed paths: - M /trunk/docbook/release-notes.xml +* Disable the TRY_TO_FAKE_THIS_ITEM optimization +* Use GString to store the protocols -Add an item for the recent packet-gdsdb.c fixes. +We should only do this if the 'hf_frame_protocols' is referenced (unlikely) ------------------------------------------------------------------------ -r23268 | etxrab | 2007-10-24 14:47:13 -0700 (Wed, 24 Oct 2007) | 2 lines +r29734 | krj | 2009-09-06 01:10:12 -0700 (Sun, 06 Sep 2009) | 1 line Changed paths: - M /trunk/epan/dissectors/packet-rtsp.c - M /trunk/epan/dissectors/packet-text-media.c - M /trunk/epan/dissectors/packet-xml.c + M /trunk/epan/emem.c -Use the media_type_dissector_table for the content type. -Add a few media types. +Avoid calling emem_create_chunk() needlessly ------------------------------------------------------------------------ -r23269 | etxrab | 2007-10-24 14:52:44 -0700 (Wed, 24 Oct 2007) | 1 line +r29735 | etxrab | 2009-09-06 01:59:30 -0700 (Sun, 06 Sep 2009) | 4 lines Changed paths: - M /trunk/epan/dissectors/packet-rtsp.c + M /trunk/epan/addr_resolv.c -Remove unused variable. +From Didier Gautheron: +Extracted from optimizations patch http://wiki.wireshark.org/Development/Optimization +Optimize address handling. +The address hash should be possible to use from the new_packet_list. ------------------------------------------------------------------------ -r23270 | kukosa | 2007-10-25 02:38:15 -0700 (Thu, 25 Oct 2007) | 4 lines +r29736 | krj | 2009-09-06 02:03:15 -0700 (Sun, 06 Sep 2009) | 1 line Changed paths: - M /trunk/epan/Makefile.common - A /trunk/epan/codecs.c - A /trunk/epan/codecs.h - M /trunk/epan/libwireshark.def - M /trunk/epan/plugins.c - M /trunk/epan/plugins.h - M /trunk/gtk/plugins_dlg.c - M /trunk/gtk/rtp_player.c + M /trunk/epan/column-utils.c -new codec table for registering codecs by name -new codec plugin type -search registered codecs in rtp player -fix memory leak in rtp player +Macrofy check_col() -> CHECK_COL() internally in columns-utils.c ------------------------------------------------------------------------ -r23271 | kukosa | 2007-10-25 05:24:01 -0700 (Thu, 25 Oct 2007) | 1 line +r29737 | krj | 2009-09-06 02:11:17 -0700 (Sun, 06 Sep 2009) | 1 line Changed paths: - M /trunk/gtk/voip_calls.c + M /trunk/epan/column-utils.c -do not update call_state if new call_state == VOIP_NO_STATE +Macrofy have_custom_cols() -> HAVE_CUSTOM_COLS() internally in columns-utils.c ------------------------------------------------------------------------ -r23272 | gerald | 2007-10-25 13:37:12 -0700 (Thu, 25 Oct 2007) | 2 lines +r29738 | krj | 2009-09-06 02:36:21 -0700 (Sun, 06 Sep 2009) | 1 line Changed paths: - M /trunk/capture_sync.c - -Fix a typo. + M /trunk/gtk/packet_list_store.c +Sort the visible list while traversing the physical row list. This halves the time needed to sort ------------------------------------------------------------------------ -r23273 | etxrab | 2007-10-25 22:42:12 -0700 (Thu, 25 Oct 2007) | 4 lines +r29739 | krj | 2009-09-06 03:03:06 -0700 (Sun, 06 Sep 2009) | 1 line Changed paths: - M /trunk/epan/addr_resolv.c M /trunk/epan/column-utils.c - M /trunk/epan/strutil.c - M /trunk/epan/strutil.h - -Apply yet another set of the optimization patches: -Replace strncpy with g_strlcpy. -Add g_strlcat for GTK1 and don't use g_snprintf in GTK1 g_strlcpy -printf family is very slow. ------------------------------------------------------------------------- -r23274 | kukosa | 2007-10-26 00:18:44 -0700 (Fri, 26 Oct 2007) | 1 line -Changed paths: - M /trunk/asn1/h460/CALL-PARTY-CATEGORY.asn - M /trunk/asn1/h460/CALL-PRIORITY.asn - M /trunk/asn1/h460/CIRCUIT-STATUS-MAP.asn - M /trunk/asn1/h460/MEDIA-TRAVERSAL.asn - M /trunk/asn1/h460/MESSAGE-BROADCAST.asn - M /trunk/asn1/h460/MLPP.asn - M /trunk/asn1/h460/NUMBER-PORTABILITY.asn - M /trunk/asn1/h460/QOS-MONITORING-EXTENDED-VOIP-REPORT.asn - M /trunk/asn1/h460/QOS-MONITORING-REPORT.asn - -fix wrong headers in H.460.x ASN.1 sources ------------------------------------------------------------------------- -r23275 | kukosa | 2007-10-26 00:42:29 -0700 (Fri, 26 Oct 2007) | 1 line -Changed paths: - M /trunk/asn1/Makefile.am - M /trunk/asn1/Makefile.nmake - A /trunk/asn1/h501 - A /trunk/asn1/h501/H501-MESSAGES.asn - A /trunk/asn1/h501/Makefile.am - A /trunk/asn1/h501/Makefile.common - A /trunk/asn1/h501/Makefile.nmake - A /trunk/asn1/h501/h501.cnf - A /trunk/asn1/h501/packet-h501-template.c - M /trunk/configure.in - M /trunk/epan/dissectors/Makefile.common - A /trunk/epan/dissectors/packet-h501.c -H.501 Mobility protocol implemented +Inline col_has_time_fmt() into col_based_on_frame_data() ------------------------------------------------------------------------ -r23276 | martinm | 2007-10-26 03:38:16 -0700 (Fri, 26 Oct 2007) | 2 lines +r29740 | krj | 2009-09-06 03:41:35 -0700 (Sun, 06 Sep 2009) | 1 line Changed paths: - M /trunk/plugins/wimaxasncp/packet-wimaxasncp.c - -Add expert item for cases of unmatched function type or message op. + M /trunk/gtk/packet_list_store.c +Tigthen the condition under which we create a protocol create while sorting ------------------------------------------------------------------------ -r23277 | wmeier | 2007-10-26 08:26:04 -0700 (Fri, 26 Oct 2007) | 2 lines +r29741 | stig | 2009-09-06 04:24:56 -0700 (Sun, 06 Sep 2009) | 7 lines Changed paths: - M /trunk/doc/README.developer + M /trunk/epan/dissectors/packet-homeplug.c -From Andrew Feren: Fix an assortment of typos and other minor errors +Use correct field types for variable length fields. +Fixed types by adding new types for "undissected" blocks: +- Replace Bridge Address +- Multicast With Response +- Confirm Network Encryption Key +- Host Tag ------------------------------------------------------------------------ -r23278 | morriss | 2007-10-26 09:19:18 -0700 (Fri, 26 Oct 2007) | 1 line +r29742 | krj | 2009-09-06 04:30:41 -0700 (Sun, 06 Sep 2009) | 1 line Changed paths: - M /trunk/epan/dissectors/packet-mtp2.c + M /trunk/epan/proto.c -Show the acronyms for LSSU types in the Info column rather than the long description (and don't tell the user it's an LSSU, they already know that). Also, there is no such thing as a SIBO, it's a SIB. +We don't currently fake fields if they are referenced indirectly through some other fields (currently only FT_PROTOCOL's can be indirectly referenced) . However, there doesn't seem to be any reason for this restriction. We already have proto_tree_set_fake_protocols() to disable 'faking' if any clients requires this. So, this changelist removes this restriction on indirectly referenced fields. ------------------------------------------------------------------------ -r23279 | gerald | 2007-10-26 09:32:28 -0700 (Fri, 26 Oct 2007) | 10 lines +r29743 | krj | 2009-09-06 05:27:32 -0700 (Sun, 06 Sep 2009) | 1 line Changed paths: - M /trunk/Makefile.nmake - M /trunk/capture_loop.c - M /trunk/capture_sync.c - M /trunk/capture_sync.h - M /trunk/dumpcap.c - -For the Wireshark/TShark -> dumpcap signal pipe on Windows, use a named -pipe instead of stdin. Add an argument (currently the parent PID) back -to the "-Z" flag and use it to construct the pipe name. This lets us -pass the parent's stdin handle to dumpcap, which lets us capture from -stdin on Windows. Add a comment about checking for the parent process. - -In capture_loop.c, remove the wait_forever argument from cap_pipe_select() -since it was always FALSE. Set the timeout under Windows to 250 ms -instead of 250000 ms. + M /trunk/gtk/packet_list_store.c + M /trunk/gtk/packet_list_store.h +Fix target of assignment not really an lvalue error ------------------------------------------------------------------------ -r23280 | martinm | 2007-10-26 09:53:08 -0700 (Fri, 26 Oct 2007) | 2 lines +r29744 | krj | 2009-09-06 06:25:31 -0700 (Sun, 06 Sep 2009) | 1 line Changed paths: - M /trunk/epan/dissectors/packet-diameter.c - -Remove some unnecessary includes. + M /trunk/epan/column-utils.c +Remove static custom column variable which is no longer used ------------------------------------------------------------------------ -r23281 | martinm | 2007-10-26 09:57:54 -0700 (Fri, 26 Oct 2007) | 2 lines +r29745 | krj | 2009-09-06 06:35:27 -0700 (Sun, 06 Sep 2009) | 1 line Changed paths: - M /trunk/epan/dissectors/packet-lwapp.c - -Stop including xmlstab.h + M /trunk/epan/column-utils.c +Remove already #if 0'ed code that was made redundant due to COL_CIRCUIT_ID custom column deprecation ------------------------------------------------------------------------ -r23282 | morriss | 2007-10-26 15:17:45 -0700 (Fri, 26 Oct 2007) | 1 line +r29746 | krj | 2009-09-06 07:00:28 -0700 (Sun, 06 Sep 2009) | 1 line Changed paths: - M /trunk/epan/dissectors/packet-sccp.c + M /trunk/tap-sctpchunkstat.c -Minor indentation changes +Dont declare address_to_str(). Pull in <epan/to_str.h> instead ------------------------------------------------------------------------ -r23283 | sfisher | 2007-10-26 22:11:50 -0700 (Fri, 26 Oct 2007) | 4 lines +r29747 | krj | 2009-09-06 07:25:47 -0700 (Sun, 06 Sep 2009) | 5 lines Changed paths: - M /trunk/gtk/toolbar.c - - -Remove empty #if / #endif block - + M /trunk/asn1/ansi-tcap/packet-ansi_tcap-template.c + M /trunk/asn1/ansi_map/packet-ansi_map-template.c + M /trunk/asn1/h245/packet-h245-template.c + M /trunk/epan/addr_resolv.c + M /trunk/epan/addr_resolv.h + M /trunk/epan/dissectors/packet-acn.c + M /trunk/epan/dissectors/packet-ansi_map.c + M /trunk/epan/dissectors/packet-ansi_tcap.c + M /trunk/epan/dissectors/packet-dtls.c + M /trunk/epan/dissectors/packet-h245.c + M /trunk/epan/dissectors/packet-http.c + M /trunk/epan/dissectors/packet-iax2.c + M /trunk/epan/dissectors/packet-ieee802154.c + M /trunk/epan/dissectors/packet-ipx.c + M /trunk/epan/dissectors/packet-jxta.c + M /trunk/epan/dissectors/packet-pagp.c + M /trunk/epan/dissectors/packet-rtcp.c + M /trunk/epan/dissectors/packet-rtp.c + M /trunk/epan/dissectors/packet-sccp.c + M /trunk/epan/dissectors/packet-ssl-utils.c + M /trunk/epan/dissectors/packet-tacacs.c + M /trunk/epan/gcp.c + M /trunk/epan/libwireshark.def + M /trunk/epan/tcap-persistentdata.c + M /trunk/epan/to_str.c + M /trunk/epan/to_str.h + M /trunk/gtk/compare_stat.c + M /trunk/gtk/conversations_table.c + M /trunk/gtk/hostlist_table.c + M /trunk/gtk/mcast_stream_dlg.c + M /trunk/gtk/rtp_stream_dlg.c + M /trunk/gtk/sctp_chunk_stat.c + M /trunk/gtk/tcp_graph.c + M /trunk/gtk/wlan_stat_dlg.c + M /trunk/plugins/stats_tree/pinfo_stats_tree.c + M /trunk/tap-iousers.c + M /trunk/tap-sctpchunkstat.c ------------------------------------------------------------------------- -r23284 | jake | 2007-10-27 02:24:31 -0700 (Sat, 27 Oct 2007) | 5 lines -Changed paths: - M /trunk/epan/dissectors/packet-dhcpv6.c +Rename address_to_str() to ep_address_to_str() because: -Fix for bug 1935. -RFC3315 says that the vendor-specific information option must encapsulate each -option in the format code/length/value. The current dhcpv6 dissector does not -differentiate these fields, it just puts it all together as one option-data -field. Attached is a patch that addresses this issue. ------------------------------------------------------------------------- -r23285 | etxrab | 2007-10-27 07:44:29 -0700 (Sat, 27 Oct 2007) | 6 lines -Changed paths: - M /trunk/epan/column-utils.c - M /trunk/epan/ipproto.c - M /trunk/epan/strutil.c - M /trunk/epan/strutil.h - M /trunk/epan/tvbuff.c +1) This indicates that the string has ephemeral lifetime +2) More consistent with its existing seasonal counterpart, se_address_to_str(). -Apply yet another set of the optimization patches: -- Use a fast path for the most common use of tvb_get_xxx functions: -offset is >= 0 and tvb->real_data is set (this one is always true). -- match_strval() is a linear search, put the most common protocols -TCP/UDP/RDP first. -- fix gtk1 g_strlcat declaration Use g_strlcat ------------------------------------------------------------------------ -r23286 | etxrab | 2007-10-27 07:57:46 -0700 (Sat, 27 Oct 2007) | 2 lines +r29748 | krj | 2009-09-06 07:39:53 -0700 (Sun, 06 Sep 2009) | 1 line Changed paths: - M /trunk/epan/dissectors/packet-rtsp.c + M /trunk/epan/to_str.c -From Andrew Feren: -patch to test for NULL media_type_str_lower_case. +Change se_address_to_str() to call address_to_str_buf() directly ------------------------------------------------------------------------ -r23287 | etxrab | 2007-10-27 08:02:07 -0700 (Sat, 27 Oct 2007) | 3 lines +r29749 | etxrab | 2009-09-06 07:53:21 -0700 (Sun, 06 Sep 2009) | 5 lines Changed paths: - M /trunk/epan/packet.c + M /trunk/epan/addr_resolv.c -From Andrew Feren: -return FALSE if dissector_try_string(...) is passed a NULL string pointer -arguably this should assert instead. +Put back +http://anonsvn.wireshark.org/viewvc?view=rev&revision=29656 +http://anonsvn.wireshark.org/viewvc?view=rev&revision=29658 +http://anonsvn.wireshark.org/viewvc?view=rev&revision=29661 +Reverted by my previous checkin. ------------------------------------------------------------------------ -r23288 | etxrab | 2007-10-27 08:28:35 -0700 (Sat, 27 Oct 2007) | 3 lines +r29750 | gerald | 2009-09-06 08:03:28 -0700 (Sun, 06 Sep 2009) | 1 line Changed paths: - M /trunk/epan/dissectors/packet-edonkey.c - M /trunk/epan/dissectors/packet-edonkey.h + M /trunk/epan/enterprise-numbers + M /trunk/manuf -From Stefano Picerno: -I made some updates to the edonkey dissector. -Most kademlia1 and some kademlia2 messages are now completely decoded. +[Automatic manuf and enterprise-numbers update for 2009-09-06] ------------------------------------------------------------------------ -r23289 | etxrab | 2007-10-27 08:38:22 -0700 (Sat, 27 Oct 2007) | 8 lines +r29753 | krj | 2009-09-06 08:06:41 -0700 (Sun, 06 Sep 2009) | 1 line Changed paths: - M /trunk/epan/dissectors/packet-giop.c - -From Steve Osselton: -The GIOP Fragment message type was added as of GIOP 1.1. However the Fragment -message header (containing a request id) was only added as of GIOP 1.2. The -GIOP Fragment dissector incorrectly attempts to process the request id for a -version 1.1 request. + M /trunk/epan/to_str.c -To fix add a version check to the dissect_giop_fragment function in -packet-giop.c: +Reorder file to group related functionality ------------------------------------------------------------------------ -r23290 | etxrab | 2007-10-27 08:44:12 -0700 (Sat, 27 Oct 2007) | 2 lines +r29754 | krj | 2009-09-06 11:25:23 -0700 (Sun, 06 Sep 2009) | 4 lines Changed paths: - M /trunk/epan/dissectors/packet-nettl.c - M /trunk/wiretap/nettl.c - M /trunk/wiretap/nettl.h + M /trunk/epan/circuit.c + M /trunk/epan/circuit.h + M /trunk/epan/conversation.c + M /trunk/epan/conversation.h + M /trunk/epan/epan.c + M /trunk/epan/epan.h + M /trunk/epan/expert.c + M /trunk/epan/expert.h + M /trunk/epan/packet.c + M /trunk/epan/reassemble.c + M /trunk/epan/reassemble.h + M /trunk/epan/reassemble_test.c + M /trunk/epan/stream.c + M /trunk/epan/stream.h + M /trunk/file.c + M /trunk/rawshark.c + M /trunk/tshark.c -From Mark C. Brown: -Add support for the new NS_LS_SCTP tracing subsystem. ------------------------------------------------------------------------- -r23291 | etxrab | 2007-10-27 08:48:47 -0700 (Sat, 27 Oct 2007) | 11 lines -Changed paths: - M /trunk/epan/dissectors/packet-tipc.c +Split a bunch of init routines into init() and cleanup(). This allows us to free memory properly on shutdown. -From Martin Peylo: -Enhancement: -- TIPC is available in a new version (1.7), adding/removing fields while -keeping the same version number (2). +This is an initial step. There's still some work to do. -Minor bugs: -- In NAME_DISTRIBUTOR messages the origianting and destination node are -switched. -- The used size of BUNDLER messages payload is not calculated correctly when -size%4=0, this leads to the wrong assumption that the message would be -malformed. ------------------------------------------------------------------------ -r23292 | etxrab | 2007-10-27 08:53:29 -0700 (Sat, 27 Oct 2007) | 6 lines +r29755 | stig | 2009-09-06 18:19:26 -0700 (Sun, 06 Sep 2009) | 3 lines Changed paths: - M /trunk/epan/dissectors/packet-ipmi.c + M /trunk/epan/dissectors/packet-homeplug.c -From Stephane Chazelas: -The description of the most significant bit of the "Device Revision" byte of -the response to a "Get Device ID" is the wrong way round. 1 means "device -provides Device SDRs" and not the contrary according to IPMI specs 1.5 and 2.0. +Don't pass length 0 to a FT_UINT. +Fixed some uint types with length 2. -Also, I noticed in that file that "Chassis" is spelled "Chasis". ------------------------------------------------------------------------ -r23293 | etxrab | 2007-10-27 09:49:13 -0700 (Sat, 27 Oct 2007) | 9 lines +r29756 | jmayer | 2009-09-07 00:26:43 -0700 (Mon, 07 Sep 2009) | 8 lines Changed paths: - M /trunk/epan/dissectors/packet-bootp.c + M /trunk/CMakeLists.txt + M /trunk/cmake/modules/FindADNS.cmake + A /trunk/cmake/modules/FindHtmlViewer.cmake + M /trunk/cmake/modules/FindLEX.cmake + D /trunk/cmake/modules/FindQt4.cmake + M /trunk/cmake/modules/FindYACC.cmake + M /trunk/cmake/modules/UseLemon.cmake + D /trunk/cmake/modules/UsePkgConfig.cmake + M /trunk/epan/CMakeLists.txt -From Stefan Puiu: -According to http://www.iana.org/assignments/bootp-dhcp-parameters, suboptions -from 1 to 10 have been defined. 3 is reserved, and most of the others have -their own RFC. For a start I've attached a patch that decodes suboption 6 just -as 1 and 2, and also suboption 3. This might not be entirely correct, since -suboptions 1 and 2 are opaque values (RFC3046), while 6 is an ASCII text -string. +- Undo the PACKAGELIST WSWIN32 stuff in CMakeLists.txt: + That's what the packages are for, so instead of creating + WSWIN32, the stuff should probably go into the GLIB2 + package. +- libwireshark now compiles - no time to add linking with + it until tonight -I added something for the other values as well... ------------------------------------------------------------------------- -r23294 | jake | 2007-10-28 04:25:34 -0700 (Sun, 28 Oct 2007) | 2 lines -Changed paths: - M /trunk/epan/dissectors/packet-isakmp.c -from Gisele Vanem: -This needs file_util.h if HAVE_LIBNETTLE is defined. ------------------------------------------------------------------------ -r23295 | gal | 2007-10-28 04:58:16 -0700 (Sun, 28 Oct 2007) | 9 lines +r29757 | jmayer | 2009-09-07 00:30:42 -0700 (Mon, 07 Sep 2009) | 3 lines Changed paths: - M /trunk/packaging/u3/win32/makefile.nmake - A /trunk/packaging/u3/win32/wireshark.bat - -U3 package update to: -a) include smi.dll if SMI_DIR is set -b) add a batch script to run the U3 wireshark configuration by simulating the U3 environment -c) include a test step in the build process to verify that the U3 package contains all the required files (tries to run "wireshark -D") -d) include the wireshark.bat in the U3 zip file. - -This final step means that the U3 package can be unzipped on any drive and run using the wireshark.bat script. (Note this currently creates an unwanted cmd window.) + M /trunk/gtk/capture_dlg.h +The external declaration of airpcap_tb here is not needed +and creates warnings ------------------------------------------------------------------------ -r23296 | wmeier | 2007-10-28 06:46:20 -0700 (Sun, 28 Oct 2007) | 2 lines +r29758 | etxrab | 2009-09-07 03:03:55 -0700 (Mon, 07 Sep 2009) | 1 line Changed paths: - M /trunk/Makefile.nmake - -Fix Windows build error if not using LUA; Bug #1950 + M /trunk/file.c + M /trunk/gtk/new_packet_list.c + M /trunk/ui_util.h +Automatically adjust the time column width when time format changes. ------------------------------------------------------------------------ -r23297 | wmeier | 2007-10-28 11:12:52 -0700 (Sun, 28 Oct 2007) | 7 lines +r29759 | krj | 2009-09-07 04:33:38 -0700 (Mon, 07 Sep 2009) | 1 line Changed paths: - M /trunk/packaging/u3/win32/makefile.nmake - M /trunk/packaging/u3/win32/wireshark.bat - -Small fixes: -1. wireshark.bat: Quote %U3_HOST_EXEC_PATH%\wireshark.exe so pathname - with spaces will work; -2. makefile.nmake: Use $(MAKE) /$(MAKEFLAGS) so things like - invoking nmake at the top level with /E to have environment - variables override config.namke definitions will work. + M /trunk/epan/frame_data.h + M /trunk/file.c + M /trunk/gtk/packet_list_store.c +Track length of columns strings. We'll need this in order to resize columns quickly ------------------------------------------------------------------------ -r23298 | sake | 2007-10-28 11:52:45 -0700 (Sun, 28 Oct 2007) | 12 lines +r29760 | etxrab | 2009-09-07 04:50:08 -0700 (Mon, 07 Sep 2009) | 1 line Changed paths: - M /trunk/wiretap/libpcap.c - -Bug 1751: From Allan M. Madsen : - -When trying to open a pcap file with the new pseudo-header/DLT (using SVN -version, changelist 23283) I get the error message: -"libpcap: ERF file has a 13-byte packet, too small to have even an ERF -pseudo-header". - -After reviewing Paolo's patch I found that there are 2 places with missing -breaks in switch case structures. - - + M /trunk/file.c + M /trunk/gtk/new_packet_list.c + M /trunk/ui_util.h +col_fmt not needed. ------------------------------------------------------------------------ -r23299 | sake | 2007-10-28 16:38:43 -0700 (Sun, 28 Oct 2007) | 16 lines +r29761 | stig | 2009-09-07 05:01:19 -0700 (Mon, 07 Sep 2009) | 2 lines Changed paths: - M /trunk/epan/dissectors/packet-tcp.c - -This patch is a remake of SVN 22762: - -When doing TCP_SEQ analysis, if the packet is a SYN, then it's -not a lost packet but the tcp ports are being reused. This is often -seen in load-balanced environments where client ports are preserved -on the server-side. - -This time it is fixed by creating a new conversation whenever a -new SYN is received for an existing conversation. This fixes the -following: - -- bug 1680: Error in TCP Sequence number analysis -- TCP-conversation timestamps for new TCP-sessions with the addresses - and ports as a previous TCP-conversation in the trace-file. + M /trunk/file.c +Fixed arguments to new_packet_list_set_time_width(). ------------------------------------------------------------------------ -r23300 | sake | 2007-10-28 16:49:15 -0700 (Sun, 28 Oct 2007) | 10 lines +r29762 | krj | 2009-09-07 05:04:59 -0700 (Mon, 07 Sep 2009) | 1 line Changed paths: - M /trunk/CMakeLists.txt - M /trunk/cmake/modules/CMakeInstallDirs.cmake - M /trunk/cmake/modules/FindDBUSGLIB.cmake - M /trunk/cmakeconfig.h.in - -Bug 1227 : From Frederic Heem: - -* modify CMakeInstallDirs.cmake according to cmake developper wishes -* FindDBUSGLIB.cmake fixes -* Add HAVE_CHOWN -* remove DBus from CMakeLists.txt. -* DBus support has its own application (capdbus) and is in a self contained directory. A separate patch will be provided - - + M /trunk/gtk/main_toolbar.c + M /trunk/gtk/new_packet_list.c + M /trunk/gtk/new_packet_list.h +Add initial implementation of new_packet_list_resize_columns() which just sets the column width according to the column format (work in progress) ------------------------------------------------------------------------ -r23301 | wmeier | 2007-10-28 17:58:06 -0700 (Sun, 28 Oct 2007) | 3 lines +r29763 | stig | 2009-09-07 05:12:45 -0700 (Mon, 07 Sep 2009) | 2 lines Changed paths: - M /trunk/asn1/pkcs12/packet-pkcs12-template.c - M /trunk/epan/dissectors/packet-pkcs12.c + M /trunk/gtk/menus.c -Include winposixtype.h only if building with GNUTLS; Bug #1949: Part 1 of fix -[asn1 template plu generated .c file] +Enable resize columns button for new packet list. ------------------------------------------------------------------------ -r23302 | wmeier | 2007-10-28 18:14:51 -0700 (Sun, 28 Oct 2007) | 5 lines +r29764 | stig | 2009-09-07 05:13:28 -0700 (Mon, 07 Sep 2009) | 2 lines Changed paths: - M /trunk/asn1/snmp/packet-snmp-template.c - M /trunk/epan/dissectors/packet-snmp.c - M /trunk/epan/dissectors/packet-snmp.h + M /trunk/gtk/main_toolbar.c -Include winposixtypes.h only if building with GNUTLS; Bug 1942: part 2 of 2 of fix. -asn1 template file plus generated .[hc] files; -Note that the generated files include changes which are a result of previous -changes to snmp.cnf (SVN #23252) and of other changes (eg: svn 21145). +Set sensitivity on resize columns button. ------------------------------------------------------------------------ -r23303 | sake | 2007-10-28 23:54:25 -0700 (Sun, 28 Oct 2007) | 3 lines +r29765 | stig | 2009-09-07 05:24:38 -0700 (Mon, 07 Sep 2009) | 2 lines Changed paths: - M /trunk/epan/conversation.c - -When there are multiple conversations with the same key, conversation_lookup_hashtable() did not return the correct conversation for the first packet of a conversation (ie when frame_num == conversation->setup_frame). + M /trunk/packaging/macosx/ScriptExec/main.c +Fixed some warnings and removed unused code. ------------------------------------------------------------------------ -r23304 | sahlberg | 2007-10-29 00:14:50 -0700 (Mon, 29 Oct 2007) | 2 lines +r29766 | krj | 2009-09-07 06:10:59 -0700 (Mon, 07 Sep 2009) | 1 line Changed paths: - A /trunk/epan/dissectors/packet-x224.c - -add an initial x.224 dissector it is very incomplete + M /trunk/gtk/new_packet_list.c + M /trunk/gtk/packet_list_store.c + M /trunk/gtk/packet_list_store.h +Auto resize non frame_data based columns ------------------------------------------------------------------------ -r23305 | sahlberg | 2007-10-29 00:15:29 -0700 (Mon, 29 Oct 2007) | 3 lines +r29767 | krj | 2009-09-07 06:54:46 -0700 (Mon, 07 Sep 2009) | 1 line Changed paths: - M /trunk/epan/dissectors/Makefile.common - -add x224 to the makefile - + M /trunk/epan/dissectors/packet-frame.c + M /trunk/epan/frame_data.h + M /trunk/file.c + M /trunk/rawshark.c + M /trunk/tshark.c +Store the packet encapsulation type as gint8. Saves 3 bytes per packet ------------------------------------------------------------------------ -r23306 | sahlberg | 2007-10-29 00:16:49 -0700 (Mon, 29 Oct 2007) | 4 lines +r29768 | etxrab | 2009-09-07 07:03:05 -0700 (Mon, 07 Sep 2009) | 1 line Changed paths: - M /trunk/epan/dissectors/packet-tpkt.c - -register tpkt for port 3389 and use x224 as the subdissector for this -port - + M /trunk/epan/addr_resolv.c + M /trunk/epan/column-utils.c + M /trunk/gtk/packet_list_store.c +Use constant strings for Addresses saves some memory. ------------------------------------------------------------------------ -r23307 | sahlberg | 2007-10-29 04:32:07 -0700 (Mon, 29 Oct 2007) | 12 lines +r29769 | etxrab | 2009-09-07 08:01:51 -0700 (Mon, 07 Sep 2009) | 1 line Changed paths: - M /trunk/asn1/Makefile.am - M /trunk/asn1/Makefile.nmake - A /trunk/asn1/t125 - A /trunk/asn1/t125/MCS-PROTOCOL.asn - A /trunk/asn1/t125/Makefile.am - A /trunk/asn1/t125/Makefile.common - A /trunk/asn1/t125/Makefile.nmake - A /trunk/asn1/t125/packet-t125-template.c - A /trunk/asn1/t125/packet-t125-template.h - A /trunk/asn1/t125/t125.cnf - M /trunk/configure.in - M /trunk/epan/dissectors/Makefile.common - A /trunk/epan/dissectors/packet-t125.c - A /trunk/epan/dissectors/packet-t125.h - M /trunk/epan/dissectors/packet-x224.c - -add a asn2wrs generated T.125 MCP dissector - -This dissects the initial Connect-Initial and Connect-confirm pdus of -setting up t.125 - - -The dissector needs to be enhanced to also decode the data payload so -that it can decode any furhter packets on the connection after these two -initial handshake packets - - + M /trunk/epan/column-utils.c +mark unused parameter. ------------------------------------------------------------------------ -r23308 | wmeier | 2007-10-29 08:11:20 -0700 (Mon, 29 Oct 2007) | 2 lines +r29770 | krj | 2009-09-07 08:49:14 -0700 (Mon, 07 Sep 2009) | 1 line Changed paths: - M /trunk/docbook/wsdg_src/WSDG_chapter_quick_setup.xml - -Add comment for Windows build re config.nmake and .h file changes requiring distclean + M /trunk/epan/addr_resolv.c +Tigthen scope of local variables ------------------------------------------------------------------------ -r23309 | kukosa | 2007-10-29 12:25:37 -0700 (Mon, 29 Oct 2007) | 11 lines +r29771 | krj | 2009-09-07 09:05:37 -0700 (Mon, 07 Sep 2009) | 2 lines Changed paths: - M /trunk/asn1/h323/Makefile.am - M /trunk/asn1/h323/Makefile.common - M /trunk/asn1/h323/Makefile.nmake - M /trunk/asn1/h323/RAS-PROTOCOL-TUNNEL.asn - M /trunk/asn1/h323/ROBUSTNESS-DATA.asn - M /trunk/asn1/h323/h323.cnf - M /trunk/asn1/h323/packet-h323-template.c - A /trunk/asn1/h323/packet-h323-template.h - M /trunk/asn1/ranap/ranap.cnf - M /trunk/epan/dissectors/packet-h225.c - M /trunk/epan/dissectors/packet-h235.c - M /trunk/epan/dissectors/packet-h245.c - M /trunk/epan/dissectors/packet-h323.c - M /trunk/epan/dissectors/packet-h450.c - M /trunk/epan/dissectors/packet-h460.c - M /trunk/epan/dissectors/packet-h501.c - M /trunk/epan/dissectors/packet-mpeg-audio.c - M /trunk/epan/dissectors/packet-mpeg-pes.c - M /trunk/epan/dissectors/packet-nbap.c - M /trunk/epan/dissectors/packet-per.c - M /trunk/epan/dissectors/packet-per.h - M /trunk/epan/dissectors/packet-ranap.c - M /trunk/epan/dissectors/packet-ranap.h - M /trunk/epan/dissectors/packet-rnsap.c - M /trunk/epan/dissectors/packet-rrc.c - M /trunk/epan/dissectors/packet-rrlp.c - M /trunk/epan/dissectors/packet-sabp.c - M /trunk/epan/dissectors/packet-t38.c - M /trunk/epan/dissectors/packet-ulp.c - M /trunk/epan/libwireshark.def - M /trunk/tools/asn2wrs.py + M /trunk/epan/addr_resolv.c + M /trunk/epan/addr_resolv.h + M /trunk/epan/column-utils.c + M /trunk/gtk/packet_list_store.c -asn2wrs - - parameterized object class assignment - - octet string with extensible size constraint - - RELATIVE-OID type (still not supported in packet-per/ber) -packet-per - - octet string with extensible size constraint -more dissect_per_... functions exported from libwireshark.dll -PER dissectors regenerated -add forgotten packet-h323-template.h -fix svn properties for h323 files +ntroduce some seasonal address name lookup functions which we use when NEW_PACKET_LIST is defined. This change partially reverts some parts of r29768, which didn't seem to work because it assumed that get_addr_name() would always return a seasonal string. This wasn't the case if the adddress type was AT_STRINGZ. ------------------------------------------------------------------------ -r23310 | sfisher | 2007-10-29 21:42:42 -0700 (Mon, 29 Oct 2007) | 7 lines +r29772 | krj | 2009-09-07 09:07:04 -0700 (Mon, 07 Sep 2009) | 1 line Changed paths: - M /trunk/epan/dissectors/packet-vnc.c - - -Fix for issue #1 in bug #1947 by doing a major overhaul of how the first -nine or so packets are handled to accommodate authentication type none and -to allow cleaner future improvements. Includes a few touch ups to the -rest of the dissector as well. - + M /trunk/epan/addr_resolv.c +Whitespace changes ------------------------------------------------------------------------ -r23311 | sfisher | 2007-10-29 22:49:41 -0700 (Mon, 29 Oct 2007) | 5 lines +r29773 | krj | 2009-09-07 09:17:58 -0700 (Mon, 07 Sep 2009) | 1 line Changed paths: - M /trunk/plugins/wimaxasncp/wimaxasncp_dict.l - - -Change a few g_string_append_printf() (GTK2 only) calls to g_strdup_printf() -and g_string_append() to work on GTK 1.2 also. - + M /trunk/epan/addr_resolv.c + M /trunk/epan/addr_resolv.h +Constify some functions ------------------------------------------------------------------------ -r23312 | sfisher | 2007-10-30 09:32:26 -0700 (Tue, 30 Oct 2007) | 5 lines +r29774 | etxrab | 2009-09-07 10:08:34 -0700 (Mon, 07 Sep 2009) | 3 lines Changed paths: - M /trunk/epan/dissectors/packet-vnc.c - - -Minor correction to protocol behavior handling when security type "none" is -selected by the client. - + M /trunk/epan/dissectors/packet-gsm_a_bssmap.c +From Mike Morrin: +Patch adding BSSMAP dissectors MSC Invoke Trace and BSS Invoke Trace. +https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=3985 ------------------------------------------------------------------------ -r23313 | gerald | 2007-10-30 15:22:14 -0700 (Tue, 30 Oct 2007) | 2 lines +r29775 | krj | 2009-09-07 10:09:09 -0700 (Mon, 07 Sep 2009) | 1 line Changed paths: - M /trunk/epan/dissectors/packet-tcp.c - -Fix some null dereferences. + M /trunk/gtk/packet_list_store.c + M /trunk/gtk/packet_list_store.h +Track how many const strings we're storing. This is guarded by NEW_PACKET_LIST_STATISTICS ------------------------------------------------------------------------ -r23314 | gerald | 2007-10-30 17:15:17 -0700 (Tue, 30 Oct 2007) | 4 lines +r29776 | etxrab | 2009-09-07 10:17:07 -0700 (Mon, 07 Sep 2009) | 4 lines Changed paths: - M /trunk/epan/crypt/airpdcap.c - M /trunk/epan/crypt/airpdcap_system.h - -From Christopher McKenzie: Zero out our SAs before we use them. - -Remove an unneeded for loop in AirPDcapCleanKeys(), and make it static. + M /trunk/epan/dissectors/packet-gsm_a_bssmap.c + M /trunk/epan/dissectors/packet-gsm_a_common.h + M /trunk/epan/dissectors/packet-gsm_a_rr.c +From Mike Morrin: +The GSM L3 part of the BSSMAP CipherModeComplete message is not being decoded. +Sligtly modified. +https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=3983 ------------------------------------------------------------------------ -r23315 | etxrab | 2007-10-31 00:47:47 -0700 (Wed, 31 Oct 2007) | 6 lines +r29777 | krj | 2009-09-07 10:45:37 -0700 (Mon, 07 Sep 2009) | 1 line Changed paths: - M /trunk/epan/dissectors/packet-edonkey.c - M /trunk/epan/dissectors/packet-edonkey.h + M /trunk/gtk/new_packet_list.c + M /trunk/gtk/packet_list_store.c -From Stefano Picerno: -Makes more fields searchable -Also fixes some typos and indentation errors -Fixes bug http://bugs.wireshark.org/bugzilla/show_bug.cgi?id=1802 for edonkey -dissector: every field defined by the dissector is now contained under the -PROTOABBREV=edonkey "root" key +Add progress bar while constructing columns (which is time consuming) ------------------------------------------------------------------------ -r23316 | etxrab | 2007-10-31 00:49:39 -0700 (Wed, 31 Oct 2007) | 3 lines +r29778 | krj | 2009-09-07 11:53:17 -0700 (Mon, 07 Sep 2009) | 1 line Changed paths: - M /trunk/asn1/pkixcmp/packet-cmp-template.c - M /trunk/epan/dissectors/packet-cmp.c - M /trunk/epan/dissectors/packet-cmp.h + M /trunk/epan/nstime.c + M /trunk/epan/nstime.h + M /trunk/gtk/packet_list_store.c -From Martin Peylo: -This uncomments the OID registration of pkixcmp and adds 2 Cryptlib OIDs -Changed to use oid_add_from_string for adding names. +Auto size COL_NUMBER, COL_PACKET_LENGTH and COL_CUMULATIVE_BYTES ------------------------------------------------------------------------ -r23317 | etxrab | 2007-10-31 00:50:59 -0700 (Wed, 31 Oct 2007) | 1 line +r29779 | krj | 2009-09-07 12:07:30 -0700 (Mon, 07 Sep 2009) | 1 line Changed paths: - M /trunk/asn1/h245/packet-h245-template.c - M /trunk/epan/dissectors/packet-h245.c + M /trunk/gtk/packet_list_store.c -Use oid_add_from_string for adding names, names changed to short form. +Auto resize rest of the frame_data columns ------------------------------------------------------------------------ -r23318 | etxrab | 2007-10-31 01:26:52 -0700 (Wed, 31 Oct 2007) | 1 line +r29780 | krj | 2009-09-07 12:43:05 -0700 (Mon, 07 Sep 2009) | 1 line Changed paths: - M /trunk/asn1/acse/packet-acse-template.c - M /trunk/asn1/cmip/packet-cmip-template.c - M /trunk/asn1/cms/packet-cms-template.c - M /trunk/asn1/disp/packet-disp-template.c - M /trunk/epan/dissectors/packet-acse.c - M /trunk/epan/dissectors/packet-acse.h - M /trunk/epan/dissectors/packet-cmip.c - M /trunk/epan/dissectors/packet-cmip.h - M /trunk/epan/dissectors/packet-cms.c - M /trunk/epan/dissectors/packet-cms.h - M /trunk/epan/dissectors/packet-disp.c + M /trunk/epan/column-utils.c + M /trunk/gtk/packet_list_store.c -Use oid_add_from_string for adding names. +Make sure that we fill in the frame_data before passing it onto col_fill_in_frame_data ------------------------------------------------------------------------ -r23319 | kukosa | 2007-10-31 02:22:56 -0700 (Wed, 31 Oct 2007) | 1 line +r29781 | krj | 2009-09-07 12:50:19 -0700 (Mon, 07 Sep 2009) | 1 line Changed paths: - M /trunk/asn1/Makefile.inc.nmake - M /trunk/asn1/Makefile.preinc.nmake + M /trunk/gtk/new_packet_list.c + M /trunk/gtk/packet_list_store.c + M /trunk/gtk/packet_list_store.h -move 'all: generate_dissector' rule from Makefile.inc.nmake to Makefile.preinc.nmake to be the 1st one in the resulting makefile +Rename packet_list_dissect_and_cache => packet_list_dissect_and_cache_iter ------------------------------------------------------------------------ -r23320 | kukosa | 2007-10-31 02:33:54 -0700 (Wed, 31 Oct 2007) | 1 line +r29782 | krj | 2009-09-07 13:45:32 -0700 (Mon, 07 Sep 2009) | 1 line Changed paths: - M /trunk/tools/asn2wrs.py + M /trunk/file.c + M /trunk/gtk/new_packet_list.c + M /trunk/ui_util.h -accept VariableTypeValueFieldSpec syntax and ParameterizedObjectClass syntax +Rename new_packet_list_set_time_width() -> new_packet_list_resize_column() because it contains no time format specific code. Further this change also ensures that new_packet_list_resize_columns() uses the newly introduced new_packet_list_resize_column() ------------------------------------------------------------------------ -r23321 | kukosa | 2007-10-31 05:57:01 -0700 (Wed, 31 Oct 2007) | 1 line +r29783 | krj | 2009-09-07 14:07:51 -0700 (Mon, 07 Sep 2009) | 1 line Changed paths: - M /trunk/tools/asn2wrs.py + M /trunk/file.c + M /trunk/gtk/main_statusbar.c -small improvement in class fields handling +Make sure that reset the elapsed time to load a file before we reload/rescan the file ------------------------------------------------------------------------ -r23322 | bondolo | 2007-10-31 08:16:33 -0700 (Wed, 31 Oct 2007) | 3 lines +r29784 | etxrab | 2009-09-07 21:50:48 -0700 (Mon, 07 Sep 2009) | 1 line Changed paths: - M /trunk/gtk/rtp_player.c - -Avoid casting directly from int to pointers. (It doesn't work on 64-bit linux) - + M /trunk/epan/column-utils.c +Remove an unused parameter. ------------------------------------------------------------------------ -r23323 | kukosa | 2007-10-31 08:42:52 -0700 (Wed, 31 Oct 2007) | 1 line +r29785 | jake | 2009-09-07 22:58:51 -0700 (Mon, 07 Sep 2009) | 3 lines Changed paths: - M /trunk/asn1/camel/camel.cnf + M /trunk/AUTHORS -add forward class declarations which are necessary to compile Remote-Operations-Information-Objects.asn ------------------------------------------------------------------------- -r23324 | etxrab | 2007-10-31 14:24:16 -0700 (Wed, 31 Oct 2007) | 2 lines -Changed paths: - M /trunk/asn1/acp133/packet-acp133-template.c - M /trunk/asn1/dap/packet-dap-template.c - M /trunk/asn1/dop/packet-dop-template.c - M /trunk/asn1/dsp/packet-dsp-template.c - M /trunk/asn1/ftam/packet-ftam-template.c - M /trunk/asn1/gsmmap/packet-gsmmap-template.c - M /trunk/asn1/h225/packet-h225-template.c - M /trunk/asn1/inap/packet-inap-template.c - M /trunk/asn1/pkixproxy/packet-pkixproxy-template.c - M /trunk/asn1/wlancertextn/packet-wlancertextn-template.c - M /trunk/asn1/x411/packet-x411-template.c - M /trunk/epan/dissectors/packet-acp133.c - M /trunk/epan/dissectors/packet-acp133.h - M /trunk/epan/dissectors/packet-dap.c - M /trunk/epan/dissectors/packet-dop.c - M /trunk/epan/dissectors/packet-dop.h - M /trunk/epan/dissectors/packet-dsp.c - M /trunk/epan/dissectors/packet-ftam.c - M /trunk/epan/dissectors/packet-ftam.h - M /trunk/epan/dissectors/packet-h225.c - M /trunk/epan/dissectors/packet-pkixproxy.c - M /trunk/epan/dissectors/packet-pkixproxy.h - M /trunk/epan/dissectors/packet-wlancertextn.c - M /trunk/epan/dissectors/packet-wlancertextn.h - M /trunk/epan/dissectors/packet-x411.c +From Artem Tamazov: +Add Artem Tamazov and Dmitry Trebuch to AUTHORS. -Use oid_add_from_string for adding names. -(gsmmap and inap does not compile at the moment). ------------------------------------------------------------------------ -r23325 | etxrab | 2007-10-31 16:11:15 -0700 (Wed, 31 Oct 2007) | 3 lines +r29786 | jmayer | 2009-09-08 00:03:57 -0700 (Tue, 08 Sep 2009) | 4 lines Changed paths: - M /trunk/asn1/gsmmap/gsmmap.cnf - M /trunk/asn1/gsmmap/packet-gsmmap-template.c - M /trunk/asn1/h235/packet-h235-template.c - M /trunk/asn1/inap/inap.cnf - M /trunk/asn1/ldap/packet-ldap-template.c - M /trunk/asn1/x509sat/packet-x509sat-template.c - M /trunk/epan/dissectors/packet-ber.c - M /trunk/epan/dissectors/packet-gsm_map.c - M /trunk/epan/dissectors/packet-gsm_map.h - M /trunk/epan/dissectors/packet-h235.c - M /trunk/epan/dissectors/packet-inap.c - M /trunk/epan/dissectors/packet-inap.h - M /trunk/epan/dissectors/packet-ldap.c - M /trunk/epan/dissectors/packet-ldap.h - M /trunk/epan/dissectors/packet-x509sat.c - M /trunk/epan/dissectors/packet-x509sat.h + M /trunk/CMakeLists.txt + A /trunk/cmake/modules/FindMATH.cmake + A /trunk/cmake/modules/FindPCRE.cmake + A /trunk/cmake/modules/FindPORTAUDIO.cmake + A /trunk/cmake/modules/FindSH.cmake + M /trunk/epan/CMakeLists.txt + A /trunk/gtk/CMakeLists.txt -Use oid_add_from_string for adding names. -fix compil of gsmmap and inap. -Note xcopy of gsmmap does not work(rename packet-gsm_map -> packet-gsmmap ?) ------------------------------------------------------------------------- -r23326 | etxrab | 2007-11-01 00:37:24 -0700 (Thu, 01 Nov 2007) | 1 line -Changed paths: - M /trunk/epan/oids.h +dftest and rawshark now build. +tshark might build. -Remove add_oid_str_name. ------------------------------------------------------------------------- -r23327 | kukosa | 2007-11-01 03:50:01 -0700 (Thu, 01 Nov 2007) | 1 line -Changed paths: - M /trunk/epan/dissectors/packet-ssl.c -set data for IV always ------------------------------------------------------------------------ -r23328 | kukosa | 2007-11-01 04:56:33 -0700 (Thu, 01 Nov 2007) | 2 lines +r29787 | etxrab | 2009-09-08 02:11:21 -0700 (Tue, 08 Sep 2009) | 4 lines Changed paths: - M /trunk/asn1/camel/camel.cnf - M /trunk/tools/asn2wrs.py + M /trunk/asn1/h248/h248v3.asn + M /trunk/epan/dissectors/packet-h248.c + M /trunk/epan/dissectors/packet-h248.h -better built-in X.880 support -forward declarations of OPERATION and ERROR classes are not necessary when Remote-Operations-Information-Objects.asn itself is compiled ------------------------------------------------------------------------- -r23329 | kukosa | 2007-11-01 05:36:27 -0700 (Thu, 01 Nov 2007) | 1 line -Changed paths: - M /trunk/asn1/gsmmap/gsmmap.cnf - M /trunk/asn1/inap/inap.cnf +From Alex Lindberg: +Update to h248v3.asn -removed unnecessary forward class declarations +Applied the change from the Amendment 1 by hand. ------------------------------------------------------------------------ -r23330 | martinm | 2007-11-01 08:15:33 -0700 (Thu, 01 Nov 2007) | 2 lines +r29788 | stig | 2009-09-08 03:12:01 -0700 (Tue, 08 Sep 2009) | 2 lines Changed paths: - M /trunk/wimaxasncp/dictionary.xml + M /trunk/gtk/packet_list_store.c -Fix a decoder type. +Fixed initialization of fdata. ------------------------------------------------------------------------ -r23331 | etxrab | 2007-11-01 12:36:39 -0700 (Thu, 01 Nov 2007) | 3 lines +r29789 | etxrab | 2009-09-08 03:33:15 -0700 (Tue, 08 Sep 2009) | 3 lines Changed paths: - M /trunk/asn1/cdt/cdt.cnf - M /trunk/asn1/cms/cms.cnf - M /trunk/asn1/dop/packet-dop-template.c - M /trunk/asn1/ldap/packet-ldap-template.c - M /trunk/asn1/pkcs12/packet-pkcs12-template.c - M /trunk/asn1/x411/x411.cnf - M /trunk/asn1/x420/x420.cnf - M /trunk/asn1/x509af/x509af.cnf - M /trunk/asn1/x509if/x509if.cnf - M /trunk/epan/dissectors/packet-ber.c - M /trunk/epan/dissectors/packet-cdt.c - M /trunk/epan/dissectors/packet-cdt.h - M /trunk/epan/dissectors/packet-cms.c - M /trunk/epan/dissectors/packet-dop.c - M /trunk/epan/dissectors/packet-l2tp.c - M /trunk/epan/dissectors/packet-ldap.c - M /trunk/epan/dissectors/packet-pkcs12.c - M /trunk/epan/dissectors/packet-pkcs12.h - M /trunk/epan/dissectors/packet-x411.c - M /trunk/epan/dissectors/packet-x420.c - M /trunk/epan/dissectors/packet-x509af.c - M /trunk/epan/dissectors/packet-x509af.h - M /trunk/epan/dissectors/packet-x509if.c - M /trunk/epan/dissectors/packet-x509if.h + M /trunk/epan/column-utils.c + M /trunk/epan/column_info.h + M /trunk/epan/epan.c + M /trunk/epan/epan.h M /trunk/epan/proto.c + M /trunk/epan/proto.h -Change: -get_oid_str_name() -> oid_resolved_from_string() -get_oid_name() -> oid_resolved_from_encoded() +From : Didier Gautheron +speed up a little proto_custom_set. +https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=3972 ------------------------------------------------------------------------ -r23332 | sahlberg | 2007-11-01 13:33:35 -0700 (Thu, 01 Nov 2007) | 4 lines +r29790 | stig | 2009-09-08 06:44:34 -0700 (Tue, 08 Sep 2009) | 3 lines Changed paths: - M /trunk/epan/dissectors/packet-dcerpc-frsrpc.c - -some updates to the frsrpc dissector -dissect parts of the TLV blob that is sent during file replication + M /trunk/epan/dissectors/packet-icmp.c +Cleanup code for type and code, do not show empty "()" when code is unused. +Use hex values for bitmasks in header_field_info. ------------------------------------------------------------------------ -r23333 | etxrab | 2007-11-01 15:07:43 -0700 (Thu, 01 Nov 2007) | 1 line +r29791 | etxrab | 2009-09-08 06:49:19 -0700 (Tue, 08 Sep 2009) | 1 line Changed paths: - M /trunk/asn1/ldap/ldap.cnf - M /trunk/epan/dissectors/packet-ber.c - M /trunk/epan/dissectors/packet-ldap.c - M /trunk/epan/dissectors/packet-per.c - M /trunk/epan/oids.h - M /trunk/epan/proto.c - M /trunk/plugins/agentx/packet-agentx.c + M /trunk/gtk/capture_dlg.c -Get rid of most of the legacy oid stuff. +Get rid of deprecated gtk_option_menu_new(); ------------------------------------------------------------------------ -r23334 | etxrab | 2007-11-01 15:14:46 -0700 (Thu, 01 Nov 2007) | 1 line +r29792 | krj | 2009-09-08 07:17:36 -0700 (Tue, 08 Sep 2009) | 4 lines Changed paths: - M /trunk/epan/dissectors/packet-text-media.c + M /trunk/epan/column-utils.c + M /trunk/epan/column_info.h + M /trunk/epan/prefs.c + M /trunk/epan/wslua/wslua_pinfo.c -Add a text media type. ------------------------------------------------------------------------- -r23335 | etxrab | 2007-11-01 15:29:02 -0700 (Thu, 01 Nov 2007) | 1 line -Changed paths: - M /trunk/asn1/ldap/Makefile.common - M /trunk/epan/dissectors/packet-ldap.c - M /trunk/epan/dissectors/packet-ldap.h +Custom column deprecation: -LDAP wasn't 'fixed' to handle -T option... ------------------------------------------------------------------------- -r23336 | kukosa | 2007-11-02 00:41:56 -0700 (Fri, 02 Nov 2007) | 1 line -Changed paths: - M /trunk/epan/dissectors/packet-sdp.c +We fill out the COL_OXID column by using 'pinfo->oxid'. This member is only set by the Fibre Channel dissector based on 'fc.ox_id'. So remove COL_OXID and migrate to 'fc.ox_id' custom column. -setup SRTP stream for RTP/SAVP media protocol ------------------------------------------------------------------------ -r23337 | kukosa | 2007-11-02 00:43:49 -0700 (Fri, 02 Nov 2007) | 1 line +r29793 | krj | 2009-09-08 07:21:14 -0700 (Tue, 08 Sep 2009) | 4 lines Changed paths: - M /trunk/epan/dissectors/packet-rtp.c - M /trunk/epan/dissectors/packet-rtp.h - M /trunk/gtk/voip_calls.c - M /trunk/gtk/voip_calls.h + M /trunk/epan/column-utils.c + M /trunk/epan/column_info.h + M /trunk/epan/prefs.c + M /trunk/epan/wslua/wslua_pinfo.c -display SRTP isntead of RTP if stream is established like a SRTP ------------------------------------------------------------------------- -r23338 | kukosa | 2007-11-02 01:34:12 -0700 (Fri, 02 Nov 2007) | 1 line -Changed paths: - M /trunk/asn1/h501/h501.cnf - M /trunk/asn1/h501/packet-h501-template.c - M /trunk/epan/dissectors/packet-h501.c +Custom column deprecation: -display message type in the info column ------------------------------------------------------------------------- -r23339 | kukosa | 2007-11-02 05:18:01 -0700 (Fri, 02 Nov 2007) | 1 line -Changed paths: - M /trunk/asn1/Makefile.am - M /trunk/asn1/Makefile.nmake - A /trunk/asn1/h282 - A /trunk/asn1/h282/Makefile.am - A /trunk/asn1/h282/Makefile.common - A /trunk/asn1/h282/Makefile.nmake - A /trunk/asn1/h282/RDC-PROTOCOL.asn - A /trunk/asn1/h282/h282.cnf - A /trunk/asn1/h282/packet-h282-template.c - A /trunk/asn1/h283 - A /trunk/asn1/h283/LCT-PROTOCOL.asn - A /trunk/asn1/h283/Makefile.am - A /trunk/asn1/h283/Makefile.common - A /trunk/asn1/h283/Makefile.nmake - A /trunk/asn1/h283/h283.cnf - A /trunk/asn1/h283/packet-h283-template.c - M /trunk/configure.in - M /trunk/epan/dissectors/Makefile.common - A /trunk/epan/dissectors/packet-h282.c - A /trunk/epan/dissectors/packet-h283.c +We fill out the COL_RXID column by using 'pinfo->rxid'. This member is only set by the Fibre Channel dissector based on 'fc.rx_id'. So remove COL_RXID and migrate to 'fc.rx_id' custom column. -new H.282 (RDC) and H.283 (LCT) dissectors ------------------------------------------------------------------------ -r23340 | gal | 2007-11-02 06:47:23 -0700 (Fri, 02 Nov 2007) | 11 lines +r29794 | krj | 2009-09-08 07:26:09 -0700 (Tue, 08 Sep 2009) | 4 lines Changed paths: - M /trunk/Makefile.nmake - A /trunk/packaging/portableapps - A /trunk/packaging/portableapps/win32 - A /trunk/packaging/portableapps/win32/Installer.nsi - A /trunk/packaging/portableapps/win32/WiresharkPortable.ini - A /trunk/packaging/portableapps/win32/WiresharkPortable.nsi - A /trunk/packaging/portableapps/win32/appinfo.tmpl - A /trunk/packaging/portableapps/win32/makefile.nmake - -Initial Portable Apps (www.portableapps.com) packaging to produce a "Wireshark Portable" (WSP) distribution. + M /trunk/epan/column-utils.c + M /trunk/epan/column_info.h + M /trunk/epan/prefs.c + M /trunk/epan/wslua/wslua_pinfo.c -This allows Wireshark to be run from any USB stick, unlike the U3 packaging which must be installed on a specific U3 device. +Custom column deprecation: -The packaging basically builds upon the U3 distribution so new libraries/config only need to be added to the U3 makefile to update both distributions. +We fill out the COL_SRCIDX column by using 'pinfo->src_idx'. This member is only set by the MDS Header dissector based on 'mdshdr.srcidx'. So remove COL_SRCIDX and migrate to 'mdshdr.srcidx' custom column. -It still takes a "dumb" approach to WinPcap - installing it if it is not already installed and removing it (if WSP installed it) when Wireshark quits. (This is worse than the U3 packaging which only uninstalls WinPcap when the device is removed.) Really must talk to the WinPcap guys to see how we can make this less intrusive. +------------------------------------------------------------------------ +r29795 | krj | 2009-09-08 07:29:08 -0700 (Tue, 08 Sep 2009) | 4 lines +Changed paths: + M /trunk/epan/column-utils.c + M /trunk/epan/column_info.h + M /trunk/epan/prefs.c + M /trunk/epan/wslua/wslua_pinfo.c -I am talking to John Haller (the Portable Apps guy) about fine tuning the distribution. +Custom column deprecation: +We fill out the COL_DSTIDX column by using 'pinfo->dst_idx'. This member is only set by the MDS Header dissector based on 'mdshdr.dstidx'. So remove COL_DSTIDX and migrate to 'mdshdr.dstidx' custom column. ------------------------------------------------------------------------ -r23341 | jmayer | 2007-11-02 12:57:41 -0700 (Fri, 02 Nov 2007) | 1 line +r29796 | etxrab | 2009-09-08 07:41:25 -0700 (Tue, 08 Sep 2009) | 1 line Changed paths: - M /trunk/manuf - M /trunk/wka.tmpl + M /trunk/gtk/prefs_gui.c -change some extreme wkas and update manuf +Get rid of deprecated gtk_entry_append_text(). ------------------------------------------------------------------------ -r23342 | jmayer | 2007-11-02 13:00:03 -0700 (Fri, 02 Nov 2007) | 3 lines +r29797 | krj | 2009-09-08 07:59:26 -0700 (Tue, 08 Sep 2009) | 4 lines Changed paths: - M /trunk/epan/dissectors/packet-extreme.c + M /trunk/epan/column-utils.c + M /trunk/epan/column_info.h + M /trunk/epan/dissectors/packet-dcerpc.c + M /trunk/epan/prefs.c + M /trunk/gtk/main_packet_list.c + M /trunk/gtk/packet_list_store.c -- Rename EAPSv2 to ESL (EAPS shared link). -- Some small improvements to ESL decoding. +Custom columnfication: ------------------------------------------------------------------------- -r23343 | martinm | 2007-11-02 15:34:18 -0700 (Fri, 02 Nov 2007) | 2 lines -Changed paths: - M /trunk/epan/dissectors/packet-catapult-dct2000.c +* Deprecate COL_DCE_CTX ("Context ID). Use dcerpc.cn_ctx_id -Improve some comments (and test committing from Windows -build). ------------------------------------------------------------------------ -r23344 | martinm | 2007-11-02 16:40:10 -0700 (Fri, 02 Nov 2007) | 1 line +r29798 | krj | 2009-09-08 08:55:10 -0700 (Tue, 08 Sep 2009) | 1 line Changed paths: - M /trunk/AUTHORS + M /trunk/epan/column-utils.c -Update my email address. +Hoist COL_CHECK_REF_TIME in the call hierarchy. Use it in our public functions, not our internal functions ------------------------------------------------------------------------ -r23345 | sfisher | 2007-11-02 20:03:02 -0700 (Fri, 02 Nov 2007) | 4 lines +r29799 | jmayer | 2009-09-08 08:56:16 -0700 (Tue, 08 Sep 2009) | 2 lines Changed paths: - M /trunk/epan/dissectors/packet-vnc.c - - -Add partial support for TightVNC packet dissection (work in progress). + M /trunk/CMakeLists.txt + M /trunk/epan/CMakeLists.txt + M /trunk/gtk/CMakeLists.txt + M /trunk/wiretap/CMakeLists.txt +- now wireshark compiles with cmake as well ------------------------------------------------------------------------ -r23346 | sfisher | 2007-11-02 21:45:35 -0700 (Fri, 02 Nov 2007) | 6 lines +r29800 | jmayer | 2009-09-08 09:07:14 -0700 (Tue, 08 Sep 2009) | 2 lines Changed paths: - M /trunk/docbook/wsug_src/WSUG_chapter_use.xml - M /trunk/epan/dissectors/packet-udp.c - M /trunk/epan/follow.c - M /trunk/epan/follow.h - M /trunk/gtk/Makefile.common - M /trunk/gtk/follow_ssl.c - M /trunk/gtk/follow_stream.c - M /trunk/gtk/follow_stream.h - M /trunk/gtk/follow_tcp.c - M /trunk/gtk/main.c - M /trunk/gtk/menu.c - - -- Future improve/clean up the now generic follow stream code - -- Add "Follow UDP Stream" feature + M /trunk/CMakeLists.txt +Build new packetlist ------------------------------------------------------------------------ -r23347 | sfisher | 2007-11-02 21:46:22 -0700 (Fri, 02 Nov 2007) | 4 lines +r29802 | martinm | 2009-09-08 10:13:55 -0700 (Tue, 08 Sep 2009) | 2 lines Changed paths: - A /trunk/gtk/follow_udp.c - A /trunk/gtk/follow_udp.h - - -The rest of the Follow UDP Stream check-in + M /trunk/epan/dissectors/packet-mac-lte.c +Trivial: add direction to expert info string for CRC failures. ------------------------------------------------------------------------ -r23348 | sfisher | 2007-11-02 23:23:02 -0700 (Fri, 02 Nov 2007) | 4 lines +r29803 | krj | 2009-09-08 10:29:57 -0700 (Tue, 08 Sep 2009) | 1 line Changed paths: - M /trunk/gtk/Makefile.am - - -Fix distcheck after my prior 2 commits - + M /trunk/epan/column.c + M /trunk/epan/column.h + M /trunk/gtk/main.c + M /trunk/gtk/main_packet_list.c + M /trunk/rawshark.c + M /trunk/tshark.c +Make tshark and rawshark use build_column_format_array() instead of duplicating the code ------------------------------------------------------------------------ -r23349 | ulfl | 2007-11-03 01:48:12 -0700 (Sat, 03 Nov 2007) | 1 line +r29804 | krj | 2009-09-08 11:02:43 -0700 (Tue, 08 Sep 2009) | 1 line Changed paths: - M /trunk/packaging/portableapps/win32/WiresharkPortable.nsi + M /trunk/cmdarg_err.h + M /trunk/dumpcap.c + M /trunk/simple_dialog.h -at least mention in a comment, that you'll need the FindProcDLL plug-in +Use Wireshark/GLib attribute specifiers instead of checking for __GNUC__ explicitly ------------------------------------------------------------------------ -r23350 | gal | 2007-11-03 13:27:48 -0700 (Sat, 03 Nov 2007) | 2 lines +r29805 | etxrab | 2009-09-08 11:46:47 -0700 (Tue, 08 Sep 2009) | 3 lines Changed paths: - A /trunk/packaging/portableapps/win32/readme.txt - -A bit of a readme for the Wireshark Portable packaging. Includes details of the NSIS plug-in required. + M /trunk/epan/dissectors/packet-giop.c + M /trunk/epan/dissectors/packet-giop.h +From Steve Osselton: +Fix for MIOP dissector for GIOP < 1.2. +https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=3892 ------------------------------------------------------------------------ -r23351 | etxrab | 2007-11-04 01:11:24 -0700 (Sun, 04 Nov 2007) | 1 line +r29806 | krj | 2009-09-08 12:00:54 -0700 (Tue, 08 Sep 2009) | 1 line Changed paths: - M /trunk/epan/libwireshark.def + M /trunk/epan/column-utils.c + M /trunk/epan/column-utils.h + M /trunk/epan/epan.c + M /trunk/epan/epan.h + M /trunk/file.c + M /trunk/gtk/main.c + M /trunk/gtk/new_packet_list.c + M /trunk/gtk/packet_list_store.c + M /trunk/gtk/packet_win.c + M /trunk/tshark.c -follow_tcp_stats -> follow_stats +Add an option to col_fill_in() to allow us to disable column expression processing. This is rarely needed. It's only needed when the user right clicks on the packet list view to generate a display filter. ------------------------------------------------------------------------ -r23352 | etxrab | 2007-11-04 08:47:30 -0800 (Sun, 04 Nov 2007) | 1 line +r29807 | etxrab | 2009-09-08 12:38:42 -0700 (Tue, 08 Sep 2009) | 3 lines Changed paths: - M /trunk/asn1/snmp/Makefile.common - M /trunk/asn1/snmp/snmp.cnf - M /trunk/epan/dissectors/packet-snmp.c - M /trunk/epan/dissectors/packet-snmp.h + M /trunk/epan/dissectors/packet-dnp.c -SNMP with option -X and -T +From Xavier Laxa: +UNS bit not correctly parsed in DNP APP Layer. +https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=3318 ------------------------------------------------------------------------ -r23353 | etxrab | 2007-11-04 09:16:01 -0800 (Sun, 04 Nov 2007) | 1 line +r29808 | krj | 2009-09-08 13:06:52 -0700 (Tue, 08 Sep 2009) | 1 line Changed paths: - M /trunk/asn1/ldap/Makefile.common - M /trunk/asn1/ldap/ldap.cnf - M /trunk/epan/dissectors/packet-ldap.c - M /trunk/epan/dissectors/packet-ldap.h + M /trunk/epan/proto.c -LDAP with -T +Use g_strlcpy when possible ------------------------------------------------------------------------ -r23354 | stig | 2007-11-04 09:24:25 -0800 (Sun, 04 Nov 2007) | 2 lines +r29810 | tuexen | 2009-09-08 14:20:31 -0700 (Tue, 08 Sep 2009) | 2 lines Changed paths: - M /trunk/asn1/pres/Makefile.common - M /trunk/epan/dissectors/packet-pres.c - M /trunk/epan/dissectors/packet-pres.h + M /trunk/epan/dissectors/packet-isup.c -Update do use the -X and -T asn2wrs flags. +Print cic in info column for BICC messages similar to ISUP. ------------------------------------------------------------------------ -r23355 | stig | 2007-11-04 09:27:42 -0800 (Sun, 04 Nov 2007) | 2 lines +r29811 | gerald | 2009-09-08 15:56:55 -0700 (Tue, 08 Sep 2009) | 3 lines Changed paths: - M /trunk/asn1/h282 - M /trunk/asn1/h283 - M /trunk/asn1/t125 + M /trunk/epan/proto.c -Added svn:ignore targets for h282,h283 and t125. +Move the infinite loop check from proto_tree_add_node to +TRY_TO_FAKE_THIS_ITEM. Partial fix for bug 3986. ------------------------------------------------------------------------ -r23356 | etxrab | 2007-11-04 09:57:31 -0800 (Sun, 04 Nov 2007) | 1 line +r29812 | gerald | 2009-09-08 15:58:23 -0700 (Tue, 08 Sep 2009) | 3 lines Changed paths: - M /trunk/asn1/cmip/Makefile.common - M /trunk/epan/dissectors/packet-cmip.c - M /trunk/epan/dissectors/packet-cmip.h + M /trunk/epan/dissectors/packet-infiniband.c -Update do use the -X and -T asn2wrs flags. ------------------------------------------------------------------------- -r23357 | etxrab | 2007-11-04 10:16:41 -0800 (Sun, 04 Nov 2007) | 1 line -Changed paths: - M /trunk/asn1/logotype-cert-extn/LogotypeCertExtn.asn - M /trunk/asn1/logotype-cert-extn/Makefile.common - M /trunk/epan/dissectors/packet-logotypecertextn.c - M /trunk/epan/dissectors/packet-logotypecertextn.h +Just use proto_tree_add_item instead of feeding tvb->real_data to +proto_tree_add_bytes. -Update do use the -X and -T asn2wrs flags. ------------------------------------------------------------------------ -r23358 | etxrab | 2007-11-04 10:23:47 -0800 (Sun, 04 Nov 2007) | 1 line +r29813 | gerald | 2009-09-08 17:18:15 -0700 (Tue, 08 Sep 2009) | 4 lines Changed paths: - M /trunk/asn1/ns-cert-exts/Makefile.common - M /trunk/epan/dissectors/packet-ns_cert_exts.c + M /trunk/plugins/opcua/opcua.c + M /trunk/plugins/opcua/opcua_simpletypes.c + M /trunk/plugins/opcua/opcua_transport_layer.c -Update do use the -X and -T asn2wrs flags. ------------------------------------------------------------------------- -r23359 | etxrab | 2007-11-04 10:34:13 -0800 (Sun, 04 Nov 2007) | 1 line -Changed paths: - M /trunk/asn1/ocsp/Makefile.common - M /trunk/asn1/ocsp/OCSP.asn - M /trunk/epan/dissectors/packet-ocsp.c - M /trunk/epan/dissectors/packet-ocsp.h +Check our array lengths and refuse to process them if they're too large. +Fixes bug 3986. Use tvb_memeql and proto_tree_add_item instead of +digging around in tvb->real_data. -Update do use the -X and -T asn2wrs flags. ------------------------------------------------------------------------ -r23360 | etxrab | 2007-11-04 10:37:06 -0800 (Sun, 04 Nov 2007) | 1 line +r29814 | jake | 2009-09-09 00:22:44 -0700 (Wed, 09 Sep 2009) | 2 lines Changed paths: - M /trunk/asn1/pkcs1/Makefile.common - M /trunk/epan/dissectors/packet-pkcs1.c - M /trunk/epan/dissectors/packet-pkcs1.h + M /trunk/epan/dissectors/packet-dhcpv6.c -Update do use the -X and -T asn2wrs flags. +Fix for bug 3987: +Option Request option values are in 16 bit units. ------------------------------------------------------------------------ -r23361 | etxrab | 2007-11-04 10:47:49 -0800 (Sun, 04 Nov 2007) | 1 line +r29815 | jake | 2009-09-09 00:27:01 -0700 (Wed, 09 Sep 2009) | 2 lines Changed paths: - M /trunk/asn1/pkinit/Makefile.common - M /trunk/epan/dissectors/packet-pkinit.c - M /trunk/epan/dissectors/packet-pkinit.h + M /trunk/epan/dissectors/packet-fc.c -Update do use the -X and -T asn2wrs flags. +From kahou: +FCSOF incorrect checksum calculation. ------------------------------------------------------------------------ -r23362 | etxrab | 2007-11-04 11:03:48 -0800 (Sun, 04 Nov 2007) | 1 line +r29816 | etxrab | 2009-09-09 00:29:41 -0700 (Wed, 09 Sep 2009) | 5 lines Changed paths: - M /trunk/asn1/pkix1explicit/Makefile.common - M /trunk/asn1/pkix1implicit/Makefile.common - M /trunk/asn1/pkixcmp/Makefile.common - M /trunk/asn1/pkixcrmf/Makefile.common - M /trunk/asn1/pkixproxy/Makefile.common - M /trunk/asn1/pkixqualified/Makefile.common - M /trunk/asn1/pkixtsp/Makefile.common - M /trunk/asn1/pkixtsp/pkixtsp.cnf - M /trunk/epan/dissectors/packet-cmp.c - M /trunk/epan/dissectors/packet-cmp.h - M /trunk/epan/dissectors/packet-crmf.c - M /trunk/epan/dissectors/packet-crmf.h - M /trunk/epan/dissectors/packet-pkix1explicit.c - M /trunk/epan/dissectors/packet-pkix1explicit.h - M /trunk/epan/dissectors/packet-pkix1implicit.c - M /trunk/epan/dissectors/packet-pkix1implicit.h - M /trunk/epan/dissectors/packet-pkixproxy.c - M /trunk/epan/dissectors/packet-pkixproxy.h - M /trunk/epan/dissectors/packet-pkixqualified.c - M /trunk/epan/dissectors/packet-pkixqualified.h - M /trunk/epan/dissectors/packet-pkixtsp.c - M /trunk/epan/dissectors/packet-pkixtsp.h + M /trunk/asn1/ranap/ranap.cnf + M /trunk/epan/dissectors/packet-gtp.c + M /trunk/epan/dissectors/packet-ranap.c + M /trunk/epan/dissectors/packet-ranap.h -Update do use the -X and -T asn2wrs flags. +Target Identification shall be coded as TLV IE where value is +coded as TargetRNC-ID. +Proposed fix to +https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=3974 +(The enclosed trace dioes not decode properly but may be wrongly encoded). ------------------------------------------------------------------------ -r23363 | etxrab | 2007-11-04 14:14:35 -0800 (Sun, 04 Nov 2007) | 1 line +r29817 | etxrab | 2009-09-09 01:50:06 -0700 (Wed, 09 Sep 2009) | 1 line Changed paths: - M /trunk/asn1/smrse/Makefile.common - M /trunk/epan/dissectors/packet-smrse.c - M /trunk/epan/dissectors/packet-smrse.h + M /trunk/gtk/new_packet_list.c + M /trunk/gtk/packet_list_store.c -Update do use the -X and -T asn2wrs flags. +Allocate col_text and col_text_len when the fdata struct is allocated. ------------------------------------------------------------------------ -r23364 | etxrab | 2007-11-04 14:16:28 -0800 (Sun, 04 Nov 2007) | 1 line +r29818 | etxrab | 2009-09-09 01:51:33 -0700 (Wed, 09 Sep 2009) | 2 lines Changed paths: - M /trunk/asn1/spnego/Makefile.common - M /trunk/epan/dissectors/packet-spnego.c - M /trunk/epan/dissectors/packet-spnego.h + M /trunk/file.c -Update do use the -X and -T asn2wrs flags. +Allocate col_text and col_text_len when the fdata struct is allocated. +(complete the checkin). ------------------------------------------------------------------------ -r23365 | etxrab | 2007-11-04 14:18:59 -0800 (Sun, 04 Nov 2007) | 1 line +r29819 | jmayer | 2009-09-09 06:20:33 -0700 (Wed, 09 Sep 2009) | 1 line Changed paths: - M /trunk/asn1/wlancertextn/Makefile.common - M /trunk/epan/dissectors/packet-wlancertextn.c - M /trunk/epan/dissectors/packet-wlancertextn.h + M /trunk/CMakeLists.txt + M /trunk/cmake/modules/FindADNS.cmake + A /trunk/cmake/modules/FindCARES.cmake + D /trunk/cmake/modules/FindDBUS.cmake + D /trunk/cmake/modules/FindDBUSGLIB.cmake + A /trunk/cmake/modules/FindGCRYPT.cmake + A /trunk/cmake/modules/FindGNUTLS.cmake + M /trunk/cmake/modules/FindGTK2.cmake + A /trunk/cmake/modules/FindLUA.cmake + M /trunk/cmake/modules/FindMATH.cmake + M /trunk/cmake/modules/FindPCAP.cmake + M /trunk/cmake/modules/FindPCRE.cmake + M /trunk/cmake/modules/FindPORTAUDIO.cmake + A /trunk/cmake/modules/FindSMI.cmake + M /trunk/cmake/modules/FindWSWIN32.cmake + A /trunk/cmake/modules/FindZ.cmake + M /trunk/cmakeconfig.h.in + A /trunk/codecs/CMakeLists.txt + M /trunk/epan/CMakeLists.txt + A /trunk/epan/wslua/CMakeLists.txt -Update do use the -X and -T asn2wrs flags. +CMAKE: Get most of of missing *build* pieces into place ------------------------------------------------------------------------ -r23366 | etxrab | 2007-11-05 12:41:44 -0800 (Mon, 05 Nov 2007) | 1 line +r29820 | jmayer | 2009-09-09 06:27:25 -0700 (Wed, 09 Sep 2009) | 4 lines Changed paths: - M /trunk/asn1/acse/Makefile.common - M /trunk/asn1/acse/acse.cnf - M /trunk/asn1/x509af/Makefile.common - M /trunk/asn1/x509ce/Makefile.common - M /trunk/asn1/x509if/Makefile.common - M /trunk/asn1/x509sat/Makefile.common - M /trunk/epan/dissectors/packet-acse.c - M /trunk/epan/dissectors/packet-acse.h - M /trunk/epan/dissectors/packet-x509af.c - M /trunk/epan/dissectors/packet-x509af.h - M /trunk/epan/dissectors/packet-x509ce.c - M /trunk/epan/dissectors/packet-x509ce.h - M /trunk/epan/dissectors/packet-x509if.c - M /trunk/epan/dissectors/packet-x509if.h - M /trunk/epan/dissectors/packet-x509sat.c - M /trunk/epan/dissectors/packet-x509sat.h + M /trunk/CMakeLists.txt -Update to use the -X and -T asn2wrs flags. ------------------------------------------------------------------------- -r23367 | etxrab | 2007-11-05 12:43:25 -0800 (Mon, 05 Nov 2007) | 2 lines -Changed paths: - M /trunk/wiretap/ber.c - M /trunk/wiretap/erf.c +Add missing include dirs when building wslua. +wslua doesn't build due to some probably non-cmake +related problem (have to verify though). -Strengthen BER and ERF heuristics to solve: -Fail to load I4B traces http://bugs.wireshark.org/bugzilla/show_bug.cgi?id=1972 ------------------------------------------------------------------------ -r23368 | etxrab | 2007-11-05 12:44:10 -0800 (Mon, 05 Nov 2007) | 1 line +r29821 | krj | 2009-09-09 07:01:57 -0700 (Wed, 09 Sep 2009) | 1 line Changed paths: + M /trunk/CMakeLists.txt + M /trunk/config.h.win32 + M /trunk/plugins/asn1/Makefile.nmake + M /trunk/plugins/docsis/Makefile.nmake + M /trunk/plugins/easy_codec/Makefile.nmake + M /trunk/plugins/ethercat/Makefile.nmake + M /trunk/plugins/giop/Makefile.nmake + M /trunk/plugins/gryphon/Makefile.nmake + M /trunk/plugins/irda/Makefile.nmake + M /trunk/plugins/m2m/Makefile.nmake + M /trunk/plugins/mate/Makefile.nmake + M /trunk/plugins/opcua/Makefile.nmake + M /trunk/plugins/profinet/Makefile.nmake + M /trunk/plugins/sercosiii/Makefile.nmake + M /trunk/plugins/stats_tree/Makefile.nmake + M /trunk/plugins/tpg/Makefile.nmake + M /trunk/plugins/unistim/Makefile.nmake + M /trunk/plugins/wimax/Makefile.nmake M /trunk/plugins/wimaxasncp/Makefile.nmake -Delete generated files at distclean. +We no longer support the old plugin API so remove it completely from the build system ------------------------------------------------------------------------ -r23369 | sake | 2007-11-05 15:05:20 -0800 (Mon, 05 Nov 2007) | 12 lines +r29822 | stig | 2009-09-09 07:11:10 -0700 (Wed, 09 Sep 2009) | 2 lines Changed paths: - M /trunk/AUTHORS - M /trunk/epan/dissectors/packet-dtls.c - M /trunk/epan/dissectors/packet-ssl-utils.c - M /trunk/epan/dissectors/packet-ssl-utils.h - -Bug 1954 From Mikael Magnusson : - -This patch updates the DTLS dissector to be compatible with OpenSSL 0.9.8f in -the following ways: -* Handle both SSL version number 0xfeff (RFC 4347 and OpenSSL 0.9.8f), and -0x100 (Used by OpenSSL 0.9.8e and earlier) -* Reassemble fragmented handshake messages. - - - + M /trunk/epan/dissectors/packet-m2ua.c +Fixed data type signedness for protocol_data_1_global. ------------------------------------------------------------------------ -r23370 | sfisher | 2007-11-05 21:06:31 -0800 (Mon, 05 Nov 2007) | 5 lines +r29823 | stig | 2009-09-09 08:06:38 -0700 (Wed, 09 Sep 2009) | 4 lines Changed paths: - M /trunk/epan/dissectors/packet-llt.c - - -Change instance of 0xCAFE to ETHERTYPE_LLT for consistency. No functional -changes. + M /trunk/epan/dissectors/packet-ospf.c +Added support for Multi-Topology (MT) Routing (RFC4915) +Added W and N flags +Fixed some string capitalizations. ------------------------------------------------------------------------ -r23371 | sfisher | 2007-11-05 21:30:04 -0800 (Mon, 05 Nov 2007) | 8 lines +r29824 | krj | 2009-09-09 09:38:09 -0700 (Wed, 09 Sep 2009) | 3 lines Changed paths: - M /trunk/epan/dissectors/Makefile.common - M /trunk/epan/dissectors/packet-ethertype.c - A /trunk/epan/dissectors/packet-wol.c - M /trunk/epan/etypes.h - - -Wake on LAN (WOL): New dissector from Chris Maynard via -dev list and -enhancement bug #1968 - -Me: Added entries in epan/etypes.h and epan/dissectors/packet-ethertype.c -for WOL. + M /trunk/dftest.c +* Free dfilter on shutdown +* Remove unused packet_info variable ------------------------------------------------------------------------ -r23372 | sahlberg | 2007-11-05 21:39:28 -0800 (Mon, 05 Nov 2007) | 3 lines +r29825 | jake | 2009-09-09 12:09:57 -0700 (Wed, 09 Sep 2009) | 3 lines Changed paths: - M /trunk/epan/dissectors/packet-vnc.c - -use strcasecmp instead of g_ascii_strcasecmp + M /trunk/epan/dissectors/packet-ssl-utils.c +From Ivan Sy: +Add a more descriptive log message on DH key exchange. ------------------------------------------------------------------------ -r23373 | sahlberg | 2007-11-05 21:51:49 -0800 (Mon, 05 Nov 2007) | 3 lines +r29827 | etxrab | 2009-09-09 12:34:14 -0700 (Wed, 09 Sep 2009) | 2 lines Changed paths: - M /trunk/epan/strutil.c - M /trunk/epan/strutil.h - -add a g_byte_array_sized_new() helper if we compile for glib < 2 - + M /trunk/gtk/expert_comp_table.c +Be consistent use and g_string_chunk_insert_const() in stead of +g_string_chunk_insert() as in expert_dlg.c ------------------------------------------------------------------------ -r23374 | guy | 2007-11-06 00:46:57 -0800 (Tue, 06 Nov 2007) | 8 lines +r29830 | guy | 2009-09-09 16:56:27 -0700 (Wed, 09 Sep 2009) | 21 lines Changed paths: - M /trunk/epan/ftypes/ftype-bytes.c + M /trunk/packaging/macosx/ChmodBPF/StartupParameters.plist -The "bitwise AND" display filter operator is supposed to evaluate to -TRUE if the result of the operation has any bit set; that means that the -test should stop and return TRUE as soon as it finds two bytes that when -ANDed together are non-zero, and return FALSE if no such byte was found. +To quote + + http://developer.apple.com/mac/library/documentation/MacOSX/Conceptual/BPSystemStartup/Articles/StartupItems.html -The other test functions don't have "_bytes" in the routine name; don't -put it into this one. +"Table 1 StartupParameters.plist key-value pairs ------------------------------------------------------------------------- -r23375 | guy | 2007-11-06 01:19:59 -0800 (Tue, 06 Nov 2007) | 4 lines -Changed paths: - M /trunk/epan/ftypes/ftype-ipv4.c +Key Type Value +Description String A short description of the startup item, + used by administrative tools. -Fix bug 1956 - make the bitwise-AND routine treat its arguments as being -IPv4 addresses. Also, rename that routine to cmp_bitwise_and(), as it's -not working on bit strings. +Provides Array The names of the services provided by this + startup item. Although a startup item can + potentially provide multiple services, it is + recommended that you limit your startup items + to only one service each." ------------------------------------------------------------------------- -r23376 | etxrab | 2007-11-06 10:10:34 -0800 (Tue, 06 Nov 2007) | 1 line -Changed paths: - M /trunk/Makefile.am - A /trunk/diameter/Ericsson.xml - M /trunk/diameter/dictionary.xml +Fix "Provides" to be the name of the service, not a description of the +helpful operations that it provides. -Fix some typos. ------------------------------------------------------------------------- -r23377 | etxrab | 2007-11-06 10:11:20 -0800 (Tue, 06 Nov 2007) | 1 line -Changed paths: - M /trunk/epan/dissectors/packet-uma.c +(Propagated from tcpdump.org git repository.) -Set up RTP conversation when PORT is known. ------------------------------------------------------------------------ -r23378 | jmayer | 2007-11-06 10:31:26 -0800 (Tue, 06 Nov 2007) | 108 lines +r29831 | guy | 2009-09-09 17:37:16 -0700 (Wed, 09 Sep 2009) | 3 lines Changed paths: - M /trunk/tools/pidl/lib/Parse/Pidl/Samba3/ClientNDR.pm - M /trunk/tools/pidl/lib/Parse/Pidl/Samba3/ServerNDR.pm - M /trunk/tools/pidl/lib/Parse/Pidl/Samba4/EJS.pm - M /trunk/tools/pidl/lib/Parse/Pidl/Samba4/Header.pm - M /trunk/tools/pidl/lib/Parse/Pidl/Samba4/NDR/Client.pm - M /trunk/tools/pidl/lib/Parse/Pidl/Samba4/NDR/Parser.pm - M /trunk/tools/pidl/lib/Parse/Pidl/Samba4/TDR.pm - M /trunk/tools/pidl/tests/Util.pm - M /trunk/tools/pidl/tests/ndr_align.pl - M /trunk/tools/pidl/tests/ndr_alloc.pl - M /trunk/tools/pidl/tests/ndr_array.pl - M /trunk/tools/pidl/tests/ndr_fullptr.pl - M /trunk/tools/pidl/tests/ndr_refptr.pl - M /trunk/tools/pidl/tests/ndr_represent.pl - M /trunk/tools/pidl/tests/ndr_simple.pl - M /trunk/tools/pidl/tests/ndr_string.pl - M /trunk/tools/pidl/tests/ndr_tagtype.pl - -Update from samba tree revision 25306 to 25880 -============================ Samba log start ============ ------------------------------------------------------------------------- -r25453 | jelmer | 2007-10-01 23:38:15 +0200 (Mon, 01 Oct 2007) | 1 line - -Fix include for NTSTATUS. ------------------------------------------------------------------------- -r25457 | jelmer | 2007-10-02 06:45:25 +0200 (Tue, 02 Oct 2007) | 1 line - -use different location for out-of-tree builds ------------------------------------------------------------------------- -r25674 | metze | 2007-10-17 10:26:55 +0200 (Wed, 17 Oct 2007) | 13 lines - -fix crash bug in pidl generated client code, this -could have happend with [in,out,unique] pointers -when the clients sends a valid pointer, but the server -reponse with a NULL pointer (as samba-3.0.26a do for some calls). - -I've tested with midl to see how windows handles this situation -and also the reverse case where the client sends NULL and -the server reposnse with non-NULL. - -It appears that midl generated code just ignores this -and only copies the result if both pointers are non-NULL. - -metze ------------------------------------------------------------------------- -r25700 | jra | 2007-10-19 02:40:51 +0200 (Fri, 19 Oct 2007) | 3 lines - -Now BOOL no longer exists in Samba 3.2, use bool instead. -Jeremy. - ------------------------------------------------------------------------- -r25745 | metze | 2007-10-27 11:57:09 +0200 (Sat, 27 Oct 2007) | 6 lines - -[pidl] ndr_pull/push_error(ndr, NDR_ERR_INVALID_POINTER,..) - -instead NT_STATUS_INVALID_PARAMETER_MIX - -metze - ------------------------------------------------------------------------- -r25751 | metze | 2007-10-30 07:24:43 +0100 (Tue, 30 Oct 2007) | 4 lines + M /trunk/packaging/macosx/ChmodBPF/README.macosx -use EJS_CHECK() instead of NDR_CHECK() in ejs code +Put in a note about the Snow Leopard bug that requires that you have BPF +devices open for writing in order to capture outgoing traffic. -metze - ------------------------------------------------------------------------- -r25765 | metze | 2007-10-31 17:25:44 +0100 (Wed, 31 Oct 2007) | 3 lines - -pidl: fix compiler warning in ndr_align test - -metze ------------------------------------------------------------------------- -r25766 | metze | 2007-10-31 17:27:21 +0100 (Wed, 31 Oct 2007) | 3 lines - -pidl: fix bugs in ndr_tagtype tests found by compiler warnings - -metze ------------------------------------------------------------------------- -r25767 | metze | 2007-10-31 17:29:32 +0100 (Wed, 31 Oct 2007) | 5 lines - -pidl: make it easier to debug errors in pidl tests - -we now print the C program that we tried to compile - -metze ------------------------------------------------------------------------ -r25768 | metze | 2007-10-31 17:44:42 +0100 (Wed, 31 Oct 2007) | 5 lines - -pidl: NT_STATUS_IS_ERR() is NOT the same as !NT_STATUS_IS_OK() - -Everything but success should be handled as error in the tests. +r29832 | morriss | 2009-09-09 19:15:55 -0700 (Wed, 09 Sep 2009) | 5 lines +Changed paths: + M /trunk/epan/dissectors/packet-ospf.c -metze ------------------------------------------------------------------------- -r25795 | metze | 2007-11-02 11:35:09 +0100 (Fri, 02 Nov 2007) | 3 lines +From Edward J. Paradise via https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=3954 : -whitespace cleanup... +The A and N bit descriptions should be Always and Never, not Answer and +Incomplete. -metze ------------------------------------------------------------------------ -r25804 | metze | 2007-11-02 14:02:25 +0100 (Fri, 02 Nov 2007) | 4 lines - -move including ndr_compression.h into HeaderInterface() +r29833 | morriss | 2009-09-09 19:40:19 -0700 (Wed, 09 Sep 2009) | 37 lines +Changed paths: + M /trunk/epan/dissectors/packet-nhrp.c -metze +From Chris Maynard via https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=3950 : ------------------------------------------------------------------------- -r25805 | metze | 2007-11-02 14:05:43 +0100 (Fri, 02 Nov 2007) | 4 lines +The attached patch improves NHRP dissection and encompasses the following +changes: +1) Now displays Request ID and CIE Reply code or Error code in Info column. -pidl: include libndr.h as first header in ndr_foo.h +2) Added support for RFC 2520 and RFC 2735 extensions and error codes. + References: + -> http://www.ietf.org/rfc/rfc2520.txt?number=2520 + -> http://www.ietf.org/rfc/rfc2735.txt?number=2735 + Note: Cisco's NAT Address Extension conflicts with RFC 2735's published +Device Capabilities Extension. Both are assigned type 9. As such, I have had +to add some heuristics to differentiate between them. It should be reliable +though since the former carries a CIE with length > 8 bytes, and the latter a +fixed-length payload of 8 bytes. -metze - ------------------------------------------------------------------------- -r25806 | metze | 2007-11-02 14:48:11 +0100 (Fri, 02 Nov 2007) | 5 lines +3) A few fields previously not filterable now are: hf_nhrp_hdr_op_type, +hf_nhrp_hdr_version and hf_nhrp_error_code. -let libndr.h include needed stuff and remove pidl magic -for choosing common required headers +4) Added support for authentication and vendor-private extension header decode. + NOTE: The authentication extension has been added according to RFC 2332. In +practice, it seems that at least with certain Cisco equipment (I tested with +cisco 2851 IOS version 12.4(15)T), they use their own non-standard +authentication extension format. Because of this, Cisco's version of the +extension will likely either be displayed a little differently than one may +expect or be indicated as being mal-formed ... because in reality, it is. -metze +5) Utilizes expert info in a couple more places to indicate mal-formed packets. + Cisco's Error Indication packet, for example, violates RFC 2332 Section 5.2.7 +by including extensions in the Error Indication packet as well as by including +erroneous data following the End Extension. Both cases are reported via expert +info now. Previously, at least with the case of the erroneous data following +the End Extension, the packet would almost certainly have been marked +mal-formed anyway. I now just prevent Wireshark from even attempting to decode +the non-sensical mess. ------------------------------------------------------------------------- ------------------------------------------------------------------------- -============================ Samba log end ============== ------------------------------------------------------------------------ -r23379 | etxrab | 2007-11-06 11:22:51 -0800 (Tue, 06 Nov 2007) | 3 lines +r29834 | morriss | 2009-09-09 19:46:40 -0700 (Wed, 09 Sep 2009) | 1 line Changed paths: - M /trunk/wiretap/erf.c + M /trunk/AUTHORS -From Florent Drouin: -Fix bug Some Toshiba format files with LAPD cannot be open -http://bugs.wireshark.org/bugzilla/show_bug.cgi?id=1711 +Add blurb for Chris Maynard's recent NHRP changes. ------------------------------------------------------------------------ -r23380 | etxrab | 2007-11-06 11:47:38 -0800 (Tue, 06 Nov 2007) | 2 lines +r29835 | etxrab | 2009-09-09 22:57:30 -0700 (Wed, 09 Sep 2009) | 4 lines Changed paths: - M /trunk/epan/dissectors/packet-cfm.c - M /trunk/epan/dissectors/packet-cfm.h + M /trunk/asn1/h248/Makefile.common + M /trunk/asn1/h248/h248.cnf + A /trunk/asn1/h248/h248v1support.asn + M /trunk/asn1/h248/packet-h248-template.c + M /trunk/epan/dissectors/packet-h248.c + M /trunk/epan/dissectors/packet-h248.h -From Keith Mercer: -CFM dissector bugfixes and code update for ITU inclusion +From Alex Lindberg: +Add H248V1 suport. +(H248 dissector fails on poorly formed AuditReply packet from Media Gateway) +https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=3953 ------------------------------------------------------------------------ -r23381 | jmayer | 2007-11-06 12:03:22 -0800 (Tue, 06 Nov 2007) | 3 lines +r29836 | etxrab | 2009-09-09 23:07:31 -0700 (Wed, 09 Sep 2009) | 3 lines Changed paths: - M /trunk/COPYING - -Add a remark that the code under tools/pidl/ is covered -by GPLv3 (inside the files it only says GPL). + M /trunk/epan/dissectors/packet-afp.c + M /trunk/epan/dissectors/packet-afp.h + M /trunk/epan/dissectors/packet-dsi.c +From Alex deVries: +DSI/AFP dissectors need support for AFP 3.3 +https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=3995 ------------------------------------------------------------------------ -r23382 | etxrab | 2007-11-06 12:16:59 -0800 (Tue, 06 Nov 2007) | 1 line +r29837 | etxrab | 2009-09-09 23:37:04 -0700 (Wed, 09 Sep 2009) | 3 lines Changed paths: - M /trunk/asn1/dap/Makefile.common - M /trunk/asn1/dap/dap.asn - M /trunk/epan/dissectors/packet-dap.c + M /trunk/epan/wslua/wslua_tree.c -as2wrs now handles EXTERNAL(direct-reference requires no special handling). +From Diego: +proto_item_set_len is missing from Lua API. +https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=3994 ------------------------------------------------------------------------ -r23383 | etxrab | 2007-11-06 12:21:09 -0800 (Tue, 06 Nov 2007) | 1 line +r29838 | jmayer | 2009-09-10 00:04:54 -0700 (Thu, 10 Sep 2009) | 4 lines Changed paths: - M /trunk/asn1/disp/Makefile.common - M /trunk/asn1/disp/disp.asn - M /trunk/epan/dissectors/packet-disp.c + M /trunk/CMakeLists.txt + A /trunk/cmake/modules/FindCAP.cmake + A /trunk/cmake/modules/FindGEOIP.cmake + A /trunk/cmake/modules/FindKERBEROS.cmake + A /trunk/cmake/modules/FindM.cmake (from /trunk/cmake/modules/FindMATH.cmake:29823) + D /trunk/cmake/modules/FindMATH.cmake + A /trunk/epan/wspython/CMakeLists.txt -as2wrs now handles EXTERNAL(direct-reference requires no special handling). ------------------------------------------------------------------------- -r23384 | etxrab | 2007-11-06 12:26:13 -0800 (Tue, 06 Nov 2007) | 1 line -Changed paths: - M /trunk/asn1/disp/disp.cnf - M /trunk/asn1/dop/Makefile.common - M /trunk/asn1/dop/dop.asn - M /trunk/asn1/dop/dop.cnf - M /trunk/epan/dissectors/packet-disp.c - M /trunk/epan/dissectors/packet-dop.c +Update to add the last missing detection stuff. +Some of it is untested, kerberos is currently a hack. +Apart from that, package detection should be complete. -as2wrs now handles EXTERNAL(direct-reference requires no special handling). ------------------------------------------------------------------------ -r23385 | gerald | 2007-11-06 12:32:30 -0800 (Tue, 06 Nov 2007) | 3 lines +r29839 | tuexen | 2009-09-10 02:50:30 -0700 (Thu, 10 Sep 2009) | 2 lines Changed paths: - M /trunk/packaging/nsis/Makefile.am - A /trunk/packaging/nsis/VersionCompare.nsh - M /trunk/packaging/nsis/wireshark.nsi + M /trunk/epan/dissectors/packet-isup.c -When checking to see if we should install WinPcap, check the installed -version directly instead of trying to divine it from its name. +Fix handling of BEARER_CONTROL_UNIT_IDENTIFIER. ------------------------------------------------------------------------ -r23386 | etxrab | 2007-11-06 13:52:26 -0800 (Tue, 06 Nov 2007) | 1 line +r29840 | krj | 2009-09-10 06:52:36 -0700 (Thu, 10 Sep 2009) | 1 line Changed paths: - M /trunk/asn1/dsp/Makefile.common - M /trunk/asn1/dsp/dsp.asn - M /trunk/asn1/dsp/dsp.cnf - M /trunk/asn1/x411/Makefile.common - M /trunk/asn1/x411/x411.asn - M /trunk/asn1/x411/x411.cnf - M /trunk/asn1/x420/ftbp.asn - M /trunk/asn1/x420/x420.asn - M /trunk/asn1/x420/x420.cnf - M /trunk/epan/dissectors/packet-dsp.c - M /trunk/epan/dissectors/packet-rrc.c - M /trunk/epan/dissectors/packet-x411.c - M /trunk/epan/dissectors/packet-x411.h - M /trunk/epan/dissectors/packet-x420.c + M /trunk/epan/ftypes/ftypes.h -as2wrs now handles EXTERNAL(direct-reference requires no special handling). +Remove unused field ------------------------------------------------------------------------ -r23387 | jmayer | 2007-11-06 14:01:20 -0800 (Tue, 06 Nov 2007) | 8 lines +r29841 | krj | 2009-09-10 07:37:09 -0700 (Thu, 10 Sep 2009) | 19 lines Changed paths: - M /trunk/COPYING + M /trunk/epan/ftypes/ftype-bytes.c + M /trunk/epan/ftypes/ftypes.h -Add two sentences clarifying the license statement on pidl: +Use the correct type, that is GByteArray instead of GString. The reason why this 'worked' before (on non-64bit platforms that is): -As a notable exception the pidl utility at tools/pidl is covered by a -"GPL version 3 or later" LICENSE. Note that only the tool itself -is covered by this license, not the source code generated by it. The -pidl authors do not consider that code a derived work of pidl. +struct _GString +{ + gchar *str; + gsize len; + gsize allocated_len; +}; +And: ------------------------------------------------------------------------- -r23388 | jmayer | 2007-11-07 09:23:28 -0800 (Wed, 07 Nov 2007) | 1 line -Changed paths: - M /trunk/epan/dissectors/packet-isakmp.c +struct _GArray +{ + gchar *data; + guint len; +}; -Print VendorID string in payload summary line ------------------------------------------------------------------------- -r23389 | etxrab | 2007-11-07 09:55:06 -0800 (Wed, 07 Nov 2007) | 1 line -Changed paths: - D /trunk/epan/dissectors/packet-MAP_DialoguePDU.c - D /trunk/epan/dissectors/packet-MAP_DialoguePDU.h - D /trunk/epan/dissectors/packet-gsm_ss.c - D /trunk/epan/dissectors/packet-gsm_ss.h +We only accessed the first two fields of the GString struct. -Delete obsolete dissectors. ------------------------------------------------------------------------ -r23390 | etxrab | 2007-11-07 09:55:57 -0800 (Wed, 07 Nov 2007) | 1 line +r29842 | morriss | 2009-09-10 08:30:10 -0700 (Thu, 10 Sep 2009) | 4 lines Changed paths: - M /trunk/asn1/h248/Makefile.common - M /trunk/asn1/t125/Makefile.common - M /trunk/epan/dissectors/packet-h248.c - M /trunk/epan/dissectors/packet-h248.h - M /trunk/epan/dissectors/packet-t125.c - M /trunk/epan/dissectors/packet-t125.h + M /trunk/AUTHORS + M /trunk/epan/dissectors/packet-mpls.c + M /trunk/epan/dissectors/packet-pw-cesopsn.c + M /trunk/epan/dissectors/packet-pw-common.h + M /trunk/epan/dissectors/packet-pw-satop.c -Update to use the -X and -T asn2wrs flags. ------------------------------------------------------------------------- -r23391 | jmayer | 2007-11-07 10:35:00 -0800 (Wed, 07 Nov 2007) | 3 lines -Changed paths: - M /trunk/epan/dissectors/packet-isakmp.c +From Artem Tamazov via https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=3903 : -Add VID VID_draft_ietf_ipsec_nat_t_ike_01, move -VID_draft_ietf_ipsec_nat_t_ike_03 a bit down. +Decoding of UDP-multiplexed CESoPSN and SAToP traffic. ------------------------------------------------------------------------ -r23392 | stig | 2007-11-07 12:03:29 -0800 (Wed, 07 Nov 2007) | 3 lines +r29843 | gerald | 2009-09-10 09:50:25 -0700 (Thu, 10 Sep 2009) | 7 lines Changed paths: - M /trunk/epan/dissectors/packet-dmp.c - -Create a subset tvb for dissect_x411_ORName so it doesn't eat too much data. -Removed some unnecessary int casts. + M /trunk/epan/crypt/airpdcap.c ------------------------------------------------------------------------- -r23393 | gerald | 2007-11-07 12:13:40 -0800 (Wed, 07 Nov 2007) | 3 lines -Changed paths: - M /trunk/docbook/wsdg_src/WSDG_chapter_quick_setup.xml +WPA decryption fix from Greg Schwendimann via bug 3890: -Back out r23308 for the time being, since it's making hhc.exe on the Windows -builder crash. +I'm reasonably sure that I introduced this bug and I apologize for the problems +with my previous patch. The problem is that I did not use all of the seen +keys, I used all except the first key, which in a case of one key is none. +The attached patch fixes the error. ------------------------------------------------------------------------ -r23394 | etxrab | 2007-11-07 13:22:25 -0800 (Wed, 07 Nov 2007) | 1 line +r29844 | krj | 2009-09-10 09:54:02 -0700 (Thu, 10 Sep 2009) | 1 line Changed paths: - M /trunk/asn1/h248/h248.cnf - M /trunk/asn1/tcap/Makefile.common - M /trunk/asn1/tcap/tcap.cnf - M /trunk/epan/dissectors/packet-tcap.c - M /trunk/epan/dissectors/packet-tcap.h + M /trunk/asn1/snmp/packet-snmp-template.c + M /trunk/epan/dissectors/packet-sccp.c + M /trunk/epan/dissectors/packet-snmp.c + M /trunk/epan/dissectors/packet-sua.c + M /trunk/epan/libwireshark.def + M /trunk/epan/tvbuff.c + M /trunk/epan/tvbuff.h -Update to use the -X and -T asn2wrs flags. +offset_from_real_beginning() is only called with 0 as second argument, so remove the argument completely. It seems that the second argument only acts as an accumulator allowing offset_from_real_beginning() to call itself recursively. To be consistent offset_from_real_beginning() is renamed to tvb_offset_from_real_beginning(). ------------------------------------------------------------------------ -r23395 | sfisher | 2007-11-07 13:50:48 -0800 (Wed, 07 Nov 2007) | 6 lines +r29845 | martinm | 2009-09-10 11:12:41 -0700 (Thu, 10 Sep 2009) | 2 lines Changed paths: - M /trunk/epan/prefs.c - M /trunk/epan/prefs.h - M /trunk/gtk/layout_prefs.c - M /trunk/gtk/toolbar.c - - -Add an arrow with drop-down menu including any toolbar buttons that do not -fit on the top of the screen. This only works in GTK 2.4+ and there is -a layout preference setting to disable it. + M /trunk/epan/dissectors/packet-mac-lte.c +Re-arrange dissection of UL/DL-SCH so easier to test for ommitted SDUs. ------------------------------------------------------------------------ -r23396 | gerald | 2007-11-07 16:58:38 -0800 (Wed, 07 Nov 2007) | 2 lines +r29846 | krj | 2009-09-10 11:22:33 -0700 (Thu, 10 Sep 2009) | 1 line Changed paths: - M /trunk/epan/dissectors/packet-tcp.c - -Add more TCP analysis struct checks. + M /trunk/epan/ftypes/ftype-bytes.c + M /trunk/epan/ftypes/ftypes.h + M /trunk/epan/proto.c +Introduce a few FT_XXX lengths defines and use those instead of hard coding constants ------------------------------------------------------------------------ -r23397 | sfisher | 2007-11-07 18:29:18 -0800 (Wed, 07 Nov 2007) | 6 lines +r29847 | jake | 2009-09-10 11:54:12 -0700 (Thu, 10 Sep 2009) | 4 lines Changed paths: - M /trunk/epan/prefs.c - - -Fix Windows builds that cannot find gtk/gtk.h from epan/prefs.c. Write out -toolbar arrow preference even in GTK < 2.4 and just don't use it unless -running GTK 2.4+. + M /trunk/epan/dissectors/packet-ieee802154.c + M /trunk/epan/dissectors/packet-ieee802154.h +From Jean-Fran?\195?\167ois Wauthy: +This patch fixes a bug in the dissection of the TI CC24xx FCS where the +endianness of the bitmasks used was wrong. ------------------------------------------------------------------------ -r23398 | gerald | 2007-11-07 21:54:29 -0800 (Wed, 07 Nov 2007) | 2 lines +r29849 | jake | 2009-09-10 13:42:17 -0700 (Thu, 10 Sep 2009) | 8 lines Changed paths: - M /trunk/docbook/release-notes.xml - M /trunk/epan/dissectors/packet-ncp2222.inc + M /trunk/epan/dissectors/packet-ieee802154.c + M /trunk/epan/dissectors/packet-ieee802154.h -Fix a couple of integer underflows. +From Jean-Fran?\195?\167ois Wauthy: +Implementation of the IEEE 802.15.4 dissector ignores the Auxiliary Security +Header of the MHR (see IEEE 802.15.4-2006 specs p.138). +The attached patch, add two things : + 1) Support for dissecting the Auxiliary Security Header + 2) Add a preference option to force the dissection of + the FCS field as being in the TI CC24xx format ------------------------------------------------------------------------ -r23399 | gerald | 2007-11-08 08:59:30 -0800 (Thu, 08 Nov 2007) | 4 lines +r29852 | martinm | 2009-09-10 15:53:57 -0700 (Thu, 10 Sep 2009) | 3 lines Changed paths: - M /trunk/test/config.sh - M /trunk/test/suite-capture.sh - M /trunk/test/suite-clopts.sh - -Move SKIP_CAPTURE from suite-capture.sh to config.sh so that we can use it -in suite-clopts as well. Allow it to be set externally. This should fix -the "test" failure in the Solairs builder. + M /trunk/epan/dissectors/packet-mac-lte.c + M /trunk/epan/dissectors/packet-rlc-lte.c ------------------------------------------------------------------------- -r23400 | etxrab | 2007-11-08 09:24:17 -0800 (Thu, 08 Nov 2007) | 2 lines -Changed paths: - M /trunk/diameter/etsie2e4.xml +Add the option to call RLC dissector for LCID 1&2. +These should be srb1 & srb2 (AM). -- "Location-Information" is grouped. -- Add TS 183 033 V1.2.0 (2007-10) AVP:s ------------------------------------------------------------------------ -r23401 | morriss | 2007-11-08 11:13:51 -0800 (Thu, 08 Nov 2007) | 5 lines +r29853 | guy | 2009-09-10 17:00:45 -0700 (Thu, 10 Sep 2009) | 2 lines Changed paths: - M /trunk/epan/tcap-persistentdata.c + M /trunk/epan/dissectors/packet-rtcp.c -Don't cast pinfo->src.data to (const mtp3_addr_pc_t *) unless we *know* it's -an MTP3 PC in there (else we get a bus error on SPARC systems). -If we don't have MTP3 PC addresses hash on address_to_str(&pinfo->src). This -makes TCAP statistics work over SUA. +Get rid of trailing space in string. ------------------------------------------------------------------------ -r23402 | etxrab | 2007-11-08 14:36:19 -0800 (Thu, 08 Nov 2007) | 1 line +r29854 | morriss | 2009-09-10 18:57:59 -0700 (Thu, 10 Sep 2009) | 9 lines Changed paths: - M /trunk/epan/dissectors/packet-diameter.c - -Change dissecton of address type for AVP < 256 (RADIUS address). ------------------------------------------------------------------------- -r23403 | etxrab | 2007-11-08 14:38:06 -0800 (Thu, 08 Nov 2007) | 2 lines -Changed paths: - M /trunk/epan/dissectors/packet-smb.c + M /trunk/AUTHORS + M /trunk/epan/dissectors + M /trunk/epan/dissectors/Makefile.am + M /trunk/epan/dissectors/Makefile.common + M /trunk/epan/dissectors/Makefile.nmake + A /trunk/epan/dissectors/README.X11 + M /trunk/epan/dissectors/packet-x11.c + M /trunk/epan/dissectors/process-x11-fields.pl + A /trunk/epan/dissectors/process-x11-xcb.pl + A /trunk/epan/dissectors/x11-declarations.h + A /trunk/epan/dissectors/x11-extension-errors.h + A /trunk/epan/dissectors/x11-extension-implementation.h + A /trunk/epan/dissectors/x11-glx-render-enum.h + A /trunk/epan/dissectors/x11-register-info.h -Apply yet another set of the optimization patches: -- Move proto_tree_add_xxxx calls inside 'if (tree) {}' block ------------------------------------------------------------------------- -r23404 | etxrab | 2007-11-08 14:39:01 -0800 (Thu, 08 Nov 2007) | 3 lines -Changed paths: - M /trunk/epan/dissectors/packet-nfs.c +From Peter Harris via https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=2981 : -Apply yet another set of the optimization patches: -if tree is not NULL then proto_xxx_add_yyy functions can't return NULL. -Remove always true tests. ------------------------------------------------------------------------- -r23405 | etxrab | 2007-11-08 14:40:20 -0800 (Thu, 08 Nov 2007) | 3 lines -Changed paths: - M /trunk/epan/dissectors/packet-clnp.c - M /trunk/epan/dissectors/packet-cpha.c - M /trunk/epan/dissectors/packet-dcp.c - M /trunk/epan/dissectors/packet-ddtp.c - M /trunk/epan/dissectors/packet-enip.c - M /trunk/epan/dissectors/packet-epmd.c - M /trunk/epan/dissectors/packet-etheric.c - M /trunk/epan/dissectors/packet-extreme.c - M /trunk/epan/dissectors/packet-gdsdb.c - M /trunk/epan/dissectors/packet-ipsec.c - M /trunk/epan/dissectors/packet-kerberos.c - M /trunk/epan/dissectors/packet-l2tp.c - M /trunk/epan/dissectors/packet-ldp.c - M /trunk/epan/dissectors/packet-mdshdr.c - M /trunk/epan/dissectors/packet-mpls-echo.c - M /trunk/epan/dissectors/packet-ndps.c - M /trunk/epan/dissectors/packet-olsr.c - M /trunk/epan/dissectors/packet-smb-pipe.c - M /trunk/epan/dissectors/packet-tapa.c - M /trunk/epan/dissectors/packet-xot.c +This patch adds extension support to the X11 dissector. -Apply yet another set of the optimization patches: -When offset parameter is 0 replace tvb_bytes_exist() with the faster tvb_length(). -non heuristic dissectors ------------------------------------------------------------------------- -r23406 | etxrab | 2007-11-08 14:49:03 -0800 (Thu, 08 Nov 2007) | 2 lines -Changed paths: - M /trunk/epan/dissectors/packet-camel.c - M /trunk/epan/dissectors/packet-cmp.c - M /trunk/epan/dissectors/packet-dhcpv6.c - M /trunk/epan/dissectors/packet-dtpt.c - M /trunk/epan/dissectors/packet-fcdns.c - M /trunk/epan/dissectors/packet-fcfcs.c - M /trunk/epan/dissectors/packet-fcfzs.c - M /trunk/epan/dissectors/packet-fcp.c - M /trunk/epan/dissectors/packet-fcsb3.c - M /trunk/epan/dissectors/packet-fcsp.c - M /trunk/epan/dissectors/packet-inap.c - M /trunk/epan/dissectors/packet-iuup.c - M /trunk/epan/dissectors/packet-kpasswd.c - M /trunk/epan/dissectors/packet-lpd.c - M /trunk/epan/dissectors/packet-mpls-echo.c - M /trunk/epan/dissectors/packet-msdp.c - M /trunk/epan/dissectors/packet-nettl.c - M /trunk/epan/dissectors/packet-ntp.c - M /trunk/epan/dissectors/packet-pktc.c - M /trunk/epan/dissectors/packet-pvfs2.c - M /trunk/epan/dissectors/packet-qllc.c - M /trunk/epan/dissectors/packet-quake2.c - M /trunk/epan/dissectors/packet-quakeworld.c - M /trunk/epan/dissectors/packet-rmp.c - M /trunk/epan/dissectors/packet-smb-browse.c - M /trunk/epan/dissectors/packet-teimanagement.c - M /trunk/epan/dissectors/packet-umts_fp.c +I've removed the perl script from the make file, since the new one depends on +perl 5.10, xcbproto (at least git as of today), and mesa (at least the +mesa/src/mesa/glapi directory). It seemed easier to just add the generated +header files to svn directly. -Apply yet another set of the optimization patches: --set_str2add_str_val_to_str ------------------------------------------------------------------------ -r23407 | sfisher | 2007-11-08 18:08:00 -0800 (Thu, 08 Nov 2007) | 5 lines +r29855 | jmayer | 2009-09-11 03:46:53 -0700 (Fri, 11 Sep 2009) | 2 lines Changed paths: - M /trunk/epan/prefs.c - M /trunk/epan/prefs.h - M /trunk/gtk/layout_prefs.c - M /trunk/gtk/toolbar.c - - -Back out part of revision 23395 - leave the toolbar arrow, but remove the -preference to turn it on / off per discussion on -dev list. + M /trunk/epan/CMakeLists.txt +Update generating the x11 stuff to follow configure ------------------------------------------------------------------------ -r23408 | etxrab | 2007-11-08 21:54:16 -0800 (Thu, 08 Nov 2007) | 2 lines +r29856 | morriss | 2009-09-11 04:22:23 -0700 (Fri, 11 Sep 2009) | 1 line Changed paths: - M /trunk/epan/dfilter/dfilter.c + M /trunk/epan/dissectors/process-x11-xcb.pl + M /trunk/epan/dissectors/x11-extension-implementation.h -Apply yet another set of the optimization patches: -small memory leak when freeing compiled filter insns. +When pre-declaring variables, use the right type. ------------------------------------------------------------------------ -r23409 | etxrab | 2007-11-08 21:55:33 -0800 (Thu, 08 Nov 2007) | 2 lines +r29857 | etxrab | 2009-09-11 04:58:00 -0700 (Fri, 11 Sep 2009) | 2 lines Changed paths: - M /trunk/epan/addr_resolv.c + M /trunk/file.c -Apply yet another set of the optimization patches: -Don't use g_snprintf for temporary unsigned int to ascii conversion. +New_packet_list +Select the correct frame in packet details when filtering. ------------------------------------------------------------------------ -r23410 | etxrab | 2007-11-08 21:56:42 -0800 (Thu, 08 Nov 2007) | 2 lines +r29858 | jmayer | 2009-09-11 06:30:01 -0700 (Fri, 11 Sep 2009) | 4 lines Changed paths: - M /trunk/epan/dissectors/packet-ip.c + M /trunk/README.cmake + M /trunk/epan/CMakeLists.txt + +- Update README.cmake: The stuff now build without + running autofoo first. +- Add a comment how to change the name of a generated target -Apply yet another set of the optimization patches: -Only call get_hostname once. ------------------------------------------------------------------------ -r23411 | etxrab | 2007-11-08 21:57:45 -0800 (Thu, 08 Nov 2007) | 2 lines +r29859 | krj | 2009-09-11 07:00:36 -0700 (Fri, 11 Sep 2009) | 1 line Changed paths: - M /trunk/epan/dissectors/packet-aim-buddylist.c - M /trunk/epan/dissectors/packet-dcm.c + M /trunk/epan/column-utils.c -Apply yet another set of the optimization patches: -janitor work, replace col_add_fstr/ col_set_fstr. +Move some CHECK_COL to our public functions, allowing us to bail our more quickly ------------------------------------------------------------------------ -r23412 | etxrab | 2007-11-08 22:01:18 -0800 (Thu, 08 Nov 2007) | 9 lines +r29860 | krj | 2009-09-11 07:21:04 -0700 (Fri, 11 Sep 2009) | 4 lines Changed paths: - M /trunk/epan/dissectors/packet-bittorrent.c - M /trunk/epan/dissectors/packet-cigi.c - M /trunk/epan/dissectors/packet-dccp.c - M /trunk/epan/dissectors/packet-dcerpc.c - M /trunk/epan/dissectors/packet-pktgen.c - M /trunk/epan/dissectors/packet-rmt-norm.c - M /trunk/epan/dissectors/packet-ses.c - M /trunk/epan/dissectors/packet-smb.c - M /trunk/epan/dissectors/packet-smb2.c - M /trunk/epan/dissectors/packet-stun.c - M /trunk/epan/dissectors/packet-stun2.c - M /trunk/epan/dissectors/packet-tds.c - M /trunk/epan/dissectors/packet-yhoo.c - M /trunk/plugins/ciscosm/packet-sm.c + M /trunk/epan/column-utils.c -Apply yet another set of the optimization patches: -When offset parameter is 0 replace tvb_bytes_exist() with the faster tvb_length(). +Make sure that we point the current column to a constant string if we have no address. -On the other hand - if (tvb_bytes_exist(tvb, 0, 20) -is more readable than - if (tvb_length(tvb) >= 20 +Fixes http://wiki.wireshark.org/Development/OptimizePacketList?action=diff&rev1=20&rev2=21 -so only do it in heuristic function ------------------------------------------------------------------------ -r23413 | etxrab | 2007-11-08 22:07:30 -0800 (Thu, 08 Nov 2007) | 5 lines +r29861 | etxrab | 2009-09-11 07:58:49 -0700 (Fri, 11 Sep 2009) | 1 line Changed paths: - M /trunk/epan/packet.c + M /trunk/file.c -Apply yet another set of the optimization patches: -move the case where pinfo->in_error_pkt is true in its own function: -- it's not the common case. -- it needs a TRY block. ==> slow volatile and big stack footprint. -- call_dissector_work is called a lot and recursively. +Only move to last row if it's vissible. ------------------------------------------------------------------------ -r23414 | martinm | 2007-11-09 06:41:04 -0800 (Fri, 09 Nov 2007) | 4 lines +r29862 | martinm | 2009-09-11 08:16:53 -0700 (Fri, 11 Sep 2009) | 2 lines Changed paths: - M /trunk/plugins/wimaxasncp/Makefile.am - M /trunk/plugins/wimaxasncp/packet-wimaxasncp.c - M /trunk/plugins/wimaxasncp/wimaxasncp_dict.h - M /trunk/plugins/wimaxasncp/wimaxasncp_dict.l + M /trunk/epan/dissectors/packet-rlc-lte.c -From Stephen Croll. - -Dynamically register filter fields from TLV definitions. +Add more useful summary info to RLC root. Useful mostly for when called from MAC. ------------------------------------------------------------------------ -r23415 | gerald | 2007-11-09 12:04:40 -0800 (Fri, 09 Nov 2007) | 7 lines +r29863 | sfisher | 2009-09-11 08:38:33 -0700 (Fri, 11 Sep 2009) | 5 lines Changed paths: - M /trunk/docbook/release-notes.xml - M /trunk/epan/dissectors/packet-http.c - -Don't call tvb_set_child_real_data_tvbuff() + add_new_data_source() twice -for the same tvb. This keeps us from freeing the same memory twice and -crashing on some systems. + M /trunk/file.c -This might be the same bug Brian Vandenberg was looking for in -http://www.wireshark.org/lists/wireshark-dev/200705/msg00406.html . ------------------------------------------------------------------------- -r23416 | gerald | 2007-11-09 12:05:44 -0800 (Fri, 09 Nov 2007) | 2 lines -Changed paths: - M /trunk/editcap.c +Fix warning that variable may be unused and then declare volatile so it +survives the TRY/CATCH code. -Add a newline. ------------------------------------------------------------------------ -r23417 | guy | 2007-11-09 16:36:01 -0800 (Fri, 09 Nov 2007) | 2 lines +r29864 | jake | 2009-09-11 09:58:21 -0700 (Fri, 11 Sep 2009) | 3 lines Changed paths: - M /trunk/plugins/wimaxasncp/packet-wimaxasncp.c - -Cast "char"s to "unsigned char" before handing them to <ctype.h> macros. + M /trunk/epan/dissectors/packet-ieee802154.c +From Jean-Fran?\195?\167ois Wauthy: +Dissect the Auxiliary Security Header for IEEE 802.15.4-2006 only. +Also Auxiliary Security Header dissection endianness bugfix. ------------------------------------------------------------------------ -r23418 | sfisher | 2007-11-09 16:57:41 -0800 (Fri, 09 Nov 2007) | 4 lines +r29865 | morriss | 2009-09-11 11:06:50 -0700 (Fri, 11 Sep 2009) | 6 lines Changed paths: - M /trunk/Makefile.am - M /trunk/configure.in - M /trunk/version_info.c + M /trunk/epan/dissectors/process-x11-xcb.pl + M /trunk/epan/dissectors/x11-extension-errors.h + M /trunk/epan/dissectors/x11-extension-implementation.h + M /trunk/epan/dissectors/x11-glx-render-enum.h +From Peter Harris via https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=2981 : -Add MacOS X version next to the Darwin version in version outputs. +Put the git version of mesa and xcbproto in the generated header files. +From me: Don't use 'which' to find git--it wouldn't work on Windows. ------------------------------------------------------------------------ -r23419 | guy | 2007-11-09 18:18:18 -0800 (Fri, 09 Nov 2007) | 2 lines +r29866 | morriss | 2009-09-11 11:15:46 -0700 (Fri, 11 Sep 2009) | 1 line Changed paths: - M /trunk/configure.in - -Update comment, clean up message. + D /trunk/svnadd + A /trunk/tools/svnadd (from /trunk/svnadd:29853) +Move svnadd to the tools directory. ------------------------------------------------------------------------ -r23420 | guy | 2007-11-09 18:39:19 -0800 (Fri, 09 Nov 2007) | 2 lines +r29867 | gerald | 2009-09-11 12:13:39 -0700 (Fri, 11 Sep 2009) | 4 lines Changed paths: - M /trunk/configure.in + M /trunk/gtk/new_packet_list.c -Quote a "Checking for" message. +Reduce the spacing between new packet list items from 2 pixels to 1. If +we want the new packet list to look like the old packet list we'll have +to adjust the behavior of the cell renderer. ------------------------------------------------------------------------ -r23421 | sake | 2007-11-10 07:18:49 -0800 (Sat, 10 Nov 2007) | 13 lines +r29868 | gerald | 2009-09-11 13:36:01 -0700 (Fri, 11 Sep 2009) | 1 line Changed paths: - M /trunk/color_filters.c - M /trunk/color_filters.h - M /trunk/gtk/color_dlg.c - M /trunk/gtk/color_edit_dlg.c - M /trunk/gtk/colors.c - M /trunk/gtk/colors.h - M /trunk/gtk/compat_macros.h - M /trunk/gtk/toolbar.c - -This patch makes it possible to disable individual coloring rules -without having to delete them. The patch has been tested on -Fedora-7 with GTK+ 1.2.10 and GTK+ 2.10.11. - -Since I don't know how to use "strikethrough" in clists in GTK1 -there is a little difference in how the disabled coloring rules -are displayed. In GTK2 they are striked through and in GTK1 -they are shown in lightgrey on a white background. - -Any info on how to use strikthrough in clists within GTK1 is more -than welcome :-) + M /trunk/gtk/new_packet_list.c + M /trunk/gtk/packet_list_store.c ------------------------------------------------------------------------ -r23422 | etxrab | 2007-11-10 08:08:14 -0800 (Sat, 10 Nov 2007) | 2 lines +r29869 | jmayer | 2009-09-12 10:14:10 -0700 (Sat, 12 Sep 2009) | 2 lines Changed paths: - M /trunk/epan/reassemble.c + M /trunk/getopt.h -Apply yet another set of the optimization patches: -Use O(1) logic for the fast path when adding fragments (ie fragments are in order). ------------------------------------------------------------------------- -r23423 | etxrab | 2007-11-10 08:09:10 -0800 (Sat, 10 Nov 2007) | 2 lines -Changed paths: - M /trunk/gtk/conversations_fc.c - M /trunk/gtk/conversations_table.c - M /trunk/gtk/conversations_table.h - -Apply yet another set of the optimization patches: -there's two structures with the same name conversation_t, change one to conv_t ------------------------------------------------------------------------- -r23424 | etxrab | 2007-11-10 09:06:49 -0800 (Sat, 10 Nov 2007) | 5 lines -Changed paths: - M /trunk/epan/dissectors/packet-eth.c +Add arguments to the getopt() prototype -Apply yet another set of the optimization patches: -move TRY block in its own function. - __attribute__((noinline)) does not compile with MS VC 6 -nor does __declspec(noinline) -Applied the patch without it. ------------------------------------------------------------------------ -r23425 | stig | 2007-11-10 13:59:20 -0800 (Sat, 10 Nov 2007) | 3 lines +r29870 | jmayer | 2009-09-12 10:20:08 -0700 (Sat, 12 Sep 2009) | 3 lines Changed paths: - M /trunk/gtk/main.c + M /trunk/CMakeLists.txt + M /trunk/ConfigureChecks.cmake + M /trunk/README.cmake + M /trunk/cmake/modules/FindCAP.cmake + M /trunk/cmake/modules/FindCARES.cmake + A /trunk/cmake/modules/FindPYTHON.cmake + M /trunk/cmakeconfig.h.in + M /trunk/epan/CMakeLists.txt -Ensure we pop any previous loaded filename from the statusbar -when loading a new file with a file already loaded. +Make building with GeoIP, Python, Capabilities and c-ares +actually work. ------------------------------------------------------------------------ -r23426 | sake | 2007-11-10 15:05:35 -0800 (Sat, 10 Nov 2007) | 18 lines +r29871 | morriss | 2009-09-12 16:02:34 -0700 (Sat, 12 Sep 2009) | 6 lines Changed paths: - M /trunk/gtk/color_dlg.c - -Make the enable/disable buttons on the coloring rule list follow -the selection. There is a little difference between the behaviour -in GTK1 and GTK2 (As long as either one row or a block of rows with -the same status is selected, GTK1 and GTK2 behave the same way): - -GTK1: -- if the last selected row is disabled, grey out the disable button -- if the last selected row is enabled, grey out the enable button + M /trunk/epan/dissectors/Makefile.am + M /trunk/epan/dissectors/Makefile.common + M /trunk/epan/dissectors/Makefile.nmake + M /trunk/epan/dissectors/README.X11 + D /trunk/epan/dissectors/ncp2222.py + D /trunk/epan/dissectors/process-x11-fields.pl + D /trunk/epan/dissectors/process-x11-xcb.pl + M /trunk/epan/dissectors/x11-declarations.h + M /trunk/epan/dissectors/x11-extension-errors.h + M /trunk/epan/dissectors/x11-extension-implementation.h + M /trunk/epan/dissectors/x11-glx-render-enum.h + M /trunk/epan/dissectors/x11-register-info.h + M /trunk/tools/Makefile.am + A /trunk/tools/ncp2222.py (from /trunk/epan/dissectors/ncp2222.py:29870) + A /trunk/tools/process-x11-fields.pl (from /trunk/epan/dissectors/process-x11-fields.pl:29870) + A /trunk/tools/process-x11-xcb.pl (from /trunk/epan/dissectors/process-x11-xcb.pl:29870) -GTK2: -- grey out both buttons when no rule is selected -- grey out the enable button when *all* selected rules are enabled -- grey out the disable button when *all* selected rules are disabled -- leave both buttons active if there is a mix of disabled and enabled - rules +Move all of the scripts in epan/dissectors/ to tools/ . +Add a target ("x11-dissector") to build the X11 dissector. +Put the X11-related files (back) in the source distribution. ------------------------------------------------------------------------ -r23427 | sake | 2007-11-10 16:59:19 -0800 (Sat, 10 Nov 2007) | 4 lines +r29872 | morriss | 2009-09-12 19:12:03 -0700 (Sat, 12 Sep 2009) | 1 line Changed paths: - M /trunk/gtk/color_dlg.c - -Open the coloring rule edit dialog when the coloring rule is -double-clicked. - + M /trunk/epan/dissectors/Makefile.nmake +Try to get the paths right ------------------------------------------------------------------------ -r23428 | etxrab | 2007-11-11 05:23:17 -0800 (Sun, 11 Nov 2007) | 3 lines +r29873 | etxrab | 2009-09-13 06:39:09 -0700 (Sun, 13 Sep 2009) | 6 lines Changed paths: - M /trunk/Makefile.am - M /trunk/Makefile.nmake - M /trunk/epan/dissectors/Makefile.common - A /trunk/epan/dissectors/packet-tpncp.c - M /trunk/packaging/nsis/wireshark.nsi - A /trunk/tpncp - A /trunk/tpncp/tpncp.dat + M /trunk/epan/expert.c + M /trunk/epan/expert.h -From Valery Sigalov: -New dissector for TPNCP protocol. -http://bugs.wireshark.org/bugzilla/show_bug.cgi?id=1853 ------------------------------------------------------------------------- -r23429 | ulfl | 2007-11-11 12:36:41 -0800 (Sun, 11 Nov 2007) | 1 line -Changed paths: - D /trunk/packaging/nsis/WinPcap_4_0_1.exe - A /trunk/packaging/nsis/WinPcap_4_0_2.exe - M /trunk/packaging/nsis/wireshark.nsi +Modified extarct from Didier Gautheron: +optimizations patch http://wiki.wireshark.org/Development/Optimization +'patch.29854.diff.gz" -update WinPcap installer to recent 4.0.2 +- ei->protocol is a constant. +- Don't setup expert tap data if there's no tap. ------------------------------------------------------------------------ -r23430 | etxrab | 2007-11-11 23:03:09 -0800 (Sun, 11 Nov 2007) | 1 line +r29874 | gerald | 2009-09-13 08:03:31 -0700 (Sun, 13 Sep 2009) | 1 line Changed paths: - M /trunk/epan/dissectors/packet-tpncp.c + M /trunk/epan/enterprise-numbers + M /trunk/manuf -Remove forgotten debug code. +[Automatic manuf and enterprise-numbers update for 2009-09-13] ------------------------------------------------------------------------ -r23431 | ulfl | 2007-11-11 23:31:38 -0800 (Sun, 11 Nov 2007) | 1 line +r29877 | jmayer | 2009-09-13 08:17:26 -0700 (Sun, 13 Sep 2009) | 1 line Changed paths: - M /trunk/packaging/nsis/Makefile.am - M /trunk/packaging/nsis/Makefile.nmake - M /trunk/packaging/nsis/wireshark.nsi - M /trunk/packaging/portableapps/win32/WiresharkPortable.ini - M /trunk/packaging/portableapps/win32/WiresharkPortable.nsi - M /trunk/packaging/u3/win32/makefile.nmake + M /trunk/epan/CMakeLists.txt -update various other places, where WinPcap version 4.0.1 was used +ncp2222.py has moved ------------------------------------------------------------------------ -r23432 | ulfl | 2007-11-11 23:33:30 -0800 (Sun, 11 Nov 2007) | 1 line +r29878 | etxrab | 2009-09-13 09:03:46 -0700 (Sun, 13 Sep 2009) | 1 line Changed paths: - M /trunk/packaging.vcproj + M /trunk/gtk/expert_comp_table.c -add various files of PortableApps packaging +'function' : different 'const' qualifiers ------------------------------------------------------------------------ -r23433 | ulfl | 2007-11-11 23:34:32 -0800 (Sun, 11 Nov 2007) | 1 line +r29879 | etxrab | 2009-09-13 09:11:11 -0700 (Sun, 13 Sep 2009) | 5 lines Changed paths: - M /trunk/packaging/u3/win32/u3util.c + M /trunk/gtk/gui_utils.c -update various other places, where WinPcap version 4.0.1 was used ------------------------------------------------------------------------- -r23434 | ulfl | 2007-11-11 23:35:21 -0800 (Sun, 11 Nov 2007) | 1 line -Changed paths: - M /trunk/wireshark.sln +From Didier Gautheron: +optimizations patch http://wiki.wireshark.org/Development/Optimization +'patch.29854.diff.gz" -add various files of PortableApps packaging +Speed up sorting. ------------------------------------------------------------------------ -r23435 | gerald | 2007-11-12 09:02:46 -0800 (Mon, 12 Nov 2007) | 4 lines +r29880 | etxrab | 2009-09-13 10:24:51 -0700 (Sun, 13 Sep 2009) | 5 lines Changed paths: - M /trunk/asn1/ansi-tcap/ansi_tcap.cnf - M /trunk/asn1/ansi-tcap/packet-ansi_tcap-template.c - M /trunk/epan/dissectors/packet-ansi_tcap.c - M /trunk/epan/dissectors/packet-ansi_tcap.h + M /trunk/epan/addr_resolv.c -Replace strcpy()+strcat() with g_snprintf(). Make sure a string isn't -NULL before we try to use it. This fixes a crash found during fuzzing -and a possible buffer overrun. +From Didier Gautheron: +optimizations patch http://wiki.wireshark.org/Development/Optimization +'patch.29854.diff.gz" +Clean up addr_resolv.c ------------------------------------------------------------------------ -r23436 | gerald | 2007-11-12 10:44:29 -0800 (Mon, 12 Nov 2007) | 3 lines +r29881 | morriss | 2009-09-13 10:46:10 -0700 (Sun, 13 Sep 2009) | 17 lines Changed paths: - M /trunk/asn1/snmp/packet-snmp-template.c - M /trunk/epan/dissectors/packet-snmp.c - M /trunk/epan/dissectors/packet-snmp.h + M /trunk/capture_sync.c + M /trunk/dumpcap.c -Initialize var_list in dissect_smux(), so that we don't use previously -ep_freed() memory and abort. +Don't use SIGUSR1 to tell dumpcap to exit, use SIGINT: SIGINT is traditionally +used for this purpose and using it also prevents the 2 signals the child gets: + - the user's Ctrl-C (which is sent as a SIGINT to both *shark and its + child dumpcap) + - the signal *shark generates to shut down the child ------------------------------------------------------------------------- -r23437 | gerald | 2007-11-12 11:47:15 -0800 (Mon, 12 Nov 2007) | 3 lines -Changed paths: - M /trunk/tools/fuzz-test.sh +from colliding (and running 2 signal handlers in the child). -Print the pass number periodically as a convenience for running the script -on a large number of trace files. +It might be possible for tshark to not send the signal at all when it gets +SIGINT, but it doesn't do any harm now. ------------------------------------------------------------------------- -r23438 | gerald | 2007-11-12 12:02:24 -0800 (Mon, 12 Nov 2007) | 2 lines -Changed paths: - M /trunk/asn1/h225/h225.cnf - M /trunk/epan/dissectors/packet-h225.c - M /trunk/epan/dissectors/packet-h225.h +Also, do not call g_log() within the signal handler: doing so can cause +aborts (if g_log is being called by the process when the signal comes, the +2nd entrance into g_log is detected as a recursion). -Don't dereference a NULL pointer. +This fixes https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=2767 ------------------------------------------------------------------------ -r23439 | etxrab | 2007-11-12 13:14:53 -0800 (Mon, 12 Nov 2007) | 1 line +r29882 | morriss | 2009-09-13 12:23:07 -0700 (Sun, 13 Sep 2009) | 1 line Changed paths: - M /trunk/diameter/dictionary.xml + M /trunk/epan/uat.h -Add AVP info. +s/g_strdown/g_ascii_strdown ------------------------------------------------------------------------ -r23440 | etxrab | 2007-11-12 22:11:24 -0800 (Mon, 12 Nov 2007) | 1 line +r29883 | morriss | 2009-09-13 12:48:22 -0700 (Sun, 13 Sep 2009) | 1 line Changed paths: - M /trunk/Makefile.nmake - M /trunk/tools/win32-setup.sh + M /trunk/epan/dissectors/Makefile.am + M /trunk/epan/dissectors/Makefile.nmake + M /trunk/plugins/asn1/Makefile.am + M /trunk/plugins/asn1/Makefile.nmake + M /trunk/plugins/docsis/Makefile.am + M /trunk/plugins/docsis/Makefile.nmake + M /trunk/plugins/easy_codec/Makefile.nmake + M /trunk/plugins/ethercat/Makefile.am + M /trunk/plugins/ethercat/Makefile.nmake + M /trunk/plugins/gryphon/Makefile.am + M /trunk/plugins/gryphon/Makefile.nmake + M /trunk/plugins/irda/Makefile.am + M /trunk/plugins/irda/Makefile.nmake + M /trunk/plugins/m2m/Makefile.am + M /trunk/plugins/m2m/Makefile.nmake + M /trunk/plugins/mate/Makefile.am + M /trunk/plugins/mate/Makefile.nmake + M /trunk/plugins/opcua/Makefile.am + M /trunk/plugins/opcua/Makefile.nmake + M /trunk/plugins/profinet/Makefile.am + M /trunk/plugins/profinet/Makefile.nmake + M /trunk/plugins/sercosiii/Makefile.am + M /trunk/plugins/sercosiii/Makefile.nmake + M /trunk/plugins/stats_tree/Makefile.am + M /trunk/plugins/stats_tree/Makefile.nmake + M /trunk/plugins/tpg/Makefile.am + M /trunk/plugins/tpg/Makefile.nmake + M /trunk/plugins/unistim/Makefile.am + M /trunk/plugins/unistim/Makefile.nmake + M /trunk/plugins/wimax/Makefile.am + M /trunk/plugins/wimax/Makefile.nmake + M /trunk/plugins/wimaxasncp/Makefile.am + M /trunk/plugins/wimaxasncp/Makefile.nmake -Use glib-2.14.3 +Run checkapi on the dissector header files ------------------------------------------------------------------------ -r23441 | stig | 2007-11-13 02:26:30 -0800 (Tue, 13 Nov 2007) | 2 lines +r29884 | morriss | 2009-09-13 16:03:38 -0700 (Sun, 13 Sep 2009) | 7 lines Changed paths: - M /trunk/asn1/ros/packet-ros-template.c - M /trunk/epan/dissectors/packet-ros.c - M /trunk/epan/dissectors/packet-ros.h + M /trunk/epan/dissectors/Makefile.common + A /trunk/epan/dissectors/packet-classicstun.c (from /trunk/epan/dissectors/packet-stun.c:29883) + M /trunk/epan/dissectors/packet-rtcp.c + M /trunk/epan/dissectors/packet-rtp.c + M /trunk/epan/dissectors/packet-sip.c + R /trunk/epan/dissectors/packet-stun.c (from /trunk/epan/dissectors/packet-stun2.c:29883) + D /trunk/epan/dissectors/packet-stun2.c + M /trunk/epan/dissectors/packet-tftp.c + +From Stephane Bryant via https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=2815 +but (since the patch no longer applied cleanly) essentially manually +re-implemented by me: -Mark some generated items in ROS. +Rename "stun" to "classic stun" and "stun2" to "stun", to follow the usage +defined in draft-ietf-behave-rfc3489bis-18 section 2. ------------------------------------------------------------------------ -r23442 | etxrab | 2007-11-13 13:59:53 -0800 (Tue, 13 Nov 2007) | 13 lines +r29885 | morriss | 2009-09-13 16:10:11 -0700 (Sun, 13 Sep 2009) | 4 lines Changed paths: - M /trunk/asn1/tcap/tcap.asn - M /trunk/asn1/tcap/tcap.cnf - M /trunk/epan/dissectors/packet-ber.c - M /trunk/epan/dissectors/packet-tcap.c - -From Florent DROUIN: -Since the use of the function 'dissect_ber_tagged_type' for DialoguePortion, -the file tcap.cnf must be updated to remove the decoding of the tag and length. -This decoding is now done in the new function 'dissect_ber_tagged_type'. + M /trunk/epan/dissectors/packet-tcp.c -The file tcap.cnf has been updated to take into account this change. -But this leads to a change in tcap.asn too, for the definition of the -ExternalPDU. -I think this part of the ASN1 file is specific to Wireshark and can be -modified. +From Didier Gautheron via https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=3417 -In the meantime, I did update the DEBUG part for packet_ber.c for the function -(dissect_ber_tagged_type) ------------------------------------------------------------------------- -r23443 | etxrab | 2007-11-13 14:00:46 -0800 (Tue, 13 Nov 2007) | 1 line -Changed paths: - M /trunk/diameter/dictionary.xml +Don't scale the window if the SYN flag is set. -Correct assorted typos and copy-past errors. ------------------------------------------------------------------------ -r23444 | etxrab | 2007-11-13 14:05:43 -0800 (Tue, 13 Nov 2007) | 9 lines +r29886 | gerald | 2009-09-13 17:38:54 -0700 (Sun, 13 Sep 2009) | 2 lines Changed paths: - M /trunk/epan/dissectors/packet-linx.c - -From Dejan Bucar: -Updated dissector for LINX protocols + M /trunk/packaging/macosx/dmg_set_style.scpt + M /trunk/packaging/macosx/osx-dmg.sh + M /trunk/packaging/macosx/root.ds_store + M /trunk/packaging/macosx/util.ds_store -* Linx Ethernet Connection Manager protocol is updated from version 2 to -version 3. -* Linx RLNH protocol has been updated from version 1 to version 2. +Tweak the Finder windows a bit. -The updated dissector is backwards-compatible allowing correct dissection of -all versions. ------------------------------------------------------------------------ -r23445 | sfisher | 2007-11-13 22:39:58 -0800 (Tue, 13 Nov 2007) | 6 lines +r29887 | morriss | 2009-09-13 18:36:26 -0700 (Sun, 13 Sep 2009) | 14 lines Changed paths: - M /trunk/gtk/menu.c - - -From didier: + M /trunk/AUTHORS + M /trunk/epan/dissectors/Makefile.common + A /trunk/epan/dissectors/packet-collectd.c -Fix for bug #1876: Resizing columns changes the currently-selected packet +From Bruno and Florian Forster via https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=3170 +This patch adds support to Wireshark for dissecting UDP packets used by +collectd's network plugin in order to transmit data from ones host to another +host (e.g. centralized storage of statistics while data is collectd on +individual systems) ------------------------------------------------------------------------- -r23446 | stig | 2007-11-14 01:37:44 -0800 (Wed, 14 Nov 2007) | 4 lines -Changed paths: - M /trunk/gtk/summary_dlg.c +The current dissector understands the part types supported by collectd-4.5 +series and gracefully processes future part types (flagging them as unknown). -From Shiang-Ming Huang: -Removed unnecessary parentheses that make the average packets size -calculated as an integer instead of a float. +In regard to protocol errors or bad packets checks are based on the various +length fields used, parts are marked with warning when length is unexpected; +marked with error when length breaks minimal rules. ------------------------------------------------------------------------ -r23447 | stig | 2007-11-14 02:15:20 -0800 (Wed, 14 Nov 2007) | 2 lines +r29888 | etxrab | 2009-09-13 22:59:38 -0700 (Sun, 13 Sep 2009) | 1 line Changed paths: - M /trunk/gtk/summary_dlg.c - -Added some parentheses to clarify the gint64 cast. + M /trunk/epan/dissectors/packet-collectd.c +Add casts to make it compile on Windows. ------------------------------------------------------------------------ -r23448 | sfisher | 2007-11-14 09:39:21 -0800 (Wed, 14 Nov 2007) | 8 lines +r29889 | etxrab | 2009-09-13 23:00:53 -0700 (Sun, 13 Sep 2009) | 5 lines Changed paths: - M /trunk/tpncp/tpncp.dat - - -From Valery Sigalov via bug #1853: Fix the following console error when -starting Wireshark: - -Duplicate field detected in call to proto_register_field_array: channel_id is -already registered + M /trunk/epan/dissectors/packet-http.c +From Didier Gautheron: +optimizations patch http://wiki.wireshark.org/Development/Optimization +'patch.29854.diff.gz" +Use "g_realloc". ------------------------------------------------------------------------ -r23449 | gerald | 2007-11-14 11:28:29 -0800 (Wed, 14 Nov 2007) | 2 lines +r29890 | jmayer | 2009-09-13 23:48:45 -0700 (Sun, 13 Sep 2009) | 1 line Changed paths: - M /trunk/docbook/release-notes.xml - M /trunk/epan/dissectors/packet-megaco.c - -Keep the MEGACO dissector from looping on a malformed events descriptor. + M /trunk/epan/CMakeLists.txt +Sync to autofoo ------------------------------------------------------------------------ -r23450 | gal | 2007-11-14 12:57:55 -0800 (Wed, 14 Nov 2007) | 5 lines +r29891 | jmayer | 2009-09-13 23:51:22 -0700 (Sun, 13 Sep 2009) | 4 lines Changed paths: - M /trunk/asn1/rtse/packet-rtse-template.c - M /trunk/asn1/rtse/rtse.asn - M /trunk/asn1/rtse/rtse.cnf - M /trunk/epan/dissectors/packet-ber.c - M /trunk/epan/dissectors/packet-rtse.c - M /trunk/epan/dissectors/packet-rtse.h - -Changed to use the the packet-ber EXTERNAL decoding (into the ASN1 context). -Uses the ber_callback mechanism to call the rtse oid callbacks, rather than the default ber oid callback list. -A couple of fixes to packet-ber.c to mark [in]direct references as present and call the ber_callback if it has been specified. - + M /trunk/CMakeLists.txt ------------------------------------------------------------------------- -r23451 | etxrab | 2007-11-14 22:03:53 -0800 (Wed, 14 Nov 2007) | 1 line -Changed paths: - M /trunk/diameter/dictionary.xml +Not yet working: +Sync with autofoo: Check for accepted compiler flags. Use + identical flags. -Fix "Diameter Dictionary: No Vendor: 3GPPDiameter Dictionary: No Vendor: 3GPP". ------------------------------------------------------------------------ -r23452 | sahlberg | 2007-11-15 01:41:32 -0800 (Thu, 15 Nov 2007) | 8 lines +r29892 | martinm | 2009-09-14 03:26:53 -0700 (Mon, 14 Sep 2009) | 2 lines Changed paths: - M /trunk/asn1/mms/mms.cnf - -branch_taken that is returned by dissect_ber_choice() is the index of -of the branch and not the tag value so one cant use it with -val_to_str() -(well one can in this instance since by luck the tag values match the -indices) - + M /trunk/epan/dissectors/packet-catapult-dct2000.c +Show UEId in info column for CCCH frames. ------------------------------------------------------------------------ -r23453 | sahlberg | 2007-11-15 01:42:21 -0800 (Thu, 15 Nov 2007) | 3 lines +r29893 | morriss | 2009-09-14 04:26:03 -0700 (Mon, 14 Sep 2009) | 1 line Changed paths: - M /trunk/epan/dissectors/packet-mms.c - M /trunk/epan/dissectors/packet-mms.h - -updated mms dissector - + M /trunk/epan/dissectors/packet-collectd.c +Change proto_tree_add_protocol_format() to proto_tree_add_text() since all that is being added is text. ------------------------------------------------------------------------ -r23454 | sahlberg | 2007-11-15 01:49:55 -0800 (Thu, 15 Nov 2007) | 4 lines +r29894 | morriss | 2009-09-14 06:11:26 -0700 (Mon, 14 Sep 2009) | 1 line Changed paths: - M /trunk/asn1/snmp/snmp.cnf - -dissect_ber_choice() returns the index of the choice, not the tag of the -choice - + M /trunk/epan/dissectors/packet-collectd.c +Put the parenthesis in the right place ------------------------------------------------------------------------ -r23455 | sahlberg | 2007-11-15 01:50:36 -0800 (Thu, 15 Nov 2007) | 3 lines +r29895 | wmeier | 2009-09-14 07:03:32 -0700 (Mon, 14 Sep 2009) | 6 lines Changed paths: - M /trunk/epan/dissectors/packet-snmp.c - -updated snmp dissector + M /trunk/epan/dissectors/packet-stun.c +Remove unneeded #includes (stdio.h & etc); +Remove a bunch calls to of check_cols(); +Use tfs_set_notset from tfs.c instead of a locally defined tfs struct; +Use consistent indentation; +Adjust spacing on some lines and reformat a few long lines. ------------------------------------------------------------------------ -r23456 | sahlberg | 2007-11-15 02:10:22 -0800 (Thu, 15 Nov 2007) | 4 lines +r29896 | wmeier | 2009-09-14 07:59:08 -0700 (Mon, 14 Sep 2009) | 6 lines Changed paths: - M /trunk/asn1/x411/x411.cnf - -dissect_ber_choice returns a gint that is the index of the choice taken, -not the tag value + M /trunk/epan/dissectors/packet-classicstun.c +Remove unneeded #includes (stdio.h & friends); +Remove a call to checkcol(); +Use tfs_set_notset instead of a local true_false_string defintion; +Use consistent indentation; +Adjust some spacing. ------------------------------------------------------------------------ -r23457 | sahlberg | 2007-11-15 02:11:09 -0800 (Thu, 15 Nov 2007) | 3 lines +r29897 | wmeier | 2009-09-14 08:28:09 -0700 (Mon, 14 Sep 2009) | 2 lines Changed paths: - M /trunk/epan/dissectors/packet-x411.c - M /trunk/epan/dissectors/packet-x411.h - -new x411 dissector + M /trunk/doc/README.developer +Update: Remove references to the use of check_col() since no longer required. ------------------------------------------------------------------------ -r23458 | sahlberg | 2007-11-15 02:32:10 -0800 (Thu, 15 Nov 2007) | 4 lines +r29898 | wmeier | 2009-09-14 08:34:05 -0700 (Mon, 14 Sep 2009) | 2 lines Changed paths: - M /trunk/asn1/ldap/ldap.cnf - -dissect_ber_choice() returns the index of the taken arm not the tag -value + M /trunk/docbook/wsdg_src/WSDG_chapter_dissection.xml +Remove usage of check_col() since no longer required. ------------------------------------------------------------------------ -r23459 | sahlberg | 2007-11-15 02:32:45 -0800 (Thu, 15 Nov 2007) | 3 lines +r29899 | wmeier | 2009-09-14 09:04:54 -0700 (Mon, 14 Sep 2009) | 2 lines Changed paths: - M /trunk/epan/dissectors/packet-ldap.c - M /trunk/epan/dissectors/packet-ldap.h - -new ldap dissector + M /trunk/epan/column-utils.c +(Trivial) Fix a typo in a comment ------------------------------------------------------------------------ -r23460 | sahlberg | 2007-11-15 02:38:43 -0800 (Thu, 15 Nov 2007) | 6 lines +r29900 | etxrab | 2009-09-14 09:06:31 -0700 (Mon, 14 Sep 2009) | 1 line Changed paths: - M /trunk/asn1/t125/packet-t125-template.c - M /trunk/asn1/t125/t125.cnf - -only dissect it as t125 if it looks like t125 - -dissect_ber_choice() returns the index of the choice taken not the -tag value - + M /trunk/gtk/simple_dialog.c +Change gtk_pixmap_new() to gtk_image_new_from_pixmap(). ------------------------------------------------------------------------ -r23461 | sahlberg | 2007-11-15 02:39:16 -0800 (Thu, 15 Nov 2007) | 3 lines +r29901 | wmeier | 2009-09-14 09:38:06 -0700 (Mon, 14 Sep 2009) | 2 lines Changed paths: - M /trunk/epan/dissectors/packet-t125.c - M /trunk/epan/dissectors/packet-t125.h - -new t125 dissector + M /trunk/epan/dissectors/dcerpc/idl2wrs.c +(Trivial) Fix a typo in a comment. ------------------------------------------------------------------------ -r23462 | martinm | 2007-11-15 10:37:50 -0800 (Thu, 15 Nov 2007) | 2 lines +r29902 | morriss | 2009-09-14 10:36:15 -0700 (Mon, 14 Sep 2009) | 1 line Changed paths: - M /trunk/epan/dissectors/packet-lapd.c - -Add a generated lapd.direction field/filter. + M /trunk/epan/dissectors/packet-http.c +Revert 29889 to stop the fuzz failures. ------------------------------------------------------------------------ -r23463 | gerald | 2007-11-15 11:38:04 -0800 (Thu, 15 Nov 2007) | 2 lines +r29903 | gerald | 2009-09-14 11:00:01 -0700 (Mon, 14 Sep 2009) | 2 lines Changed paths: - M /trunk/docbook/release-notes.xml - M /trunk/epan/dissectors/packet-dcp-etsi.c + M /trunk/packaging/macosx/dmg_set_style.scpt + M /trunk/packaging/macosx/osx-dmg.sh + M /trunk/packaging/macosx/root.ds_store + M /trunk/packaging/macosx/util.ds_store -Don't try to reassemble a huge number of fragments. +More Finder tweaks. ------------------------------------------------------------------------ -r23464 | sake | 2007-11-15 11:46:25 -0800 (Thu, 15 Nov 2007) | 3 lines +r29906 | jake | 2009-09-14 14:24:24 -0700 (Mon, 14 Sep 2009) | 2 lines Changed paths: - M /trunk/wiretap/netscreen.c - M /trunk/wiretap/netscreen.h - -Added correct svn propset settings to wiretap/netscreen.[ch] - + M /trunk/epan/dissectors/packet-dtls.c + M /trunk/epan/dissectors/packet-ssl-utils.c + M /trunk/epan/dissectors/packet-ssl-utils.h + M /trunk/epan/dissectors/packet-ssl.c +Fix for bug 4008: +Crash on TLSv1.2 packets, caused by ssl_short_name array overrun. ------------------------------------------------------------------------ |