diff options
| author | Guy Harris <guy@alum.mit.edu> | 2016-12-02 01:29:26 -0800 |
|---|---|---|
| committer | Guy Harris <guy@alum.mit.edu> | 2016-12-02 10:10:07 +0000 |
| commit | 6e0278989c29a401f22485fd295bcc2486160241 (patch) | |
| tree | 676430bdc705a7885f554bdba1db75a8604fc982 /acinclude.m4 | |
| parent | 8d927a98fdac92b562cfd5c769f7ae7bed0ace2d (diff) | |
| download | wireshark-6e0278989c29a401f22485fd295bcc2486160241.tar.gz | |
Do *NOT* strip newlines from the standard input of sed.
There is *NO* guarantee that sed will do anything useful with input that
doesn't have a newline and, in fact, the default sed in Solaris 11
doesn't produce *any* output if you hand it input with no newline.
Furthermore, doing xxx=`yyy` will, if the output of yyy has newlines at
the end, strip them; to quote section 2.6.3 "Command Substitution" of
the Single UNIX Specification:
The shell shall expand the command substitution by executing
command in a subshell environment (see Shell Execution
Environment) and replacing the command substitution (the text of
command plus the enclosing "$()" or backquotes) with the
standard output of the command, removing sequences of one or
more <newline> characters at the end of the substitution.
so there's no need to strip the newline.
Change-Id: Ia710f67a42739c1e218eb9fec53a54bde6e010da
Reviewed-on: https://code.wireshark.org/review/19016
Petri-Dish: Guy Harris <guy@alum.mit.edu>
Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org>
Reviewed-by: Guy Harris <guy@alum.mit.edu>
Diffstat (limited to 'acinclude.m4')
| -rw-r--r-- | acinclude.m4 | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/acinclude.m4 b/acinclude.m4 index 38cc9f2713..040d774454 100644 --- a/acinclude.m4 +++ b/acinclude.m4 @@ -1605,7 +1605,7 @@ fi AC_DEFUN([AC_WIRESHARK_GCC_SYSTEM_INCLUDE], [ if test "x$GCC" = "xyes" -o "x$CC" = "xclang" ; then - $1=`printf %s " $$1" \ + $1=`echo " $$1" \ | sed -e 's/ *-I *\// -isystem\//g' -e 's/^ *//'` fi ]) |