summaryrefslogtreecommitdiff
path: root/epan/addr_resolv.h
diff options
context:
space:
mode:
authorGuy Harris <guy@alum.mit.edu>2016-01-18 23:22:30 -0800
committerGuy Harris <guy@alum.mit.edu>2016-01-19 07:23:53 +0000
commit72a9968fabd30865bd972f13613f10b33ecc0272 (patch)
treeefa4f819a78de6da25f06f75e4078e586a0a6048 /epan/addr_resolv.h
parent5335f1d065b1e30619ed7c2ba4a68b9df48ad157 (diff)
downloadwireshark-72a9968fabd30865bd972f13613f10b33ecc0272.tar.gz
Don't use IP address strings as "names" for MAC addresses.
Have a flag for addresses indicating whether the address is resolved to a name or whether its "name" is just a printable version of the address. If the name corresponding to an IP address isn't really a name, don't assign it to a MAC address. Clean up some code a bit (have a fill_dummy_ip6() corresponding to fill_dummy_ip4()). Bug: 10212 Change-Id: I9d0ffa2706be17842f832c64cea7acc5c1dc6536 Reviewed-on: https://code.wireshark.org/review/13412 Reviewed-by: Guy Harris <guy@alum.mit.edu>
Diffstat (limited to 'epan/addr_resolv.h')
-rw-r--r--epan/addr_resolv.h9
1 files changed, 5 insertions, 4 deletions
diff --git a/epan/addr_resolv.h b/epan/addr_resolv.h
index 45cd190972..a316c18fb6 100644
--- a/epan/addr_resolv.h
+++ b/epan/addr_resolv.h
@@ -81,11 +81,12 @@ typedef struct serv_port {
} serv_port_t;
/*
- *
+ * Flags for various IPv4/IPv6 hash table entries.
*/
-#define DUMMY_ADDRESS_ENTRY (1U<<0)
-#define TRIED_RESOLVE_ADDRESS (1U<<1)
-#define RESOLVED_ADDRESS_USED (1U<<2)
+#define DUMMY_ADDRESS_ENTRY (1U<<0) /* XXX - what does this bit *really* mean? */
+#define TRIED_RESOLVE_ADDRESS (1U<<1) /* XXX - what does this bit *really* mean? */
+#define RESOLVED_ADDRESS_USED (1U<<2) /* a get_hostname* call returned the host name */
+#define NAME_RESOLVED (1U<<3) /* the name field contains a host name, not a printable address */
#define DUMMY_AND_RESOLVE_FLGS (DUMMY_ADDRESS_ENTRY | TRIED_RESOLVE_ADDRESS)
#define USED_AND_RESOLVED_MASK (DUMMY_ADDRESS_ENTRY | RESOLVED_ADDRESS_USED)