diff options
| author | Niels de Vos <ndevos@redhat.com> | 2014-04-11 10:47:19 +0200 |
|---|---|---|
| committer | Alexis La Goutte <alexis.lagoutte@gmail.com> | 2014-04-11 13:08:33 +0000 |
| commit | 48c05a4f8e61998478e8be44cb4819989b1bfd99 (patch) | |
| tree | 42fc649b3059274c61c23b746606d7548fcffef0 /epan/dissectors/packet-glusterfs.c | |
| parent | 3f81af22e0116a2f83c0298de7874959b3967da2 (diff) | |
| download | wireshark-48c05a4f8e61998478e8be44cb4819989b1bfd99.tar.gz | |
GlusterFS: correctly dissect flags passed with OPEN, CREATE, etc.
RPC/XDR is in big-endian, just like dissect_rpc_uint64() and friends.
Change-Id: I0843e280bd2ffc2c4bd9a5273a7343a17d81ad6a
Reported-by: Xavier Hernandez <xhernandez@datalab.es>
Signed-off-by: Niels de Vos <ndevos@redhat.com>
Reviewed-on: https://code.wireshark.org/review/1066
Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com>
Diffstat (limited to 'epan/dissectors/packet-glusterfs.c')
| -rw-r--r-- | epan/dissectors/packet-glusterfs.c | 8 |
1 files changed, 4 insertions, 4 deletions
diff --git a/epan/dissectors/packet-glusterfs.c b/epan/dissectors/packet-glusterfs.c index 746706e21a..6cb527ac28 100644 --- a/epan/dissectors/packet-glusterfs.c +++ b/epan/dissectors/packet-glusterfs.c @@ -246,7 +246,7 @@ glusterfs_rpc_dissect_mode(proto_tree *tree, tvbuff_t *tvb, int hfindex, if (tree) proto_tree_add_bitmask(tree, tvb, offset, hfindex, - ett_glusterfs_mode, mode_bits, ENC_LITTLE_ENDIAN); + ett_glusterfs_mode, mode_bits, ENC_BIG_ENDIAN); offset += 4; return offset; @@ -413,11 +413,11 @@ glusterfs_rpc_dissect_flags(proto_tree *tree, tvbuff_t *tvb, int offset) }; if (tree) { - flag_tree = proto_tree_add_bitmask(tree, tvb, offset, hf_glusterfs_flags, ett_glusterfs_flags, flag_bits, ENC_LITTLE_ENDIAN); + flag_tree = proto_tree_add_bitmask(tree, tvb, offset, hf_glusterfs_flags, ett_glusterfs_flags, flag_bits, ENC_BIG_ENDIAN); /* rdonly is TRUE only when no flags are set */ rdonly = (tvb_get_ntohl(tvb, offset) == 0); - proto_tree_add_item(flag_tree, hf_glusterfs_flags_rdonly, tvb, offset, 4, ENC_LITTLE_ENDIAN); + proto_tree_add_item(flag_tree, hf_glusterfs_flags_rdonly, tvb, offset, 4, ENC_BIG_ENDIAN); if (rdonly) { rdonly_hf = proto_registrar_get_nth(hf_glusterfs_flags_rdonly); proto_item_append_text(flag_tree, ", %s", rdonly_hf->name); @@ -470,7 +470,7 @@ glusterfs_rpc_dissect_statfs(proto_tree *tree, tvbuff_t *tvb, int offset) if (tree) proto_tree_add_bitmask(tree, tvb, offset + 4, hf_glusterfs_mnt_flags, ett_glusterfs_mnt_flags, - flag_bits, ENC_LITTLE_ENDIAN); + flag_bits, ENC_BIG_ENDIAN); offset += 8; offset = dissect_rpc_uint64(tvb, tree, hf_glusterfs_namemax, offset); |