diff options
| author | Guy Harris <guy@alum.mit.edu> | 2014-10-19 23:14:50 -0700 |
|---|---|---|
| committer | Guy Harris <guy@alum.mit.edu> | 2014-10-20 06:15:19 +0000 |
| commit | 80e6f6251e96dd7b8a9ab0fdbf63b03a73ef6692 (patch) | |
| tree | 92d519b9b19cccba0d083a6ad20152352daa5924 /epan/dissectors/packet-multipart.c | |
| parent | 0b9eb9f4b71b6632cfb4b87bcdefdfa75eaf2dd0 (diff) | |
| download | wireshark-80e6f6251e96dd7b8a9ab0fdbf63b03a73ef6692.tar.gz | |
Get rid of calls to ctype.h functions.
They don't handle values outside the range -1 to 127, and their behavior
is locale-dependent. Use g_ascii_isXXX() and g_ascii_toXXX() instead of
isXXX() and toXXX().
If you're checking for printable ASCII, don't use isascii() and don't
use iscntrl(), use g_ascii_isprint(). If you're checking for graphical
ASCII, i.e. printable ASCII except for a space, use g_ascii_isgraph().
Use ws_xton() to convert a hex digit character to the corresponding
numeric value.
Change-Id: Id3039bc586fbf66d8736c2df248c790c0d7a2330
Reviewed-on: https://code.wireshark.org/review/4851
Reviewed-by: Guy Harris <guy@alum.mit.edu>
Diffstat (limited to 'epan/dissectors/packet-multipart.c')
| -rw-r--r-- | epan/dissectors/packet-multipart.c | 5 |
1 files changed, 2 insertions, 3 deletions
diff --git a/epan/dissectors/packet-multipart.c b/epan/dissectors/packet-multipart.c index d664215dda..112a8e59c6 100644 --- a/epan/dissectors/packet-multipart.c +++ b/epan/dissectors/packet-multipart.c @@ -57,7 +57,6 @@ #include "config.h" #include <string.h> -#include <ctype.h> #include <glib.h> @@ -323,7 +322,7 @@ static char *find_parameter(char *parameters, const char *key, int *retlen) while (*p) { - while ((*p) && isspace((guchar)*p)) + while ((*p) && g_ascii_isspace(*p)) p++; /* Skip white space */ if (g_ascii_strncasecmp(p, key, keylen) == 0) @@ -363,7 +362,7 @@ static char *find_parameter(char *parameters, const char *key, int *retlen) */ p = start; while (*p) { - if (*p == ';' || isspace((guchar)*p)) + if (*p == ';' || g_ascii_isspace(*p)) break; p++; len++; |