diff options
| author | Alexis La Goutte <alexis.lagoutte@gmail.com> | 2017-03-18 15:10:33 +0100 |
|---|---|---|
| committer | Michael Mann <mmann78@netscape.net> | 2017-03-18 23:22:25 +0000 |
| commit | a16771f34b60cc9862fae885d681d2eeb4530d4d (patch) | |
| tree | 9994fae8942f5b1bb5adf9968e79f682efc06e5d /epan/dissectors | |
| parent | a8e7e3cc816b1cbec29f29113eb469ab9a8aa19d (diff) | |
| download | wireshark-a16771f34b60cc9862fae885d681d2eeb4530d4d.tar.gz | |
umts_fp: Fix Dereference of null pointer found by Clang analyzer
Access to field 'paging_indications' results in a dereference of a null pointer (loaded from variable 'umts_fp_conversation_info')
Change-Id: Iacddb9b2e9b49f50178e82f48273757885331c2f
Reviewed-on: https://code.wireshark.org/review/20605
Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com>
Petri-Dish: Alexis La Goutte <alexis.lagoutte@gmail.com>
Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org>
Reviewed-by: Michael Mann <mmann78@netscape.net>
Diffstat (limited to 'epan/dissectors')
| -rw-r--r-- | epan/dissectors/packet-umts_fp.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/epan/dissectors/packet-umts_fp.c b/epan/dissectors/packet-umts_fp.c index d869525a4d..2540694ff4 100644 --- a/epan/dissectors/packet-umts_fp.c +++ b/epan/dissectors/packet-umts_fp.c @@ -4417,7 +4417,7 @@ heur_dissect_fp_pch(tvbuff_t *tvb, packet_info *pinfo, proto_tree *tree, void *d set_both_sides_umts_fp_conv_data(pinfo, umts_fp_conversation_info); pi_length_found = TRUE; } - else if (tfi == 0x01 && !tb_size_found && pi_present) { + else if (tfi == 0x01 && !tb_size_found && pi_length_found) { /* TB present and PI bitmap length is known. Can calculate TB length.*/ pi_byte_length = (umts_fp_conversation_info->paging_indications + 7) / 8; if (p_conv == NULL) { |