summaryrefslogtreecommitdiff
path: root/epan/osi-utils.c
diff options
context:
space:
mode:
authorGuy Harris <guy@alum.mit.edu>2014-03-04 18:32:00 -0800
committerGuy Harris <guy@alum.mit.edu>2014-03-05 02:33:20 +0000
commit8881f3f61a793be6158eb9d1b9f4114edc5b957c (patch)
treee7bc6920a5a73b77996306b0e7e85c52c018ce9f /epan/osi-utils.c
parentb2689ab4e044db15eb80b52a07c3f2d0c4fa59a6 (diff)
downloadwireshark-8881f3f61a793be6158eb9d1b9f4114edc5b957c.tar.gz
Don't truncate the options field.
Create a placeholder protocol tree item under which to put the options, do the analysis of fields from the fixed-length portion of the TCP header (such as sequence numbers), and then do a straightforward dissection of the options, throwing an exception if we run past the end of the options field. This is a bit simpler, and doesn't add confusing notes about truncation of the options. XXX - we're currently not including selective acknowledgments in any of the SEQ/ACK analysis; should we? That means, of course, that we have to dissect the options before doing that analysis, and if the options were cut short by slicing, you lose.... Change-Id: I425a6c83f26512b802267f76739cbf40121b3040 Reviewed-on: https://code.wireshark.org/review/511 Reviewed-by: Guy Harris <guy@alum.mit.edu>
Diffstat (limited to 'epan/osi-utils.c')
0 files changed, 0 insertions, 0 deletions