diff options
| author | Michael Mann <mmann78@netscape.net> | 2016-12-22 15:12:27 -0500 |
|---|---|---|
| committer | Michael Mann <mmann78@netscape.net> | 2017-01-07 00:44:10 +0000 |
| commit | 6a6d7ea34f43515dfe3f52aa96b943c272c925a7 (patch) | |
| tree | dbf89a2226861fa855cc04d80607c56f7268e51b /epan/prefs.h | |
| parent | 29a7fce2720288c86e474f68880a0e61e517027b (diff) | |
| download | wireshark-6a6d7ea34f43515dfe3f52aa96b943c272c925a7.tar.gz | |
Convert range API to always use wmem memory.
This is mostly to address memory leaks in range preferences (the biggest
user of range functionality) on shutdown.
Now range preferences must use epan scoped memory when referencing
internal preference structures to keep consistency.
Change-Id: Idc644f59b5b42fa1d46891542b53ff13ea754157
Reviewed-on: https://code.wireshark.org/review/19387
Petri-Dish: Michael Mann <mmann78@netscape.net>
Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org>
Reviewed-by: Peter Wu <peter@lekensteyn.nl>
Reviewed-by: Michael Mann <mmann78@netscape.net>
Diffstat (limited to 'epan/prefs.h')
| -rw-r--r-- | epan/prefs.h | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/epan/prefs.h b/epan/prefs.h index 93094c048c..d2b193a243 100644 --- a/epan/prefs.h +++ b/epan/prefs.h @@ -641,7 +641,7 @@ prefs_set_pref_e prefs_set_preference_obsolete(pref_t *pref); WS_DLL_PUBLIC guint prefs_get_uint_value(const char *module_name, const char* pref_name); /* - * Get the current range_copy()ed range preference value (so it needs to be freed). This allows the + * Get the current range preference value (maintained by pref, so it doesn't need to be freed). This allows the * preference structure to remain hidden from those that doesn't really need it. */ WS_DLL_PUBLIC range_t* prefs_get_range_value(const char *module_name, const char* pref_name); |