diff options
| author | Michael Tüxen <tuexen@wireshark.org> | 2014-10-21 22:26:15 +0200 |
|---|---|---|
| committer | Michael Tüxen <tuexen@wireshark.org> | 2014-10-21 20:29:51 +0000 |
| commit | 24f0888b3102d9f5a772c6df370f6a5a9188de62 (patch) | |
| tree | fe85cfa0a5ecce13b21b444545bccaa34c7b3639 /epan | |
| parent | 4664ac6e200a3e2b2a056abf5b790720d105b1b6 (diff) | |
| download | wireshark-24f0888b3102d9f5a772c6df370f6a5a9188de62.tar.gz | |
Fix the condition for an expert info
The condition triggering an expert info if the reliability
parameter is non-zero, but a reliable data channel is
negotiated was wrong. Now the type field is considered
correctly.
While there, update the reference.
Change-Id: I1f2f78861d6a44c5334fd44e2038bbfdc52fa919
Reviewed-on: https://code.wireshark.org/review/4900
Reviewed-by: Michael Tüxen <tuexen@wireshark.org>
Diffstat (limited to 'epan')
| -rw-r--r-- | epan/dissectors/packet-rtcdc.c | 6 |
1 files changed, 3 insertions, 3 deletions
diff --git a/epan/dissectors/packet-rtcdc.c b/epan/dissectors/packet-rtcdc.c index d2307752f9..e1776fc52a 100644 --- a/epan/dissectors/packet-rtcdc.c +++ b/epan/dissectors/packet-rtcdc.c @@ -3,8 +3,8 @@ * Routines for the RTCWeb Data Channel Protocol dissection * as specified in * http://tools.ietf.org/html/draft-jesup-rtcweb-data-protocol-03 - * and the upcoming version specified in - * http://tools.ietf.org/html/draft-ietf-rtcweb-data-protocol-00 + * and specified in + * http://tools.ietf.org/html/draft-ietf-rtcweb-data-protocol-08 * We might want to remove the support of * http://tools.ietf.org/html/draft-jesup-rtcweb-data-protocol-03 * in the future, but I'll leave it in for now. @@ -220,7 +220,7 @@ dissect_new_open_request_message(tvbuff_t *tvb, packet_info *pinfo, proto_tree * proto_tree_add_item(rtcdc_tree, hf_new_priority, tvb, NEW_PRIORITY_OFFSET, NEW_PRIORITY_LENGTH, ENC_BIG_ENDIAN); proto_tree_add_item(rtcdc_tree, hf_new_reliability, tvb, NEW_RELIABILITY_OFFSET, NEW_RELIABILITY_LENGTH, ENC_BIG_ENDIAN); reliability = tvb_get_ntohl(tvb, NEW_RELIABILITY_OFFSET); - if ((reliability > 0) && ((channel_type & 0x80) == 0)) { + if ((reliability > 0) && ((channel_type & 0x7f) == 0x00)) { expert_add_info(pinfo, rtcdc_item, &ei_rtcdc_new_reliability_non_zero); } proto_tree_add_item(rtcdc_tree, hf_new_label_length, tvb, NEW_LABEL_LENGTH_OFFSET, NEW_LABEL_LENGTH_LENGTH, ENC_BIG_ENDIAN); |