More checks for localtime() and gmtime() returning NULL.

And some comments in the case where we're converting the result of
time() - if your machine's idea of time predates January 1, 1970,
00:00:00 UTC, it'll crash on Windows, but that's not a case where a
*file* can cause the problem due either to a bad file time stamp or bad
time stamps in the file.

Change-Id: I837a438e4b875dd8c4f3ec2137df7a16ee4e9498
Reviewed-on: https://code.wireshark.org/review/18369
Reviewed-by: Guy Harris <guy@alum.mit.edu>

1 files changed, 4 insertions, 0 deletions

diff --git a/extcap.c b/extcap.c
index 3672902cdd..b900d084f5 100644
--- a/extcap.c
+++ b/extcap.c
@@ -1127,6 +1127,10 @@ gboolean extcap_create_pipe(char ** fifo)
     SECURITY_ATTRIBUTES security;
     /* create pipename */
     current_time = time(NULL);
+    /*
+     * XXX - we trust Windows not to return a time before the Epoch here,
+     * so we won't get a null pointer back from localtime().
+     */
     strftime(timestr, sizeof(timestr), "%Y%m%d%H%M%S", localtime(&current_time));
     pipename = g_strconcat ( "\\\\.\\pipe\\", EXTCAP_PIPE_PREFIX, "_", timestr, NULL );