diff options
| author | Dario Lombardo <lomato@gmail.com> | 2016-10-14 14:36:27 +0200 |
|---|---|---|
| committer | Jaap Keuter <jaap.keuter@xs4all.nl> | 2016-10-15 10:22:21 +0000 |
| commit | a19c12b4a973d8f514db3824ed16f664fb9f1151 (patch) | |
| tree | c237223f56e275c579ddae7139a6c16a2ec9bdec /extcap | |
| parent | fb9ce2796cff7c896b0fec5042711b695f88be08 (diff) | |
| download | wireshark-a19c12b4a973d8f514db3824ed16f664fb9f1151.tar.gz | |
udpdump: fix issues from coverity.
Change-Id: I1d82d8166abe8eda6588ae2970ae9f2d096adf9d
Reviewed-on: https://code.wireshark.org/review/18198
Petri-Dish: Dario Lombardo <lomato@gmail.com>
Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org>
Reviewed-by: Jaap Keuter <jaap.keuter@xs4all.nl>
Diffstat (limited to 'extcap')
| -rw-r--r-- | extcap/udpdump.c | 11 |
1 files changed, 7 insertions, 4 deletions
diff --git a/extcap/udpdump.c b/extcap/udpdump.c index 1ff4e4b513..a83b7215d6 100644 --- a/extcap/udpdump.c +++ b/extcap/udpdump.c @@ -168,7 +168,7 @@ static int setup_dumpfile(const char* fifo, FILE** fp) } *fp = fopen(fifo, "w"); - if (!fp) { + if (!(*fp)) { g_warning("Error creating output file: %s", g_strerror(errno)); return EXIT_FAILURE; } @@ -233,19 +233,22 @@ static int dump_packet(const char* proto_name, const guint16 listenport, const c static void run_listener(const char* fifo, const guint16 port, const char* proto_name) { struct sockaddr_in clientaddr; - int clientlen; + int clientlen = 0; socket_handle_t sock; char buf[PKT_BUF_SIZE]; ssize_t buflen; - FILE* fp; + FILE* fp = NULL; if (signal(SIGINT, exit_from_loop) == SIG_ERR) { g_warning("Can't set signal handler"); return; } - if (setup_dumpfile(fifo, &fp) == EXIT_FAILURE) + if (setup_dumpfile(fifo, &fp) == EXIT_FAILURE) { + if (fp) + fclose(fp); return; + } if (setup_listener(port, &sock) == EXIT_FAILURE) return; |