diff options
| author | Guy Harris <guy@alum.mit.edu> | 2004-02-12 22:24:28 +0000 |
|---|---|---|
| committer | Guy Harris <guy@alum.mit.edu> | 2004-02-12 22:24:28 +0000 |
| commit | 90cf9a6b7b850a9ddd69baf1eb8535dde06a3510 (patch) | |
| tree | bff8e905f0757abd0edb742830da25baaac19e01 /gtk/dfilter_expr_dlg.c | |
| parent | 26536d7a419e04261f04035b287a050889e77a98 (diff) | |
| download | wireshark-90cf9a6b7b850a9ddd69baf1eb8535dde06a3510.tar.gz | |
The HIG's and/or GUI toolkit documentation for:
Mac OS X
GNOME
Qt
KDE
Windows
all indicate that {message,alert} boxes are modal, at least for the
window to which they apply. (Presumably the idea is that not forcing
the user to pay attention to the alert box, and allowing more than one
alert box to be up for a given window, causes more problems than not
letting the user do stuff to that window in order to figure out what the
underlying problem is or figure out what to do to fix it - the message
should be sufficient, in most if not all cases, to let you know what the
problem is.)
Make "simple_dialog()" unconditionally make the alert box modal, and get
rid of ESD_TYPE_MODAL. XXX - we need to make it possible to make an
alert box modal for a given window, rather than just the top-level
window.
svn path=/trunk/; revision=10051
Diffstat (limited to 'gtk/dfilter_expr_dlg.c')
| -rw-r--r-- | gtk/dfilter_expr_dlg.c | 11 |
1 files changed, 5 insertions, 6 deletions
diff --git a/gtk/dfilter_expr_dlg.c b/gtk/dfilter_expr_dlg.c index 7c7e0410a1..193a8eb1ed 100644 --- a/gtk/dfilter_expr_dlg.c +++ b/gtk/dfilter_expr_dlg.c @@ -7,7 +7,7 @@ * Copyright 2000, Jeffrey C. Foster <jfoste@woodward.com> and * Guy Harris <guy@alum.mit.edu> * - * $Id: dfilter_expr_dlg.c,v 1.50 2004/02/06 19:19:09 ulfl Exp $ + * $Id: dfilter_expr_dlg.c,v 1.51 2004/02/12 22:24:28 guy Exp $ * * Ethereal - Network traffic analyzer * By Gerald Combs <gerald@ethereal.com> @@ -778,8 +778,7 @@ dfilter_report_bad_value(char *format, ...) vsnprintf(error_msg_buf, sizeof error_msg_buf, format, args); va_end(args); - simple_dialog(ESD_TYPE_ERROR | ESD_TYPE_MODAL, ESD_BTN_OK, - "%s", error_msg_buf); + simple_dialog(ESD_TYPE_ERROR, ESD_BTN_OK, "%s", error_msg_buf); } static void @@ -900,11 +899,11 @@ dfilter_expr_dlg_accept_cb(GtkWidget *w, gpointer filter_te_arg) can_compare = TRUE; /* not a comparison */ if (!can_compare) { if (range_str == NULL) { - simple_dialog(ESD_TYPE_ERROR | ESD_TYPE_MODAL, ESD_BTN_OK, + simple_dialog(ESD_TYPE_ERROR, ESD_BTN_OK, "That field cannot be tested with \"%s\".", item_str); } else { - simple_dialog(ESD_TYPE_ERROR | ESD_TYPE_MODAL, ESD_BTN_OK, + simple_dialog(ESD_TYPE_ERROR, ESD_BTN_OK, "Ranges of that field cannot be tested with \"%s\".", item_str); } @@ -924,7 +923,7 @@ dfilter_expr_dlg_accept_cb(GtkWidget *w, gpointer filter_te_arg) * This field takes a value, but they didn't supply * one. */ - simple_dialog(ESD_TYPE_ERROR | ESD_TYPE_MODAL, ESD_BTN_OK, + simple_dialog(ESD_TYPE_ERROR, ESD_BTN_OK, "That field must be compared with a value, " "but you didn't specify a value with which to " "compare it."); |