diff options
| author | Ronnie Sahlberg <ronnie_sahlberg@ozemail.com.au> | 2002-03-12 08:16:41 +0000 |
|---|---|---|
| committer | Ronnie Sahlberg <ronnie_sahlberg@ozemail.com.au> | 2002-03-12 08:16:41 +0000 |
| commit | 385c80e202f7319f08a41fb3dd4cb2478d7b0c79 (patch) | |
| tree | 713f460101d5c3393e9a8e7956efd27f64318fcc /packet-dcerpc-nt.c | |
| parent | c41a4fe415a589524535394b44f248b96535b5f9 (diff) | |
| download | wireshark-385c80e202f7319f08a41fb3dd4cb2478d7b0c79.tar.gz | |
Small fix for dissect_ndr_nt_UNICODE_STRING_str() in packet-dcerpc-nt.c
so that NETLOGON will not dump core (since netlogon has these structs as top
level reference pointers)
Addition of full netlogon dissection. Full in the sense as it assumes the idl
is correct and complete.
Many calls and fields are unknown so they get dissected with "unknown long,
contact ethereal-dev@... if you know what it is".
svn path=/trunk/; revision=4929
Diffstat (limited to 'packet-dcerpc-nt.c')
| -rw-r--r-- | packet-dcerpc-nt.c | 7 |
1 files changed, 5 insertions, 2 deletions
diff --git a/packet-dcerpc-nt.c b/packet-dcerpc-nt.c index 6c931e45c1..c5c4533fdb 100644 --- a/packet-dcerpc-nt.c +++ b/packet-dcerpc-nt.c @@ -2,7 +2,7 @@ * Routines for DCERPC over SMB packet disassembly * Copyright 2001, Tim Potter <tpot@samba.org> * - * $Id: packet-dcerpc-nt.c,v 1.13 2002/03/11 00:15:20 sahlberg Exp $ + * $Id: packet-dcerpc-nt.c,v 1.14 2002/03/12 08:16:41 sahlberg Exp $ * * Ethereal - Network traffic analyzer * By Gerald Combs <gerald@ethereal.com> @@ -464,7 +464,10 @@ dissect_ndr_nt_UNICODE_STRING_str(tvbuff_t *tvb, int offset, proto_tree_add_string(tree, di->hf_index, tvb, old_offset, offset-old_offset, text); - if(tree){ + /* need to test di->levels before doing the proto_item_append_text() + since netlogon has these objects as top level objects in its representation + and trying to append to the tree object in that case will dump core */ + if(tree && (di->levels>-1)){ proto_item_append_text(tree, ": %s", text); if(di->levels>-1){ tree=tree->parent; |