diff options
| author | Michael Mann <mmann78@netscape.net> | 2017-05-08 20:32:56 -0400 |
|---|---|---|
| committer | Anders Broman <a.broman58@gmail.com> | 2017-05-09 04:52:00 +0000 |
| commit | fa5f913256bc16d21f9b9727fdf2cec454059c8d (patch) | |
| tree | 841d9388695919e49419659e7d45beb34cee8dce /plugins/docsis/packet-dsarsp.c | |
| parent | 954548fdb951cbffbfa3c7cadb2c202919c0204c (diff) | |
| download | wireshark-fa5f913256bc16d21f9b9727fdf2cec454059c8d.tar.gz | |
Bring DOCSIS Mac Management "dissectors" into modernity.
1. Use proto_tree_add_item_ret_uint to remove separate "gets"
2. Remove if (tree)s that prevented expert_info
3. Apply consistent whitespace
4. Apply consistent TLV behavior, making T and L always filterable
5. Remove T name (of TLV) from field name itself (where applicable)
6. Use BASE_UNIT_STRING and BASE_NO_DISPLAY_VALUE
Tested with capture generated from https://github.com/AdrianSimionov/docsis-generator
Change-Id: I9987397ccb3248b2a26d850af468740f94b28a63
Reviewed-on: https://code.wireshark.org/review/21561
Petri-Dish: Michael Mann <mmann78@netscape.net>
Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org>
Reviewed-by: Anders Broman <a.broman58@gmail.com>
Diffstat (limited to 'plugins/docsis/packet-dsarsp.c')
| -rw-r--r-- | plugins/docsis/packet-dsarsp.c | 31 |
1 files changed, 10 insertions, 21 deletions
diff --git a/plugins/docsis/packet-dsarsp.c b/plugins/docsis/packet-dsarsp.c index eb31168b15..5d85ed326e 100644 --- a/plugins/docsis/packet-dsarsp.c +++ b/plugins/docsis/packet-dsarsp.c @@ -46,34 +46,23 @@ static int dissect_dsarsp (tvbuff_t * tvb, packet_info * pinfo, proto_tree * tree, void* data _U_) { proto_item *it; - proto_tree *dsarsp_tree = NULL; - guint16 transid; - guint8 response; + proto_tree *dsarsp_tree; + guint32 transid, response; tvbuff_t *next_tvb; - transid = tvb_get_ntohs (tvb, 0); - response = tvb_get_guint8 (tvb, 2); + it = proto_tree_add_item (tree, proto_docsis_dsarsp, tvb, 0, -1, ENC_NA); + dsarsp_tree = proto_item_add_subtree (it, ett_docsis_dsarsp); + proto_tree_add_item_ret_uint (dsarsp_tree, hf_docsis_dsarsp_tranid, tvb, 0, 2, ENC_BIG_ENDIAN, &transid); + proto_tree_add_item_ret_uint (dsarsp_tree, hf_docsis_dsarsp_response, tvb, 2, 1, ENC_BIG_ENDIAN, &response); col_add_fstr (pinfo->cinfo, COL_INFO, "Dynamic Service Add Response ID = %u (%s)", transid, val_to_str (response, docsis_conf_code, "%d")); - if (tree) - { - it = - proto_tree_add_protocol_format (tree, proto_docsis_dsarsp, tvb, 0, -1, - "DSA Response"); - dsarsp_tree = proto_item_add_subtree (it, ett_docsis_dsarsp); - proto_tree_add_item (dsarsp_tree, hf_docsis_dsarsp_tranid, tvb, 0, 2, - ENC_BIG_ENDIAN); - proto_tree_add_item (dsarsp_tree, hf_docsis_dsarsp_response, tvb, 2, 1, - ENC_BIG_ENDIAN); - } - - /* Call dissector for Appendix C TLV's */ - next_tvb = tvb_new_subset_remaining (tvb, 3); - call_dissector (docsis_tlv_handle, next_tvb, pinfo, dsarsp_tree); - return tvb_captured_length(tvb); + /* Call dissector for Appendix C TLV's */ + next_tvb = tvb_new_subset_remaining (tvb, 3); + call_dissector (docsis_tlv_handle, next_tvb, pinfo, dsarsp_tree); + return tvb_captured_length(tvb); } /* Register the protocol with Wireshark */ |