diff options
| author | Birol Capa <birol.capa@siemens.com> | 2016-09-28 08:26:34 +0300 |
|---|---|---|
| committer | Michael Mann <mmann78@netscape.net> | 2016-09-29 00:49:57 +0000 |
| commit | 814477c32f9ac7838cf7364fcc83f36378ea2159 (patch) | |
| tree | 9e87f22b74797429bd45183939699669b6d47dec /plugins/profinet | |
| parent | 48a66835ee4f319ba7806a542bb2cf1f16a2ac06 (diff) | |
| download | wireshark-814477c32f9ac7838cf7364fcc83f36378ea2159.tar.gz | |
PROFINET: Fix pointer variable 'fp' previously deallocated warning
'fp' pointer variable was freed or deleted in an earlier statement.
To make code more readable and to avoid possible future mistakes
make sure that developer sees this situation.
Change-Id: Ib5b9c4c32000adf05a30e094ebc98fe4bc4cfa52
Reviewed-on: https://code.wireshark.org/review/17961
Reviewed-by: Peter Wu <peter@lekensteyn.nl>
Petri-Dish: Peter Wu <peter@lekensteyn.nl>
Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org>
Reviewed-by: Michael Mann <mmann78@netscape.net>
Diffstat (limited to 'plugins/profinet')
| -rw-r--r-- | plugins/profinet/packet-dcerpc-pn-io.c | 5 |
1 files changed, 4 insertions, 1 deletions
diff --git a/plugins/profinet/packet-dcerpc-pn-io.c b/plugins/profinet/packet-dcerpc-pn-io.c index fc555605af..8b7948405e 100644 --- a/plugins/profinet/packet-dcerpc-pn-io.c +++ b/plugins/profinet/packet-dcerpc-pn-io.c @@ -8353,7 +8353,10 @@ dissect_ExpectedSubmoduleBlockReq_block(tvbuff_t *tvb, int offset, if (diropen != NULL) { fp = ws_fopen(diropen, "r"); } - if(gsdmlFoundFlag && fp != NULL) { + else { + fp = NULL; + } + if(fp != NULL && gsdmlFoundFlag) { fseek(fp, 0, SEEK_SET); /* Find Indexnumber for fParameter */ |