diff options
| author | Peter Wu <peter@lekensteyn.nl> | 2015-06-08 00:10:21 +0200 |
|---|---|---|
| committer | Michael Mann <mmann78@netscape.net> | 2015-06-08 13:05:17 +0000 |
| commit | 69dac892803cdc555648c0a085ae2770942f0ae2 (patch) | |
| tree | f932f072243ff8d45e11075885ecb63da8c8b670 /plugins/stats_tree | |
| parent | 09e3505701559298c2b43b9f2439a80d0c39323f (diff) | |
| download | wireshark-69dac892803cdc555648c0a085ae2770942f0ae2.tar.gz | |
tcp: simplify tcp.flags.str, fix off-by-one
Observe that tcp_flags_to_str_first_letter is a copy of tcp_flags_to_str
with the flags[][4] variables copied and the loop variables inverted.
This misses the FIN bit, and runs past the flags buffer.
Behavior change: for consistency, move the reserved bits to the front
and print reserved bits individually. Old output / new output:
NCEUAPRSRRR
RRRNCEUAPRSF
Tested with this pcap with all flag bits set (0x0fff). hexdump:
d4c3b2a1020004000000000000000000ff7f000065000000b6b77455f3ac
06002800000028000000450000280001000040067ccd7f0000017f000001
0014005000000000000000005fff2000907f0000
Change-Id: I70e070808d1f0f9cd60eaf4f2b3f4ac6e3cfaada
Reviewed-on: https://code.wireshark.org/review/8826
Petri-Dish: Peter Wu <peter@lekensteyn.nl>
Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org>
Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com>
Reviewed-by: Michael Mann <mmann78@netscape.net>
Diffstat (limited to 'plugins/stats_tree')
0 files changed, 0 insertions, 0 deletions