Add some information about how/why this dissector is (partially) machine-generated and what that means to Wireshark maintainers.

svn path=/trunk/; revision=32577

7 files changed, 57 insertions, 20 deletions

diff --git a/plugins/opcua/README b/plugins/opcua/README
index df58cd5108..07068d77d0 100644
--- a/plugins/opcua/README
+++ b/plugins/opcua/README
@@ -50,6 +50,37 @@ For more information see http://www.opcfoundation.org
 Known limitations:
 ==================
 
-* Only the security policy http://opcfoundation.org/UA/SecurityPolicy#None is supported,
-  which means the encryption and signing is turned off.
+* Only the security policy http://opcfoundation.org/UA/SecurityPolicy#None is
+  supported, which means the encryption and signing is turned off.
   
+Machine-generated dissector:
+============================
+Parts of the OpcUa dissector are machine generated.  Several of the files are
+marked "DON'T MODIFY THIS FILE!" for this reason.
+
+However, the code to create this dissector is not part of the Wireshark source
+source code distribution.  This was discussed prior to the plugin's inclusion.
+From http://www.wireshark.org/lists/wireshark-dev/200704/msg00025.html :
+
+~~~
+> a lot of the code seems to be autogenerated (as the comments suggest)
+> It might make sense to include the sources and the build process instead 
+> of the intermediate files (if the amount of code/tools to build the 
+> files seems reasonable). The reason: When people start to hack your code 
+> (e.g. to remove warnings on a compiler you don't even think about), 
+> you'll might get into annoying trouble with merging code the next time 
+> you've update the upcua files.
+>
+>   
+I'm sorry, but I cannot give you the sources of the code generator,
+because they are owned by the OPC Foundation.
+I only extended the existing code generator to produce also wireshark code.
+It's .Net based so I guess you don't want to have it anyway ;-)
+~~~
+
+So, if changes must be made to the machine-generated files, it just means the
+upstream source will have to be modified before pushing any updates back to
+Wireshark.
+
+Of course it also means that care must be taken when applying patches from
+upstream to ensure local changes aren't reversed.
diff --git a/plugins/opcua/opcua_complextypeparser.h b/plugins/opcua/opcua_complextypeparser.h
index 502542a3ce..e34965a47e 100644
--- a/plugins/opcua/opcua_complextypeparser.h
+++ b/plugins/opcua/opcua_complextypeparser.h
@@ -3,21 +3,22 @@
 **
 ** Copyright (C) 2006-2009 ascolab GmbH. All Rights Reserved.
 ** Web: http://www.ascolab.com
-** 
+**
 ** This program is free software; you can redistribute it and/or
 ** modify it under the terms of the GNU General Public License
 ** as published by the Free Software Foundation; either version 2
 ** of the License, or (at your option) any later version.
-** 
+**
 ** This file is provided AS IS with NO WARRANTY OF ANY KIND, INCLUDING THE
 ** WARRANTY OF DESIGN, MERCHANTABILITY AND FITNESS FOR A PARTICULAR PURPOSE.
-** 
+**
 ** Project: OpcUa Wireshark Plugin
 **
 ** Description: OpcUa Complex Type Parser
 **
 ** This file was autogenerated on 31.03.2009.
 ** DON'T MODIFY THIS FILE!
+** XXX - well, except that you may have to.  See the README.
 **
 ******************************************************************************/
 
diff --git a/plugins/opcua/opcua_enumparser.h b/plugins/opcua/opcua_enumparser.h
index 1778c79f6a..b82c5a98f8 100644
--- a/plugins/opcua/opcua_enumparser.h
+++ b/plugins/opcua/opcua_enumparser.h
@@ -3,21 +3,22 @@
 **
 ** Copyright (C) 2006-2009 ascolab GmbH. All Rights Reserved.
 ** Web: http://www.ascolab.com
-** 
+**
 ** This program is free software; you can redistribute it and/or
 ** modify it under the terms of the GNU General Public License
 ** as published by the Free Software Foundation; either version 2
 ** of the License, or (at your option) any later version.
-** 
+**
 ** This file is provided AS IS with NO WARRANTY OF ANY KIND, INCLUDING THE
 ** WARRANTY OF DESIGN, MERCHANTABILITY AND FITNESS FOR A PARTICULAR PURPOSE.
-** 
+**
 ** Project: OpcUa Wireshark Plugin
 **
 ** Description: OpcUa Enum Type Parser
 **
 ** This file was autogenerated on 31.03.2009.
 ** DON'T MODIFY THIS FILE!
+** XXX - well, except that you may have to.  See the README.
 **
 ******************************************************************************/
 
diff --git a/plugins/opcua/opcua_hfindeces.h b/plugins/opcua/opcua_hfindeces.h
index 2117b84512..44cd27a0f5 100644
--- a/plugins/opcua/opcua_hfindeces.h
+++ b/plugins/opcua/opcua_hfindeces.h
@@ -3,21 +3,22 @@
 **
 ** Copyright (C) 2006-2009 ascolab GmbH. All Rights Reserved.
 ** Web: http://www.ascolab.com
-** 
+**
 ** This program is free software; you can redistribute it and/or
 ** modify it under the terms of the GNU General Public License
 ** as published by the Free Software Foundation; either version 2
 ** of the License, or (at your option) any later version.
-** 
+**
 ** This file is provided AS IS with NO WARRANTY OF ANY KIND, INCLUDING THE
 ** WARRANTY OF DESIGN, MERCHANTABILITY AND FITNESS FOR A PARTICULAR PURPOSE.
-** 
+**
 ** Project: OpcUa Wireshark Plugin
 **
 ** Description: This file contains protocol field handles.
 **
 ** This file was autogenerated on 31.03.2009.
 ** DON'T MODIFY THIS FILE!
+** XXX - well, except that you may have to.  See the README.
 **
 ******************************************************************************/
 
diff --git a/plugins/opcua/opcua_identifiers.h b/plugins/opcua/opcua_identifiers.h
index e0288c5d11..e817612b7c 100644
--- a/plugins/opcua/opcua_identifiers.h
+++ b/plugins/opcua/opcua_identifiers.h
@@ -3,21 +3,22 @@
 **
 ** Copyright (C) 2006-2007 ascolab GmbH. All Rights Reserved.
 ** Web: http://www.ascolab.com
-** 
+**
 ** This program is free software; you can redistribute it and/or
 ** modify it under the terms of the GNU General Public License
 ** as published by the Free Software Foundation; either version 2
 ** of the License, or (at your option) any later version.
-** 
+**
 ** This file is provided AS IS with NO WARRANTY OF ANY KIND, INCLUDING THE
 ** WARRANTY OF DESIGN, MERCHANTABILITY AND FITNESS FOR A PARTICULAR PURPOSE.
-** 
+**
 ** Project: OpcUa Wireshark Plugin
 **
 ** Description: Parser type definitions.
 **
 ** This file was autogenerated on 6/10/2007 2:35:22 AM.
 ** DON'T MODIFY THIS FILE!
+** XXX - well, except that you may have to.  See the README.
 **
 ******************************************************************************/
 
diff --git a/plugins/opcua/opcua_serviceids.h b/plugins/opcua/opcua_serviceids.h
index 7c55f464cd..79bda0a6ce 100644
--- a/plugins/opcua/opcua_serviceids.h
+++ b/plugins/opcua/opcua_serviceids.h
@@ -3,21 +3,22 @@
 **
 ** Copyright (C) 2006-2009 ascolab GmbH. All Rights Reserved.
 ** Web: http://www.ascolab.com
-** 
+**
 ** This program is free software; you can redistribute it and/or
 ** modify it under the terms of the GNU General Public License
 ** as published by the Free Software Foundation; either version 2
 ** of the License, or (at your option) any later version.
-** 
+**
 ** This file is provided AS IS with NO WARRANTY OF ANY KIND, INCLUDING THE
 ** WARRANTY OF DESIGN, MERCHANTABILITY AND FITNESS FOR A PARTICULAR PURPOSE.
-** 
+**
 ** Project: OpcUa Wireshark Plugin
 **
 ** Description: OpcUa Service IDs
 **
 ** This file was autogenerated on 31.03.2009.
 ** DON'T MODIFY THIS FILE!
+** XXX - well, except that you may have to.  See the README.
 **
 ******************************************************************************/
 
diff --git a/plugins/opcua/opcua_serviceparser.h b/plugins/opcua/opcua_serviceparser.h
index fd2b236797..b674ebf284 100644
--- a/plugins/opcua/opcua_serviceparser.h
+++ b/plugins/opcua/opcua_serviceparser.h
@@ -3,21 +3,22 @@
 **
 ** Copyright (C) 2006-2009 ascolab GmbH. All Rights Reserved.
 ** Web: http://www.ascolab.com
-** 
+**
 ** This program is free software; you can redistribute it and/or
 ** modify it under the terms of the GNU General Public License
 ** as published by the Free Software Foundation; either version 2
 ** of the License, or (at your option) any later version.
-** 
+**
 ** This file is provided AS IS with NO WARRANTY OF ANY KIND, INCLUDING THE
 ** WARRANTY OF DESIGN, MERCHANTABILITY AND FITNESS FOR A PARTICULAR PURPOSE.
-** 
+**
 ** Project: OpcUa Wireshark Plugin
 **
 ** Description: OpcUa Service Type Parser
 **
 ** This file was autogenerated on 31.03.2009.
 ** DON'T MODIFY THIS FILE!
+** XXX - well, except that you may have to.  See the README.
 **
 ******************************************************************************/