diff options
| author | Hadriel Kaplan <hadrielk@yahoo.com> | 2014-04-03 17:42:54 -0400 |
|---|---|---|
| committer | Michael Mann <mmann78@netscape.net> | 2014-04-14 00:10:20 +0000 |
| commit | 0a5572ea77aff392c7925b8ce30c15327c8d28cc (patch) | |
| tree | 006767092db788eb77357a619beb1bf3fab6814f /tools/pre-commit | |
| parent | f532fb94fc1478061e94c98423079b74269967f3 (diff) | |
| download | wireshark-0a5572ea77aff392c7925b8ce30c15327c8d28cc.tar.gz | |
Fix Bug 9951: 'git commit hook isn't calling checkAPIs.pl with arguments for the dissectors'
I recently made a change to packet-rtp.c and inappropriately included
g_error() in it, which the builbots caught during their run of checkAPIs.pl.
But checkAPIs.pl is supposed to catch such things for us before we submit, by
being invoked in the git pre-commit hook.
Apparently though, buildbots call checkAPIs.pl with extra arguments for
different cases... and for packet dissectors it calls it with a '-g abort'
argument, which is how it caught the g_error.
So the "bug" is that the pre-commit hook should invoke checAPIs.pl with that
argument too, for epan/dissectors/packet-*.c files.
Change-Id: Ie8f9dcc55f2248918208dea85a04f67e6bf9829a
Reviewed-on: https://code.wireshark.org/review/953
Reviewed-by: Hadriel Kaplan <hadrielk@yahoo.com>
Reviewed-by: Evan Huus <eapache@gmail.com>
Reviewed-by: Michael Mann <mmann78@netscape.net>
Diffstat (limited to 'tools/pre-commit')
| -rwxr-xr-x | tools/pre-commit | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/tools/pre-commit b/tools/pre-commit index 89afabc3e9..55b9c9c96d 100755 --- a/tools/pre-commit +++ b/tools/pre-commit @@ -21,7 +21,7 @@ for FILE in `git diff-index --cached --name-only HEAD | grep "\.[ch]$"` ; do ./tools/checkhf.pl $FILE #Check if checkAPIs is good - ./tools/checkAPIs.pl $FILE + ./tools/checkAPIs.pl -p $FILE #Check if fix-encoding-args is good ./tools/fix-encoding-args.pl $FILE |