diff options
| author | Dario Lombardo <lomato@gmail.com> | 2016-10-24 16:15:22 +0200 |
|---|---|---|
| committer | Dario Lombardo <lomato@gmail.com> | 2016-10-27 15:11:06 +0000 |
| commit | 7dfaab3cf79db1f36d4607d5d1ce79c222b8a9ac (patch) | |
| tree | 3cd4dca5da599aebb7d3bbd77f17297b74756e35 /tools | |
| parent | f347af277cd1132f7d9676303c06bbc26b3f22e8 (diff) | |
| download | wireshark-7dfaab3cf79db1f36d4607d5d1ce79c222b8a9ac.tar.gz | |
checkAPI: move atoi from soft-deprecated to prohibited.
The atoi function has been completely removed from the tree.
It's still present in the GTK code, but, since GTK compilation
has been removed in the default, checkAPI target doesn't complain,
as well as the buildbot.
Change-Id: I436d6f333b99b9188734155c1f92273420354947
Reviewed-on: https://code.wireshark.org/review/18432
Petri-Dish: Dario Lombardo <lomato@gmail.com>
Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org>
Reviewed-by: Jeff Morriss <jeff.morriss.ws@gmail.com>
Tested-by: Jeff Morriss <jeff.morriss.ws@gmail.com>
Reviewed-by: Dario Lombardo <lomato@gmail.com>
Diffstat (limited to 'tools')
| -rwxr-xr-x | tools/checkAPIs.pl | 9 |
1 files changed, 2 insertions, 7 deletions
diff --git a/tools/checkAPIs.pl b/tools/checkAPIs.pl index 14e18a2582..8801174df4 100755 --- a/tools/checkAPIs.pl +++ b/tools/checkAPIs.pl @@ -56,6 +56,7 @@ my %APIs = ( # and "Deprecated CRT Functions" # https://msdn.microsoft.com/en-us/library/ms235384.aspx # + 'atoi', # use wsutil/strtoi.h functions 'gets', 'sprintf', 'g_sprintf', @@ -159,13 +160,7 @@ my %APIs = ( # "I" isn't always the upper-case form of "i", and "i" isn't # always the lower-case form of "I"). Use the g_ascii_* version # instead. - 'toupper', - - # use wsutil/ws_strtoi.h function - # because of the wide use of atoi, we keep it in soft-deprecation status - # until we approach its complete removal, otherwise windows buildbot - # will keep to stuck with error. - 'atoi', + 'toupper' ] }, # APIs that SHOULD NOT be used in Wireshark (any more) |