summaryrefslogtreecommitdiff
path: root/ui/gtk/CMakeLists.txt
diff options
context:
space:
mode:
authorGuy Harris <guy@alum.mit.edu>2015-06-22 23:59:59 -0700
committerGuy Harris <guy@alum.mit.edu>2015-06-23 07:00:39 +0000
commit74c5ab0ff240edc1fd3f478128b378a0a0502190 (patch)
tree183d8c6aa3384f1547eb7b9d138d7f07f7a0a44c /ui/gtk/CMakeLists.txt
parent1dc608a05e4caa378dda710b829eee4d83d7cd80 (diff)
downloadwireshark-74c5ab0ff240edc1fd3f478128b378a0a0502190.tar.gz
Treat channel flags fields as just collections of bits, not as type fields.
The radiotap and PPI specs don't call them type fields, and don't list them as having type values, they call them flags fields and list the individual bits. Listing them as type fields is especially confusing with radiotap, as you can have multiple fields giving *different* channel types, as per, for example https://ask.wireshark.org/questions/42888/multiple-channel-types-and-mcs-missing where an 802.11ac packet has one "channel type" field claiming it's 802.11a and another one claiming it's 802.11n when it is, in fact, *neither* 11a *nor* 11n. If you want to know the channel type, look at the "802.11 radio information" tree that comes before the 802.11 header tree; it gives a reasonable summary of most of the radio metadata, giving the *correct* channel type, and not showing any field multiple times. Look at the radiotap or PPI or... tree only if either 1) you're debugging a driver that creates those headers or 2) there's some data in the header that *doesn't* show up in any form in the 802.11 radio information tree (in which case the code for radio information probably needs to be changed to show it). Change-Id: I545b81b08a993dbb219fa7a4f54daac3637ea071 Reviewed-on: https://code.wireshark.org/review/9051 Reviewed-by: Guy Harris <guy@alum.mit.edu>
Diffstat (limited to 'ui/gtk/CMakeLists.txt')
0 files changed, 0 insertions, 0 deletions