diff options
| author | João Valverde <joao.valverde@tecnico.ulisboa.pt> | 2015-11-26 04:44:52 +0000 |
|---|---|---|
| committer | João Valverde <j@v6e.pt> | 2016-02-07 23:22:30 +0000 |
| commit | 13ec77a9fc3af3b0b502820d0b55796c89997896 (patch) | |
| tree | c5f5f72f090efd5471cf95095b00e13efa407959 /ui/gtk/graph_analysis.c | |
| parent | d762a895ab570680e4e72142a348ad2b07c97d4f (diff) | |
| download | wireshark-13ec77a9fc3af3b0b502820d0b55796c89997896.tar.gz | |
Add free_address_wmem() and other extensions to address API
Try to improve 'address' API (to be easier/safer) and also avoid
some constness warnings by not overloading the 'data' pointer to
store malloc'ed buffers (use private pointer for that instead).
Change-Id: I7456516b12c67620ceadac447907c12f5905bd49
Reviewed-on: https://code.wireshark.org/review/13463
Petri-Dish: João Valverde <j@v6e.pt>
Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org>
Reviewed-by: João Valverde <j@v6e.pt>
Diffstat (limited to 'ui/gtk/graph_analysis.c')
| -rw-r--r-- | ui/gtk/graph_analysis.c | 10 |
1 files changed, 2 insertions, 8 deletions
diff --git a/ui/gtk/graph_analysis.c b/ui/gtk/graph_analysis.c index b8b78cb816..d6351f6d6b 100644 --- a/ui/gtk/graph_analysis.c +++ b/ui/gtk/graph_analysis.c @@ -86,10 +86,7 @@ static void graph_analysis_reset(graph_analysis_data_t *user_data) user_data->graph_info->num_nodes = 0; user_data->num_items = 0; for (i=0; i<MAX_NUM_NODES; i++) { - user_data->graph_info->nodes[i].type = AT_NONE; - user_data->graph_info->nodes[i].len = 0; - g_free((void *)user_data->graph_info->nodes[i].data); - user_data->graph_info->nodes[i].data = NULL; + free_address(&user_data->graph_info->nodes[i]); } user_data->dlg.first_node = 0; @@ -157,10 +154,7 @@ static void on_destroy(GtkWidget *win _U_, graph_analysis_data_t *user_data) int i; for (i=0; i<MAX_NUM_NODES; i++) { - user_data->graph_info->nodes[i].type = AT_NONE; - user_data->graph_info->nodes[i].len = 0; - g_free((void *)user_data->graph_info->nodes[i].data); - user_data->graph_info->nodes[i].data = NULL; + free_address(&user_data->graph_info->nodes[i]); } user_data->dlg.window = NULL; g_free(user_data->dlg.title); |