summaryrefslogtreecommitdiff
path: root/ui/gtk/rtp_player.c
diff options
context:
space:
mode:
authorPeter Wu <peter@lekensteyn.nl>2015-02-07 10:02:13 +0100
committerAnders Broman <a.broman58@gmail.com>2015-02-09 05:26:29 +0000
commit702618fa615482383733587e58c5b0619ae50e35 (patch)
tree16dd27621445fc22f6fbd28647819cd722b866bb /ui/gtk/rtp_player.c
parentd56a3c9789adbe8dd7fbaeb1232365d11cf1fad7 (diff)
downloadwireshark-702618fa615482383733587e58c5b0619ae50e35.tar.gz
Fix use-after free in RTP player
Clicking "Decode" in the RTP player triggered an ASAN heap-use-after-free in update_progress_bar(). Explicitly set progress_bar to NULL to prevent this. Change-Id: Ice3105a11642a1cc5a54b8fbdf7dbf0ed430d965 Ping-Bug: 10714 Reviewed-on: https://code.wireshark.org/review/6999 Reviewed-by: Anders Broman <a.broman58@gmail.com>
Diffstat (limited to 'ui/gtk/rtp_player.c')
-rw-r--r--ui/gtk/rtp_player.c1
1 files changed, 1 insertions, 0 deletions
diff --git a/ui/gtk/rtp_player.c b/ui/gtk/rtp_player.c
index 3b2886ef55..a765c1d404 100644
--- a/ui/gtk/rtp_player.c
+++ b/ui/gtk/rtp_player.c
@@ -2228,6 +2228,7 @@ decode_streams(void)
gtk_widget_show_all(main_scrolled_window);
gtk_widget_destroy(progress_bar);
+ progress_bar = NULL;
#if !GTK_CHECK_VERSION(3,0,0)
gtk_statusbar_set_has_resize_grip(GTK_STATUSBAR(info_bar), TRUE);
#endif