diff options
| author | Alexis La Goutte <alexis.lagoutte@gmail.com> | 2015-12-03 09:03:53 +0100 |
|---|---|---|
| committer | Anders Broman <a.broman58@gmail.com> | 2015-12-19 15:00:31 +0000 |
| commit | 16181142a7b027f754ce67c4129e0a75554f4e66 (patch) | |
| tree | de4e0b31a8c543386a4b450dcf68797c2e52910b /ui/gtk/sctp_graph_dlg.c | |
| parent | 5667cf9c922739ba486f092eeca3ea7521108237 (diff) | |
| download | wireshark-16181142a7b027f754ce67c4129e0a75554f4e66.tar.gz | |
sctp_graph_dlg: fix Expression 'tsn->secs >= min_secs' is always true. Unsigned type value is always >= 0
min_secs is always set to 0
Change-Id: I62e3a5b71b423ae9ae15be1206bd1deeb9962760
Reviewed-on: https://code.wireshark.org/review/12400
Petri-Dish: Alexis La Goutte <alexis.lagoutte@gmail.com>
Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org>
Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com>
Reviewed-by: Anders Broman <a.broman58@gmail.com>
Diffstat (limited to 'ui/gtk/sctp_graph_dlg.c')
| -rw-r--r-- | ui/gtk/sctp_graph_dlg.c | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/ui/gtk/sctp_graph_dlg.c b/ui/gtk/sctp_graph_dlg.c index 3a0e055071..b0ddcc5dfc 100644 --- a/ui/gtk/sctp_graph_dlg.c +++ b/ui/gtk/sctp_graph_dlg.c @@ -527,7 +527,7 @@ draw_tsn_graph(struct sctp_udata *u_data) GList *list=NULL, *tlist; guint8 type; guint32 tsnumber=0; - guint32 min_secs=0, diff; + guint32 diff; gint xvalue, yvalue; cairo_t *cr = NULL; GdkRGBA black_color = {0.0, 0.0, 0.0, 1.0}; @@ -571,7 +571,7 @@ draw_tsn_graph(struct sctp_udata *u_data) type = ((struct chunk_header *)tlist->data)->type; if (type == SCTP_DATA_CHUNK_ID || type == SCTP_I_DATA_CHUNK_ID || type == SCTP_FORWARD_TSN_CHUNK_ID) tsnumber = g_ntohl(((struct data_chunk_header *)tlist->data)->tsn); - if (tsnumber >= min_tsn && tsnumber <= max_tsn && tsn->secs >= min_secs) + if (tsnumber >= min_tsn && tsnumber <= max_tsn) { if (u_data->io->uoff) { diff = tsn->secs - u_data->io->min_x; |