Fix a bunch of warnings.

Cast away some implicit 64-bit-to-32-bit conversion errors due to use of
sizeof.

Cast away some implicit 64-bit-to-32-bit conversion errors due to use of
strtol() and strtoul().

Change some data types to avoid those implicit conversion warnings.

When assigning a constant to a float, make sure the constant isn't a
double, by appending "f" to the constant.

Constify a bunch of variables, parameters, and return values to
eliminate warnings due to strings being given const qualifiers.  Cast
away those warnings in some cases where an API we don't control forces
us to do so.

Enable a bunch of additional warnings by default.  Note why at least
some of the other warnings aren't enabled.

randpkt.c and text2pcap.c are used to build programs, so they don't need
to be in EXTRA_DIST.

If the user specifies --enable-warnings-as-errors, add -Werror *even if
the user specified --enable-extra-gcc-flags; assume they know what
they're doing and are willing to have the compile fail due to the extra
GCC warnings being treated as errors.

svn path=/trunk/; revision=46748

1 files changed, 67 insertions, 67 deletions

diff --git a/ui/gtk/stock_icons.c b/ui/gtk/stock_icons.c
index 0d2908a1d6..691af12483 100644
--- a/ui/gtk/stock_icons.c
+++ b/ui/gtk/stock_icons.c
@@ -95,75 +95,75 @@ void stock_icons_init(void) {
 
     /* register non-standard pixmaps with the gtk-stock engine */
     static const GtkStockItem stock_items[] = {
-        { WIRESHARK_STOCK_CAPTURE_INTERFACES,    "_Interfaces",    0, 0, NULL },
-        { WIRESHARK_STOCK_CAPTURE_OPTIONS,       "_Options",       0, 0, NULL },
-        { WIRESHARK_STOCK_CAPTURE_START,         "_Start",         0, 0, NULL },
-        { WIRESHARK_STOCK_CAPTURE_STOP,          "S_top",          0, 0, NULL },
-        { WIRESHARK_STOCK_CAPTURE_RESTART,       "_Restart",       0, 0, NULL },
-        { WIRESHARK_STOCK_CAPTURE_FILTER,        "_Capture Filter",   0, 0, NULL },
-        { WIRESHARK_STOCK_CAPTURE_FILTER_ENTRY,  "_Capture Filter:",  0, 0, NULL },
-        { WIRESHARK_STOCK_CAPTURE_DETAILS,       "_Details",       0, 0, NULL },
+        { (char *)WIRESHARK_STOCK_CAPTURE_INTERFACES,    (char *)"_Interfaces",    0, 0, NULL },
+        { (char *)WIRESHARK_STOCK_CAPTURE_OPTIONS,       (char *)"_Options",       0, 0, NULL },
+        { (char *)WIRESHARK_STOCK_CAPTURE_START,         (char *)"_Start",         0, 0, NULL },
+        { (char *)WIRESHARK_STOCK_CAPTURE_STOP,          (char *)"S_top",          0, 0, NULL },
+        { (char *)WIRESHARK_STOCK_CAPTURE_RESTART,       (char *)"_Restart",       0, 0, NULL },
+        { (char *)WIRESHARK_STOCK_CAPTURE_FILTER,        (char *)"_Capture Filter",   0, 0, NULL },
+        { (char *)WIRESHARK_STOCK_CAPTURE_FILTER_ENTRY,  (char *)"_Capture Filter:",  0, 0, NULL },
+        { (char *)WIRESHARK_STOCK_CAPTURE_DETAILS,       (char *)"_Details",       0, 0, NULL },
 #ifdef HAVE_GEOIP
-        { WIRESHARK_STOCK_MAP,                   "Map",                   0, 0, NULL },
+        { (char *)WIRESHARK_STOCK_MAP,                   (char *)"Map",                   0, 0, NULL },
 #endif
-        { WIRESHARK_STOCK_GRAPH_A_B,             "Graph A->B",            0, 0, NULL },
-        { WIRESHARK_STOCK_GRAPH_B_A,             "Graph B->A",            0, 0, NULL },
-        { WIRESHARK_STOCK_FOLLOW_STREAM,         "Follow Stream",         0, 0, NULL },
-        { WIRESHARK_STOCK_DISPLAY_FILTER,        "Display _Filter",       0, 0, NULL },
-        { WIRESHARK_STOCK_DISPLAY_FILTER_ENTRY,  "F_ilter:",  0, 0, NULL },
-        { WIRESHARK_STOCK_BROWSE,                "_Browse...",                0, 0, NULL },
-        { WIRESHARK_STOCK_CREATE_STAT,           "Create _Stat",           0, 0, NULL },
-        { WIRESHARK_STOCK_EXPORT,                "_Export...",                0, 0, NULL },
-        { WIRESHARK_STOCK_IMPORT,                "_Import...",                0, 0, NULL },
-        { WIRESHARK_STOCK_EDIT,                  "_Edit...",                  0, 0, NULL },
-        { WIRESHARK_STOCK_ADD_EXPRESSION,        "E_xpression..." ,        0, 0, NULL }, /* plus sign coming from icon */
-        { WIRESHARK_STOCK_CLEAR_EXPRESSION,      "Clea_r" ,                   0, 0, NULL },
-        { WIRESHARK_STOCK_APPLY_EXPRESSION,      "App_ly" ,                   0, 0, NULL },
-        { WIRESHARK_STOCK_SAVE_ALL,              "Save A_ll",             0, 0, NULL },
-        { WIRESHARK_STOCK_DONT_SAVE,             "Continue _without Saving",             0, 0, NULL },
-        { WIRESHARK_STOCK_QUIT_DONT_SAVE,        "Quit _without Saving",             0, 0, NULL },
-        { WIRESHARK_STOCK_STOP_DONT_SAVE,        "Stop and Continue _without Saving",             0, 0, NULL },
-        { WIRESHARK_STOCK_STOP_QUIT_DONT_SAVE,   "Stop and Quit _without Saving",             0, 0, NULL },
-        { WIRESHARK_STOCK_STOP_SAVE,             "Stop and Save",             0, 0, NULL },
-        { WIRESHARK_STOCK_ABOUT,                 "_About",                 0, 0, NULL },
-        { WIRESHARK_STOCK_COLORIZE,              "_Colorize",              0, 0, NULL },
-        { WIRESHARK_STOCK_AUTOSCROLL,            "_Auto Scroll",            0, 0, NULL },
-        { WIRESHARK_STOCK_RESIZE_COLUMNS,        "Resize Columns",        0, 0, NULL },
-        { WIRESHARK_STOCK_TIME,                  "Time",                  0, 0, NULL },
-        { WIRESHARK_STOCK_INTERNET,              "Internet",              0, 0, NULL },
-        { WIRESHARK_STOCK_WEB_SUPPORT,           "Web Support",           0, 0, NULL },
-        { WIRESHARK_STOCK_WIKI,                  "Wiki",                  0, 0, NULL },
-        { WIRESHARK_STOCK_CONVERSATIONS,         "Conversations",         0, 0, NULL },
-        { WIRESHARK_STOCK_ENDPOINTS,             "Endpoints",             0, 0, NULL },
-        { WIRESHARK_STOCK_EXPERT_INFO,           "Expert Info",           0, 0, NULL },
-        { WIRESHARK_STOCK_GRAPHS,                "Graphs",                0, 0, NULL },
-        { WIRESHARK_STOCK_FLOW_GRAPH,            "Flow Graph",            0, 0, NULL },
-        { WIRESHARK_STOCK_TELEPHONY,             "Telephony",             0, 0, NULL },
-        { WIRESHARK_STOCK_DECODE_AS,             "Decode As",             0, 0, NULL },
-        { WIRESHARK_STOCK_CHECKBOX,              "Checkbox",              0, 0, NULL },
-        { WIRESHARK_STOCK_FILE_SET_LIST,         "List Files",         0, 0, NULL },
-        { WIRESHARK_STOCK_FILE_SET_NEXT,         "Next File",         0, 0, NULL },
-        { WIRESHARK_STOCK_FILE_SET_PREVIOUS,     "Previous File",     0, 0, NULL },
-        { WIRESHARK_STOCK_FILTER_OUT_STREAM,     "Filter Out This Stream",     0, 0, NULL },
-        { WIRESHARK_STOCK_ENABLE,                "Enable",                0, 0, NULL },
-        { WIRESHARK_STOCK_DISABLE,               "Disable",               0, 0, NULL },
-        { WIRESHARK_STOCK_COLOR1,                "Color 1",                0, 0, NULL },
-        { WIRESHARK_STOCK_COLOR2,                "Color 2",                0, 0, NULL },
-        { WIRESHARK_STOCK_COLOR3,                "Color 3",                0, 0, NULL },
-        { WIRESHARK_STOCK_COLOR4,                "Color 4",                0, 0, NULL },
-        { WIRESHARK_STOCK_COLOR5,                "Color 5",                0, 0, NULL },
-        { WIRESHARK_STOCK_COLOR6,                "Color 6",                0, 0, NULL },
-        { WIRESHARK_STOCK_COLOR7,                "Color 7",                0, 0, NULL },
-        { WIRESHARK_STOCK_COLOR8,                "Color 8",                0, 0, NULL },
-        { WIRESHARK_STOCK_COLOR9,                "Color 9",                0, 0, NULL },
-        { WIRESHARK_STOCK_COLOR0,                "Color 10",               0, 0, NULL },
-        { WIRESHARK_STOCK_DECODE,                "Decode",                 0, 0, NULL },
-        { WIRESHARK_STOCK_AUDIO_PLAYER,          "Player",                 0, 0, NULL },
-        { WIRESHARK_STOCK_VOIP_FLOW,             "Flow",                   0, 0, NULL },
-        { WIRESHARK_STOCK_TELEPHONE,             "Telephone",              0, 0, NULL },
-        { WIRESHARK_STOCK_PREPARE_FILTER,        "Prepare Filter",         0, 0, NULL },
-        { WIRESHARK_STOCK_ANALYZE,               "Analyze",                0, 0, NULL },
-        { WIRESHARK_STOCK_SAVE,                  "Save",                   0, 0, NULL }
+        { (char *)WIRESHARK_STOCK_GRAPH_A_B,             (char *)"Graph A->B",            0, 0, NULL },
+        { (char *)WIRESHARK_STOCK_GRAPH_B_A,             (char *)"Graph B->A",            0, 0, NULL },
+        { (char *)WIRESHARK_STOCK_FOLLOW_STREAM,         (char *)"Follow Stream",         0, 0, NULL },
+        { (char *)WIRESHARK_STOCK_DISPLAY_FILTER,        (char *)"Display _Filter",       0, 0, NULL },
+        { (char *)WIRESHARK_STOCK_DISPLAY_FILTER_ENTRY,  (char *)"F_ilter:",  0, 0, NULL },
+        { (char *)WIRESHARK_STOCK_BROWSE,                (char *)"_Browse...",                0, 0, NULL },
+        { (char *)WIRESHARK_STOCK_CREATE_STAT,           (char *)"Create _Stat",           0, 0, NULL },
+        { (char *)WIRESHARK_STOCK_EXPORT,                (char *)"_Export...",                0, 0, NULL },
+        { (char *)WIRESHARK_STOCK_IMPORT,                (char *)"_Import...",                0, 0, NULL },
+        { (char *)WIRESHARK_STOCK_EDIT,                  (char *)"_Edit...",                  0, 0, NULL },
+        { (char *)WIRESHARK_STOCK_ADD_EXPRESSION,        (char *)"E_xpression..." ,        0, 0, NULL }, /* plus sign coming from icon */
+        { (char *)WIRESHARK_STOCK_CLEAR_EXPRESSION,      (char *)"Clea_r" ,                   0, 0, NULL },
+        { (char *)WIRESHARK_STOCK_APPLY_EXPRESSION,      (char *)"App_ly" ,                   0, 0, NULL },
+        { (char *)WIRESHARK_STOCK_SAVE_ALL,              (char *)"Save A_ll",             0, 0, NULL },
+        { (char *)WIRESHARK_STOCK_DONT_SAVE,             (char *)"Continue _without Saving",             0, 0, NULL },
+        { (char *)WIRESHARK_STOCK_QUIT_DONT_SAVE,        (char *)"Quit _without Saving",             0, 0, NULL },
+        { (char *)WIRESHARK_STOCK_STOP_DONT_SAVE,        (char *)"Stop and Continue _without Saving",             0, 0, NULL },
+        { (char *)WIRESHARK_STOCK_STOP_QUIT_DONT_SAVE,   (char *)"Stop and Quit _without Saving",             0, 0, NULL },
+        { (char *)WIRESHARK_STOCK_STOP_SAVE,             (char *)"Stop and Save",             0, 0, NULL },
+        { (char *)WIRESHARK_STOCK_ABOUT,                 (char *)"_About",                 0, 0, NULL },
+        { (char *)WIRESHARK_STOCK_COLORIZE,              (char *)"_Colorize",              0, 0, NULL },
+        { (char *)WIRESHARK_STOCK_AUTOSCROLL,            (char *)"_Auto Scroll",            0, 0, NULL },
+        { (char *)WIRESHARK_STOCK_RESIZE_COLUMNS,        (char *)"Resize Columns",        0, 0, NULL },
+        { (char *)WIRESHARK_STOCK_TIME,                  (char *)"Time",                  0, 0, NULL },
+        { (char *)WIRESHARK_STOCK_INTERNET,              (char *)"Internet",              0, 0, NULL },
+        { (char *)WIRESHARK_STOCK_WEB_SUPPORT,           (char *)"Web Support",           0, 0, NULL },
+        { (char *)WIRESHARK_STOCK_WIKI,                  (char *)"Wiki",                  0, 0, NULL },
+        { (char *)WIRESHARK_STOCK_CONVERSATIONS,         (char *)"Conversations",         0, 0, NULL },
+        { (char *)WIRESHARK_STOCK_ENDPOINTS,             (char *)"Endpoints",             0, 0, NULL },
+        { (char *)WIRESHARK_STOCK_EXPERT_INFO,           (char *)"Expert Info",           0, 0, NULL },
+        { (char *)WIRESHARK_STOCK_GRAPHS,                (char *)"Graphs",                0, 0, NULL },
+        { (char *)WIRESHARK_STOCK_FLOW_GRAPH,            (char *)"Flow Graph",            0, 0, NULL },
+        { (char *)WIRESHARK_STOCK_TELEPHONY,             (char *)"Telephony",             0, 0, NULL },
+        { (char *)WIRESHARK_STOCK_DECODE_AS,             (char *)"Decode As",             0, 0, NULL },
+        { (char *)WIRESHARK_STOCK_CHECKBOX,              (char *)"Checkbox",              0, 0, NULL },
+        { (char *)WIRESHARK_STOCK_FILE_SET_LIST,         (char *)"List Files",         0, 0, NULL },
+        { (char *)WIRESHARK_STOCK_FILE_SET_NEXT,         (char *)"Next File",         0, 0, NULL },
+        { (char *)WIRESHARK_STOCK_FILE_SET_PREVIOUS,     (char *)"Previous File",     0, 0, NULL },
+        { (char *)WIRESHARK_STOCK_FILTER_OUT_STREAM,     (char *)"Filter Out This Stream",     0, 0, NULL },
+        { (char *)WIRESHARK_STOCK_ENABLE,                (char *)"Enable",                0, 0, NULL },
+        { (char *)WIRESHARK_STOCK_DISABLE,               (char *)"Disable",               0, 0, NULL },
+        { (char *)WIRESHARK_STOCK_COLOR1,                (char *)"Color 1",                0, 0, NULL },
+        { (char *)WIRESHARK_STOCK_COLOR2,                (char *)"Color 2",                0, 0, NULL },
+        { (char *)WIRESHARK_STOCK_COLOR3,                (char *)"Color 3",                0, 0, NULL },
+        { (char *)WIRESHARK_STOCK_COLOR4,                (char *)"Color 4",                0, 0, NULL },
+        { (char *)WIRESHARK_STOCK_COLOR5,                (char *)"Color 5",                0, 0, NULL },
+        { (char *)WIRESHARK_STOCK_COLOR6,                (char *)"Color 6",                0, 0, NULL },
+        { (char *)WIRESHARK_STOCK_COLOR7,                (char *)"Color 7",                0, 0, NULL },
+        { (char *)WIRESHARK_STOCK_COLOR8,                (char *)"Color 8",                0, 0, NULL },
+        { (char *)WIRESHARK_STOCK_COLOR9,                (char *)"Color 9",                0, 0, NULL },
+        { (char *)WIRESHARK_STOCK_COLOR0,                (char *)"Color 10",               0, 0, NULL },
+        { (char *)WIRESHARK_STOCK_DECODE,                (char *)"Decode",                 0, 0, NULL },
+        { (char *)WIRESHARK_STOCK_AUDIO_PLAYER,          (char *)"Player",                 0, 0, NULL },
+        { (char *)WIRESHARK_STOCK_VOIP_FLOW,             (char *)"Flow",                   0, 0, NULL },
+        { (char *)WIRESHARK_STOCK_TELEPHONE,             (char *)"Telephone",              0, 0, NULL },
+        { (char *)WIRESHARK_STOCK_PREPARE_FILTER,        (char *)"Prepare Filter",         0, 0, NULL },
+        { (char *)WIRESHARK_STOCK_ANALYZE,               (char *)"Analyze",                0, 0, NULL },
+        { (char *)WIRESHARK_STOCK_SAVE,                  (char *)"Save",                   0, 0, NULL }
     };
 
     static const stock_pixmap_t pixmaps[] = {