diff options
| author | Guy Harris <guy@alum.mit.edu> | 2015-01-13 15:13:40 -0800 |
|---|---|---|
| committer | Guy Harris <guy@alum.mit.edu> | 2015-01-13 23:14:13 +0000 |
| commit | 63a3d043e3f14eebb0798a250d9aecdc8e89dfb9 (patch) | |
| tree | 69a58dd4cadfc7f98669cba229e76fa8c60e0761 /ui/help_url.c | |
| parent | 9f5e4fb7a51741a286ce5bc92a6f335ed58587a2 (diff) | |
| download | wireshark-63a3d043e3f14eebb0798a250d9aecdc8e89dfb9.tar.gz | |
Consistently use the "g_string_free returns a C string pointer" idiom.
g_string_free(str, FALSE) frees the GString container but not the
underlying g_malloc()ed string; instead, it returns a pointer to the
g_malloc()ed string.
Fix those places that didn't already get the string pointer from
g_string_free() to do so rather than manually extracting the string
themselves.
And fix one place that didn't even need to use a string - it was just
scanning a C string without even modifying it.
Change-Id: Ibbf4872bf5b9935b9907f539b6edb1013f3053a5
Reviewed-on: https://code.wireshark.org/review/6532
Reviewed-by: Guy Harris <guy@alum.mit.edu>
Diffstat (limited to 'ui/help_url.c')
| -rw-r--r-- | ui/help_url.c | 5 |
1 files changed, 1 insertions, 4 deletions
diff --git a/ui/help_url.c b/ui/help_url.c index a1fa295b20..5ccb3082c5 100644 --- a/ui/help_url.c +++ b/ui/help_url.c @@ -119,7 +119,6 @@ topic_online_url(topic_action_e action) gchar * user_guide_url(const gchar *page) { GString *url = g_string_new(""); - gchar *ug_url = NULL; /* * Try to open local .chm file. This is not the most intuitive way to @@ -155,9 +154,7 @@ user_guide_url(const gchar *page) { #endif /* ifdef DOC_DIR */ - ug_url = url->str; - g_string_free(url, FALSE); - return ug_url; + return g_string_free(url, FALSE); } gchar * |