summaryrefslogtreecommitdiff
path: root/ui/help_url.h
diff options
context:
space:
mode:
authorGuy Harris <guy@alum.mit.edu>2013-06-21 05:24:59 +0000
committerGuy Harris <guy@alum.mit.edu>2013-06-21 05:24:59 +0000
commit4e29abf8bee1443759022340d621004bd76b06b9 (patch)
tree812a23a3a1e6d5aaaf0a9aee0e380861cbc09cc0 /ui/help_url.h
parent44882c4f1493734860e8ecdc5ddb3275cd1c936e (diff)
downloadwireshark-4e29abf8bee1443759022340d621004bd76b06b9.tar.gz
get_ax25_name() is *NOT* the right routine to use to translate a
human-readable representing an AX.25 subaddress (e.g. "KA9Q-01") into the binary form of an AX.25 address, because what it does is translate the binary form of an AX.25 address to the human-readable form! We currently have no routine that does the right thing and, even if we did, given that some bits in the AX.25 subaddress format are used for purposes other than representing the call sign and substation ID, so the matching routines for AX.25 addresses need to ignore certain bits. For now, we just remove the call to get_ax25_name() (which squelches the pointer-signedness warning that made me look at this code, and find the problem, in the first place) and replace it with a comment discussing the problem and a failure. The other pointer-signedness warning brought up a question of what to do with G_REGEX_RAW in the g_regex_match_full() call; it didn't bring up an immediately obvious *answer*, so we throw a cast at the warning and add another comment. (We fix up alignment while we're at it.) svn path=/trunk/; revision=50106
Diffstat (limited to 'ui/help_url.h')
0 files changed, 0 insertions, 0 deletions