summaryrefslogtreecommitdiff
path: root/ui/qt/byte_view_tab.cpp
diff options
context:
space:
mode:
authorGerald Combs <gerald@wireshark.org>2014-10-24 13:24:23 -0700
committerGerald Combs <gerald@wireshark.org>2014-10-24 22:58:46 +0000
commitceff4edbf04d5725542208a533cc61ffdf7854b2 (patch)
tree416881949db860fe045a75dbfa96d56e89a722e5 /ui/qt/byte_view_tab.cpp
parent001dbaf76382fafa1b0525bd0b16757b1c675eb0 (diff)
downloadwireshark-ceff4edbf04d5725542208a533cc61ffdf7854b2.tar.gz
Qt: Refactor ByteViewText.
Instead of subclassing QTextEdit and filling it with the entire contents of our tvbuff, subclass QAbstractScrollArea and draw text by hand only when needed. The new code should be *much* faster. Some code based on QHexView by Even Teran (https://code.google.com/p/qhexview/). To do: - Finish the bit view implementation. Change-Id: Ie44de6870d80711cd44324521a17ab76bcefe5e5 Reviewed-on: https://code.wireshark.org/review/4922 Reviewed-by: Gerald Combs <gerald@wireshark.org>
Diffstat (limited to 'ui/qt/byte_view_tab.cpp')
-rw-r--r--ui/qt/byte_view_tab.cpp2
1 files changed, 0 insertions, 2 deletions
diff --git a/ui/qt/byte_view_tab.cpp b/ui/qt/byte_view_tab.cpp
index 04b3008b13..61b3af1238 100644
--- a/ui/qt/byte_view_tab.cpp
+++ b/ui/qt/byte_view_tab.cpp
@@ -169,8 +169,6 @@ void ByteViewTab::protoTreeItemChanged(QTreeWidgetItem *current) {
// Appendix (trailer) bytes
byte_view_text->setFieldAppendixHighlight(fa_start, fa_end);
- byte_view_text->renderBytes();
-
setCurrentIndex(i);
}
byte_view_text = qobject_cast<ByteViewText*>(widget(++i));