Qt: Clean up the byte view hover highlight.

Rename the text highlight enum "HighlightMode" to make its use and
intent more clear. Add a mode for the offset highlight instead of using
a separate variable. Use our palette to draw the hover highlight colors.
Add a note about colors to the Developer's Guide.

Change-Id: I488b2512a5058e17eb5b49c8ac55616100f32fbc
Reviewed-on: https://code.wireshark.org/review/18953
Petri-Dish: Gerald Combs <gerald@wireshark.org>
Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org>
Reviewed-by: Gerald Combs <gerald@wireshark.org>

1 files changed, 9 insertions, 7 deletions

diff --git a/ui/qt/byte_view_text.h b/ui/qt/byte_view_text.h
index 8271f31161..0e91e084ba 100644
--- a/ui/qt/byte_view_text.h
+++ b/ui/qt/byte_view_text.h
@@ -69,16 +69,18 @@ protected:
     virtual void contextMenuEvent(QContextMenuEvent *event);
 
 private:
+    // Text highlight modes.
     typedef enum {
-        StateNormal,
-        StateField,
-        StateProtocol,
-        StateOffsetNormal,
-        StateOffsetField
-    } highlight_state;
+        ModeNormal,
+        ModeField,
+        ModeProtocol,
+        ModeOffsetNormal,
+        ModeOffsetField,
+        ModeHover
+    } HighlightMode;
 
     void drawOffsetLine(QPainter &painter, const guint offset, const int row_y);
-    qreal flushOffsetFragment(QPainter &painter, qreal x, int y, highlight_state state, gboolean extra_highlight, QString &text);
+    qreal flushOffsetFragment(QPainter &painter, qreal x, int y, HighlightMode mode, QString &text);
     void scrollToByte(int byte);
     int offsetChars();
     int offsetPixels();