diff options
| author | Gerald Combs <gerald@wireshark.org> | 2014-08-01 16:32:02 -0700 |
|---|---|---|
| committer | Gerald Combs <gerald@wireshark.org> | 2014-08-02 00:50:41 +0000 |
| commit | 69d0788875b81b2cdd0c751f00eb5b20944ffe15 (patch) | |
| tree | 72c5ddb373485c69c25d6c8bbae8b51988e124af /ui/qt/compiled_filter_output.h | |
| parent | 45f3deed0b55177266618b686e388aea4300a7ec (diff) | |
| download | wireshark-69d0788875b81b2cdd0c751f00eb5b20944ffe15.tar.gz | |
CompiledFilterOutput dialog fixes and updates.
Apply a layout to the "Compiled Filter Output" dialog. Render the filter
as monospaced text.
Don't add an "expert OK" icon to the list. It doesn't seem to indicate
any sort of status.
Use a "Close" button instead of "OK". According to
http://uxmovement.com/buttons/why-the-ok-button-is-no-longer-okay/
"OK" implies we're going to perform some sort of action.
Add a "Copy" button while we're here.
Change-Id: Ia63f3032916e322fa9f4f2d465140b128b4f8078
Reviewed-on: https://code.wireshark.org/review/3338
Reviewed-by: Gerald Combs <gerald@wireshark.org>
Diffstat (limited to 'ui/qt/compiled_filter_output.h')
| -rw-r--r-- | ui/qt/compiled_filter_output.h | 4 |
1 files changed, 3 insertions, 1 deletions
diff --git a/ui/qt/compiled_filter_output.h b/ui/qt/compiled_filter_output.h index 3da688d3f7..ba31717655 100644 --- a/ui/qt/compiled_filter_output.h +++ b/ui/qt/compiled_filter_output.h @@ -45,6 +45,7 @@ private: GMutex *pcap_compile_mtx; QHash<QString, QString> compile_results; QListWidget *interface_list_; + QPushButton *copy_bt_; void compileFilter(); public: @@ -53,7 +54,8 @@ public: ~CompiledFilterOutput(); private slots: - void compile_clicked(QListWidgetItem* current, QListWidgetItem* previous); + void on_interfaceList_currentItemChanged(QListWidgetItem *current, QListWidgetItem *previous); + void copyFilterText(); }; #endif // COMPILEDFILTEROUTPUT_H |