diff options
| author | AndersBroman <anders.broman@ericsson.com> | 2016-04-29 15:23:28 +0200 |
|---|---|---|
| committer | Anders Broman <a.broman58@gmail.com> | 2016-05-03 10:17:46 +0000 |
| commit | 6d2ea733ddedf9850883a2dbec43069b92e129bf (patch) | |
| tree | d72fb4c216433f40fad65b22dc54a7dbac69f62c /ui/qt/export_pdu_dialog.cpp | |
| parent | 1489c9e6ff1b98bee792c0cb98eb9e1dc1c1e875 (diff) | |
| download | wireshark-6d2ea733ddedf9850883a2dbec43069b92e129bf.tar.gz | |
Implement Export PDU for tshark
This patch introduces the "-U tap_name[,filter]" tshark option and
is similar to the "Export PDUs as file" option in Wireshark.
Wireshark implements this feature by reopening a capture file, applying
a tap and finally opening the temporary file. Since tshark knows
in advance that a PDU export is needed, it can optimize by not creating
the temporary file and perform the export at the first opportunity.
This patch splits the opening/tapping functionality from error reporting
since tshark does not need a temp file and has no dialogs.
The capture file comment is now specified explicitly as there is no
"current file" anymore if the tap is running without active file.
TODO:
- Review whether it is acceptable to overwrite save_file in tshark.
- Add documentation (tshark manpage).
Bug: 3444
Change-Id: Ie159495d42c32c2ba7400f2991b7b8185b3fda09
Reviewed-on: https://code.wireshark.org/review/5890
Petri-Dish: Anders Broman <a.broman58@gmail.com>
Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org>
Reviewed-by: Anders Broman <a.broman58@gmail.com>
Diffstat (limited to 'ui/qt/export_pdu_dialog.cpp')
| -rw-r--r-- | ui/qt/export_pdu_dialog.cpp | 1 |
1 files changed, 1 insertions, 0 deletions
diff --git a/ui/qt/export_pdu_dialog.cpp b/ui/qt/export_pdu_dialog.cpp index d1f9c30120..7316c680a7 100644 --- a/ui/qt/export_pdu_dialog.cpp +++ b/ui/qt/export_pdu_dialog.cpp @@ -32,6 +32,7 @@ #include <epan/exported_pdu.h> #include "ui/tap_export_pdu.h" +#include "ui/export_pdu_ui_utils.h" ExportPDUDialog::ExportPDUDialog(QWidget *parent) : QDialog(parent), |