InterfaceTree: Change foreach to const_iterator

Change all occurences of the foreach macro to while loops with
const_iterator for performance reasons

Change-Id: I1cd378696136b3d6cc100b9bfff95295baa2ff83
Reviewed-on: https://code.wireshark.org/review/18286
Reviewed-by: Anders Broman <a.broman58@gmail.com>

1 files changed, 14 insertions, 10 deletions

diff --git a/ui/qt/interface_frame.cpp b/ui/qt/interface_frame.cpp
index d79f2c06a3..1e1a140c8b 100644
--- a/ui/qt/interface_frame.cpp
+++ b/ui/qt/interface_frame.cpp
@@ -116,17 +116,21 @@ QMenu * InterfaceFrame::getSelectionMenu()
     QMenu * contextMenu = new QMenu();
     QList<int> typesDisplayed = proxyModel->typesDisplayed();
 
-    foreach(int ifType, ifTypeDescription.keys())
+    QMap<int, QString>::const_iterator it = ifTypeDescription.constBegin();
+    while(it != ifTypeDescription.constEnd())
     {
-        if ( ! typesDisplayed.contains(ifType) )
-            continue;
-
-        QAction *endp_action = new QAction(ifTypeDescription[ifType], this);
-        endp_action->setData(qVariantFromValue(ifType));
-        endp_action->setCheckable(true);
-        endp_action->setChecked(proxyModel->isInterfaceTypeShown(ifType));
-        connect(endp_action, SIGNAL(triggered()), this, SLOT(triggeredIfTypeButton()));
-        contextMenu->addAction(endp_action);
+        int ifType = it.key();
+
+        if ( typesDisplayed.contains(ifType) )
+        {
+            QAction *endp_action = new QAction(it.value(), this);
+            endp_action->setData(qVariantFromValue(ifType));
+            endp_action->setCheckable(true);
+            endp_action->setChecked(proxyModel->isInterfaceTypeShown(ifType));
+            connect(endp_action, SIGNAL(triggered()), this, SLOT(triggeredIfTypeButton()));
+            contextMenu->addAction(endp_action);
+        }
+        ++it;
     }
 
     return contextMenu;